commit 3985a63ea688eecdc0a498b025d42411c34ef177
author Josh Gao <jmgao@google.com> Mon May 08 17:51:07 2017 -0700
committer Josh Gao <jmgao@google.com> Tue May 09 14:30:13 2017 -0700
tree 86f00df03a3f859b7528592fd494246694ce046b
parent 46f981e959d7a14a3a0bc7dce450933bc259fe13

adb: libusb: replace sleep with timed CV wait.

Instead of sleeping for 500ms at the end of every device poll loop, use
a timed condition variable wait so that we can tell the device poll
thread to immediately commit suicide.

Bug: http://b/37869663
Test: adb kill-server; adb start-server
Change-Id: I597071866f7d9ef91900411727345d32c1a97556

adb/client/usb_libusb.cpp

diff --git a/adb/client/usb_libusb.cpp b/adb/client/usb_libusb.cpp
index 15d4b7a..5a65865 100644
--- a/adb/client/usb_libusb.cpp
+++ b/adb/client/usb_libusb.cpp
@@ -152,7 +152,9 @@
 static auto& usb_handles_mutex = *new std::mutex();
 
 static std::thread* device_poll_thread = nullptr;
-static std::atomic<bool> terminate_device_poll_thread(false);
+static bool terminate_device_poll_thread = false;
+static auto& device_poll_mutex = *new std::mutex();
+static auto& device_poll_cv = *new std::condition_variable();
 
 static std::string get_device_address(libusb_device* device) {
     return StringPrintf("usb:%d:%d", libusb_get_bus_number(device),
@@ -376,7 +378,7 @@
 static void poll_for_devices() {
     libusb_device** list;
     adb_thread_setname("device poll");
-    while (!terminate_device_poll_thread) {
+    while (true) {
         const ssize_t device_count = libusb_get_device_list(nullptr, &list);
 
         LOG(VERBOSE) << "found " << device_count << " attached devices";
@@ -389,7 +391,10 @@
 
         adb_notify_device_scan_complete();
 
-        std::this_thread::sleep_for(500ms);
+        std::unique_lock<std::mutex> lock(device_poll_mutex);
+        if (device_poll_cv.wait_for(lock, 500ms, []() { return terminate_device_poll_thread; })) {
+            return;
+        }
     }
 }
 
@@ -412,7 +417,11 @@
     // TODO: Use libusb_hotplug_* instead?
     device_poll_thread = new std::thread(poll_for_devices);
     android::base::at_quick_exit([]() {
-        terminate_device_poll_thread = true;
+        {
+            std::unique_lock<std::mutex> lock(device_poll_mutex);
+            terminate_device_poll_thread = true;
+        }
+        device_poll_cv.notify_all();
         device_poll_thread->join();
     });
 }