Revert "Restrict pmsg use to eng builds."
This reverts commit f894b96a9211dcefb83b175720b53a2e49b8e463.
Kernel binaries have incorporated the performance-enhanced pmsg driver
that has removed the bounce buffer.
Bug: 31057326
Bug: 30375418
Change-Id: Id6cec3ac144f57e8e5465aa48bbdc829cf29e283
diff --git a/liblog/pmsg_writer.c b/liblog/pmsg_writer.c
index b338dca..944feba 100644
--- a/liblog/pmsg_writer.c
+++ b/liblog/pmsg_writer.c
@@ -31,8 +31,6 @@
#include <private/android_filesystem_config.h>
#include <private/android_logger.h>
-#include <sys/system_properties.h>
-
#include "config_write.h"
#include "log_portability.h"
#include "logger.h"
@@ -53,25 +51,8 @@
.write = pmsgWrite,
};
-static bool pmsgShouldUse = false;
-
-// Only use pmsg on eng builds
-static bool pmsgIsEng() {
- char buf[PROP_VALUE_MAX];
-
- if (__system_property_get("ro.build.type", buf) == 0) {
- return false;
- }
-
- if (!strncmp(buf, "eng", sizeof("eng"))) {
- return true;
- }
- return false;
-}
-
static int pmsgOpen()
{
- pmsgShouldUse = pmsgIsEng();
if (pmsgLoggerWrite.context.fd < 0) {
pmsgLoggerWrite.context.fd = TEMP_FAILURE_RETRY(open("/dev/pmsg0", O_WRONLY | O_CLOEXEC));
}
@@ -94,7 +75,7 @@
}
if ((logId != LOG_ID_SECURITY) &&
(logId != LOG_ID_EVENTS) &&
- (!pmsgShouldUse || !__android_log_is_debuggable())) {
+ !__android_log_is_debuggable()) {
return -EINVAL;
}
if (pmsgLoggerWrite.context.fd < 0) {
@@ -124,7 +105,7 @@
size_t i, payloadSize;
ssize_t ret;
- if ((logId == LOG_ID_EVENTS) && (!pmsgShouldUse || !__android_log_is_debuggable())) {
+ if ((logId == LOG_ID_EVENTS) && !__android_log_is_debuggable()) {
if (vec[0].iov_len < 4) {
return -EINVAL;
}