commit 4f0fde2f7d3003c7ad1ccf9ef23d69361069fc01
author Adrian Salido <salidoa@google.com> Tue Jan 03 23:34:37 2017 +0000
committer android-build-merger <android-build-merger@google.com> Tue Jan 03 23:34:37 2017 +0000
tree e5ec0e97b8686655de853c3c8ecf1c4acc577893
parent 1652212b1dc49a31a2fdd3affc4b919eaf027db3
parent 6af4ac24fccff98f35d56f968364d60ccf829354

Merge "init/service.cpp: fix access check for console" am: 4a3b03e9e5 am: 7cc669c493
am: 08cbedfb14

Change-Id: I2b82459bcd305feddce157057c8d1e9f5cf22fc9

init/service.cpp

diff --git a/init/service.cpp b/init/service.cpp
index 7cff348..0f7f62f 100644
--- a/init/service.cpp
+++ b/init/service.cpp
@@ -582,12 +582,15 @@
             console_ = default_console;
         }
 
-        bool have_console = (access(console_.c_str(), R_OK | W_OK) != -1);
-        if (!have_console) {
-            PLOG(ERROR) << "service '" << name_ << "' cannot gain read/write access to console '" << console_ << "'";
+        // Make sure that open call succeeds to ensure a console driver is
+        // properly registered for the device node
+        int console_fd = open(console_.c_str(), O_RDWR | O_CLOEXEC);
+        if (console_fd < 0) {
+            PLOG(ERROR) << "service '" << name_ << "' couldn't open console '" << console_ << "'";
             flags_ |= SVC_DISABLED;
             return false;
         }
+        close(console_fd);
     }
 
     struct stat sb;