commit 52d9edb59008c40d22e4c7a6f74229ce23e2effe
author Nathan Bullock <nathanbullock@google.com> Wed Oct 01 09:31:31 2014 -0400
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Oct 01 19:47:24 2014 +0000
tree 30c6124919aa20719e4faf4a910ffae84c7b4b7c
parent dfea2f8992e9f909634b9af6f1481a6b2f08cdc2

metrics: 'Send' method crashes on NULL ErrorPtr

TEST=manually tested on panther_embedded
BUG=none

Change-Id: Iced380180918839d34a46e1cb2743a4cffdd5b4c
Reviewed-on: https://chromium-review.googlesource.com/220780
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Commit-Queue: Nathan Bullock <nathanbullock@google.com>
Tested-by: Nathan Bullock <nathanbullock@google.com>

metrics/uploader/sender_http.cc

diff --git a/metrics/uploader/sender_http.cc b/metrics/uploader/sender_http.cc
index 585287f..7b5228a 100644
--- a/metrics/uploader/sender_http.cc
+++ b/metrics/uploader/sender_http.cc
@@ -29,7 +29,9 @@
       chromeos::http::Transport::CreateDefault(),
       &error);
   if (!response || response->GetDataAsString() != "OK") {
-    DLOG(ERROR) << "Failed to send data: " << error->GetMessage();
+    if (error) {
+      DLOG(ERROR) << "Failed to send data: " << error->GetMessage();
+    }
     return false;
   }
   return true;