| commit | 69bcbc97ee387b401e124a2fba34541e325f80cf | [log] [tgz] |
|---|---|---|
| author | Elliott Hughes <enh@google.com> | Wed Aug 02 12:57:02 2017 -0700 |
| committer | Elliott Hughes <enh@google.com> | Wed Aug 02 20:32:27 2017 +0000 |
| tree | 321a866243002cf48d5226dfcec00f8ba1febf76 | |
| parent | 6b6ac6fe317727edcca5cfa377a46812377bbba0 [diff] |
Make sure freeaddrinfo is always called on failure. Bug: https://android-review.googlesource.com/#/c/platform/system/core/+/268797/2/libcutils/socket_network_client_unix.c Test: builds Signed-off-by: Ivan Maidanski <i.maidanski@samsung.com> Change-Id: I2d93c8359c3398769d408284f77d56e09713a7f3
diff --git a/libcutils/socket_network_client_unix.c b/libcutils/socket_network_client_unix.c index 37851b1..1b87c49 100644 --- a/libcutils/socket_network_client_unix.c +++ b/libcutils/socket_network_client_unix.c
@@ -63,7 +63,7 @@ for (struct addrinfo* addr = addrs; addr != NULL; addr = addr->ai_next) { // The Mac doesn't have SOCK_NONBLOCK. int s = socket(addr->ai_family, type, addr->ai_protocol); - if (s == -1 || toggle_O_NONBLOCK(s) == -1) return -1; + if (s == -1 || toggle_O_NONBLOCK(s) == -1) break; int rc = connect(s, addr->ai_addr, addr->ai_addrlen); if (rc == 0) {