commit 7c7d18239e3eaee2a42a5d9726a7a4abe355bb7c
author Daniel Colascione <dancol@google.com> Thu Sep 05 00:56:38 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Sep 05 00:56:38 2019 +0000
tree 37983c6b39e4aa14483a51518e9daadc2de6d39f
parent 916d9aa93173a5b28b2f5dd99157aeea49658805
parent 1c4d5b23da98539b68f6bb7c6a749afbc526df26

Merge "Improve codegen slightly when doing FD validity checks"

base/include/android-base/unique_fd.h

diff --git a/base/include/android-base/unique_fd.h b/base/include/android-base/unique_fd.h
index 6e11b4e..1605daf 100644
--- a/base/include/android-base/unique_fd.h
+++ b/base/include/android-base/unique_fd.h
@@ -120,7 +120,7 @@
   // Catch bogus error checks (i.e.: "!fd" instead of "fd != -1").
   bool operator!() const = delete;
 
-  bool ok() const { return get() != -1; }
+  bool ok() const { return get() >= 0; }
 
   int release() __attribute__((warn_unused_result)) {
     tag(fd_, this, nullptr);