commit 9ac51b0991a2a9f00f3b452eec805873781463cd
author Christopher Tate <ctate@google.com> Thu Jun 02 15:08:13 2011 -0700
committer Alex Ray <aray@google.com> Tue Jul 30 13:56:56 2013 -0700
tree 4b097d9b210003b9488256f87779628db52b5001
parent 8deb51e8e492219c72b5f143868958af2ad56459

Implement shared-storage full backup/restore

Every available shared-storage volume is backed up, tagged with its
ordinal in the set of mounted shared volumes.  This is an approximation
of "internal + the external card".  This lets us restore things to the
same volume [or "equivalent" volume, in the case of a cross-model
restore] as they originated on.

Also fixed a bug in the handling of files/dirs with spaces in
their names.

Change-Id: I380019da8d0bb5b3699bd7c11eeff621a88e78c3

libs/utils/BackupHelpers.cpp

diff --git a/libs/utils/BackupHelpers.cpp b/libs/utils/BackupHelpers.cpp
index f933199..b433fd3 100644
--- a/libs/utils/BackupHelpers.cpp
+++ b/libs/utils/BackupHelpers.cpp
@@ -503,10 +503,10 @@
         needExtended = true;
     }
 
-    // Non-7bit-clean path also means needing pax extended format
+    // Non-7bit-clean path or embedded spaces also mean needing pax extended format
     if (!needExtended) {
         for (size_t i = 0; i < filepath.length(); i++) {
-            if ((filepath[i] & 0x80) != 0) {
+            if ((filepath[i] & 0x80) != 0 || filepath[i] == ' ') {
                 needExtended = true;
                 break;
             }