commit 9e72385efa9d2797ad451a96aa4f29445017b266
author Yifan Hong <elsk@google.com> Wed Feb 12 18:20:07 2020 +0000
committer Yifan Hong <elsk@google.com> Mon Mar 09 16:16:33 2020 -0700
tree 4cd59a88007a0b6d2ff1c0b1724373dac64c1dd8
parent 8afb85111ad822acb44c2f77aa27cd6354b06977

Revert "libsnapshot callstack files readable by dumpstate"

This reverts commit faa49d1d0052e074606d88cc56638b573d6e5fb0.

Reason for revert: Callstack should not be logged.

Test: none
Bug: 148818798

Change-Id: Ie5506ae0c7408e255a464b2f403d0a47d272229e

fs_mgr/libsnapshot/snapshot.cpp

diff --git a/fs_mgr/libsnapshot/snapshot.cpp b/fs_mgr/libsnapshot/snapshot.cpp
index ff63f63..7a72e69 100644
--- a/fs_mgr/libsnapshot/snapshot.cpp
+++ b/fs_mgr/libsnapshot/snapshot.cpp
@@ -239,12 +239,7 @@
     LOG(WARNING) << callstack_str.c_str();
     std::stringstream path;
     path << "/data/misc/snapshotctl_log/libsnapshot." << Now() << ".log";
-    std::string path_str = path.str();
-    android::base::WriteStringToFile(callstack_str.c_str(), path_str);
-    if (chmod(path_str.c_str(), 0644) == -1) {
-        PLOG(WARNING) << "Unable to chmod 0644 "
-                      << ", file maybe dropped from bugreport:" << path_str;
-    }
+    android::base::WriteStringToFile(callstack_str.c_str(), path.str());
 #endif
 
     if (!RemoveAllSnapshots(lock)) {