commit 9ee1f5f034e44dd20b3cb229db601eeb1098a3d6
author Ken Mixter <kmixter@chromium.org> Tue Oct 25 02:15:05 2011 +0000
committer Sameer Nanda <snanda@chromium.org> Thu Nov 17 15:19:02 2011 -0800
tree 4a9ac6b4a2e24e3b6bcff043c6cfc902521051f1
parent ce9556e1c490113bf66eaf5bb3f2d9241e209474

crash-reporter: always write kernel crashes for dev builds

Added check for devloper build. Always write kernel crash files when
running devloper builds.

BUG=None
TEST=run "echo bug > /proc/breakme" and ensure the kcrash files get
created under /var/spool/crash

Change-Id: Iced35df9db1f997c41138f082ee50a3506a88eb2
Reviewed-on: https://gerrit.chromium.org/gerrit/10615
Reviewed-by: Sameer Nanda <snanda@chromium.org>
Tested-by: Sameer Nanda <snanda@chromium.org>

crash_reporter/kernel_collector.cc

diff --git a/crash_reporter/kernel_collector.cc b/crash_reporter/kernel_collector.cc
index de4f92d..bdd1dd2 100644
--- a/crash_reporter/kernel_collector.cc
+++ b/crash_reporter/kernel_collector.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -448,11 +448,18 @@
     signature = kDefaultKernelStackSignature;
   }
 
-  bool feedback = is_feedback_allowed_function_();
+  std::string reason = "handling";
+  bool feedback = true;
+  if (IsDeveloperImage()) {
+    reason = "developer build - always dumping";
+    feedback = true;
+  } else if (!is_feedback_allowed_function_()) {
+    reason = "ignoring - no consent";
+    feedback = false;
+  }
 
   LOG(INFO) << "Received prior crash notification from "
-            << "kernel (signature " << signature << ") ("
-            << (feedback ? "handling" : "ignoring - no consent") << ")";
+            << "kernel (signature " << signature << ") (" << reason << ")";
 
   if (feedback) {
     count_crash_function_();