commit 9f817282994f99ac275b2642a1a97565310c9538
author Andreas Huber <andih@google.com> Fri Aug 18 14:43:52 2017 -0700
committer Andreas Huber <andih@google.com> Mon Aug 21 09:44:56 2017 -0700
tree 1fa8fca9e5240e9a48de949262aa119cb9f863a7
parent 7c95c0260c9cfb2b3bbea6aa5ae20b15b844ef67

Fix use-after-free of stack-allocated temporary string.

Bug: 64848081
Test: built and successfully booted again
Merged-In: I93c899249bf2cc5ab8d880c0eaff471518e73121

Change-Id: I93c899249bf2cc5ab8d880c0eaff471518e73121

init/selinux.cpp

diff --git a/init/selinux.cpp b/init/selinux.cpp
index 291b969..c824028 100644
--- a/init/selinux.cpp
+++ b/init/selinux.cpp
@@ -295,13 +295,15 @@
         return false;
     }
     std::string mapping_file("/system/etc/selinux/mapping/" + vend_plat_vers + ".cil");
+    const std::string version_as_string = std::to_string(max_policy_version);
+
     // clang-format off
     const char* compile_args[] = {
         "/system/bin/secilc",
         plat_policy_cil_file,
         "-M", "true", "-G", "-N",
         // Target the highest policy language version supported by the kernel
-        "-c", std::to_string(max_policy_version).c_str(),
+        "-c", version_as_string.c_str(),
         mapping_file.c_str(),
         "/vendor/etc/selinux/nonplat_sepolicy.cil",
         "-o", compiled_sepolicy,