commit a30d340bee3d475544f0d63b1005ff66bd6af70c
author Paul Crowley <paulcrowley@google.com> Tue Jan 30 21:44:10 2018 +0000
committer android-build-merger <android-build-merger@google.com> Tue Jan 30 21:44:10 2018 +0000
tree 109e47b13169f9d05a06daeff691a7a846736399
parent e89de4115aab8f97aca11e07852d21643420050b
parent 0987c2f9a77a303e10ab1f0477c790eff7a333f4

Merge "Don't initialize atrace if it's already disabled."
am: 0e239bbd8b

Change-Id: I3839188718fe70fb6e0bb94aacd2dc8de7612654

libcutils/trace-dev.cpp

diff --git a/libcutils/trace-dev.cpp b/libcutils/trace-dev.cpp
index 4da8215..27255c2 100644
--- a/libcutils/trace-dev.cpp
+++ b/libcutils/trace-dev.cpp
@@ -25,6 +25,7 @@
 void atrace_set_tracing_enabled(bool enabled)
 {
     atomic_store_explicit(&atrace_is_enabled, enabled, memory_order_release);
+    atomic_store_explicit(&atrace_is_ready, false, memory_order_release);
     atrace_update_tags();
 }
 
@@ -34,18 +35,17 @@
     if (atrace_marker_fd == -1) {
         ALOGE("Error opening trace file: %s (%d)", strerror(errno), errno);
         atrace_enabled_tags = 0;
-        goto done;
+        return;
     }
-
     atrace_enabled_tags = atrace_get_property();
-
-done:
-    atomic_store_explicit(&atrace_is_ready, true, memory_order_release);
 }
 
 void atrace_setup()
 {
-    pthread_once(&atrace_once_control, atrace_init_once);
+    if (atomic_load_explicit(&atrace_is_enabled, memory_order_acquire)) {
+        pthread_once(&atrace_once_control, atrace_init_once);
+    }
+    atomic_store_explicit(&atrace_is_ready, true, memory_order_release);
 }
 
 void atrace_begin_body(const char* name)