commit a39b355d3813afc732ef37923cd84c8921c76a76
author Josh Gao <jmgao@google.com> Mon Jul 08 18:05:16 2019 -0700
committer Josh Gao <jmgao@google.com> Mon Jul 08 18:32:24 2019 -0700
tree e74848e033f5edba2ad27914e25236eb4c396ada
parent 1d0d86efa97da2db8d8340d8ae0c5cdcd9d875f5

adb: fdevent: move CheckMainThread logic to fdevent_context.

Test: adb_test
Change-Id: I10b93293af22d54ec739dc0f95c95df3ab082fb6

adb/fdevent/fdevent.cpp

diff --git a/adb/fdevent/fdevent.cpp b/adb/fdevent/fdevent.cpp
index d6e3a66..698b293 100644
--- a/adb/fdevent/fdevent.cpp
+++ b/adb/fdevent/fdevent.cpp
@@ -20,7 +20,9 @@
 
 #include <inttypes.h>
 
+#include <android-base/logging.h>
 #include <android-base/stringprintf.h>
+#include <android-base/threads.h>
 
 #include "fdevent.h"
 #include "fdevent_poll.h"
@@ -46,6 +48,12 @@
                                        state.c_str());
 }
 
+void fdevent_context::CheckMainThread() {
+    if (main_thread_id_) {
+        CHECK_EQ(*main_thread_id_, android::base::GetThreadId());
+    }
+}
+
 void fdevent_context::Run(std::function<void()> fn) {
     {
         std::lock_guard<std::mutex> lock(run_queue_mutex_);

adb/fdevent/fdevent.h

diff --git a/adb/fdevent/fdevent.h b/adb/fdevent/fdevent.h
index 0147ad5..c007e51 100644
--- a/adb/fdevent/fdevent.h
+++ b/adb/fdevent/fdevent.h
@@ -75,8 +75,9 @@
     // Implementations should call FlushRunQueue on every iteration.
     virtual void Loop() = 0;
 
-    // Assert that the caller is running on the context's main thread.
-    virtual void CheckMainThread() = 0;
+    // Assert that the caller is either running on the context's main thread, or that there is no
+    // active main thread.
+    void CheckMainThread();
 
     // Queue an operation to be run on the main thread.
     void Run(std::function<void()> fn);
@@ -92,6 +93,8 @@
     // Run all pending functions enqueued via Run().
     void FlushRunQueue() EXCLUDES(run_queue_mutex_);
 
+    std::optional<uint64_t> main_thread_id_ = std::nullopt;
+
   private:
     std::mutex run_queue_mutex_;
     std::deque<std::function<void()>> run_queue_ GUARDED_BY(run_queue_mutex_);

adb/fdevent/fdevent_poll.cpp

diff --git a/adb/fdevent/fdevent_poll.cpp b/adb/fdevent/fdevent_poll.cpp
index f786337..8a12162 100644
--- a/adb/fdevent/fdevent_poll.cpp
+++ b/adb/fdevent/fdevent_poll.cpp
@@ -75,16 +75,9 @@
 }
 
 fdevent_context_poll::~fdevent_context_poll() {
-    main_thread_valid_ = false;
     this->Destroy(this->interrupt_fde_);
 }
 
-void fdevent_context_poll::CheckMainThread() {
-    if (main_thread_valid_) {
-        CHECK_EQ(main_thread_id_, android::base::GetThreadId());
-    }
-}
-
 fdevent* fdevent_context_poll::Create(unique_fd fd, std::variant<fd_func, fd_func2> func,
                                       void* arg) {
     CheckMainThread();
@@ -373,13 +366,12 @@
 }
 
 void fdevent_context_poll::Loop() {
-    this->main_thread_id_ = android::base::GetThreadId();
-    this->main_thread_valid_ = true;
+    main_thread_id_ = android::base::GetThreadId();
 
     uint64_t cycle = 0;
     while (true) {
         if (terminate_loop_) {
-            return;
+            break;
         }
 
         D("--- --- waiting for events");
@@ -396,6 +388,8 @@
 
         this->FlushRunQueue();
     }
+
+    main_thread_id_.reset();
 }
 
 void fdevent_context_poll::TerminateLoop() {

adb/fdevent/fdevent_poll.h

diff --git a/adb/fdevent/fdevent_poll.h b/adb/fdevent/fdevent_poll.h
index 1b505a7..b0465b9 100644
--- a/adb/fdevent/fdevent_poll.h
+++ b/adb/fdevent/fdevent_poll.h
@@ -58,8 +58,6 @@
 
     virtual void Loop() final;
 
-    virtual void CheckMainThread() final;
-
     virtual void TerminateLoop() final;
     virtual size_t InstalledCount() final;
 
@@ -71,8 +69,6 @@
     // That's why we don't need a lock for fdevent.
     std::unordered_map<int, PollNode> poll_node_map_;
     std::list<fdevent*> pending_list_;
-    bool main_thread_valid_ = false;
-    uint64_t main_thread_id_ = 0;
     uint64_t fdevent_id_ = 0;
 
     unique_fd interrupt_fd_;