commit bae32ec5c20bacbabdb75600d867c5ead0115aeb
author Yi Kong <yikong@google.com> Thu Mar 01 17:48:53 2018 -0500
committer Yi Kong <yikong@google.com> Thu Mar 01 22:54:08 2018 +0000
tree 33a1cb2ac86704f21d57cc46cb0f780d61ad21ff
parent 7e83e04c732303706b2f1313e6931a3e8598f2ea

Remove unreachable condition

Comparison of unsigned enum expression < 0 is always false. Fixes
tautological-unsigned-enum-zero-compare warning.

Bug: 72331526
Test: m
Change-Id: I17eb218b256015f5f406fd24324a49b05a0e8866

logd/LogBuffer.cpp

diff --git a/logd/LogBuffer.cpp b/logd/LogBuffer.cpp
index 560f490..b8af2f0 100644
--- a/logd/LogBuffer.cpp
+++ b/logd/LogBuffer.cpp
@@ -198,7 +198,7 @@
 
 int LogBuffer::log(log_id_t log_id, log_time realtime, uid_t uid, pid_t pid,
                    pid_t tid, const char* msg, unsigned short len) {
-    if ((log_id >= LOG_ID_MAX) || (log_id < 0)) {
+    if (log_id >= LOG_ID_MAX) {
         return -EINVAL;
     }