commit c60e4e8008ed0a0cdf7b3ed1e5f9863b1e6f3540
author Sandeep Patil <sspatil@google.com> Mon Jul 15 17:29:33 2019 -0700
committer Sandeep Patil <sspatil@google.com> Tue Jul 30 14:40:24 2019 -0700
tree 620462a0dc29e8cf6b433f77cbfd9fc386df9283
parent 5b6d594bcecc01c0e1f70681acc341ff5a4d3b68

libion: Add missing error checks for input parameters to APIs.

The errors were caught by ion-unit-tests. Make sure we fix them before
we start running the tests in automation etc.

Bug: 133508579
Test: ion-unit-tests

Change-Id: I7ebecfa037767481ee7f2b30e2923c84ebc352bf
Signed-off-by: Sandeep Patil <sspatil@google.com>

libion/ion.c

diff --git a/libion/ion.c b/libion/ion.c
index b8de5a4..1ecfc78 100644
--- a/libion/ion.c
+++ b/libion/ion.c
@@ -152,6 +152,8 @@
     ion_user_handle_t handle;
     int ret;
 
+    if (!handle_fd) return -EINVAL;
+
     if (!ion_is_legacy(fd)) {
         struct ion_new_allocation_data data = {
             .len = len,
@@ -201,6 +203,7 @@
     int ret;
     struct ion_heap_query query;
 
+    if (!cnt) return -EINVAL;
     memset(&query, 0, sizeof(query));
 
     ret = ion_ioctl(fd, ION_IOC_HEAP_QUERY, &query);