commit c6e7b53074e368f4d3c8936fe978270986f08ac1
author Elliott Hughes <enh@google.com> Sat Sep 12 03:16:51 2015 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Sat Sep 12 03:16:51 2015 +0000
tree 9984881d38254299d0c93cf3ec9bbb84ca743858
parent f27fd0a8651365b3e92ea048f75854b21aa01ba6
parent 585a127cdbb9ced6eb38ace690124e2f97854518

Merge "libbase_test: get it building for Windows"

base/Android.mk

diff --git a/base/Android.mk b/base/Android.mk
index ebc2e07..613636b 100644
--- a/base/Android.mk
+++ b/base/Android.mk
@@ -98,6 +98,7 @@
 
 include $(CLEAR_VARS)
 LOCAL_MODULE := libbase_test
+LOCAL_MODULE_HOST_OS := darwin linux windows
 LOCAL_SRC_FILES := $(libbase_test_src_files)
 LOCAL_C_INCLUDES := $(LOCAL_PATH)
 LOCAL_CPPFLAGS := $(libbase_cppflags)

base/parseint_test.cpp

diff --git a/base/parseint_test.cpp b/base/parseint_test.cpp
index 6a109f4..e19c6e3 100644
--- a/base/parseint_test.cpp
+++ b/base/parseint_test.cpp
@@ -20,49 +20,49 @@
 
 TEST(parseint, signed_smoke) {
   int i;
-  ASSERT_EQ(false, android::base::ParseInt("x", &i));
-  ASSERT_EQ(false, android::base::ParseInt("123x", &i));
+  ASSERT_FALSE(android::base::ParseInt("x", &i));
+  ASSERT_FALSE(android::base::ParseInt("123x", &i));
 
-  ASSERT_EQ(true, android::base::ParseInt("123", &i));
+  ASSERT_TRUE(android::base::ParseInt("123", &i));
   ASSERT_EQ(123, i);
-  ASSERT_EQ(true, android::base::ParseInt("-123", &i));
+  ASSERT_TRUE(android::base::ParseInt("-123", &i));
   ASSERT_EQ(-123, i);
 
   short s;
-  ASSERT_EQ(true, android::base::ParseInt("1234", &s));
+  ASSERT_TRUE(android::base::ParseInt("1234", &s));
   ASSERT_EQ(1234, s);
 
-  ASSERT_EQ(true, android::base::ParseInt("12", &i, 0, 15));
+  ASSERT_TRUE(android::base::ParseInt("12", &i, 0, 15));
   ASSERT_EQ(12, i);
-  ASSERT_EQ(false, android::base::ParseInt("-12", &i, 0, 15));
-  ASSERT_EQ(false, android::base::ParseInt("16", &i, 0, 15));
+  ASSERT_FALSE(android::base::ParseInt("-12", &i, 0, 15));
+  ASSERT_FALSE(android::base::ParseInt("16", &i, 0, 15));
 }
 
 TEST(parseint, unsigned_smoke) {
   unsigned int i;
-  ASSERT_EQ(false, android::base::ParseUint("x", &i));
-  ASSERT_EQ(false, android::base::ParseUint("123x", &i));
+  ASSERT_FALSE(android::base::ParseUint("x", &i));
+  ASSERT_FALSE(android::base::ParseUint("123x", &i));
 
-  ASSERT_EQ(true, android::base::ParseUint("123", &i));
+  ASSERT_TRUE(android::base::ParseUint("123", &i));
   ASSERT_EQ(123u, i);
-  ASSERT_EQ(false, android::base::ParseUint("-123", &i));
+  ASSERT_FALSE(android::base::ParseUint("-123", &i));
 
   unsigned short s;
-  ASSERT_EQ(true, android::base::ParseUint("1234", &s));
+  ASSERT_TRUE(android::base::ParseUint("1234", &s));
   ASSERT_EQ(1234u, s);
 
-  ASSERT_EQ(true, android::base::ParseUint("12", &i, 15u));
+  ASSERT_TRUE(android::base::ParseUint("12", &i, 15u));
   ASSERT_EQ(12u, i);
-  ASSERT_EQ(false, android::base::ParseUint("-12", &i, 15u));
-  ASSERT_EQ(false, android::base::ParseUint("16", &i, 15u));
+  ASSERT_FALSE(android::base::ParseUint("-12", &i, 15u));
+  ASSERT_FALSE(android::base::ParseUint("16", &i, 15u));
 }
 
 TEST(parseint, no_implicit_octal) {
   int i;
-  ASSERT_EQ(true, android::base::ParseInt("0123", &i));
+  ASSERT_TRUE(android::base::ParseInt("0123", &i));
   ASSERT_EQ(123, i);
 
   unsigned int u;
-  ASSERT_EQ(true, android::base::ParseUint("0123", &u));
+  ASSERT_TRUE(android::base::ParseUint("0123", &u));
   ASSERT_EQ(123u, u);
 }