commit d86678c81d86cea028b145bb848252e92a98d7e1
author Rajeev Kumar <rajekumar@google.com> Fri Mar 09 15:20:56 2018 -0800
committer Rajeev Kumar <rajekumar@google.com> Mon Mar 26 18:15:25 2018 +0000
tree 2a57d92fabb00fff99a7f5128436b058cb92ffab
parent cb69a1c0528830e3ca880d56635b77aec1292a91

Fix compilation issue when LMKD_LOG_STATS is defined.

Note: The breakage was caused by http://ag/3621623

Test: mmma system/core/lmkd/
Change-Id: I17033aeedb3183d4777dacb89ec84430ff061b3c
Bug: 74443701
(cherry picked from commit fb25ddd9c9004de9a9ebb1175a6ceaf7aeec0673)

lmkd/lmkd.c

diff --git a/lmkd/lmkd.c b/lmkd/lmkd.c
index 1d8afb4..e2e5c4e 100644
--- a/lmkd/lmkd.c
+++ b/lmkd/lmkd.c
@@ -1201,7 +1201,7 @@
         (unsigned long)property_get_int32("ro.lmk.kill_timeout_ms", 0);
 
 #ifdef LMKD_LOG_STATS
-    statlog_init();
+    statslog_init(&log_ctx, &enable_stats_log);
 #endif
 
     // MCL_ONFAULT pins pages as they fault instead of loading
@@ -1221,7 +1221,7 @@
         mainloop();
 
 #ifdef LMKD_LOG_STATS
-    statslog_destroy();
+    statslog_destroy(&log_ctx);
 #endif
 
     ALOGI("exiting");

lmkd/statslog.h

diff --git a/lmkd/statslog.h b/lmkd/statslog.h
index b567fbf..4cde840 100644
--- a/lmkd/statslog.h
+++ b/lmkd/statslog.h
@@ -17,6 +17,7 @@
 #ifndef _STATSLOG_H_
 #define _STATSLOG_H_
 
+#include <assert.h>
 #include <stdbool.h>
 #include <sys/cdefs.h>
 
@@ -34,17 +35,26 @@
 #define LMK_STATE_CHANGE_START 1
 #define LMK_STATE_CHANGE_STOP 2
 
-static inline void statslog_init() {
-    enable_stats_log = property_get_bool("ro.lmk.log_stats", false);
+/*
+ * The single event tag id for all stats logs.
+ * Keep this in sync with system/core/logcat/event.logtags
+ */
+const static int kStatsEventTag = 1937006964;
 
-    if (enable_stats_log) {
-        log_ctx = create_android_logger(kStatsEventTag);
+static inline void statslog_init(android_log_context* log_ctx, bool* enable_stats_log) {
+    assert(log_ctx != NULL);
+    assert(enable_stats_log != NULL);
+    *enable_stats_log = property_get_bool("ro.lmk.log_stats", false);
+
+    if (*enable_stats_log) {
+        *log_ctx = create_android_logger(kStatsEventTag);
     }
 }
 
-static inline void statslog_destroy() {
-    if (log_ctx) {
-        android_log_destroy(&log_ctx);
+static inline void statslog_destroy(android_log_context* log_ctx) {
+    assert(log_ctx != NULL);
+    if (*log_ctx) {
+        android_log_destroy(log_ctx);
     }
 }
 
@@ -58,12 +68,6 @@
 
 #define MEMCG_PROCESS_MEMORY_STAT_PATH "/dev/memcg/apps/uid_%u/pid_%u/memory.stat"
 
-/*
- * The single event tag id for all stats logs.
- * Keep this in sync with system/core/logcat/event.logtags
- */
-const static int kStatsEventTag = 1937006964;
-
 /**
  * Logs the change in LMKD state which is used as start/stop boundaries for logging
  * LMK_KILL_OCCURRED event.