commit ed983c5bcbe42ca8a4f9dca173f239e1db430e79
author Yabin Cui <yabinc@google.com> Wed Feb 10 04:34:52 2016 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Feb 10 04:34:53 2016 +0000
tree c95d3a5682d920bef245e45ed2d6c55c97f7e2a1
parent c14e686ed879846331d9b867037acf6ba44b97c7
parent 88e2c38bd0d50cce3c7c4f9e19c6250fc375c3d6

Merge "adb: setsid() for adb host server."

adb/adb.cpp

diff --git a/adb/adb.cpp b/adb/adb.cpp
index 58ccd0a..cb54d04 100644
--- a/adb/adb.cpp
+++ b/adb/adb.cpp
@@ -883,8 +883,6 @@
             fprintf(stderr, "ADB server didn't ACK\n" );
             return -1;
         }
-
-        setsid();
     }
 #endif /* !defined(_WIN32) */
     return 0;

adb/client/main.cpp

diff --git a/adb/client/main.cpp b/adb/client/main.cpp
index 6397c52..27b7109 100644
--- a/adb/client/main.cpp
+++ b/adb/client/main.cpp
@@ -127,10 +127,12 @@
         setup_daemon_logging();
 
 #if !defined(_WIN32)
-        // Set the process group so that ctrl-c in the spawning process doesn't kill us.
-        // Do this here instead of after the fork so that a ctrl-c between the "starting server" and
-        // "done starting server" messages gets a chance to terminate the server.
-        setpgrp();
+        // Start a new session for the daemon. Do this here instead of after the fork so
+        // that a ctrl-c between the "starting server" and "done starting server" messages
+        // gets a chance to terminate the server.
+        if (setsid() == -1) {
+            fatal("setsid() failed: %s", strerror(errno));
+        }
 #endif
 
         // Any error output written to stderr now goes to adb.log. We could