commit f216cea61e5c1a3d8746a40397a7b7ec7a275398
author Mark Salyzyn <salyzyn@google.com> Tue Feb 21 23:10:58 2017 +0000
committer android-build-merger <android-build-merger@google.com> Tue Feb 21 23:10:58 2017 +0000
tree a12a5927a0ac7a3d232bf48fb99fe01e73c9ee9a
parent 1a8bd5f5807a01739be3ef45cecf7819375c398f
parent 9a8e2ae900363ec2cc6152eca10da1f7dac8f199

Merge "liblog: Harden log_id check."
am: c280143d9b

Change-Id: I2a87f95287be7ee8009cc9c56c7bbc82f1673b99

liblog/logd_reader.c

diff --git a/liblog/logd_reader.c b/liblog/logd_reader.c
index ccc7da8..a6c3f7a 100644
--- a/liblog/logd_reader.c
+++ b/liblog/logd_reader.c
@@ -91,7 +91,7 @@
 
 static int logdAvailable(log_id_t logId)
 {
-    if (logId > LOG_ID_KERNEL) {
+    if (logId >= LOG_ID_MAX) {
         return -EINVAL;
     }
     if (logId == LOG_ID_SECURITY) {

liblog/logd_writer.c

diff --git a/liblog/logd_writer.c b/liblog/logd_writer.c
index 2bab92e..12b797d 100644
--- a/liblog/logd_writer.c
+++ b/liblog/logd_writer.c
@@ -117,7 +117,7 @@
 
 static int logdAvailable(log_id_t logId)
 {
-    if (logId > LOG_ID_SECURITY) {
+    if (logId >= LOG_ID_MAX || logId == LOG_ID_KERNEL) {
         return -EINVAL;
     }
     if (atomic_load(&logdLoggerWrite.context.sock) < 0) {