commit 15749e0edc083ca9d4a6e6ac15b75978a9682731
author Yabin Cui <yabinc@google.com> Wed May 30 16:37:06 2018 -0700
committer Yabin Cui <yabinc@google.com> Wed May 30 16:37:06 2018 -0700
tree d04924e1f5307dc2ac499e7c506849fc9b0fcaa5
parent 600eab5ee11b692c8c35a616b7a4e2c4397487b9

simpleperf: add a missing null check.

Bug: none.
Test: run simpleperf_unit_test.
Change-Id: I206c9c67cd96025956246c1bd080653f532a9112

simpleperf/dso_test.cpp

diff --git a/simpleperf/dso_test.cpp b/simpleperf/dso_test.cpp
index 175ce1d..75d4c85 100644
--- a/simpleperf/dso_test.cpp
+++ b/simpleperf/dso_test.cpp
@@ -81,6 +81,11 @@
     ASSERT_STREQ(symbol->DemangledName(),
                  "com.example.simpleperf.simpleperfexamplewithnative.MixActivity$1.run");
     ASSERT_EQ(0u, dso->MinVirtualAddress());
+
+    // Don't crash on not exist zip entry.
+    dso = Dso::CreateDso(dso_type, GetTestData("base.zip!/not_exist_entry"));
+    ASSERT_TRUE(dso);
+    ASSERT_EQ(nullptr, dso->FindSymbol(0));
   }
 #else
   GTEST_LOG_(INFO) << "This test only runs on linux because of libdexfile";