Use -Werror in system/extras
* Remove unused variables.
* Fix redefined macro warnings.
* Fix sign-compare warnings.
* Fix 'return false' in main().
* Keep existing warnings to fix later.
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ib92ef5297693595fb84ed4f8e61665bda4cee312
diff --git a/crypto-perf/Android.mk b/crypto-perf/Android.mk
index 291aca1..4a3cbe4 100644
--- a/crypto-perf/Android.mk
+++ b/crypto-perf/Android.mk
@@ -2,7 +2,7 @@
ifeq ($(TARGET_ARCH),arm64)
include $(CLEAR_VARS)
-LOCAL_CFLAGS := -O0 -march=armv8-a+crypto
+LOCAL_CFLAGS := -O0 -march=armv8-a+crypto -Wall -Werror
LOCAL_SRC_FILES := crypto.cpp
LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
diff --git a/crypto-perf/crypto.cpp b/crypto-perf/crypto.cpp
index 2cd2709..c186076 100644
--- a/crypto-perf/crypto.cpp
+++ b/crypto-perf/crypto.cpp
@@ -121,7 +121,7 @@
CPU_SET(cmd_data.cpu_to_lock, &cpuset);
if (sched_setaffinity(0, sizeof(cpuset), &cpuset) != 0) {
perror("sched_setaffinity failed");
- return false;
+ return 1;
}
gettimeofday(&begin_time, NULL);
while (count < MAX_COUNT) {