Refactor Update operation to return amount of input consumed.
Per the keymaster "update" API documentation, implementations need not
consume all provided input, and must return information about how much
they did consume, so the caller knows to resend the unprocessed portion.
It's convenient for the AES OCB mode encryption to sometimes process
less than is provided, but the Update operation interfaces didn't
account for not consuming all data.
This change was already reviewed, merged and reverted, so I'm skipping
the review step this time.
Change-Id: Ida401453a6af6c751ea7093e283a101bd8527709
diff --git a/rsa_operation.h b/rsa_operation.h
index fb417a7..7ffbbce 100644
--- a/rsa_operation.h
+++ b/rsa_operation.h
@@ -33,11 +33,11 @@
~RsaOperation();
virtual keymaster_error_t Begin() { return KM_ERROR_OK; }
- virtual keymaster_error_t Update(const Buffer& input, Buffer* output);
+ virtual keymaster_error_t Update(const Buffer& input, Buffer* output, size_t* input_consumed);
virtual keymaster_error_t Abort() { return KM_ERROR_OK; }
protected:
- keymaster_error_t StoreData(const Buffer& input);
+ keymaster_error_t StoreData(const Buffer& input, size_t* input_consumed);
RSA* rsa_key_;
keymaster_padding_t padding_;