Gitiles
Code Review Sign In
review.blissroms.org / platform_system_libhwbinder / abaa7629b2303056e14fb735794a0fcfc2317a81
commitabaa7629b2303056e14fb735794a0fcfc2317a81[log] [tgz]
authorChristopher Tate <ctate@google.com>Mon Jun 08 14:45:14 2015 -0700
committerChristopher Tate <ctate@google.com>Mon Jun 08 14:49:09 2015 -0700
tree02dd82c10959209ca369bf728b9ab68749f82ec7
parent78183cc65c3a7bd267c570b371ee5ce3f4b5d63d [diff]
Prevent integer overflow when calculating buffer resizes

Make sure that we don't go haywire if an exponential buffer growth
operation winds up wrapping integer range.  Along the way, fix a
bookkeeping bug in BufferedTextOutput that would cause it to keep
spuriously realloc()ing on every append().

Bug 20674694

Change-Id: Ia845b7de36b90672a151a918ffc26c7da68e20a2
2 files changed
tree: 02dd82c10959209ca369bf728b9ab68749f82ec7
  1. include/
  2. tests/
  3. Android.mk
  4. AppOpsManager.cpp
  5. Binder.cpp
  6. BpBinder.cpp
  7. BufferedTextOutput.cpp
  8. Debug.cpp
  9. IAppOpsCallback.cpp
  10. IAppOpsService.cpp
  11. IBatteryStats.cpp
  12. IInterface.cpp
  13. IMemory.cpp
  14. IPCThreadState.cpp
  15. IPermissionController.cpp
  16. IProcessInfoService.cpp
  17. IServiceManager.cpp
  18. MemoryBase.cpp
  19. MemoryDealer.cpp
  20. MemoryHeapBase.cpp
  21. Parcel.cpp
  22. PermissionCache.cpp
  23. ProcessInfoService.cpp
  24. ProcessState.cpp
  25. Static.cpp
  26. TextOutput.cpp