| commit | 17b7758713dc38fc9f47540954985807a1d928ad | [log] [tgz] |
|---|---|---|
| author | Tom Cherry <tomcherry@google.com> | Wed Jun 17 11:40:55 2020 -0700 |
| committer | Tom Cherry <tomcherry@google.com> | Wed Jun 17 11:40:55 2020 -0700 |
| tree | 5e6f561deeff47e7b3bdd1389a3869c82f6a9388 | |
| parent | 6d9fc7f99fe4d005df8d262a851721072f7ca724 [diff] |
logd: fix various clang-tidy issues In order of severity: 1) Add a CHECK() that a pointer is not nullptr, where the analyzer believes this is possible. 2) Add `final` appropriately to functions called from constructors. 3) Add missing cloexec flags. 4) Add missing `noexcept` and other subtle performance warnings Test: build with clang-tidy Change-Id: Ifd9a1299a51027a47382926b2224748b5750d6cf