tree 9b1587fb4d4f1842138d2e43b4e65f9b96f6faf9
parent 76b3a64c54ac819c87eb0a4e5f7d2bf2987f0bbe
author Amin Hassani <ahassani@chromium.org> 1606783559 -0800
committer Commit Bot <commit-bot@chromium.org> 1606861395 +0000

update_engine: Make SystemState pointer static only

The style guide does not allow a global object with non-trivial dtor. It
can cause hidden problems and it has caused issue this CL is
fixing (look at the attached bug). Instead of keeping the ownership of
the SystemState in global, we can keep the ownership in the high level
object DaemonChromeOS and keep a global static pointer to it so it can
easily be accessed by SystemState::Get().

BUG=b:174212887
TEST=cros_workon_make --board reef --test update_engine
TEST=cros deploy + stop update-engine -> The update_engine did not crash anymore.

Change-Id: I442f4220bfd8586c59fcdfd7d699776362143467
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2566875
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Commit-Queue: Amin Hassani <ahassani@chromium.org>