commit ad3a57032af7683282f2af49e1a782076e1a41e8
author Michael Bestas <mkbestas@lineageos.org> Thu Aug 24 00:00:48 2017 +0300
committer Michael Bestas <mkbestas@lineageos.org> Sun Aug 27 12:39:42 2017 +0000
tree b4b892d6504bddaca035decfa78ac66373c39469
parent af3532bef551ca210c3908ca735a10e0a052cc92

lineage/aosp/cafremote: Make variables local

* Certain order of running these commands on different repos can
  end up producing broken remotes, because the variables are
  exported globally (looking at you PFX)

Change-Id: I0b679f04264d964ed9a0f0d1adfdbaeac9403ec8

build/envsetup.sh

diff --git a/build/envsetup.sh b/build/envsetup.sh
index 59e9d9d..530d5dc 100644
--- a/build/envsetup.sh
+++ b/build/envsetup.sh
@@ -266,13 +266,13 @@
         return 1
     fi
     git remote rm lineage 2> /dev/null
-    GERRIT_REMOTE=$(git config --get remote.github.projectname)
+    local GERRIT_REMOTE=$(git config --get remote.github.projectname)
     if [ -z "$GERRIT_REMOTE" ]
     then
-        GERRIT_REMOTE=$(git config --get remote.aosp.projectname | sed s#platform/#android/#g | sed s#/#_#g)
-        PFX="LineageOS/"
+        local GERRIT_REMOTE=$(git config --get remote.aosp.projectname | sed s#platform/#android/#g | sed s#/#_#g)
+        local PFX="LineageOS/"
     fi
-    LINEAGE_USER=$(git config --get review.review.lineageos.org.username)
+    local LINEAGE_USER=$(git config --get review.review.lineageos.org.username)
     if [ -z "$LINEAGE_USER" ]
     then
         git remote add lineage ssh://review.lineageos.org:29418/$PFX$GERRIT_REMOTE
@@ -290,10 +290,10 @@
         return 1
     fi
     git remote rm aosp 2> /dev/null
-    PROJECT=$(pwd -P | sed -e "s#$ANDROID_BUILD_TOP\/##; s#-caf.*##; s#\/default##")
+    local PROJECT=$(pwd -P | sed -e "s#$ANDROID_BUILD_TOP\/##; s#-caf.*##; s#\/default##")
     if (echo $PROJECT | grep -qv "^device")
     then
-        PFX="platform/"
+        local PFX="platform/"
     fi
     git remote add aosp https://android.googlesource.com/$PFX$PROJECT
     echo "Remote 'aosp' created"
@@ -307,10 +307,10 @@
         return 1
     fi
     git remote rm caf 2> /dev/null
-    PROJECT=$(pwd -P | sed -e "s#$ANDROID_BUILD_TOP\/##; s#-caf.*##; s#\/default##")
+    local PROJECT=$(pwd -P | sed -e "s#$ANDROID_BUILD_TOP\/##; s#-caf.*##; s#\/default##")
     if (echo $PROJECT | grep -qv "^device")
     then
-        PFX="platform/"
+        local PFX="platform/"
     fi
     git remote add caf https://source.codeaurora.org/quic/la/$PFX$PROJECT
     echo "Remote 'caf' created"