Initialize the ChromeBrowserProxyResolver only once.
The ChromeBrowserProxyResolver instance was being initialized on every
update check, making it register a listener for the proxy resolved
signal on each update, calling the callback multiple times.
Only the first time the callback is called will actually do something,
and the rest of the calls will only log an error message and return.
This patch removes the error message by registering the callback only once.
Bug: None
TEST=emerge-link update_engine; deployed on a link and ran several update checks.
Change-Id: I8a64fdf168966a895080760b8a95f9d8bf27976c
diff --git a/update_attempter.cc b/update_attempter.cc
index 461d10d..5704731 100644
--- a/update_attempter.cc
+++ b/update_attempter.cc
@@ -155,6 +155,8 @@
status_ = UpdateStatus::UPDATED_NEED_REBOOT;
else
status_ = UpdateStatus::IDLE;
+
+ chrome_proxy_resolver_.Init();
}
void UpdateAttempter::ScheduleUpdates() {
@@ -256,7 +258,6 @@
if (forced_update_pending_callback_.get())
forced_update_pending_callback_->Run(false, false);
- chrome_proxy_resolver_.Init();
fake_update_success_ = false;
if (status_ == UpdateStatus::UPDATED_NEED_REBOOT) {
// Although we have applied an update, we still want to ping Omaha