commit 9c4f79378567cd05d2a87626c22686b5d5c33d38
author Quinn Male <qmale@codeaurora.org> Tue Apr 21 16:15:03 2020 -0700
committer Quinn Male <qmale@codeaurora.org> Tue Apr 21 16:48:49 2020 -0700
tree 3bf4c65ddd7bacb503e13d66e8df6b1a10092008
parent cb7fba765978fe1a29156eae0047d79fd2525d3d

st-hal: Prevent st_device callback handling before initialization

Sometimes a callback from audio hal while sthal is not yet
initialized from framework is causing crash in accessing
uninitialized sthal parameters. Synchronize callback from
audio hal with sthal initialization.

Change-Id: I35a012666ca7c8215b5bd30cac17780e2415d7da

sound_trigger_hw.c

diff --git a/sound_trigger_hw.c b/sound_trigger_hw.c
index 1eb7f40..21f968e 100644
--- a/sound_trigger_hw.c
+++ b/sound_trigger_hw.c
@@ -2558,7 +2558,8 @@
 
 static int stdev_close(hw_device_t *device)
 {
-    struct sound_trigger_device *stdev = (struct sound_trigger_device *)device;
+    struct sound_trigger_device *st_device =
+        (struct sound_trigger_device *)device;
     st_session_t *st_session = NULL;
     struct listnode *node = NULL, *tmp_node = NULL;
     int status = 0;
@@ -2567,18 +2568,18 @@
     ATRACE_BEGIN("sthal: stdev_close");
 
     pthread_mutex_lock(&stdev_init_lock);
-    if (!stdev || (--stdev_ref_cnt != 0)) {
+    if (!st_device || (--stdev_ref_cnt != 0)) {
         goto exit;
     }
 
-    pthread_mutex_lock(&stdev->lock);
+    pthread_mutex_lock(&st_device->lock);
     sthw_extn_lpma_deinit();
-    platform_stdev_deinit(stdev->platform);
-    free(stdev->arm_pcm_use_cases);
-    free(stdev->ape_pcm_use_cases);
-    free(stdev->dev_ref_cnt);
-    free(stdev->dev_enable_cnt);
-    list_for_each_safe(node, tmp_node, &stdev->sound_model_list) {
+    platform_stdev_deinit(st_device->platform);
+    free(st_device->arm_pcm_use_cases);
+    free(st_device->ape_pcm_use_cases);
+    free(st_device->dev_ref_cnt);
+    free(st_device->dev_enable_cnt);
+    list_for_each_safe(node, tmp_node, &st_device->sound_model_list) {
         st_session = node_to_item(node, st_session_t, list_node);
         list_remove(node);
         st_session_stop_lab(st_session);
@@ -2591,28 +2592,29 @@
         free(st_session);
     }
 
-    pthread_mutex_unlock(&stdev->lock);
+    pthread_mutex_unlock(&st_device->lock);
     hw_session_notifier_deinit();
 
-    if (stdev->transit_to_adsp_on_playback ||
-        stdev->transit_to_adsp_on_battery_charging) {
-        stdev->stop_transitions_thread_loop = true;
-        pthread_cond_signal(&stdev->transitions_cond);
-        status = pthread_join(stdev->transitions_thread, NULL);
+    if (st_device->transit_to_adsp_on_playback ||
+        st_device->transit_to_adsp_on_battery_charging) {
+        st_device->stop_transitions_thread_loop = true;
+        pthread_cond_signal(&st_device->transitions_cond);
+        status = pthread_join(st_device->transitions_thread, NULL);
         if (status)
             ALOGE("%s: Error joining transitions thread. status = %d",
                 __func__, status);
     }
 
-    pthread_mutex_destroy(&stdev->lock);
-    pthread_mutex_destroy(&stdev->ref_cnt_lock);
+    pthread_mutex_destroy(&st_device->lock);
+    pthread_mutex_destroy(&st_device->ref_cnt_lock);
     free(device);
     stdev = NULL;
 
 exit:
     pthread_mutex_unlock(&stdev_init_lock);
     ATRACE_END();
-    ALOGD("%s: Exit device=%p cnt=%d ", __func__, stdev, stdev_ref_cnt);
+    ALOGD("%s: Exit device=%p cnt=%d ", __func__, st_device,
+        stdev_ref_cnt);
     return 0;
 }
 
@@ -2854,8 +2856,11 @@
     st_exec_mode_t exec_mode = 0;
     sound_model_handle_t sm_handle = 0;
 
-    if (!stdev)
+    pthread_mutex_lock(&stdev_init_lock);
+    if (!stdev) {
+        pthread_mutex_unlock(&stdev_init_lock);
         return -ENODEV;
+    }
 
     switch (event) {
     case AUDIO_EVENT_PLAYBACK_STREAM_INACTIVE:
@@ -3091,6 +3096,7 @@
         break;
     }
 
+    pthread_mutex_unlock(&stdev_init_lock);
     return ret;
 }