commit 1dad831abe8395b7d0399f1e73ebd75b3274ed4b
author Ashwanth Goli <ashwanth@codeaurora.org> Fri Dec 16 15:09:23 2016 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Sun Jan 08 18:52:11 2017 -0800
tree a4fa46157d6c59ad6ca884763cc21089089565aa
parent 45fa28f6dbcf91514d1dcfbddd2333d9d34718cf

dataservices: Changes to prevent double free

Changes to prevent double free of the response and request buffers.

CRs-Fixed: 1102958
Change-Id: Ibbcb75f3e4389cae669c684237a8a0df973f4d06
Signed-off-by: Ashwanth Goli <ashwanth@codeaurora.org>

rmnetctl/src/librmnetctl.c

diff --git a/rmnetctl/src/librmnetctl.c b/rmnetctl/src/librmnetctl.c
index a5147e2..95f0510 100644
--- a/rmnetctl/src/librmnetctl.c
+++ b/rmnetctl/src/librmnetctl.c
@@ -135,7 +135,6 @@
 
 	response_buf = (uint8_t *)malloc(MAX_BUF_SIZE * sizeof(uint8_t));
 	if (!response_buf) {
-		free(request_buf);
 		return_code = RMNETCTL_API_ERR_RESPONSE_NULL;
 		break;
 	}
@@ -165,8 +164,6 @@
 			(struct sockaddr*)saddr_ptr,
 			sizeof(struct sockaddr_nl)) < 0) {
 		return_code = RMNETCTL_API_ERR_MESSAGE_SEND;
-		free(request_buf);
-		free(response_buf);
 		break;
 	}
 
@@ -179,8 +176,6 @@
 			&addrlen);
 	if (bytes_read < 0) {
 		return_code = RMNETCTL_API_ERR_MESSAGE_RECEIVE;
-		free(request_buf);
-		free(response_buf);
 		break;
 	}
 
@@ -188,15 +183,11 @@
 	sizeof(struct rmnet_nl_msg_s));
 	if (sizeof(*response) < sizeof(struct rmnet_nl_msg_s)) {
 		return_code = RMNETCTL_API_ERR_RESPONSE_NULL;
-		free(request_buf);
-		free(response_buf);
 		break;
 	}
 
 	if (request->message_type != response->message_type) {
 		return_code = RMNETCTL_API_ERR_MESSAGE_TYPE;
-		free(request_buf);
-		free(response_buf);
 		break;
 	}
 	return_code = RMNETCTL_SUCCESS;