commit a9e487b7d0a6f4bfa96e17f0d41f41e75b80685c
author Kamal Negi <kamaln@codeaurora.org> Tue Sep 27 19:50:25 2016 +0530
committer Kamal Negi <kamaln@codeaurora.org> Fri Sep 30 14:49:34 2016 +0530
tree 3eb796104d214ed59f954189e889116d7e3d53d8
parent 67f115c04967238c869ce2f5029302a1f960f30c

fm: synchronize dequeue_fm_tx_cmd function

In dequeue_fm_tx_cmd function, there is race condition happened between
command credits decrement and event received for command sent. After
sending command to SoC, event received immediately and processed before
it decrement the command credits, hence command credits become zero and
it stuck in condition wait for command credits and FM failure happens.

Change-Id: Ibb2cf98ade08bbc9b25946d2368b1b7e428397bc

fm_hci/fm_hci.c

diff --git a/fm_hci/fm_hci.c b/fm_hci/fm_hci.c
index 8c6173a..2fafe83 100644
--- a/fm_hci/fm_hci.c
+++ b/fm_hci/fm_hci.c
@@ -138,12 +138,11 @@
         }
         pthread_mutex_unlock(&hci->tx_q_lock);
 
-wait_for_cmd_credits:
         pthread_mutex_lock(&hci->credit_lock);
+wait_for_cmd_credits:
         while (hci->command_credits == 0) {
               pthread_cond_wait(&hci->cmd_credits_cond, &hci->credit_lock);
         }
-        pthread_mutex_unlock(&hci->credit_lock);
 
         /* Check if we really got the command credits */
         if (hci->command_credits) {
@@ -160,14 +159,18 @@
             count = 0;
 
             /* Decrement cmd credits by '1' after sending the cmd*/
-            pthread_mutex_lock(&hci->credit_lock);
             hci->command_credits--;
-            pthread_mutex_unlock(&hci->credit_lock);
+            if (temp->hdr)
+                free(temp->hdr);
+            free(temp);
         } else {
-            if (!lib_running)
+            if (!lib_running) {
+                pthread_mutex_unlock(&hci->credit_lock);
                 break;
+            }
             goto wait_for_cmd_credits;
         }
+        pthread_mutex_unlock(&hci->credit_lock);
     }
 }