commit c1c29ea48680c38f8eece48c30a02b704b010d26
author Kamal Negi <kamaln@codeaurora.org> Fri Aug 04 15:46:32 2017 +0530
committer Gerrit - the friendly Code Review server <code-review@localhost> Thu Sep 21 19:33:26 2017 -0700
tree 7a8f30be9794c11a3d8e99dd7e401d533826bfaa
parent f93c1f8c26791e4ed9975f26488c9a3243a696b3

fm: Initialize variables after fm_hal service connection

Initialize variables after fm_hal_service connection. In subsequent FM on,
if hal init happens before threads exits in previous FM off, there might be
race condition , because of which lib_running variable sets to 0 even if
init happens. This will lead to FM failure as all threads exits as
soon as created.

Change-Id: I2e61cc7ebb935c0b31c575aed60ead1424d23eb7

fm_hci/fm_hci.c

diff --git a/fm_hci/fm_hci.c b/fm_hci/fm_hci.c
index d509395..e0d437a 100644
--- a/fm_hci/fm_hci.c
+++ b/fm_hci/fm_hci.c
@@ -704,11 +704,6 @@
     }
     memset(hci, 0, sizeof(struct fm_hci_t));
 
-    lib_running = 1;
-    ready_events = 0;
-    hci->command_credits = 1;
-    hci->fd = -1;
-
     pthread_mutex_init(&hci->tx_q_lock, NULL);
     pthread_mutex_init(&hci->credit_lock, NULL);
     pthread_mutex_init(&hci->event_lock, NULL);
@@ -724,6 +719,11 @@
     }
     ALOGI("fm_hal_fd = %d", fm_hal_fd);
 
+    lib_running = 1;
+    ready_events = 0;
+    hci->command_credits = 1;
+    hci->fd = -1;
+
     ret = vendor_init(hci);
     if (ret)
         goto err_vendor;