move storeActiveDeviceVolume out of BtA2dpLock scope in removeActiveDevice
Issue: btif thread is stuck and audio server crashed.
Analysis:
1) When disconnecting a2dp, setActiveDeviceInternal->removeActiveDevice
->storeVolumeForDevice->mAudioManager.getStreamVolume is invoked with
mBtA2dpLock acquired.
2) At the same time, a2dp is started by audio side, then
bta2dp_audio_state_callback->messageFromNative wants to acqurie
mBtA2dpLock. Because mBtA2dpLock is already acquired in 1), btif thread
is stuck and cannot respond a2dp started ack to audio side.
3) Because audio side cannot receive a2dp startd ack,
mAudioManager.getStreamVolume will never return, then deadlock happened.
Fix:
To fix it, move storeActiveDeviceVolume out of mBtA2dpLock scope in
removeActiveDevice to avoid mBtA2dpLock deadlock.
Change-Id: I83a0828f13731eaa0f9a484bdaa19d52b6759ec0
CRs-Fixed: 2638331
1 file changed