Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 1 | From 6fcc14c6109e17cd47d007e6dd677d3ce5616bdd Mon Sep 17 00:00:00 2001 |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 2 | From: Pierre-Hugues Husson <phh@phh.me> |
| 3 | Date: Mon, 6 Aug 2018 20:01:44 +0200 |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 4 | Subject: [PATCH 14/27] Change SignalStrentgh to change behaviour based on |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 5 | property |
| 6 | |
| 7 | Change-Id: I940ed724047567ec5195ac93ea04574c3d92f70b |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 8 | |
| 9 | Conflicts: |
| 10 | telephony/java/android/telephony/SignalStrength.java |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 11 | --- |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 12 | .../android/telephony/SignalStrength.java | 40 ++++++++++++------- |
| 13 | 1 file changed, 26 insertions(+), 14 deletions(-) |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 14 | |
| 15 | diff --git a/telephony/java/android/telephony/SignalStrength.java b/telephony/java/android/telephony/SignalStrength.java |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 16 | index 55c0c778972..ff906d330d4 100644 |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 17 | --- a/telephony/java/android/telephony/SignalStrength.java |
| 18 | +++ b/telephony/java/android/telephony/SignalStrength.java |
| 19 | @@ -854,6 +854,7 @@ public class SignalStrength implements Parcelable { |
| 20 | * RSRQ = quality of signal dB = Number of Resource blocks*RSRP/RSSI |
| 21 | * SNR = gain = signal/noise ratio = -10log P1/P2 dB |
| 22 | */ |
| 23 | + String method = android.os.SystemProperties.get("persist.sys.signal.level", "default"); |
| 24 | int rssiIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN, rsrpIconLevel = -1, snrIconLevel = -1; |
| 25 | |
| 26 | if (mLteRsrp > MAX_LTE_RSRP || mLteRsrp < MIN_LTE_RSRP) { |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 27 | @@ -897,8 +898,31 @@ public class SignalStrength implements Parcelable { |
| 28 | + rsrpIconLevel + " snrIconLevel:" + snrIconLevel |
| 29 | + " lteRsrpBoost:" + mLteRsrpBoost); |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 30 | |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 31 | - /* Ignore RSSNR for now */ |
| 32 | - if(rsrpIconLevel != -1) return rsrpIconLevel; |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 33 | + /* Valid values are (0-63, 99) as defined in TS 36.331 */ |
| 34 | + // TODO the range here is probably supposed to be (0..31, 99). It's unclear if anyone relies |
| 35 | + // on the current incorrect range check, so this will be fixed in a future release with more |
| 36 | + // soak time |
| 37 | + if (mLteSignalStrength > 63) rssiIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN; |
| 38 | + else if (mLteSignalStrength >= 12) rssiIconLevel = SIGNAL_STRENGTH_GREAT; |
| 39 | + else if (mLteSignalStrength >= 8) rssiIconLevel = SIGNAL_STRENGTH_GOOD; |
| 40 | + else if (mLteSignalStrength >= 5) rssiIconLevel = SIGNAL_STRENGTH_MODERATE; |
| 41 | + else if (mLteSignalStrength >= 0) rssiIconLevel = SIGNAL_STRENGTH_POOR; |
| 42 | + |
| 43 | + if (DBG) log("getLTELevel - rssi:" + mLteSignalStrength + " rssiIconLevel:" |
| 44 | + + rssiIconLevel); |
| 45 | + |
| 46 | + if("rsrp".equals(method)) { |
| 47 | + if(rsrpIconLevel == -1) rsrpIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN; |
| 48 | + return rsrpIconLevel; |
| 49 | + } |
| 50 | + if("rssnr".equals(method)) { |
| 51 | + if(snrIconLevel == -1) snrIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN; |
| 52 | + return snrIconLevel; |
| 53 | + } |
| 54 | + if("rssi".equals(method)) { |
| 55 | + if(rssiIconLevel == -1) rssiIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN; |
| 56 | + return rssiIconLevel; |
| 57 | + } |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 58 | |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 59 | /* Choose a measurement type to use for notification */ |
| 60 | if (snrIconLevel != -1 && rsrpIconLevel != -1) { |
Jon West | eb45d5e | 2019-03-17 16:58:43 -0400 | [diff] [blame] | 61 | @@ -914,18 +938,6 @@ public class SignalStrength implements Parcelable { |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 62 | |
| 63 | if (rsrpIconLevel != -1) return rsrpIconLevel; |
| 64 | |
| 65 | - /* Valid values are (0-63, 99) as defined in TS 36.331 */ |
| 66 | - // TODO the range here is probably supposed to be (0..31, 99). It's unclear if anyone relies |
| 67 | - // on the current incorrect range check, so this will be fixed in a future release with more |
| 68 | - // soak time |
| 69 | - if (mLteSignalStrength > 63) rssiIconLevel = SIGNAL_STRENGTH_NONE_OR_UNKNOWN; |
| 70 | - else if (mLteSignalStrength >= 12) rssiIconLevel = SIGNAL_STRENGTH_GREAT; |
| 71 | - else if (mLteSignalStrength >= 8) rssiIconLevel = SIGNAL_STRENGTH_GOOD; |
| 72 | - else if (mLteSignalStrength >= 5) rssiIconLevel = SIGNAL_STRENGTH_MODERATE; |
| 73 | - else if (mLteSignalStrength >= 0) rssiIconLevel = SIGNAL_STRENGTH_POOR; |
| 74 | - |
| 75 | - if (DBG) log("getLteLevel - rssi:" + mLteSignalStrength + " rssiIconLevel:" |
| 76 | - + rssiIconLevel); |
| 77 | return rssiIconLevel; |
| 78 | |
| 79 | } |
| 80 | -- |
Jackeagle | d3ba228 | 2018-11-17 20:49:22 -0700 | [diff] [blame] | 81 | 2.17.1 |
Jon West | 013ef58 | 2018-08-21 20:45:26 -0400 | [diff] [blame] | 82 | |