ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2017 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | package android.net; |
| 18 | |
| 19 | import static android.system.OsConstants.AF_INET; |
| 20 | import static android.system.OsConstants.IPPROTO_UDP; |
| 21 | import static android.system.OsConstants.SOCK_DGRAM; |
Brett Chabot | 147f6cf | 2019-03-04 14:14:56 -0800 | [diff] [blame] | 22 | |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 23 | import static org.junit.Assert.assertEquals; |
| 24 | import static org.junit.Assert.assertNotNull; |
| 25 | import static org.junit.Assert.fail; |
| 26 | import static org.mockito.Matchers.anyInt; |
| 27 | import static org.mockito.Matchers.anyObject; |
| 28 | import static org.mockito.Matchers.anyString; |
| 29 | import static org.mockito.Matchers.eq; |
| 30 | import static org.mockito.Mockito.mock; |
| 31 | import static org.mockito.Mockito.verify; |
| 32 | import static org.mockito.Mockito.when; |
| 33 | |
Remi NGUYEN VAN | 154cf1d | 2021-06-29 17:16:28 +0900 | [diff] [blame] | 34 | import android.os.Build; |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 35 | import android.system.Os; |
Brett Chabot | 147f6cf | 2019-03-04 14:14:56 -0800 | [diff] [blame] | 36 | import android.test.mock.MockContext; |
| 37 | |
| 38 | import androidx.test.filters.SmallTest; |
Hugo Benichi | 1c0f4e2 | 2017-10-11 11:26:25 +0900 | [diff] [blame] | 39 | |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 40 | import com.android.server.IpSecService; |
Remi NGUYEN VAN | 154cf1d | 2021-06-29 17:16:28 +0900 | [diff] [blame] | 41 | import com.android.testutils.DevSdkIgnoreRule; |
| 42 | import com.android.testutils.DevSdkIgnoreRunner; |
Hugo Benichi | 1c0f4e2 | 2017-10-11 11:26:25 +0900 | [diff] [blame] | 43 | |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 44 | import org.junit.Before; |
| 45 | import org.junit.Test; |
| 46 | import org.junit.runner.RunWith; |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 47 | |
Brett Chabot | 147f6cf | 2019-03-04 14:14:56 -0800 | [diff] [blame] | 48 | import java.net.InetAddress; |
| 49 | import java.net.Socket; |
| 50 | import java.net.UnknownHostException; |
| 51 | |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 52 | /** Unit tests for {@link IpSecManager}. */ |
| 53 | @SmallTest |
Remi NGUYEN VAN | 154cf1d | 2021-06-29 17:16:28 +0900 | [diff] [blame] | 54 | @RunWith(DevSdkIgnoreRunner.class) |
Paul Hu | 516d5dc | 2022-05-26 12:57:01 +0000 | [diff] [blame] | 55 | @DevSdkIgnoreRule.IgnoreUpTo(Build.VERSION_CODES.S_V2) |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 56 | public class IpSecManagerTest { |
| 57 | |
| 58 | private static final int TEST_UDP_ENCAP_PORT = 34567; |
| 59 | private static final int DROID_SPI = 0xD1201D; |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 60 | private static final int DUMMY_RESOURCE_ID = 0x1234; |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 61 | |
| 62 | private static final InetAddress GOOGLE_DNS_4; |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 63 | private static final String VTI_INTF_NAME = "ipsec_test"; |
| 64 | private static final InetAddress VTI_LOCAL_ADDRESS; |
| 65 | private static final LinkAddress VTI_INNER_ADDRESS = new LinkAddress("10.0.1.1/24"); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 66 | |
| 67 | static { |
| 68 | try { |
| 69 | // Google Public DNS Addresses; |
| 70 | GOOGLE_DNS_4 = InetAddress.getByName("8.8.8.8"); |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 71 | VTI_LOCAL_ADDRESS = InetAddress.getByName("8.8.4.4"); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 72 | } catch (UnknownHostException e) { |
| 73 | throw new RuntimeException("Could not resolve DNS Addresses", e); |
| 74 | } |
| 75 | } |
| 76 | |
| 77 | private IpSecService mMockIpSecService; |
| 78 | private IpSecManager mIpSecManager; |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 79 | private MockContext mMockContext = new MockContext() { |
| 80 | @Override |
| 81 | public String getOpPackageName() { |
| 82 | return "fooPackage"; |
| 83 | } |
| 84 | }; |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 85 | |
| 86 | @Before |
| 87 | public void setUp() throws Exception { |
| 88 | mMockIpSecService = mock(IpSecService.class); |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 89 | mIpSecManager = new IpSecManager(mMockContext, mMockIpSecService); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 90 | } |
| 91 | |
| 92 | /* |
| 93 | * Allocate a specific SPI |
| 94 | * Close SPIs |
| 95 | */ |
| 96 | @Test |
| 97 | public void testAllocSpi() throws Exception { |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 98 | IpSecSpiResponse spiResp = |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 99 | new IpSecSpiResponse(IpSecManager.Status.OK, DUMMY_RESOURCE_ID, DROID_SPI); |
Jonathan Basseri | fbe3a82 | 2017-11-16 10:58:01 -0800 | [diff] [blame] | 100 | when(mMockIpSecService.allocateSecurityParameterIndex( |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 101 | eq(GOOGLE_DNS_4.getHostAddress()), |
| 102 | eq(DROID_SPI), |
| 103 | anyObject())) |
| 104 | .thenReturn(spiResp); |
| 105 | |
| 106 | IpSecManager.SecurityParameterIndex droidSpi = |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 107 | mIpSecManager.allocateSecurityParameterIndex(GOOGLE_DNS_4, DROID_SPI); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 108 | assertEquals(DROID_SPI, droidSpi.getSpi()); |
| 109 | |
| 110 | droidSpi.close(); |
| 111 | |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 112 | verify(mMockIpSecService).releaseSecurityParameterIndex(DUMMY_RESOURCE_ID); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 113 | } |
| 114 | |
| 115 | @Test |
| 116 | public void testAllocRandomSpi() throws Exception { |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 117 | IpSecSpiResponse spiResp = |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 118 | new IpSecSpiResponse(IpSecManager.Status.OK, DUMMY_RESOURCE_ID, DROID_SPI); |
Jonathan Basseri | fbe3a82 | 2017-11-16 10:58:01 -0800 | [diff] [blame] | 119 | when(mMockIpSecService.allocateSecurityParameterIndex( |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 120 | eq(GOOGLE_DNS_4.getHostAddress()), |
| 121 | eq(IpSecManager.INVALID_SECURITY_PARAMETER_INDEX), |
| 122 | anyObject())) |
| 123 | .thenReturn(spiResp); |
| 124 | |
| 125 | IpSecManager.SecurityParameterIndex randomSpi = |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 126 | mIpSecManager.allocateSecurityParameterIndex(GOOGLE_DNS_4); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 127 | |
| 128 | assertEquals(DROID_SPI, randomSpi.getSpi()); |
| 129 | |
| 130 | randomSpi.close(); |
| 131 | |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 132 | verify(mMockIpSecService).releaseSecurityParameterIndex(DUMMY_RESOURCE_ID); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 133 | } |
| 134 | |
| 135 | /* |
| 136 | * Throws resource unavailable exception |
| 137 | */ |
| 138 | @Test |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 139 | public void testAllocSpiResUnavailableException() throws Exception { |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 140 | IpSecSpiResponse spiResp = |
| 141 | new IpSecSpiResponse(IpSecManager.Status.RESOURCE_UNAVAILABLE, 0, 0); |
Jonathan Basseri | fbe3a82 | 2017-11-16 10:58:01 -0800 | [diff] [blame] | 142 | when(mMockIpSecService.allocateSecurityParameterIndex( |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 143 | anyString(), anyInt(), anyObject())) |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 144 | .thenReturn(spiResp); |
| 145 | |
| 146 | try { |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 147 | mIpSecManager.allocateSecurityParameterIndex(GOOGLE_DNS_4); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 148 | fail("ResourceUnavailableException was not thrown"); |
| 149 | } catch (IpSecManager.ResourceUnavailableException e) { |
| 150 | } |
| 151 | } |
| 152 | |
| 153 | /* |
| 154 | * Throws spi unavailable exception |
| 155 | */ |
| 156 | @Test |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 157 | public void testAllocSpiSpiUnavailableException() throws Exception { |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 158 | IpSecSpiResponse spiResp = new IpSecSpiResponse(IpSecManager.Status.SPI_UNAVAILABLE, 0, 0); |
Jonathan Basseri | fbe3a82 | 2017-11-16 10:58:01 -0800 | [diff] [blame] | 159 | when(mMockIpSecService.allocateSecurityParameterIndex( |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 160 | anyString(), anyInt(), anyObject())) |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 161 | .thenReturn(spiResp); |
| 162 | |
| 163 | try { |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 164 | mIpSecManager.allocateSecurityParameterIndex(GOOGLE_DNS_4); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 165 | fail("ResourceUnavailableException was not thrown"); |
| 166 | } catch (IpSecManager.ResourceUnavailableException e) { |
| 167 | } |
| 168 | } |
| 169 | |
| 170 | /* |
| 171 | * Should throw exception when request spi 0 in IpSecManager |
| 172 | */ |
| 173 | @Test |
| 174 | public void testRequestAllocInvalidSpi() throws Exception { |
| 175 | try { |
Nathan Harold | 3865a00 | 2018-01-05 19:25:13 -0800 | [diff] [blame] | 176 | mIpSecManager.allocateSecurityParameterIndex(GOOGLE_DNS_4, 0); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 177 | fail("Able to allocate invalid spi"); |
| 178 | } catch (IllegalArgumentException e) { |
| 179 | } |
| 180 | } |
| 181 | |
| 182 | @Test |
| 183 | public void testOpenEncapsulationSocket() throws Exception { |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 184 | IpSecUdpEncapResponse udpEncapResp = |
| 185 | new IpSecUdpEncapResponse( |
| 186 | IpSecManager.Status.OK, |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 187 | DUMMY_RESOURCE_ID, |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 188 | TEST_UDP_ENCAP_PORT, |
| 189 | Os.socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP)); |
| 190 | when(mMockIpSecService.openUdpEncapsulationSocket(eq(TEST_UDP_ENCAP_PORT), anyObject())) |
| 191 | .thenReturn(udpEncapResp); |
| 192 | |
| 193 | IpSecManager.UdpEncapsulationSocket encapSocket = |
| 194 | mIpSecManager.openUdpEncapsulationSocket(TEST_UDP_ENCAP_PORT); |
Benedict Wong | c165885 | 2018-03-27 16:55:48 -0700 | [diff] [blame] | 195 | assertNotNull(encapSocket.getFileDescriptor()); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 196 | assertEquals(TEST_UDP_ENCAP_PORT, encapSocket.getPort()); |
| 197 | |
| 198 | encapSocket.close(); |
| 199 | |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 200 | verify(mMockIpSecService).closeUdpEncapsulationSocket(DUMMY_RESOURCE_ID); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 201 | } |
| 202 | |
| 203 | @Test |
Benedict Wong | 412ff41 | 2018-04-02 18:12:34 -0700 | [diff] [blame] | 204 | public void testApplyTransportModeTransformEnsuresSocketCreation() throws Exception { |
| 205 | Socket socket = new Socket(); |
| 206 | IpSecConfig dummyConfig = new IpSecConfig(); |
| 207 | IpSecTransform dummyTransform = new IpSecTransform(null, dummyConfig); |
| 208 | |
| 209 | // Even if underlying SocketImpl is not initalized, this should force the init, and |
| 210 | // thereby succeed. |
| 211 | mIpSecManager.applyTransportModeTransform( |
| 212 | socket, IpSecManager.DIRECTION_IN, dummyTransform); |
| 213 | |
| 214 | // Check to make sure the FileDescriptor is non-null |
| 215 | assertNotNull(socket.getFileDescriptor$()); |
| 216 | } |
| 217 | |
| 218 | @Test |
| 219 | public void testRemoveTransportModeTransformsForcesSocketCreation() throws Exception { |
| 220 | Socket socket = new Socket(); |
| 221 | |
| 222 | // Even if underlying SocketImpl is not initalized, this should force the init, and |
| 223 | // thereby succeed. |
| 224 | mIpSecManager.removeTransportModeTransforms(socket); |
| 225 | |
| 226 | // Check to make sure the FileDescriptor is non-null |
| 227 | assertNotNull(socket.getFileDescriptor$()); |
| 228 | } |
| 229 | |
| 230 | @Test |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 231 | public void testOpenEncapsulationSocketOnRandomPort() throws Exception { |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 232 | IpSecUdpEncapResponse udpEncapResp = |
| 233 | new IpSecUdpEncapResponse( |
| 234 | IpSecManager.Status.OK, |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 235 | DUMMY_RESOURCE_ID, |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 236 | TEST_UDP_ENCAP_PORT, |
| 237 | Os.socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP)); |
| 238 | |
| 239 | when(mMockIpSecService.openUdpEncapsulationSocket(eq(0), anyObject())) |
| 240 | .thenReturn(udpEncapResp); |
| 241 | |
| 242 | IpSecManager.UdpEncapsulationSocket encapSocket = |
| 243 | mIpSecManager.openUdpEncapsulationSocket(); |
| 244 | |
Benedict Wong | c165885 | 2018-03-27 16:55:48 -0700 | [diff] [blame] | 245 | assertNotNull(encapSocket.getFileDescriptor()); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 246 | assertEquals(TEST_UDP_ENCAP_PORT, encapSocket.getPort()); |
| 247 | |
| 248 | encapSocket.close(); |
| 249 | |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 250 | verify(mMockIpSecService).closeUdpEncapsulationSocket(DUMMY_RESOURCE_ID); |
ludi | 50c2767 | 2017-05-12 09:15:00 -0700 | [diff] [blame] | 251 | } |
| 252 | |
| 253 | @Test |
| 254 | public void testOpenEncapsulationSocketWithInvalidPort() throws Exception { |
| 255 | try { |
| 256 | mIpSecManager.openUdpEncapsulationSocket(IpSecManager.INVALID_SECURITY_PARAMETER_INDEX); |
| 257 | fail("IllegalArgumentException was not thrown"); |
| 258 | } catch (IllegalArgumentException e) { |
| 259 | } |
| 260 | } |
| 261 | |
| 262 | // TODO: add test when applicable transform builder interface is available |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 263 | |
| 264 | private IpSecManager.IpSecTunnelInterface createAndValidateVti(int resourceId, String intfName) |
| 265 | throws Exception { |
| 266 | IpSecTunnelInterfaceResponse dummyResponse = |
| 267 | new IpSecTunnelInterfaceResponse(IpSecManager.Status.OK, resourceId, intfName); |
| 268 | when(mMockIpSecService.createTunnelInterface( |
| 269 | eq(VTI_LOCAL_ADDRESS.getHostAddress()), eq(GOOGLE_DNS_4.getHostAddress()), |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 270 | anyObject(), anyObject(), anyString())) |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 271 | .thenReturn(dummyResponse); |
| 272 | |
| 273 | IpSecManager.IpSecTunnelInterface tunnelIntf = mIpSecManager.createIpSecTunnelInterface( |
| 274 | VTI_LOCAL_ADDRESS, GOOGLE_DNS_4, mock(Network.class)); |
| 275 | |
| 276 | assertNotNull(tunnelIntf); |
| 277 | return tunnelIntf; |
| 278 | } |
| 279 | |
| 280 | @Test |
| 281 | public void testCreateVti() throws Exception { |
| 282 | IpSecManager.IpSecTunnelInterface tunnelIntf = |
| 283 | createAndValidateVti(DUMMY_RESOURCE_ID, VTI_INTF_NAME); |
| 284 | |
| 285 | assertEquals(VTI_INTF_NAME, tunnelIntf.getInterfaceName()); |
| 286 | |
| 287 | tunnelIntf.close(); |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 288 | verify(mMockIpSecService).deleteTunnelInterface(eq(DUMMY_RESOURCE_ID), anyString()); |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 289 | } |
| 290 | |
| 291 | @Test |
| 292 | public void testAddRemoveAddressesFromVti() throws Exception { |
| 293 | IpSecManager.IpSecTunnelInterface tunnelIntf = |
| 294 | createAndValidateVti(DUMMY_RESOURCE_ID, VTI_INTF_NAME); |
| 295 | |
Benedict Wong | 2ea91ae | 2018-04-03 20:30:54 -0700 | [diff] [blame] | 296 | tunnelIntf.addAddress(VTI_INNER_ADDRESS.getAddress(), |
| 297 | VTI_INNER_ADDRESS.getPrefixLength()); |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 298 | verify(mMockIpSecService) |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 299 | .addAddressToTunnelInterface( |
| 300 | eq(DUMMY_RESOURCE_ID), eq(VTI_INNER_ADDRESS), anyString()); |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 301 | |
Benedict Wong | 2ea91ae | 2018-04-03 20:30:54 -0700 | [diff] [blame] | 302 | tunnelIntf.removeAddress(VTI_INNER_ADDRESS.getAddress(), |
| 303 | VTI_INNER_ADDRESS.getPrefixLength()); |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 304 | verify(mMockIpSecService) |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 305 | .addAddressToTunnelInterface( |
| 306 | eq(DUMMY_RESOURCE_ID), eq(VTI_INNER_ADDRESS), anyString()); |
Benedict Wong | 76df78f | 2018-03-01 18:53:07 -0800 | [diff] [blame] | 307 | } |
Nathan Harold | 68a7edf | 2018-03-15 18:06:06 -0700 | [diff] [blame] | 308 | } |