blob: 0978ae17f89f43c994a4ec2373051bcd73962947 [file] [log] [blame]
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +01001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "ssa_phi_elimination.h"
18
David Brazdil809d70f2015-11-19 10:29:39 +000019#include "base/arena_containers.h"
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +000020#include "base/bit_vector-inl.h"
David Brazdil809d70f2015-11-19 10:29:39 +000021
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010022namespace art {
23
24void SsaDeadPhiElimination::Run() {
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +000025 MarkDeadPhis();
26 EliminateDeadPhis();
27}
28
29void SsaDeadPhiElimination::MarkDeadPhis() {
David Brazdil809d70f2015-11-19 10:29:39 +000030 // Phis are constructed live and should not be revived if previously marked
31 // dead. This algorithm temporarily breaks that invariant but we DCHECK that
32 // only phis which were initially live are revived.
33 ArenaSet<HPhi*> initially_live(graph_->GetArena()->Adapter());
34
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010035 // Add to the worklist phis referenced by non-phi instructions.
36 for (HReversePostOrderIterator it(*graph_); !it.Done(); it.Advance()) {
37 HBasicBlock* block = it.Current();
Andreas Gampe277ccbd2014-11-03 21:36:10 -080038 for (HInstructionIterator inst_it(block->GetPhis()); !inst_it.Done(); inst_it.Advance()) {
39 HPhi* phi = inst_it.Current()->AsPhi();
David Brazdil809d70f2015-11-19 10:29:39 +000040 if (phi->IsDead()) {
41 continue;
42 }
43
David Brazdild9510df2015-11-04 23:30:22 +000044 bool keep_alive = (graph_->IsDebuggable() && phi->HasEnvironmentUses());
45 if (!keep_alive) {
Vladimir Marko46817b82016-03-29 12:21:58 +010046 for (const HUseListNode<HInstruction*>& use : phi->GetUses()) {
47 if (!use.GetUser()->IsPhi()) {
David Brazdild9510df2015-11-04 23:30:22 +000048 keep_alive = true;
49 break;
50 }
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010051 }
52 }
David Brazdil809d70f2015-11-19 10:29:39 +000053
David Brazdild9510df2015-11-04 23:30:22 +000054 if (keep_alive) {
David Brazdil809d70f2015-11-19 10:29:39 +000055 worklist_.push_back(phi);
56 } else {
57 phi->SetDead();
58 if (kIsDebugBuild) {
59 initially_live.insert(phi);
60 }
61 }
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010062 }
63 }
64
65 // Process the worklist by propagating liveness to phi inputs.
Vladimir Marko2aaa4b52015-09-17 17:03:26 +010066 while (!worklist_.empty()) {
67 HPhi* phi = worklist_.back();
68 worklist_.pop_back();
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010069 for (HInputIterator it(phi); !it.Done(); it.Advance()) {
David Brazdil809d70f2015-11-19 10:29:39 +000070 HPhi* input = it.Current()->AsPhi();
71 if (input != nullptr && input->IsDead()) {
72 // Input is a dead phi. Revive it and add to the worklist. We make sure
73 // that the phi was not dead initially (see definition of `initially_live`).
74 DCHECK(ContainsElement(initially_live, input));
75 input->SetLive();
76 worklist_.push_back(input);
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010077 }
78 }
79 }
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +000080}
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010081
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +000082void SsaDeadPhiElimination::EliminateDeadPhis() {
Nicolas Geoffray3ac17fc2014-08-06 23:02:54 +010083 // Remove phis that are not live. Visit in post order so that phis
84 // that are not inputs of loop phis can be removed when they have
85 // no users left (dead phis might use dead phis).
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010086 for (HPostOrderIterator it(*graph_); !it.Done(); it.Advance()) {
87 HBasicBlock* block = it.Current();
88 HInstruction* current = block->GetFirstPhi();
89 HInstruction* next = nullptr;
David Brazdil1abb4192015-02-17 18:33:36 +000090 HPhi* phi;
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010091 while (current != nullptr) {
David Brazdil1abb4192015-02-17 18:33:36 +000092 phi = current->AsPhi();
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +010093 next = current->GetNext();
David Brazdil1abb4192015-02-17 18:33:36 +000094 if (phi->IsDead()) {
95 // Make sure the phi is only used by other dead phis.
96 if (kIsDebugBuild) {
Vladimir Marko46817b82016-03-29 12:21:58 +010097 for (const HUseListNode<HInstruction*>& use : phi->GetUses()) {
98 HInstruction* user = use.GetUser();
David Brazdild9510df2015-11-04 23:30:22 +000099 DCHECK(user->IsLoopHeaderPhi());
100 DCHECK(user->AsPhi()->IsDead());
Nicolas Geoffray3ac17fc2014-08-06 23:02:54 +0100101 }
102 }
David Brazdil1abb4192015-02-17 18:33:36 +0000103 // Remove the phi from use lists of its inputs.
104 for (size_t i = 0, e = phi->InputCount(); i < e; ++i) {
105 phi->RemoveAsUserOfInput(i);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100106 }
David Brazdil1abb4192015-02-17 18:33:36 +0000107 // Remove the phi from environments that use it.
Vladimir Marko46817b82016-03-29 12:21:58 +0100108 for (const HUseListNode<HEnvironment*>& use : phi->GetEnvUses()) {
109 HEnvironment* user = use.GetUser();
110 user->SetRawEnvAt(use.GetIndex(), nullptr);
David Brazdil1abb4192015-02-17 18:33:36 +0000111 }
112 // Delete it from the instruction list.
113 block->RemovePhi(phi, /*ensure_safety=*/ false);
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100114 }
115 current = next;
116 }
117 }
118}
119
120void SsaRedundantPhiElimination::Run() {
David Brazdil77b022d2015-08-19 14:17:31 +0100121 // Add all phis in the worklist. Order does not matter for correctness, and
122 // neither will necessarily converge faster.
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100123 for (HReversePostOrderIterator it(*graph_); !it.Done(); it.Advance()) {
124 HBasicBlock* block = it.Current();
Andreas Gampe277ccbd2014-11-03 21:36:10 -0800125 for (HInstructionIterator inst_it(block->GetPhis()); !inst_it.Done(); inst_it.Advance()) {
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100126 worklist_.push_back(inst_it.Current()->AsPhi());
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100127 }
128 }
129
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000130 ArenaSet<uint32_t> visited_phis_in_cycle(graph_->GetArena()->Adapter());
131 ArenaVector<HPhi*> cycle_worklist(graph_->GetArena()->Adapter());
132
Vladimir Marko2aaa4b52015-09-17 17:03:26 +0100133 while (!worklist_.empty()) {
134 HPhi* phi = worklist_.back();
135 worklist_.pop_back();
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100136
137 // If the phi has already been processed, continue.
138 if (!phi->IsInBlock()) {
139 continue;
140 }
141
Nicolas Geoffray05b3fa02016-05-04 12:05:56 +0100142 // If the phi is dead, we know we won't revive it and it will be removed,
143 // so don't process it.
144 if (phi->IsDead()) {
David Brazdilffee3d32015-07-06 11:48:53 +0100145 continue;
146 }
147
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000148 HInstruction* candidate = nullptr;
149 visited_phis_in_cycle.clear();
150 cycle_worklist.clear();
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100151
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000152 cycle_worklist.push_back(phi);
153 visited_phis_in_cycle.insert(phi->GetId());
154 bool catch_phi_in_cycle = phi->IsCatchPhi();
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000155 bool irreducible_loop_phi_in_cycle = phi->IsIrreducibleLoopHeaderPhi();
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000156
157 // First do a simple loop over inputs and check if they are all the same.
158 for (size_t j = 0; j < phi->InputCount(); ++j) {
159 HInstruction* input = phi->InputAt(j);
160 if (input == phi) {
161 continue;
162 } else if (candidate == nullptr) {
163 candidate = input;
164 } else if (candidate != input) {
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100165 candidate = nullptr;
166 break;
167 }
168 }
169
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000170 // If we haven't found a candidate, check for a phi cycle. Note that we need to detect
171 // such cycles to avoid having reference and non-reference equivalents. We check this
172 // invariant in the graph checker.
173 if (candidate == nullptr) {
174 // We iterate over the array as long as it grows.
175 for (size_t i = 0; i < cycle_worklist.size(); ++i) {
176 HPhi* current = cycle_worklist[i];
177 DCHECK(!current->IsLoopHeaderPhi() ||
178 current->GetBlock()->IsLoopPreHeaderFirstPredecessor());
179
180 for (size_t j = 0; j < current->InputCount(); ++j) {
181 HInstruction* input = current->InputAt(j);
182 if (input == current) {
183 continue;
184 } else if (input->IsPhi()) {
185 if (!ContainsElement(visited_phis_in_cycle, input->GetId())) {
186 cycle_worklist.push_back(input->AsPhi());
187 visited_phis_in_cycle.insert(input->GetId());
188 catch_phi_in_cycle |= input->AsPhi()->IsCatchPhi();
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000189 irreducible_loop_phi_in_cycle |= input->IsIrreducibleLoopHeaderPhi();
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000190 } else {
191 // Already visited, nothing to do.
192 }
193 } else if (candidate == nullptr) {
194 candidate = input;
195 } else if (candidate != input) {
196 candidate = nullptr;
197 // Clear the cycle worklist to break out of the outer loop.
198 cycle_worklist.clear();
199 break;
200 }
201 }
202 }
203 }
204
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100205 if (candidate == nullptr) {
206 continue;
207 }
208
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000209 if (irreducible_loop_phi_in_cycle && !candidate->IsConstant()) {
210 // For irreducible loops, we need to keep the phis to satisfy our linear scan
211 // algorithm.
212 // There is one exception for constants, as the type propagation requires redundant
213 // cyclic phis of a constant to be removed. This is ok for the linear scan as it
214 // has to deal with constants anyway, and they can trivially be rematerialized.
215 continue;
216 }
217
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000218 for (HPhi* current : cycle_worklist) {
219 // The candidate may not dominate a phi in a catch block: there may be non-throwing
220 // instructions at the beginning of a try range, that may be the first input of
221 // catch phis.
222 // TODO(dbrazdil): Remove this situation by moving those non-throwing instructions
223 // before the try entry.
224 if (catch_phi_in_cycle) {
225 if (!candidate->StrictlyDominates(current)) {
226 continue;
227 }
228 } else {
229 DCHECK(candidate->StrictlyDominates(current));
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100230 }
David Brazdil77b022d2015-08-19 14:17:31 +0100231
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000232 // Because we're updating the users of this phi, we may have new candidates
233 // for elimination. Add phis that use this phi to the worklist.
Vladimir Marko46817b82016-03-29 12:21:58 +0100234 for (const HUseListNode<HInstruction*>& use : current->GetUses()) {
235 HInstruction* user = use.GetUser();
Nicolas Geoffrayf5f64ef2015-12-15 14:11:59 +0000236 if (user->IsPhi() && !ContainsElement(visited_phis_in_cycle, user->GetId())) {
237 worklist_.push_back(user->AsPhi());
238 }
239 }
240 DCHECK(candidate->StrictlyDominates(current));
241 current->ReplaceWith(candidate);
242 current->GetBlock()->RemovePhi(current);
243 }
Nicolas Geoffray7dc206a2014-07-11 09:49:49 +0100244 }
245}
246
247} // namespace art