blob: 3663448f64dd1136f8f3e22f791b389d526cb925 [file] [log] [blame]
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001/*
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Nicolas Geoffraye5038322014-07-04 09:41:32 +010017#include "builder.h"
18
Mathieu Chartierc7853442015-03-27 14:35:38 -070019#include "art_field-inl.h"
Andreas Gamped881df52014-11-24 23:28:39 -080020#include "base/logging.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010021#include "class_linker.h"
Jeff Hao848f70a2014-01-15 13:49:50 -080022#include "dex/verified_method.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000023#include "dex_file-inl.h"
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +000024#include "dex_instruction-inl.h"
Roland Levillain4c0eb422015-04-24 16:43:49 +010025#include "dex/verified_method.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010026#include "driver/compiler_driver-inl.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000027#include "driver/compiler_options.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010028#include "mirror/class_loader.h"
29#include "mirror/dex_cache.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000030#include "nodes.h"
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +000031#include "primitive.h"
Nicolas Geoffraye5038322014-07-04 09:41:32 +010032#include "scoped_thread_state_change.h"
33#include "thread.h"
Vladimir Marko58155012015-08-19 12:49:41 +000034#include "utils/dex_cache_arrays_layout-inl.h"
Nicolas Geoffray818f2102014-02-18 16:43:35 +000035
36namespace art {
37
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010038/**
39 * Helper class to add HTemporary instructions. This class is used when
40 * converting a DEX instruction to multiple HInstruction, and where those
41 * instructions do not die at the following instruction, but instead spans
42 * multiple instructions.
43 */
44class Temporaries : public ValueObject {
45 public:
Calin Juravlef97f9fb2014-11-11 15:38:19 +000046 explicit Temporaries(HGraph* graph) : graph_(graph), index_(0) {}
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010047
48 void Add(HInstruction* instruction) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +060049 HInstruction* temp = new (graph_->GetArena()) HTemporary(index_, instruction->GetDexPc());
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010050 instruction->GetBlock()->AddInstruction(temp);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000051
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010052 DCHECK(temp->GetPrevious() == instruction);
Calin Juravlef97f9fb2014-11-11 15:38:19 +000053
54 size_t offset;
55 if (instruction->GetType() == Primitive::kPrimLong
56 || instruction->GetType() == Primitive::kPrimDouble) {
57 offset = 2;
58 } else {
59 offset = 1;
60 }
61 index_ += offset;
62
63 graph_->UpdateTemporariesVRegSlots(index_);
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010064 }
65
66 private:
67 HGraph* const graph_;
68
Nicolas Geoffrayf12feb82014-07-17 18:32:41 +010069 // Current index in the temporary stack, updated by `Add`.
70 size_t index_;
71};
72
Andreas Gamped881df52014-11-24 23:28:39 -080073class SwitchTable : public ValueObject {
74 public:
75 SwitchTable(const Instruction& instruction, uint32_t dex_pc, bool sparse)
76 : instruction_(instruction), dex_pc_(dex_pc), sparse_(sparse) {
77 int32_t table_offset = instruction.VRegB_31t();
78 const uint16_t* table = reinterpret_cast<const uint16_t*>(&instruction) + table_offset;
79 if (sparse) {
80 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kSparseSwitchSignature));
81 } else {
82 CHECK_EQ(table[0], static_cast<uint16_t>(Instruction::kPackedSwitchSignature));
83 }
84 num_entries_ = table[1];
85 values_ = reinterpret_cast<const int32_t*>(&table[2]);
86 }
87
88 uint16_t GetNumEntries() const {
89 return num_entries_;
90 }
91
Andreas Gampee4d4d322014-12-04 09:09:57 -080092 void CheckIndex(size_t index) const {
93 if (sparse_) {
94 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
95 DCHECK_LT(index, 2 * static_cast<size_t>(num_entries_));
96 } else {
97 // In a packed table, we have the starting key and num_entries_ values.
98 DCHECK_LT(index, 1 + static_cast<size_t>(num_entries_));
99 }
100 }
101
Andreas Gamped881df52014-11-24 23:28:39 -0800102 int32_t GetEntryAt(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800103 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800104 return values_[index];
105 }
106
107 uint32_t GetDexPcForIndex(size_t index) const {
Andreas Gampee4d4d322014-12-04 09:09:57 -0800108 CheckIndex(index);
Andreas Gamped881df52014-11-24 23:28:39 -0800109 return dex_pc_ +
110 (reinterpret_cast<const int16_t*>(values_ + index) -
111 reinterpret_cast<const int16_t*>(&instruction_));
112 }
113
Andreas Gampee4d4d322014-12-04 09:09:57 -0800114 // Index of the first value in the table.
115 size_t GetFirstValueIndex() const {
116 if (sparse_) {
117 // In a sparse table, we have num_entries_ keys and num_entries_ values, in that order.
118 return num_entries_;
119 } else {
120 // In a packed table, we have the starting key and num_entries_ values.
121 return 1;
122 }
123 }
124
Andreas Gamped881df52014-11-24 23:28:39 -0800125 private:
126 const Instruction& instruction_;
127 const uint32_t dex_pc_;
128
129 // Whether this is a sparse-switch table (or a packed-switch one).
130 const bool sparse_;
131
132 // This can't be const as it needs to be computed off of the given instruction, and complicated
133 // expressions in the initializer list seemed very ugly.
134 uint16_t num_entries_;
135
136 const int32_t* values_;
137
138 DISALLOW_COPY_AND_ASSIGN(SwitchTable);
139};
140
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100141void HGraphBuilder::InitializeLocals(uint16_t count) {
142 graph_->SetNumberOfVRegs(count);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000143 locals_.SetSize(count);
144 for (int i = 0; i < count; i++) {
145 HLocal* local = new (arena_) HLocal(i);
146 entry_block_->AddInstruction(local);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000147 locals_.Put(i, local);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000148 }
149}
150
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000151void HGraphBuilder::InitializeParameters(uint16_t number_of_parameters) {
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100152 // dex_compilation_unit_ is null only when unit testing.
153 if (dex_compilation_unit_ == nullptr) {
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000154 return;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100155 }
156
157 graph_->SetNumberOfInVRegs(number_of_parameters);
158 const char* shorty = dex_compilation_unit_->GetShorty();
159 int locals_index = locals_.Size() - number_of_parameters;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100160 int parameter_index = 0;
161
162 if (!dex_compilation_unit_->IsStatic()) {
163 // Add the implicit 'this' argument, not expressed in the signature.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600164 HParameterValue* parameter = new (arena_) HParameterValue(parameter_index++,
165 Primitive::kPrimNot,
166 true);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100167 entry_block_->AddInstruction(parameter);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100168 HLocal* local = GetLocalAt(locals_index++);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600169 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter, local->GetDexPc()));
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100170 number_of_parameters--;
171 }
172
173 uint32_t pos = 1;
174 for (int i = 0; i < number_of_parameters; i++) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600175 HParameterValue* parameter = new (arena_) HParameterValue(parameter_index++,
176 Primitive::GetType(shorty[pos++]),
177 false);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100178 entry_block_->AddInstruction(parameter);
179 HLocal* local = GetLocalAt(locals_index++);
180 // Store the parameter value in the local that the dex code will use
181 // to reference that parameter.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600182 entry_block_->AddInstruction(new (arena_) HStoreLocal(local, parameter, local->GetDexPc()));
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +0100183 bool is_wide = (parameter->GetType() == Primitive::kPrimLong)
184 || (parameter->GetType() == Primitive::kPrimDouble);
185 if (is_wide) {
186 i++;
187 locals_index++;
188 parameter_index++;
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100189 }
190 }
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100191}
192
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100193template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000194void HGraphBuilder::If_22t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000195 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000196 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
197 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
198 DCHECK(branch_target != nullptr);
199 DCHECK(fallthrough_target != nullptr);
200 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600201 HInstruction* first = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
202 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
203 T* comparison = new (arena_) T(first, second, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700204 current_block_->AddInstruction(comparison);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600205 HInstruction* ifinst = new (arena_) HIf(comparison, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700206 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000207 current_block_->AddSuccessor(branch_target);
208 current_block_->AddSuccessor(fallthrough_target);
Dave Allison20dfc792014-06-16 20:44:29 -0700209 current_block_ = nullptr;
210}
211
212template<typename T>
Calin Juravle225ff812014-11-13 16:46:39 +0000213void HGraphBuilder::If_21t(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000214 int32_t target_offset = instruction.GetTargetOffset();
David Brazdil852eaff2015-02-02 15:23:05 +0000215 HBasicBlock* branch_target = FindBlockStartingAt(dex_pc + target_offset);
216 HBasicBlock* fallthrough_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
217 DCHECK(branch_target != nullptr);
218 DCHECK(fallthrough_target != nullptr);
219 PotentiallyAddSuspendCheck(branch_target, dex_pc);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600220 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
221 T* comparison = new (arena_) T(value, graph_->GetIntConstant(0, dex_pc), dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700222 current_block_->AddInstruction(comparison);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600223 HInstruction* ifinst = new (arena_) HIf(comparison, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -0700224 current_block_->AddInstruction(ifinst);
David Brazdil852eaff2015-02-02 15:23:05 +0000225 current_block_->AddSuccessor(branch_target);
226 current_block_->AddSuccessor(fallthrough_target);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +0100227 current_block_ = nullptr;
228}
229
Calin Juravle48c2b032014-12-09 18:11:36 +0000230void HGraphBuilder::MaybeRecordStat(MethodCompilationStat compilation_stat) {
231 if (compilation_stats_ != nullptr) {
232 compilation_stats_->RecordStat(compilation_stat);
233 }
234}
235
David Brazdil1b498722015-03-31 11:37:18 +0100236bool HGraphBuilder::SkipCompilation(const DexFile::CodeItem& code_item,
Calin Juravle48c2b032014-12-09 18:11:36 +0000237 size_t number_of_branches) {
238 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000239 CompilerOptions::CompilerFilter compiler_filter = compiler_options.GetCompilerFilter();
240 if (compiler_filter == CompilerOptions::kEverything) {
241 return false;
242 }
243
David Brazdil1b498722015-03-31 11:37:18 +0100244 if (compiler_options.IsHugeMethod(code_item.insns_size_in_code_units_)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000245 VLOG(compiler) << "Skip compilation of huge method "
246 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100247 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000248 MaybeRecordStat(MethodCompilationStat::kNotCompiledHugeMethod);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000249 return true;
250 }
251
252 // If it's large and contains no branches, it's likely to be machine generated initialization.
David Brazdil1b498722015-03-31 11:37:18 +0100253 if (compiler_options.IsLargeMethod(code_item.insns_size_in_code_units_)
254 && (number_of_branches == 0)) {
Calin Juravle48c2b032014-12-09 18:11:36 +0000255 VLOG(compiler) << "Skip compilation of large method with no branch "
256 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
David Brazdil1b498722015-03-31 11:37:18 +0100257 << ": " << code_item.insns_size_in_code_units_ << " code units";
Calin Juravle48c2b032014-12-09 18:11:36 +0000258 MaybeRecordStat(MethodCompilationStat::kNotCompiledLargeMethodNoBranches);
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000259 return true;
260 }
261
262 return false;
263}
264
David Brazdilbff75032015-07-08 17:26:51 +0000265static const DexFile::TryItem* GetTryItem(HBasicBlock* block,
266 const DexFile::CodeItem& code_item,
267 const ArenaBitVector& can_block_throw) {
268 DCHECK(!block->IsSingleTryBoundary());
269
270 // Block does not contain throwing instructions. Even if it is covered by
271 // a TryItem, we will consider it not in a try block.
272 if (!can_block_throw.IsBitSet(block->GetBlockId())) {
273 return nullptr;
274 }
275
276 // Instructions in the block may throw. Find a TryItem covering this block.
277 int32_t try_item_idx = DexFile::FindTryItem(code_item, block->GetDexPc());
David Brazdil6cd788f2015-07-08 16:44:00 +0100278 return (try_item_idx == -1) ? nullptr : DexFile::GetTryItems(code_item, try_item_idx);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000279}
280
281void HGraphBuilder::CreateBlocksForTryCatch(const DexFile::CodeItem& code_item) {
282 if (code_item.tries_size_ == 0) {
283 return;
284 }
285
286 // Create branch targets at the start/end of the TryItem range. These are
287 // places where the program might fall through into/out of the a block and
288 // where TryBoundary instructions will be inserted later. Other edges which
289 // enter/exit the try blocks are a result of branches/switches.
290 for (size_t idx = 0; idx < code_item.tries_size_; ++idx) {
291 const DexFile::TryItem* try_item = DexFile::GetTryItems(code_item, idx);
292 uint32_t dex_pc_start = try_item->start_addr_;
293 uint32_t dex_pc_end = dex_pc_start + try_item->insn_count_;
294 FindOrCreateBlockStartingAt(dex_pc_start);
295 if (dex_pc_end < code_item.insns_size_in_code_units_) {
296 // TODO: Do not create block if the last instruction cannot fall through.
297 FindOrCreateBlockStartingAt(dex_pc_end);
298 } else {
299 // The TryItem spans until the very end of the CodeItem (or beyond if
300 // invalid) and therefore cannot have any code afterwards.
301 }
302 }
303
304 // Create branch targets for exception handlers.
305 const uint8_t* handlers_ptr = DexFile::GetCatchHandlerData(code_item, 0);
306 uint32_t handlers_size = DecodeUnsignedLeb128(&handlers_ptr);
307 for (uint32_t idx = 0; idx < handlers_size; ++idx) {
308 CatchHandlerIterator iterator(handlers_ptr);
309 for (; iterator.HasNext(); iterator.Next()) {
310 uint32_t address = iterator.GetHandlerAddress();
311 HBasicBlock* block = FindOrCreateBlockStartingAt(address);
David Brazdilec16f792015-08-19 15:04:01 +0100312 block->SetTryCatchInformation(
313 new (arena_) TryCatchInformation(iterator.GetHandlerTypeIndex(), *dex_file_));
David Brazdilfc6a86a2015-06-26 10:33:45 +0000314 }
315 handlers_ptr = iterator.EndDataPointer();
316 }
317}
318
David Brazdil56e1acc2015-06-30 15:41:36 +0100319void HGraphBuilder::SplitTryBoundaryEdge(HBasicBlock* predecessor,
320 HBasicBlock* successor,
321 HTryBoundary::BoundaryKind kind,
322 const DexFile::CodeItem& code_item,
323 const DexFile::TryItem& try_item) {
324 // Split the edge with a single TryBoundary instruction.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600325 HTryBoundary* try_boundary = new (arena_) HTryBoundary(kind, successor->GetDexPc());
David Brazdil56e1acc2015-06-30 15:41:36 +0100326 HBasicBlock* try_entry_block = graph_->SplitEdge(predecessor, successor);
327 try_entry_block->AddInstruction(try_boundary);
328
329 // Link the TryBoundary to the handlers of `try_item`.
330 for (CatchHandlerIterator it(code_item, try_item); it.HasNext(); it.Next()) {
331 try_boundary->AddExceptionHandler(FindBlockStartingAt(it.GetHandlerAddress()));
332 }
333}
334
David Brazdilfc6a86a2015-06-26 10:33:45 +0000335void HGraphBuilder::InsertTryBoundaryBlocks(const DexFile::CodeItem& code_item) {
336 if (code_item.tries_size_ == 0) {
337 return;
338 }
339
David Brazdil72783ff2015-07-09 14:36:05 +0100340 // Bit vector stores information on which blocks contain throwing instructions.
341 // Must be expandable because catch blocks may be split into two.
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100342 ArenaBitVector can_block_throw(arena_, graph_->GetBlocks().size(), /* expandable */ true);
David Brazdilbff75032015-07-08 17:26:51 +0000343
344 // Scan blocks and mark those which contain throwing instructions.
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100345 for (HBasicBlock* block : graph_->GetBlocks()) {
David Brazdil72783ff2015-07-09 14:36:05 +0100346 bool can_throw = false;
David Brazdilbff75032015-07-08 17:26:51 +0000347 for (HInstructionIterator insn(block->GetInstructions()); !insn.Done(); insn.Advance()) {
348 if (insn.Current()->CanThrow()) {
David Brazdil72783ff2015-07-09 14:36:05 +0100349 can_throw = true;
David Brazdilbff75032015-07-08 17:26:51 +0000350 break;
351 }
352 }
David Brazdil72783ff2015-07-09 14:36:05 +0100353
354 if (can_throw) {
355 if (block->IsCatchBlock()) {
356 // Catch blocks are always considered an entry point into the TryItem in
357 // order to avoid splitting exceptional edges. We split the block after
358 // the move-exception (if present) and mark the first part non-throwing.
359 // Later on, a TryBoundary will be inserted between the two blocks.
360 HInstruction* first_insn = block->GetFirstInstruction();
361 if (first_insn->IsLoadException()) {
362 // Catch block starts with a LoadException. Split the block after the
David Brazdilcb1c0552015-08-04 16:22:25 +0100363 // StoreLocal and ClearException which must come after the load.
David Brazdil72783ff2015-07-09 14:36:05 +0100364 DCHECK(first_insn->GetNext()->IsStoreLocal());
David Brazdilcb1c0552015-08-04 16:22:25 +0100365 DCHECK(first_insn->GetNext()->GetNext()->IsClearException());
366 block = block->SplitBefore(first_insn->GetNext()->GetNext()->GetNext());
David Brazdil72783ff2015-07-09 14:36:05 +0100367 } else {
368 // Catch block does not load the exception. Split at the beginning to
369 // create an empty catch block.
370 block = block->SplitBefore(first_insn);
371 }
372 }
373 can_block_throw.SetBit(block->GetBlockId());
374 }
David Brazdilbff75032015-07-08 17:26:51 +0000375 }
376
David Brazdil281a6322015-07-03 10:34:57 +0100377 // Iterate over all blocks, find those covered by some TryItem and:
378 // (a) split edges which enter/exit the try range,
379 // (b) create TryBoundary instructions in the new blocks,
380 // (c) link the new blocks to corresponding exception handlers.
381 // We cannot iterate only over blocks in `branch_targets_` because switch-case
382 // blocks share the same dex_pc.
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100383 for (HBasicBlock* try_block : graph_->GetBlocks()) {
David Brazdil281a6322015-07-03 10:34:57 +0100384 // TryBoundary blocks are added at the end of the list and not iterated over.
385 DCHECK(!try_block->IsSingleTryBoundary());
David Brazdilfc6a86a2015-06-26 10:33:45 +0000386
David Brazdil281a6322015-07-03 10:34:57 +0100387 // Find the TryItem for this block.
David Brazdilbff75032015-07-08 17:26:51 +0000388 const DexFile::TryItem* try_item = GetTryItem(try_block, code_item, can_block_throw);
389 if (try_item == nullptr) {
David Brazdil281a6322015-07-03 10:34:57 +0100390 continue;
391 }
David Brazdil281a6322015-07-03 10:34:57 +0100392
David Brazdil72783ff2015-07-09 14:36:05 +0100393 // Catch blocks were split earlier and cannot throw.
394 DCHECK(!try_block->IsCatchBlock());
395
396 // Find predecessors which are not covered by the same TryItem range. Such
397 // edges enter the try block and will have a TryBoundary inserted.
Vladimir Marko60584552015-09-03 13:35:12 +0000398 for (size_t i = 0; i < try_block->GetPredecessors().size(); ++i) {
399 HBasicBlock* predecessor = try_block->GetPredecessor(i);
David Brazdil72783ff2015-07-09 14:36:05 +0100400 if (predecessor->IsSingleTryBoundary()) {
401 // The edge was already split because of an exit from a neighbouring
402 // TryItem. We split it again and insert an entry point.
403 if (kIsDebugBuild) {
404 HTryBoundary* last_insn = predecessor->GetLastInstruction()->AsTryBoundary();
405 const DexFile::TryItem* predecessor_try_item =
406 GetTryItem(predecessor->GetSinglePredecessor(), code_item, can_block_throw);
407 DCHECK(!last_insn->IsEntry());
408 DCHECK_EQ(last_insn->GetNormalFlowSuccessor(), try_block);
409 DCHECK(try_block->IsFirstIndexOfPredecessor(predecessor, i));
410 DCHECK_NE(try_item, predecessor_try_item);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000411 }
David Brazdil72783ff2015-07-09 14:36:05 +0100412 } else if (GetTryItem(predecessor, code_item, can_block_throw) != try_item) {
413 // This is an entry point into the TryItem and the edge has not been
414 // split yet. That means that `predecessor` is not in a TryItem, or
415 // it is in a different TryItem and we happened to iterate over this
416 // block first. We split the edge and insert an entry point.
417 } else {
418 // Not an edge on the boundary of the try block.
419 continue;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000420 }
David Brazdil72783ff2015-07-09 14:36:05 +0100421 SplitTryBoundaryEdge(predecessor, try_block, HTryBoundary::kEntry, code_item, *try_item);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000422 }
David Brazdil281a6322015-07-03 10:34:57 +0100423
424 // Find successors which are not covered by the same TryItem range. Such
425 // edges exit the try block and will have a TryBoundary inserted.
Vladimir Marko60584552015-09-03 13:35:12 +0000426 for (HBasicBlock* successor : try_block->GetSuccessors()) {
David Brazdil281a6322015-07-03 10:34:57 +0100427 if (successor->IsCatchBlock()) {
428 // A catch block is always considered an entry point into its TryItem.
429 // We therefore assume this is an exit point, regardless of whether
430 // the catch block is in a different TryItem or not.
431 } else if (successor->IsSingleTryBoundary()) {
432 // The edge was already split because of an entry into a neighbouring
433 // TryItem. We split it again and insert an exit.
434 if (kIsDebugBuild) {
435 HTryBoundary* last_insn = successor->GetLastInstruction()->AsTryBoundary();
David Brazdilbff75032015-07-08 17:26:51 +0000436 const DexFile::TryItem* successor_try_item =
437 GetTryItem(last_insn->GetNormalFlowSuccessor(), code_item, can_block_throw);
David Brazdil281a6322015-07-03 10:34:57 +0100438 DCHECK_EQ(try_block, successor->GetSinglePredecessor());
439 DCHECK(last_insn->IsEntry());
David Brazdilbff75032015-07-08 17:26:51 +0000440 DCHECK_NE(try_item, successor_try_item);
David Brazdil281a6322015-07-03 10:34:57 +0100441 }
David Brazdilbff75032015-07-08 17:26:51 +0000442 } else if (GetTryItem(successor, code_item, can_block_throw) != try_item) {
David Brazdil281a6322015-07-03 10:34:57 +0100443 // This is an exit out of the TryItem and the edge has not been split
444 // yet. That means that either `successor` is not in a TryItem, or it
445 // is in a different TryItem and we happened to iterate over this
446 // block first. We split the edge and insert an exit.
447 HInstruction* last_instruction = try_block->GetLastInstruction();
448 if (last_instruction->IsReturn() || last_instruction->IsReturnVoid()) {
449 DCHECK_EQ(successor, exit_block_);
450 // Control flow exits the try block with a Return(Void). Because
451 // splitting the edge would invalidate the invariant that Return
452 // always jumps to Exit, we move the Return outside the try block.
453 successor = try_block->SplitBefore(last_instruction);
454 }
455 } else {
456 // Not an edge on the boundary of the try block.
457 continue;
458 }
David Brazdilbff75032015-07-08 17:26:51 +0000459 SplitTryBoundaryEdge(try_block, successor, HTryBoundary::kExit, code_item, *try_item);
David Brazdil281a6322015-07-03 10:34:57 +0100460 }
David Brazdilfc6a86a2015-06-26 10:33:45 +0000461 }
462}
463
David Brazdil5e8b1372015-01-23 14:39:08 +0000464bool HGraphBuilder::BuildGraph(const DexFile::CodeItem& code_item) {
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100465 DCHECK(graph_->GetBlocks().empty());
David Brazdil5e8b1372015-01-23 14:39:08 +0000466
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000467 const uint16_t* code_ptr = code_item.insns_;
468 const uint16_t* code_end = code_item.insns_ + code_item.insns_size_in_code_units_;
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +0100469 code_start_ = code_ptr;
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000470
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000471 // Setup the graph with the entry block and exit block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100472 entry_block_ = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000473 graph_->AddBlock(entry_block_);
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100474 exit_block_ = new (arena_) HBasicBlock(graph_, kNoDexPc);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000475 graph_->SetEntryBlock(entry_block_);
476 graph_->SetExitBlock(exit_block_);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000477
David Brazdil77a48ae2015-09-15 12:34:04 +0000478 graph_->SetHasTryCatch(code_item.tries_size_ != 0);
479
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000480 InitializeLocals(code_item.registers_size_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000481 graph_->SetMaximumNumberOfOutVRegs(code_item.outs_size_);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000482
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000483 // Compute the number of dex instructions, blocks, and branches. We will
484 // check these values against limits given to the compiler.
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000485 size_t number_of_branches = 0;
486
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000487 // To avoid splitting blocks, we compute ahead of time the instructions that
488 // start a new block, and create these blocks.
Calin Juravle702d2602015-04-30 19:28:21 +0100489 if (!ComputeBranchTargets(code_ptr, code_end, &number_of_branches)) {
490 MaybeRecordStat(MethodCompilationStat::kNotCompiledBranchOutsideMethodCode);
491 return false;
492 }
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000493
494 // Note that the compiler driver is null when unit testing.
David Brazdil1b498722015-03-31 11:37:18 +0100495 if ((compiler_driver_ != nullptr) && SkipCompilation(code_item, number_of_branches)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000496 return false;
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000497 }
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000498
David Brazdilfc6a86a2015-06-26 10:33:45 +0000499 CreateBlocksForTryCatch(code_item);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +0000500
Nicolas Geoffray52e832b2014-11-06 15:15:31 +0000501 InitializeParameters(code_item.ins_size_);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100502
Calin Juravle225ff812014-11-13 16:46:39 +0000503 size_t dex_pc = 0;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000504 while (code_ptr < code_end) {
Calin Juravle225ff812014-11-13 16:46:39 +0000505 // Update the current block if dex_pc starts a new block.
506 MaybeUpdateCurrentBlock(dex_pc);
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000507 const Instruction& instruction = *Instruction::At(code_ptr);
Calin Juravle48c2b032014-12-09 18:11:36 +0000508 if (!AnalyzeDexInstruction(instruction, dex_pc)) {
David Brazdil5e8b1372015-01-23 14:39:08 +0000509 return false;
Calin Juravle48c2b032014-12-09 18:11:36 +0000510 }
Calin Juravle225ff812014-11-13 16:46:39 +0000511 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000512 code_ptr += instruction.SizeInCodeUnits();
513 }
514
David Brazdilfc6a86a2015-06-26 10:33:45 +0000515 // Add Exit to the exit block.
David Brazdil3e187382015-06-26 09:59:52 +0000516 exit_block_->AddInstruction(new (arena_) HExit());
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +0000517 // Add the suspend check to the entry block.
518 entry_block_->AddInstruction(new (arena_) HSuspendCheck(0));
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +0000519 entry_block_->AddInstruction(new (arena_) HGoto());
David Brazdilbff75032015-07-08 17:26:51 +0000520 // Add the exit block at the end.
521 graph_->AddBlock(exit_block_);
David Brazdil5e8b1372015-01-23 14:39:08 +0000522
David Brazdilfc6a86a2015-06-26 10:33:45 +0000523 // Iterate over blocks covered by TryItems and insert TryBoundaries at entry
524 // and exit points. This requires all control-flow instructions and
525 // non-exceptional edges to have been created.
526 InsertTryBoundaryBlocks(code_item);
527
David Brazdil5e8b1372015-01-23 14:39:08 +0000528 return true;
Nicolas Geoffray818f2102014-02-18 16:43:35 +0000529}
530
David Brazdilfc6a86a2015-06-26 10:33:45 +0000531void HGraphBuilder::MaybeUpdateCurrentBlock(size_t dex_pc) {
532 HBasicBlock* block = FindBlockStartingAt(dex_pc);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +0000533 if (block == nullptr) {
534 return;
535 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000536
537 if (current_block_ != nullptr) {
538 // Branching instructions clear current_block, so we know
539 // the last instruction of the current block is not a branching
540 // instruction. We add an unconditional goto to the found block.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600541 current_block_->AddInstruction(new (arena_) HGoto(dex_pc));
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000542 current_block_->AddSuccessor(block);
543 }
544 graph_->AddBlock(block);
545 current_block_ = block;
546}
547
Calin Juravle702d2602015-04-30 19:28:21 +0100548bool HGraphBuilder::ComputeBranchTargets(const uint16_t* code_ptr,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000549 const uint16_t* code_end,
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000550 size_t* number_of_branches) {
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000551 branch_targets_.SetSize(code_end - code_ptr);
552
553 // Create the first block for the dex instructions, single successor of the entry block.
Nicolas Geoffray3c049742014-09-24 18:10:46 +0100554 HBasicBlock* block = new (arena_) HBasicBlock(graph_, 0);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000555 branch_targets_.Put(0, block);
556 entry_block_->AddSuccessor(block);
557
558 // Iterate over all instructions and find branching instructions. Create blocks for
559 // the locations these instructions branch to.
Andreas Gamped881df52014-11-24 23:28:39 -0800560 uint32_t dex_pc = 0;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000561 while (code_ptr < code_end) {
562 const Instruction& instruction = *Instruction::At(code_ptr);
563 if (instruction.IsBranch()) {
Nicolas Geoffray43a539f2014-12-02 10:19:51 +0000564 (*number_of_branches)++;
Calin Juravle225ff812014-11-13 16:46:39 +0000565 int32_t target = instruction.GetTargetOffset() + dex_pc;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000566 // Create a block for the target instruction.
David Brazdilfc6a86a2015-06-26 10:33:45 +0000567 FindOrCreateBlockStartingAt(target);
568
Calin Juravle225ff812014-11-13 16:46:39 +0000569 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000570 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100571
David Brazdilfe659462015-06-24 14:23:56 +0100572 if (instruction.CanFlowThrough()) {
573 if (code_ptr >= code_end) {
Calin Juravle702d2602015-04-30 19:28:21 +0100574 // In the normal case we should never hit this but someone can artificially forge a dex
575 // file to fall-through out the method code. In this case we bail out compilation.
576 return false;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000577 } else {
578 FindOrCreateBlockStartingAt(dex_pc);
Calin Juravle702d2602015-04-30 19:28:21 +0100579 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000580 }
Andreas Gampee4d4d322014-12-04 09:09:57 -0800581 } else if (instruction.IsSwitch()) {
582 SwitchTable table(instruction, dex_pc, instruction.Opcode() == Instruction::SPARSE_SWITCH);
Andreas Gamped881df52014-11-24 23:28:39 -0800583
584 uint16_t num_entries = table.GetNumEntries();
585
Andreas Gampee4d4d322014-12-04 09:09:57 -0800586 // In a packed-switch, the entry at index 0 is the starting key. In a sparse-switch, the
587 // entry at index 0 is the first key, and values are after *all* keys.
588 size_t offset = table.GetFirstValueIndex();
589
590 // Use a larger loop counter type to avoid overflow issues.
591 for (size_t i = 0; i < num_entries; ++i) {
Andreas Gamped881df52014-11-24 23:28:39 -0800592 // The target of the case.
Andreas Gampee4d4d322014-12-04 09:09:57 -0800593 uint32_t target = dex_pc + table.GetEntryAt(i + offset);
David Brazdilfc6a86a2015-06-26 10:33:45 +0000594 FindOrCreateBlockStartingAt(target);
Andreas Gamped881df52014-11-24 23:28:39 -0800595
David Brazdil281a6322015-07-03 10:34:57 +0100596 // Create a block for the switch-case logic. The block gets the dex_pc
597 // of the SWITCH instruction because it is part of its semantics.
598 block = new (arena_) HBasicBlock(graph_, dex_pc);
599 branch_targets_.Put(table.GetDexPcForIndex(i), block);
Andreas Gamped881df52014-11-24 23:28:39 -0800600 }
601
602 // Fall-through. Add a block if there is more code afterwards.
603 dex_pc += instruction.SizeInCodeUnits();
604 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle702d2602015-04-30 19:28:21 +0100605 if (code_ptr >= code_end) {
606 // In the normal case we should never hit this but someone can artificially forge a dex
607 // file to fall-through out the method code. In this case we bail out compilation.
608 // (A switch can fall-through so we don't need to check CanFlowThrough().)
609 return false;
David Brazdilfc6a86a2015-06-26 10:33:45 +0000610 } else {
611 FindOrCreateBlockStartingAt(dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -0800612 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000613 } else {
614 code_ptr += instruction.SizeInCodeUnits();
Calin Juravle225ff812014-11-13 16:46:39 +0000615 dex_pc += instruction.SizeInCodeUnits();
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000616 }
617 }
Calin Juravle702d2602015-04-30 19:28:21 +0100618 return true;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000619}
620
David Brazdilfc6a86a2015-06-26 10:33:45 +0000621HBasicBlock* HGraphBuilder::FindBlockStartingAt(int32_t dex_pc) const {
622 DCHECK_GE(dex_pc, 0);
623 DCHECK_LT(static_cast<size_t>(dex_pc), branch_targets_.Size());
624 return branch_targets_.Get(dex_pc);
625}
626
627HBasicBlock* HGraphBuilder::FindOrCreateBlockStartingAt(int32_t dex_pc) {
628 HBasicBlock* block = FindBlockStartingAt(dex_pc);
629 if (block == nullptr) {
630 block = new (arena_) HBasicBlock(graph_, dex_pc);
631 branch_targets_.Put(dex_pc, block);
632 }
633 return block;
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +0000634}
635
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100636template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600637void HGraphBuilder::Unop_12x(const Instruction& instruction,
638 Primitive::Type type,
639 uint32_t dex_pc) {
640 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
641 current_block_->AddInstruction(new (arena_) T(type, first, dex_pc));
642 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Roland Levillain88cb1752014-10-20 16:36:47 +0100643}
644
Roland Levillaindff1f282014-11-05 14:15:05 +0000645void HGraphBuilder::Conversion_12x(const Instruction& instruction,
646 Primitive::Type input_type,
Roland Levillain624279f2014-12-04 11:54:28 +0000647 Primitive::Type result_type,
648 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600649 HInstruction* first = LoadLocal(instruction.VRegB(), input_type, dex_pc);
Roland Levillain624279f2014-12-04 11:54:28 +0000650 current_block_->AddInstruction(new (arena_) HTypeConversion(result_type, first, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600651 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100652}
653
654template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000655void HGraphBuilder::Binop_23x(const Instruction& instruction,
656 Primitive::Type type,
657 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600658 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
659 HInstruction* second = LoadLocal(instruction.VRegC(), type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000660 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600661 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000662}
663
664template<typename T>
Calin Juravle9aec02f2014-11-18 23:06:35 +0000665void HGraphBuilder::Binop_23x_shift(const Instruction& instruction,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600666 Primitive::Type type,
667 uint32_t dex_pc) {
668 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
669 HInstruction* second = LoadLocal(instruction.VRegC(), Primitive::kPrimInt, dex_pc);
670 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
671 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +0000672}
673
Calin Juravleddb7df22014-11-25 20:56:51 +0000674void HGraphBuilder::Binop_23x_cmp(const Instruction& instruction,
675 Primitive::Type type,
Mark Mendellc4701932015-04-10 13:18:51 -0400676 ComparisonBias bias,
Alexey Frunze4dda3372015-06-01 18:31:49 -0700677 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600678 HInstruction* first = LoadLocal(instruction.VRegB(), type, dex_pc);
679 HInstruction* second = LoadLocal(instruction.VRegC(), type, dex_pc);
Alexey Frunze4dda3372015-06-01 18:31:49 -0700680 current_block_->AddInstruction(new (arena_) HCompare(type, first, second, bias, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600681 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +0000682}
683
Calin Juravle9aec02f2014-11-18 23:06:35 +0000684template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600685void HGraphBuilder::Binop_12x_shift(const Instruction& instruction, Primitive::Type type,
686 uint32_t dex_pc) {
687 HInstruction* first = LoadLocal(instruction.VRegA(), type, dex_pc);
688 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
689 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
690 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +0000691}
692
693template<typename T>
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000694void HGraphBuilder::Binop_12x(const Instruction& instruction,
695 Primitive::Type type,
696 uint32_t dex_pc) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600697 HInstruction* first = LoadLocal(instruction.VRegA(), type, dex_pc);
698 HInstruction* second = LoadLocal(instruction.VRegB(), type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000699 current_block_->AddInstruction(new (arena_) T(type, first, second, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600700 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +0000701}
702
703template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600704void HGraphBuilder::Binop_22s(const Instruction& instruction, bool reverse, uint32_t dex_pc) {
705 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
706 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22s(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100707 if (reverse) {
708 std::swap(first, second);
709 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600710 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second, dex_pc));
711 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100712}
713
714template<typename T>
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600715void HGraphBuilder::Binop_22b(const Instruction& instruction, bool reverse, uint32_t dex_pc) {
716 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
717 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22b(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100718 if (reverse) {
719 std::swap(first, second);
720 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600721 current_block_->AddInstruction(new (arena_) T(Primitive::kPrimInt, first, second, dex_pc));
722 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +0100723}
724
Calin Juravle0c25d102015-04-20 14:49:09 +0100725static bool RequiresConstructorBarrier(const DexCompilationUnit* cu, const CompilerDriver& driver) {
Calin Juravle27df7582015-04-17 19:12:31 +0100726 Thread* self = Thread::Current();
Calin Juravle0c25d102015-04-20 14:49:09 +0100727 return cu->IsConstructor()
728 && driver.RequiresConstructorBarrier(self, cu->GetDexFile(), cu->GetClassDefIndex());
Calin Juravle27df7582015-04-17 19:12:31 +0100729}
730
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600731void HGraphBuilder::BuildReturn(const Instruction& instruction,
732 Primitive::Type type,
733 uint32_t dex_pc) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100734 if (type == Primitive::kPrimVoid) {
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100735 if (graph_->ShouldGenerateConstructorBarrier()) {
736 // The compilation unit is null during testing.
737 if (dex_compilation_unit_ != nullptr) {
738 DCHECK(RequiresConstructorBarrier(dex_compilation_unit_, *compiler_driver_))
739 << "Inconsistent use of ShouldGenerateConstructorBarrier. Should not generate a barrier.";
740 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600741 current_block_->AddInstruction(new (arena_) HMemoryBarrier(kStoreStore, dex_pc));
Calin Juravle27df7582015-04-17 19:12:31 +0100742 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600743 current_block_->AddInstruction(new (arena_) HReturnVoid(dex_pc));
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100744 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +0600745 HInstruction* value = LoadLocal(instruction.VRegA(), type, dex_pc);
746 current_block_->AddInstruction(new (arena_) HReturn(value, dex_pc));
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +0100747 }
748 current_block_->AddSuccessor(exit_block_);
749 current_block_ = nullptr;
750}
751
Calin Juravle68ad6492015-08-18 17:08:12 +0100752static InvokeType GetInvokeTypeFromOpCode(Instruction::Code opcode) {
753 switch (opcode) {
754 case Instruction::INVOKE_STATIC:
755 case Instruction::INVOKE_STATIC_RANGE:
756 return kStatic;
757 case Instruction::INVOKE_DIRECT:
758 case Instruction::INVOKE_DIRECT_RANGE:
759 return kDirect;
760 case Instruction::INVOKE_VIRTUAL:
761 case Instruction::INVOKE_VIRTUAL_QUICK:
762 case Instruction::INVOKE_VIRTUAL_RANGE:
763 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK:
764 return kVirtual;
765 case Instruction::INVOKE_INTERFACE:
766 case Instruction::INVOKE_INTERFACE_RANGE:
767 return kInterface;
768 case Instruction::INVOKE_SUPER_RANGE:
769 case Instruction::INVOKE_SUPER:
770 return kSuper;
771 default:
772 LOG(FATAL) << "Unexpected invoke opcode: " << opcode;
773 UNREACHABLE();
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100774 }
Calin Juravle68ad6492015-08-18 17:08:12 +0100775}
776
777bool HGraphBuilder::BuildInvoke(const Instruction& instruction,
778 uint32_t dex_pc,
779 uint32_t method_idx,
780 uint32_t number_of_vreg_arguments,
781 bool is_range,
782 uint32_t* args,
783 uint32_t register_index) {
784 InvokeType original_invoke_type = GetInvokeTypeFromOpCode(instruction.Opcode());
785 InvokeType optimized_invoke_type = original_invoke_type;
786 const char* descriptor = dex_file_->GetMethodShorty(method_idx);
787 Primitive::Type return_type = Primitive::GetType(descriptor[0]);
788
789 // Remove the return type from the 'proto'.
790 size_t number_of_arguments = strlen(descriptor) - 1;
791 if (original_invoke_type != kStatic) { // instance call
792 // One extra argument for 'this'.
793 number_of_arguments++;
794 }
795
796 MethodReference target_method(dex_file_, method_idx);
Calin Juravle5d01db12015-08-25 15:02:42 +0100797 int32_t table_index = 0;
798 uintptr_t direct_code = 0;
799 uintptr_t direct_method = 0;
Calin Juravle68ad6492015-08-18 17:08:12 +0100800
Calin Juravle5d01db12015-08-25 15:02:42 +0100801 // Special handling for string init.
802 int32_t string_init_offset = 0;
803 bool is_string_init = compiler_driver_->IsStringInit(method_idx,
804 dex_file_,
805 &string_init_offset);
806 // Replace calls to String.<init> with StringFactory.
807 if (is_string_init) {
808 HInvokeStaticOrDirect::DispatchInfo dispatch_info = ComputeDispatchInfo(is_string_init,
809 string_init_offset,
810 target_method,
811 direct_method,
812 direct_code);
813 HInvoke* invoke = new (arena_) HInvokeStaticOrDirect(
814 arena_,
815 number_of_arguments - 1,
816 Primitive::kPrimNot /*return_type */,
817 dex_pc,
818 method_idx,
819 target_method,
820 dispatch_info,
821 original_invoke_type,
822 kStatic /* optimized_invoke_type */,
823 HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit);
824 return HandleStringInit(invoke,
825 number_of_vreg_arguments,
826 args,
827 register_index,
828 is_range,
829 descriptor);
830 }
831
832 // Handle unresolved methods.
Calin Juravle68ad6492015-08-18 17:08:12 +0100833 if (!compiler_driver_->ComputeInvokeInfo(dex_compilation_unit_,
834 dex_pc,
835 true /* update_stats */,
836 true /* enable_devirtualization */,
837 &optimized_invoke_type,
838 &target_method,
839 &table_index,
840 &direct_code,
841 &direct_method)) {
Calin Juravle175dc732015-08-25 15:42:32 +0100842 MaybeRecordStat(MethodCompilationStat::kUnresolvedMethod);
843 HInvoke* invoke = new (arena_) HInvokeUnresolved(arena_,
844 number_of_arguments,
845 return_type,
846 dex_pc,
847 method_idx,
848 original_invoke_type);
849 return HandleInvoke(invoke,
850 number_of_vreg_arguments,
851 args,
852 register_index,
853 is_range,
854 descriptor,
855 nullptr /* clinit_check */);
Calin Juravle68ad6492015-08-18 17:08:12 +0100856 }
857
Calin Juravle5d01db12015-08-25 15:02:42 +0100858 // Handle resolved methods (non string init).
Calin Juravle68ad6492015-08-18 17:08:12 +0100859
Calin Juravle5d01db12015-08-25 15:02:42 +0100860 DCHECK(optimized_invoke_type != kSuper);
Calin Juravle68ad6492015-08-18 17:08:12 +0100861
862 // Potential class initialization check, in the case of a static method call.
863 HClinitCheck* clinit_check = nullptr;
864 HInvoke* invoke = nullptr;
865
Calin Juravle5d01db12015-08-25 15:02:42 +0100866 if (optimized_invoke_type == kDirect || optimized_invoke_type == kStatic) {
Calin Juravle68ad6492015-08-18 17:08:12 +0100867 // By default, consider that the called method implicitly requires
868 // an initialization check of its declaring method.
869 HInvokeStaticOrDirect::ClinitCheckRequirement clinit_check_requirement
870 = HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit;
Calin Juravle5d01db12015-08-25 15:02:42 +0100871 if (optimized_invoke_type == kStatic) {
Calin Juravle68ad6492015-08-18 17:08:12 +0100872 clinit_check = ProcessClinitCheckForInvoke(dex_pc, method_idx, &clinit_check_requirement);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100873 }
Calin Juravle68ad6492015-08-18 17:08:12 +0100874
Calin Juravle68ad6492015-08-18 17:08:12 +0100875 HInvokeStaticOrDirect::DispatchInfo dispatch_info = ComputeDispatchInfo(is_string_init,
876 string_init_offset,
877 target_method,
878 direct_method,
879 direct_code);
880 invoke = new (arena_) HInvokeStaticOrDirect(arena_,
881 number_of_arguments,
882 return_type,
883 dex_pc,
884 method_idx,
885 target_method,
886 dispatch_info,
887 original_invoke_type,
888 optimized_invoke_type,
889 clinit_check_requirement);
890 } else if (optimized_invoke_type == kVirtual) {
891 invoke = new (arena_) HInvokeVirtual(arena_,
892 number_of_arguments,
893 return_type,
894 dex_pc,
895 method_idx,
896 table_index);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100897 } else {
Calin Juravle68ad6492015-08-18 17:08:12 +0100898 DCHECK_EQ(optimized_invoke_type, kInterface);
899 invoke = new (arena_) HInvokeInterface(arena_,
900 number_of_arguments,
901 return_type,
902 dex_pc,
903 method_idx,
904 table_index);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100905 }
Calin Juravle68ad6492015-08-18 17:08:12 +0100906
Calin Juravle5d01db12015-08-25 15:02:42 +0100907 return HandleInvoke(invoke,
908 number_of_vreg_arguments,
909 args,
910 register_index,
911 is_range,
912 descriptor,
913 clinit_check);
Calin Juravle68ad6492015-08-18 17:08:12 +0100914}
915
916HClinitCheck* HGraphBuilder::ProcessClinitCheckForInvoke(
917 uint32_t dex_pc,
918 uint32_t method_idx,
919 HInvokeStaticOrDirect::ClinitCheckRequirement* clinit_check_requirement) {
920 ScopedObjectAccess soa(Thread::Current());
921 StackHandleScope<4> hs(soa.Self());
922 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
923 dex_compilation_unit_->GetClassLinker()->FindDexCache(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -0700924 soa.Self(), *dex_compilation_unit_->GetDexFile())));
Calin Juravle68ad6492015-08-18 17:08:12 +0100925 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
926 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
927 ArtMethod* resolved_method = compiler_driver_->ResolveMethod(
928 soa, dex_cache, class_loader, dex_compilation_unit_, method_idx, InvokeType::kStatic);
929
930 DCHECK(resolved_method != nullptr);
931
932 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
933 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -0700934 outer_compilation_unit_->GetClassLinker()->FindDexCache(soa.Self(), outer_dex_file)));
Calin Juravle68ad6492015-08-18 17:08:12 +0100935 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
936
937 // The index at which the method's class is stored in the DexCache's type array.
938 uint32_t storage_index = DexFile::kDexNoIndex;
939 bool is_outer_class = (resolved_method->GetDeclaringClass() == outer_class.Get());
940 if (is_outer_class) {
941 storage_index = outer_class->GetDexTypeIndex();
942 } else if (outer_dex_cache.Get() == dex_cache.Get()) {
943 // Get `storage_index` from IsClassOfStaticMethodAvailableToReferrer.
944 compiler_driver_->IsClassOfStaticMethodAvailableToReferrer(outer_dex_cache.Get(),
945 GetCompilingClass(),
946 resolved_method,
947 method_idx,
948 &storage_index);
949 }
950
951 HClinitCheck* clinit_check = nullptr;
952
953 if (!outer_class->IsInterface()
954 && outer_class->IsSubClass(resolved_method->GetDeclaringClass())) {
955 // If the outer class is the declaring class or a subclass
956 // of the declaring class, no class initialization is needed
957 // before the static method call.
958 // Note that in case of inlining, we do not need to add clinit checks
959 // to calls that satisfy this subclass check with any inlined methods. This
960 // will be detected by the optimization passes.
961 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
962 } else if (storage_index != DexFile::kDexNoIndex) {
963 // If the method's class type index is available, check
964 // whether we should add an explicit class initialization
965 // check for its declaring class before the static method call.
966
967 // TODO: find out why this check is needed.
968 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
969 *outer_compilation_unit_->GetDexFile(), storage_index);
970 bool is_initialized =
971 resolved_method->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
972
973 if (is_initialized) {
974 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
975 } else {
976 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit;
977 HLoadClass* load_class = new (arena_) HLoadClass(
978 graph_->GetCurrentMethod(),
979 storage_index,
980 *dex_compilation_unit_->GetDexFile(),
981 is_outer_class,
982 dex_pc);
983 current_block_->AddInstruction(load_class);
984 clinit_check = new (arena_) HClinitCheck(load_class, dex_pc);
985 current_block_->AddInstruction(clinit_check);
986 }
987 }
988 return clinit_check;
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +0100989}
990
Vladimir Marko58155012015-08-19 12:49:41 +0000991HInvokeStaticOrDirect::DispatchInfo HGraphBuilder::ComputeDispatchInfo(
992 bool is_string_init,
993 int32_t string_init_offset,
994 MethodReference target_method,
995 uintptr_t direct_method,
996 uintptr_t direct_code) {
997 HInvokeStaticOrDirect::MethodLoadKind method_load_kind;
998 HInvokeStaticOrDirect::CodePtrLocation code_ptr_location;
999 uint64_t method_load_data = 0u;
1000 uint64_t direct_code_ptr = 0u;
1001
1002 if (is_string_init) {
1003 // TODO: Use direct_method and direct_code for the appropriate StringFactory method.
1004 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kStringInit;
1005 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod;
1006 method_load_data = string_init_offset;
1007 } else if (target_method.dex_file == outer_compilation_unit_->GetDexFile() &&
1008 target_method.dex_method_index == outer_compilation_unit_->GetDexMethodIndex()) {
1009 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kRecursive;
1010 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallSelf;
1011 } else {
1012 if (direct_method != 0u) { // Should we use a direct pointer to the method?
1013 if (direct_method != static_cast<uintptr_t>(-1)) { // Is the method pointer known now?
1014 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDirectAddress;
1015 method_load_data = direct_method;
1016 } else { // The direct pointer will be known at link time.
1017 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDirectAddressWithFixup;
1018 }
1019 } else { // Use dex cache.
1020 DCHECK(target_method.dex_file == dex_compilation_unit_->GetDexFile());
1021 DexCacheArraysLayout layout =
1022 compiler_driver_->GetDexCacheArraysLayout(target_method.dex_file);
1023 if (layout.Valid()) { // Can we use PC-relative access to the dex cache arrays?
1024 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDexCachePcRelative;
1025 method_load_data = layout.MethodOffset(target_method.dex_method_index);
1026 } else { // We must go through the ArtMethod's pointer to resolved methods.
1027 method_load_kind = HInvokeStaticOrDirect::MethodLoadKind::kDexCacheViaMethod;
1028 }
1029 }
1030 if (direct_code != 0u) { // Should we use a direct pointer to the code?
1031 if (direct_code != static_cast<uintptr_t>(-1)) { // Is the code pointer known now?
1032 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallDirect;
1033 direct_code_ptr = direct_code;
1034 } else if (compiler_driver_->IsImage() ||
1035 target_method.dex_file == dex_compilation_unit_->GetDexFile()) {
1036 // Use PC-relative calls for invokes within a multi-dex oat file.
1037 // TODO: Recognize when the target dex file is within the current oat file for
1038 // app compilation. At the moment we recognize only the boot image as multi-dex.
1039 // NOTE: This will require changing the ARM backend which currently falls
1040 // through from kCallPCRelative to kDirectCodeFixup for different dex files.
1041 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallPCRelative;
1042 } else { // The direct pointer will be known at link time.
1043 // NOTE: This is used for app->boot calls when compiling an app against
1044 // a relocatable but not yet relocated image.
1045 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallDirectWithFixup;
1046 }
1047 } else { // We must use the code pointer from the ArtMethod.
1048 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod;
1049 }
1050 }
1051
1052 if (graph_->IsDebuggable()) {
1053 // For debuggable apps always use the code pointer from ArtMethod
1054 // so that we don't circumvent instrumentation stubs if installed.
1055 code_ptr_location = HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod;
1056 }
1057
1058 return HInvokeStaticOrDirect::DispatchInfo {
1059 method_load_kind, code_ptr_location, method_load_data, direct_code_ptr };
1060}
1061
Calin Juravle5d01db12015-08-25 15:02:42 +01001062bool HGraphBuilder::SetupInvokeArguments(HInvoke* invoke,
1063 uint32_t number_of_vreg_arguments,
1064 uint32_t* args,
1065 uint32_t register_index,
1066 bool is_range,
1067 const char* descriptor,
1068 size_t start_index,
1069 size_t* argument_index) {
Calin Juravle68ad6492015-08-18 17:08:12 +01001070 uint32_t descriptor_index = 1; // Skip the return type.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001071 uint32_t dex_pc = invoke->GetDexPc();
Calin Juravle68ad6492015-08-18 17:08:12 +01001072
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001073 for (size_t i = start_index;
1074 // Make sure we don't go over the expected arguments or over the number of
1075 // dex registers given. If the instruction was seen as dead by the verifier,
1076 // it hasn't been properly checked.
Calin Juravle5d01db12015-08-25 15:02:42 +01001077 (i < number_of_vreg_arguments) && (*argument_index < invoke->GetNumberOfArguments());
1078 i++, (*argument_index)++) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001079 Primitive::Type type = Primitive::GetType(descriptor[descriptor_index++]);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001080 bool is_wide = (type == Primitive::kPrimLong) || (type == Primitive::kPrimDouble);
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001081 if (!is_range
1082 && is_wide
1083 && ((i + 1 == number_of_vreg_arguments) || (args[i] + 1 != args[i + 1]))) {
1084 // Longs and doubles should be in pairs, that is, sequential registers. The verifier should
1085 // reject any class where this is violated. However, the verifier only does these checks
1086 // on non trivially dead instructions, so we just bailout the compilation.
1087 VLOG(compiler) << "Did not compile "
1088 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
1089 << " because of non-sequential dex register pair in wide argument";
1090 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
1091 return false;
1092 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001093 HInstruction* arg = LoadLocal(is_range ? register_index + i : args[i], type, dex_pc);
Calin Juravle5d01db12015-08-25 15:02:42 +01001094 invoke->SetArgumentAt(*argument_index, arg);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01001095 if (is_wide) {
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001096 i++;
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001097 }
1098 }
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001099
Calin Juravle5d01db12015-08-25 15:02:42 +01001100 if (*argument_index != invoke->GetNumberOfArguments()) {
Nicolas Geoffray2e335252015-06-18 11:11:27 +01001101 VLOG(compiler) << "Did not compile "
1102 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
1103 << " because of wrong number of arguments in invoke instruction";
1104 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
1105 return false;
1106 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001107
Nicolas Geoffray38207af2015-06-01 15:46:22 +01001108 if (invoke->IsInvokeStaticOrDirect()) {
Calin Juravle5d01db12015-08-25 15:02:42 +01001109 invoke->SetArgumentAt(*argument_index, graph_->GetCurrentMethod());
1110 (*argument_index)++;
1111 }
1112
1113 return true;
1114}
1115
1116bool HGraphBuilder::HandleInvoke(HInvoke* invoke,
1117 uint32_t number_of_vreg_arguments,
1118 uint32_t* args,
1119 uint32_t register_index,
1120 bool is_range,
1121 const char* descriptor,
1122 HClinitCheck* clinit_check) {
1123 DCHECK(!invoke->IsInvokeStaticOrDirect() || !invoke->AsInvokeStaticOrDirect()->IsStringInit());
1124
1125 size_t start_index = 0;
1126 size_t argument_index = 0;
1127 if (invoke->GetOriginalInvokeType() != InvokeType::kStatic) { // Instance call.
1128 Temporaries temps(graph_);
1129 HInstruction* arg = LoadLocal(
1130 is_range ? register_index : args[0], Primitive::kPrimNot, invoke->GetDexPc());
1131 HNullCheck* null_check = new (arena_) HNullCheck(arg, invoke->GetDexPc());
1132 current_block_->AddInstruction(null_check);
1133 temps.Add(null_check);
1134 invoke->SetArgumentAt(0, null_check);
1135 start_index = 1;
1136 argument_index = 1;
1137 }
1138
1139 if (!SetupInvokeArguments(invoke,
1140 number_of_vreg_arguments,
1141 args,
1142 register_index,
1143 is_range,
1144 descriptor,
1145 start_index,
1146 &argument_index)) {
1147 return false;
Nicolas Geoffray38207af2015-06-01 15:46:22 +01001148 }
1149
Calin Juravle68ad6492015-08-18 17:08:12 +01001150 if (clinit_check != nullptr) {
Roland Levillain4c0eb422015-04-24 16:43:49 +01001151 // Add the class initialization check as last input of `invoke`.
Calin Juravle68ad6492015-08-18 17:08:12 +01001152 DCHECK(invoke->IsInvokeStaticOrDirect());
1153 DCHECK(invoke->AsInvokeStaticOrDirect()->GetClinitCheckRequirement()
1154 == HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit);
Roland Levillain3e3d7332015-04-28 11:00:54 +01001155 invoke->SetArgumentAt(argument_index, clinit_check);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +01001156 argument_index++;
Roland Levillain4c0eb422015-04-24 16:43:49 +01001157 }
1158
Calin Juravle5d01db12015-08-25 15:02:42 +01001159 current_block_->AddInstruction(invoke);
1160 latest_result_ = invoke;
1161
1162 return true;
1163}
1164
1165bool HGraphBuilder::HandleStringInit(HInvoke* invoke,
1166 uint32_t number_of_vreg_arguments,
1167 uint32_t* args,
1168 uint32_t register_index,
1169 bool is_range,
1170 const char* descriptor) {
1171 DCHECK(invoke->IsInvokeStaticOrDirect());
1172 DCHECK(invoke->AsInvokeStaticOrDirect()->IsStringInit());
1173
1174 size_t start_index = 1;
1175 size_t argument_index = 0;
1176 if (!SetupInvokeArguments(invoke,
1177 number_of_vreg_arguments,
1178 args,
1179 register_index,
1180 is_range,
1181 descriptor,
1182 start_index,
1183 &argument_index)) {
1184 return false;
Jeff Hao848f70a2014-01-15 13:49:50 -08001185 }
Calin Juravle0eedd7e2015-08-20 14:48:00 +01001186
Calin Juravle5d01db12015-08-25 15:02:42 +01001187 // Add move-result for StringFactory method.
1188 uint32_t orig_this_reg = is_range ? register_index : args[0];
1189 HInstruction* fake_string = LoadLocal(orig_this_reg, Primitive::kPrimNot, invoke->GetDexPc());
1190 invoke->SetArgumentAt(argument_index, fake_string);
1191 current_block_->AddInstruction(invoke);
1192 PotentiallySimplifyFakeString(orig_this_reg, invoke->GetDexPc(), invoke);
1193
Calin Juravle0eedd7e2015-08-20 14:48:00 +01001194 latest_result_ = invoke;
1195
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001196 return true;
1197}
1198
Calin Juravle68ad6492015-08-18 17:08:12 +01001199void HGraphBuilder::PotentiallySimplifyFakeString(uint16_t original_dex_register,
1200 uint32_t dex_pc,
1201 HInvoke* actual_string) {
1202 if (!graph_->IsDebuggable()) {
1203 // Notify that we cannot compile with baseline. The dex registers aliasing
1204 // with `original_dex_register` will be handled when we optimize
1205 // (see HInstructionSimplifer::VisitFakeString).
1206 can_use_baseline_for_string_init_ = false;
1207 return;
1208 }
1209 const VerifiedMethod* verified_method =
1210 compiler_driver_->GetVerifiedMethod(dex_file_, dex_compilation_unit_->GetDexMethodIndex());
1211 if (verified_method != nullptr) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001212 UpdateLocal(original_dex_register, actual_string, dex_pc);
Calin Juravle68ad6492015-08-18 17:08:12 +01001213 const SafeMap<uint32_t, std::set<uint32_t>>& string_init_map =
1214 verified_method->GetStringInitPcRegMap();
1215 auto map_it = string_init_map.find(dex_pc);
1216 if (map_it != string_init_map.end()) {
1217 std::set<uint32_t> reg_set = map_it->second;
1218 for (auto set_it = reg_set.begin(); set_it != reg_set.end(); ++set_it) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001219 HInstruction* load_local = LoadLocal(original_dex_register, Primitive::kPrimNot, dex_pc);
1220 UpdateLocal(*set_it, load_local, dex_pc);
Calin Juravle68ad6492015-08-18 17:08:12 +01001221 }
1222 }
1223 } else {
1224 can_use_baseline_for_string_init_ = false;
1225 }
1226}
1227
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001228bool HGraphBuilder::BuildInstanceFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001229 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001230 bool is_put) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001231 uint32_t source_or_dest_reg = instruction.VRegA_22c();
1232 uint32_t obj_reg = instruction.VRegB_22c();
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001233 uint16_t field_index;
1234 if (instruction.IsQuickened()) {
1235 if (!CanDecodeQuickenedInfo()) {
1236 return false;
1237 }
1238 field_index = LookupQuickenedInfo(dex_pc);
1239 } else {
1240 field_index = instruction.VRegC_22c();
1241 }
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001242
1243 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -07001244 ArtField* resolved_field =
1245 compiler_driver_->ComputeInstanceFieldInfo(field_index, dex_compilation_unit_, is_put, soa);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001246
Mathieu Chartierc7853442015-03-27 14:35:38 -07001247 if (resolved_field == nullptr) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001248 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001249 return false;
1250 }
Calin Juravle52c48962014-12-16 17:02:57 +00001251
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001252 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001253
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001254 HInstruction* object = LoadLocal(obj_reg, Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001255 current_block_->AddInstruction(new (arena_) HNullCheck(object, dex_pc));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001256 if (is_put) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001257 Temporaries temps(graph_);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001258 HInstruction* null_check = current_block_->GetLastInstruction();
1259 // We need one temporary for the null check.
1260 temps.Add(null_check);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001261 HInstruction* value = LoadLocal(source_or_dest_reg, field_type, dex_pc);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001262 current_block_->AddInstruction(new (arena_) HInstanceFieldSet(
1263 null_check,
1264 value,
Nicolas Geoffray39468442014-09-02 15:17:15 +01001265 field_type,
Calin Juravle52c48962014-12-16 17:02:57 +00001266 resolved_field->GetOffset(),
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001267 resolved_field->IsVolatile(),
1268 field_index,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001269 *dex_file_,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001270 dex_compilation_unit_->GetDexCache(),
1271 dex_pc));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001272 } else {
1273 current_block_->AddInstruction(new (arena_) HInstanceFieldGet(
1274 current_block_->GetLastInstruction(),
Nicolas Geoffrayabed4d02014-07-14 15:24:11 +01001275 field_type,
Calin Juravle52c48962014-12-16 17:02:57 +00001276 resolved_field->GetOffset(),
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001277 resolved_field->IsVolatile(),
1278 field_index,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001279 *dex_file_,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001280 dex_compilation_unit_->GetDexCache(),
1281 dex_pc));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001282
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001283 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001284 }
1285 return true;
1286}
1287
Nicolas Geoffray30451742015-06-19 13:32:41 +01001288static mirror::Class* GetClassFrom(CompilerDriver* driver,
1289 const DexCompilationUnit& compilation_unit) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001290 ScopedObjectAccess soa(Thread::Current());
1291 StackHandleScope<2> hs(soa.Self());
Nicolas Geoffray30451742015-06-19 13:32:41 +01001292 const DexFile& dex_file = *compilation_unit.GetDexFile();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001293 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
Nicolas Geoffray30451742015-06-19 13:32:41 +01001294 soa.Decode<mirror::ClassLoader*>(compilation_unit.GetClassLoader())));
1295 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001296 compilation_unit.GetClassLinker()->FindDexCache(soa.Self(), dex_file)));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001297
Nicolas Geoffray30451742015-06-19 13:32:41 +01001298 return driver->ResolveCompilingMethodsClass(soa, dex_cache, class_loader, &compilation_unit);
1299}
1300
1301mirror::Class* HGraphBuilder::GetOutermostCompilingClass() const {
1302 return GetClassFrom(compiler_driver_, *outer_compilation_unit_);
1303}
1304
1305mirror::Class* HGraphBuilder::GetCompilingClass() const {
1306 return GetClassFrom(compiler_driver_, *dex_compilation_unit_);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001307}
1308
1309bool HGraphBuilder::IsOutermostCompilingClass(uint16_t type_index) const {
1310 ScopedObjectAccess soa(Thread::Current());
1311 StackHandleScope<4> hs(soa.Self());
1312 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001313 dex_compilation_unit_->GetClassLinker()->FindDexCache(
1314 soa.Self(), *dex_compilation_unit_->GetDexFile())));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001315 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1316 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
1317 Handle<mirror::Class> cls(hs.NewHandle(compiler_driver_->ResolveClass(
1318 soa, dex_cache, class_loader, type_index, dex_compilation_unit_)));
Nicolas Geoffrayafd06412015-06-20 22:44:47 +01001319 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001320
Nicolas Geoffrayafd06412015-06-20 22:44:47 +01001321 return outer_class.Get() == cls.Get();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001322}
1323
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001324bool HGraphBuilder::BuildStaticFieldAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001325 uint32_t dex_pc,
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001326 bool is_put) {
1327 uint32_t source_or_dest_reg = instruction.VRegA_21c();
1328 uint16_t field_index = instruction.VRegB_21c();
1329
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001330 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartierc7853442015-03-27 14:35:38 -07001331 StackHandleScope<4> hs(soa.Self());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001332 Handle<mirror::DexCache> dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001333 dex_compilation_unit_->GetClassLinker()->FindDexCache(
1334 soa.Self(), *dex_compilation_unit_->GetDexFile())));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001335 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1336 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
Mathieu Chartierc7853442015-03-27 14:35:38 -07001337 ArtField* resolved_field = compiler_driver_->ResolveField(
1338 soa, dex_cache, class_loader, dex_compilation_unit_, field_index, true);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001339
Mathieu Chartierc7853442015-03-27 14:35:38 -07001340 if (resolved_field == nullptr) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001341 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnresolvedField);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001342 return false;
1343 }
1344
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001345 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
1346 Handle<mirror::DexCache> outer_dex_cache(hs.NewHandle(
Mathieu Chartier673ed3d2015-08-28 14:56:43 -07001347 outer_compilation_unit_->GetClassLinker()->FindDexCache(soa.Self(), outer_dex_file)));
Nicolas Geoffray30451742015-06-19 13:32:41 +01001348 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001349
1350 // The index at which the field's class is stored in the DexCache's type array.
1351 uint32_t storage_index;
Nicolas Geoffray30451742015-06-19 13:32:41 +01001352 bool is_outer_class = (outer_class.Get() == resolved_field->GetDeclaringClass());
1353 if (is_outer_class) {
1354 storage_index = outer_class->GetDexTypeIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001355 } else if (outer_dex_cache.Get() != dex_cache.Get()) {
Roland Levillain4c0eb422015-04-24 16:43:49 +01001356 // The compiler driver cannot currently understand multiple dex caches involved. Just bailout.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001357 return false;
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001358 } else {
1359 std::pair<bool, bool> pair = compiler_driver_->IsFastStaticField(
1360 outer_dex_cache.Get(),
Nicolas Geoffray30451742015-06-19 13:32:41 +01001361 GetCompilingClass(),
Mathieu Chartierc7853442015-03-27 14:35:38 -07001362 resolved_field,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001363 field_index,
1364 &storage_index);
1365 bool can_easily_access = is_put ? pair.second : pair.first;
1366 if (!can_easily_access) {
1367 return false;
1368 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001369 }
1370
1371 // TODO: find out why this check is needed.
1372 bool is_in_dex_cache = compiler_driver_->CanAssumeTypeIsPresentInDexCache(
Nicolas Geoffray6a816cf2015-03-24 16:17:56 +00001373 *outer_compilation_unit_->GetDexFile(), storage_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001374 bool is_initialized = resolved_field->GetDeclaringClass()->IsInitialized() && is_in_dex_cache;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001375
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001376 HLoadClass* constant = new (arena_) HLoadClass(graph_->GetCurrentMethod(),
1377 storage_index,
1378 *dex_compilation_unit_->GetDexFile(),
Nicolas Geoffray30451742015-06-19 13:32:41 +01001379 is_outer_class,
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001380 dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001381 current_block_->AddInstruction(constant);
1382
1383 HInstruction* cls = constant;
Nicolas Geoffray30451742015-06-19 13:32:41 +01001384 if (!is_initialized && !is_outer_class) {
Calin Juravle225ff812014-11-13 16:46:39 +00001385 cls = new (arena_) HClinitCheck(constant, dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001386 current_block_->AddInstruction(cls);
1387 }
1388
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001389 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001390 if (is_put) {
1391 // We need to keep the class alive before loading the value.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001392 Temporaries temps(graph_);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001393 temps.Add(cls);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001394 HInstruction* value = LoadLocal(source_or_dest_reg, field_type, dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001395 DCHECK_EQ(value->GetType(), field_type);
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001396 current_block_->AddInstruction(new (arena_) HStaticFieldSet(cls,
1397 value,
1398 field_type,
1399 resolved_field->GetOffset(),
1400 resolved_field->IsVolatile(),
1401 field_index,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001402 *dex_file_,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001403 dex_cache_,
1404 dex_pc));
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001405 } else {
Guillaume "Vermeille" Sanchez104fd8a2015-05-20 17:52:13 +01001406 current_block_->AddInstruction(new (arena_) HStaticFieldGet(cls,
1407 field_type,
1408 resolved_field->GetOffset(),
1409 resolved_field->IsVolatile(),
1410 field_index,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001411 *dex_file_,
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001412 dex_cache_,
1413 dex_pc));
1414 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01001415 }
1416 return true;
1417}
1418
Calin Juravlebacfec32014-11-14 15:54:36 +00001419void HGraphBuilder::BuildCheckedDivRem(uint16_t out_vreg,
1420 uint16_t first_vreg,
1421 int64_t second_vreg_or_constant,
1422 uint32_t dex_pc,
1423 Primitive::Type type,
1424 bool second_is_constant,
1425 bool isDiv) {
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001426 DCHECK(type == Primitive::kPrimInt || type == Primitive::kPrimLong);
Calin Juravled0d48522014-11-04 16:40:20 +00001427
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001428 HInstruction* first = LoadLocal(first_vreg, type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001429 HInstruction* second = nullptr;
1430 if (second_is_constant) {
1431 if (type == Primitive::kPrimInt) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001432 second = graph_->GetIntConstant(second_vreg_or_constant, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001433 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001434 second = graph_->GetLongConstant(second_vreg_or_constant, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001435 }
1436 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001437 second = LoadLocal(second_vreg_or_constant, type, dex_pc);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00001438 }
1439
1440 if (!second_is_constant
1441 || (type == Primitive::kPrimInt && second->AsIntConstant()->GetValue() == 0)
1442 || (type == Primitive::kPrimLong && second->AsLongConstant()->GetValue() == 0)) {
1443 second = new (arena_) HDivZeroCheck(second, dex_pc);
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001444 Temporaries temps(graph_);
Calin Juravled0d48522014-11-04 16:40:20 +00001445 current_block_->AddInstruction(second);
1446 temps.Add(current_block_->GetLastInstruction());
1447 }
1448
Calin Juravlebacfec32014-11-14 15:54:36 +00001449 if (isDiv) {
1450 current_block_->AddInstruction(new (arena_) HDiv(type, first, second, dex_pc));
1451 } else {
1452 current_block_->AddInstruction(new (arena_) HRem(type, first, second, dex_pc));
1453 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001454 UpdateLocal(out_vreg, current_block_->GetLastInstruction(), dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001455}
1456
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001457void HGraphBuilder::BuildArrayAccess(const Instruction& instruction,
Calin Juravle225ff812014-11-13 16:46:39 +00001458 uint32_t dex_pc,
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001459 bool is_put,
1460 Primitive::Type anticipated_type) {
1461 uint8_t source_or_dest_reg = instruction.VRegA_23x();
1462 uint8_t array_reg = instruction.VRegB_23x();
1463 uint8_t index_reg = instruction.VRegC_23x();
1464
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001465 // We need one temporary for the null check, one for the index, and one for the length.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001466 Temporaries temps(graph_);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001467
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001468 HInstruction* object = LoadLocal(array_reg, Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001469 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001470 current_block_->AddInstruction(object);
1471 temps.Add(object);
1472
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001473 HInstruction* length = new (arena_) HArrayLength(object, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001474 current_block_->AddInstruction(length);
1475 temps.Add(length);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001476 HInstruction* index = LoadLocal(index_reg, Primitive::kPrimInt, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001477 index = new (arena_) HBoundsCheck(index, length, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001478 current_block_->AddInstruction(index);
1479 temps.Add(index);
1480 if (is_put) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001481 HInstruction* value = LoadLocal(source_or_dest_reg, anticipated_type, dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001482 // TODO: Insert a type check node if the type is Object.
Nicolas Geoffray39468442014-09-02 15:17:15 +01001483 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001484 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001485 } else {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001486 current_block_->AddInstruction(new (arena_) HArrayGet(object, index, anticipated_type, dex_pc));
1487 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001488 }
Mark Mendell1152c922015-04-24 17:06:35 -04001489 graph_->SetHasBoundsChecks(true);
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01001490}
1491
Calin Juravle225ff812014-11-13 16:46:39 +00001492void HGraphBuilder::BuildFilledNewArray(uint32_t dex_pc,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001493 uint32_t type_index,
1494 uint32_t number_of_vreg_arguments,
1495 bool is_range,
1496 uint32_t* args,
1497 uint32_t register_index) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001498 HInstruction* length = graph_->GetIntConstant(number_of_vreg_arguments, dex_pc);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001499 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
1500 ? kQuickAllocArrayWithAccessCheck
1501 : kQuickAllocArray;
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001502 HInstruction* object = new (arena_) HNewArray(length,
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01001503 graph_->GetCurrentMethod(),
Guillaume "Vermeille" Sanchez81d804a2015-05-20 12:42:25 +01001504 dex_pc,
1505 type_index,
1506 *dex_compilation_unit_->GetDexFile(),
1507 entrypoint);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001508 current_block_->AddInstruction(object);
1509
1510 const char* descriptor = dex_file_->StringByTypeIdx(type_index);
1511 DCHECK_EQ(descriptor[0], '[') << descriptor;
1512 char primitive = descriptor[1];
1513 DCHECK(primitive == 'I'
1514 || primitive == 'L'
1515 || primitive == '[') << descriptor;
1516 bool is_reference_array = (primitive == 'L') || (primitive == '[');
1517 Primitive::Type type = is_reference_array ? Primitive::kPrimNot : Primitive::kPrimInt;
1518
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001519 Temporaries temps(graph_);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001520 temps.Add(object);
1521 for (size_t i = 0; i < number_of_vreg_arguments; ++i) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001522 HInstruction* value = LoadLocal(is_range ? register_index + i : args[i], type, dex_pc);
1523 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001524 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001525 new (arena_) HArraySet(object, index, value, type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001526 }
1527 latest_result_ = object;
1528}
1529
1530template <typename T>
1531void HGraphBuilder::BuildFillArrayData(HInstruction* object,
1532 const T* data,
1533 uint32_t element_count,
1534 Primitive::Type anticipated_type,
Calin Juravle225ff812014-11-13 16:46:39 +00001535 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001536 for (uint32_t i = 0; i < element_count; ++i) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001537 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1538 HInstruction* value = graph_->GetIntConstant(data[i], dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001539 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001540 object, index, value, anticipated_type, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001541 }
1542}
1543
Calin Juravle225ff812014-11-13 16:46:39 +00001544void HGraphBuilder::BuildFillArrayData(const Instruction& instruction, uint32_t dex_pc) {
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001545 Temporaries temps(graph_);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001546 HInstruction* array = LoadLocal(instruction.VRegA_31t(), Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001547 HNullCheck* null_check = new (arena_) HNullCheck(array, dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001548 current_block_->AddInstruction(null_check);
1549 temps.Add(null_check);
1550
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001551 HInstruction* length = new (arena_) HArrayLength(null_check, dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001552 current_block_->AddInstruction(length);
1553
Calin Juravle225ff812014-11-13 16:46:39 +00001554 int32_t payload_offset = instruction.VRegB_31t() + dex_pc;
Calin Juravled0d48522014-11-04 16:40:20 +00001555 const Instruction::ArrayDataPayload* payload =
1556 reinterpret_cast<const Instruction::ArrayDataPayload*>(code_start_ + payload_offset);
1557 const uint8_t* data = payload->data;
1558 uint32_t element_count = payload->element_count;
1559
1560 // Implementation of this DEX instruction seems to be that the bounds check is
1561 // done before doing any stores.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001562 HInstruction* last_index = graph_->GetIntConstant(payload->element_count - 1, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00001563 current_block_->AddInstruction(new (arena_) HBoundsCheck(last_index, length, dex_pc));
Calin Juravled0d48522014-11-04 16:40:20 +00001564
1565 switch (payload->element_width) {
1566 case 1:
1567 BuildFillArrayData(null_check,
1568 reinterpret_cast<const int8_t*>(data),
1569 element_count,
1570 Primitive::kPrimByte,
Calin Juravle225ff812014-11-13 16:46:39 +00001571 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001572 break;
1573 case 2:
1574 BuildFillArrayData(null_check,
1575 reinterpret_cast<const int16_t*>(data),
1576 element_count,
1577 Primitive::kPrimShort,
Calin Juravle225ff812014-11-13 16:46:39 +00001578 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001579 break;
1580 case 4:
1581 BuildFillArrayData(null_check,
1582 reinterpret_cast<const int32_t*>(data),
1583 element_count,
1584 Primitive::kPrimInt,
Calin Juravle225ff812014-11-13 16:46:39 +00001585 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001586 break;
1587 case 8:
1588 BuildFillWideArrayData(null_check,
1589 reinterpret_cast<const int64_t*>(data),
1590 element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001591 dex_pc);
Calin Juravled0d48522014-11-04 16:40:20 +00001592 break;
1593 default:
1594 LOG(FATAL) << "Unknown element width for " << payload->element_width;
1595 }
Mark Mendell1152c922015-04-24 17:06:35 -04001596 graph_->SetHasBoundsChecks(true);
Calin Juravled0d48522014-11-04 16:40:20 +00001597}
1598
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001599void HGraphBuilder::BuildFillWideArrayData(HInstruction* object,
Nicolas Geoffray8d6ae522014-10-23 18:32:13 +01001600 const int64_t* data,
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001601 uint32_t element_count,
Calin Juravle225ff812014-11-13 16:46:39 +00001602 uint32_t dex_pc) {
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001603 for (uint32_t i = 0; i < element_count; ++i) {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001604 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1605 HInstruction* value = graph_->GetLongConstant(data[i], dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001606 current_block_->AddInstruction(new (arena_) HArraySet(
Calin Juravle225ff812014-11-13 16:46:39 +00001607 object, index, value, Primitive::kPrimLong, dex_pc));
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01001608 }
1609}
1610
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001611bool HGraphBuilder::BuildTypeCheck(const Instruction& instruction,
1612 uint8_t destination,
1613 uint8_t reference,
1614 uint16_t type_index,
Calin Juravle225ff812014-11-13 16:46:39 +00001615 uint32_t dex_pc) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001616 bool type_known_final;
1617 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001618 // `CanAccessTypeWithoutChecks` will tell whether the method being
1619 // built is trying to access its own class, so that the generated
1620 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001621 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001622 bool dont_use_is_referrers_class;
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001623 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
1624 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001625 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001626 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00001627 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001628 return false;
1629 }
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001630 HInstruction* object = LoadLocal(reference, Primitive::kPrimNot, dex_pc);
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001631 HLoadClass* cls = new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01001632 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01001633 type_index,
1634 *dex_compilation_unit_->GetDexFile(),
1635 IsOutermostCompilingClass(type_index),
1636 dex_pc);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001637 current_block_->AddInstruction(cls);
1638 // The class needs a temporary before being used by the type check.
Calin Juravlef97f9fb2014-11-11 15:38:19 +00001639 Temporaries temps(graph_);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001640 temps.Add(cls);
1641 if (instruction.Opcode() == Instruction::INSTANCE_OF) {
1642 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001643 new (arena_) HInstanceOf(object, cls, type_known_final, dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001644 UpdateLocal(destination, current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001645 } else {
1646 DCHECK_EQ(instruction.Opcode(), Instruction::CHECK_CAST);
1647 current_block_->AddInstruction(
Calin Juravle225ff812014-11-13 16:46:39 +00001648 new (arena_) HCheckCast(object, cls, type_known_final, dex_pc));
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00001649 }
1650 return true;
1651}
1652
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00001653bool HGraphBuilder::NeedsAccessCheck(uint32_t type_index) const {
1654 return !compiler_driver_->CanAccessInstantiableTypeWithoutChecks(
1655 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index);
1656}
1657
Calin Juravle48c2b032014-12-09 18:11:36 +00001658void HGraphBuilder::BuildPackedSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001659 // Verifier guarantees that the payload for PackedSwitch contains:
1660 // (a) number of entries (may be zero)
1661 // (b) first and lowest switch case value (entry 0, always present)
1662 // (c) list of target pcs (entries 1 <= i <= N)
Andreas Gamped881df52014-11-24 23:28:39 -08001663 SwitchTable table(instruction, dex_pc, false);
1664
1665 // Value to test against.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001666 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08001667
David Brazdil2ef645b2015-06-17 18:20:52 +01001668 // Retrieve number of entries.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001669 uint16_t num_entries = table.GetNumEntries();
David Brazdil2ef645b2015-06-17 18:20:52 +01001670 if (num_entries == 0) {
1671 return;
1672 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001673
Andreas Gamped881df52014-11-24 23:28:39 -08001674 // Chained cmp-and-branch, starting from starting_key.
1675 int32_t starting_key = table.GetEntryAt(0);
1676
Andreas Gamped881df52014-11-24 23:28:39 -08001677 for (size_t i = 1; i <= num_entries; i++) {
Andreas Gampee4d4d322014-12-04 09:09:57 -08001678 BuildSwitchCaseHelper(instruction, i, i == num_entries, table, value, starting_key + i - 1,
1679 table.GetEntryAt(i), dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08001680 }
Andreas Gamped881df52014-11-24 23:28:39 -08001681}
1682
Calin Juravle48c2b032014-12-09 18:11:36 +00001683void HGraphBuilder::BuildSparseSwitch(const Instruction& instruction, uint32_t dex_pc) {
David Brazdil2ef645b2015-06-17 18:20:52 +01001684 // Verifier guarantees that the payload for SparseSwitch contains:
1685 // (a) number of entries (may be zero)
1686 // (b) sorted key values (entries 0 <= i < N)
1687 // (c) target pcs corresponding to the switch values (entries N <= i < 2*N)
Andreas Gampee4d4d322014-12-04 09:09:57 -08001688 SwitchTable table(instruction, dex_pc, true);
1689
1690 // Value to test against.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001691 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001692
1693 uint16_t num_entries = table.GetNumEntries();
Andreas Gampee4d4d322014-12-04 09:09:57 -08001694
1695 for (size_t i = 0; i < num_entries; i++) {
1696 BuildSwitchCaseHelper(instruction, i, i == static_cast<size_t>(num_entries) - 1, table, value,
1697 table.GetEntryAt(i), table.GetEntryAt(i + num_entries), dex_pc);
1698 }
Andreas Gampee4d4d322014-12-04 09:09:57 -08001699}
1700
1701void HGraphBuilder::BuildSwitchCaseHelper(const Instruction& instruction, size_t index,
1702 bool is_last_case, const SwitchTable& table,
1703 HInstruction* value, int32_t case_value_int,
1704 int32_t target_offset, uint32_t dex_pc) {
David Brazdil852eaff2015-02-02 15:23:05 +00001705 HBasicBlock* case_target = FindBlockStartingAt(dex_pc + target_offset);
1706 DCHECK(case_target != nullptr);
1707 PotentiallyAddSuspendCheck(case_target, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001708
1709 // The current case's value.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001710 HInstruction* this_case_value = graph_->GetIntConstant(case_value_int, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001711
1712 // Compare value and this_case_value.
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001713 HEqual* comparison = new (arena_) HEqual(value, this_case_value, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001714 current_block_->AddInstruction(comparison);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001715 HInstruction* ifinst = new (arena_) HIf(comparison, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08001716 current_block_->AddInstruction(ifinst);
1717
1718 // Case hit: use the target offset to determine where to go.
Andreas Gampee4d4d322014-12-04 09:09:57 -08001719 current_block_->AddSuccessor(case_target);
1720
1721 // Case miss: go to the next case (or default fall-through).
1722 // When there is a next case, we use the block stored with the table offset representing this
1723 // case (that is where we registered them in ComputeBranchTargets).
1724 // When there is no next case, we use the following instruction.
1725 // TODO: Find a good way to peel the last iteration to avoid conditional, but still have re-use.
1726 if (!is_last_case) {
1727 HBasicBlock* next_case_target = FindBlockStartingAt(table.GetDexPcForIndex(index));
1728 DCHECK(next_case_target != nullptr);
1729 current_block_->AddSuccessor(next_case_target);
1730
1731 // Need to manually add the block, as there is no dex-pc transition for the cases.
1732 graph_->AddBlock(next_case_target);
1733
1734 current_block_ = next_case_target;
1735 } else {
1736 HBasicBlock* default_target = FindBlockStartingAt(dex_pc + instruction.SizeInCodeUnits());
1737 DCHECK(default_target != nullptr);
1738 current_block_->AddSuccessor(default_target);
1739 current_block_ = nullptr;
1740 }
1741}
1742
David Brazdil852eaff2015-02-02 15:23:05 +00001743void HGraphBuilder::PotentiallyAddSuspendCheck(HBasicBlock* target, uint32_t dex_pc) {
1744 int32_t target_offset = target->GetDexPc() - dex_pc;
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001745 if (target_offset <= 0) {
David Brazdil852eaff2015-02-02 15:23:05 +00001746 // DX generates back edges to the first encountered return. We can save
1747 // time of later passes by not adding redundant suspend checks.
David Brazdil2fd6aa52015-02-02 18:58:27 +00001748 HInstruction* last_in_target = target->GetLastInstruction();
1749 if (last_in_target != nullptr &&
1750 (last_in_target->IsReturn() || last_in_target->IsReturnVoid())) {
1751 return;
David Brazdil852eaff2015-02-02 15:23:05 +00001752 }
1753
1754 // Add a suspend check to backward branches which may potentially loop. We
1755 // can remove them after we recognize loops in the graph.
Calin Juravle225ff812014-11-13 16:46:39 +00001756 current_block_->AddInstruction(new (arena_) HSuspendCheck(dex_pc));
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001757 }
1758}
1759
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001760bool HGraphBuilder::CanDecodeQuickenedInfo() const {
1761 return interpreter_metadata_ != nullptr;
1762}
1763
1764uint16_t HGraphBuilder::LookupQuickenedInfo(uint32_t dex_pc) {
1765 DCHECK(interpreter_metadata_ != nullptr);
1766 uint32_t dex_pc_in_map = DecodeUnsignedLeb128(&interpreter_metadata_);
1767 DCHECK_EQ(dex_pc, dex_pc_in_map);
1768 return DecodeUnsignedLeb128(&interpreter_metadata_);
1769}
1770
Calin Juravle225ff812014-11-13 16:46:39 +00001771bool HGraphBuilder::AnalyzeDexInstruction(const Instruction& instruction, uint32_t dex_pc) {
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001772 if (current_block_ == nullptr) {
1773 return true; // Dead code
1774 }
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001775
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001776 switch (instruction.Opcode()) {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001777 case Instruction::CONST_4: {
1778 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001779 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_11n(), dex_pc);
1780 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00001781 break;
1782 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001783
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001784 case Instruction::CONST_16: {
1785 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001786 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21s(), dex_pc);
1787 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001788 break;
1789 }
1790
Dave Allison20dfc792014-06-16 20:44:29 -07001791 case Instruction::CONST: {
1792 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001793 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_31i(), dex_pc);
1794 UpdateLocal(register_index, constant, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001795 break;
1796 }
1797
1798 case Instruction::CONST_HIGH16: {
1799 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001800 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21h() << 16, dex_pc);
1801 UpdateLocal(register_index, constant, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001802 break;
1803 }
1804
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001805 case Instruction::CONST_WIDE_16: {
1806 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001807 // Get 16 bits of constant value, sign extended to 64 bits.
1808 int64_t value = instruction.VRegB_21s();
1809 value <<= 48;
1810 value >>= 48;
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001811 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1812 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001813 break;
1814 }
1815
1816 case Instruction::CONST_WIDE_32: {
1817 int32_t register_index = instruction.VRegA();
Dave Allison20dfc792014-06-16 20:44:29 -07001818 // Get 32 bits of constant value, sign extended to 64 bits.
1819 int64_t value = instruction.VRegB_31i();
1820 value <<= 32;
1821 value >>= 32;
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001822 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1823 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001824 break;
1825 }
1826
1827 case Instruction::CONST_WIDE: {
1828 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001829 HLongConstant* constant = graph_->GetLongConstant(instruction.VRegB_51l(), dex_pc);
1830 UpdateLocal(register_index, constant, dex_pc);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001831 break;
1832 }
1833
Dave Allison20dfc792014-06-16 20:44:29 -07001834 case Instruction::CONST_WIDE_HIGH16: {
1835 int32_t register_index = instruction.VRegA();
1836 int64_t value = static_cast<int64_t>(instruction.VRegB_21h()) << 48;
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001837 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1838 UpdateLocal(register_index, constant, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001839 break;
1840 }
1841
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001842 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001843 case Instruction::MOVE:
1844 case Instruction::MOVE_FROM16:
1845 case Instruction::MOVE_16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001846 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimInt, dex_pc);
1847 UpdateLocal(instruction.VRegA(), value, dex_pc);
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001848 break;
1849 }
1850
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001851 // Note that the SSA building will refine the types.
Dave Allison20dfc792014-06-16 20:44:29 -07001852 case Instruction::MOVE_WIDE:
1853 case Instruction::MOVE_WIDE_FROM16:
1854 case Instruction::MOVE_WIDE_16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001855 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimLong, dex_pc);
1856 UpdateLocal(instruction.VRegA(), value, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001857 break;
1858 }
1859
1860 case Instruction::MOVE_OBJECT:
1861 case Instruction::MOVE_OBJECT_16:
1862 case Instruction::MOVE_OBJECT_FROM16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001863 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimNot, dex_pc);
1864 UpdateLocal(instruction.VRegA(), value, dex_pc);
Dave Allison20dfc792014-06-16 20:44:29 -07001865 break;
1866 }
1867
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001868 case Instruction::RETURN_VOID_NO_BARRIER:
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001869 case Instruction::RETURN_VOID: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001870 BuildReturn(instruction, Primitive::kPrimVoid, dex_pc);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00001871 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001872 }
1873
Dave Allison20dfc792014-06-16 20:44:29 -07001874#define IF_XX(comparison, cond) \
Calin Juravle225ff812014-11-13 16:46:39 +00001875 case Instruction::IF_##cond: If_22t<comparison>(instruction, dex_pc); break; \
1876 case Instruction::IF_##cond##Z: If_21t<comparison>(instruction, dex_pc); break
Nicolas Geoffrayb55f8352014-04-07 15:26:35 +01001877
Dave Allison20dfc792014-06-16 20:44:29 -07001878 IF_XX(HEqual, EQ);
1879 IF_XX(HNotEqual, NE);
1880 IF_XX(HLessThan, LT);
1881 IF_XX(HLessThanOrEqual, LE);
1882 IF_XX(HGreaterThan, GT);
1883 IF_XX(HGreaterThanOrEqual, GE);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001884
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001885 case Instruction::GOTO:
1886 case Instruction::GOTO_16:
1887 case Instruction::GOTO_32: {
Nicolas Geoffrayfbc695f2014-09-15 15:33:30 +00001888 int32_t offset = instruction.GetTargetOffset();
Calin Juravle225ff812014-11-13 16:46:39 +00001889 HBasicBlock* target = FindBlockStartingAt(offset + dex_pc);
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001890 DCHECK(target != nullptr);
David Brazdil852eaff2015-02-02 15:23:05 +00001891 PotentiallyAddSuspendCheck(target, dex_pc);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001892 current_block_->AddInstruction(new (arena_) HGoto(dex_pc));
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00001893 current_block_->AddSuccessor(target);
1894 current_block_ = nullptr;
1895 break;
1896 }
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001897
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001898 case Instruction::RETURN: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001899 BuildReturn(instruction, return_type_, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001900 break;
1901 }
1902
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01001903 case Instruction::RETURN_OBJECT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001904 BuildReturn(instruction, return_type_, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001905 break;
1906 }
1907
1908 case Instruction::RETURN_WIDE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001909 BuildReturn(instruction, return_type_, dex_pc);
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00001910 break;
1911 }
1912
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001913 case Instruction::INVOKE_DIRECT:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001914 case Instruction::INVOKE_INTERFACE:
1915 case Instruction::INVOKE_STATIC:
1916 case Instruction::INVOKE_SUPER:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001917 case Instruction::INVOKE_VIRTUAL:
1918 case Instruction::INVOKE_VIRTUAL_QUICK: {
1919 uint16_t method_idx;
1920 if (instruction.Opcode() == Instruction::INVOKE_VIRTUAL_QUICK) {
1921 if (!CanDecodeQuickenedInfo()) {
1922 return false;
1923 }
1924 method_idx = LookupQuickenedInfo(dex_pc);
1925 } else {
1926 method_idx = instruction.VRegB_35c();
1927 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001928 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001929 uint32_t args[5];
Ian Rogers29a26482014-05-02 15:27:29 -07001930 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00001931 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00001932 number_of_vreg_arguments, false, args, -1)) {
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001933 return false;
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001934 }
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001935 break;
1936 }
1937
Nicolas Geoffraye982f0b2014-08-13 02:11:24 +01001938 case Instruction::INVOKE_DIRECT_RANGE:
Nicolas Geoffray0d8db992014-11-11 14:40:10 +00001939 case Instruction::INVOKE_INTERFACE_RANGE:
1940 case Instruction::INVOKE_STATIC_RANGE:
1941 case Instruction::INVOKE_SUPER_RANGE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001942 case Instruction::INVOKE_VIRTUAL_RANGE:
1943 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK: {
1944 uint16_t method_idx;
1945 if (instruction.Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK) {
1946 if (!CanDecodeQuickenedInfo()) {
1947 return false;
1948 }
1949 method_idx = LookupQuickenedInfo(dex_pc);
1950 } else {
1951 method_idx = instruction.VRegB_3rc();
1952 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001953 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
1954 uint32_t register_index = instruction.VRegC();
Calin Juravle225ff812014-11-13 16:46:39 +00001955 if (!BuildInvoke(instruction, dex_pc, method_idx,
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01001956 number_of_vreg_arguments, true, nullptr, register_index)) {
Nicolas Geoffray4a34a422014-04-03 10:38:37 +01001957 return false;
1958 }
Nicolas Geoffray8ccc3f52014-03-19 10:34:11 +00001959 break;
1960 }
1961
Roland Levillain88cb1752014-10-20 16:36:47 +01001962 case Instruction::NEG_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001963 Unop_12x<HNeg>(instruction, Primitive::kPrimInt, dex_pc);
Roland Levillain88cb1752014-10-20 16:36:47 +01001964 break;
1965 }
1966
Roland Levillain2e07b4f2014-10-23 18:12:09 +01001967 case Instruction::NEG_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001968 Unop_12x<HNeg>(instruction, Primitive::kPrimLong, dex_pc);
Roland Levillain2e07b4f2014-10-23 18:12:09 +01001969 break;
1970 }
1971
Roland Levillain3dbcb382014-10-28 17:30:07 +00001972 case Instruction::NEG_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001973 Unop_12x<HNeg>(instruction, Primitive::kPrimFloat, dex_pc);
Roland Levillain3dbcb382014-10-28 17:30:07 +00001974 break;
1975 }
1976
1977 case Instruction::NEG_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001978 Unop_12x<HNeg>(instruction, Primitive::kPrimDouble, dex_pc);
Roland Levillain3dbcb382014-10-28 17:30:07 +00001979 break;
1980 }
1981
Roland Levillain1cc5f2512014-10-22 18:06:21 +01001982 case Instruction::NOT_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001983 Unop_12x<HNot>(instruction, Primitive::kPrimInt, dex_pc);
Roland Levillain1cc5f2512014-10-22 18:06:21 +01001984 break;
1985 }
1986
Roland Levillain70566432014-10-24 16:20:17 +01001987 case Instruction::NOT_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06001988 Unop_12x<HNot>(instruction, Primitive::kPrimLong, dex_pc);
Roland Levillain70566432014-10-24 16:20:17 +01001989 break;
1990 }
1991
Roland Levillaindff1f282014-11-05 14:15:05 +00001992 case Instruction::INT_TO_LONG: {
Roland Levillain624279f2014-12-04 11:54:28 +00001993 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimLong, dex_pc);
Roland Levillaindff1f282014-11-05 14:15:05 +00001994 break;
1995 }
1996
Roland Levillaincff13742014-11-17 14:32:17 +00001997 case Instruction::INT_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00001998 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimFloat, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00001999 break;
2000 }
2001
2002 case Instruction::INT_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00002003 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimDouble, dex_pc);
Roland Levillaincff13742014-11-17 14:32:17 +00002004 break;
2005 }
2006
Roland Levillain946e1432014-11-11 17:35:19 +00002007 case Instruction::LONG_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002008 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimInt, dex_pc);
Roland Levillain946e1432014-11-11 17:35:19 +00002009 break;
2010 }
2011
Roland Levillain6d0e4832014-11-27 18:31:21 +00002012 case Instruction::LONG_TO_FLOAT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002013 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimFloat, dex_pc);
Roland Levillain6d0e4832014-11-27 18:31:21 +00002014 break;
2015 }
2016
Roland Levillain647b9ed2014-11-27 12:06:00 +00002017 case Instruction::LONG_TO_DOUBLE: {
Roland Levillain624279f2014-12-04 11:54:28 +00002018 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimDouble, dex_pc);
Roland Levillain647b9ed2014-11-27 12:06:00 +00002019 break;
2020 }
2021
Roland Levillain3f8f9362014-12-02 17:45:01 +00002022 case Instruction::FLOAT_TO_INT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002023 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimInt, dex_pc);
2024 break;
2025 }
2026
2027 case Instruction::FLOAT_TO_LONG: {
2028 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimLong, dex_pc);
Roland Levillain3f8f9362014-12-02 17:45:01 +00002029 break;
2030 }
2031
Roland Levillain8964e2b2014-12-04 12:10:50 +00002032 case Instruction::FLOAT_TO_DOUBLE: {
2033 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimDouble, dex_pc);
2034 break;
2035 }
2036
Roland Levillain4c0b61f2014-12-05 12:06:01 +00002037 case Instruction::DOUBLE_TO_INT: {
2038 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimInt, dex_pc);
2039 break;
2040 }
2041
2042 case Instruction::DOUBLE_TO_LONG: {
2043 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimLong, dex_pc);
2044 break;
2045 }
2046
Roland Levillain8964e2b2014-12-04 12:10:50 +00002047 case Instruction::DOUBLE_TO_FLOAT: {
2048 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimFloat, dex_pc);
2049 break;
2050 }
2051
Roland Levillain51d3fc42014-11-13 14:11:42 +00002052 case Instruction::INT_TO_BYTE: {
Roland Levillain624279f2014-12-04 11:54:28 +00002053 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimByte, dex_pc);
Roland Levillain51d3fc42014-11-13 14:11:42 +00002054 break;
2055 }
2056
Roland Levillain01a8d712014-11-14 16:27:39 +00002057 case Instruction::INT_TO_SHORT: {
Roland Levillain624279f2014-12-04 11:54:28 +00002058 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimShort, dex_pc);
Roland Levillain01a8d712014-11-14 16:27:39 +00002059 break;
2060 }
2061
Roland Levillain981e4542014-11-14 11:47:14 +00002062 case Instruction::INT_TO_CHAR: {
Roland Levillain624279f2014-12-04 11:54:28 +00002063 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimChar, dex_pc);
Roland Levillain981e4542014-11-14 11:47:14 +00002064 break;
2065 }
2066
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002067 case Instruction::ADD_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002068 Binop_23x<HAdd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002069 break;
2070 }
2071
2072 case Instruction::ADD_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002073 Binop_23x<HAdd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002074 break;
2075 }
2076
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002077 case Instruction::ADD_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002078 Binop_23x<HAdd>(instruction, Primitive::kPrimDouble, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002079 break;
2080 }
2081
2082 case Instruction::ADD_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002083 Binop_23x<HAdd>(instruction, Primitive::kPrimFloat, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002084 break;
2085 }
2086
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002087 case Instruction::SUB_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002088 Binop_23x<HSub>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002089 break;
2090 }
2091
2092 case Instruction::SUB_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002093 Binop_23x<HSub>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002094 break;
2095 }
2096
Calin Juravle096cc022014-10-23 17:01:13 +01002097 case Instruction::SUB_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002098 Binop_23x<HSub>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002099 break;
2100 }
2101
2102 case Instruction::SUB_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002103 Binop_23x<HSub>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002104 break;
2105 }
2106
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002107 case Instruction::ADD_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002108 Binop_12x<HAdd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002109 break;
2110 }
2111
Calin Juravle34bacdf2014-10-07 20:23:36 +01002112 case Instruction::MUL_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002113 Binop_23x<HMul>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002114 break;
2115 }
2116
2117 case Instruction::MUL_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002118 Binop_23x<HMul>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002119 break;
2120 }
2121
Calin Juravleb5bfa962014-10-21 18:02:24 +01002122 case Instruction::MUL_FLOAT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002123 Binop_23x<HMul>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002124 break;
2125 }
2126
2127 case Instruction::MUL_DOUBLE: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002128 Binop_23x<HMul>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002129 break;
2130 }
2131
Calin Juravled0d48522014-11-04 16:40:20 +00002132 case Instruction::DIV_INT: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002133 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2134 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravled0d48522014-11-04 16:40:20 +00002135 break;
2136 }
2137
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002138 case Instruction::DIV_LONG: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002139 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2140 dex_pc, Primitive::kPrimLong, false, true);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002141 break;
2142 }
2143
Calin Juravle7c4954d2014-10-28 16:57:40 +00002144 case Instruction::DIV_FLOAT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002145 Binop_23x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002146 break;
2147 }
2148
2149 case Instruction::DIV_DOUBLE: {
Calin Juravle225ff812014-11-13 16:46:39 +00002150 Binop_23x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002151 break;
2152 }
2153
Calin Juravlebacfec32014-11-14 15:54:36 +00002154 case Instruction::REM_INT: {
2155 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2156 dex_pc, Primitive::kPrimInt, false, false);
2157 break;
2158 }
2159
2160 case Instruction::REM_LONG: {
2161 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2162 dex_pc, Primitive::kPrimLong, false, false);
2163 break;
2164 }
2165
Calin Juravled2ec87d2014-12-08 14:24:46 +00002166 case Instruction::REM_FLOAT: {
2167 Binop_23x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2168 break;
2169 }
2170
2171 case Instruction::REM_DOUBLE: {
2172 Binop_23x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2173 break;
2174 }
2175
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002176 case Instruction::AND_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002177 Binop_23x<HAnd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002178 break;
2179 }
2180
2181 case Instruction::AND_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002182 Binop_23x<HAnd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002183 break;
2184 }
2185
Calin Juravle9aec02f2014-11-18 23:06:35 +00002186 case Instruction::SHL_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002187 Binop_23x_shift<HShl>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002188 break;
2189 }
2190
2191 case Instruction::SHL_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002192 Binop_23x_shift<HShl>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002193 break;
2194 }
2195
2196 case Instruction::SHR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002197 Binop_23x_shift<HShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002198 break;
2199 }
2200
2201 case Instruction::SHR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002202 Binop_23x_shift<HShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002203 break;
2204 }
2205
2206 case Instruction::USHR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002207 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002208 break;
2209 }
2210
2211 case Instruction::USHR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002212 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002213 break;
2214 }
2215
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002216 case Instruction::OR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002217 Binop_23x<HOr>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002218 break;
2219 }
2220
2221 case Instruction::OR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002222 Binop_23x<HOr>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002223 break;
2224 }
2225
2226 case Instruction::XOR_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002227 Binop_23x<HXor>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002228 break;
2229 }
2230
2231 case Instruction::XOR_LONG: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002232 Binop_23x<HXor>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002233 break;
2234 }
2235
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002236 case Instruction::ADD_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002237 Binop_12x<HAdd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002238 break;
2239 }
2240
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002241 case Instruction::ADD_DOUBLE_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002242 Binop_12x<HAdd>(instruction, Primitive::kPrimDouble, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002243 break;
2244 }
2245
2246 case Instruction::ADD_FLOAT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002247 Binop_12x<HAdd>(instruction, Primitive::kPrimFloat, dex_pc);
Nicolas Geoffray7fb49da2014-10-06 09:12:41 +01002248 break;
2249 }
2250
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002251 case Instruction::SUB_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002252 Binop_12x<HSub>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002253 break;
2254 }
2255
2256 case Instruction::SUB_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002257 Binop_12x<HSub>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002258 break;
2259 }
2260
Calin Juravle096cc022014-10-23 17:01:13 +01002261 case Instruction::SUB_FLOAT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002262 Binop_12x<HSub>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002263 break;
2264 }
2265
2266 case Instruction::SUB_DOUBLE_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002267 Binop_12x<HSub>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle096cc022014-10-23 17:01:13 +01002268 break;
2269 }
2270
Calin Juravle34bacdf2014-10-07 20:23:36 +01002271 case Instruction::MUL_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002272 Binop_12x<HMul>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002273 break;
2274 }
2275
2276 case Instruction::MUL_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002277 Binop_12x<HMul>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002278 break;
2279 }
2280
Calin Juravleb5bfa962014-10-21 18:02:24 +01002281 case Instruction::MUL_FLOAT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002282 Binop_12x<HMul>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002283 break;
2284 }
2285
2286 case Instruction::MUL_DOUBLE_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002287 Binop_12x<HMul>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravleb5bfa962014-10-21 18:02:24 +01002288 break;
2289 }
2290
Calin Juravle865fc882014-11-06 17:09:03 +00002291 case Instruction::DIV_INT_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002292 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2293 dex_pc, Primitive::kPrimInt, false, true);
Calin Juravle865fc882014-11-06 17:09:03 +00002294 break;
2295 }
2296
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002297 case Instruction::DIV_LONG_2ADDR: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002298 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2299 dex_pc, Primitive::kPrimLong, false, true);
2300 break;
2301 }
2302
2303 case Instruction::REM_INT_2ADDR: {
2304 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2305 dex_pc, Primitive::kPrimInt, false, false);
2306 break;
2307 }
2308
2309 case Instruction::REM_LONG_2ADDR: {
2310 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2311 dex_pc, Primitive::kPrimLong, false, false);
Calin Juravled6fb6cf2014-11-11 19:07:44 +00002312 break;
2313 }
2314
Calin Juravled2ec87d2014-12-08 14:24:46 +00002315 case Instruction::REM_FLOAT_2ADDR: {
2316 Binop_12x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2317 break;
2318 }
2319
2320 case Instruction::REM_DOUBLE_2ADDR: {
2321 Binop_12x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2322 break;
2323 }
2324
Calin Juravle9aec02f2014-11-18 23:06:35 +00002325 case Instruction::SHL_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002326 Binop_12x_shift<HShl>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002327 break;
2328 }
2329
2330 case Instruction::SHL_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002331 Binop_12x_shift<HShl>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002332 break;
2333 }
2334
2335 case Instruction::SHR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002336 Binop_12x_shift<HShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002337 break;
2338 }
2339
2340 case Instruction::SHR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002341 Binop_12x_shift<HShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002342 break;
2343 }
2344
2345 case Instruction::USHR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002346 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimInt, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002347 break;
2348 }
2349
2350 case Instruction::USHR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002351 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimLong, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002352 break;
2353 }
2354
Calin Juravle7c4954d2014-10-28 16:57:40 +00002355 case Instruction::DIV_FLOAT_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00002356 Binop_12x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002357 break;
2358 }
2359
2360 case Instruction::DIV_DOUBLE_2ADDR: {
Calin Juravle225ff812014-11-13 16:46:39 +00002361 Binop_12x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
Calin Juravle7c4954d2014-10-28 16:57:40 +00002362 break;
2363 }
2364
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002365 case Instruction::AND_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002366 Binop_12x<HAnd>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002367 break;
2368 }
2369
2370 case Instruction::AND_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002371 Binop_12x<HAnd>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002372 break;
2373 }
2374
2375 case Instruction::OR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002376 Binop_12x<HOr>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002377 break;
2378 }
2379
2380 case Instruction::OR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002381 Binop_12x<HOr>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002382 break;
2383 }
2384
2385 case Instruction::XOR_INT_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002386 Binop_12x<HXor>(instruction, Primitive::kPrimInt, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002387 break;
2388 }
2389
2390 case Instruction::XOR_LONG_2ADDR: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002391 Binop_12x<HXor>(instruction, Primitive::kPrimLong, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002392 break;
2393 }
2394
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002395 case Instruction::ADD_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002396 Binop_22s<HAdd>(instruction, false, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002397 break;
2398 }
2399
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002400 case Instruction::AND_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002401 Binop_22s<HAnd>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002402 break;
2403 }
2404
2405 case Instruction::OR_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002406 Binop_22s<HOr>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002407 break;
2408 }
2409
2410 case Instruction::XOR_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002411 Binop_22s<HXor>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002412 break;
2413 }
2414
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002415 case Instruction::RSUB_INT: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002416 Binop_22s<HSub>(instruction, true, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002417 break;
2418 }
2419
Calin Juravle34bacdf2014-10-07 20:23:36 +01002420 case Instruction::MUL_INT_LIT16: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002421 Binop_22s<HMul>(instruction, false, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002422 break;
2423 }
2424
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002425 case Instruction::ADD_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002426 Binop_22b<HAdd>(instruction, false, dex_pc);
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002427 break;
2428 }
2429
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002430 case Instruction::AND_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002431 Binop_22b<HAnd>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002432 break;
2433 }
2434
2435 case Instruction::OR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002436 Binop_22b<HOr>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002437 break;
2438 }
2439
2440 case Instruction::XOR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002441 Binop_22b<HXor>(instruction, false, dex_pc);
Nicolas Geoffray9574c4b2014-11-12 13:19:37 +00002442 break;
2443 }
2444
Nicolas Geoffrayf583e592014-04-07 13:20:42 +01002445 case Instruction::RSUB_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002446 Binop_22b<HSub>(instruction, true, dex_pc);
Nicolas Geoffrayd8ee7372014-03-28 15:43:40 +00002447 break;
2448 }
2449
Calin Juravle34bacdf2014-10-07 20:23:36 +01002450 case Instruction::MUL_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002451 Binop_22b<HMul>(instruction, false, dex_pc);
Calin Juravle34bacdf2014-10-07 20:23:36 +01002452 break;
2453 }
2454
Calin Juravled0d48522014-11-04 16:40:20 +00002455 case Instruction::DIV_INT_LIT16:
2456 case Instruction::DIV_INT_LIT8: {
Calin Juravlebacfec32014-11-14 15:54:36 +00002457 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2458 dex_pc, Primitive::kPrimInt, true, true);
2459 break;
2460 }
2461
2462 case Instruction::REM_INT_LIT16:
2463 case Instruction::REM_INT_LIT8: {
2464 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2465 dex_pc, Primitive::kPrimInt, true, false);
Calin Juravled0d48522014-11-04 16:40:20 +00002466 break;
2467 }
2468
Calin Juravle9aec02f2014-11-18 23:06:35 +00002469 case Instruction::SHL_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002470 Binop_22b<HShl>(instruction, false, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002471 break;
2472 }
2473
2474 case Instruction::SHR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002475 Binop_22b<HShr>(instruction, false, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002476 break;
2477 }
2478
2479 case Instruction::USHR_INT_LIT8: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002480 Binop_22b<HUShr>(instruction, false, dex_pc);
Calin Juravle9aec02f2014-11-18 23:06:35 +00002481 break;
2482 }
2483
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002484 case Instruction::NEW_INSTANCE: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002485 uint16_t type_index = instruction.VRegB_21c();
Jeff Hao848f70a2014-01-15 13:49:50 -08002486 if (compiler_driver_->IsStringTypeIndex(type_index, dex_file_)) {
Jeff Hao848f70a2014-01-15 13:49:50 -08002487 int32_t register_index = instruction.VRegA();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002488 HFakeString* fake_string = new (arena_) HFakeString(dex_pc);
Nicolas Geoffray2e7cd752015-07-10 11:38:52 +01002489 current_block_->AddInstruction(fake_string);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002490 UpdateLocal(register_index, fake_string, dex_pc);
Jeff Hao848f70a2014-01-15 13:49:50 -08002491 } else {
2492 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2493 ? kQuickAllocObjectWithAccessCheck
2494 : kQuickAllocObject;
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002495
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002496 current_block_->AddInstruction(new (arena_) HNewInstance(
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002497 graph_->GetCurrentMethod(),
2498 dex_pc,
2499 type_index,
2500 *dex_compilation_unit_->GetDexFile(),
2501 entrypoint));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002502 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction(), dex_pc);
Jeff Hao848f70a2014-01-15 13:49:50 -08002503 }
Nicolas Geoffray2e7038a2014-04-03 18:49:58 +01002504 break;
2505 }
2506
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002507 case Instruction::NEW_ARRAY: {
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002508 uint16_t type_index = instruction.VRegC_22c();
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002509 HInstruction* length = LoadLocal(instruction.VRegB_22c(), Primitive::kPrimInt, dex_pc);
Nicolas Geoffraycb1b00a2015-01-28 14:50:01 +00002510 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index)
2511 ? kQuickAllocArrayWithAccessCheck
2512 : kQuickAllocArray;
Nicolas Geoffray69aa6012015-06-09 10:34:25 +01002513 current_block_->AddInstruction(new (arena_) HNewArray(length,
2514 graph_->GetCurrentMethod(),
2515 dex_pc,
2516 type_index,
2517 *dex_compilation_unit_->GetDexFile(),
2518 entrypoint));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002519 UpdateLocal(instruction.VRegA_22c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002520 break;
2521 }
2522
2523 case Instruction::FILLED_NEW_ARRAY: {
2524 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
2525 uint32_t type_index = instruction.VRegB_35c();
2526 uint32_t args[5];
2527 instruction.GetVarArgs(args);
Calin Juravle225ff812014-11-13 16:46:39 +00002528 BuildFilledNewArray(dex_pc, type_index, number_of_vreg_arguments, false, args, 0);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002529 break;
2530 }
2531
2532 case Instruction::FILLED_NEW_ARRAY_RANGE: {
2533 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
2534 uint32_t type_index = instruction.VRegB_3rc();
2535 uint32_t register_index = instruction.VRegC_3rc();
2536 BuildFilledNewArray(
Calin Juravle225ff812014-11-13 16:46:39 +00002537 dex_pc, type_index, number_of_vreg_arguments, true, nullptr, register_index);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002538 break;
2539 }
2540
2541 case Instruction::FILL_ARRAY_DATA: {
Calin Juravle225ff812014-11-13 16:46:39 +00002542 BuildFillArrayData(instruction, dex_pc);
Nicolas Geoffraya3d05a42014-10-20 17:41:32 +01002543 break;
2544 }
2545
Nicolas Geoffrayddb311f2014-05-16 09:28:54 +01002546 case Instruction::MOVE_RESULT:
Dave Allison20dfc792014-06-16 20:44:29 -07002547 case Instruction::MOVE_RESULT_WIDE:
David Brazdilfc6a86a2015-06-26 10:33:45 +00002548 case Instruction::MOVE_RESULT_OBJECT: {
Nicolas Geoffray1efcc222015-06-24 12:41:20 +01002549 if (latest_result_ == nullptr) {
2550 // Only dead code can lead to this situation, where the verifier
2551 // does not reject the method.
2552 } else {
David Brazdilfc6a86a2015-06-26 10:33:45 +00002553 // An Invoke/FilledNewArray and its MoveResult could have landed in
2554 // different blocks if there was a try/catch block boundary between
2555 // them. For Invoke, we insert a StoreLocal after the instruction. For
2556 // FilledNewArray, the local needs to be updated after the array was
2557 // filled, otherwise we might overwrite an input vreg.
2558 HStoreLocal* update_local =
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002559 new (arena_) HStoreLocal(GetLocalAt(instruction.VRegA()), latest_result_, dex_pc);
David Brazdilfc6a86a2015-06-26 10:33:45 +00002560 HBasicBlock* block = latest_result_->GetBlock();
2561 if (block == current_block_) {
2562 // MoveResult and the previous instruction are in the same block.
2563 current_block_->AddInstruction(update_local);
2564 } else {
2565 // The two instructions are in different blocks. Insert the MoveResult
2566 // before the final control-flow instruction of the previous block.
2567 DCHECK(block->EndsWithControlFlowInstruction());
2568 DCHECK(current_block_->GetInstructions().IsEmpty());
2569 block->InsertInstructionBefore(update_local, block->GetLastInstruction());
2570 }
Nicolas Geoffray1efcc222015-06-24 12:41:20 +01002571 latest_result_ = nullptr;
2572 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002573 break;
David Brazdilfc6a86a2015-06-26 10:33:45 +00002574 }
Nicolas Geoffray01bc96d2014-04-11 17:43:50 +01002575
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002576 case Instruction::CMP_LONG: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002577 Binop_23x_cmp(instruction, Primitive::kPrimLong, ComparisonBias::kNoBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002578 break;
2579 }
2580
2581 case Instruction::CMPG_FLOAT: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002582 Binop_23x_cmp(instruction, Primitive::kPrimFloat, ComparisonBias::kGtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002583 break;
2584 }
2585
2586 case Instruction::CMPG_DOUBLE: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002587 Binop_23x_cmp(instruction, Primitive::kPrimDouble, ComparisonBias::kGtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002588 break;
2589 }
2590
2591 case Instruction::CMPL_FLOAT: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002592 Binop_23x_cmp(instruction, Primitive::kPrimFloat, ComparisonBias::kLtBias, dex_pc);
Calin Juravleddb7df22014-11-25 20:56:51 +00002593 break;
2594 }
2595
2596 case Instruction::CMPL_DOUBLE: {
Roland Levillain4fa13f62015-07-06 18:11:54 +01002597 Binop_23x_cmp(instruction, Primitive::kPrimDouble, ComparisonBias::kLtBias, dex_pc);
Nicolas Geoffray412f10c2014-06-19 10:00:34 +01002598 break;
2599 }
2600
Nicolas Geoffraybe9a92a2014-02-25 14:22:56 +00002601 case Instruction::NOP:
2602 break;
Nicolas Geoffraybab4ed72014-03-11 17:53:17 +00002603
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002604 case Instruction::IGET:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002605 case Instruction::IGET_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002606 case Instruction::IGET_WIDE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002607 case Instruction::IGET_WIDE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002608 case Instruction::IGET_OBJECT:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002609 case Instruction::IGET_OBJECT_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002610 case Instruction::IGET_BOOLEAN:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002611 case Instruction::IGET_BOOLEAN_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002612 case Instruction::IGET_BYTE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002613 case Instruction::IGET_BYTE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002614 case Instruction::IGET_CHAR:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002615 case Instruction::IGET_CHAR_QUICK:
2616 case Instruction::IGET_SHORT:
2617 case Instruction::IGET_SHORT_QUICK: {
Calin Juravle225ff812014-11-13 16:46:39 +00002618 if (!BuildInstanceFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002619 return false;
2620 }
2621 break;
2622 }
2623
2624 case Instruction::IPUT:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002625 case Instruction::IPUT_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002626 case Instruction::IPUT_WIDE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002627 case Instruction::IPUT_WIDE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002628 case Instruction::IPUT_OBJECT:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002629 case Instruction::IPUT_OBJECT_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002630 case Instruction::IPUT_BOOLEAN:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002631 case Instruction::IPUT_BOOLEAN_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002632 case Instruction::IPUT_BYTE:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002633 case Instruction::IPUT_BYTE_QUICK:
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002634 case Instruction::IPUT_CHAR:
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00002635 case Instruction::IPUT_CHAR_QUICK:
2636 case Instruction::IPUT_SHORT:
2637 case Instruction::IPUT_SHORT_QUICK: {
Calin Juravle225ff812014-11-13 16:46:39 +00002638 if (!BuildInstanceFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002639 return false;
2640 }
2641 break;
2642 }
2643
2644 case Instruction::SGET:
2645 case Instruction::SGET_WIDE:
2646 case Instruction::SGET_OBJECT:
2647 case Instruction::SGET_BOOLEAN:
2648 case Instruction::SGET_BYTE:
2649 case Instruction::SGET_CHAR:
2650 case Instruction::SGET_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002651 if (!BuildStaticFieldAccess(instruction, dex_pc, false)) {
Nicolas Geoffray19a19cf2014-10-22 16:07:05 +01002652 return false;
2653 }
2654 break;
2655 }
2656
2657 case Instruction::SPUT:
2658 case Instruction::SPUT_WIDE:
2659 case Instruction::SPUT_OBJECT:
2660 case Instruction::SPUT_BOOLEAN:
2661 case Instruction::SPUT_BYTE:
2662 case Instruction::SPUT_CHAR:
2663 case Instruction::SPUT_SHORT: {
Calin Juravle225ff812014-11-13 16:46:39 +00002664 if (!BuildStaticFieldAccess(instruction, dex_pc, true)) {
Nicolas Geoffraye5038322014-07-04 09:41:32 +01002665 return false;
2666 }
2667 break;
2668 }
2669
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002670#define ARRAY_XX(kind, anticipated_type) \
2671 case Instruction::AGET##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002672 BuildArrayAccess(instruction, dex_pc, false, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002673 break; \
2674 } \
2675 case Instruction::APUT##kind: { \
Calin Juravle225ff812014-11-13 16:46:39 +00002676 BuildArrayAccess(instruction, dex_pc, true, anticipated_type); \
Nicolas Geoffray3c7bb982014-07-23 16:04:16 +01002677 break; \
2678 }
2679
2680 ARRAY_XX(, Primitive::kPrimInt);
2681 ARRAY_XX(_WIDE, Primitive::kPrimLong);
2682 ARRAY_XX(_OBJECT, Primitive::kPrimNot);
2683 ARRAY_XX(_BOOLEAN, Primitive::kPrimBoolean);
2684 ARRAY_XX(_BYTE, Primitive::kPrimByte);
2685 ARRAY_XX(_CHAR, Primitive::kPrimChar);
2686 ARRAY_XX(_SHORT, Primitive::kPrimShort);
2687
Nicolas Geoffray39468442014-09-02 15:17:15 +01002688 case Instruction::ARRAY_LENGTH: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002689 HInstruction* object = LoadLocal(instruction.VRegB_12x(), Primitive::kPrimNot, dex_pc);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002690 // No need for a temporary for the null check, it is the only input of the following
2691 // instruction.
Calin Juravle225ff812014-11-13 16:46:39 +00002692 object = new (arena_) HNullCheck(object, dex_pc);
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002693 current_block_->AddInstruction(object);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002694 current_block_->AddInstruction(new (arena_) HArrayLength(object, dex_pc));
2695 UpdateLocal(instruction.VRegA_12x(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray39468442014-09-02 15:17:15 +01002696 break;
2697 }
2698
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002699 case Instruction::CONST_STRING: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002700 current_block_->AddInstruction(
2701 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_21c(), dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002702 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002703 break;
2704 }
2705
2706 case Instruction::CONST_STRING_JUMBO: {
Nicolas Geoffrayfbdaa302015-05-29 12:06:56 +01002707 current_block_->AddInstruction(
2708 new (arena_) HLoadString(graph_->GetCurrentMethod(), instruction.VRegB_31c(), dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002709 UpdateLocal(instruction.VRegA_31c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +00002710 break;
2711 }
2712
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002713 case Instruction::CONST_CLASS: {
2714 uint16_t type_index = instruction.VRegB_21c();
2715 bool type_known_final;
2716 bool type_known_abstract;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002717 bool dont_use_is_referrers_class;
2718 // `CanAccessTypeWithoutChecks` will tell whether the method being
2719 // built is trying to access its own class, so that the generated
2720 // code can optimize for this case. However, the optimization does not
Nicolas Geoffray9437b782015-03-25 10:08:51 +00002721 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002722 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
2723 dex_compilation_unit_->GetDexMethodIndex(), *dex_file_, type_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00002724 &type_known_final, &type_known_abstract, &dont_use_is_referrers_class);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002725 if (!can_access) {
Calin Juravle48c2b032014-12-09 18:11:36 +00002726 MaybeRecordStat(MethodCompilationStat::kNotCompiledCantAccesType);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002727 return false;
2728 }
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002729 current_block_->AddInstruction(new (arena_) HLoadClass(
Nicolas Geoffray76b1e172015-05-27 17:18:33 +01002730 graph_->GetCurrentMethod(),
Nicolas Geoffrayd5111bf2015-05-22 15:37:09 +01002731 type_index,
2732 *dex_compilation_unit_->GetDexFile(),
2733 IsOutermostCompilingClass(type_index),
2734 dex_pc));
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002735 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction(), dex_pc);
Nicolas Geoffray424f6762014-11-03 14:51:25 +00002736 break;
2737 }
2738
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002739 case Instruction::MOVE_EXCEPTION: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002740 current_block_->AddInstruction(new (arena_) HLoadException(dex_pc));
2741 UpdateLocal(instruction.VRegA_11x(), current_block_->GetLastInstruction(), dex_pc);
2742 current_block_->AddInstruction(new (arena_) HClearException(dex_pc));
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002743 break;
2744 }
2745
2746 case Instruction::THROW: {
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002747 HInstruction* exception = LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot, dex_pc);
Calin Juravle225ff812014-11-13 16:46:39 +00002748 current_block_->AddInstruction(new (arena_) HThrow(exception, dex_pc));
Nicolas Geoffrayde58ab22014-11-05 12:46:03 +00002749 // A throw instruction must branch to the exit block.
2750 current_block_->AddSuccessor(exit_block_);
2751 // We finished building this block. Set the current block to null to avoid
2752 // adding dead instructions to it.
2753 current_block_ = nullptr;
2754 break;
2755 }
2756
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002757 case Instruction::INSTANCE_OF: {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002758 uint8_t destination = instruction.VRegA_22c();
2759 uint8_t reference = instruction.VRegB_22c();
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002760 uint16_t type_index = instruction.VRegC_22c();
Calin Juravle225ff812014-11-13 16:46:39 +00002761 if (!BuildTypeCheck(instruction, destination, reference, type_index, dex_pc)) {
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002762 return false;
2763 }
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002764 break;
2765 }
2766
2767 case Instruction::CHECK_CAST: {
2768 uint8_t reference = instruction.VRegA_21c();
2769 uint16_t type_index = instruction.VRegB_21c();
Calin Juravle225ff812014-11-13 16:46:39 +00002770 if (!BuildTypeCheck(instruction, -1, reference, type_index, dex_pc)) {
Nicolas Geoffray57a88d42014-11-10 15:09:21 +00002771 return false;
2772 }
Nicolas Geoffray6f5c41f2014-11-06 08:59:20 +00002773 break;
2774 }
2775
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002776 case Instruction::MONITOR_ENTER: {
2777 current_block_->AddInstruction(new (arena_) HMonitorOperation(
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002778 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot, dex_pc),
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002779 HMonitorOperation::kEnter,
Calin Juravle225ff812014-11-13 16:46:39 +00002780 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002781 break;
2782 }
2783
2784 case Instruction::MONITOR_EXIT: {
2785 current_block_->AddInstruction(new (arena_) HMonitorOperation(
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002786 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot, dex_pc),
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002787 HMonitorOperation::kExit,
Calin Juravle225ff812014-11-13 16:46:39 +00002788 dex_pc));
Nicolas Geoffrayb7baf5c2014-11-11 16:29:44 +00002789 break;
2790 }
2791
Andreas Gamped881df52014-11-24 23:28:39 -08002792 case Instruction::PACKED_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002793 BuildPackedSwitch(instruction, dex_pc);
Andreas Gamped881df52014-11-24 23:28:39 -08002794 break;
2795 }
2796
Andreas Gampee4d4d322014-12-04 09:09:57 -08002797 case Instruction::SPARSE_SWITCH: {
Calin Juravle48c2b032014-12-09 18:11:36 +00002798 BuildSparseSwitch(instruction, dex_pc);
Andreas Gampee4d4d322014-12-04 09:09:57 -08002799 break;
2800 }
2801
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002802 default:
Calin Juravle48c2b032014-12-09 18:11:36 +00002803 VLOG(compiler) << "Did not compile "
2804 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
2805 << " because of unhandled instruction "
2806 << instruction.Name();
2807 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnhandledInstruction);
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002808 return false;
2809 }
2810 return true;
Nicolas Geoffraydadf3172014-11-07 16:36:02 +00002811} // NOLINT(readability/fn_size)
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002812
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002813HLocal* HGraphBuilder::GetLocalAt(int register_index) const {
2814 return locals_.Get(register_index);
2815}
2816
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002817void HGraphBuilder::UpdateLocal(int register_index,
2818 HInstruction* instruction,
2819 uint32_t dex_pc) const {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002820 HLocal* local = GetLocalAt(register_index);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002821 current_block_->AddInstruction(new (arena_) HStoreLocal(local, instruction, dex_pc));
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002822}
2823
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002824HInstruction* HGraphBuilder::LoadLocal(int register_index,
2825 Primitive::Type type,
2826 uint32_t dex_pc) const {
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002827 HLocal* local = GetLocalAt(register_index);
Yevgeny Rouban3ecfd652015-09-07 17:57:00 +06002828 current_block_->AddInstruction(new (arena_) HLoadLocal(local, type, dex_pc));
Nicolas Geoffray787c3072014-03-17 10:20:19 +00002829 return current_block_->GetLastInstruction();
Nicolas Geoffray3ff386a2014-03-04 14:46:47 +00002830}
2831
Nicolas Geoffray818f2102014-02-18 16:43:35 +00002832} // namespace art