blob: ff4b9a765cc0a568bad93a909e6ee28ea6b9bd04 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000020#include "builder.h"
21#include "class_linker.h"
22#include "constant_folding.h"
23#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000024#include "dex/verified_method.h"
25#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010027#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000028#include "driver/dex_compilation_unit.h"
29#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010030#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000031#include "jit/jit.h"
32#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000033#include "mirror/class_loader.h"
34#include "mirror/dex_cache.h"
35#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010036#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010037#include "reference_type_propagation.h"
Nicolas Geoffray259136f2014-12-17 23:21:58 +000038#include "register_allocator.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000039#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010040#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000041#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000042#include "ssa_phi_elimination.h"
43#include "scoped_thread_state_change.h"
44#include "thread.h"
45
46namespace art {
47
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000048static constexpr size_t kMaximumNumberOfHInstructions = 32;
49
50// Limit the number of dex registers that we accumulate while inlining
51// to avoid creating large amount of nested environments.
52static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
53
54// Avoid inlining within a huge method due to memory pressure.
55static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070056
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000057void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010058 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
59 if ((compiler_options.GetInlineDepthLimit() == 0)
60 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
61 return;
62 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000063 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
64 return;
65 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000066 if (graph_->IsDebuggable()) {
67 // For simplicity, we currently never inline when the graph is debuggable. This avoids
68 // doing some logic in the runtime to discover if a method could have been inlined.
69 return;
70 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010071 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
72 DCHECK(!blocks.empty());
73 HBasicBlock* next_block = blocks[0];
74 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010075 // Because we are changing the graph when inlining, we need to remember the next block.
76 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010077 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010078 continue;
79 }
80 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010081 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000082 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
83 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010084 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070085 // As long as the call is not intrinsified, it is worth trying to inline.
86 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000087 // We use the original invoke type to ensure the resolution of the called method
88 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000089 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010090 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000091 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000092 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000093 bool should_inline = callee_name.find("$inline$") != std::string::npos;
94 CHECK(!should_inline) << "Could not inline " << callee_name;
95 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010096 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010097 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010098 std::string callee_name =
99 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
100 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
101 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
102 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000103 }
104 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000105 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000106 }
107 }
108}
109
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100110static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700111 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100112 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
113}
114
115/**
116 * Given the `resolved_method` looked up in the dex cache, try to find
117 * the actual runtime target of an interface or virtual call.
118 * Return nullptr if the runtime target cannot be proven.
119 */
120static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700121 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100122 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
123 // No need to lookup further, the resolved method will be the target.
124 return resolved_method;
125 }
126
127 HInstruction* receiver = invoke->InputAt(0);
128 if (receiver->IsNullCheck()) {
129 // Due to multiple levels of inlining within the same pass, it might be that
130 // null check does not have the reference type of the actual receiver.
131 receiver = receiver->InputAt(0);
132 }
133 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000134 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
135 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100136 // We currently only support inlining with known receivers.
137 // TODO: Remove this check, we should be able to inline final methods
138 // on unknown receivers.
139 return nullptr;
140 } else if (info.GetTypeHandle()->IsInterface()) {
141 // Statically knowing that the receiver has an interface type cannot
142 // help us find what is the target method.
143 return nullptr;
144 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
145 // The method that we're trying to call is not in the receiver's class or super classes.
146 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000147 } else if (info.GetTypeHandle()->IsErroneous()) {
148 // If the type is erroneous, do not go further, as we are going to query the vtable or
149 // imt table, that we can only safely do on non-erroneous classes.
150 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100151 }
152
153 ClassLinker* cl = Runtime::Current()->GetClassLinker();
154 size_t pointer_size = cl->GetImagePointerSize();
155 if (invoke->IsInvokeInterface()) {
156 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
157 resolved_method, pointer_size);
158 } else {
159 DCHECK(invoke->IsInvokeVirtual());
160 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
161 resolved_method, pointer_size);
162 }
163
164 if (resolved_method == nullptr) {
165 // The information we had on the receiver was not enough to find
166 // the target method. Since we check above the exact type of the receiver,
167 // the only reason this can happen is an IncompatibleClassChangeError.
168 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700169 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100170 // The information we had on the receiver was not enough to find
171 // the target method. Since we check above the exact type of the receiver,
172 // the only reason this can happen is an IncompatibleClassChangeError.
173 return nullptr;
174 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
175 // A final method has to be the target method.
176 return resolved_method;
177 } else if (info.IsExact()) {
178 // If we found a method and the receiver's concrete type is statically
179 // known, we know for sure the target.
180 return resolved_method;
181 } else {
182 // Even if we did find a method, the receiver type was not enough to
183 // statically find the runtime target.
184 return nullptr;
185 }
186}
187
188static uint32_t FindMethodIndexIn(ArtMethod* method,
189 const DexFile& dex_file,
190 uint32_t referrer_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700191 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100192 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100193 return method->GetDexMethodIndex();
194 } else {
195 return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index);
196 }
197}
198
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000199static uint32_t FindClassIndexIn(mirror::Class* cls,
200 const DexFile& dex_file,
201 Handle<mirror::DexCache> dex_cache)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100202 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000203 uint32_t index = DexFile::kDexNoIndex;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100204 if (cls->GetDexCache() == nullptr) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000205 DCHECK(cls->IsArrayClass()) << PrettyClass(cls);
206 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100207 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000208 DCHECK(cls->IsProxyClass()) << PrettyClass(cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100209 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100210 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000211 index = cls->GetDexTypeIndex();
212 } else {
213 index = cls->FindTypeIndexInOtherDexFile(dex_file);
214 }
215
216 if (index != DexFile::kDexNoIndex) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100217 // Update the dex cache to ensure the class is in. The generated code will
218 // consider it is. We make it safe by updating the dex cache, as other
219 // dex files might also load the class, and there is no guarantee the dex
220 // cache of the dex file of the class will be updated.
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000221 if (dex_cache->GetResolvedType(index) == nullptr) {
222 dex_cache->SetResolvedType(index, cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100223 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100224 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000225
226 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100227}
228
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000229class ScopedProfilingInfoInlineUse {
230 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000231 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
232 : method_(method),
233 self_(self),
234 // Fetch the profiling info ahead of using it. If it's null when fetching,
235 // we should not call JitCodeCache::DoneInlining.
236 profiling_info_(
237 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000238 }
239
240 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000241 if (profiling_info_ != nullptr) {
242 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
243 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
244 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
245 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000246 }
247
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000248 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
249
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000250 private:
251 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000252 Thread* const self_;
253 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000254};
255
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700256bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100257 if (invoke_instruction->IsInvokeUnresolved()) {
258 return false; // Don't bother to move further if we know the method is unresolved.
259 }
260
Vladimir Marko58155012015-08-19 12:49:41 +0000261 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000262 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000263 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
264 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000265
Nicolas Geoffray35071052015-06-09 15:43:38 +0100266 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
267 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000268 ArtMethod* resolved_method;
Andreas Gampefd2140f2015-12-23 16:30:44 -0800269 ArtMethod* actual_method = nullptr;
Vladimir Marko58155012015-08-19 12:49:41 +0000270 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000271 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
272 VLOG(compiler) << "Not inlining a String.<init> method";
273 return false;
274 }
Vladimir Marko58155012015-08-19 12:49:41 +0000275 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700276 mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file)
277 ? caller_compilation_unit_.GetDexCache().Get()
278 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
279 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000280 ref.dex_method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800281 // actual_method == resolved_method for direct or static calls.
282 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000283 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700284 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000285 method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800286 if (resolved_method != nullptr) {
287 // Check if we can statically find the method.
288 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
289 }
Vladimir Marko58155012015-08-19 12:49:41 +0000290 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000291
Mathieu Chartiere401d142015-04-22 13:56:20 -0700292 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100293 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100294 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000295 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000296 return false;
297 }
298
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100299 if (actual_method != nullptr) {
Calin Juravle69158982016-03-16 11:53:41 +0000300 bool result = TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ true);
301 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
302 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
303 }
304 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100305 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000306
Andreas Gampefd2140f2015-12-23 16:30:44 -0800307 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100308
309 // Check if we can use an inline cache.
310 ArtMethod* caller = graph_->GetArtMethod();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000311 if (Runtime::Current()->UseJit()) {
312 // Under JIT, we should always know the caller.
313 DCHECK(caller != nullptr);
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000314 ScopedProfilingInfoInlineUse spiis(caller, soa.Self());
315 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000316 if (profiling_info != nullptr) {
317 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000318 if (ic.IsUninitialized()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000319 VLOG(compiler) << "Interface or virtual call to "
320 << PrettyMethod(method_index, caller_dex_file)
321 << " is not hit and not inlined";
322 return false;
323 } else if (ic.IsMonomorphic()) {
324 MaybeRecordStat(kMonomorphicCall);
325 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
326 } else if (ic.IsPolymorphic()) {
327 MaybeRecordStat(kPolymorphicCall);
328 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
329 } else {
330 DCHECK(ic.IsMegamorphic());
331 VLOG(compiler) << "Interface or virtual call to "
332 << PrettyMethod(method_index, caller_dex_file)
333 << " is megamorphic and not inlined";
334 MaybeRecordStat(kMegamorphicCall);
335 return false;
336 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100337 }
338 }
339
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100340 VLOG(compiler) << "Interface or virtual call to "
341 << PrettyMethod(method_index, caller_dex_file)
342 << " could not be statically determined";
343 return false;
344}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000345
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000346HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
347 HInstruction* receiver,
348 uint32_t dex_pc) const {
349 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
350 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000351 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000352 receiver,
353 Primitive::kPrimNot,
354 field->GetOffset(),
355 field->IsVolatile(),
356 field->GetDexFieldIndex(),
357 field->GetDeclaringClass()->GetDexClassDefIndex(),
358 *field->GetDexFile(),
359 handles_->NewHandle(field->GetDexCache()),
360 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000361 // The class of a field is effectively final, and does not have any memory dependencies.
362 result->SetSideEffects(SideEffects::None());
363 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000364}
365
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100366bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
367 ArtMethod* resolved_method,
368 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000369 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
370 << invoke_instruction->DebugName();
371
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100372 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000373 uint32_t class_index = FindClassIndexIn(
374 ic.GetMonomorphicType(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100375 if (class_index == DexFile::kDexNoIndex) {
376 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
377 << " from inline cache is not inlined because its class is not"
378 << " accessible to the caller";
379 return false;
380 }
381
382 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
383 size_t pointer_size = class_linker->GetImagePointerSize();
384 if (invoke_instruction->IsInvokeInterface()) {
385 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
386 resolved_method, pointer_size);
387 } else {
388 DCHECK(invoke_instruction->IsInvokeVirtual());
389 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
390 resolved_method, pointer_size);
391 }
392 DCHECK(resolved_method != nullptr);
393 HInstruction* receiver = invoke_instruction->InputAt(0);
394 HInstruction* cursor = invoke_instruction->GetPrevious();
395 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
396
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000397 if (!TryInlineAndReplace(invoke_instruction, resolved_method, /* do_rtp */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100398 return false;
399 }
400
401 // We successfully inlined, now add a guard.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100402 bool is_referrer =
403 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000404 AddTypeGuard(receiver,
405 cursor,
406 bb_cursor,
407 class_index,
408 is_referrer,
409 invoke_instruction,
410 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100411
412 // Run type propagation to get the guard typed, and eventually propagate the
413 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000414 ReferenceTypePropagation rtp_fixup(graph_,
415 outer_compilation_unit_.GetDexCache(),
416 handles_,
417 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100418 rtp_fixup.Run();
419
420 MaybeRecordStat(kInlinedMonomorphicCall);
421 return true;
422}
423
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000424HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
425 HInstruction* cursor,
426 HBasicBlock* bb_cursor,
427 uint32_t class_index,
428 bool is_referrer,
429 HInstruction* invoke_instruction,
430 bool with_deoptimization) {
431 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
432 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
433 class_linker, receiver, invoke_instruction->GetDexPc());
434
435 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
436 // Note that we will just compare the classes, so we don't need Java semantics access checks.
437 // Also, the caller of `AddTypeGuard` must have guaranteed that the class is in the dex cache.
438 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
439 class_index,
440 caller_dex_file,
441 is_referrer,
442 invoke_instruction->GetDexPc(),
443 /* needs_access_check */ false,
444 /* is_in_dex_cache */ true);
445
446 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
447 // TODO: Extend reference type propagation to understand the guard.
448 if (cursor != nullptr) {
449 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
450 } else {
451 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
452 }
453 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
454 bb_cursor->InsertInstructionAfter(compare, load_class);
455 if (with_deoptimization) {
456 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
457 compare, invoke_instruction->GetDexPc());
458 bb_cursor->InsertInstructionAfter(deoptimize, compare);
459 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
460 }
461 return compare;
462}
463
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000464bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100465 ArtMethod* resolved_method,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000466 const InlineCache& ic) {
467 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
468 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000469
470 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, ic)) {
471 return true;
472 }
473
474 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
475 size_t pointer_size = class_linker->GetImagePointerSize();
476 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
477
478 bool all_targets_inlined = true;
479 bool one_target_inlined = false;
480 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
481 if (ic.GetTypeAt(i) == nullptr) {
482 break;
483 }
484 ArtMethod* method = nullptr;
485 if (invoke_instruction->IsInvokeInterface()) {
486 method = ic.GetTypeAt(i)->FindVirtualMethodForInterface(
487 resolved_method, pointer_size);
488 } else {
489 DCHECK(invoke_instruction->IsInvokeVirtual());
490 method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual(
491 resolved_method, pointer_size);
492 }
493
494 HInstruction* receiver = invoke_instruction->InputAt(0);
495 HInstruction* cursor = invoke_instruction->GetPrevious();
496 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
497
Nicolas Geoffray1fe26e12016-02-18 16:55:42 +0000498 uint32_t class_index = FindClassIndexIn(
499 ic.GetTypeAt(i), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000500 HInstruction* return_replacement = nullptr;
501 if (class_index == DexFile::kDexNoIndex ||
502 !TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
503 all_targets_inlined = false;
504 } else {
505 one_target_inlined = true;
506 bool is_referrer = (ic.GetTypeAt(i) == outermost_graph_->GetArtMethod()->GetDeclaringClass());
507
508 // If we have inlined all targets before, and this receiver is the last seen,
509 // we deoptimize instead of keeping the original invoke instruction.
510 bool deoptimize = all_targets_inlined &&
511 (i != InlineCache::kIndividualCacheSize - 1) &&
512 (ic.GetTypeAt(i + 1) == nullptr);
513 HInstruction* compare = AddTypeGuard(
514 receiver, cursor, bb_cursor, class_index, is_referrer, invoke_instruction, deoptimize);
515 if (deoptimize) {
516 if (return_replacement != nullptr) {
517 invoke_instruction->ReplaceWith(return_replacement);
518 }
519 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
520 // Because the inline cache data can be populated concurrently, we force the end of the
521 // iteration. Otherhwise, we could see a new receiver type.
522 break;
523 } else {
524 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
525 }
526 }
527 }
528
529 if (!one_target_inlined) {
530 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
531 << " from inline cache is not inlined because none"
532 << " of its targets could be inlined";
533 return false;
534 }
535 MaybeRecordStat(kInlinedPolymorphicCall);
536
537 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000538 ReferenceTypePropagation rtp_fixup(graph_,
539 outer_compilation_unit_.GetDexCache(),
540 handles_,
541 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000542 rtp_fixup.Run();
543 return true;
544}
545
546void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
547 HInstruction* return_replacement,
548 HInstruction* invoke_instruction) {
549 uint32_t dex_pc = invoke_instruction->GetDexPc();
550 HBasicBlock* cursor_block = compare->GetBlock();
551 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
552 ArenaAllocator* allocator = graph_->GetArena();
553
554 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
555 // and the returned block is the start of the then branch (that could contain multiple blocks).
556 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
557
558 // Split the block containing the invoke before and after the invoke. The returned block
559 // of the split before will contain the invoke and will be the otherwise branch of
560 // the diamond. The returned block of the split after will be the merge block
561 // of the diamond.
562 HBasicBlock* end_then = invoke_instruction->GetBlock();
563 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
564 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
565
566 // If the methods we are inlining return a value, we create a phi in the merge block
567 // that will have the `invoke_instruction and the `return_replacement` as inputs.
568 if (return_replacement != nullptr) {
569 HPhi* phi = new (allocator) HPhi(
570 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
571 merge->AddPhi(phi);
572 invoke_instruction->ReplaceWith(phi);
573 phi->AddInput(return_replacement);
574 phi->AddInput(invoke_instruction);
575 }
576
577 // Add the control flow instructions.
578 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
579 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
580 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
581
582 // Add the newly created blocks to the graph.
583 graph_->AddBlock(then);
584 graph_->AddBlock(otherwise);
585 graph_->AddBlock(merge);
586
587 // Set up successor (and implictly predecessor) relations.
588 cursor_block->AddSuccessor(otherwise);
589 cursor_block->AddSuccessor(then);
590 end_then->AddSuccessor(merge);
591 otherwise->AddSuccessor(merge);
592
593 // Set up dominance information.
594 then->SetDominator(cursor_block);
595 cursor_block->AddDominatedBlock(then);
596 otherwise->SetDominator(cursor_block);
597 cursor_block->AddDominatedBlock(otherwise);
598 merge->SetDominator(cursor_block);
599 cursor_block->AddDominatedBlock(merge);
600
601 // Update the revert post order.
602 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
603 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
604 graph_->reverse_post_order_[++index] = then;
605 index = IndexOfElement(graph_->reverse_post_order_, end_then);
606 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
607 graph_->reverse_post_order_[++index] = otherwise;
608 graph_->reverse_post_order_[++index] = merge;
609
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000610
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000611 graph_->UpdateLoopAndTryInformationOfNewBlock(
612 then, original_invoke_block, /* replace_if_back_edge */ false);
613 graph_->UpdateLoopAndTryInformationOfNewBlock(
614 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
615
616 // In case the original invoke location was a back edge, we need to update
617 // the loop to now have the merge block as a back edge.
618 graph_->UpdateLoopAndTryInformationOfNewBlock(
619 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000620}
621
622bool HInliner::TryInlinePolymorphicCallToSameTarget(HInvoke* invoke_instruction,
623 ArtMethod* resolved_method,
624 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000625 // This optimization only works under JIT for now.
626 DCHECK(Runtime::Current()->UseJit());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000627 if (graph_->GetInstructionSet() == kMips64) {
628 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000629 return false;
630 }
631 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
632 size_t pointer_size = class_linker->GetImagePointerSize();
633
634 DCHECK(resolved_method != nullptr);
635 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000636 size_t method_index = invoke_instruction->IsInvokeVirtual()
637 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
638 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
639
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000640 // Check whether we are actually calling the same method among
641 // the different types seen.
642 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
643 if (ic.GetTypeAt(i) == nullptr) {
644 break;
645 }
646 ArtMethod* new_method = nullptr;
647 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000648 new_method = ic.GetTypeAt(i)->GetEmbeddedImTableEntry(
649 method_index % mirror::Class::kImtSize, pointer_size);
650 if (new_method->IsRuntimeMethod()) {
651 // Bail out as soon as we see a conflict trampoline in one of the target's
652 // interface table.
653 return false;
654 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000655 } else {
656 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000657 new_method = ic.GetTypeAt(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000658 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000659 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000660 if (actual_method == nullptr) {
661 actual_method = new_method;
662 } else if (actual_method != new_method) {
663 // Different methods, bailout.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000664 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
665 << " from inline cache is not inlined because it resolves"
666 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000667 return false;
668 }
669 }
670
671 HInstruction* receiver = invoke_instruction->InputAt(0);
672 HInstruction* cursor = invoke_instruction->GetPrevious();
673 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
674
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000675 if (!TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ false)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000676 return false;
677 }
678
679 // We successfully inlined, now add a guard.
680 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
681 class_linker, receiver, invoke_instruction->GetDexPc());
682
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000683 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
684 ? Primitive::kPrimLong
685 : Primitive::kPrimInt;
686 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
687 receiver_class,
688 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000689 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
690 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000691 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000692 invoke_instruction->GetDexPc());
693
694 HConstant* constant;
695 if (type == Primitive::kPrimLong) {
696 constant = graph_->GetLongConstant(
697 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
698 } else {
699 constant = graph_->GetIntConstant(
700 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
701 }
702
703 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
704 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
705 compare, invoke_instruction->GetDexPc());
706 // TODO: Extend reference type propagation to understand the guard.
707 if (cursor != nullptr) {
708 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
709 } else {
710 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
711 }
712 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
713 bb_cursor->InsertInstructionAfter(compare, class_table_get);
714 bb_cursor->InsertInstructionAfter(deoptimize, compare);
715 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
716
717 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000718 ReferenceTypePropagation rtp_fixup(graph_,
719 outer_compilation_unit_.GetDexCache(),
720 handles_,
721 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000722 rtp_fixup.Run();
723
724 MaybeRecordStat(kInlinedPolymorphicCall);
725
726 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100727}
728
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000729bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
730 HInstruction* return_replacement = nullptr;
731 if (!TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
732 return false;
733 }
734 if (return_replacement != nullptr) {
735 invoke_instruction->ReplaceWith(return_replacement);
736 }
737 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
738 FixUpReturnReferenceType(invoke_instruction, method, return_replacement, do_rtp);
739 return true;
740}
741
742bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
743 ArtMethod* method,
744 HInstruction** return_replacement) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100745 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Jeff Haodcdc85b2015-12-04 14:06:18 -0800746
747 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
748 // dex file here (though the transitivity of an inline chain would allow checking the calller).
749 if (!compiler_driver_->MayInline(method->GetDexFile(),
750 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000751 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000752 VLOG(compiler) << "Successfully replaced pattern of invoke " << PrettyMethod(method);
753 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
754 return true;
755 }
Jeff Haodcdc85b2015-12-04 14:06:18 -0800756 VLOG(compiler) << "Won't inline " << PrettyMethod(method) << " in "
757 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
758 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
759 << method->GetDexFile()->GetLocation();
760 return false;
761 }
762
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100763 uint32_t method_index = FindMethodIndexIn(
764 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
765 if (method_index == DexFile::kDexNoIndex) {
766 VLOG(compiler) << "Call to "
767 << PrettyMethod(method)
768 << " cannot be inlined because unaccessible to caller";
769 return false;
770 }
771
772 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
773
774 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000775
776 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100777 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000778 << " is not inlined because it is native";
779 return false;
780 }
781
Calin Juravleec748352015-07-29 13:52:12 +0100782 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
783 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100784 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000785 << " is too big to inline: "
786 << code_item->insns_size_in_code_units_
787 << " > "
788 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000789 return false;
790 }
791
792 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100793 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000794 << " is not inlined because of try block";
795 return false;
796 }
797
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100798 if (!method->IsCompilable()) {
799 VLOG(compiler) << "Method " << PrettyMethod(method)
800 << " has soft failures un-handled by the compiler, so it cannot be inlined";
801 }
802
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100803 if (!method->GetDeclaringClass()->IsVerified()) {
804 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000805 if (Runtime::Current()->UseJit() ||
806 !compiler_driver_->IsMethodVerifiedWithoutFailures(
807 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100808 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
809 << " couldn't be verified, so it cannot be inlined";
810 return false;
811 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000812 }
813
Roland Levillain4c0eb422015-04-24 16:43:49 +0100814 if (invoke_instruction->IsInvokeStaticOrDirect() &&
815 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
816 // Case of a static method that cannot be inlined because it implicitly
817 // requires an initialization check of its declaring class.
818 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
819 << " is not inlined because it is static and requires a clinit"
820 << " check that cannot be emitted due to Dex cache limitations";
821 return false;
822 }
823
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000824 if (!TryBuildAndInlineHelper(invoke_instruction, method, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000825 return false;
826 }
827
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000828 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000829 MaybeRecordStat(kInlinedInvoke);
830 return true;
831}
832
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000833static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
834 size_t arg_vreg_index)
835 SHARED_REQUIRES(Locks::mutator_lock_) {
836 size_t input_index = 0;
837 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
838 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
839 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
840 ++i;
841 DCHECK_NE(i, arg_vreg_index);
842 }
843 }
844 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
845 return invoke_instruction->InputAt(input_index);
846}
847
848// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
849bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
850 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000851 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000852 InlineMethod inline_method;
853 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
854 return false;
855 }
856
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000857 switch (inline_method.opcode) {
858 case kInlineOpNop:
859 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000860 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000861 break;
862 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000863 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
864 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000865 break;
866 case kInlineOpNonWideConst:
867 if (resolved_method->GetShorty()[0] == 'L') {
868 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000869 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000870 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000871 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000872 }
873 break;
874 case kInlineOpIGet: {
875 const InlineIGetIPutData& data = inline_method.d.ifield_data;
876 if (data.method_is_static || data.object_arg != 0u) {
877 // TODO: Needs null check.
878 return false;
879 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000880 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000881 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000882 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000883 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
884 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
885 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000886 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000887 break;
888 }
889 case kInlineOpIPut: {
890 const InlineIGetIPutData& data = inline_method.d.ifield_data;
891 if (data.method_is_static || data.object_arg != 0u) {
892 // TODO: Needs null check.
893 return false;
894 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000895 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000896 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
897 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000898 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000899 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
900 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
901 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
902 if (data.return_arg_plus1 != 0u) {
903 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000904 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000905 }
906 break;
907 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000908 case kInlineOpConstructor: {
909 const InlineConstructorData& data = inline_method.d.constructor_data;
910 // Get the indexes to arrays for easier processing.
911 uint16_t iput_field_indexes[] = {
912 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
913 };
914 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
915 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
916 // Count valid field indexes.
917 size_t number_of_iputs = 0u;
918 while (number_of_iputs != arraysize(iput_field_indexes) &&
919 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
920 // Check that there are no duplicate valid field indexes.
921 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
922 iput_field_indexes + arraysize(iput_field_indexes),
923 iput_field_indexes[number_of_iputs]));
924 ++number_of_iputs;
925 }
926 // Check that there are no valid field indexes in the rest of the array.
927 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
928 iput_field_indexes + arraysize(iput_field_indexes),
929 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
930
931 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
932 Handle<mirror::DexCache> dex_cache;
933 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
934 bool needs_constructor_barrier = false;
935 for (size_t i = 0; i != number_of_iputs; ++i) {
936 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +0000937 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +0000938 if (dex_cache.GetReference() == nullptr) {
939 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
940 }
941 uint16_t field_index = iput_field_indexes[i];
942 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
943 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
944
945 // Check whether the field is final. If it is, we need to add a barrier.
946 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
947 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
948 DCHECK(resolved_field != nullptr);
949 if (resolved_field->IsFinal()) {
950 needs_constructor_barrier = true;
951 }
952 }
953 }
954 if (needs_constructor_barrier) {
955 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
956 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
957 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000958 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +0000959 break;
960 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000961 default:
962 LOG(FATAL) << "UNREACHABLE";
963 UNREACHABLE();
964 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000965 return true;
966}
967
Vladimir Marko354efa62016-02-04 19:46:56 +0000968HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000969 uint32_t field_index,
970 HInstruction* obj)
971 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000972 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
973 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
974 DCHECK(resolved_field != nullptr);
975 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
976 obj,
977 resolved_field->GetTypeAsPrimitiveType(),
978 resolved_field->GetOffset(),
979 resolved_field->IsVolatile(),
980 field_index,
981 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +0000982 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000983 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +0000984 // Read barrier generates a runtime call in slow path and we need a valid
985 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
986 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000987 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +0000988 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
989 ReferenceTypePropagation rtp(graph_, dex_cache, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000990 rtp.Visit(iget);
991 }
992 return iget;
993}
994
Vladimir Marko354efa62016-02-04 19:46:56 +0000995HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000996 uint32_t field_index,
997 HInstruction* obj,
998 HInstruction* value)
999 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001000 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
1001 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1002 DCHECK(resolved_field != nullptr);
1003 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1004 obj,
1005 value,
1006 resolved_field->GetTypeAsPrimitiveType(),
1007 resolved_field->GetOffset(),
1008 resolved_field->IsVolatile(),
1009 field_index,
1010 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001011 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001012 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +00001013 // Read barrier generates a runtime call in slow path and we need a valid
1014 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1015 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001016 return iput;
1017}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001018
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001019bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1020 ArtMethod* resolved_method,
1021 bool same_dex_file,
1022 HInstruction** return_replacement) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001023 ScopedObjectAccess soa(Thread::Current());
1024 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001025 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1026 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001027 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -07001028 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001029 DexCompilationUnit dex_compilation_unit(
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001030 caller_compilation_unit_.GetClassLoader(),
1031 class_linker,
1032 callee_dex_file,
1033 code_item,
1034 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1035 method_index,
1036 resolved_method->GetAccessFlags(),
1037 /* verified_method */ nullptr,
1038 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001039
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001040 bool requires_ctor_barrier = false;
1041
1042 if (dex_compilation_unit.IsConstructor()) {
1043 // If it's a super invocation and we already generate a barrier there's no need
1044 // to generate another one.
1045 // We identify super calls by looking at the "this" pointer. If its value is the
1046 // same as the local "this" pointer then we must have a super invocation.
1047 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1048 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1049 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1050 requires_ctor_barrier = false;
1051 } else {
1052 Thread* self = Thread::Current();
1053 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1054 dex_compilation_unit.GetDexFile(),
1055 dex_compilation_unit.GetClassDefIndex());
1056 }
1057 }
1058
Nicolas Geoffray35071052015-06-09 15:43:38 +01001059 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
1060 if (invoke_type == kInterface) {
1061 // We have statically resolved the dispatch. To please the class linker
1062 // at runtime, we change this call as if it was a virtual call.
1063 invoke_type = kVirtual;
1064 }
David Brazdil3f523062016-02-29 16:53:33 +00001065
1066 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001067 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001068 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001069 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001070 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001071 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001072 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001073 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001074 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001075 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001076 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001077 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001078
Roland Levillaina8013fd2016-04-04 15:34:31 +01001079 // When they are needed, allocate `inline_stats` on the heap instead
1080 // of on the stack, as Clang might produce a stack frame too large
1081 // for this function, that would not fit the requirements of the
1082 // `-Wframe-larger-than` option.
1083 std::unique_ptr<OptimizingCompilerStats> inline_stats =
1084 (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>();
David Brazdil5e8b1372015-01-23 14:39:08 +00001085 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001086 &dex_compilation_unit,
1087 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001088 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001089 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001090 compiler_driver_,
Roland Levillaina8013fd2016-04-04 15:34:31 +01001091 inline_stats.get(),
Mathieu Chartier736b5602015-09-02 14:54:11 -07001092 resolved_method->GetQuickenedInfo(),
David Brazdildee58d62016-04-07 09:54:26 +00001093 dex_cache,
1094 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001095
David Brazdildee58d62016-04-07 09:54:26 +00001096 if (builder.BuildGraph() != kAnalysisSuccess) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001097 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001098 << " could not be built, so cannot be inlined";
1099 return false;
1100 }
1101
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001102 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1103 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001104 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001105 << " cannot be inlined because of the register allocator";
1106 return false;
1107 }
1108
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001109 size_t parameter_index = 0;
1110 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1111 !instructions.Done();
1112 instructions.Advance()) {
1113 HInstruction* current = instructions.Current();
1114 if (current->IsParameterValue()) {
1115 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
1116 if (argument->IsNullConstant()) {
1117 current->ReplaceWith(callee_graph->GetNullConstant());
1118 } else if (argument->IsIntConstant()) {
1119 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1120 } else if (argument->IsLongConstant()) {
1121 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1122 } else if (argument->IsFloatConstant()) {
1123 current->ReplaceWith(
1124 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1125 } else if (argument->IsDoubleConstant()) {
1126 current->ReplaceWith(
1127 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1128 } else if (argument->GetType() == Primitive::kPrimNot) {
1129 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1130 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1131 }
1132 }
1133 }
1134
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001135 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001136 size_t number_of_inlined_instructions =
1137 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
1138 number_of_instructions_budget += number_of_inlined_instructions;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001139
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001140 // TODO: We should abort only if all predecessors throw. However,
1141 // HGraph::InlineInto currently does not handle an exit block with
1142 // a throw predecessor.
1143 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1144 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001145 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001146 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001147 return false;
1148 }
1149
1150 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001151 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1152 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001153 has_throw_predecessor = true;
1154 break;
1155 }
1156 }
1157 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001158 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001159 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001160 return false;
1161 }
1162
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001163 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001164 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001165 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001166
1167 bool can_inline_environment =
1168 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1169
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001170 for (; !it.Done(); it.Advance()) {
1171 HBasicBlock* block = it.Current();
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001172
1173 if (block->IsLoopHeader() && block->GetLoopInformation()->IsIrreducible()) {
1174 // Don't inline methods with irreducible loops, they could prevent some
1175 // optimizations to run.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001176 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001177 << " could not be inlined because it contains an irreducible loop";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001178 return false;
1179 }
1180
1181 for (HInstructionIterator instr_it(block->GetInstructions());
1182 !instr_it.Done();
1183 instr_it.Advance()) {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001184 if (number_of_instructions++ == number_of_instructions_budget) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001185 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001186 << " is not inlined because its caller has reached"
1187 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001188 return false;
1189 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001190 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001191 if (!can_inline_environment && current->NeedsEnvironment()) {
1192 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1193 << " is not inlined because its caller has reached"
1194 << " its environment budget limit.";
1195 return false;
1196 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001197
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001198 if (current->IsInvokeInterface()) {
1199 // Disable inlining of interface calls. The cost in case of entering the
1200 // resolution conflict is currently too high.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001201 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001202 << " could not be inlined because it has an interface call.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001203 return false;
1204 }
1205
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001206 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001207 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001208 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001209 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001210 return false;
1211 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001212
Vladimir Markodc151b22015-10-15 18:02:30 +01001213 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001214 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001215 << " could not be inlined because " << current->DebugName()
1216 << " it is in a different dex file and requires access to the dex cache";
1217 return false;
1218 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001219
1220 if (current->IsNewInstance() &&
1221 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001222 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1223 << " could not be inlined because it is using an entrypoint"
1224 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001225 // Allocation entrypoint does not handle inlined frames.
1226 return false;
1227 }
1228
1229 if (current->IsNewArray() &&
1230 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001231 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1232 << " could not be inlined because it is using an entrypoint"
1233 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001234 // Allocation entrypoint does not handle inlined frames.
1235 return false;
1236 }
1237
1238 if (current->IsUnresolvedStaticFieldGet() ||
1239 current->IsUnresolvedInstanceFieldGet() ||
1240 current->IsUnresolvedStaticFieldSet() ||
1241 current->IsUnresolvedInstanceFieldSet()) {
1242 // Entrypoint for unresolved fields does not handle inlined frames.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001243 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1244 << " could not be inlined because it is using an unresolved"
1245 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001246 return false;
1247 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001248 }
1249 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001250 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001251
David Brazdil3f523062016-02-29 16:53:33 +00001252 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1253 << "No instructions can be added to the outer graph while inner graph is being built";
1254
1255 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1256 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001257 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001258
1259 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1260 << "No instructions can be added to the inner graph during inlining into the outer graph";
1261
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001262 return true;
1263}
Calin Juravle2e768302015-07-28 14:41:11 +00001264
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001265size_t HInliner::RunOptimizations(HGraph* callee_graph,
1266 const DexFile::CodeItem* code_item,
1267 const DexCompilationUnit& dex_compilation_unit) {
1268 HDeadCodeElimination dce(callee_graph, stats_);
1269 HConstantFolding fold(callee_graph);
1270 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
1271 InstructionSimplifier simplify(callee_graph, stats_);
1272 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_, stats_);
1273
1274 HOptimization* optimizations[] = {
1275 &intrinsics,
1276 &sharpening,
1277 &simplify,
1278 &fold,
1279 &dce,
1280 };
1281
1282 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1283 HOptimization* optimization = optimizations[i];
1284 optimization->Run();
1285 }
1286
1287 size_t number_of_inlined_instructions = 0u;
1288 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
1289 HInliner inliner(callee_graph,
1290 outermost_graph_,
1291 codegen_,
1292 outer_compilation_unit_,
1293 dex_compilation_unit,
1294 compiler_driver_,
1295 handles_,
1296 stats_,
1297 total_number_of_dex_registers_ + code_item->registers_size_,
1298 depth_ + 1);
1299 inliner.Run();
1300 number_of_inlined_instructions += inliner.number_of_inlined_instructions_;
1301 }
1302
1303 return number_of_inlined_instructions;
1304}
1305
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001306void HInliner::FixUpReturnReferenceType(HInvoke* invoke_instruction,
1307 ArtMethod* resolved_method,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001308 HInstruction* return_replacement,
1309 bool do_rtp) {
Alex Light68289a52015-12-15 17:30:30 -08001310 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001311 if (return_replacement != nullptr) {
1312 if (return_replacement->GetType() == Primitive::kPrimNot) {
1313 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1314 // Make sure that we have a valid type for the return. We may get an invalid one when
1315 // we inline invokes with multiple branches and create a Phi for the result.
1316 // TODO: we could be more precise by merging the phi inputs but that requires
1317 // some functionality from the reference type propagation.
1318 DCHECK(return_replacement->IsPhi());
1319 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray44fd0e52016-03-16 15:16:06 +00001320 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */, pointer_size);
Aart Bik8b3f9b22016-04-06 11:22:12 -07001321 if (cls != nullptr && !cls->IsErroneous()) {
Nicolas Geoffraya1724502016-03-16 17:01:39 +00001322 ReferenceTypeInfo::TypeHandle return_handle = handles_->NewHandle(cls);
Nicolas Geoffray44fd0e52016-03-16 15:16:06 +00001323 return_replacement->SetReferenceTypeInfo(ReferenceTypeInfo::Create(
1324 return_handle, return_handle->CannotBeAssignedFromOtherTypes() /* is_exact */));
1325 } else {
Aart Bik8b3f9b22016-04-06 11:22:12 -07001326 // Return inexact object type on failures.
Nicolas Geoffray44fd0e52016-03-16 15:16:06 +00001327 return_replacement->SetReferenceTypeInfo(graph_->GetInexactObjectRti());
1328 }
David Brazdil4833f5a2015-12-16 10:37:39 +00001329 }
Alex Light68289a52015-12-15 17:30:30 -08001330
David Brazdil4833f5a2015-12-16 10:37:39 +00001331 if (do_rtp) {
1332 // If the return type is a refinement of the declared type run the type propagation again.
1333 ReferenceTypeInfo return_rti = return_replacement->GetReferenceTypeInfo();
1334 ReferenceTypeInfo invoke_rti = invoke_instruction->GetReferenceTypeInfo();
1335 if (invoke_rti.IsStrictSupertypeOf(return_rti)
1336 || (return_rti.IsExact() && !invoke_rti.IsExact())
1337 || !return_replacement->CanBeNull()) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001338 ReferenceTypePropagation(graph_,
1339 outer_compilation_unit_.GetDexCache(),
1340 handles_,
1341 /* is_first_run */ false).Run();
David Brazdil4833f5a2015-12-16 10:37:39 +00001342 }
1343 }
1344 } else if (return_replacement->IsInstanceOf()) {
1345 if (do_rtp) {
1346 // Inlining InstanceOf into an If may put a tighter bound on reference types.
Vladimir Marko456307a2016-04-19 14:12:13 +00001347 ReferenceTypePropagation(graph_,
1348 outer_compilation_unit_.GetDexCache(),
1349 handles_,
1350 /* is_first_run */ false).Run();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001351 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001352 }
Calin Juravle2e768302015-07-28 14:41:11 +00001353 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001354}
1355
1356} // namespace art