blob: 394b87caae25e3337b6b5a098f1716ddf381e109 [file] [log] [blame]
Brian Carlstrom7940e442013-07-12 13:46:57 -07001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "compiler_driver.h"
18
Anwar Ghuloum67f99412013-08-12 14:19:48 -070019#define ATRACE_TAG ATRACE_TAG_DALVIK
20#include <utils/Trace.h>
Brian Carlstrom7940e442013-07-12 13:46:57 -070021
Anwar Ghuloum67f99412013-08-12 14:19:48 -070022#include <vector>
Brian Carlstrom7940e442013-07-12 13:46:57 -070023#include <unistd.h>
24
25#include "base/stl_util.h"
26#include "base/timing_logger.h"
27#include "class_linker.h"
Mingyao Yang98d1cc82014-05-15 17:02:16 -070028#include "compiled_class.h"
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +000029#include "compiler.h"
Vladimir Markobe0e5462014-02-26 11:24:15 +000030#include "compiler_driver-inl.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070031#include "dex_compilation_unit.h"
32#include "dex_file-inl.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000033#include "dex/verification_results.h"
Vladimir Marko2730db02014-01-27 11:15:17 +000034#include "dex/verified_method.h"
Vladimir Marko2bc47802014-02-10 09:43:07 +000035#include "dex/quick/dex_file_method_inliner.h"
Mark Mendellae9fd932014-02-10 16:14:35 -080036#include "driver/compiler_options.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070037#include "jni_internal.h"
Ian Rogers22d5e732014-07-15 22:23:51 -070038#include "object_lock.h"
Calin Juravlebb0b53f2014-05-23 17:33:29 +010039#include "profiler.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070040#include "runtime.h"
41#include "gc/accounting/card_table-inl.h"
42#include "gc/accounting/heap_bitmap.h"
43#include "gc/space/space.h"
Brian Carlstromea46f952013-07-30 01:26:50 -070044#include "mirror/art_field-inl.h"
45#include "mirror/art_method-inl.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070046#include "mirror/class_loader.h"
47#include "mirror/class-inl.h"
48#include "mirror/dex_cache-inl.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070049#include "mirror/object-inl.h"
50#include "mirror/object_array-inl.h"
51#include "mirror/throwable.h"
52#include "scoped_thread_state_change.h"
53#include "ScopedLocalRef.h"
Mathieu Chartiereb8167a2014-05-07 15:43:14 -070054#include "handle_scope-inl.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070055#include "thread.h"
56#include "thread_pool.h"
Ian Rogers848871b2013-08-05 10:56:33 -070057#include "trampolines/trampoline_compiler.h"
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +010058#include "transaction.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070059#include "verifier/method_verifier.h"
Vladimir Marko2bc47802014-02-10 09:43:07 +000060#include "verifier/method_verifier-inl.h"
Brian Carlstrom7940e442013-07-12 13:46:57 -070061
Brian Carlstrom7940e442013-07-12 13:46:57 -070062namespace art {
63
Ian Rogers6dd35cc2014-08-27 21:46:57 +000064static constexpr bool kTimeCompileMethod = !kIsDebugBuild;
Mathieu Chartierb68c6e52014-08-19 14:29:46 -070065
Brian Carlstrom7940e442013-07-12 13:46:57 -070066static double Percentage(size_t x, size_t y) {
67 return 100.0 * (static_cast<double>(x)) / (static_cast<double>(x + y));
68}
69
70static void DumpStat(size_t x, size_t y, const char* str) {
71 if (x == 0 && y == 0) {
72 return;
73 }
Ian Rogerse732ef12013-10-09 15:22:24 -070074 LOG(INFO) << Percentage(x, y) << "% of " << str << " for " << (x + y) << " cases";
Brian Carlstrom7940e442013-07-12 13:46:57 -070075}
76
Vladimir Markof096aad2014-01-23 15:51:58 +000077class CompilerDriver::AOTCompilationStats {
Brian Carlstrom7940e442013-07-12 13:46:57 -070078 public:
79 AOTCompilationStats()
80 : stats_lock_("AOT compilation statistics lock"),
81 types_in_dex_cache_(0), types_not_in_dex_cache_(0),
82 strings_in_dex_cache_(0), strings_not_in_dex_cache_(0),
83 resolved_types_(0), unresolved_types_(0),
84 resolved_instance_fields_(0), unresolved_instance_fields_(0),
85 resolved_local_static_fields_(0), resolved_static_fields_(0), unresolved_static_fields_(0),
86 type_based_devirtualization_(0),
87 safe_casts_(0), not_safe_casts_(0) {
88 for (size_t i = 0; i <= kMaxInvokeType; i++) {
89 resolved_methods_[i] = 0;
90 unresolved_methods_[i] = 0;
91 virtual_made_direct_[i] = 0;
92 direct_calls_to_boot_[i] = 0;
93 direct_methods_to_boot_[i] = 0;
94 }
95 }
96
97 void Dump() {
98 DumpStat(types_in_dex_cache_, types_not_in_dex_cache_, "types known to be in dex cache");
99 DumpStat(strings_in_dex_cache_, strings_not_in_dex_cache_, "strings known to be in dex cache");
100 DumpStat(resolved_types_, unresolved_types_, "types resolved");
101 DumpStat(resolved_instance_fields_, unresolved_instance_fields_, "instance fields resolved");
102 DumpStat(resolved_local_static_fields_ + resolved_static_fields_, unresolved_static_fields_,
103 "static fields resolved");
104 DumpStat(resolved_local_static_fields_, resolved_static_fields_ + unresolved_static_fields_,
105 "static fields local to a class");
106 DumpStat(safe_casts_, not_safe_casts_, "check-casts removed based on type information");
107 // Note, the code below subtracts the stat value so that when added to the stat value we have
108 // 100% of samples. TODO: clean this up.
109 DumpStat(type_based_devirtualization_,
110 resolved_methods_[kVirtual] + unresolved_methods_[kVirtual] +
111 resolved_methods_[kInterface] + unresolved_methods_[kInterface] -
112 type_based_devirtualization_,
113 "virtual/interface calls made direct based on type information");
114
115 for (size_t i = 0; i <= kMaxInvokeType; i++) {
116 std::ostringstream oss;
117 oss << static_cast<InvokeType>(i) << " methods were AOT resolved";
118 DumpStat(resolved_methods_[i], unresolved_methods_[i], oss.str().c_str());
119 if (virtual_made_direct_[i] > 0) {
120 std::ostringstream oss2;
121 oss2 << static_cast<InvokeType>(i) << " methods made direct";
122 DumpStat(virtual_made_direct_[i],
123 resolved_methods_[i] + unresolved_methods_[i] - virtual_made_direct_[i],
124 oss2.str().c_str());
125 }
126 if (direct_calls_to_boot_[i] > 0) {
127 std::ostringstream oss2;
128 oss2 << static_cast<InvokeType>(i) << " method calls are direct into boot";
129 DumpStat(direct_calls_to_boot_[i],
130 resolved_methods_[i] + unresolved_methods_[i] - direct_calls_to_boot_[i],
131 oss2.str().c_str());
132 }
133 if (direct_methods_to_boot_[i] > 0) {
134 std::ostringstream oss2;
135 oss2 << static_cast<InvokeType>(i) << " method calls have methods in boot";
136 DumpStat(direct_methods_to_boot_[i],
137 resolved_methods_[i] + unresolved_methods_[i] - direct_methods_to_boot_[i],
138 oss2.str().c_str());
139 }
140 }
141 }
142
143// Allow lossy statistics in non-debug builds.
144#ifndef NDEBUG
145#define STATS_LOCK() MutexLock mu(Thread::Current(), stats_lock_)
146#else
147#define STATS_LOCK()
148#endif
149
150 void TypeInDexCache() {
151 STATS_LOCK();
152 types_in_dex_cache_++;
153 }
154
155 void TypeNotInDexCache() {
156 STATS_LOCK();
157 types_not_in_dex_cache_++;
158 }
159
160 void StringInDexCache() {
161 STATS_LOCK();
162 strings_in_dex_cache_++;
163 }
164
165 void StringNotInDexCache() {
166 STATS_LOCK();
167 strings_not_in_dex_cache_++;
168 }
169
170 void TypeDoesntNeedAccessCheck() {
171 STATS_LOCK();
172 resolved_types_++;
173 }
174
175 void TypeNeedsAccessCheck() {
176 STATS_LOCK();
177 unresolved_types_++;
178 }
179
180 void ResolvedInstanceField() {
181 STATS_LOCK();
182 resolved_instance_fields_++;
183 }
184
185 void UnresolvedInstanceField() {
186 STATS_LOCK();
187 unresolved_instance_fields_++;
188 }
189
190 void ResolvedLocalStaticField() {
191 STATS_LOCK();
192 resolved_local_static_fields_++;
193 }
194
195 void ResolvedStaticField() {
196 STATS_LOCK();
197 resolved_static_fields_++;
198 }
199
200 void UnresolvedStaticField() {
201 STATS_LOCK();
202 unresolved_static_fields_++;
203 }
204
205 // Indicate that type information from the verifier led to devirtualization.
206 void PreciseTypeDevirtualization() {
207 STATS_LOCK();
208 type_based_devirtualization_++;
209 }
210
211 // Indicate that a method of the given type was resolved at compile time.
212 void ResolvedMethod(InvokeType type) {
213 DCHECK_LE(type, kMaxInvokeType);
214 STATS_LOCK();
215 resolved_methods_[type]++;
216 }
217
218 // Indicate that a method of the given type was unresolved at compile time as it was in an
219 // unknown dex file.
220 void UnresolvedMethod(InvokeType type) {
221 DCHECK_LE(type, kMaxInvokeType);
222 STATS_LOCK();
223 unresolved_methods_[type]++;
224 }
225
226 // Indicate that a type of virtual method dispatch has been converted into a direct method
227 // dispatch.
228 void VirtualMadeDirect(InvokeType type) {
229 DCHECK(type == kVirtual || type == kInterface || type == kSuper);
230 STATS_LOCK();
231 virtual_made_direct_[type]++;
232 }
233
234 // Indicate that a method of the given type was able to call directly into boot.
235 void DirectCallsToBoot(InvokeType type) {
236 DCHECK_LE(type, kMaxInvokeType);
237 STATS_LOCK();
238 direct_calls_to_boot_[type]++;
239 }
240
241 // Indicate that a method of the given type was able to be resolved directly from boot.
242 void DirectMethodsToBoot(InvokeType type) {
243 DCHECK_LE(type, kMaxInvokeType);
244 STATS_LOCK();
245 direct_methods_to_boot_[type]++;
246 }
247
Vladimir Markof096aad2014-01-23 15:51:58 +0000248 void ProcessedInvoke(InvokeType type, int flags) {
249 STATS_LOCK();
250 if (flags == 0) {
251 unresolved_methods_[type]++;
252 } else {
253 DCHECK_NE((flags & kFlagMethodResolved), 0);
254 resolved_methods_[type]++;
255 if ((flags & kFlagVirtualMadeDirect) != 0) {
256 virtual_made_direct_[type]++;
257 if ((flags & kFlagPreciseTypeDevirtualization) != 0) {
258 type_based_devirtualization_++;
259 }
260 } else {
261 DCHECK_EQ((flags & kFlagPreciseTypeDevirtualization), 0);
262 }
263 if ((flags & kFlagDirectCallToBoot) != 0) {
264 direct_calls_to_boot_[type]++;
265 }
266 if ((flags & kFlagDirectMethodToBoot) != 0) {
267 direct_methods_to_boot_[type]++;
268 }
269 }
270 }
271
Brian Carlstrom7940e442013-07-12 13:46:57 -0700272 // A check-cast could be eliminated due to verifier type analysis.
273 void SafeCast() {
274 STATS_LOCK();
275 safe_casts_++;
276 }
277
278 // A check-cast couldn't be eliminated due to verifier type analysis.
279 void NotASafeCast() {
280 STATS_LOCK();
281 not_safe_casts_++;
282 }
283
284 private:
285 Mutex stats_lock_;
286
287 size_t types_in_dex_cache_;
288 size_t types_not_in_dex_cache_;
289
290 size_t strings_in_dex_cache_;
291 size_t strings_not_in_dex_cache_;
292
293 size_t resolved_types_;
294 size_t unresolved_types_;
295
296 size_t resolved_instance_fields_;
297 size_t unresolved_instance_fields_;
298
299 size_t resolved_local_static_fields_;
300 size_t resolved_static_fields_;
301 size_t unresolved_static_fields_;
302 // Type based devirtualization for invoke interface and virtual.
303 size_t type_based_devirtualization_;
304
305 size_t resolved_methods_[kMaxInvokeType + 1];
306 size_t unresolved_methods_[kMaxInvokeType + 1];
307 size_t virtual_made_direct_[kMaxInvokeType + 1];
308 size_t direct_calls_to_boot_[kMaxInvokeType + 1];
309 size_t direct_methods_to_boot_[kMaxInvokeType + 1];
310
311 size_t safe_casts_;
312 size_t not_safe_casts_;
313
314 DISALLOW_COPY_AND_ASSIGN(AOTCompilationStats);
315};
316
Brian Carlstrom7940e442013-07-12 13:46:57 -0700317
318extern "C" art::CompiledMethod* ArtCompileDEX(art::CompilerDriver& compiler,
319 const art::DexFile::CodeItem* code_item,
320 uint32_t access_flags,
321 art::InvokeType invoke_type,
Ian Rogers8b2c0b92013-09-19 02:56:49 -0700322 uint16_t class_def_idx,
Brian Carlstrom7940e442013-07-12 13:46:57 -0700323 uint32_t method_idx,
324 jobject class_loader,
325 const art::DexFile& dex_file);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700326
Brian Carlstrom6449c622014-02-10 23:48:36 -0800327CompilerDriver::CompilerDriver(const CompilerOptions* compiler_options,
328 VerificationResults* verification_results,
Vladimir Marko5816ed42013-11-27 17:04:20 +0000329 DexFileToMethodInlinerMap* method_inliner_map,
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000330 Compiler::Kind compiler_kind,
Nicolas Geoffrayf5df8972014-02-14 18:37:08 +0000331 InstructionSet instruction_set,
Dave Allison70202782013-10-22 17:52:19 -0700332 InstructionSetFeatures instruction_set_features,
Ian Rogerscb6b0f32014-08-12 02:30:58 -0700333 bool image, std::set<std::string>* image_classes, size_t thread_count,
Dave Allison39c3bfb2014-01-28 18:33:52 -0800334 bool dump_stats, bool dump_passes, CumulativeLogger* timer,
335 std::string profile_file)
Calin Juravlec1b643c2014-05-30 23:44:11 +0100336 : profile_present_(false), compiler_options_(compiler_options),
Brian Carlstrom6449c622014-02-10 23:48:36 -0800337 verification_results_(verification_results),
Vladimir Marko5816ed42013-11-27 17:04:20 +0000338 method_inliner_map_(method_inliner_map),
Ian Rogers72d32622014-05-06 16:20:11 -0700339 compiler_(Compiler::Create(this, compiler_kind)),
Brian Carlstrom7940e442013-07-12 13:46:57 -0700340 instruction_set_(instruction_set),
Dave Allison70202782013-10-22 17:52:19 -0700341 instruction_set_features_(instruction_set_features),
Brian Carlstrom7940e442013-07-12 13:46:57 -0700342 freezing_constructor_lock_("freezing constructor lock"),
343 compiled_classes_lock_("compiled classes lock"),
344 compiled_methods_lock_("compiled method lock"),
345 image_(image),
346 image_classes_(image_classes),
347 thread_count_(thread_count),
Brian Carlstrom7940e442013-07-12 13:46:57 -0700348 start_ns_(0),
349 stats_(new AOTCompilationStats),
350 dump_stats_(dump_stats),
Nicolas Geoffrayea3fa0b2014-02-10 11:59:41 +0000351 dump_passes_(dump_passes),
352 timings_logger_(timer),
Andreas Gampe35439ba2014-08-28 14:41:02 -0700353 compiler_library_(nullptr),
354 compiler_context_(nullptr),
355 compiler_enable_auto_elf_loading_(nullptr),
356 compiler_get_method_code_addr_(nullptr),
Mark Mendell55d0eac2014-02-06 11:02:52 -0800357 support_boot_image_fixup_(instruction_set != kMips),
Mark Mendellae9fd932014-02-10 16:14:35 -0800358 cfi_info_(nullptr),
Ian Rogersd133b972013-09-05 11:01:30 -0700359 dedupe_code_("dedupe code"),
360 dedupe_mapping_table_("dedupe mapping table"),
361 dedupe_vmap_table_("dedupe vmap table"),
Mark Mendellae9fd932014-02-10 16:14:35 -0800362 dedupe_gc_map_("dedupe gc map"),
363 dedupe_cfi_info_("dedupe cfi info") {
Brian Carlstrom6449c622014-02-10 23:48:36 -0800364 DCHECK(compiler_options_ != nullptr);
365 DCHECK(verification_results_ != nullptr);
366 DCHECK(method_inliner_map_ != nullptr);
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700367
Andreas Gampe35439ba2014-08-28 14:41:02 -0700368 CHECK_PTHREAD_CALL(pthread_key_create, (&tls_key_, nullptr), "compiler tls key");
Brian Carlstrom7940e442013-07-12 13:46:57 -0700369
Sebastien Hertz75021222013-07-16 18:34:50 +0200370 dex_to_dex_compiler_ = reinterpret_cast<DexToDexCompilerFn>(ArtCompileDEX);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700371
Ian Rogers72d32622014-05-06 16:20:11 -0700372 compiler_->Init();
Brian Carlstrom7940e442013-07-12 13:46:57 -0700373
374 CHECK(!Runtime::Current()->IsStarted());
Kenny Rootd5185342014-05-13 14:47:05 -0700375 if (image_) {
376 CHECK(image_classes_.get() != nullptr);
377 } else {
378 CHECK(image_classes_.get() == nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700379 }
Mark Mendellae9fd932014-02-10 16:14:35 -0800380
381 // Are we generating CFI information?
382 if (compiler_options->GetGenerateGDBInformation()) {
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000383 cfi_info_.reset(compiler_->GetCallFrameInformationInitialization(*this));
Mark Mendellae9fd932014-02-10 16:14:35 -0800384 }
Calin Juravlec1b643c2014-05-30 23:44:11 +0100385
386 // Read the profile file if one is provided.
387 if (!profile_file.empty()) {
388 profile_present_ = profile_file_.LoadFile(profile_file);
389 if (profile_present_) {
390 LOG(INFO) << "Using profile data form file " << profile_file;
391 } else {
392 LOG(INFO) << "Failed to load profile file " << profile_file;
393 }
394 }
Brian Carlstrom7940e442013-07-12 13:46:57 -0700395}
396
Mathieu Chartier193bad92013-08-29 18:46:00 -0700397std::vector<uint8_t>* CompilerDriver::DeduplicateCode(const std::vector<uint8_t>& code) {
398 return dedupe_code_.Add(Thread::Current(), code);
399}
400
401std::vector<uint8_t>* CompilerDriver::DeduplicateMappingTable(const std::vector<uint8_t>& code) {
402 return dedupe_mapping_table_.Add(Thread::Current(), code);
403}
404
405std::vector<uint8_t>* CompilerDriver::DeduplicateVMapTable(const std::vector<uint8_t>& code) {
406 return dedupe_vmap_table_.Add(Thread::Current(), code);
407}
408
409std::vector<uint8_t>* CompilerDriver::DeduplicateGCMap(const std::vector<uint8_t>& code) {
410 return dedupe_gc_map_.Add(Thread::Current(), code);
411}
412
Mark Mendellae9fd932014-02-10 16:14:35 -0800413std::vector<uint8_t>* CompilerDriver::DeduplicateCFIInfo(const std::vector<uint8_t>* cfi_info) {
414 if (cfi_info == nullptr) {
415 return nullptr;
416 }
417 return dedupe_cfi_info_.Add(Thread::Current(), *cfi_info);
418}
419
Brian Carlstrom7940e442013-07-12 13:46:57 -0700420CompilerDriver::~CompilerDriver() {
421 Thread* self = Thread::Current();
422 {
423 MutexLock mu(self, compiled_classes_lock_);
424 STLDeleteValues(&compiled_classes_);
425 }
426 {
427 MutexLock mu(self, compiled_methods_lock_);
428 STLDeleteValues(&compiled_methods_);
429 }
430 {
431 MutexLock mu(self, compiled_methods_lock_);
432 STLDeleteElements(&code_to_patch_);
433 }
434 {
435 MutexLock mu(self, compiled_methods_lock_);
436 STLDeleteElements(&methods_to_patch_);
437 }
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800438 {
439 MutexLock mu(self, compiled_methods_lock_);
440 STLDeleteElements(&classes_to_patch_);
441 }
Brian Carlstrom7940e442013-07-12 13:46:57 -0700442 CHECK_PTHREAD_CALL(pthread_key_delete, (tls_key_), "delete tls key");
Ian Rogers72d32622014-05-06 16:20:11 -0700443 compiler_->UnInit();
Brian Carlstrom7940e442013-07-12 13:46:57 -0700444}
445
446CompilerTls* CompilerDriver::GetTls() {
447 // Lazily create thread-local storage
448 CompilerTls* res = static_cast<CompilerTls*>(pthread_getspecific(tls_key_));
Andreas Gampe35439ba2014-08-28 14:41:02 -0700449 if (res == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700450 res = new CompilerTls();
451 CHECK_PTHREAD_CALL(pthread_setspecific, (tls_key_, res), "compiler tls");
452 }
453 return res;
454}
455
Ian Rogersdd7624d2014-03-14 17:43:00 -0700456#define CREATE_TRAMPOLINE(type, abi, offset) \
Andreas Gampeaf13ad92014-04-11 12:07:48 -0700457 if (Is64BitInstructionSet(instruction_set_)) { \
Ian Rogersdd7624d2014-03-14 17:43:00 -0700458 return CreateTrampoline64(instruction_set_, abi, \
459 type ## _ENTRYPOINT_OFFSET(8, offset)); \
460 } else { \
461 return CreateTrampoline32(instruction_set_, abi, \
462 type ## _ENTRYPOINT_OFFSET(4, offset)); \
463 }
464
Ian Rogers848871b2013-08-05 10:56:33 -0700465const std::vector<uint8_t>* CompilerDriver::CreateInterpreterToInterpreterBridge() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700466 CREATE_TRAMPOLINE(INTERPRETER, kInterpreterAbi, pInterpreterToInterpreterBridge)
Ian Rogers848871b2013-08-05 10:56:33 -0700467}
468
469const std::vector<uint8_t>* CompilerDriver::CreateInterpreterToCompiledCodeBridge() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700470 CREATE_TRAMPOLINE(INTERPRETER, kInterpreterAbi, pInterpreterToCompiledCodeBridge)
Ian Rogers848871b2013-08-05 10:56:33 -0700471}
472
473const std::vector<uint8_t>* CompilerDriver::CreateJniDlsymLookup() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700474 CREATE_TRAMPOLINE(JNI, kJniAbi, pDlsymLookup)
Ian Rogers848871b2013-08-05 10:56:33 -0700475}
476
Jeff Hao88474b42013-10-23 16:24:40 -0700477const std::vector<uint8_t>* CompilerDriver::CreatePortableImtConflictTrampoline() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700478 CREATE_TRAMPOLINE(PORTABLE, kPortableAbi, pPortableImtConflictTrampoline)
Jeff Hao88474b42013-10-23 16:24:40 -0700479}
480
Brian Carlstrom7940e442013-07-12 13:46:57 -0700481const std::vector<uint8_t>* CompilerDriver::CreatePortableResolutionTrampoline() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700482 CREATE_TRAMPOLINE(PORTABLE, kPortableAbi, pPortableResolutionTrampoline)
Ian Rogers848871b2013-08-05 10:56:33 -0700483}
484
485const std::vector<uint8_t>* CompilerDriver::CreatePortableToInterpreterBridge() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700486 CREATE_TRAMPOLINE(PORTABLE, kPortableAbi, pPortableToInterpreterBridge)
Brian Carlstrom7940e442013-07-12 13:46:57 -0700487}
488
Andreas Gampe2da88232014-02-27 12:26:20 -0800489const std::vector<uint8_t>* CompilerDriver::CreateQuickGenericJniTrampoline() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700490 CREATE_TRAMPOLINE(QUICK, kQuickAbi, pQuickGenericJniTrampoline)
Andreas Gampe2da88232014-02-27 12:26:20 -0800491}
492
Jeff Hao88474b42013-10-23 16:24:40 -0700493const std::vector<uint8_t>* CompilerDriver::CreateQuickImtConflictTrampoline() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700494 CREATE_TRAMPOLINE(QUICK, kQuickAbi, pQuickImtConflictTrampoline)
Jeff Hao88474b42013-10-23 16:24:40 -0700495}
496
Brian Carlstrom7940e442013-07-12 13:46:57 -0700497const std::vector<uint8_t>* CompilerDriver::CreateQuickResolutionTrampoline() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700498 CREATE_TRAMPOLINE(QUICK, kQuickAbi, pQuickResolutionTrampoline)
Brian Carlstrom7940e442013-07-12 13:46:57 -0700499}
500
Ian Rogers848871b2013-08-05 10:56:33 -0700501const std::vector<uint8_t>* CompilerDriver::CreateQuickToInterpreterBridge() const {
Ian Rogersdd7624d2014-03-14 17:43:00 -0700502 CREATE_TRAMPOLINE(QUICK, kQuickAbi, pQuickToInterpreterBridge)
Brian Carlstrom7940e442013-07-12 13:46:57 -0700503}
Ian Rogersdd7624d2014-03-14 17:43:00 -0700504#undef CREATE_TRAMPOLINE
Brian Carlstrom7940e442013-07-12 13:46:57 -0700505
506void CompilerDriver::CompileAll(jobject class_loader,
Brian Carlstrom45602482013-07-21 22:07:55 -0700507 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -0800508 TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700509 DCHECK(!Runtime::Current()->IsStarted());
Ian Rogers700a4022014-05-19 16:49:03 -0700510 std::unique_ptr<ThreadPool> thread_pool(new ThreadPool("Compiler driver thread pool", thread_count_ - 1));
Ian Rogers3d504072014-03-01 09:16:49 -0800511 PreCompile(class_loader, dex_files, thread_pool.get(), timings);
512 Compile(class_loader, dex_files, thread_pool.get(), timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700513 if (dump_stats_) {
514 stats_->Dump();
515 }
516}
517
Mathieu Chartier590fee92013-09-13 13:46:47 -0700518static DexToDexCompilationLevel GetDexToDexCompilationlevel(
Mathieu Chartier0cd81352014-05-22 16:48:55 -0700519 Thread* self, Handle<mirror::ClassLoader> class_loader, const DexFile& dex_file,
Mathieu Chartier590fee92013-09-13 13:46:47 -0700520 const DexFile::ClassDef& class_def) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700521 const char* descriptor = dex_file.GetClassDescriptor(class_def);
522 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
Ian Rogers98379392014-02-24 16:53:16 -0800523 mirror::Class* klass = class_linker->FindClass(self, descriptor, class_loader);
Andreas Gampe35439ba2014-08-28 14:41:02 -0700524 if (klass == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700525 CHECK(self->IsExceptionPending());
526 self->ClearException();
Sebastien Hertz75021222013-07-16 18:34:50 +0200527 return kDontDexToDexCompile;
Brian Carlstrom7940e442013-07-12 13:46:57 -0700528 }
Andreas Gampe35439ba2014-08-28 14:41:02 -0700529 // DexToDex at the kOptimize level may introduce quickened opcodes, which replace symbolic
530 // references with actual offsets. We cannot re-verify such instructions.
531 //
532 // We store the verification information in the class status in the oat file, which the linker
533 // can validate (checksums) and use to skip load-time verification. It is thus safe to
534 // optimize when a class has been fully verified before.
535 if (klass->IsVerified()) {
Sebastien Hertz75021222013-07-16 18:34:50 +0200536 // Class is verified so we can enable DEX-to-DEX compilation for performance.
537 return kOptimize;
538 } else if (klass->IsCompileTimeVerified()) {
539 // Class verification has soft-failed. Anyway, ensure at least correctness.
540 DCHECK_EQ(klass->GetStatus(), mirror::Class::kStatusRetryVerificationAtRuntime);
541 return kRequired;
542 } else {
543 // Class verification has failed: do not run DEX-to-DEX compilation.
544 return kDontDexToDexCompile;
545 }
Brian Carlstrom7940e442013-07-12 13:46:57 -0700546}
547
Ian Rogers3d504072014-03-01 09:16:49 -0800548void CompilerDriver::CompileOne(mirror::ArtMethod* method, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700549 DCHECK(!Runtime::Current()->IsStarted());
550 Thread* self = Thread::Current();
551 jobject jclass_loader;
552 const DexFile* dex_file;
Ian Rogers8b2c0b92013-09-19 02:56:49 -0700553 uint16_t class_def_idx;
Ian Rogersef7d42f2014-01-06 12:55:46 -0800554 uint32_t method_idx = method->GetDexMethodIndex();
555 uint32_t access_flags = method->GetAccessFlags();
556 InvokeType invoke_type = method->GetInvokeType();
Brian Carlstrom7940e442013-07-12 13:46:57 -0700557 {
558 ScopedObjectAccessUnchecked soa(self);
559 ScopedLocalRef<jobject>
560 local_class_loader(soa.Env(),
561 soa.AddLocalReference<jobject>(method->GetDeclaringClass()->GetClassLoader()));
562 jclass_loader = soa.Env()->NewGlobalRef(local_class_loader.get());
563 // Find the dex_file
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700564 dex_file = method->GetDexFile();
565 class_def_idx = method->GetClassDefIndex();
Brian Carlstrom7940e442013-07-12 13:46:57 -0700566 }
Ian Rogersef7d42f2014-01-06 12:55:46 -0800567 const DexFile::CodeItem* code_item = dex_file->GetCodeItem(method->GetCodeItemOffset());
Brian Carlstrom7940e442013-07-12 13:46:57 -0700568 self->TransitionFromRunnableToSuspended(kNative);
569
570 std::vector<const DexFile*> dex_files;
571 dex_files.push_back(dex_file);
572
Ian Rogers700a4022014-05-19 16:49:03 -0700573 std::unique_ptr<ThreadPool> thread_pool(new ThreadPool("Compiler driver thread pool", 0U));
Ian Rogers3d504072014-03-01 09:16:49 -0800574 PreCompile(jclass_loader, dex_files, thread_pool.get(), timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700575
Brian Carlstrom7940e442013-07-12 13:46:57 -0700576 // Can we run DEX-to-DEX compiler on this class ?
Sebastien Hertz75021222013-07-16 18:34:50 +0200577 DexToDexCompilationLevel dex_to_dex_compilation_level = kDontDexToDexCompile;
Brian Carlstrom7940e442013-07-12 13:46:57 -0700578 {
579 ScopedObjectAccess soa(Thread::Current());
580 const DexFile::ClassDef& class_def = dex_file->GetClassDef(class_def_idx);
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700581 StackHandleScope<1> hs(soa.Self());
582 Handle<mirror::ClassLoader> class_loader(
583 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
Ian Rogers98379392014-02-24 16:53:16 -0800584 dex_to_dex_compilation_level = GetDexToDexCompilationlevel(self, class_loader, *dex_file,
585 class_def);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700586 }
Ian Rogersef7d42f2014-01-06 12:55:46 -0800587 CompileMethod(code_item, access_flags, invoke_type, class_def_idx, method_idx, jclass_loader,
588 *dex_file, dex_to_dex_compilation_level);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700589
590 self->GetJniEnv()->DeleteGlobalRef(jclass_loader);
591
592 self->TransitionFromSuspendedToRunnable();
593}
594
595void CompilerDriver::Resolve(jobject class_loader, const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -0800596 ThreadPool* thread_pool, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700597 for (size_t i = 0; i != dex_files.size(); ++i) {
598 const DexFile* dex_file = dex_files[i];
Kenny Rootd5185342014-05-13 14:47:05 -0700599 CHECK(dex_file != nullptr);
Andreas Gampe01719872014-07-28 18:38:57 -0700600 ResolveDexFile(class_loader, *dex_file, dex_files, thread_pool, timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700601 }
602}
603
604void CompilerDriver::PreCompile(jobject class_loader, const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -0800605 ThreadPool* thread_pool, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700606 LoadImageClasses(timings);
607
Andreas Gampe35439ba2014-08-28 14:41:02 -0700608 Resolve(class_loader, dex_files, thread_pool, timings);
609
Jeff Hao4a200f52014-04-01 14:58:49 -0700610 if (!compiler_options_->IsVerificationEnabled()) {
Andreas Gampe35439ba2014-08-28 14:41:02 -0700611 VLOG(compiler) << "Verify none mode specified, skipping verification.";
612 SetVerified(class_loader, dex_files, thread_pool, timings);
Jeff Hao4a200f52014-04-01 14:58:49 -0700613 return;
614 }
615
Brian Carlstrom7940e442013-07-12 13:46:57 -0700616 Verify(class_loader, dex_files, thread_pool, timings);
617
618 InitializeClasses(class_loader, dex_files, thread_pool, timings);
619
620 UpdateImageClasses(timings);
621}
622
Ian Rogersdfb325e2013-10-30 01:00:44 -0700623bool CompilerDriver::IsImageClass(const char* descriptor) const {
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700624 if (!IsImage()) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700625 return true;
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700626 } else {
Ian Rogersdfb325e2013-10-30 01:00:44 -0700627 return image_classes_->find(descriptor) != image_classes_->end();
Brian Carlstrom7940e442013-07-12 13:46:57 -0700628 }
Brian Carlstrom7940e442013-07-12 13:46:57 -0700629}
630
631static void ResolveExceptionsForMethod(MethodHelper* mh,
Ian Rogers700a4022014-05-19 16:49:03 -0700632 std::set<std::pair<uint16_t, const DexFile*>>& exceptions_to_resolve)
Brian Carlstrom7940e442013-07-12 13:46:57 -0700633 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700634 const DexFile::CodeItem* code_item = mh->GetMethod()->GetCodeItem();
Andreas Gampe35439ba2014-08-28 14:41:02 -0700635 if (code_item == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700636 return; // native or abstract method
637 }
638 if (code_item->tries_size_ == 0) {
639 return; // nothing to process
640 }
641 const byte* encoded_catch_handler_list = DexFile::GetCatchHandlerData(*code_item, 0);
642 size_t num_encoded_catch_handlers = DecodeUnsignedLeb128(&encoded_catch_handler_list);
643 for (size_t i = 0; i < num_encoded_catch_handlers; i++) {
644 int32_t encoded_catch_handler_size = DecodeSignedLeb128(&encoded_catch_handler_list);
645 bool has_catch_all = false;
646 if (encoded_catch_handler_size <= 0) {
647 encoded_catch_handler_size = -encoded_catch_handler_size;
648 has_catch_all = true;
649 }
650 for (int32_t j = 0; j < encoded_catch_handler_size; j++) {
651 uint16_t encoded_catch_handler_handlers_type_idx =
652 DecodeUnsignedLeb128(&encoded_catch_handler_list);
653 // Add to set of types to resolve if not already in the dex cache resolved types
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700654 if (!mh->GetMethod()->IsResolvedTypeIdx(encoded_catch_handler_handlers_type_idx)) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700655 exceptions_to_resolve.insert(
656 std::pair<uint16_t, const DexFile*>(encoded_catch_handler_handlers_type_idx,
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700657 mh->GetMethod()->GetDexFile()));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700658 }
659 // ignore address associated with catch handler
660 DecodeUnsignedLeb128(&encoded_catch_handler_list);
661 }
662 if (has_catch_all) {
663 // ignore catch all address
664 DecodeUnsignedLeb128(&encoded_catch_handler_list);
665 }
666 }
667}
668
669static bool ResolveCatchBlockExceptionsClassVisitor(mirror::Class* c, void* arg)
670 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Ian Rogers700a4022014-05-19 16:49:03 -0700671 std::set<std::pair<uint16_t, const DexFile*>>* exceptions_to_resolve =
672 reinterpret_cast<std::set<std::pair<uint16_t, const DexFile*>>*>(arg);
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700673 StackHandleScope<1> hs(Thread::Current());
674 MethodHelper mh(hs.NewHandle<mirror::ArtMethod>(nullptr));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700675 for (size_t i = 0; i < c->NumVirtualMethods(); ++i) {
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700676 mh.ChangeMethod(c->GetVirtualMethod(i));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700677 ResolveExceptionsForMethod(&mh, *exceptions_to_resolve);
678 }
679 for (size_t i = 0; i < c->NumDirectMethods(); ++i) {
Mathieu Chartierbfd9a432014-05-21 17:43:44 -0700680 mh.ChangeMethod(c->GetDirectMethod(i));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700681 ResolveExceptionsForMethod(&mh, *exceptions_to_resolve);
682 }
683 return true;
684}
685
686static bool RecordImageClassesVisitor(mirror::Class* klass, void* arg)
687 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Ian Rogerscb6b0f32014-08-12 02:30:58 -0700688 std::set<std::string>* image_classes = reinterpret_cast<std::set<std::string>*>(arg);
689 std::string temp;
690 image_classes->insert(klass->GetDescriptor(&temp));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700691 return true;
692}
693
694// Make a list of descriptors for classes to include in the image
Ian Rogers3d504072014-03-01 09:16:49 -0800695void CompilerDriver::LoadImageClasses(TimingLogger* timings)
Brian Carlstrom7940e442013-07-12 13:46:57 -0700696 LOCKS_EXCLUDED(Locks::mutator_lock_) {
Kenny Rootd5185342014-05-13 14:47:05 -0700697 CHECK(timings != nullptr);
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700698 if (!IsImage()) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700699 return;
700 }
701
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700702 TimingLogger::ScopedTiming t("LoadImageClasses", timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700703 // Make a first class to load all classes explicitly listed in the file
704 Thread* self = Thread::Current();
705 ScopedObjectAccess soa(self);
706 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
Kenny Rootd5185342014-05-13 14:47:05 -0700707 CHECK(image_classes_.get() != nullptr);
Mathieu Chartier02e25112013-08-14 16:14:24 -0700708 for (auto it = image_classes_->begin(), end = image_classes_->end(); it != end;) {
Vladimir Markoe9c36b32013-11-21 15:49:16 +0000709 const std::string& descriptor(*it);
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700710 StackHandleScope<1> hs(self);
711 Handle<mirror::Class> klass(
712 hs.NewHandle(class_linker->FindSystemClass(self, descriptor.c_str())));
Andreas Gampe35439ba2014-08-28 14:41:02 -0700713 if (klass.Get() == nullptr) {
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700714 VLOG(compiler) << "Failed to find class " << descriptor;
Vladimir Markoe9c36b32013-11-21 15:49:16 +0000715 image_classes_->erase(it++);
Ian Rogersa436fde2013-08-27 23:34:06 -0700716 self->ClearException();
Brian Carlstrom7940e442013-07-12 13:46:57 -0700717 } else {
718 ++it;
719 }
720 }
721
722 // Resolve exception classes referenced by the loaded classes. The catch logic assumes
723 // exceptions are resolved by the verifier when there is a catch block in an interested method.
724 // Do this here so that exception classes appear to have been specified image classes.
Ian Rogers700a4022014-05-19 16:49:03 -0700725 std::set<std::pair<uint16_t, const DexFile*>> unresolved_exception_types;
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700726 StackHandleScope<1> hs(self);
727 Handle<mirror::Class> java_lang_Throwable(
728 hs.NewHandle(class_linker->FindSystemClass(self, "Ljava/lang/Throwable;")));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700729 do {
730 unresolved_exception_types.clear();
731 class_linker->VisitClasses(ResolveCatchBlockExceptionsClassVisitor,
732 &unresolved_exception_types);
Mathieu Chartier02e25112013-08-14 16:14:24 -0700733 for (const std::pair<uint16_t, const DexFile*>& exception_type : unresolved_exception_types) {
734 uint16_t exception_type_idx = exception_type.first;
735 const DexFile* dex_file = exception_type.second;
Mathieu Chartier0cd81352014-05-22 16:48:55 -0700736 StackHandleScope<2> hs(self);
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700737 Handle<mirror::DexCache> dex_cache(hs.NewHandle(class_linker->FindDexCache(*dex_file)));
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700738 Handle<mirror::Class> klass(hs.NewHandle(
Mathieu Chartier0cd81352014-05-22 16:48:55 -0700739 class_linker->ResolveType(*dex_file, exception_type_idx, dex_cache,
740 NullHandle<mirror::ClassLoader>())));
Andreas Gampe35439ba2014-08-28 14:41:02 -0700741 if (klass.Get() == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700742 const DexFile::TypeId& type_id = dex_file->GetTypeId(exception_type_idx);
743 const char* descriptor = dex_file->GetTypeDescriptor(type_id);
744 LOG(FATAL) << "Failed to resolve class " << descriptor;
745 }
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700746 DCHECK(java_lang_Throwable->IsAssignableFrom(klass.Get()));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700747 }
748 // Resolving exceptions may load classes that reference more exceptions, iterate until no
749 // more are found
750 } while (!unresolved_exception_types.empty());
751
752 // We walk the roots looking for classes so that we'll pick up the
753 // above classes plus any classes them depend on such super
754 // classes, interfaces, and the required ClassLinker roots.
755 class_linker->VisitClasses(RecordImageClassesVisitor, image_classes_.get());
756
757 CHECK_NE(image_classes_->size(), 0U);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700758}
759
Ian Rogerscb6b0f32014-08-12 02:30:58 -0700760static void MaybeAddToImageClasses(Handle<mirror::Class> c, std::set<std::string>* image_classes)
Brian Carlstrom7940e442013-07-12 13:46:57 -0700761 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Mathieu Chartierf8322842014-05-16 10:59:25 -0700762 Thread* self = Thread::Current();
763 StackHandleScope<1> hs(self);
764 // Make a copy of the handle so that we don't clobber it doing Assign.
765 Handle<mirror::Class> klass(hs.NewHandle(c.Get()));
Ian Rogerscb6b0f32014-08-12 02:30:58 -0700766 std::string temp;
Brian Carlstrom7940e442013-07-12 13:46:57 -0700767 while (!klass->IsObjectClass()) {
Ian Rogerscb6b0f32014-08-12 02:30:58 -0700768 const char* descriptor = klass->GetDescriptor(&temp);
769 std::pair<std::set<std::string>::iterator, bool> result = image_classes->insert(descriptor);
770 if (!result.second) { // Previously inserted.
771 break;
Brian Carlstrom7940e442013-07-12 13:46:57 -0700772 }
Ian Rogerscb6b0f32014-08-12 02:30:58 -0700773 VLOG(compiler) << "Adding " << descriptor << " to image classes";
Mathieu Chartierf8322842014-05-16 10:59:25 -0700774 for (size_t i = 0; i < klass->NumDirectInterfaces(); ++i) {
775 StackHandleScope<1> hs(self);
776 MaybeAddToImageClasses(hs.NewHandle(mirror::Class::GetDirectInterface(self, klass, i)),
777 image_classes);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700778 }
779 if (klass->IsArrayClass()) {
Mathieu Chartierf8322842014-05-16 10:59:25 -0700780 StackHandleScope<1> hs(self);
781 MaybeAddToImageClasses(hs.NewHandle(klass->GetComponentType()), image_classes);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700782 }
Mathieu Chartierf8322842014-05-16 10:59:25 -0700783 klass.Assign(klass->GetSuperClass());
Brian Carlstrom7940e442013-07-12 13:46:57 -0700784 }
785}
786
787void CompilerDriver::FindClinitImageClassesCallback(mirror::Object* object, void* arg) {
Andreas Gampe35439ba2014-08-28 14:41:02 -0700788 DCHECK(object != nullptr);
789 DCHECK(arg != nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700790 CompilerDriver* compiler_driver = reinterpret_cast<CompilerDriver*>(arg);
Mathieu Chartierf8322842014-05-16 10:59:25 -0700791 StackHandleScope<1> hs(Thread::Current());
792 MaybeAddToImageClasses(hs.NewHandle(object->GetClass()), compiler_driver->image_classes_.get());
Brian Carlstrom7940e442013-07-12 13:46:57 -0700793}
794
Ian Rogers3d504072014-03-01 09:16:49 -0800795void CompilerDriver::UpdateImageClasses(TimingLogger* timings) {
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700796 if (IsImage()) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -0700797 TimingLogger::ScopedTiming t("UpdateImageClasses", timings);
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700798 // Update image_classes_ with classes for objects created by <clinit> methods.
799 Thread* self = Thread::Current();
800 const char* old_cause = self->StartAssertNoThreadSuspension("ImageWriter");
801 gc::Heap* heap = Runtime::Current()->GetHeap();
802 // TODO: Image spaces only?
Mathieu Chartier590fee92013-09-13 13:46:47 -0700803 ScopedObjectAccess soa(Thread::Current());
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700804 WriterMutexLock mu(self, *Locks::heap_bitmap_lock_);
Mathieu Chartier590fee92013-09-13 13:46:47 -0700805 heap->VisitObjects(FindClinitImageClassesCallback, this);
Ian Rogerse6bb3b22013-08-19 21:51:45 -0700806 self->EndAssertNoThreadSuspension(old_cause);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700807 }
Brian Carlstrom7940e442013-07-12 13:46:57 -0700808}
809
Mathieu Chartier590fee92013-09-13 13:46:47 -0700810bool CompilerDriver::CanAssumeTypeIsPresentInDexCache(const DexFile& dex_file, uint32_t type_idx) {
Ian Rogersfc0e94b2013-09-23 23:51:32 -0700811 if (IsImage() &&
Ian Rogersdfb325e2013-10-30 01:00:44 -0700812 IsImageClass(dex_file.StringDataByIdx(dex_file.GetTypeId(type_idx).descriptor_idx_))) {
Andreas Gampe4ef12f52014-07-31 16:23:49 -0700813 {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700814 ScopedObjectAccess soa(Thread::Current());
815 mirror::DexCache* dex_cache = Runtime::Current()->GetClassLinker()->FindDexCache(dex_file);
816 mirror::Class* resolved_class = dex_cache->GetResolvedType(type_idx);
Andreas Gampe4ef12f52014-07-31 16:23:49 -0700817 if (resolved_class == nullptr) {
818 // Erroneous class.
819 stats_->TypeNotInDexCache();
820 return false;
821 }
Brian Carlstrom7940e442013-07-12 13:46:57 -0700822 }
823 stats_->TypeInDexCache();
824 return true;
825 } else {
826 stats_->TypeNotInDexCache();
827 return false;
828 }
829}
830
831bool CompilerDriver::CanAssumeStringIsPresentInDexCache(const DexFile& dex_file,
832 uint32_t string_idx) {
833 // See also Compiler::ResolveDexFile
834
835 bool result = false;
836 if (IsImage()) {
837 // We resolve all const-string strings when building for the image.
838 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartiereb8167a2014-05-07 15:43:14 -0700839 StackHandleScope<1> hs(soa.Self());
840 Handle<mirror::DexCache> dex_cache(
841 hs.NewHandle(Runtime::Current()->GetClassLinker()->FindDexCache(dex_file)));
Brian Carlstrom7940e442013-07-12 13:46:57 -0700842 Runtime::Current()->GetClassLinker()->ResolveString(dex_file, string_idx, dex_cache);
843 result = true;
844 }
845 if (result) {
846 stats_->StringInDexCache();
847 } else {
848 stats_->StringNotInDexCache();
849 }
850 return result;
851}
852
853bool CompilerDriver::CanAccessTypeWithoutChecks(uint32_t referrer_idx, const DexFile& dex_file,
854 uint32_t type_idx,
855 bool* type_known_final, bool* type_known_abstract,
856 bool* equals_referrers_class) {
Andreas Gampe35439ba2014-08-28 14:41:02 -0700857 if (type_known_final != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700858 *type_known_final = false;
859 }
Andreas Gampe35439ba2014-08-28 14:41:02 -0700860 if (type_known_abstract != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700861 *type_known_abstract = false;
862 }
Andreas Gampe35439ba2014-08-28 14:41:02 -0700863 if (equals_referrers_class != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700864 *equals_referrers_class = false;
865 }
866 ScopedObjectAccess soa(Thread::Current());
867 mirror::DexCache* dex_cache = Runtime::Current()->GetClassLinker()->FindDexCache(dex_file);
868 // Get type from dex cache assuming it was populated by the verifier
869 mirror::Class* resolved_class = dex_cache->GetResolvedType(type_idx);
Andreas Gampe35439ba2014-08-28 14:41:02 -0700870 if (resolved_class == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700871 stats_->TypeNeedsAccessCheck();
872 return false; // Unknown class needs access checks.
873 }
874 const DexFile::MethodId& method_id = dex_file.GetMethodId(referrer_idx);
Andreas Gampe35439ba2014-08-28 14:41:02 -0700875 if (equals_referrers_class != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700876 *equals_referrers_class = (method_id.class_idx_ == type_idx);
877 }
878 mirror::Class* referrer_class = dex_cache->GetResolvedType(method_id.class_idx_);
Andreas Gampe35439ba2014-08-28 14:41:02 -0700879 if (referrer_class == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700880 stats_->TypeNeedsAccessCheck();
881 return false; // Incomplete referrer knowledge needs access check.
882 }
883 // Perform access check, will return true if access is ok or false if we're going to have to
884 // check this at runtime (for example for class loaders).
885 bool result = referrer_class->CanAccess(resolved_class);
886 if (result) {
887 stats_->TypeDoesntNeedAccessCheck();
Andreas Gampe35439ba2014-08-28 14:41:02 -0700888 if (type_known_final != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700889 *type_known_final = resolved_class->IsFinal() && !resolved_class->IsArrayClass();
890 }
Andreas Gampe35439ba2014-08-28 14:41:02 -0700891 if (type_known_abstract != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700892 *type_known_abstract = resolved_class->IsAbstract() && !resolved_class->IsArrayClass();
893 }
894 } else {
895 stats_->TypeNeedsAccessCheck();
896 }
897 return result;
898}
899
900bool CompilerDriver::CanAccessInstantiableTypeWithoutChecks(uint32_t referrer_idx,
901 const DexFile& dex_file,
902 uint32_t type_idx) {
903 ScopedObjectAccess soa(Thread::Current());
904 mirror::DexCache* dex_cache = Runtime::Current()->GetClassLinker()->FindDexCache(dex_file);
905 // Get type from dex cache assuming it was populated by the verifier.
906 mirror::Class* resolved_class = dex_cache->GetResolvedType(type_idx);
Andreas Gampe35439ba2014-08-28 14:41:02 -0700907 if (resolved_class == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700908 stats_->TypeNeedsAccessCheck();
909 return false; // Unknown class needs access checks.
910 }
911 const DexFile::MethodId& method_id = dex_file.GetMethodId(referrer_idx);
912 mirror::Class* referrer_class = dex_cache->GetResolvedType(method_id.class_idx_);
Andreas Gampe35439ba2014-08-28 14:41:02 -0700913 if (referrer_class == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -0700914 stats_->TypeNeedsAccessCheck();
915 return false; // Incomplete referrer knowledge needs access check.
916 }
917 // Perform access and instantiable checks, will return true if access is ok or false if we're
918 // going to have to check this at runtime (for example for class loaders).
919 bool result = referrer_class->CanAccess(resolved_class) && resolved_class->IsInstantiable();
920 if (result) {
921 stats_->TypeDoesntNeedAccessCheck();
922 } else {
923 stats_->TypeNeedsAccessCheck();
924 }
925 return result;
926}
927
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800928bool CompilerDriver::CanEmbedTypeInCode(const DexFile& dex_file, uint32_t type_idx,
929 bool* is_type_initialized, bool* use_direct_type_ptr,
Mathieu Chartier8668c3c2014-04-24 16:48:11 -0700930 uintptr_t* direct_type_ptr, bool* out_is_finalizable) {
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800931 ScopedObjectAccess soa(Thread::Current());
932 mirror::DexCache* dex_cache = Runtime::Current()->GetClassLinker()->FindDexCache(dex_file);
933 mirror::Class* resolved_class = dex_cache->GetResolvedType(type_idx);
934 if (resolved_class == nullptr) {
935 return false;
936 }
Mathieu Chartier8668c3c2014-04-24 16:48:11 -0700937 *out_is_finalizable = resolved_class->IsFinalizable();
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800938 const bool compiling_boot = Runtime::Current()->GetHeap()->IsCompilingBoot();
Alex Light345c4b12014-07-18 14:57:04 -0700939 const bool support_boot_image_fixup = GetSupportBootImageFixup();
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800940 if (compiling_boot) {
941 // boot -> boot class pointers.
942 // True if the class is in the image at boot compiling time.
943 const bool is_image_class = IsImage() && IsImageClass(
944 dex_file.StringDataByIdx(dex_file.GetTypeId(type_idx).descriptor_idx_));
945 // True if pc relative load works.
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800946 if (is_image_class && support_boot_image_fixup) {
947 *is_type_initialized = resolved_class->IsInitialized();
948 *use_direct_type_ptr = false;
949 *direct_type_ptr = 0;
950 return true;
951 } else {
952 return false;
953 }
954 } else {
955 // True if the class is in the image at app compiling time.
956 const bool class_in_image =
957 Runtime::Current()->GetHeap()->FindSpaceFromObject(resolved_class, false)->IsImageSpace();
Alex Light345c4b12014-07-18 14:57:04 -0700958 if (class_in_image && support_boot_image_fixup) {
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800959 // boot -> app class pointers.
960 *is_type_initialized = resolved_class->IsInitialized();
Alex Lighta59dd802014-07-02 16:28:08 -0700961 // TODO This is somewhat hacky. We should refactor all of this invoke codepath.
962 *use_direct_type_ptr = !GetCompilerOptions().GetIncludePatchInformation();
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -0800963 *direct_type_ptr = reinterpret_cast<uintptr_t>(resolved_class);
964 return true;
965 } else {
966 // app -> app class pointers.
967 // Give up because app does not have an image and class
968 // isn't created at compile time. TODO: implement this
969 // if/when each app gets an image.
970 return false;
971 }
972 }
973}
974
Vladimir Markobe0e5462014-02-26 11:24:15 +0000975void CompilerDriver::ProcessedInstanceField(bool resolved) {
976 if (!resolved) {
977 stats_->UnresolvedInstanceField();
978 } else {
979 stats_->ResolvedInstanceField();
980 }
981}
982
983void CompilerDriver::ProcessedStaticField(bool resolved, bool local) {
984 if (!resolved) {
985 stats_->UnresolvedStaticField();
986 } else if (local) {
987 stats_->ResolvedLocalStaticField();
988 } else {
989 stats_->ResolvedStaticField();
990 }
991}
992
Vladimir Markof096aad2014-01-23 15:51:58 +0000993void CompilerDriver::ProcessedInvoke(InvokeType invoke_type, int flags) {
994 stats_->ProcessedInvoke(invoke_type, flags);
Brian Carlstrom7940e442013-07-12 13:46:57 -0700995}
996
Nicolas Geoffraye5038322014-07-04 09:41:32 +0100997mirror::ArtField* CompilerDriver::ComputeInstanceFieldInfo(uint32_t field_idx,
998 const DexCompilationUnit* mUnit,
999 bool is_put,
1000 const ScopedObjectAccess& soa) {
Vladimir Markobe0e5462014-02-26 11:24:15 +00001001 // Try to resolve the field and compiling method's class.
1002 mirror::ArtField* resolved_field;
1003 mirror::Class* referrer_class;
1004 mirror::DexCache* dex_cache;
1005 {
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001006 StackHandleScope<3> hs(soa.Self());
1007 Handle<mirror::DexCache> dex_cache_handle(
1008 hs.NewHandle(mUnit->GetClassLinker()->FindDexCache(*mUnit->GetDexFile())));
1009 Handle<mirror::ClassLoader> class_loader_handle(
1010 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(mUnit->GetClassLoader())));
1011 Handle<mirror::ArtField> resolved_field_handle(hs.NewHandle(
1012 ResolveField(soa, dex_cache_handle, class_loader_handle, mUnit, field_idx, false)));
1013 referrer_class = (resolved_field_handle.Get() != nullptr)
1014 ? ResolveCompilingMethodsClass(soa, dex_cache_handle, class_loader_handle, mUnit) : nullptr;
1015 resolved_field = resolved_field_handle.Get();
1016 dex_cache = dex_cache_handle.Get();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001017 }
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001018 bool can_link = false;
Vladimir Markobe0e5462014-02-26 11:24:15 +00001019 if (resolved_field != nullptr && referrer_class != nullptr) {
Vladimir Markobe0e5462014-02-26 11:24:15 +00001020 std::pair<bool, bool> fast_path = IsFastInstanceField(
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001021 dex_cache, referrer_class, resolved_field, field_idx);
1022 can_link = is_put ? fast_path.second : fast_path.first;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001023 }
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001024 ProcessedInstanceField(can_link);
1025 return can_link ? resolved_field : nullptr;
1026}
1027
1028bool CompilerDriver::ComputeInstanceFieldInfo(uint32_t field_idx, const DexCompilationUnit* mUnit,
1029 bool is_put, MemberOffset* field_offset,
1030 bool* is_volatile) {
1031 ScopedObjectAccess soa(Thread::Current());
1032 StackHandleScope<1> hs(soa.Self());
1033 Handle<mirror::ArtField> resolved_field =
1034 hs.NewHandle(ComputeInstanceFieldInfo(field_idx, mUnit, is_put, soa));
1035
1036 if (resolved_field.Get() == nullptr) {
Vladimir Markobe0e5462014-02-26 11:24:15 +00001037 // Conservative defaults.
1038 *is_volatile = true;
1039 *field_offset = MemberOffset(static_cast<size_t>(-1));
Nicolas Geoffraye5038322014-07-04 09:41:32 +01001040 return false;
1041 } else {
1042 *is_volatile = resolved_field->IsVolatile();
1043 *field_offset = resolved_field->GetOffset();
1044 return true;
Vladimir Markobe0e5462014-02-26 11:24:15 +00001045 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001046}
1047
1048bool CompilerDriver::ComputeStaticFieldInfo(uint32_t field_idx, const DexCompilationUnit* mUnit,
Vladimir Markobe0e5462014-02-26 11:24:15 +00001049 bool is_put, MemberOffset* field_offset,
1050 uint32_t* storage_index, bool* is_referrers_class,
1051 bool* is_volatile, bool* is_initialized) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001052 ScopedObjectAccess soa(Thread::Current());
Vladimir Markobe0e5462014-02-26 11:24:15 +00001053 // Try to resolve the field and compiling method's class.
1054 mirror::ArtField* resolved_field;
1055 mirror::Class* referrer_class;
1056 mirror::DexCache* dex_cache;
1057 {
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001058 StackHandleScope<3> hs(soa.Self());
1059 Handle<mirror::DexCache> dex_cache_handle(
1060 hs.NewHandle(mUnit->GetClassLinker()->FindDexCache(*mUnit->GetDexFile())));
1061 Handle<mirror::ClassLoader> class_loader_handle(
1062 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(mUnit->GetClassLoader())));
1063 Handle<mirror::ArtField> resolved_field_handle(hs.NewHandle(
1064 ResolveField(soa, dex_cache_handle, class_loader_handle, mUnit, field_idx, true)));
1065 referrer_class = (resolved_field_handle.Get() != nullptr)
1066 ? ResolveCompilingMethodsClass(soa, dex_cache_handle, class_loader_handle, mUnit) : nullptr;
1067 resolved_field = resolved_field_handle.Get();
1068 dex_cache = dex_cache_handle.Get();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001069 }
Vladimir Markobe0e5462014-02-26 11:24:15 +00001070 bool result = false;
1071 if (resolved_field != nullptr && referrer_class != nullptr) {
1072 *is_volatile = IsFieldVolatile(resolved_field);
1073 std::pair<bool, bool> fast_path = IsFastStaticField(
1074 dex_cache, referrer_class, resolved_field, field_idx, field_offset,
1075 storage_index, is_referrers_class, is_initialized);
1076 result = is_put ? fast_path.second : fast_path.first;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001077 }
Vladimir Markobe0e5462014-02-26 11:24:15 +00001078 if (!result) {
1079 // Conservative defaults.
1080 *is_volatile = true;
1081 *field_offset = MemberOffset(static_cast<size_t>(-1));
1082 *storage_index = -1;
1083 *is_referrers_class = false;
1084 *is_initialized = false;
1085 }
1086 ProcessedStaticField(result, *is_referrers_class);
1087 return result;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001088}
1089
Ian Rogers83883d72013-10-21 21:07:24 -07001090void CompilerDriver::GetCodeAndMethodForDirectCall(InvokeType* type, InvokeType sharp_type,
1091 bool no_guarantee_of_dex_cache_entry,
Brian Carlstrom7940e442013-07-12 13:46:57 -07001092 mirror::Class* referrer_class,
Brian Carlstromea46f952013-07-30 01:26:50 -07001093 mirror::ArtMethod* method,
Vladimir Markof096aad2014-01-23 15:51:58 +00001094 int* stats_flags,
Ian Rogers83883d72013-10-21 21:07:24 -07001095 MethodReference* target_method,
Ian Rogers65ec92c2013-09-06 10:49:58 -07001096 uintptr_t* direct_code,
1097 uintptr_t* direct_method) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001098 // For direct and static methods compute possible direct_code and direct_method values, ie
1099 // an address for the Method* being invoked and an address of the code for that Method*.
1100 // For interface calls compute a value for direct_method that is the interface method being
1101 // invoked, so this can be passed to the out-of-line runtime support code.
Ian Rogers65ec92c2013-09-06 10:49:58 -07001102 *direct_code = 0;
1103 *direct_method = 0;
Ian Rogers83883d72013-10-21 21:07:24 -07001104 bool use_dex_cache = false;
Mathieu Chartier590fee92013-09-13 13:46:47 -07001105 const bool compiling_boot = Runtime::Current()->GetHeap()->IsCompilingBoot();
Alex Lighta59dd802014-07-02 16:28:08 -07001106 // TODO This is somewhat hacky. We should refactor all of this invoke codepath.
1107 const bool force_relocations = (compiling_boot ||
1108 GetCompilerOptions().GetIncludePatchInformation());
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001109 if (compiler_->IsPortable()) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001110 if (sharp_type != kStatic && sharp_type != kDirect) {
1111 return;
1112 }
Ian Rogers83883d72013-10-21 21:07:24 -07001113 use_dex_cache = true;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001114 } else {
Jeff Hao88474b42013-10-23 16:24:40 -07001115 if (sharp_type != kStatic && sharp_type != kDirect) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001116 return;
1117 }
Ian Rogers83883d72013-10-21 21:07:24 -07001118 // TODO: support patching on all architectures.
Alex Lighta59dd802014-07-02 16:28:08 -07001119 use_dex_cache = force_relocations && !support_boot_image_fixup_;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001120 }
Ian Rogers83883d72013-10-21 21:07:24 -07001121 bool method_code_in_boot = (method->GetDeclaringClass()->GetClassLoader() == nullptr);
1122 if (!use_dex_cache) {
1123 if (!method_code_in_boot) {
1124 use_dex_cache = true;
1125 } else {
1126 bool has_clinit_trampoline =
1127 method->IsStatic() && !method->GetDeclaringClass()->IsInitialized();
1128 if (has_clinit_trampoline && (method->GetDeclaringClass() != referrer_class)) {
1129 // Ensure we run the clinit trampoline unless we are invoking a static method in the same
1130 // class.
1131 use_dex_cache = true;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001132 }
1133 }
Ian Rogers83883d72013-10-21 21:07:24 -07001134 }
Vladimir Markof096aad2014-01-23 15:51:58 +00001135 if (method_code_in_boot) {
1136 *stats_flags |= kFlagDirectCallToBoot | kFlagDirectMethodToBoot;
Ian Rogers83883d72013-10-21 21:07:24 -07001137 }
Alex Lighta59dd802014-07-02 16:28:08 -07001138 if (!use_dex_cache && force_relocations) {
1139 if (!IsImage() || !IsImageClass(method->GetDeclaringClassDescriptor())) {
Ian Rogers83883d72013-10-21 21:07:24 -07001140 // We can only branch directly to Methods that are resolved in the DexCache.
1141 // Otherwise we won't invoke the resolution trampoline.
1142 use_dex_cache = true;
1143 }
1144 }
1145 // The method is defined not within this dex file. We need a dex cache slot within the current
1146 // dex file or direct pointers.
1147 bool must_use_direct_pointers = false;
1148 if (target_method->dex_file == method->GetDeclaringClass()->GetDexCache()->GetDexFile()) {
1149 target_method->dex_method_index = method->GetDexMethodIndex();
1150 } else {
Ian Rogers83883d72013-10-21 21:07:24 -07001151 if (no_guarantee_of_dex_cache_entry) {
Mathieu Chartierbfd9a432014-05-21 17:43:44 -07001152 StackHandleScope<1> hs(Thread::Current());
1153 MethodHelper mh(hs.NewHandle(method));
Ian Rogers83883d72013-10-21 21:07:24 -07001154 // See if the method is also declared in this dex cache.
Mathieu Chartierbfd9a432014-05-21 17:43:44 -07001155 uint32_t dex_method_idx = mh.FindDexMethodIndexInOtherDexFile(
Vladimir Markobbcc0c02014-02-03 14:08:42 +00001156 *target_method->dex_file, target_method->dex_method_index);
Ian Rogers83883d72013-10-21 21:07:24 -07001157 if (dex_method_idx != DexFile::kDexNoIndex) {
1158 target_method->dex_method_index = dex_method_idx;
1159 } else {
Alex Lighta59dd802014-07-02 16:28:08 -07001160 if (force_relocations && !use_dex_cache) {
Jeff Hao49161ce2014-03-12 11:05:25 -07001161 target_method->dex_method_index = method->GetDexMethodIndex();
1162 target_method->dex_file = method->GetDeclaringClass()->GetDexCache()->GetDexFile();
1163 }
Ian Rogers83883d72013-10-21 21:07:24 -07001164 must_use_direct_pointers = true;
1165 }
1166 }
1167 }
1168 if (use_dex_cache) {
1169 if (must_use_direct_pointers) {
1170 // Fail. Test above showed the only safe dispatch was via the dex cache, however, the direct
1171 // pointers are required as the dex cache lacks an appropriate entry.
1172 VLOG(compiler) << "Dex cache devirtualization failed for: " << PrettyMethod(method);
1173 } else {
1174 *type = sharp_type;
1175 }
1176 } else {
Alex Lighta59dd802014-07-02 16:28:08 -07001177 bool method_in_image =
Vladimir Markoa51a0b02014-05-21 12:08:39 +01001178 Runtime::Current()->GetHeap()->FindSpaceFromObject(method, false)->IsImageSpace();
Alex Lighta59dd802014-07-02 16:28:08 -07001179 if (method_in_image || compiling_boot) {
1180 // We know we must be able to get to the method in the image, so use that pointer.
Vladimir Markoa51a0b02014-05-21 12:08:39 +01001181 CHECK(!method->IsAbstract());
Ian Rogers83883d72013-10-21 21:07:24 -07001182 *type = sharp_type;
Alex Lighta59dd802014-07-02 16:28:08 -07001183 *direct_method = force_relocations ? -1 : reinterpret_cast<uintptr_t>(method);
1184 *direct_code = force_relocations ? -1 : compiler_->GetEntryPointOf(method);
Vladimir Markoa51a0b02014-05-21 12:08:39 +01001185 target_method->dex_file = method->GetDeclaringClass()->GetDexCache()->GetDexFile();
1186 target_method->dex_method_index = method->GetDexMethodIndex();
1187 } else if (!must_use_direct_pointers) {
1188 // Set the code and rely on the dex cache for the method.
1189 *type = sharp_type;
Alex Lighta59dd802014-07-02 16:28:08 -07001190 if (force_relocations) {
1191 *direct_code = -1;
1192 target_method->dex_file = method->GetDeclaringClass()->GetDexCache()->GetDexFile();
1193 target_method->dex_method_index = method->GetDexMethodIndex();
1194 } else {
1195 *direct_code = compiler_->GetEntryPointOf(method);
1196 }
Ian Rogers83883d72013-10-21 21:07:24 -07001197 } else {
Vladimir Markoa51a0b02014-05-21 12:08:39 +01001198 // Direct pointers were required but none were available.
1199 VLOG(compiler) << "Dex cache devirtualization failed for: " << PrettyMethod(method);
Ian Rogers83883d72013-10-21 21:07:24 -07001200 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001201 }
1202}
1203
1204bool CompilerDriver::ComputeInvokeInfo(const DexCompilationUnit* mUnit, const uint32_t dex_pc,
Ian Rogers65ec92c2013-09-06 10:49:58 -07001205 bool update_stats, bool enable_devirtualization,
1206 InvokeType* invoke_type, MethodReference* target_method,
1207 int* vtable_idx, uintptr_t* direct_code,
1208 uintptr_t* direct_method) {
Vladimir Markof096aad2014-01-23 15:51:58 +00001209 InvokeType orig_invoke_type = *invoke_type;
1210 int stats_flags = 0;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001211 ScopedObjectAccess soa(Thread::Current());
Vladimir Markof096aad2014-01-23 15:51:58 +00001212 // Try to resolve the method and compiling method's class.
1213 mirror::ArtMethod* resolved_method;
1214 mirror::Class* referrer_class;
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001215 StackHandleScope<3> hs(soa.Self());
1216 Handle<mirror::DexCache> dex_cache(
1217 hs.NewHandle(mUnit->GetClassLinker()->FindDexCache(*mUnit->GetDexFile())));
1218 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1219 soa.Decode<mirror::ClassLoader*>(mUnit->GetClassLoader())));
Vladimir Markof096aad2014-01-23 15:51:58 +00001220 {
1221 uint32_t method_idx = target_method->dex_method_index;
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001222 Handle<mirror::ArtMethod> resolved_method_handle(hs.NewHandle(
1223 ResolveMethod(soa, dex_cache, class_loader, mUnit, method_idx, orig_invoke_type)));
1224 referrer_class = (resolved_method_handle.Get() != nullptr)
Vladimir Markof096aad2014-01-23 15:51:58 +00001225 ? ResolveCompilingMethodsClass(soa, dex_cache, class_loader, mUnit) : nullptr;
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001226 resolved_method = resolved_method_handle.Get();
Vladimir Markof096aad2014-01-23 15:51:58 +00001227 }
1228 bool result = false;
1229 if (resolved_method != nullptr) {
1230 *vtable_idx = GetResolvedMethodVTableIndex(resolved_method, orig_invoke_type);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001231
Vladimir Markof096aad2014-01-23 15:51:58 +00001232 if (enable_devirtualization) {
1233 DCHECK(mUnit->GetVerifiedMethod() != nullptr);
1234 const MethodReference* devirt_target = mUnit->GetVerifiedMethod()->GetDevirtTarget(dex_pc);
1235
1236 stats_flags = IsFastInvoke(
1237 soa, dex_cache, class_loader, mUnit, referrer_class, resolved_method,
1238 invoke_type, target_method, devirt_target, direct_code, direct_method);
1239 result = stats_flags != 0;
1240 } else {
1241 // Devirtualization not enabled. Inline IsFastInvoke(), dropping the devirtualization parts.
1242 if (UNLIKELY(referrer_class == nullptr) ||
1243 UNLIKELY(!referrer_class->CanAccessResolvedMethod(resolved_method->GetDeclaringClass(),
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001244 resolved_method, dex_cache.Get(),
Vladimir Markof096aad2014-01-23 15:51:58 +00001245 target_method->dex_method_index)) ||
1246 *invoke_type == kSuper) {
1247 // Slow path. (Without devirtualization, all super calls go slow path as well.)
1248 } else {
1249 // Sharpening failed so generate a regular resolved method dispatch.
1250 stats_flags = kFlagMethodResolved;
1251 GetCodeAndMethodForDirectCall(invoke_type, *invoke_type, false, referrer_class, resolved_method,
1252 &stats_flags, target_method, direct_code, direct_method);
1253 result = true;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001254 }
1255 }
1256 }
Vladimir Markof096aad2014-01-23 15:51:58 +00001257 if (!result) {
1258 // Conservative defaults.
1259 *vtable_idx = -1;
1260 *direct_code = 0u;
1261 *direct_method = 0u;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001262 }
1263 if (update_stats) {
Vladimir Markof096aad2014-01-23 15:51:58 +00001264 ProcessedInvoke(orig_invoke_type, stats_flags);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001265 }
Vladimir Markof096aad2014-01-23 15:51:58 +00001266 return result;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001267}
1268
Vladimir Marko2730db02014-01-27 11:15:17 +00001269const VerifiedMethod* CompilerDriver::GetVerifiedMethod(const DexFile* dex_file,
1270 uint32_t method_idx) const {
1271 MethodReference ref(dex_file, method_idx);
1272 return verification_results_->GetVerifiedMethod(ref);
1273}
1274
1275bool CompilerDriver::IsSafeCast(const DexCompilationUnit* mUnit, uint32_t dex_pc) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07001276 if (!compiler_options_->IsVerificationEnabled()) {
1277 // If we didn't verify, every cast has to be treated as non-safe.
1278 return false;
1279 }
Vladimir Marko2730db02014-01-27 11:15:17 +00001280 DCHECK(mUnit->GetVerifiedMethod() != nullptr);
1281 bool result = mUnit->GetVerifiedMethod()->IsSafeCast(dex_pc);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001282 if (result) {
1283 stats_->SafeCast();
1284 } else {
1285 stats_->NotASafeCast();
1286 }
1287 return result;
1288}
1289
Brian Carlstrom7940e442013-07-12 13:46:57 -07001290void CompilerDriver::AddCodePatch(const DexFile* dex_file,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07001291 uint16_t referrer_class_def_idx,
1292 uint32_t referrer_method_idx,
1293 InvokeType referrer_invoke_type,
1294 uint32_t target_method_idx,
Jeff Hao49161ce2014-03-12 11:05:25 -07001295 const DexFile* target_dex_file,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07001296 InvokeType target_invoke_type,
1297 size_t literal_offset) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001298 MutexLock mu(Thread::Current(), compiled_methods_lock_);
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -08001299 code_to_patch_.push_back(new CallPatchInformation(dex_file,
1300 referrer_class_def_idx,
1301 referrer_method_idx,
1302 referrer_invoke_type,
1303 target_method_idx,
Jeff Hao49161ce2014-03-12 11:05:25 -07001304 target_dex_file,
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -08001305 target_invoke_type,
1306 literal_offset));
Brian Carlstrom7940e442013-07-12 13:46:57 -07001307}
Mark Mendell55d0eac2014-02-06 11:02:52 -08001308void CompilerDriver::AddRelativeCodePatch(const DexFile* dex_file,
1309 uint16_t referrer_class_def_idx,
1310 uint32_t referrer_method_idx,
1311 InvokeType referrer_invoke_type,
1312 uint32_t target_method_idx,
Jeff Hao49161ce2014-03-12 11:05:25 -07001313 const DexFile* target_dex_file,
Mark Mendell55d0eac2014-02-06 11:02:52 -08001314 InvokeType target_invoke_type,
1315 size_t literal_offset,
1316 int32_t pc_relative_offset) {
1317 MutexLock mu(Thread::Current(), compiled_methods_lock_);
1318 code_to_patch_.push_back(new RelativeCallPatchInformation(dex_file,
1319 referrer_class_def_idx,
1320 referrer_method_idx,
1321 referrer_invoke_type,
1322 target_method_idx,
Jeff Hao49161ce2014-03-12 11:05:25 -07001323 target_dex_file,
Mark Mendell55d0eac2014-02-06 11:02:52 -08001324 target_invoke_type,
1325 literal_offset,
1326 pc_relative_offset));
1327}
Brian Carlstrom7940e442013-07-12 13:46:57 -07001328void CompilerDriver::AddMethodPatch(const DexFile* dex_file,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07001329 uint16_t referrer_class_def_idx,
1330 uint32_t referrer_method_idx,
1331 InvokeType referrer_invoke_type,
1332 uint32_t target_method_idx,
Jeff Hao49161ce2014-03-12 11:05:25 -07001333 const DexFile* target_dex_file,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07001334 InvokeType target_invoke_type,
1335 size_t literal_offset) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001336 MutexLock mu(Thread::Current(), compiled_methods_lock_);
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -08001337 methods_to_patch_.push_back(new CallPatchInformation(dex_file,
1338 referrer_class_def_idx,
1339 referrer_method_idx,
1340 referrer_invoke_type,
1341 target_method_idx,
Jeff Hao49161ce2014-03-12 11:05:25 -07001342 target_dex_file,
Hiroshi Yamauchibe1ca552014-01-15 11:46:48 -08001343 target_invoke_type,
1344 literal_offset));
1345}
1346void CompilerDriver::AddClassPatch(const DexFile* dex_file,
1347 uint16_t referrer_class_def_idx,
1348 uint32_t referrer_method_idx,
1349 uint32_t target_type_idx,
1350 size_t literal_offset) {
1351 MutexLock mu(Thread::Current(), compiled_methods_lock_);
1352 classes_to_patch_.push_back(new TypePatchInformation(dex_file,
1353 referrer_class_def_idx,
1354 referrer_method_idx,
1355 target_type_idx,
1356 literal_offset));
Brian Carlstrom7940e442013-07-12 13:46:57 -07001357}
1358
1359class ParallelCompilationManager {
1360 public:
1361 typedef void Callback(const ParallelCompilationManager* manager, size_t index);
1362
1363 ParallelCompilationManager(ClassLinker* class_linker,
1364 jobject class_loader,
1365 CompilerDriver* compiler,
1366 const DexFile* dex_file,
Andreas Gampe01719872014-07-28 18:38:57 -07001367 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001368 ThreadPool* thread_pool)
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001369 : index_(0),
1370 class_linker_(class_linker),
Brian Carlstrom7940e442013-07-12 13:46:57 -07001371 class_loader_(class_loader),
1372 compiler_(compiler),
1373 dex_file_(dex_file),
Andreas Gampe01719872014-07-28 18:38:57 -07001374 dex_files_(dex_files),
Ian Rogers3d504072014-03-01 09:16:49 -08001375 thread_pool_(thread_pool) {}
Brian Carlstrom7940e442013-07-12 13:46:57 -07001376
1377 ClassLinker* GetClassLinker() const {
Andreas Gampe35439ba2014-08-28 14:41:02 -07001378 CHECK(class_linker_ != nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001379 return class_linker_;
1380 }
1381
1382 jobject GetClassLoader() const {
1383 return class_loader_;
1384 }
1385
1386 CompilerDriver* GetCompiler() const {
Andreas Gampe35439ba2014-08-28 14:41:02 -07001387 CHECK(compiler_ != nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001388 return compiler_;
1389 }
1390
1391 const DexFile* GetDexFile() const {
Andreas Gampe35439ba2014-08-28 14:41:02 -07001392 CHECK(dex_file_ != nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001393 return dex_file_;
1394 }
1395
Andreas Gampe01719872014-07-28 18:38:57 -07001396 const std::vector<const DexFile*>& GetDexFiles() const {
1397 return dex_files_;
1398 }
1399
Brian Carlstrom7940e442013-07-12 13:46:57 -07001400 void ForAll(size_t begin, size_t end, Callback callback, size_t work_units) {
1401 Thread* self = Thread::Current();
1402 self->AssertNoPendingException();
1403 CHECK_GT(work_units, 0U);
1404
Ian Rogers3e5cf302014-05-20 16:40:37 -07001405 index_.StoreRelaxed(begin);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001406 for (size_t i = 0; i < work_units; ++i) {
Sebastien Hertz501baec2013-12-13 12:02:36 +01001407 thread_pool_->AddTask(self, new ForAllClosure(this, end, callback));
Brian Carlstrom7940e442013-07-12 13:46:57 -07001408 }
1409 thread_pool_->StartWorkers(self);
1410
1411 // Ensure we're suspended while we're blocked waiting for the other threads to finish (worker
1412 // thread destructor's called below perform join).
1413 CHECK_NE(self->GetState(), kRunnable);
1414
1415 // Wait for all the worker threads to finish.
1416 thread_pool_->Wait(self, true, false);
1417 }
1418
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001419 size_t NextIndex() {
Ian Rogers3e5cf302014-05-20 16:40:37 -07001420 return index_.FetchAndAddSequentiallyConsistent(1);
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001421 }
1422
Brian Carlstrom7940e442013-07-12 13:46:57 -07001423 private:
Brian Carlstrom7940e442013-07-12 13:46:57 -07001424 class ForAllClosure : public Task {
1425 public:
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001426 ForAllClosure(ParallelCompilationManager* manager, size_t end, Callback* callback)
Brian Carlstrom7940e442013-07-12 13:46:57 -07001427 : manager_(manager),
Brian Carlstrom7940e442013-07-12 13:46:57 -07001428 end_(end),
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001429 callback_(callback) {}
Brian Carlstrom7940e442013-07-12 13:46:57 -07001430
1431 virtual void Run(Thread* self) {
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001432 while (true) {
1433 const size_t index = manager_->NextIndex();
1434 if (UNLIKELY(index >= end_)) {
1435 break;
1436 }
1437 callback_(manager_, index);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001438 self->AssertNoPendingException();
1439 }
1440 }
1441
1442 virtual void Finalize() {
1443 delete this;
1444 }
Brian Carlstrom0cd7ec22013-07-17 23:40:20 -07001445
Brian Carlstrom7940e442013-07-12 13:46:57 -07001446 private:
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001447 ParallelCompilationManager* const manager_;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001448 const size_t end_;
Bernhard Rosenkränzer46053622013-12-12 02:15:52 +01001449 Callback* const callback_;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001450 };
1451
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001452 AtomicInteger index_;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001453 ClassLinker* const class_linker_;
1454 const jobject class_loader_;
1455 CompilerDriver* const compiler_;
1456 const DexFile* const dex_file_;
Andreas Gampe01719872014-07-28 18:38:57 -07001457 const std::vector<const DexFile*>& dex_files_;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001458 ThreadPool* const thread_pool_;
Mathieu Chartier0b3eb392013-08-23 14:56:59 -07001459
1460 DISALLOW_COPY_AND_ASSIGN(ParallelCompilationManager);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001461};
1462
Jeff Hao0e49b422013-11-08 12:16:56 -08001463// A fast version of SkipClass above if the class pointer is available
1464// that avoids the expensive FindInClassPath search.
1465static bool SkipClass(jobject class_loader, const DexFile& dex_file, mirror::Class* klass)
1466 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07001467 DCHECK(klass != nullptr);
Jeff Hao0e49b422013-11-08 12:16:56 -08001468 const DexFile& original_dex_file = *klass->GetDexCache()->GetDexFile();
1469 if (&dex_file != &original_dex_file) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07001470 if (class_loader == nullptr) {
Jeff Hao0e49b422013-11-08 12:16:56 -08001471 LOG(WARNING) << "Skipping class " << PrettyDescriptor(klass) << " from "
1472 << dex_file.GetLocation() << " previously found in "
1473 << original_dex_file.GetLocation();
1474 }
1475 return true;
1476 }
1477 return false;
1478}
1479
Mathieu Chartier70b63482014-06-27 17:19:04 -07001480static void CheckAndClearResolveException(Thread* self)
1481 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
1482 CHECK(self->IsExceptionPending());
1483 mirror::Throwable* exception = self->GetException(nullptr);
Ian Rogerscb6b0f32014-08-12 02:30:58 -07001484 std::string temp;
1485 const char* descriptor = exception->GetClass()->GetDescriptor(&temp);
1486 const char* expected_exceptions[] = {
1487 "Ljava/lang/IllegalAccessError;",
1488 "Ljava/lang/IncompatibleClassChangeError;",
1489 "Ljava/lang/InstantiationError;",
Brian Carlstrom118785c2014-08-25 23:07:30 -07001490 "Ljava/lang/LinkageError;",
Ian Rogerscb6b0f32014-08-12 02:30:58 -07001491 "Ljava/lang/NoClassDefFoundError;",
1492 "Ljava/lang/NoSuchFieldError;",
1493 "Ljava/lang/NoSuchMethodError;"
1494 };
1495 bool found = false;
1496 for (size_t i = 0; (found == false) && (i < arraysize(expected_exceptions)); ++i) {
1497 if (strcmp(descriptor, expected_exceptions[i]) == 0) {
1498 found = true;
1499 }
1500 }
1501 if (!found) {
Brian Carlstrom118785c2014-08-25 23:07:30 -07001502 LOG(FATAL) << "Unexpected exception " << exception->Dump();
Mathieu Chartier70b63482014-06-27 17:19:04 -07001503 }
1504 self->ClearException();
1505}
1506
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001507static void ResolveClassFieldsAndMethods(const ParallelCompilationManager* manager,
1508 size_t class_def_index)
Brian Carlstrom7940e442013-07-12 13:46:57 -07001509 LOCKS_EXCLUDED(Locks::mutator_lock_) {
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001510 ATRACE_CALL();
Ian Rogersbe7149f2013-08-20 09:29:39 -07001511 Thread* self = Thread::Current();
1512 jobject jclass_loader = manager->GetClassLoader();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001513 const DexFile& dex_file = *manager->GetDexFile();
Ian Rogersbe7149f2013-08-20 09:29:39 -07001514 ClassLinker* class_linker = manager->GetClassLinker();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001515
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001516 // If an instance field is final then we need to have a barrier on the return, static final
1517 // fields are assigned within the lock held for class initialization. Conservatively assume
1518 // constructor barriers are always required.
1519 bool requires_constructor_barrier = true;
1520
Brian Carlstrom7940e442013-07-12 13:46:57 -07001521 // Method and Field are the worst. We can't resolve without either
1522 // context from the code use (to disambiguate virtual vs direct
1523 // method and instance vs static field) or from class
1524 // definitions. While the compiler will resolve what it can as it
1525 // needs it, here we try to resolve fields and methods used in class
1526 // definitions, since many of them many never be referenced by
1527 // generated code.
1528 const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_index);
Ian Rogerscc2f2392014-08-29 20:19:11 -07001529 ScopedObjectAccess soa(self);
1530 StackHandleScope<2> hs(soa.Self());
1531 Handle<mirror::ClassLoader> class_loader(
1532 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
1533 Handle<mirror::DexCache> dex_cache(hs.NewHandle(class_linker->FindDexCache(dex_file)));
1534 // Resolve the class.
1535 mirror::Class* klass = class_linker->ResolveType(dex_file, class_def.class_idx_, dex_cache,
1536 class_loader);
1537 bool resolve_fields_and_methods;
1538 if (klass == nullptr) {
1539 // Class couldn't be resolved, for example, super-class is in a different dex file. Don't
1540 // attempt to resolve methods and fields when there is no declaring class.
1541 CheckAndClearResolveException(soa.Self());
1542 resolve_fields_and_methods = false;
1543 } else {
1544 // We successfully resolved a class, should we skip it?
1545 if (SkipClass(jclass_loader, dex_file, klass)) {
1546 return;
Brian Carlstromcb5f5e52013-09-23 17:48:16 -07001547 }
Ian Rogerscc2f2392014-08-29 20:19:11 -07001548 // We want to resolve the methods and fields eagerly.
1549 resolve_fields_and_methods = true;
1550 }
1551 // Note the class_data pointer advances through the headers,
1552 // static fields, instance fields, direct methods, and virtual
1553 // methods.
1554 const byte* class_data = dex_file.GetClassData(class_def);
Andreas Gampe35439ba2014-08-28 14:41:02 -07001555 if (class_data == nullptr) {
Ian Rogerscc2f2392014-08-29 20:19:11 -07001556 // Empty class such as a marker interface.
1557 requires_constructor_barrier = false;
1558 } else {
1559 ClassDataItemIterator it(dex_file, class_data);
1560 while (it.HasNextStaticField()) {
1561 if (resolve_fields_and_methods) {
1562 mirror::ArtField* field = class_linker->ResolveField(dex_file, it.GetMemberIndex(),
1563 dex_cache, class_loader, true);
Andreas Gampe35439ba2014-08-28 14:41:02 -07001564 if (field == nullptr) {
Ian Rogerscc2f2392014-08-29 20:19:11 -07001565 CheckAndClearResolveException(soa.Self());
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001566 }
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001567 }
Ian Rogerscc2f2392014-08-29 20:19:11 -07001568 it.Next();
1569 }
1570 // We require a constructor barrier if there are final instance fields.
1571 requires_constructor_barrier = false;
1572 while (it.HasNextInstanceField()) {
1573 if ((it.GetMemberAccessFlags() & kAccFinal) != 0) {
1574 requires_constructor_barrier = true;
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001575 }
1576 if (resolve_fields_and_methods) {
Ian Rogerscc2f2392014-08-29 20:19:11 -07001577 mirror::ArtField* field = class_linker->ResolveField(dex_file, it.GetMemberIndex(),
1578 dex_cache, class_loader, false);
Andreas Gampe35439ba2014-08-28 14:41:02 -07001579 if (field == nullptr) {
Ian Rogerscc2f2392014-08-29 20:19:11 -07001580 CheckAndClearResolveException(soa.Self());
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001581 }
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001582 }
Ian Rogerscc2f2392014-08-29 20:19:11 -07001583 it.Next();
1584 }
1585 if (resolve_fields_and_methods) {
1586 while (it.HasNextDirectMethod()) {
1587 mirror::ArtMethod* method = class_linker->ResolveMethod(dex_file, it.GetMemberIndex(),
1588 dex_cache, class_loader,
1589 NullHandle<mirror::ArtMethod>(),
1590 it.GetMethodInvokeType(class_def));
Andreas Gampe35439ba2014-08-28 14:41:02 -07001591 if (method == nullptr) {
Ian Rogerscc2f2392014-08-29 20:19:11 -07001592 CheckAndClearResolveException(soa.Self());
1593 }
1594 it.Next();
1595 }
1596 while (it.HasNextVirtualMethod()) {
1597 mirror::ArtMethod* method = class_linker->ResolveMethod(dex_file, it.GetMemberIndex(),
1598 dex_cache, class_loader,
1599 NullHandle<mirror::ArtMethod>(),
1600 it.GetMethodInvokeType(class_def));
Andreas Gampe35439ba2014-08-28 14:41:02 -07001601 if (method == nullptr) {
Ian Rogerscc2f2392014-08-29 20:19:11 -07001602 CheckAndClearResolveException(soa.Self());
1603 }
1604 it.Next();
1605 }
1606 DCHECK(!it.HasNext());
Brian Carlstrom7940e442013-07-12 13:46:57 -07001607 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001608 }
1609 if (requires_constructor_barrier) {
Ian Rogersbe7149f2013-08-20 09:29:39 -07001610 manager->GetCompiler()->AddRequiresConstructorBarrier(self, &dex_file, class_def_index);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001611 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001612}
1613
1614static void ResolveType(const ParallelCompilationManager* manager, size_t type_idx)
1615 LOCKS_EXCLUDED(Locks::mutator_lock_) {
1616 // Class derived values are more complicated, they require the linker and loader.
1617 ScopedObjectAccess soa(Thread::Current());
1618 ClassLinker* class_linker = manager->GetClassLinker();
1619 const DexFile& dex_file = *manager->GetDexFile();
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001620 StackHandleScope<2> hs(soa.Self());
1621 Handle<mirror::DexCache> dex_cache(hs.NewHandle(class_linker->FindDexCache(dex_file)));
1622 Handle<mirror::ClassLoader> class_loader(
1623 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(manager->GetClassLoader())));
Brian Carlstrom7940e442013-07-12 13:46:57 -07001624 mirror::Class* klass = class_linker->ResolveType(dex_file, type_idx, dex_cache, class_loader);
1625
Andreas Gampe35439ba2014-08-28 14:41:02 -07001626 if (klass == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001627 CHECK(soa.Self()->IsExceptionPending());
Andreas Gampe35439ba2014-08-28 14:41:02 -07001628 mirror::Throwable* exception = soa.Self()->GetException(nullptr);
Ian Rogersa436fde2013-08-27 23:34:06 -07001629 VLOG(compiler) << "Exception during type resolution: " << exception->Dump();
Mathieu Chartierf8322842014-05-16 10:59:25 -07001630 if (exception->GetClass()->DescriptorEquals("Ljava/lang/OutOfMemoryError;")) {
Ian Rogersa436fde2013-08-27 23:34:06 -07001631 // There's little point continuing compilation if the heap is exhausted.
1632 LOG(FATAL) << "Out of memory during type resolution for compilation";
1633 }
1634 soa.Self()->ClearException();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001635 }
1636}
1637
1638void CompilerDriver::ResolveDexFile(jobject class_loader, const DexFile& dex_file,
Andreas Gampe01719872014-07-28 18:38:57 -07001639 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001640 ThreadPool* thread_pool, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001641 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1642
1643 // TODO: we could resolve strings here, although the string table is largely filled with class
1644 // and method names.
1645
Andreas Gampe01719872014-07-28 18:38:57 -07001646 ParallelCompilationManager context(class_linker, class_loader, this, &dex_file, dex_files,
1647 thread_pool);
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001648 if (IsImage()) {
1649 // For images we resolve all types, such as array, whereas for applications just those with
1650 // classdefs are resolved by ResolveClassFieldsAndMethods.
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001651 TimingLogger::ScopedTiming t("Resolve Types", timings);
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001652 context.ForAll(0, dex_file.NumTypeIds(), ResolveType, thread_count_);
1653 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001654
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001655 TimingLogger::ScopedTiming t("Resolve MethodsAndFields", timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001656 context.ForAll(0, dex_file.NumClassDefs(), ResolveClassFieldsAndMethods, thread_count_);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001657}
1658
Andreas Gampe35439ba2014-08-28 14:41:02 -07001659void CompilerDriver::SetVerified(jobject class_loader, const std::vector<const DexFile*>& dex_files,
1660 ThreadPool* thread_pool, TimingLogger* timings) {
1661 for (size_t i = 0; i != dex_files.size(); ++i) {
1662 const DexFile* dex_file = dex_files[i];
1663 CHECK(dex_file != nullptr);
1664 SetVerifiedDexFile(class_loader, *dex_file, dex_files, thread_pool, timings);
1665 }
1666}
1667
Brian Carlstrom7940e442013-07-12 13:46:57 -07001668void CompilerDriver::Verify(jobject class_loader, const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001669 ThreadPool* thread_pool, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001670 for (size_t i = 0; i != dex_files.size(); ++i) {
1671 const DexFile* dex_file = dex_files[i];
Andreas Gampe35439ba2014-08-28 14:41:02 -07001672 CHECK(dex_file != nullptr);
Andreas Gampe01719872014-07-28 18:38:57 -07001673 VerifyDexFile(class_loader, *dex_file, dex_files, thread_pool, timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001674 }
1675}
1676
1677static void VerifyClass(const ParallelCompilationManager* manager, size_t class_def_index)
1678 LOCKS_EXCLUDED(Locks::mutator_lock_) {
Anwar Ghuloum67f99412013-08-12 14:19:48 -07001679 ATRACE_CALL();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001680 ScopedObjectAccess soa(Thread::Current());
Jeff Hao0e49b422013-11-08 12:16:56 -08001681 const DexFile& dex_file = *manager->GetDexFile();
1682 const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_index);
1683 const char* descriptor = dex_file.GetClassDescriptor(class_def);
1684 ClassLinker* class_linker = manager->GetClassLinker();
1685 jobject jclass_loader = manager->GetClassLoader();
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001686 StackHandleScope<3> hs(soa.Self());
1687 Handle<mirror::ClassLoader> class_loader(
1688 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
1689 Handle<mirror::Class> klass(
1690 hs.NewHandle(class_linker->FindClass(soa.Self(), descriptor, class_loader)));
1691 if (klass.Get() == nullptr) {
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001692 CHECK(soa.Self()->IsExceptionPending());
Brian Carlstrom7940e442013-07-12 13:46:57 -07001693 soa.Self()->ClearException();
1694
1695 /*
1696 * At compile time, we can still structurally verify the class even if FindClass fails.
1697 * This is to ensure the class is structurally sound for compilation. An unsound class
1698 * will be rejected by the verifier and later skipped during compilation in the compiler.
1699 */
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001700 Handle<mirror::DexCache> dex_cache(hs.NewHandle(class_linker->FindDexCache(dex_file)));
Brian Carlstrom7940e442013-07-12 13:46:57 -07001701 std::string error_msg;
Mathieu Chartier590fee92013-09-13 13:46:47 -07001702 if (verifier::MethodVerifier::VerifyClass(&dex_file, dex_cache, class_loader, &class_def, true,
1703 &error_msg) ==
Brian Carlstrom7940e442013-07-12 13:46:57 -07001704 verifier::MethodVerifier::kHardFailure) {
Jeff Hao0e49b422013-11-08 12:16:56 -08001705 LOG(ERROR) << "Verification failed on class " << PrettyDescriptor(descriptor)
Brian Carlstrom7940e442013-07-12 13:46:57 -07001706 << " because: " << error_msg;
1707 }
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001708 } else if (!SkipClass(jclass_loader, dex_file, klass.Get())) {
1709 CHECK(klass->IsResolved()) << PrettyClass(klass.Get());
Jeff Hao0e49b422013-11-08 12:16:56 -08001710 class_linker->VerifyClass(klass);
Ian Rogerse6bb3b22013-08-19 21:51:45 -07001711
1712 if (klass->IsErroneous()) {
1713 // ClassLinker::VerifyClass throws, which isn't useful in the compiler.
1714 CHECK(soa.Self()->IsExceptionPending());
1715 soa.Self()->ClearException();
1716 }
1717
1718 CHECK(klass->IsCompileTimeVerified() || klass->IsErroneous())
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001719 << PrettyDescriptor(klass.Get()) << ": state=" << klass->GetStatus();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001720 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001721 soa.Self()->AssertNoPendingException();
1722}
1723
1724void CompilerDriver::VerifyDexFile(jobject class_loader, const DexFile& dex_file,
Andreas Gampe01719872014-07-28 18:38:57 -07001725 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001726 ThreadPool* thread_pool, TimingLogger* timings) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001727 TimingLogger::ScopedTiming t("Verify Dex File", timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001728 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
Andreas Gampe01719872014-07-28 18:38:57 -07001729 ParallelCompilationManager context(class_linker, class_loader, this, &dex_file, dex_files,
1730 thread_pool);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001731 context.ForAll(0, dex_file.NumClassDefs(), VerifyClass, thread_count_);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001732}
1733
Andreas Gampe35439ba2014-08-28 14:41:02 -07001734static void SetVerifiedClass(const ParallelCompilationManager* manager, size_t class_def_index)
1735 LOCKS_EXCLUDED(Locks::mutator_lock_) {
1736 ATRACE_CALL();
1737 ScopedObjectAccess soa(Thread::Current());
1738 const DexFile& dex_file = *manager->GetDexFile();
1739 const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_index);
1740 const char* descriptor = dex_file.GetClassDescriptor(class_def);
1741 ClassLinker* class_linker = manager->GetClassLinker();
1742 jobject jclass_loader = manager->GetClassLoader();
1743 StackHandleScope<3> hs(soa.Self());
1744 Handle<mirror::ClassLoader> class_loader(
1745 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
1746 Handle<mirror::Class> klass(
1747 hs.NewHandle(class_linker->FindClass(soa.Self(), descriptor, class_loader)));
1748 // Class might have failed resolution. Then don't set it to verified.
1749 if (klass.Get() != nullptr) {
1750 // Only do this if the class is resolved. If even resolution fails, quickening will go very,
1751 // very wrong.
1752 if (klass->IsResolved()) {
1753 if (klass->GetStatus() < mirror::Class::kStatusVerified) {
1754 ObjectLock<mirror::Class> lock(soa.Self(), klass);
1755 klass->SetStatus(mirror::Class::kStatusVerified, soa.Self());
1756 }
1757 // Record the final class status if necessary.
1758 ClassReference ref(manager->GetDexFile(), class_def_index);
1759 manager->GetCompiler()->RecordClassStatus(ref, klass->GetStatus());
1760 }
1761 }
1762 soa.Self()->AssertNoPendingException();
1763}
1764
1765void CompilerDriver::SetVerifiedDexFile(jobject class_loader, const DexFile& dex_file,
1766 const std::vector<const DexFile*>& dex_files,
1767 ThreadPool* thread_pool, TimingLogger* timings) {
1768 TimingLogger::ScopedTiming t("Verify Dex File", timings);
1769 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1770 ParallelCompilationManager context(class_linker, class_loader, this, &dex_file, dex_files,
1771 thread_pool);
1772 context.ForAll(0, dex_file.NumClassDefs(), SetVerifiedClass, thread_count_);
1773}
1774
Brian Carlstrom7940e442013-07-12 13:46:57 -07001775static void InitializeClass(const ParallelCompilationManager* manager, size_t class_def_index)
1776 LOCKS_EXCLUDED(Locks::mutator_lock_) {
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001777 ATRACE_CALL();
Jeff Hao0e49b422013-11-08 12:16:56 -08001778 jobject jclass_loader = manager->GetClassLoader();
1779 const DexFile& dex_file = *manager->GetDexFile();
1780 const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_index);
Jeff Haobcdbbfe2013-11-08 18:03:22 -08001781 const DexFile::TypeId& class_type_id = dex_file.GetTypeId(class_def.class_idx_);
1782 const char* descriptor = dex_file.StringDataByIdx(class_type_id.descriptor_idx_);
Ian Rogersfc0e94b2013-09-23 23:51:32 -07001783
Brian Carlstrom7940e442013-07-12 13:46:57 -07001784 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001785 StackHandleScope<3> hs(soa.Self());
1786 Handle<mirror::ClassLoader> class_loader(
1787 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
1788 Handle<mirror::Class> klass(
1789 hs.NewHandle(manager->GetClassLinker()->FindClass(soa.Self(), descriptor, class_loader)));
Jeff Hao0e49b422013-11-08 12:16:56 -08001790
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001791 if (klass.Get() != nullptr && !SkipClass(jclass_loader, dex_file, klass.Get())) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001792 // Only try to initialize classes that were successfully verified.
1793 if (klass->IsVerified()) {
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001794 // Attempt to initialize the class but bail if we either need to initialize the super-class
1795 // or static fields.
1796 manager->GetClassLinker()->EnsureInitialized(klass, false, false);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001797 if (!klass->IsInitialized()) {
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001798 // We don't want non-trivial class initialization occurring on multiple threads due to
1799 // deadlock problems. For example, a parent class is initialized (holding its lock) that
1800 // refers to a sub-class in its static/class initializer causing it to try to acquire the
1801 // sub-class' lock. While on a second thread the sub-class is initialized (holding its lock)
1802 // after first initializing its parents, whose locks are acquired. This leads to a
1803 // parent-to-child and a child-to-parent lock ordering and consequent potential deadlock.
1804 // We need to use an ObjectLock due to potential suspension in the interpreting code. Rather
1805 // than use a special Object for the purpose we use the Class of java.lang.Class.
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001806 Handle<mirror::Class> h_klass(hs.NewHandle(klass->GetClass()));
Mathieu Chartierdb2633c2014-05-16 09:59:29 -07001807 ObjectLock<mirror::Class> lock(soa.Self(), h_klass);
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001808 // Attempt to initialize allowing initialization of parent classes but still not static
1809 // fields.
1810 manager->GetClassLinker()->EnsureInitialized(klass, false, true);
1811 if (!klass->IsInitialized()) {
1812 // We need to initialize static fields, we only do this for image classes that aren't
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +01001813 // marked with the $NoPreloadHolder (which implies this should not be initialized early).
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001814 bool can_init_static_fields = manager->GetCompiler()->IsImage() &&
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +01001815 manager->GetCompiler()->IsImageClass(descriptor) &&
1816 !StringPiece(descriptor).ends_with("$NoPreloadHolder;");
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001817 if (can_init_static_fields) {
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +01001818 VLOG(compiler) << "Initializing: " << descriptor;
Ian Rogersc45b8b52014-05-03 01:39:59 -07001819 // TODO multithreading support. We should ensure the current compilation thread has
1820 // exclusive access to the runtime and the transaction. To achieve this, we could use
1821 // a ReaderWriterMutex but we're holding the mutator lock so we fail mutex sanity
1822 // checks in Thread::AssertThreadSuspensionIsAllowable.
1823 Runtime* const runtime = Runtime::Current();
1824 Transaction transaction;
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +01001825
Ian Rogersc45b8b52014-05-03 01:39:59 -07001826 // Run the class initializer in transaction mode.
1827 runtime->EnterTransactionMode(&transaction);
1828 const mirror::Class::Status old_status = klass->GetStatus();
1829 bool success = manager->GetClassLinker()->EnsureInitialized(klass, true, true);
1830 // TODO we detach transaction from runtime to indicate we quit the transactional
1831 // mode which prevents the GC from visiting objects modified during the transaction.
1832 // Ensure GC is not run so don't access freed objects when aborting transaction.
1833 const char* old_casue = soa.Self()->StartAssertNoThreadSuspension("Transaction end");
1834 runtime->ExitTransactionMode();
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +01001835
Ian Rogersc45b8b52014-05-03 01:39:59 -07001836 if (!success) {
1837 CHECK(soa.Self()->IsExceptionPending());
1838 ThrowLocation throw_location;
1839 mirror::Throwable* exception = soa.Self()->GetException(&throw_location);
1840 VLOG(compiler) << "Initialization of " << descriptor << " aborted because of "
1841 << exception->Dump();
1842 soa.Self()->ClearException();
1843 transaction.Abort();
1844 CHECK_EQ(old_status, klass->GetStatus()) << "Previous class status not restored";
Brian Carlstrom7940e442013-07-12 13:46:57 -07001845 }
Ian Rogersc45b8b52014-05-03 01:39:59 -07001846 soa.Self()->EndAssertNoThreadSuspension(old_casue);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001847 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001848 }
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001849 soa.Self()->AssertNoPendingException();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001850 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001851 }
1852 // Record the final class status if necessary.
Brian Carlstrom7940e442013-07-12 13:46:57 -07001853 ClassReference ref(manager->GetDexFile(), class_def_index);
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07001854 manager->GetCompiler()->RecordClassStatus(ref, klass->GetStatus());
Brian Carlstrom7940e442013-07-12 13:46:57 -07001855 }
1856 // Clear any class not found or verification exceptions.
1857 soa.Self()->ClearException();
1858}
1859
1860void CompilerDriver::InitializeClasses(jobject jni_class_loader, const DexFile& dex_file,
Andreas Gampe01719872014-07-28 18:38:57 -07001861 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001862 ThreadPool* thread_pool, TimingLogger* timings) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001863 TimingLogger::ScopedTiming t("InitializeNoClinit", timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001864 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
Andreas Gampe01719872014-07-28 18:38:57 -07001865 ParallelCompilationManager context(class_linker, jni_class_loader, this, &dex_file, dex_files,
1866 thread_pool);
Sebastien Hertzd2fe10a2014-01-15 10:20:56 +01001867 size_t thread_count;
1868 if (IsImage()) {
1869 // TODO: remove this when transactional mode supports multithreading.
1870 thread_count = 1U;
1871 } else {
1872 thread_count = thread_count_;
1873 }
1874 context.ForAll(0, dex_file.NumClassDefs(), InitializeClass, thread_count);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001875}
1876
1877void CompilerDriver::InitializeClasses(jobject class_loader,
1878 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001879 ThreadPool* thread_pool, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001880 for (size_t i = 0; i != dex_files.size(); ++i) {
1881 const DexFile* dex_file = dex_files[i];
Andreas Gampe35439ba2014-08-28 14:41:02 -07001882 CHECK(dex_file != nullptr);
Andreas Gampe01719872014-07-28 18:38:57 -07001883 InitializeClasses(class_loader, *dex_file, dex_files, thread_pool, timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001884 }
Mathieu Chartiera73a8b52014-08-11 13:52:12 -07001885 if (IsImage()) {
1886 // Prune garbage objects created during aborted transactions.
1887 Runtime::Current()->GetHeap()->CollectGarbage(true);
1888 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001889}
1890
1891void CompilerDriver::Compile(jobject class_loader, const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001892 ThreadPool* thread_pool, TimingLogger* timings) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001893 for (size_t i = 0; i != dex_files.size(); ++i) {
1894 const DexFile* dex_file = dex_files[i];
Andreas Gampe35439ba2014-08-28 14:41:02 -07001895 CHECK(dex_file != nullptr);
Andreas Gampe01719872014-07-28 18:38:57 -07001896 CompileDexFile(class_loader, *dex_file, dex_files, thread_pool, timings);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001897 }
1898}
1899
1900void CompilerDriver::CompileClass(const ParallelCompilationManager* manager, size_t class_def_index) {
Anwar Ghuloum67f99412013-08-12 14:19:48 -07001901 ATRACE_CALL();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001902 const DexFile& dex_file = *manager->GetDexFile();
1903 const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_index);
Ian Rogersbe7149f2013-08-20 09:29:39 -07001904 ClassLinker* class_linker = manager->GetClassLinker();
Ian Rogerscb6b0f32014-08-12 02:30:58 -07001905 jobject jclass_loader = manager->GetClassLoader();
1906 {
1907 // Use a scoped object access to perform to the quick SkipClass check.
1908 const char* descriptor = dex_file.GetClassDescriptor(class_def);
1909 ScopedObjectAccess soa(Thread::Current());
1910 StackHandleScope<3> hs(soa.Self());
1911 Handle<mirror::ClassLoader> class_loader(
1912 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
1913 Handle<mirror::Class> klass(
1914 hs.NewHandle(class_linker->FindClass(soa.Self(), descriptor, class_loader)));
1915 if (klass.Get() == nullptr) {
1916 CHECK(soa.Self()->IsExceptionPending());
1917 soa.Self()->ClearException();
1918 } else if (SkipClass(jclass_loader, dex_file, klass.Get())) {
1919 return;
1920 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07001921 }
1922 ClassReference ref(&dex_file, class_def_index);
1923 // Skip compiling classes with generic verifier failures since they will still fail at runtime
Vladimir Markoc7f83202014-01-24 17:55:18 +00001924 if (manager->GetCompiler()->verification_results_->IsClassRejected(ref)) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001925 return;
1926 }
1927 const byte* class_data = dex_file.GetClassData(class_def);
Andreas Gampe35439ba2014-08-28 14:41:02 -07001928 if (class_data == nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07001929 // empty class, probably a marker interface
1930 return;
1931 }
Anwar Ghuloum67f99412013-08-12 14:19:48 -07001932
Brian Carlstrom7940e442013-07-12 13:46:57 -07001933 // Can we run DEX-to-DEX compiler on this class ?
Sebastien Hertz75021222013-07-16 18:34:50 +02001934 DexToDexCompilationLevel dex_to_dex_compilation_level = kDontDexToDexCompile;
Brian Carlstrom7940e442013-07-12 13:46:57 -07001935 {
1936 ScopedObjectAccess soa(Thread::Current());
Mathieu Chartiereb8167a2014-05-07 15:43:14 -07001937 StackHandleScope<1> hs(soa.Self());
1938 Handle<mirror::ClassLoader> class_loader(
1939 hs.NewHandle(soa.Decode<mirror::ClassLoader*>(jclass_loader)));
Ian Rogers98379392014-02-24 16:53:16 -08001940 dex_to_dex_compilation_level = GetDexToDexCompilationlevel(soa.Self(), class_loader, dex_file,
1941 class_def);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001942 }
1943 ClassDataItemIterator it(dex_file, class_data);
1944 // Skip fields
1945 while (it.HasNextStaticField()) {
1946 it.Next();
1947 }
1948 while (it.HasNextInstanceField()) {
1949 it.Next();
1950 }
Ian Rogersbe7149f2013-08-20 09:29:39 -07001951 CompilerDriver* driver = manager->GetCompiler();
Brian Carlstrom7940e442013-07-12 13:46:57 -07001952 // Compile direct methods
1953 int64_t previous_direct_method_idx = -1;
1954 while (it.HasNextDirectMethod()) {
1955 uint32_t method_idx = it.GetMemberIndex();
1956 if (method_idx == previous_direct_method_idx) {
1957 // smali can create dex files with two encoded_methods sharing the same method_idx
1958 // http://code.google.com/p/smali/issues/detail?id=119
1959 it.Next();
1960 continue;
1961 }
1962 previous_direct_method_idx = method_idx;
Ian Rogersbe7149f2013-08-20 09:29:39 -07001963 driver->CompileMethod(it.GetMethodCodeItem(), it.GetMemberAccessFlags(),
1964 it.GetMethodInvokeType(class_def), class_def_index,
1965 method_idx, jclass_loader, dex_file, dex_to_dex_compilation_level);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001966 it.Next();
1967 }
1968 // Compile virtual methods
1969 int64_t previous_virtual_method_idx = -1;
1970 while (it.HasNextVirtualMethod()) {
1971 uint32_t method_idx = it.GetMemberIndex();
1972 if (method_idx == previous_virtual_method_idx) {
1973 // smali can create dex files with two encoded_methods sharing the same method_idx
1974 // http://code.google.com/p/smali/issues/detail?id=119
1975 it.Next();
1976 continue;
1977 }
1978 previous_virtual_method_idx = method_idx;
Ian Rogersbe7149f2013-08-20 09:29:39 -07001979 driver->CompileMethod(it.GetMethodCodeItem(), it.GetMemberAccessFlags(),
1980 it.GetMethodInvokeType(class_def), class_def_index,
1981 method_idx, jclass_loader, dex_file, dex_to_dex_compilation_level);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001982 it.Next();
1983 }
1984 DCHECK(!it.HasNext());
1985}
1986
1987void CompilerDriver::CompileDexFile(jobject class_loader, const DexFile& dex_file,
Andreas Gampe01719872014-07-28 18:38:57 -07001988 const std::vector<const DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08001989 ThreadPool* thread_pool, TimingLogger* timings) {
Mathieu Chartierf5997b42014-06-20 10:37:54 -07001990 TimingLogger::ScopedTiming t("Compile Dex File", timings);
Ian Rogersbe7149f2013-08-20 09:29:39 -07001991 ParallelCompilationManager context(Runtime::Current()->GetClassLinker(), class_loader, this,
Andreas Gampe01719872014-07-28 18:38:57 -07001992 &dex_file, dex_files, thread_pool);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001993 context.ForAll(0, dex_file.NumClassDefs(), CompilerDriver::CompileClass, thread_count_);
Brian Carlstrom7940e442013-07-12 13:46:57 -07001994}
1995
1996void CompilerDriver::CompileMethod(const DexFile::CodeItem* code_item, uint32_t access_flags,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07001997 InvokeType invoke_type, uint16_t class_def_idx,
Brian Carlstrom7940e442013-07-12 13:46:57 -07001998 uint32_t method_idx, jobject class_loader,
1999 const DexFile& dex_file,
Sebastien Hertz75021222013-07-16 18:34:50 +02002000 DexToDexCompilationLevel dex_to_dex_compilation_level) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07002001 CompiledMethod* compiled_method = nullptr;
Mathieu Chartierb68c6e52014-08-19 14:29:46 -07002002 uint64_t start_ns = kTimeCompileMethod ? NanoTime() : 0;
Brian Carlstrom7940e442013-07-12 13:46:57 -07002003
2004 if ((access_flags & kAccNative) != 0) {
Ian Rogers0188ab72014-03-17 16:51:53 -07002005 // Are we interpreting only and have support for generic JNI down calls?
Jeff Hao4a200f52014-04-01 14:58:49 -07002006 if (!compiler_options_->IsCompilationEnabled() &&
Stuart Monteithb95a5342014-03-12 13:32:32 +00002007 (instruction_set_ == kX86_64 || instruction_set_ == kArm64)) {
Ian Rogers5b271492014-03-14 13:20:26 -07002008 // Leaving this empty will trigger the generic JNI version
2009 } else {
Ian Rogers72d32622014-05-06 16:20:11 -07002010 compiled_method = compiler_->JniCompile(access_flags, method_idx, dex_file);
Andreas Gampe35439ba2014-08-28 14:41:02 -07002011 CHECK(compiled_method != nullptr);
Ian Rogers5b271492014-03-14 13:20:26 -07002012 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07002013 } else if ((access_flags & kAccAbstract) != 0) {
2014 } else {
Dragos Sbirlea90af14d2013-08-15 17:50:16 -07002015 MethodReference method_ref(&dex_file, method_idx);
Brian Carlstrom6449c622014-02-10 23:48:36 -08002016 bool compile = verification_results_->IsCandidateForCompilation(method_ref, access_flags);
Sebastien Hertz4d4adb12013-07-24 16:14:19 +02002017 if (compile) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07002018 // NOTE: if compiler declines to compile this method, it will return nullptr.
Ian Rogers72d32622014-05-06 16:20:11 -07002019 compiled_method = compiler_->Compile(code_item, access_flags, invoke_type, class_def_idx,
2020 method_idx, class_loader, dex_file);
Sebastien Hertz17965ed2014-04-04 15:59:53 +02002021 }
2022 if (compiled_method == nullptr && dex_to_dex_compilation_level != kDontDexToDexCompile) {
2023 // TODO: add a command-line option to disable DEX-to-DEX compilation ?
Sebastien Hertz75021222013-07-16 18:34:50 +02002024 (*dex_to_dex_compiler_)(*this, code_item, access_flags,
2025 invoke_type, class_def_idx,
2026 method_idx, class_loader, dex_file,
2027 dex_to_dex_compilation_level);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002028 }
2029 }
Mathieu Chartierb68c6e52014-08-19 14:29:46 -07002030 if (kTimeCompileMethod) {
2031 uint64_t duration_ns = NanoTime() - start_ns;
2032 if (duration_ns > MsToNs(compiler_->GetMaximumCompilationTimeBeforeWarning())) {
2033 LOG(WARNING) << "Compilation of " << PrettyMethod(method_idx, dex_file)
2034 << " took " << PrettyDuration(duration_ns);
2035 }
Brian Carlstrom7940e442013-07-12 13:46:57 -07002036 }
2037
2038 Thread* self = Thread::Current();
Andreas Gampe35439ba2014-08-28 14:41:02 -07002039 if (compiled_method != nullptr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07002040 MethodReference ref(&dex_file, method_idx);
Andreas Gampe35439ba2014-08-28 14:41:02 -07002041 DCHECK(GetCompiledMethod(ref) == nullptr) << PrettyMethod(method_idx, dex_file);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002042 {
2043 MutexLock mu(self, compiled_methods_lock_);
2044 compiled_methods_.Put(ref, compiled_method);
2045 }
Andreas Gampe35439ba2014-08-28 14:41:02 -07002046 DCHECK(GetCompiledMethod(ref) != nullptr) << PrettyMethod(method_idx, dex_file);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002047 }
2048
2049 if (self->IsExceptionPending()) {
2050 ScopedObjectAccess soa(self);
2051 LOG(FATAL) << "Unexpected exception compiling: " << PrettyMethod(method_idx, dex_file) << "\n"
Andreas Gampe35439ba2014-08-28 14:41:02 -07002052 << self->GetException(nullptr)->Dump();
Brian Carlstrom7940e442013-07-12 13:46:57 -07002053 }
2054}
2055
2056CompiledClass* CompilerDriver::GetCompiledClass(ClassReference ref) const {
2057 MutexLock mu(Thread::Current(), compiled_classes_lock_);
2058 ClassTable::const_iterator it = compiled_classes_.find(ref);
2059 if (it == compiled_classes_.end()) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07002060 return nullptr;
Brian Carlstrom7940e442013-07-12 13:46:57 -07002061 }
Andreas Gampe35439ba2014-08-28 14:41:02 -07002062 CHECK(it->second != nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002063 return it->second;
2064}
2065
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07002066void CompilerDriver::RecordClassStatus(ClassReference ref, mirror::Class::Status status) {
2067 MutexLock mu(Thread::Current(), compiled_classes_lock_);
2068 auto it = compiled_classes_.find(ref);
2069 if (it == compiled_classes_.end() || it->second->GetStatus() != status) {
2070 // An entry doesn't exist or the status is lower than the new status.
2071 if (it != compiled_classes_.end()) {
2072 CHECK_GT(status, it->second->GetStatus());
2073 delete it->second;
2074 }
2075 switch (status) {
2076 case mirror::Class::kStatusNotReady:
2077 case mirror::Class::kStatusError:
2078 case mirror::Class::kStatusRetryVerificationAtRuntime:
2079 case mirror::Class::kStatusVerified:
2080 case mirror::Class::kStatusInitialized:
2081 break; // Expected states.
2082 default:
2083 LOG(FATAL) << "Unexpected class status for class "
2084 << PrettyDescriptor(ref.first->GetClassDescriptor(ref.first->GetClassDef(ref.second)))
2085 << " of " << status;
2086 }
2087 CompiledClass* compiled_class = new CompiledClass(status);
2088 compiled_classes_.Overwrite(ref, compiled_class);
2089 }
2090}
2091
Brian Carlstrom7940e442013-07-12 13:46:57 -07002092CompiledMethod* CompilerDriver::GetCompiledMethod(MethodReference ref) const {
2093 MutexLock mu(Thread::Current(), compiled_methods_lock_);
2094 MethodTable::const_iterator it = compiled_methods_.find(ref);
2095 if (it == compiled_methods_.end()) {
Andreas Gampe35439ba2014-08-28 14:41:02 -07002096 return nullptr;
Brian Carlstrom7940e442013-07-12 13:46:57 -07002097 }
Andreas Gampe35439ba2014-08-28 14:41:02 -07002098 CHECK(it->second != nullptr);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002099 return it->second;
2100}
2101
Brian Carlstrom7940e442013-07-12 13:46:57 -07002102void CompilerDriver::AddRequiresConstructorBarrier(Thread* self, const DexFile* dex_file,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07002103 uint16_t class_def_index) {
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07002104 WriterMutexLock mu(self, freezing_constructor_lock_);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002105 freezing_constructor_classes_.insert(ClassReference(dex_file, class_def_index));
2106}
2107
2108bool CompilerDriver::RequiresConstructorBarrier(Thread* self, const DexFile* dex_file,
Ian Rogers8b2c0b92013-09-19 02:56:49 -07002109 uint16_t class_def_index) {
Ian Rogers8f3c9ae2013-08-20 17:26:41 -07002110 ReaderMutexLock mu(self, freezing_constructor_lock_);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002111 return freezing_constructor_classes_.count(ClassReference(dex_file, class_def_index)) != 0;
2112}
2113
2114bool CompilerDriver::WriteElf(const std::string& android_root,
2115 bool is_host,
2116 const std::vector<const art::DexFile*>& dex_files,
Ian Rogers3d504072014-03-01 09:16:49 -08002117 OatWriter* oat_writer,
Brian Carlstrom7940e442013-07-12 13:46:57 -07002118 art::File* file)
2119 SHARED_LOCKS_REQUIRED(Locks::mutator_lock_) {
Ian Rogers72d32622014-05-06 16:20:11 -07002120 return compiler_->WriteElf(file, oat_writer, dex_files, android_root, is_host);
Brian Carlstrom7940e442013-07-12 13:46:57 -07002121}
2122void CompilerDriver::InstructionSetToLLVMTarget(InstructionSet instruction_set,
Ian Rogers3d504072014-03-01 09:16:49 -08002123 std::string* target_triple,
2124 std::string* target_cpu,
2125 std::string* target_attr) {
Brian Carlstrom7940e442013-07-12 13:46:57 -07002126 switch (instruction_set) {
2127 case kThumb2:
Ian Rogers3d504072014-03-01 09:16:49 -08002128 *target_triple = "thumb-none-linux-gnueabi";
2129 *target_cpu = "cortex-a9";
2130 *target_attr = "+thumb2,+neon,+neonfp,+vfp3,+db";
Brian Carlstrom7940e442013-07-12 13:46:57 -07002131 break;
2132
2133 case kArm:
Ian Rogers3d504072014-03-01 09:16:49 -08002134 *target_triple = "armv7-none-linux-gnueabi";
Brian Carlstrom7940e442013-07-12 13:46:57 -07002135 // TODO: Fix for Nexus S.
Ian Rogers3d504072014-03-01 09:16:49 -08002136 *target_cpu = "cortex-a9";
Brian Carlstrom7940e442013-07-12 13:46:57 -07002137 // TODO: Fix for Xoom.
Ian Rogers3d504072014-03-01 09:16:49 -08002138 *target_attr = "+v7,+neon,+neonfp,+vfp3,+db";
Brian Carlstrom7940e442013-07-12 13:46:57 -07002139 break;
2140
2141 case kX86:
Ian Rogers3d504072014-03-01 09:16:49 -08002142 *target_triple = "i386-pc-linux-gnu";
2143 *target_attr = "";
Brian Carlstrom7940e442013-07-12 13:46:57 -07002144 break;
2145
Dmitry Petrochenko6a58cb12014-04-02 17:27:59 +07002146 case kX86_64:
2147 *target_triple = "x86_64-pc-linux-gnu";
2148 *target_attr = "";
2149 break;
2150
Brian Carlstrom7940e442013-07-12 13:46:57 -07002151 case kMips:
Ian Rogers3d504072014-03-01 09:16:49 -08002152 *target_triple = "mipsel-unknown-linux";
2153 *target_attr = "mips32r2";
Brian Carlstrom7940e442013-07-12 13:46:57 -07002154 break;
2155
2156 default:
2157 LOG(FATAL) << "Unknown instruction set: " << instruction_set;
2158 }
2159 }
Dave Allison39c3bfb2014-01-28 18:33:52 -08002160
Dave Allison39c3bfb2014-01-28 18:33:52 -08002161bool CompilerDriver::SkipCompilation(const std::string& method_name) {
Calin Juravlec1b643c2014-05-30 23:44:11 +01002162 if (!profile_present_) {
Dave Allison644789f2014-04-10 13:06:10 -07002163 return false;
Dave Allison39c3bfb2014-01-28 18:33:52 -08002164 }
Calin Juravlebb0b53f2014-05-23 17:33:29 +01002165 // First find the method in the profile file.
2166 ProfileFile::ProfileData data;
2167 if (!profile_file_.GetProfileData(&data, method_name)) {
Dave Allison39c3bfb2014-01-28 18:33:52 -08002168 // Not in profile, no information can be determined.
Calin Juravle08f7a2d2014-06-23 15:22:29 +01002169 if (kIsDebugBuild) {
2170 VLOG(compiler) << "not compiling " << method_name << " because it's not in the profile";
2171 }
Dave Allison39c3bfb2014-01-28 18:33:52 -08002172 return true;
2173 }
Calin Juravlebb0b53f2014-05-23 17:33:29 +01002174
2175 // Methods that comprise top_k_threshold % of the total samples will be compiled.
Calin Juravlef6a4cee2014-04-02 17:03:08 +01002176 // Compare against the start of the topK percentage bucket just in case the threshold
Calin Juravle04ff2262014-04-02 19:08:47 +01002177 // falls inside a bucket.
Calin Juravlec1b643c2014-05-30 23:44:11 +01002178 bool compile = data.GetTopKUsedPercentage() - data.GetUsedPercent()
2179 <= compiler_options_->GetTopKProfileThreshold();
Calin Juravle08f7a2d2014-06-23 15:22:29 +01002180 if (kIsDebugBuild) {
2181 if (compile) {
2182 LOG(INFO) << "compiling method " << method_name << " because its usage is part of top "
2183 << data.GetTopKUsedPercentage() << "% with a percent of " << data.GetUsedPercent() << "%"
2184 << " (topKThreshold=" << compiler_options_->GetTopKProfileThreshold() << ")";
2185 } else {
2186 VLOG(compiler) << "not compiling method " << method_name
2187 << " because it's not part of leading " << compiler_options_->GetTopKProfileThreshold()
2188 << "% samples)";
2189 }
Dave Allison39c3bfb2014-01-28 18:33:52 -08002190 }
2191 return !compile;
2192}
Brian Carlstrom7940e442013-07-12 13:46:57 -07002193} // namespace art