Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 17 | #include "compiler_internals.h" |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 18 | #include "global_value_numbering.h" |
| 19 | #include "local_value_numbering.h" |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 20 | #include "gtest/gtest.h" |
| 21 | |
| 22 | namespace art { |
| 23 | |
| 24 | class LocalValueNumberingTest : public testing::Test { |
| 25 | protected: |
| 26 | struct IFieldDef { |
| 27 | uint16_t field_idx; |
| 28 | uintptr_t declaring_dex_file; |
| 29 | uint16_t declaring_field_idx; |
| 30 | bool is_volatile; |
| 31 | }; |
| 32 | |
| 33 | struct SFieldDef { |
| 34 | uint16_t field_idx; |
| 35 | uintptr_t declaring_dex_file; |
| 36 | uint16_t declaring_field_idx; |
| 37 | bool is_volatile; |
| 38 | }; |
| 39 | |
| 40 | struct MIRDef { |
| 41 | static constexpr size_t kMaxSsaDefs = 2; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 42 | static constexpr size_t kMaxSsaUses = 4; |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 43 | |
| 44 | Instruction::Code opcode; |
| 45 | int64_t value; |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 46 | uint32_t field_info; |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 47 | size_t num_uses; |
| 48 | int32_t uses[kMaxSsaUses]; |
| 49 | size_t num_defs; |
| 50 | int32_t defs[kMaxSsaDefs]; |
| 51 | }; |
| 52 | |
| 53 | #define DEF_CONST(opcode, reg, value) \ |
| 54 | { opcode, value, 0u, 0, { }, 1, { reg } } |
| 55 | #define DEF_CONST_WIDE(opcode, reg, value) \ |
| 56 | { opcode, value, 0u, 0, { }, 2, { reg, reg + 1 } } |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 57 | #define DEF_CONST_STRING(opcode, reg, index) \ |
| 58 | { opcode, index, 0u, 0, { }, 1, { reg } } |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 59 | #define DEF_IGET(opcode, reg, obj, field_info) \ |
| 60 | { opcode, 0u, field_info, 1, { obj }, 1, { reg } } |
| 61 | #define DEF_IGET_WIDE(opcode, reg, obj, field_info) \ |
| 62 | { opcode, 0u, field_info, 1, { obj }, 2, { reg, reg + 1 } } |
| 63 | #define DEF_IPUT(opcode, reg, obj, field_info) \ |
| 64 | { opcode, 0u, field_info, 2, { reg, obj }, 0, { } } |
| 65 | #define DEF_IPUT_WIDE(opcode, reg, obj, field_info) \ |
| 66 | { opcode, 0u, field_info, 3, { reg, reg + 1, obj }, 0, { } } |
| 67 | #define DEF_SGET(opcode, reg, field_info) \ |
| 68 | { opcode, 0u, field_info, 0, { }, 1, { reg } } |
| 69 | #define DEF_SGET_WIDE(opcode, reg, field_info) \ |
| 70 | { opcode, 0u, field_info, 0, { }, 2, { reg, reg + 1 } } |
| 71 | #define DEF_SPUT(opcode, reg, field_info) \ |
| 72 | { opcode, 0u, field_info, 1, { reg }, 0, { } } |
| 73 | #define DEF_SPUT_WIDE(opcode, reg, field_info) \ |
| 74 | { opcode, 0u, field_info, 2, { reg, reg + 1 }, 0, { } } |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 75 | #define DEF_AGET(opcode, reg, obj, idx) \ |
| 76 | { opcode, 0u, 0u, 2, { obj, idx }, 1, { reg } } |
| 77 | #define DEF_AGET_WIDE(opcode, reg, obj, idx) \ |
| 78 | { opcode, 0u, 0u, 2, { obj, idx }, 2, { reg, reg + 1 } } |
| 79 | #define DEF_APUT(opcode, reg, obj, idx) \ |
| 80 | { opcode, 0u, 0u, 3, { reg, obj, idx }, 0, { } } |
| 81 | #define DEF_APUT_WIDE(opcode, reg, obj, idx) \ |
| 82 | { opcode, 0u, 0u, 4, { reg, reg + 1, obj, idx }, 0, { } } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 83 | #define DEF_INVOKE1(opcode, reg) \ |
| 84 | { opcode, 0u, 0u, 1, { reg }, 0, { } } |
| 85 | #define DEF_UNIQUE_REF(opcode, reg) \ |
| 86 | { opcode, 0u, 0u, 0, { }, 1, { reg } } // CONST_CLASS, CONST_STRING, NEW_ARRAY, ... |
| 87 | |
| 88 | void DoPrepareIFields(const IFieldDef* defs, size_t count) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 89 | cu_.mir_graph->ifield_lowering_infos_.clear(); |
| 90 | cu_.mir_graph->ifield_lowering_infos_.reserve(count); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 91 | for (size_t i = 0u; i != count; ++i) { |
| 92 | const IFieldDef* def = &defs[i]; |
| 93 | MirIFieldLoweringInfo field_info(def->field_idx); |
| 94 | if (def->declaring_dex_file != 0u) { |
| 95 | field_info.declaring_dex_file_ = reinterpret_cast<const DexFile*>(def->declaring_dex_file); |
| 96 | field_info.declaring_field_idx_ = def->declaring_field_idx; |
| 97 | field_info.flags_ = 0u | // Without kFlagIsStatic. |
| 98 | (def->is_volatile ? MirIFieldLoweringInfo::kFlagIsVolatile : 0u); |
| 99 | } |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 100 | cu_.mir_graph->ifield_lowering_infos_.push_back(field_info); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 101 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 102 | } |
| 103 | |
| 104 | template <size_t count> |
| 105 | void PrepareIFields(const IFieldDef (&defs)[count]) { |
| 106 | DoPrepareIFields(defs, count); |
| 107 | } |
| 108 | |
| 109 | void DoPrepareSFields(const SFieldDef* defs, size_t count) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 110 | cu_.mir_graph->sfield_lowering_infos_.clear(); |
| 111 | cu_.mir_graph->sfield_lowering_infos_.reserve(count); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 112 | for (size_t i = 0u; i != count; ++i) { |
| 113 | const SFieldDef* def = &defs[i]; |
| 114 | MirSFieldLoweringInfo field_info(def->field_idx); |
Vladimir Marko | f418f32 | 2014-07-09 14:45:36 +0100 | [diff] [blame] | 115 | // Mark even unresolved fields as initialized. |
| 116 | field_info.flags_ = MirSFieldLoweringInfo::kFlagIsStatic | |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 117 | MirSFieldLoweringInfo::kFlagClassIsInitialized; |
| 118 | // NOTE: MirSFieldLoweringInfo::kFlagClassIsInDexCache isn't used by LVN. |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 119 | if (def->declaring_dex_file != 0u) { |
| 120 | field_info.declaring_dex_file_ = reinterpret_cast<const DexFile*>(def->declaring_dex_file); |
| 121 | field_info.declaring_field_idx_ = def->declaring_field_idx; |
Vladimir Marko | f418f32 | 2014-07-09 14:45:36 +0100 | [diff] [blame] | 122 | field_info.flags_ |= (def->is_volatile ? MirSFieldLoweringInfo::kFlagIsVolatile : 0u); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 123 | } |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 124 | cu_.mir_graph->sfield_lowering_infos_.push_back(field_info); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 125 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 126 | } |
| 127 | |
| 128 | template <size_t count> |
| 129 | void PrepareSFields(const SFieldDef (&defs)[count]) { |
| 130 | DoPrepareSFields(defs, count); |
| 131 | } |
| 132 | |
| 133 | void DoPrepareMIRs(const MIRDef* defs, size_t count) { |
| 134 | mir_count_ = count; |
Vladimir Marko | 83cc7ae | 2014-02-12 18:02:05 +0000 | [diff] [blame] | 135 | mirs_ = reinterpret_cast<MIR*>(cu_.arena.Alloc(sizeof(MIR) * count, kArenaAllocMIR)); |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 136 | ssa_reps_.resize(count); |
| 137 | for (size_t i = 0u; i != count; ++i) { |
| 138 | const MIRDef* def = &defs[i]; |
| 139 | MIR* mir = &mirs_[i]; |
| 140 | mir->dalvikInsn.opcode = def->opcode; |
| 141 | mir->dalvikInsn.vB = static_cast<int32_t>(def->value); |
| 142 | mir->dalvikInsn.vB_wide = def->value; |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 143 | if (def->opcode >= Instruction::IGET && def->opcode <= Instruction::IPUT_SHORT) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 144 | ASSERT_LT(def->field_info, cu_.mir_graph->ifield_lowering_infos_.size()); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 145 | mir->meta.ifield_lowering_info = def->field_info; |
| 146 | } else if (def->opcode >= Instruction::SGET && def->opcode <= Instruction::SPUT_SHORT) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 147 | ASSERT_LT(def->field_info, cu_.mir_graph->sfield_lowering_infos_.size()); |
Vladimir Marko | be0e546 | 2014-02-26 11:24:15 +0000 | [diff] [blame] | 148 | mir->meta.sfield_lowering_info = def->field_info; |
| 149 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 150 | mir->ssa_rep = &ssa_reps_[i]; |
| 151 | mir->ssa_rep->num_uses = def->num_uses; |
| 152 | mir->ssa_rep->uses = const_cast<int32_t*>(def->uses); // Not modified by LVN. |
| 153 | mir->ssa_rep->fp_use = nullptr; // Not used by LVN. |
| 154 | mir->ssa_rep->num_defs = def->num_defs; |
| 155 | mir->ssa_rep->defs = const_cast<int32_t*>(def->defs); // Not modified by LVN. |
| 156 | mir->ssa_rep->fp_def = nullptr; // Not used by LVN. |
| 157 | mir->dalvikInsn.opcode = def->opcode; |
| 158 | mir->offset = i; // LVN uses offset only for debug output |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 159 | mir->optimization_flags = 0u; |
| 160 | |
| 161 | if (i != 0u) { |
| 162 | mirs_[i - 1u].next = mir; |
| 163 | } |
| 164 | } |
| 165 | mirs_[count - 1u].next = nullptr; |
| 166 | } |
| 167 | |
| 168 | template <size_t count> |
| 169 | void PrepareMIRs(const MIRDef (&defs)[count]) { |
| 170 | DoPrepareMIRs(defs, count); |
| 171 | } |
| 172 | |
Vladimir Marko | f418f32 | 2014-07-09 14:45:36 +0100 | [diff] [blame] | 173 | void MakeSFieldUninitialized(uint32_t sfield_index) { |
Vladimir Marko | e39c54e | 2014-09-22 14:50:02 +0100 | [diff] [blame] | 174 | CHECK_LT(sfield_index, cu_.mir_graph->sfield_lowering_infos_.size()); |
| 175 | cu_.mir_graph->sfield_lowering_infos_[sfield_index].flags_ &= |
Vladimir Marko | 66c6d7b | 2014-10-16 15:41:48 +0100 | [diff] [blame] | 176 | ~MirSFieldLoweringInfo::kFlagClassIsInitialized; |
Vladimir Marko | f418f32 | 2014-07-09 14:45:36 +0100 | [diff] [blame] | 177 | } |
| 178 | |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 179 | void PerformLVN() { |
| 180 | value_names_.resize(mir_count_); |
| 181 | for (size_t i = 0; i != mir_count_; ++i) { |
Vladimir Marko | 83cc7ae | 2014-02-12 18:02:05 +0000 | [diff] [blame] | 182 | value_names_[i] = lvn_->GetValueNumber(&mirs_[i]); |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 183 | } |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 184 | EXPECT_TRUE(gvn_->Good()); |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 185 | } |
| 186 | |
Vladimir Marko | 83cc7ae | 2014-02-12 18:02:05 +0000 | [diff] [blame] | 187 | LocalValueNumberingTest() |
| 188 | : pool_(), |
| 189 | cu_(&pool_), |
| 190 | mir_count_(0u), |
| 191 | mirs_(nullptr), |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 192 | ssa_reps_(), |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 193 | allocator_(), |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 194 | gvn_(), |
| 195 | lvn_(), |
| 196 | value_names_() { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 197 | cu_.mir_graph.reset(new MIRGraph(&cu_, &cu_.arena)); |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 198 | allocator_.reset(ScopedArenaAllocator::Create(&cu_.arena_stack)); |
Vladimir Marko | 415ac88 | 2014-09-30 18:09:14 +0100 | [diff] [blame] | 199 | gvn_.reset(new (allocator_.get()) GlobalValueNumbering(&cu_, allocator_.get(), |
| 200 | GlobalValueNumbering::kModeLvn)); |
Vladimir Marko | b19955d | 2014-07-29 12:04:10 +0100 | [diff] [blame] | 201 | lvn_.reset(new (allocator_.get()) LocalValueNumbering(gvn_.get(), 0u, allocator_.get())); |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 202 | } |
| 203 | |
| 204 | ArenaPool pool_; |
| 205 | CompilationUnit cu_; |
| 206 | size_t mir_count_; |
| 207 | MIR* mirs_; |
| 208 | std::vector<SSARepresentation> ssa_reps_; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 209 | std::unique_ptr<ScopedArenaAllocator> allocator_; |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 210 | std::unique_ptr<GlobalValueNumbering> gvn_; |
Ian Rogers | 700a402 | 2014-05-19 16:49:03 -0700 | [diff] [blame] | 211 | std::unique_ptr<LocalValueNumbering> lvn_; |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 212 | std::vector<uint16_t> value_names_; |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 213 | }; |
| 214 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 215 | TEST_F(LocalValueNumberingTest, IGetIGetInvokeIGet) { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 216 | static const IFieldDef ifields[] = { |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 217 | { 1u, 1u, 1u, false }, |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 218 | }; |
| 219 | static const MIRDef mirs[] = { |
| 220 | DEF_IGET(Instruction::IGET, 0u, 10u, 0u), |
| 221 | DEF_IGET(Instruction::IGET, 1u, 10u, 0u), |
| 222 | DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 11u), |
| 223 | DEF_IGET(Instruction::IGET, 2u, 10u, 0u), |
| 224 | }; |
| 225 | |
| 226 | PrepareIFields(ifields); |
| 227 | PrepareMIRs(mirs); |
| 228 | PerformLVN(); |
| 229 | ASSERT_EQ(value_names_.size(), 4u); |
| 230 | EXPECT_EQ(value_names_[0], value_names_[1]); |
| 231 | EXPECT_NE(value_names_[0], value_names_[3]); |
| 232 | EXPECT_EQ(mirs_[0].optimization_flags, 0u); |
| 233 | EXPECT_EQ(mirs_[1].optimization_flags, MIR_IGNORE_NULL_CHECK); |
| 234 | EXPECT_EQ(mirs_[2].optimization_flags, 0u); |
| 235 | EXPECT_EQ(mirs_[3].optimization_flags, MIR_IGNORE_NULL_CHECK); |
| 236 | } |
| 237 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 238 | TEST_F(LocalValueNumberingTest, IGetIPutIGetIGetIGet) { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 239 | static const IFieldDef ifields[] = { |
| 240 | { 1u, 1u, 1u, false }, |
| 241 | { 2u, 1u, 2u, false }, |
| 242 | }; |
| 243 | static const MIRDef mirs[] = { |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 244 | DEF_IGET(Instruction::IGET_OBJECT, 0u, 10u, 0u), |
| 245 | DEF_IPUT(Instruction::IPUT_OBJECT, 1u, 11u, 0u), // May alias. |
| 246 | DEF_IGET(Instruction::IGET_OBJECT, 2u, 10u, 0u), |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 247 | DEF_IGET(Instruction::IGET, 3u, 0u, 1u), |
| 248 | DEF_IGET(Instruction::IGET, 4u, 2u, 1u), |
| 249 | }; |
| 250 | |
| 251 | PrepareIFields(ifields); |
| 252 | PrepareMIRs(mirs); |
| 253 | PerformLVN(); |
| 254 | ASSERT_EQ(value_names_.size(), 5u); |
| 255 | EXPECT_NE(value_names_[0], value_names_[2]); |
| 256 | EXPECT_NE(value_names_[3], value_names_[4]); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 257 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
| 258 | EXPECT_EQ((i == 2u) ? MIR_IGNORE_NULL_CHECK : 0, |
| 259 | mirs_[i].optimization_flags) << i; |
| 260 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 261 | } |
| 262 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 263 | TEST_F(LocalValueNumberingTest, UniquePreserve1) { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 264 | static const IFieldDef ifields[] = { |
| 265 | { 1u, 1u, 1u, false }, |
| 266 | }; |
| 267 | static const MIRDef mirs[] = { |
| 268 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 10u), |
| 269 | DEF_IGET(Instruction::IGET, 0u, 10u, 0u), |
| 270 | DEF_IPUT(Instruction::IPUT, 1u, 11u, 0u), // No aliasing since 10u is unique. |
| 271 | DEF_IGET(Instruction::IGET, 2u, 10u, 0u), |
| 272 | }; |
| 273 | |
| 274 | PrepareIFields(ifields); |
| 275 | PrepareMIRs(mirs); |
| 276 | PerformLVN(); |
| 277 | ASSERT_EQ(value_names_.size(), 4u); |
| 278 | EXPECT_EQ(value_names_[1], value_names_[3]); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 279 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
| 280 | EXPECT_EQ((i == 1u || i == 3u) ? MIR_IGNORE_NULL_CHECK : 0, |
| 281 | mirs_[i].optimization_flags) << i; |
| 282 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 283 | } |
| 284 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 285 | TEST_F(LocalValueNumberingTest, UniquePreserve2) { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 286 | static const IFieldDef ifields[] = { |
| 287 | { 1u, 1u, 1u, false }, |
| 288 | }; |
| 289 | static const MIRDef mirs[] = { |
| 290 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 11u), |
| 291 | DEF_IGET(Instruction::IGET, 0u, 10u, 0u), |
| 292 | DEF_IPUT(Instruction::IPUT, 1u, 11u, 0u), // No aliasing since 11u is unique. |
| 293 | DEF_IGET(Instruction::IGET, 2u, 10u, 0u), |
| 294 | }; |
| 295 | |
| 296 | PrepareIFields(ifields); |
| 297 | PrepareMIRs(mirs); |
| 298 | PerformLVN(); |
| 299 | ASSERT_EQ(value_names_.size(), 4u); |
| 300 | EXPECT_EQ(value_names_[1], value_names_[3]); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 301 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
| 302 | EXPECT_EQ((i == 2u || i == 3u) ? MIR_IGNORE_NULL_CHECK : 0, |
| 303 | mirs_[i].optimization_flags) << i; |
| 304 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 305 | } |
| 306 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 307 | TEST_F(LocalValueNumberingTest, UniquePreserveAndEscape) { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 308 | static const IFieldDef ifields[] = { |
| 309 | { 1u, 1u, 1u, false }, |
| 310 | }; |
| 311 | static const MIRDef mirs[] = { |
| 312 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 10u), |
| 313 | DEF_IGET(Instruction::IGET, 0u, 10u, 0u), |
| 314 | DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 11u), // 10u still unique. |
| 315 | DEF_IGET(Instruction::IGET, 2u, 10u, 0u), |
| 316 | DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 10u), // 10u not unique anymore. |
| 317 | DEF_IGET(Instruction::IGET, 3u, 10u, 0u), |
| 318 | }; |
| 319 | |
| 320 | PrepareIFields(ifields); |
| 321 | PrepareMIRs(mirs); |
| 322 | PerformLVN(); |
| 323 | ASSERT_EQ(value_names_.size(), 6u); |
| 324 | EXPECT_EQ(value_names_[1], value_names_[3]); |
| 325 | EXPECT_NE(value_names_[1], value_names_[5]); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 326 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
| 327 | EXPECT_EQ((i == 1u || i == 3u || i == 4u || i == 5u) ? MIR_IGNORE_NULL_CHECK : 0, |
| 328 | mirs_[i].optimization_flags) << i; |
| 329 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 330 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 331 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 332 | TEST_F(LocalValueNumberingTest, Volatile) { |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 333 | static const IFieldDef ifields[] = { |
| 334 | { 1u, 1u, 1u, false }, |
| 335 | { 2u, 1u, 2u, true }, |
| 336 | }; |
| 337 | static const MIRDef mirs[] = { |
| 338 | DEF_IGET(Instruction::IGET, 0u, 10u, 1u), // Volatile. |
| 339 | DEF_IGET(Instruction::IGET, 1u, 0u, 0u), // Non-volatile. |
| 340 | DEF_IGET(Instruction::IGET, 2u, 10u, 1u), // Volatile. |
| 341 | DEF_IGET(Instruction::IGET, 3u, 2u, 1u), // Non-volatile. |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 342 | DEF_IGET(Instruction::IGET, 4u, 0u, 0u), // Non-volatile. |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 343 | }; |
| 344 | |
| 345 | PrepareIFields(ifields); |
| 346 | PrepareMIRs(mirs); |
| 347 | PerformLVN(); |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 348 | ASSERT_EQ(value_names_.size(), 5u); |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 349 | EXPECT_NE(value_names_[0], value_names_[2]); // Volatile has always different value name. |
| 350 | EXPECT_NE(value_names_[1], value_names_[3]); // Used different base because of volatile. |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 351 | EXPECT_NE(value_names_[1], value_names_[4]); // Not guaranteed to be the same after "acquire". |
| 352 | |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 353 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 354 | EXPECT_EQ((i == 2u || i == 4u) ? MIR_IGNORE_NULL_CHECK : 0, |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 355 | mirs_[i].optimization_flags) << i; |
| 356 | } |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 357 | } |
| 358 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 359 | TEST_F(LocalValueNumberingTest, UnresolvedIField) { |
| 360 | static const IFieldDef ifields[] = { |
| 361 | { 1u, 1u, 1u, false }, // Resolved field #1. |
| 362 | { 2u, 1u, 2u, false }, // Resolved field #2. |
| 363 | { 3u, 0u, 0u, false }, // Unresolved field. |
| 364 | }; |
| 365 | static const MIRDef mirs[] = { |
| 366 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 20u), |
| 367 | DEF_IGET(Instruction::IGET, 1u, 20u, 0u), // Resolved field #1, unique object. |
| 368 | DEF_IGET(Instruction::IGET, 2u, 21u, 0u), // Resolved field #1. |
| 369 | DEF_IGET_WIDE(Instruction::IGET_WIDE, 3u, 21u, 1u), // Resolved field #2. |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 370 | DEF_IGET(Instruction::IGET, 4u, 22u, 2u), // Unresolved IGET can be "acquire". |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 371 | DEF_IGET(Instruction::IGET, 5u, 20u, 0u), // Resolved field #1, unique object. |
| 372 | DEF_IGET(Instruction::IGET, 6u, 21u, 0u), // Resolved field #1. |
| 373 | DEF_IGET_WIDE(Instruction::IGET_WIDE, 7u, 21u, 1u), // Resolved field #2. |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 374 | DEF_IPUT(Instruction::IPUT, 8u, 22u, 2u), // IPUT clobbers field #1 (#2 is wide). |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 375 | DEF_IGET(Instruction::IGET, 9u, 20u, 0u), // Resolved field #1, unique object. |
| 376 | DEF_IGET(Instruction::IGET, 10u, 21u, 0u), // Resolved field #1, new value name. |
| 377 | DEF_IGET_WIDE(Instruction::IGET_WIDE, 11u, 21u, 1u), // Resolved field #2. |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 378 | DEF_IGET_WIDE(Instruction::IGET_WIDE, 12u, 20u, 1u), // Resolved field #2, unique object. |
| 379 | DEF_IPUT(Instruction::IPUT, 13u, 20u, 2u), // IPUT clobbers field #1 (#2 is wide). |
| 380 | DEF_IGET(Instruction::IGET, 14u, 20u, 0u), // Resolved field #1, unique object. |
| 381 | DEF_IGET_WIDE(Instruction::IGET_WIDE, 15u, 20u, 1u), // Resolved field #2, unique object. |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 382 | }; |
| 383 | |
| 384 | PrepareIFields(ifields); |
| 385 | PrepareMIRs(mirs); |
| 386 | PerformLVN(); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 387 | ASSERT_EQ(value_names_.size(), 16u); |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 388 | // Unresolved field is potentially volatile, so we need to adhere to the volatile semantics. |
| 389 | EXPECT_EQ(value_names_[1], value_names_[5]); // Unique object. |
| 390 | EXPECT_NE(value_names_[2], value_names_[6]); // Not guaranteed to be the same after "acquire". |
| 391 | EXPECT_NE(value_names_[3], value_names_[7]); // Not guaranteed to be the same after "acquire". |
| 392 | EXPECT_EQ(value_names_[1], value_names_[9]); // Unique object. |
| 393 | EXPECT_NE(value_names_[6], value_names_[10]); // This aliased with unresolved IPUT. |
| 394 | EXPECT_EQ(value_names_[7], value_names_[11]); // Still the same after "release". |
| 395 | EXPECT_EQ(value_names_[12], value_names_[15]); // Still the same after "release". |
| 396 | EXPECT_NE(value_names_[1], value_names_[14]); // This aliased with unresolved IPUT. |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 397 | EXPECT_EQ(mirs_[0].optimization_flags, 0u); |
| 398 | EXPECT_EQ(mirs_[1].optimization_flags, MIR_IGNORE_NULL_CHECK); |
| 399 | EXPECT_EQ(mirs_[2].optimization_flags, 0u); |
| 400 | EXPECT_EQ(mirs_[3].optimization_flags, MIR_IGNORE_NULL_CHECK); |
| 401 | EXPECT_EQ(mirs_[4].optimization_flags, 0u); |
| 402 | for (size_t i = 5u; i != mir_count_; ++i) { |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 403 | EXPECT_EQ((i == 1u || i == 3u || i >=5u) ? MIR_IGNORE_NULL_CHECK : 0, |
| 404 | mirs_[i].optimization_flags) << i; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 405 | } |
| 406 | } |
| 407 | |
| 408 | TEST_F(LocalValueNumberingTest, UnresolvedSField) { |
| 409 | static const SFieldDef sfields[] = { |
| 410 | { 1u, 1u, 1u, false }, // Resolved field #1. |
| 411 | { 2u, 1u, 2u, false }, // Resolved field #2. |
| 412 | { 3u, 0u, 0u, false }, // Unresolved field. |
| 413 | }; |
| 414 | static const MIRDef mirs[] = { |
| 415 | DEF_SGET(Instruction::SGET, 0u, 0u), // Resolved field #1. |
| 416 | DEF_SGET_WIDE(Instruction::SGET_WIDE, 1u, 1u), // Resolved field #2. |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 417 | DEF_SGET(Instruction::SGET, 2u, 2u), // Unresolved SGET can be "acquire". |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 418 | DEF_SGET(Instruction::SGET, 3u, 0u), // Resolved field #1. |
| 419 | DEF_SGET_WIDE(Instruction::SGET_WIDE, 4u, 1u), // Resolved field #2. |
| 420 | DEF_SPUT(Instruction::SPUT, 5u, 2u), // SPUT clobbers field #1 (#2 is wide). |
| 421 | DEF_SGET(Instruction::SGET, 6u, 0u), // Resolved field #1. |
| 422 | DEF_SGET_WIDE(Instruction::SGET_WIDE, 7u, 1u), // Resolved field #2. |
| 423 | }; |
| 424 | |
| 425 | PrepareSFields(sfields); |
| 426 | PrepareMIRs(mirs); |
| 427 | PerformLVN(); |
| 428 | ASSERT_EQ(value_names_.size(), 8u); |
Vladimir Marko | fa23645 | 2014-09-29 17:58:10 +0100 | [diff] [blame] | 429 | // Unresolved field is potentially volatile, so we need to adhere to the volatile semantics. |
| 430 | EXPECT_NE(value_names_[0], value_names_[3]); // Not guaranteed to be the same after "acquire". |
| 431 | EXPECT_NE(value_names_[1], value_names_[4]); // Not guaranteed to be the same after "acquire". |
| 432 | EXPECT_NE(value_names_[3], value_names_[6]); // This aliased with unresolved IPUT. |
| 433 | EXPECT_EQ(value_names_[4], value_names_[7]); // Still the same after "release". |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 434 | for (size_t i = 0u; i != mir_count_; ++i) { |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 435 | EXPECT_EQ(0, mirs_[i].optimization_flags) << i; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 436 | } |
| 437 | } |
| 438 | |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 439 | TEST_F(LocalValueNumberingTest, UninitializedSField) { |
| 440 | static const IFieldDef ifields[] = { |
| 441 | { 1u, 1u, 1u, false }, // Resolved field #1. |
| 442 | }; |
| 443 | static const SFieldDef sfields[] = { |
| 444 | { 1u, 1u, 1u, false }, // Resolved field #1. |
| 445 | { 2u, 1u, 2u, false }, // Resolved field #2; uninitialized. |
| 446 | }; |
| 447 | static const MIRDef mirs[] = { |
| 448 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 200u), |
| 449 | DEF_IGET(Instruction::IGET, 1u, 100u, 0u), |
| 450 | DEF_IGET(Instruction::IGET, 2u, 200u, 0u), |
| 451 | DEF_SGET(Instruction::SGET, 3u, 0u), |
| 452 | DEF_SGET(Instruction::SGET, 4u, 1u), // Can call <clinit>(). |
| 453 | DEF_IGET(Instruction::IGET, 5u, 100u, 0u), // Differs from 1u. |
| 454 | DEF_IGET(Instruction::IGET, 6u, 200u, 0u), // Same as 2u. |
| 455 | DEF_SGET(Instruction::SGET, 7u, 0u), // Differs from 3u. |
| 456 | }; |
| 457 | |
| 458 | PrepareIFields(ifields); |
| 459 | PrepareSFields(sfields); |
| 460 | MakeSFieldUninitialized(1u); |
| 461 | PrepareMIRs(mirs); |
| 462 | PerformLVN(); |
| 463 | ASSERT_EQ(value_names_.size(), 8u); |
| 464 | EXPECT_NE(value_names_[1], value_names_[5]); |
| 465 | EXPECT_EQ(value_names_[2], value_names_[6]); |
| 466 | EXPECT_NE(value_names_[3], value_names_[7]); |
| 467 | } |
| 468 | |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 469 | TEST_F(LocalValueNumberingTest, ConstString) { |
| 470 | static const MIRDef mirs[] = { |
| 471 | DEF_CONST_STRING(Instruction::CONST_STRING, 0u, 0u), |
| 472 | DEF_CONST_STRING(Instruction::CONST_STRING, 1u, 0u), |
| 473 | DEF_CONST_STRING(Instruction::CONST_STRING, 2u, 2u), |
| 474 | DEF_CONST_STRING(Instruction::CONST_STRING, 3u, 0u), |
| 475 | DEF_INVOKE1(Instruction::INVOKE_DIRECT, 2u), |
| 476 | DEF_CONST_STRING(Instruction::CONST_STRING, 4u, 2u), |
| 477 | }; |
| 478 | |
| 479 | PrepareMIRs(mirs); |
| 480 | PerformLVN(); |
| 481 | ASSERT_EQ(value_names_.size(), 6u); |
| 482 | EXPECT_EQ(value_names_[1], value_names_[0]); |
| 483 | EXPECT_NE(value_names_[2], value_names_[0]); |
| 484 | EXPECT_EQ(value_names_[3], value_names_[0]); |
| 485 | EXPECT_EQ(value_names_[5], value_names_[2]); |
| 486 | } |
| 487 | |
| 488 | TEST_F(LocalValueNumberingTest, SameValueInDifferentMemoryLocations) { |
| 489 | static const IFieldDef ifields[] = { |
| 490 | { 1u, 1u, 1u, false }, |
| 491 | { 2u, 1u, 2u, false }, |
| 492 | }; |
| 493 | static const SFieldDef sfields[] = { |
| 494 | { 3u, 1u, 3u, false }, |
| 495 | }; |
| 496 | static const MIRDef mirs[] = { |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 497 | DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 201u), |
| 498 | DEF_IGET(Instruction::IGET, 0u, 100u, 0u), |
| 499 | DEF_IPUT(Instruction::IPUT, 0u, 100u, 1u), |
| 500 | DEF_IPUT(Instruction::IPUT, 0u, 101u, 1u), |
| 501 | DEF_APUT(Instruction::APUT, 0u, 200u, 300u), |
| 502 | DEF_APUT(Instruction::APUT, 0u, 200u, 301u), |
| 503 | DEF_APUT(Instruction::APUT, 0u, 201u, 300u), |
| 504 | DEF_APUT(Instruction::APUT, 0u, 201u, 301u), |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 505 | DEF_SPUT(Instruction::SPUT, 0u, 0u), |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 506 | DEF_IGET(Instruction::IGET, 9u, 100u, 0u), |
| 507 | DEF_IGET(Instruction::IGET, 10u, 100u, 1u), |
| 508 | DEF_IGET(Instruction::IGET, 11u, 101u, 1u), |
| 509 | DEF_AGET(Instruction::AGET, 12u, 200u, 300u), |
| 510 | DEF_AGET(Instruction::AGET, 13u, 200u, 301u), |
| 511 | DEF_AGET(Instruction::AGET, 14u, 201u, 300u), |
| 512 | DEF_AGET(Instruction::AGET, 15u, 201u, 301u), |
| 513 | DEF_SGET(Instruction::SGET, 16u, 0u), |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 514 | }; |
| 515 | |
| 516 | PrepareIFields(ifields); |
| 517 | PrepareSFields(sfields); |
| 518 | PrepareMIRs(mirs); |
| 519 | PerformLVN(); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 520 | ASSERT_EQ(value_names_.size(), 17u); |
| 521 | for (size_t i = 9; i != arraysize(mirs); ++i) { |
| 522 | EXPECT_EQ(value_names_[1], value_names_[i]) << i; |
| 523 | } |
| 524 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
| 525 | int expected_flags = |
| 526 | ((i == 2u || (i >= 5u && i <= 7u) || (i >= 9u && i <= 15u)) ? MIR_IGNORE_NULL_CHECK : 0) | |
| 527 | ((i >= 12u && i <= 15u) ? MIR_IGNORE_RANGE_CHECK : 0); |
| 528 | EXPECT_EQ(expected_flags, mirs_[i].optimization_flags) << i; |
| 529 | } |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 530 | } |
| 531 | |
| 532 | TEST_F(LocalValueNumberingTest, UniqueArrayAliasing) { |
| 533 | static const MIRDef mirs[] = { |
| 534 | DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 20u), |
| 535 | DEF_AGET(Instruction::AGET, 1u, 20u, 40u), |
| 536 | DEF_APUT(Instruction::APUT, 2u, 20u, 41u), // May alias with index for sreg 40u. |
| 537 | DEF_AGET(Instruction::AGET, 3u, 20u, 40u), |
| 538 | }; |
| 539 | |
| 540 | PrepareMIRs(mirs); |
| 541 | PerformLVN(); |
| 542 | ASSERT_EQ(value_names_.size(), 4u); |
| 543 | EXPECT_NE(value_names_[1], value_names_[3]); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 544 | for (size_t i = 0; i != arraysize(mirs); ++i) { |
| 545 | int expected_flags = |
| 546 | ((i >= 1u) ? MIR_IGNORE_NULL_CHECK : 0) | |
| 547 | ((i == 3u) ? MIR_IGNORE_RANGE_CHECK : 0); |
| 548 | EXPECT_EQ(expected_flags, mirs_[i].optimization_flags) << i; |
| 549 | } |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 550 | } |
| 551 | |
| 552 | TEST_F(LocalValueNumberingTest, EscapingRefs) { |
| 553 | static const IFieldDef ifields[] = { |
| 554 | { 1u, 1u, 1u, false }, // Field #1. |
| 555 | { 2u, 1u, 2u, false }, // Field #2. |
| 556 | { 3u, 1u, 3u, false }, // Reference field for storing escaping refs. |
| 557 | { 4u, 1u, 4u, false }, // Wide. |
| 558 | { 5u, 0u, 0u, false }, // Unresolved field, int. |
| 559 | { 6u, 0u, 0u, false }, // Unresolved field, wide. |
| 560 | }; |
| 561 | static const MIRDef mirs[] = { |
| 562 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 20u), |
| 563 | DEF_IGET(Instruction::IGET, 1u, 20u, 0u), |
| 564 | DEF_IGET(Instruction::IGET, 2u, 20u, 1u), |
| 565 | DEF_IPUT(Instruction::IPUT_OBJECT, 20u, 30u, 2u), // Ref escapes. |
| 566 | DEF_IGET(Instruction::IGET, 4u, 20u, 0u), |
| 567 | DEF_IGET(Instruction::IGET, 5u, 20u, 1u), |
| 568 | DEF_IPUT(Instruction::IPUT, 6u, 31u, 0u), // May alias with field #1. |
| 569 | DEF_IGET(Instruction::IGET, 7u, 20u, 0u), // New value. |
| 570 | DEF_IGET(Instruction::IGET, 8u, 20u, 1u), // Still the same. |
| 571 | DEF_IPUT_WIDE(Instruction::IPUT_WIDE, 9u, 31u, 3u), // No aliasing, different type. |
| 572 | DEF_IGET(Instruction::IGET, 10u, 20u, 0u), |
| 573 | DEF_IGET(Instruction::IGET, 11u, 20u, 1u), |
| 574 | DEF_IPUT_WIDE(Instruction::IPUT_WIDE, 12u, 31u, 5u), // No aliasing, different type. |
| 575 | DEF_IGET(Instruction::IGET, 13u, 20u, 0u), |
| 576 | DEF_IGET(Instruction::IGET, 14u, 20u, 1u), |
| 577 | DEF_IPUT(Instruction::IPUT, 15u, 31u, 4u), // Aliasing, same type. |
| 578 | DEF_IGET(Instruction::IGET, 16u, 20u, 0u), |
| 579 | DEF_IGET(Instruction::IGET, 17u, 20u, 1u), |
| 580 | }; |
| 581 | |
| 582 | PrepareIFields(ifields); |
| 583 | PrepareMIRs(mirs); |
| 584 | PerformLVN(); |
| 585 | ASSERT_EQ(value_names_.size(), 18u); |
| 586 | EXPECT_EQ(value_names_[1], value_names_[4]); |
| 587 | EXPECT_EQ(value_names_[2], value_names_[5]); |
| 588 | EXPECT_NE(value_names_[4], value_names_[7]); // New value. |
| 589 | EXPECT_EQ(value_names_[5], value_names_[8]); |
| 590 | EXPECT_EQ(value_names_[7], value_names_[10]); |
| 591 | EXPECT_EQ(value_names_[8], value_names_[11]); |
| 592 | EXPECT_EQ(value_names_[10], value_names_[13]); |
| 593 | EXPECT_EQ(value_names_[11], value_names_[14]); |
| 594 | EXPECT_NE(value_names_[13], value_names_[16]); // New value. |
| 595 | EXPECT_NE(value_names_[14], value_names_[17]); // New value. |
| 596 | for (size_t i = 0u; i != mir_count_; ++i) { |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 597 | int expected = (i != 0u && i != 3u && i != 6u) ? MIR_IGNORE_NULL_CHECK : 0; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 598 | EXPECT_EQ(expected, mirs_[i].optimization_flags) << i; |
| 599 | } |
| 600 | } |
| 601 | |
| 602 | TEST_F(LocalValueNumberingTest, EscapingArrayRefs) { |
| 603 | static const MIRDef mirs[] = { |
| 604 | DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 20u), |
| 605 | DEF_AGET(Instruction::AGET, 1u, 20u, 40u), |
| 606 | DEF_AGET(Instruction::AGET, 2u, 20u, 41u), |
| 607 | DEF_APUT(Instruction::APUT_OBJECT, 20u, 30u, 42u), // Array ref escapes. |
| 608 | DEF_AGET(Instruction::AGET, 4u, 20u, 40u), |
| 609 | DEF_AGET(Instruction::AGET, 5u, 20u, 41u), |
| 610 | DEF_APUT_WIDE(Instruction::APUT_WIDE, 6u, 31u, 43u), // No aliasing, different type. |
| 611 | DEF_AGET(Instruction::AGET, 7u, 20u, 40u), |
| 612 | DEF_AGET(Instruction::AGET, 8u, 20u, 41u), |
| 613 | DEF_APUT(Instruction::APUT, 9u, 32u, 40u), // May alias with all elements. |
| 614 | DEF_AGET(Instruction::AGET, 10u, 20u, 40u), // New value (same index name). |
| 615 | DEF_AGET(Instruction::AGET, 11u, 20u, 41u), // New value (different index name). |
| 616 | }; |
| 617 | |
| 618 | PrepareMIRs(mirs); |
| 619 | PerformLVN(); |
| 620 | ASSERT_EQ(value_names_.size(), 12u); |
| 621 | EXPECT_EQ(value_names_[1], value_names_[4]); |
| 622 | EXPECT_EQ(value_names_[2], value_names_[5]); |
| 623 | EXPECT_EQ(value_names_[4], value_names_[7]); |
| 624 | EXPECT_EQ(value_names_[5], value_names_[8]); |
| 625 | EXPECT_NE(value_names_[7], value_names_[10]); // New value. |
| 626 | EXPECT_NE(value_names_[8], value_names_[11]); // New value. |
| 627 | for (size_t i = 0u; i != mir_count_; ++i) { |
| 628 | int expected = |
| 629 | ((i != 0u && i != 3u && i != 6u && i != 9u) ? MIR_IGNORE_NULL_CHECK : 0u) | |
| 630 | ((i >= 4 && i != 6u && i != 9u) ? MIR_IGNORE_RANGE_CHECK : 0u); |
| 631 | EXPECT_EQ(expected, mirs_[i].optimization_flags) << i; |
| 632 | } |
| 633 | } |
| 634 | |
| 635 | TEST_F(LocalValueNumberingTest, StoringSameValueKeepsMemoryVersion) { |
| 636 | static const IFieldDef ifields[] = { |
| 637 | { 1u, 1u, 1u, false }, |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 638 | { 2u, 1u, 2u, false }, |
| 639 | }; |
| 640 | static const SFieldDef sfields[] = { |
| 641 | { 2u, 1u, 2u, false }, |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 642 | }; |
| 643 | static const MIRDef mirs[] = { |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 644 | DEF_IGET(Instruction::IGET, 0u, 30u, 0u), |
| 645 | DEF_IGET(Instruction::IGET, 1u, 31u, 0u), |
| 646 | DEF_IPUT(Instruction::IPUT, 1u, 31u, 0u), // Store the same value. |
| 647 | DEF_IGET(Instruction::IGET, 3u, 30u, 0u), |
| 648 | DEF_AGET(Instruction::AGET, 4u, 32u, 40u), |
| 649 | DEF_AGET(Instruction::AGET, 5u, 33u, 40u), |
| 650 | DEF_APUT(Instruction::APUT, 5u, 33u, 40u), // Store the same value. |
| 651 | DEF_AGET(Instruction::AGET, 7u, 32u, 40u), |
| 652 | DEF_SGET(Instruction::SGET, 8u, 0u), |
| 653 | DEF_SPUT(Instruction::SPUT, 8u, 0u), // Store the same value. |
| 654 | DEF_SGET(Instruction::SGET, 10u, 0u), |
| 655 | DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 50u), // Test with unique references. |
| 656 | { Instruction::FILLED_NEW_ARRAY, 0, 0u, 2, { 12u, 13u }, 0, { } }, |
| 657 | DEF_UNIQUE_REF(Instruction::MOVE_RESULT_OBJECT, 51u), |
| 658 | DEF_IGET(Instruction::IGET, 14u, 50u, 0u), |
| 659 | DEF_IGET(Instruction::IGET, 15u, 50u, 1u), |
| 660 | DEF_IPUT(Instruction::IPUT, 15u, 50u, 1u), // Store the same value. |
| 661 | DEF_IGET(Instruction::IGET, 17u, 50u, 0u), |
| 662 | DEF_AGET(Instruction::AGET, 18u, 51u, 40u), |
| 663 | DEF_AGET(Instruction::AGET, 19u, 51u, 41u), |
| 664 | DEF_APUT(Instruction::APUT, 19u, 51u, 41u), // Store the same value. |
| 665 | DEF_AGET(Instruction::AGET, 21u, 51u, 40u), |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 666 | }; |
| 667 | |
| 668 | PrepareIFields(ifields); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 669 | PrepareSFields(sfields); |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 670 | PrepareMIRs(mirs); |
| 671 | PerformLVN(); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 672 | ASSERT_EQ(value_names_.size(), 22u); |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 673 | EXPECT_NE(value_names_[0], value_names_[1]); |
| 674 | EXPECT_EQ(value_names_[0], value_names_[3]); |
| 675 | EXPECT_NE(value_names_[4], value_names_[5]); |
| 676 | EXPECT_EQ(value_names_[4], value_names_[7]); |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 677 | EXPECT_EQ(value_names_[8], value_names_[10]); |
| 678 | EXPECT_NE(value_names_[14], value_names_[15]); |
| 679 | EXPECT_EQ(value_names_[14], value_names_[17]); |
| 680 | EXPECT_NE(value_names_[18], value_names_[19]); |
| 681 | EXPECT_EQ(value_names_[18], value_names_[21]); |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 682 | for (size_t i = 0u; i != mir_count_; ++i) { |
| 683 | int expected = |
Vladimir Marko | 95a0597 | 2014-05-30 10:01:32 +0100 | [diff] [blame] | 684 | ((i == 2u || i == 3u || i == 6u || i == 7u || (i >= 14u)) ? MIR_IGNORE_NULL_CHECK : 0u) | |
| 685 | ((i == 6u || i == 7u || i >= 20u) ? MIR_IGNORE_RANGE_CHECK : 0u); |
| 686 | EXPECT_EQ(expected, mirs_[i].optimization_flags) << i; |
| 687 | } |
| 688 | } |
| 689 | |
| 690 | TEST_F(LocalValueNumberingTest, FilledNewArrayTracking) { |
| 691 | if (!kLocalValueNumberingEnableFilledNewArrayTracking) { |
| 692 | // Feature disabled. |
| 693 | return; |
| 694 | } |
| 695 | static const MIRDef mirs[] = { |
| 696 | DEF_CONST(Instruction::CONST, 0u, 100), |
| 697 | DEF_CONST(Instruction::CONST, 1u, 200), |
| 698 | { Instruction::FILLED_NEW_ARRAY, 0, 0u, 2, { 0u, 1u }, 0, { } }, |
| 699 | DEF_UNIQUE_REF(Instruction::MOVE_RESULT_OBJECT, 10u), |
| 700 | DEF_CONST(Instruction::CONST, 20u, 0), |
| 701 | DEF_CONST(Instruction::CONST, 21u, 1), |
| 702 | DEF_AGET(Instruction::AGET, 6u, 10u, 20u), |
| 703 | DEF_AGET(Instruction::AGET, 7u, 10u, 21u), |
| 704 | }; |
| 705 | |
| 706 | PrepareMIRs(mirs); |
| 707 | PerformLVN(); |
| 708 | ASSERT_EQ(value_names_.size(), 8u); |
| 709 | EXPECT_EQ(value_names_[0], value_names_[6]); |
| 710 | EXPECT_EQ(value_names_[1], value_names_[7]); |
| 711 | for (size_t i = 0u; i != mir_count_; ++i) { |
| 712 | int expected = (i == 6u || i == 7u) ? (MIR_IGNORE_NULL_CHECK | MIR_IGNORE_RANGE_CHECK) : 0u; |
Vladimir Marko | 2ac01fc | 2014-05-22 12:09:08 +0100 | [diff] [blame] | 713 | EXPECT_EQ(expected, mirs_[i].optimization_flags) << i; |
| 714 | } |
| 715 | } |
| 716 | |
Vladimir Marko | f418f32 | 2014-07-09 14:45:36 +0100 | [diff] [blame] | 717 | TEST_F(LocalValueNumberingTest, ClInitOnSget) { |
| 718 | static const SFieldDef sfields[] = { |
| 719 | { 0u, 1u, 0u, false }, |
| 720 | { 1u, 2u, 1u, false }, |
| 721 | }; |
| 722 | static const MIRDef mirs[] = { |
| 723 | DEF_SGET(Instruction::SGET_OBJECT, 0u, 0u), |
| 724 | DEF_AGET(Instruction::AGET, 1u, 0u, 100u), |
| 725 | DEF_SGET(Instruction::SGET_OBJECT, 2u, 1u), |
| 726 | DEF_SGET(Instruction::SGET_OBJECT, 3u, 0u), |
| 727 | DEF_AGET(Instruction::AGET, 4u, 3u, 100u), |
| 728 | }; |
| 729 | |
| 730 | PrepareSFields(sfields); |
| 731 | MakeSFieldUninitialized(1u); |
| 732 | PrepareMIRs(mirs); |
| 733 | PerformLVN(); |
| 734 | ASSERT_EQ(value_names_.size(), 5u); |
| 735 | EXPECT_NE(value_names_[0], value_names_[3]); |
| 736 | } |
| 737 | |
Vladimir Marko | f59f18b | 2014-02-17 15:53:57 +0000 | [diff] [blame] | 738 | } // namespace art |