blob: 8678fab655995a31eb3e256a6056180b5d32a4d2 [file] [log] [blame]
Mingyao Yang8df69d42015-10-22 15:40:58 -07001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "load_store_elimination.h"
Aart Bik96fd51d2016-11-28 11:22:35 -080018
Vladimir Marko009d1662017-10-10 13:21:15 +010019#include "base/array_ref.h"
20#include "base/scoped_arena_allocator.h"
21#include "base/scoped_arena_containers.h"
Aart Bik96fd51d2016-11-28 11:22:35 -080022#include "escape.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070023#include "load_store_analysis.h"
Mingyao Yang8df69d42015-10-22 15:40:58 -070024#include "side_effects_analysis.h"
25
26#include <iostream>
27
28namespace art {
29
Mingyao Yang8df69d42015-10-22 15:40:58 -070030// An unknown heap value. Loads with such a value in the heap location cannot be eliminated.
Mingyao Yangfb8464a2015-11-02 10:56:59 -080031// A heap location can be set to kUnknownHeapValue when:
32// - initially set a value.
33// - killed due to aliasing, merging, invocation, or loop side effects.
Mingyao Yang8df69d42015-10-22 15:40:58 -070034static HInstruction* const kUnknownHeapValue =
35 reinterpret_cast<HInstruction*>(static_cast<uintptr_t>(-1));
Mingyao Yangfb8464a2015-11-02 10:56:59 -080036
Mingyao Yang8df69d42015-10-22 15:40:58 -070037// Default heap value after an allocation.
Mingyao Yangfb8464a2015-11-02 10:56:59 -080038// A heap location can be set to that value right after an allocation.
Mingyao Yang8df69d42015-10-22 15:40:58 -070039static HInstruction* const kDefaultHeapValue =
40 reinterpret_cast<HInstruction*>(static_cast<uintptr_t>(-2));
41
Mingyao Yangc62b7ec2017-10-25 16:42:15 -070042// Use HGraphDelegateVisitor for which all VisitInvokeXXX() delegate to VisitInvoke().
43class LSEVisitor : public HGraphDelegateVisitor {
Mingyao Yang8df69d42015-10-22 15:40:58 -070044 public:
45 LSEVisitor(HGraph* graph,
46 const HeapLocationCollector& heap_locations_collector,
Igor Murashkin6ef45672017-08-08 13:59:55 -070047 const SideEffectsAnalysis& side_effects,
48 OptimizingCompilerStats* stats)
Mingyao Yangc62b7ec2017-10-25 16:42:15 -070049 : HGraphDelegateVisitor(graph, stats),
Mingyao Yang8df69d42015-10-22 15:40:58 -070050 heap_location_collector_(heap_locations_collector),
51 side_effects_(side_effects),
Vladimir Marko009d1662017-10-10 13:21:15 +010052 allocator_(graph->GetArenaStack()),
Mingyao Yang8df69d42015-10-22 15:40:58 -070053 heap_values_for_(graph->GetBlocks().size(),
Vladimir Marko009d1662017-10-10 13:21:15 +010054 ScopedArenaVector<HInstruction*>(heap_locations_collector.
55 GetNumberOfHeapLocations(),
56 kUnknownHeapValue,
57 allocator_.Adapter(kArenaAllocLSE)),
58 allocator_.Adapter(kArenaAllocLSE)),
59 removed_loads_(allocator_.Adapter(kArenaAllocLSE)),
60 substitute_instructions_for_loads_(allocator_.Adapter(kArenaAllocLSE)),
61 possibly_removed_stores_(allocator_.Adapter(kArenaAllocLSE)),
62 singleton_new_instances_(allocator_.Adapter(kArenaAllocLSE)),
63 singleton_new_arrays_(allocator_.Adapter(kArenaAllocLSE)) {
Mingyao Yang8df69d42015-10-22 15:40:58 -070064 }
65
66 void VisitBasicBlock(HBasicBlock* block) OVERRIDE {
Mingyao Yangfb8464a2015-11-02 10:56:59 -080067 // Populate the heap_values array for this block.
Mingyao Yang8df69d42015-10-22 15:40:58 -070068 // TODO: try to reuse the heap_values array from one predecessor if possible.
69 if (block->IsLoopHeader()) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -080070 HandleLoopSideEffects(block);
Mingyao Yang8df69d42015-10-22 15:40:58 -070071 } else {
72 MergePredecessorValues(block);
73 }
74 HGraphVisitor::VisitBasicBlock(block);
75 }
76
77 // Remove recorded instructions that should be eliminated.
78 void RemoveInstructions() {
Mingyao Yangfb8464a2015-11-02 10:56:59 -080079 size_t size = removed_loads_.size();
80 DCHECK_EQ(size, substitute_instructions_for_loads_.size());
Mingyao Yang8df69d42015-10-22 15:40:58 -070081 for (size_t i = 0; i < size; i++) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -080082 HInstruction* load = removed_loads_[i];
83 DCHECK(load != nullptr);
84 DCHECK(load->IsInstanceFieldGet() ||
85 load->IsStaticFieldGet() ||
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +000086 load->IsArrayGet());
Mingyao Yangfb8464a2015-11-02 10:56:59 -080087 HInstruction* substitute = substitute_instructions_for_loads_[i];
88 DCHECK(substitute != nullptr);
89 // Keep tracing substitute till one that's not removed.
90 HInstruction* sub_sub = FindSubstitute(substitute);
91 while (sub_sub != substitute) {
92 substitute = sub_sub;
93 sub_sub = FindSubstitute(substitute);
Mingyao Yang8df69d42015-10-22 15:40:58 -070094 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -080095 load->ReplaceWith(substitute);
96 load->GetBlock()->RemoveInstruction(load);
Mingyao Yang8df69d42015-10-22 15:40:58 -070097 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -080098
99 // At this point, stores in possibly_removed_stores_ can be safely removed.
Mingyao Yang86974902017-03-01 14:03:51 -0800100 for (HInstruction* store : possibly_removed_stores_) {
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000101 DCHECK(store->IsInstanceFieldSet() || store->IsStaticFieldSet() || store->IsArraySet());
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800102 store->GetBlock()->RemoveInstruction(store);
103 }
104
Igor Murashkind01745e2017-04-05 16:40:31 -0700105 // Eliminate singleton-classified instructions:
106 // * - Constructor fences (they never escape this thread).
107 // * - Allocations (if they are unused).
Mingyao Yang86974902017-03-01 14:03:51 -0800108 for (HInstruction* new_instance : singleton_new_instances_) {
Igor Murashkin6ef45672017-08-08 13:59:55 -0700109 size_t removed = HConstructorFence::RemoveConstructorFences(new_instance);
110 MaybeRecordStat(stats_,
111 MethodCompilationStat::kConstructorFenceRemovedLSE,
112 removed);
Igor Murashkind01745e2017-04-05 16:40:31 -0700113
Mingyao Yang062157f2016-03-02 10:15:36 -0800114 if (!new_instance->HasNonEnvironmentUses()) {
115 new_instance->RemoveEnvironmentUsers();
116 new_instance->GetBlock()->RemoveInstruction(new_instance);
117 }
118 }
Mingyao Yang86974902017-03-01 14:03:51 -0800119 for (HInstruction* new_array : singleton_new_arrays_) {
Igor Murashkin6ef45672017-08-08 13:59:55 -0700120 size_t removed = HConstructorFence::RemoveConstructorFences(new_array);
121 MaybeRecordStat(stats_,
122 MethodCompilationStat::kConstructorFenceRemovedLSE,
123 removed);
Igor Murashkind01745e2017-04-05 16:40:31 -0700124
Mingyao Yang86974902017-03-01 14:03:51 -0800125 if (!new_array->HasNonEnvironmentUses()) {
126 new_array->RemoveEnvironmentUsers();
127 new_array->GetBlock()->RemoveInstruction(new_array);
128 }
129 }
Mingyao Yang8df69d42015-10-22 15:40:58 -0700130 }
131
132 private:
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800133 // If heap_values[index] is an instance field store, need to keep the store.
134 // This is necessary if a heap value is killed due to merging, or loop side
135 // effects (which is essentially merging also), since a load later from the
136 // location won't be eliminated.
137 void KeepIfIsStore(HInstruction* heap_value) {
138 if (heap_value == kDefaultHeapValue ||
139 heap_value == kUnknownHeapValue ||
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000140 !(heap_value->IsInstanceFieldSet() || heap_value->IsArraySet())) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800141 return;
142 }
143 auto idx = std::find(possibly_removed_stores_.begin(),
144 possibly_removed_stores_.end(), heap_value);
145 if (idx != possibly_removed_stores_.end()) {
146 // Make sure the store is kept.
147 possibly_removed_stores_.erase(idx);
148 }
149 }
150
151 void HandleLoopSideEffects(HBasicBlock* block) {
152 DCHECK(block->IsLoopHeader());
153 int block_id = block->GetBlockId();
Vladimir Marko009d1662017-10-10 13:21:15 +0100154 ScopedArenaVector<HInstruction*>& heap_values = heap_values_for_[block_id];
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000155
156 // Don't eliminate loads in irreducible loops. This is safe for singletons, because
157 // they are always used by the non-eliminated loop-phi.
158 if (block->GetLoopInformation()->IsIrreducible()) {
159 if (kIsDebugBuild) {
160 for (size_t i = 0; i < heap_values.size(); i++) {
161 DCHECK_EQ(heap_values[i], kUnknownHeapValue);
162 }
163 }
164 return;
165 }
166
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800167 HBasicBlock* pre_header = block->GetLoopInformation()->GetPreHeader();
Vladimir Marko009d1662017-10-10 13:21:15 +0100168 ScopedArenaVector<HInstruction*>& pre_header_heap_values =
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800169 heap_values_for_[pre_header->GetBlockId()];
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000170
Mingyao Yang803cbb92015-12-01 12:24:36 -0800171 // Inherit the values from pre-header.
172 for (size_t i = 0; i < heap_values.size(); i++) {
173 heap_values[i] = pre_header_heap_values[i];
174 }
175
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800176 // We do a single pass in reverse post order. For loops, use the side effects as a hint
177 // to see if the heap values should be killed.
178 if (side_effects_.GetLoopEffects(block).DoesAnyWrite()) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800179 for (size_t i = 0; i < heap_values.size(); i++) {
Mingyao Yang803cbb92015-12-01 12:24:36 -0800180 HeapLocation* location = heap_location_collector_.GetHeapLocation(i);
181 ReferenceInfo* ref_info = location->GetReferenceInfo();
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800182 if (ref_info->IsSingletonAndRemovable() &&
183 !location->IsValueKilledByLoopSideEffects()) {
184 // A removable singleton's field that's not stored into inside a loop is
185 // invariant throughout the loop. Nothing to do.
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800186 } else {
187 // heap value is killed by loop side effects (stored into directly, or
188 // due to aliasing). Or the heap value may be needed after method return
189 // or deoptimization.
Mingyao Yang803cbb92015-12-01 12:24:36 -0800190 KeepIfIsStore(pre_header_heap_values[i]);
191 heap_values[i] = kUnknownHeapValue;
Mingyao Yang803cbb92015-12-01 12:24:36 -0800192 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800193 }
194 }
195 }
196
Mingyao Yang8df69d42015-10-22 15:40:58 -0700197 void MergePredecessorValues(HBasicBlock* block) {
Vladimir Marko009d1662017-10-10 13:21:15 +0100198 ArrayRef<HBasicBlock* const> predecessors(block->GetPredecessors());
Mingyao Yang8df69d42015-10-22 15:40:58 -0700199 if (predecessors.size() == 0) {
200 return;
201 }
Mingyao Yang58d9bfc2016-11-01 13:31:58 -0700202
Vladimir Marko009d1662017-10-10 13:21:15 +0100203 ScopedArenaVector<HInstruction*>& heap_values = heap_values_for_[block->GetBlockId()];
Mingyao Yang8df69d42015-10-22 15:40:58 -0700204 for (size_t i = 0; i < heap_values.size(); i++) {
Mingyao Yang58d9bfc2016-11-01 13:31:58 -0700205 HInstruction* merged_value = nullptr;
206 // Whether merged_value is a result that's merged from all predecessors.
207 bool from_all_predecessors = true;
208 ReferenceInfo* ref_info = heap_location_collector_.GetHeapLocation(i)->GetReferenceInfo();
209 HInstruction* singleton_ref = nullptr;
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800210 if (ref_info->IsSingleton()) {
Mingyao Yang58d9bfc2016-11-01 13:31:58 -0700211 // We do more analysis of liveness when merging heap values for such
212 // cases since stores into such references may potentially be eliminated.
213 singleton_ref = ref_info->GetReference();
214 }
215
216 for (HBasicBlock* predecessor : predecessors) {
217 HInstruction* pred_value = heap_values_for_[predecessor->GetBlockId()][i];
218 if ((singleton_ref != nullptr) &&
219 !singleton_ref->GetBlock()->Dominates(predecessor)) {
220 // singleton_ref is not live in this predecessor. Skip this predecessor since
221 // it does not really have the location.
222 DCHECK_EQ(pred_value, kUnknownHeapValue);
223 from_all_predecessors = false;
224 continue;
225 }
226 if (merged_value == nullptr) {
227 // First seen heap value.
228 merged_value = pred_value;
229 } else if (pred_value != merged_value) {
230 // There are conflicting values.
231 merged_value = kUnknownHeapValue;
232 break;
Mingyao Yang8df69d42015-10-22 15:40:58 -0700233 }
234 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800235
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800236 if (merged_value == kUnknownHeapValue || ref_info->IsSingletonAndNonRemovable()) {
237 // There are conflicting heap values from different predecessors,
238 // or the heap value may be needed after method return or deoptimization.
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800239 // Keep the last store in each predecessor since future loads cannot be eliminated.
Mingyao Yang58d9bfc2016-11-01 13:31:58 -0700240 for (HBasicBlock* predecessor : predecessors) {
Vladimir Marko009d1662017-10-10 13:21:15 +0100241 ScopedArenaVector<HInstruction*>& pred_values =
242 heap_values_for_[predecessor->GetBlockId()];
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800243 KeepIfIsStore(pred_values[i]);
244 }
245 }
Mingyao Yang58d9bfc2016-11-01 13:31:58 -0700246
247 if ((merged_value == nullptr) || !from_all_predecessors) {
248 DCHECK(singleton_ref != nullptr);
249 DCHECK((singleton_ref->GetBlock() == block) ||
250 !singleton_ref->GetBlock()->Dominates(block));
251 // singleton_ref is not defined before block or defined only in some of its
252 // predecessors, so block doesn't really have the location at its entry.
253 heap_values[i] = kUnknownHeapValue;
254 } else {
255 heap_values[i] = merged_value;
256 }
Mingyao Yang8df69d42015-10-22 15:40:58 -0700257 }
258 }
259
260 // `instruction` is being removed. Try to see if the null check on it
261 // can be removed. This can happen if the same value is set in two branches
262 // but not in dominators. Such as:
263 // int[] a = foo();
264 // if () {
265 // a[0] = 2;
266 // } else {
267 // a[0] = 2;
268 // }
269 // // a[0] can now be replaced with constant 2, and the null check on it can be removed.
270 void TryRemovingNullCheck(HInstruction* instruction) {
271 HInstruction* prev = instruction->GetPrevious();
272 if ((prev != nullptr) && prev->IsNullCheck() && (prev == instruction->InputAt(0))) {
273 // Previous instruction is a null check for this instruction. Remove the null check.
274 prev->ReplaceWith(prev->InputAt(0));
275 prev->GetBlock()->RemoveInstruction(prev);
276 }
277 }
278
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100279 HInstruction* GetDefaultValue(DataType::Type type) {
Mingyao Yang8df69d42015-10-22 15:40:58 -0700280 switch (type) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100281 case DataType::Type::kReference:
Mingyao Yang8df69d42015-10-22 15:40:58 -0700282 return GetGraph()->GetNullConstant();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100283 case DataType::Type::kBool:
Vladimir Markod5d2f2c2017-09-26 12:37:26 +0100284 case DataType::Type::kUint8:
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100285 case DataType::Type::kInt8:
286 case DataType::Type::kUint16:
287 case DataType::Type::kInt16:
288 case DataType::Type::kInt32:
Mingyao Yang8df69d42015-10-22 15:40:58 -0700289 return GetGraph()->GetIntConstant(0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100290 case DataType::Type::kInt64:
Mingyao Yang8df69d42015-10-22 15:40:58 -0700291 return GetGraph()->GetLongConstant(0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100292 case DataType::Type::kFloat32:
Mingyao Yang8df69d42015-10-22 15:40:58 -0700293 return GetGraph()->GetFloatConstant(0);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100294 case DataType::Type::kFloat64:
Mingyao Yang8df69d42015-10-22 15:40:58 -0700295 return GetGraph()->GetDoubleConstant(0);
296 default:
297 UNREACHABLE();
298 }
299 }
300
301 void VisitGetLocation(HInstruction* instruction,
302 HInstruction* ref,
303 size_t offset,
304 HInstruction* index,
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100305 size_t vector_length,
Mingyao Yang8df69d42015-10-22 15:40:58 -0700306 int16_t declaring_class_def_index) {
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100307 HInstruction* original_ref = heap_location_collector_.HuntForOriginalReference(ref);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700308 ReferenceInfo* ref_info = heap_location_collector_.FindReferenceInfoOf(original_ref);
309 size_t idx = heap_location_collector_.FindHeapLocationIndex(
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100310 ref_info, offset, index, vector_length, declaring_class_def_index);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700311 DCHECK_NE(idx, HeapLocationCollector::kHeapLocationNotFound);
Vladimir Marko009d1662017-10-10 13:21:15 +0100312 ScopedArenaVector<HInstruction*>& heap_values =
Mingyao Yang8df69d42015-10-22 15:40:58 -0700313 heap_values_for_[instruction->GetBlock()->GetBlockId()];
314 HInstruction* heap_value = heap_values[idx];
315 if (heap_value == kDefaultHeapValue) {
316 HInstruction* constant = GetDefaultValue(instruction->GetType());
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800317 removed_loads_.push_back(instruction);
318 substitute_instructions_for_loads_.push_back(constant);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700319 heap_values[idx] = constant;
320 return;
321 }
Mingyao Yang86974902017-03-01 14:03:51 -0800322 if (heap_value != kUnknownHeapValue) {
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000323 if (heap_value->IsInstanceFieldSet() || heap_value->IsArraySet()) {
Mingyao Yang86974902017-03-01 14:03:51 -0800324 HInstruction* store = heap_value;
325 // This load must be from a singleton since it's from the same
326 // field/element that a "removed" store puts the value. That store
327 // must be to a singleton's field/element.
328 DCHECK(ref_info->IsSingleton());
329 // Get the real heap value of the store.
330 heap_value = heap_value->IsInstanceFieldSet() ? store->InputAt(1) : store->InputAt(2);
331 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800332 }
David Brazdil15693bf2015-12-16 10:30:45 +0000333 if (heap_value == kUnknownHeapValue) {
334 // Load isn't eliminated. Put the load as the value into the HeapLocation.
335 // This acts like GVN but with better aliasing analysis.
336 heap_values[idx] = instruction;
337 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100338 if (DataType::Kind(heap_value->GetType()) != DataType::Kind(instruction->GetType())) {
Nicolas Geoffray03971632016-03-17 10:44:24 +0000339 // The only situation where the same heap location has different type is when
Nicolas Geoffray65fef302016-05-04 14:00:12 +0100340 // we do an array get on an instruction that originates from the null constant
341 // (the null could be behind a field access, an array access, a null check or
342 // a bound type).
343 // In order to stay properly typed on primitive types, we do not eliminate
344 // the array gets.
Nicolas Geoffray03971632016-03-17 10:44:24 +0000345 if (kIsDebugBuild) {
346 DCHECK(heap_value->IsArrayGet()) << heap_value->DebugName();
347 DCHECK(instruction->IsArrayGet()) << instruction->DebugName();
Nicolas Geoffray03971632016-03-17 10:44:24 +0000348 }
349 return;
350 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800351 removed_loads_.push_back(instruction);
352 substitute_instructions_for_loads_.push_back(heap_value);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700353 TryRemovingNullCheck(instruction);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700354 }
355 }
356
357 bool Equal(HInstruction* heap_value, HInstruction* value) {
358 if (heap_value == value) {
359 return true;
360 }
361 if (heap_value == kDefaultHeapValue && GetDefaultValue(value->GetType()) == value) {
362 return true;
363 }
364 return false;
365 }
366
367 void VisitSetLocation(HInstruction* instruction,
368 HInstruction* ref,
369 size_t offset,
370 HInstruction* index,
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100371 size_t vector_length,
Mingyao Yang8df69d42015-10-22 15:40:58 -0700372 int16_t declaring_class_def_index,
373 HInstruction* value) {
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100374 HInstruction* original_ref = heap_location_collector_.HuntForOriginalReference(ref);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700375 ReferenceInfo* ref_info = heap_location_collector_.FindReferenceInfoOf(original_ref);
376 size_t idx = heap_location_collector_.FindHeapLocationIndex(
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100377 ref_info, offset, index, vector_length, declaring_class_def_index);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700378 DCHECK_NE(idx, HeapLocationCollector::kHeapLocationNotFound);
Vladimir Marko009d1662017-10-10 13:21:15 +0100379 ScopedArenaVector<HInstruction*>& heap_values =
Mingyao Yang8df69d42015-10-22 15:40:58 -0700380 heap_values_for_[instruction->GetBlock()->GetBlockId()];
381 HInstruction* heap_value = heap_values[idx];
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800382 bool same_value = false;
383 bool possibly_redundant = false;
Mingyao Yang8df69d42015-10-22 15:40:58 -0700384 if (Equal(heap_value, value)) {
385 // Store into the heap location with the same value.
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800386 same_value = true;
Mingyao Yang86974902017-03-01 14:03:51 -0800387 } else if (index != nullptr && ref_info->HasIndexAliasing()) {
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800388 // For array element, don't eliminate stores if the index can be aliased.
389 } else if (ref_info->IsSingleton()) {
Mingyao Yang025c1a62017-10-30 11:19:57 -0700390 // Store into a field/element of a singleton. The value cannot be killed due to
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800391 // aliasing/invocation. It can be redundant since future loads can
392 // directly get the value set by this instruction. The value can still be killed due to
393 // merging or loop side effects. Stores whose values are killed due to merging/loop side
394 // effects later will be removed from possibly_removed_stores_ when that is detected.
395 // Stores whose values may be needed after method return or deoptimization
396 // are also removed from possibly_removed_stores_ when that is detected.
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800397 possibly_redundant = true;
Mingyao Yang025c1a62017-10-30 11:19:57 -0700398 HLoopInformation* loop_info = instruction->GetBlock()->GetLoopInformation();
399 if (loop_info != nullptr) {
400 // instruction is a store in the loop so the loop must does write.
401 DCHECK(side_effects_.GetLoopEffects(loop_info->GetHeader()).DoesAnyWrite());
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800402
Mingyao Yang025c1a62017-10-30 11:19:57 -0700403 if (loop_info->IsDefinedOutOfTheLoop(original_ref)) {
404 DCHECK(original_ref->GetBlock()->Dominates(loop_info->GetPreHeader()));
405 // Keep the store since its value may be needed at the loop header.
406 possibly_redundant = false;
407 } else {
408 // The singleton is created inside the loop. Value stored to it isn't needed at
409 // the loop header. This is true for outer loops also.
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800410 }
Mingyao Yang8df69d42015-10-22 15:40:58 -0700411 }
Mingyao Yang8df69d42015-10-22 15:40:58 -0700412 }
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800413 if (same_value || possibly_redundant) {
414 possibly_removed_stores_.push_back(instruction);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700415 }
Mingyao Yange9d6e602015-10-23 17:08:42 -0700416
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800417 if (!same_value) {
418 if (possibly_redundant) {
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000419 DCHECK(instruction->IsInstanceFieldSet() || instruction->IsArraySet());
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800420 // Put the store as the heap value. If the value is loaded from heap
421 // by a load later, this store isn't really redundant.
422 heap_values[idx] = instruction;
423 } else {
424 heap_values[idx] = value;
425 }
426 }
Mingyao Yang8df69d42015-10-22 15:40:58 -0700427 // This store may kill values in other heap locations due to aliasing.
428 for (size_t i = 0; i < heap_values.size(); i++) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800429 if (i == idx) {
430 continue;
431 }
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000432 if (heap_values[i] == value) {
433 // Same value should be kept even if aliasing happens.
Mingyao Yang8df69d42015-10-22 15:40:58 -0700434 continue;
435 }
436 if (heap_values[i] == kUnknownHeapValue) {
437 // Value is already unknown, no need for aliasing check.
438 continue;
439 }
440 if (heap_location_collector_.MayAlias(i, idx)) {
441 // Kill heap locations that may alias.
442 heap_values[i] = kUnknownHeapValue;
443 }
444 }
445 }
446
447 void VisitInstanceFieldGet(HInstanceFieldGet* instruction) OVERRIDE {
448 HInstruction* obj = instruction->InputAt(0);
449 size_t offset = instruction->GetFieldInfo().GetFieldOffset().SizeValue();
450 int16_t declaring_class_def_index = instruction->GetFieldInfo().GetDeclaringClassDefIndex();
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100451 VisitGetLocation(instruction,
452 obj,
453 offset,
454 nullptr,
455 HeapLocation::kScalar,
456 declaring_class_def_index);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700457 }
458
459 void VisitInstanceFieldSet(HInstanceFieldSet* instruction) OVERRIDE {
460 HInstruction* obj = instruction->InputAt(0);
461 size_t offset = instruction->GetFieldInfo().GetFieldOffset().SizeValue();
462 int16_t declaring_class_def_index = instruction->GetFieldInfo().GetDeclaringClassDefIndex();
463 HInstruction* value = instruction->InputAt(1);
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100464 VisitSetLocation(instruction,
465 obj,
466 offset,
467 nullptr,
468 HeapLocation::kScalar,
469 declaring_class_def_index,
470 value);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700471 }
472
473 void VisitStaticFieldGet(HStaticFieldGet* instruction) OVERRIDE {
474 HInstruction* cls = instruction->InputAt(0);
475 size_t offset = instruction->GetFieldInfo().GetFieldOffset().SizeValue();
476 int16_t declaring_class_def_index = instruction->GetFieldInfo().GetDeclaringClassDefIndex();
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100477 VisitGetLocation(instruction,
478 cls,
479 offset,
480 nullptr,
481 HeapLocation::kScalar,
482 declaring_class_def_index);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700483 }
484
485 void VisitStaticFieldSet(HStaticFieldSet* instruction) OVERRIDE {
486 HInstruction* cls = instruction->InputAt(0);
487 size_t offset = instruction->GetFieldInfo().GetFieldOffset().SizeValue();
488 int16_t declaring_class_def_index = instruction->GetFieldInfo().GetDeclaringClassDefIndex();
489 HInstruction* value = instruction->InputAt(1);
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100490 VisitSetLocation(instruction,
491 cls,
492 offset,
493 nullptr,
494 HeapLocation::kScalar,
495 declaring_class_def_index,
496 value);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700497 }
498
499 void VisitArrayGet(HArrayGet* instruction) OVERRIDE {
500 HInstruction* array = instruction->InputAt(0);
501 HInstruction* index = instruction->InputAt(1);
502 VisitGetLocation(instruction,
503 array,
504 HeapLocation::kInvalidFieldOffset,
505 index,
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100506 HeapLocation::kScalar,
Mingyao Yang8df69d42015-10-22 15:40:58 -0700507 HeapLocation::kDeclaringClassDefIndexForArrays);
508 }
509
510 void VisitArraySet(HArraySet* instruction) OVERRIDE {
511 HInstruction* array = instruction->InputAt(0);
512 HInstruction* index = instruction->InputAt(1);
513 HInstruction* value = instruction->InputAt(2);
514 VisitSetLocation(instruction,
515 array,
516 HeapLocation::kInvalidFieldOffset,
517 index,
xueliang.zhongb50b16a2017-09-19 17:43:29 +0100518 HeapLocation::kScalar,
Mingyao Yang8df69d42015-10-22 15:40:58 -0700519 HeapLocation::kDeclaringClassDefIndexForArrays,
520 value);
521 }
522
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800523 void VisitDeoptimize(HDeoptimize* instruction) {
Vladimir Marko009d1662017-10-10 13:21:15 +0100524 const ScopedArenaVector<HInstruction*>& heap_values =
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800525 heap_values_for_[instruction->GetBlock()->GetBlockId()];
526 for (HInstruction* heap_value : heap_values) {
527 // Filter out fake instructions before checking instruction kind below.
528 if (heap_value == kUnknownHeapValue || heap_value == kDefaultHeapValue) {
529 continue;
530 }
531 // A store is kept as the heap value for possibly removed stores.
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000532 if (heap_value->IsInstanceFieldSet() || heap_value->IsArraySet()) {
Mingyao Yangeb2d2d346e2017-03-02 13:26:17 -0800533 // Check whether the reference for a store is used by an environment local of
534 // HDeoptimize.
535 HInstruction* reference = heap_value->InputAt(0);
536 DCHECK(heap_location_collector_.FindReferenceInfoOf(reference)->IsSingleton());
537 for (const HUseListNode<HEnvironment*>& use : reference->GetEnvUses()) {
538 HEnvironment* user = use.GetUser();
539 if (user->GetHolder() == instruction) {
540 // The singleton for the store is visible at this deoptimization
541 // point. Need to keep the store so that the heap value is
542 // seen by the interpreter.
543 KeepIfIsStore(heap_value);
544 }
545 }
546 }
547 }
548 }
549
Mingyao Yang293f1c02017-11-08 15:22:17 -0800550 void HandleInvoke(HInstruction* instruction) {
551 SideEffects side_effects = instruction->GetSideEffects();
Vladimir Marko009d1662017-10-10 13:21:15 +0100552 ScopedArenaVector<HInstruction*>& heap_values =
Mingyao Yang293f1c02017-11-08 15:22:17 -0800553 heap_values_for_[instruction->GetBlock()->GetBlockId()];
Mingyao Yang8df69d42015-10-22 15:40:58 -0700554 for (size_t i = 0; i < heap_values.size(); i++) {
555 ReferenceInfo* ref_info = heap_location_collector_.GetHeapLocation(i)->GetReferenceInfo();
556 if (ref_info->IsSingleton()) {
557 // Singleton references cannot be seen by the callee.
558 } else {
Mingyao Yang293f1c02017-11-08 15:22:17 -0800559 if (side_effects.DoesAnyRead()) {
560 KeepIfIsStore(heap_values[i]);
561 }
562 if (side_effects.DoesAnyWrite()) {
563 heap_values[i] = kUnknownHeapValue;
564 }
Mingyao Yang8df69d42015-10-22 15:40:58 -0700565 }
566 }
567 }
568
Mingyao Yangc62b7ec2017-10-25 16:42:15 -0700569 void VisitInvoke(HInvoke* invoke) OVERRIDE {
Orion Hodsonac141392017-01-13 11:53:47 +0000570 HandleInvoke(invoke);
571 }
572
Mingyao Yang8df69d42015-10-22 15:40:58 -0700573 void VisitClinitCheck(HClinitCheck* clinit) OVERRIDE {
574 HandleInvoke(clinit);
575 }
576
577 void VisitUnresolvedInstanceFieldGet(HUnresolvedInstanceFieldGet* instruction) OVERRIDE {
578 // Conservatively treat it as an invocation.
579 HandleInvoke(instruction);
580 }
581
582 void VisitUnresolvedInstanceFieldSet(HUnresolvedInstanceFieldSet* instruction) OVERRIDE {
583 // Conservatively treat it as an invocation.
584 HandleInvoke(instruction);
585 }
586
587 void VisitUnresolvedStaticFieldGet(HUnresolvedStaticFieldGet* instruction) OVERRIDE {
588 // Conservatively treat it as an invocation.
589 HandleInvoke(instruction);
590 }
591
592 void VisitUnresolvedStaticFieldSet(HUnresolvedStaticFieldSet* instruction) OVERRIDE {
593 // Conservatively treat it as an invocation.
594 HandleInvoke(instruction);
595 }
596
597 void VisitNewInstance(HNewInstance* new_instance) OVERRIDE {
598 ReferenceInfo* ref_info = heap_location_collector_.FindReferenceInfoOf(new_instance);
599 if (ref_info == nullptr) {
600 // new_instance isn't used for field accesses. No need to process it.
601 return;
602 }
Mingyao Yang025c1a62017-10-30 11:19:57 -0700603 if (ref_info->IsSingletonAndRemovable() && !new_instance->NeedsChecks()) {
604 DCHECK(!new_instance->IsFinalizable());
Mingyao Yang062157f2016-03-02 10:15:36 -0800605 singleton_new_instances_.push_back(new_instance);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700606 }
Vladimir Marko009d1662017-10-10 13:21:15 +0100607 ScopedArenaVector<HInstruction*>& heap_values =
Mingyao Yang8df69d42015-10-22 15:40:58 -0700608 heap_values_for_[new_instance->GetBlock()->GetBlockId()];
609 for (size_t i = 0; i < heap_values.size(); i++) {
610 HInstruction* ref =
611 heap_location_collector_.GetHeapLocation(i)->GetReferenceInfo()->GetReference();
612 size_t offset = heap_location_collector_.GetHeapLocation(i)->GetOffset();
613 if (ref == new_instance && offset >= mirror::kObjectHeaderSize) {
614 // Instance fields except the header fields are set to default heap values.
615 heap_values[i] = kDefaultHeapValue;
616 }
617 }
618 }
619
Mingyao Yang86974902017-03-01 14:03:51 -0800620 void VisitNewArray(HNewArray* new_array) OVERRIDE {
621 ReferenceInfo* ref_info = heap_location_collector_.FindReferenceInfoOf(new_array);
622 if (ref_info == nullptr) {
623 // new_array isn't used for array accesses. No need to process it.
624 return;
625 }
626 if (ref_info->IsSingletonAndRemovable()) {
627 singleton_new_arrays_.push_back(new_array);
628 }
Vladimir Marko009d1662017-10-10 13:21:15 +0100629 ScopedArenaVector<HInstruction*>& heap_values =
Mingyao Yang86974902017-03-01 14:03:51 -0800630 heap_values_for_[new_array->GetBlock()->GetBlockId()];
631 for (size_t i = 0; i < heap_values.size(); i++) {
632 HeapLocation* location = heap_location_collector_.GetHeapLocation(i);
633 HInstruction* ref = location->GetReferenceInfo()->GetReference();
634 if (ref == new_array && location->GetIndex() != nullptr) {
635 // Array elements are set to default heap values.
636 heap_values[i] = kDefaultHeapValue;
637 }
638 }
639 }
640
Mingyao Yang8df69d42015-10-22 15:40:58 -0700641 // Find an instruction's substitute if it should be removed.
642 // Return the same instruction if it should not be removed.
643 HInstruction* FindSubstitute(HInstruction* instruction) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800644 size_t size = removed_loads_.size();
Mingyao Yang8df69d42015-10-22 15:40:58 -0700645 for (size_t i = 0; i < size; i++) {
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800646 if (removed_loads_[i] == instruction) {
647 return substitute_instructions_for_loads_[i];
Mingyao Yang8df69d42015-10-22 15:40:58 -0700648 }
649 }
650 return instruction;
651 }
652
653 const HeapLocationCollector& heap_location_collector_;
654 const SideEffectsAnalysis& side_effects_;
655
Vladimir Marko009d1662017-10-10 13:21:15 +0100656 // Use local allocator for allocating memory.
657 ScopedArenaAllocator allocator_;
658
Mingyao Yang8df69d42015-10-22 15:40:58 -0700659 // One array of heap values for each block.
Vladimir Marko009d1662017-10-10 13:21:15 +0100660 ScopedArenaVector<ScopedArenaVector<HInstruction*>> heap_values_for_;
Mingyao Yang8df69d42015-10-22 15:40:58 -0700661
662 // We record the instructions that should be eliminated but may be
663 // used by heap locations. They'll be removed in the end.
Vladimir Marko009d1662017-10-10 13:21:15 +0100664 ScopedArenaVector<HInstruction*> removed_loads_;
665 ScopedArenaVector<HInstruction*> substitute_instructions_for_loads_;
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800666
667 // Stores in this list may be removed from the list later when it's
668 // found that the store cannot be eliminated.
Vladimir Marko009d1662017-10-10 13:21:15 +0100669 ScopedArenaVector<HInstruction*> possibly_removed_stores_;
Mingyao Yangfb8464a2015-11-02 10:56:59 -0800670
Vladimir Marko009d1662017-10-10 13:21:15 +0100671 ScopedArenaVector<HInstruction*> singleton_new_instances_;
672 ScopedArenaVector<HInstruction*> singleton_new_arrays_;
Mingyao Yang8df69d42015-10-22 15:40:58 -0700673
674 DISALLOW_COPY_AND_ASSIGN(LSEVisitor);
675};
676
677void LoadStoreElimination::Run() {
David Brazdil8993caf2015-12-07 10:04:40 +0000678 if (graph_->IsDebuggable() || graph_->HasTryCatch()) {
Mingyao Yang8df69d42015-10-22 15:40:58 -0700679 // Debugger may set heap values or trigger deoptimization of callers.
David Brazdil8993caf2015-12-07 10:04:40 +0000680 // Try/catch support not implemented yet.
Mingyao Yang8df69d42015-10-22 15:40:58 -0700681 // Skip this optimization.
682 return;
683 }
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100684 const HeapLocationCollector& heap_location_collector = lsa_.GetHeapLocationCollector();
685 if (heap_location_collector.GetNumberOfHeapLocations() == 0) {
686 // No HeapLocation information from LSA, skip this optimization.
Mingyao Yang8df69d42015-10-22 15:40:58 -0700687 return;
688 }
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100689
Nicolas Geoffray8c4ddb22017-11-13 11:49:53 +0000690 // TODO: analyze VecLoad/VecStore better.
691 if (graph_->HasSIMD()) {
692 return;
693 }
694
Igor Murashkin6ef45672017-08-08 13:59:55 -0700695 LSEVisitor lse_visitor(graph_, heap_location_collector, side_effects_, stats_);
Vladimir Marko2c45bc92016-10-25 16:54:12 +0100696 for (HBasicBlock* block : graph_->GetReversePostOrder()) {
697 lse_visitor.VisitBasicBlock(block);
Mingyao Yang8df69d42015-10-22 15:40:58 -0700698 }
699 lse_visitor.RemoveInstructions();
700}
701
702} // namespace art