blob: 02a1acc240b9d2bc64e3545bbfbad88cb3ca42fe [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000020#include "builder.h"
21#include "class_linker.h"
22#include "constant_folding.h"
23#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000024#include "dex/verified_method.h"
25#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010027#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000028#include "driver/dex_compilation_unit.h"
29#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010030#include "intrinsics.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000031#include "mirror/class_loader.h"
32#include "mirror/dex_cache.h"
33#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010034#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010035#include "reference_type_propagation.h"
Nicolas Geoffray259136f2014-12-17 23:21:58 +000036#include "register_allocator.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000037#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010038#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000039#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000040#include "ssa_phi_elimination.h"
41#include "scoped_thread_state_change.h"
42#include "thread.h"
43
44namespace art {
45
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000046static constexpr size_t kMaximumNumberOfHInstructions = 32;
47
48// Limit the number of dex registers that we accumulate while inlining
49// to avoid creating large amount of nested environments.
50static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
51
52// Avoid inlining within a huge method due to memory pressure.
53static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070054
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000055void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010056 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
57 if ((compiler_options.GetInlineDepthLimit() == 0)
58 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
59 return;
60 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000061 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
62 return;
63 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000064 if (graph_->IsDebuggable()) {
65 // For simplicity, we currently never inline when the graph is debuggable. This avoids
66 // doing some logic in the runtime to discover if a method could have been inlined.
67 return;
68 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010069 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
70 DCHECK(!blocks.empty());
71 HBasicBlock* next_block = blocks[0];
72 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010073 // Because we are changing the graph when inlining, we need to remember the next block.
74 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010075 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010076 continue;
77 }
78 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010079 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000080 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
81 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010082 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070083 // As long as the call is not intrinsified, it is worth trying to inline.
84 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000085 // We use the original invoke type to ensure the resolution of the called method
86 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000087 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010088 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000089 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000090 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000091 bool should_inline = callee_name.find("$inline$") != std::string::npos;
92 CHECK(!should_inline) << "Could not inline " << callee_name;
93 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010094 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010095 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010096 std::string callee_name =
97 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
98 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
99 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
100 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000101 }
102 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000103 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000104 }
105 }
106}
107
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100108static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700109 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100110 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
111}
112
113/**
114 * Given the `resolved_method` looked up in the dex cache, try to find
115 * the actual runtime target of an interface or virtual call.
116 * Return nullptr if the runtime target cannot be proven.
117 */
118static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700119 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100120 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
121 // No need to lookup further, the resolved method will be the target.
122 return resolved_method;
123 }
124
125 HInstruction* receiver = invoke->InputAt(0);
126 if (receiver->IsNullCheck()) {
127 // Due to multiple levels of inlining within the same pass, it might be that
128 // null check does not have the reference type of the actual receiver.
129 receiver = receiver->InputAt(0);
130 }
131 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000132 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
133 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100134 // We currently only support inlining with known receivers.
135 // TODO: Remove this check, we should be able to inline final methods
136 // on unknown receivers.
137 return nullptr;
138 } else if (info.GetTypeHandle()->IsInterface()) {
139 // Statically knowing that the receiver has an interface type cannot
140 // help us find what is the target method.
141 return nullptr;
142 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
143 // The method that we're trying to call is not in the receiver's class or super classes.
144 return nullptr;
145 }
146
147 ClassLinker* cl = Runtime::Current()->GetClassLinker();
148 size_t pointer_size = cl->GetImagePointerSize();
149 if (invoke->IsInvokeInterface()) {
150 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
151 resolved_method, pointer_size);
152 } else {
153 DCHECK(invoke->IsInvokeVirtual());
154 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
155 resolved_method, pointer_size);
156 }
157
158 if (resolved_method == nullptr) {
159 // The information we had on the receiver was not enough to find
160 // the target method. Since we check above the exact type of the receiver,
161 // the only reason this can happen is an IncompatibleClassChangeError.
162 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700163 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100164 // The information we had on the receiver was not enough to find
165 // the target method. Since we check above the exact type of the receiver,
166 // the only reason this can happen is an IncompatibleClassChangeError.
167 return nullptr;
168 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
169 // A final method has to be the target method.
170 return resolved_method;
171 } else if (info.IsExact()) {
172 // If we found a method and the receiver's concrete type is statically
173 // known, we know for sure the target.
174 return resolved_method;
175 } else {
176 // Even if we did find a method, the receiver type was not enough to
177 // statically find the runtime target.
178 return nullptr;
179 }
180}
181
182static uint32_t FindMethodIndexIn(ArtMethod* method,
183 const DexFile& dex_file,
184 uint32_t referrer_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700185 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100186 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100187 return method->GetDexMethodIndex();
188 } else {
189 return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index);
190 }
191}
192
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000193static uint32_t FindClassIndexIn(mirror::Class* cls,
194 const DexFile& dex_file,
195 Handle<mirror::DexCache> dex_cache)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100196 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000197 uint32_t index = DexFile::kDexNoIndex;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100198 if (cls->GetDexCache() == nullptr) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000199 DCHECK(cls->IsArrayClass()) << PrettyClass(cls);
200 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100201 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000202 DCHECK(cls->IsProxyClass()) << PrettyClass(cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100203 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100204 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000205 index = cls->GetDexTypeIndex();
206 } else {
207 index = cls->FindTypeIndexInOtherDexFile(dex_file);
208 }
209
210 if (index != DexFile::kDexNoIndex) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100211 // Update the dex cache to ensure the class is in. The generated code will
212 // consider it is. We make it safe by updating the dex cache, as other
213 // dex files might also load the class, and there is no guarantee the dex
214 // cache of the dex file of the class will be updated.
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000215 if (dex_cache->GetResolvedType(index) == nullptr) {
216 dex_cache->SetResolvedType(index, cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100217 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100218 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000219
220 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100221}
222
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700223bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100224 if (invoke_instruction->IsInvokeUnresolved()) {
225 return false; // Don't bother to move further if we know the method is unresolved.
226 }
227
Vladimir Marko58155012015-08-19 12:49:41 +0000228 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000229 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000230 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
231 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000232
Nicolas Geoffray35071052015-06-09 15:43:38 +0100233 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
234 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000235 ArtMethod* resolved_method;
Andreas Gampefd2140f2015-12-23 16:30:44 -0800236 ArtMethod* actual_method = nullptr;
Vladimir Marko58155012015-08-19 12:49:41 +0000237 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000238 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
239 VLOG(compiler) << "Not inlining a String.<init> method";
240 return false;
241 }
Vladimir Marko58155012015-08-19 12:49:41 +0000242 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700243 mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file)
244 ? caller_compilation_unit_.GetDexCache().Get()
245 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
246 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000247 ref.dex_method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800248 // actual_method == resolved_method for direct or static calls.
249 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000250 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700251 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000252 method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800253 if (resolved_method != nullptr) {
254 // Check if we can statically find the method.
255 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
256 }
Vladimir Marko58155012015-08-19 12:49:41 +0000257 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000258
Mathieu Chartiere401d142015-04-22 13:56:20 -0700259 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100260 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100261 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000262 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000263 return false;
264 }
265
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100266 if (actual_method != nullptr) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000267 return TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100268 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000269
Andreas Gampefd2140f2015-12-23 16:30:44 -0800270 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100271
272 // Check if we can use an inline cache.
273 ArtMethod* caller = graph_->GetArtMethod();
274 size_t pointer_size = class_linker->GetImagePointerSize();
275 // Under JIT, we should always know the caller.
276 DCHECK(!Runtime::Current()->UseJit() || (caller != nullptr));
277 if (caller != nullptr && caller->GetProfilingInfo(pointer_size) != nullptr) {
278 ProfilingInfo* profiling_info = caller->GetProfilingInfo(pointer_size);
279 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
280 if (ic.IsUnitialized()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100281 VLOG(compiler) << "Interface or virtual call to "
282 << PrettyMethod(method_index, caller_dex_file)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100283 << " is not hit and not inlined";
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100284 return false;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100285 } else if (ic.IsMonomorphic()) {
286 MaybeRecordStat(kMonomorphicCall);
287 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
288 } else if (ic.IsPolymorphic()) {
289 MaybeRecordStat(kPolymorphicCall);
290 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
291 } else {
292 DCHECK(ic.IsMegamorphic());
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100293 VLOG(compiler) << "Interface or virtual call to "
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100294 << PrettyMethod(method_index, caller_dex_file)
295 << " is megamorphic and not inlined";
296 MaybeRecordStat(kMegamorphicCall);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100297 return false;
298 }
299 }
300
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100301 VLOG(compiler) << "Interface or virtual call to "
302 << PrettyMethod(method_index, caller_dex_file)
303 << " could not be statically determined";
304 return false;
305}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000306
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000307HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
308 HInstruction* receiver,
309 uint32_t dex_pc) const {
310 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
311 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000312 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000313 receiver,
314 Primitive::kPrimNot,
315 field->GetOffset(),
316 field->IsVolatile(),
317 field->GetDexFieldIndex(),
318 field->GetDeclaringClass()->GetDexClassDefIndex(),
319 *field->GetDexFile(),
320 handles_->NewHandle(field->GetDexCache()),
321 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000322 // The class of a field is effectively final, and does not have any memory dependencies.
323 result->SetSideEffects(SideEffects::None());
324 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000325}
326
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100327bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
328 ArtMethod* resolved_method,
329 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000330 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
331 << invoke_instruction->DebugName();
332
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100333 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000334 uint32_t class_index = FindClassIndexIn(
335 ic.GetMonomorphicType(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100336 if (class_index == DexFile::kDexNoIndex) {
337 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
338 << " from inline cache is not inlined because its class is not"
339 << " accessible to the caller";
340 return false;
341 }
342
343 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
344 size_t pointer_size = class_linker->GetImagePointerSize();
345 if (invoke_instruction->IsInvokeInterface()) {
346 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
347 resolved_method, pointer_size);
348 } else {
349 DCHECK(invoke_instruction->IsInvokeVirtual());
350 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
351 resolved_method, pointer_size);
352 }
353 DCHECK(resolved_method != nullptr);
354 HInstruction* receiver = invoke_instruction->InputAt(0);
355 HInstruction* cursor = invoke_instruction->GetPrevious();
356 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
357
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000358 if (!TryInlineAndReplace(invoke_instruction, resolved_method, /* do_rtp */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100359 return false;
360 }
361
362 // We successfully inlined, now add a guard.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100363 bool is_referrer =
364 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000365 AddTypeGuard(receiver,
366 cursor,
367 bb_cursor,
368 class_index,
369 is_referrer,
370 invoke_instruction,
371 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100372
373 // Run type propagation to get the guard typed, and eventually propagate the
374 // type of the receiver.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000375 ReferenceTypePropagation rtp_fixup(graph_, handles_, /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100376 rtp_fixup.Run();
377
378 MaybeRecordStat(kInlinedMonomorphicCall);
379 return true;
380}
381
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000382HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
383 HInstruction* cursor,
384 HBasicBlock* bb_cursor,
385 uint32_t class_index,
386 bool is_referrer,
387 HInstruction* invoke_instruction,
388 bool with_deoptimization) {
389 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
390 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
391 class_linker, receiver, invoke_instruction->GetDexPc());
392
393 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
394 // Note that we will just compare the classes, so we don't need Java semantics access checks.
395 // Also, the caller of `AddTypeGuard` must have guaranteed that the class is in the dex cache.
396 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
397 class_index,
398 caller_dex_file,
399 is_referrer,
400 invoke_instruction->GetDexPc(),
401 /* needs_access_check */ false,
402 /* is_in_dex_cache */ true);
403
404 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
405 // TODO: Extend reference type propagation to understand the guard.
406 if (cursor != nullptr) {
407 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
408 } else {
409 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
410 }
411 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
412 bb_cursor->InsertInstructionAfter(compare, load_class);
413 if (with_deoptimization) {
414 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
415 compare, invoke_instruction->GetDexPc());
416 bb_cursor->InsertInstructionAfter(deoptimize, compare);
417 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
418 }
419 return compare;
420}
421
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000422bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100423 ArtMethod* resolved_method,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000424 const InlineCache& ic) {
425 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
426 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000427
428 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, ic)) {
429 return true;
430 }
431
432 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
433 size_t pointer_size = class_linker->GetImagePointerSize();
434 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
435
436 bool all_targets_inlined = true;
437 bool one_target_inlined = false;
438 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
439 if (ic.GetTypeAt(i) == nullptr) {
440 break;
441 }
442 ArtMethod* method = nullptr;
443 if (invoke_instruction->IsInvokeInterface()) {
444 method = ic.GetTypeAt(i)->FindVirtualMethodForInterface(
445 resolved_method, pointer_size);
446 } else {
447 DCHECK(invoke_instruction->IsInvokeVirtual());
448 method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual(
449 resolved_method, pointer_size);
450 }
451
452 HInstruction* receiver = invoke_instruction->InputAt(0);
453 HInstruction* cursor = invoke_instruction->GetPrevious();
454 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
455
Nicolas Geoffray1fe26e12016-02-18 16:55:42 +0000456 uint32_t class_index = FindClassIndexIn(
457 ic.GetTypeAt(i), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000458 HInstruction* return_replacement = nullptr;
459 if (class_index == DexFile::kDexNoIndex ||
460 !TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
461 all_targets_inlined = false;
462 } else {
463 one_target_inlined = true;
464 bool is_referrer = (ic.GetTypeAt(i) == outermost_graph_->GetArtMethod()->GetDeclaringClass());
465
466 // If we have inlined all targets before, and this receiver is the last seen,
467 // we deoptimize instead of keeping the original invoke instruction.
468 bool deoptimize = all_targets_inlined &&
469 (i != InlineCache::kIndividualCacheSize - 1) &&
470 (ic.GetTypeAt(i + 1) == nullptr);
471 HInstruction* compare = AddTypeGuard(
472 receiver, cursor, bb_cursor, class_index, is_referrer, invoke_instruction, deoptimize);
473 if (deoptimize) {
474 if (return_replacement != nullptr) {
475 invoke_instruction->ReplaceWith(return_replacement);
476 }
477 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
478 // Because the inline cache data can be populated concurrently, we force the end of the
479 // iteration. Otherhwise, we could see a new receiver type.
480 break;
481 } else {
482 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
483 }
484 }
485 }
486
487 if (!one_target_inlined) {
488 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
489 << " from inline cache is not inlined because none"
490 << " of its targets could be inlined";
491 return false;
492 }
493 MaybeRecordStat(kInlinedPolymorphicCall);
494
495 // Run type propagation to get the guards typed.
496 ReferenceTypePropagation rtp_fixup(graph_, handles_, /* is_first_run */ false);
497 rtp_fixup.Run();
498 return true;
499}
500
501void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
502 HInstruction* return_replacement,
503 HInstruction* invoke_instruction) {
504 uint32_t dex_pc = invoke_instruction->GetDexPc();
505 HBasicBlock* cursor_block = compare->GetBlock();
506 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
507 ArenaAllocator* allocator = graph_->GetArena();
508
509 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
510 // and the returned block is the start of the then branch (that could contain multiple blocks).
511 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
512
513 // Split the block containing the invoke before and after the invoke. The returned block
514 // of the split before will contain the invoke and will be the otherwise branch of
515 // the diamond. The returned block of the split after will be the merge block
516 // of the diamond.
517 HBasicBlock* end_then = invoke_instruction->GetBlock();
518 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
519 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
520
521 // If the methods we are inlining return a value, we create a phi in the merge block
522 // that will have the `invoke_instruction and the `return_replacement` as inputs.
523 if (return_replacement != nullptr) {
524 HPhi* phi = new (allocator) HPhi(
525 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
526 merge->AddPhi(phi);
527 invoke_instruction->ReplaceWith(phi);
528 phi->AddInput(return_replacement);
529 phi->AddInput(invoke_instruction);
530 }
531
532 // Add the control flow instructions.
533 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
534 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
535 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
536
537 // Add the newly created blocks to the graph.
538 graph_->AddBlock(then);
539 graph_->AddBlock(otherwise);
540 graph_->AddBlock(merge);
541
542 // Set up successor (and implictly predecessor) relations.
543 cursor_block->AddSuccessor(otherwise);
544 cursor_block->AddSuccessor(then);
545 end_then->AddSuccessor(merge);
546 otherwise->AddSuccessor(merge);
547
548 // Set up dominance information.
549 then->SetDominator(cursor_block);
550 cursor_block->AddDominatedBlock(then);
551 otherwise->SetDominator(cursor_block);
552 cursor_block->AddDominatedBlock(otherwise);
553 merge->SetDominator(cursor_block);
554 cursor_block->AddDominatedBlock(merge);
555
556 // Update the revert post order.
557 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
558 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
559 graph_->reverse_post_order_[++index] = then;
560 index = IndexOfElement(graph_->reverse_post_order_, end_then);
561 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
562 graph_->reverse_post_order_[++index] = otherwise;
563 graph_->reverse_post_order_[++index] = merge;
564
565 // Set the loop information of the newly created blocks.
566 HLoopInformation* loop_info = cursor_block->GetLoopInformation();
567 if (loop_info != nullptr) {
568 then->SetLoopInformation(cursor_block->GetLoopInformation());
569 merge->SetLoopInformation(cursor_block->GetLoopInformation());
570 otherwise->SetLoopInformation(cursor_block->GetLoopInformation());
571 for (HLoopInformationOutwardIterator loop_it(*cursor_block);
572 !loop_it.Done();
573 loop_it.Advance()) {
574 loop_it.Current()->Add(then);
575 loop_it.Current()->Add(merge);
576 loop_it.Current()->Add(otherwise);
577 }
578 // In case the original invoke location was a back edge, we need to update
579 // the loop to now have the merge block as a back edge.
580 if (loop_info->IsBackEdge(*original_invoke_block)) {
581 loop_info->RemoveBackEdge(original_invoke_block);
582 loop_info->AddBackEdge(merge);
583 }
584 }
585
586 // Set the try/catch information of the newly created blocks.
587 then->SetTryCatchInformation(cursor_block->GetTryCatchInformation());
588 merge->SetTryCatchInformation(cursor_block->GetTryCatchInformation());
589 otherwise->SetTryCatchInformation(cursor_block->GetTryCatchInformation());
590}
591
592bool HInliner::TryInlinePolymorphicCallToSameTarget(HInvoke* invoke_instruction,
593 ArtMethod* resolved_method,
594 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000595 // This optimization only works under JIT for now.
596 DCHECK(Runtime::Current()->UseJit());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000597 if (graph_->GetInstructionSet() == kMips64) {
598 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000599 return false;
600 }
601 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
602 size_t pointer_size = class_linker->GetImagePointerSize();
603
604 DCHECK(resolved_method != nullptr);
605 ArtMethod* actual_method = nullptr;
606 // Check whether we are actually calling the same method among
607 // the different types seen.
608 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
609 if (ic.GetTypeAt(i) == nullptr) {
610 break;
611 }
612 ArtMethod* new_method = nullptr;
613 if (invoke_instruction->IsInvokeInterface()) {
614 new_method = ic.GetTypeAt(i)->FindVirtualMethodForInterface(
615 resolved_method, pointer_size);
616 } else {
617 DCHECK(invoke_instruction->IsInvokeVirtual());
618 new_method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual(
619 resolved_method, pointer_size);
620 }
621 if (actual_method == nullptr) {
622 actual_method = new_method;
623 } else if (actual_method != new_method) {
624 // Different methods, bailout.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000625 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
626 << " from inline cache is not inlined because it resolves"
627 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000628 return false;
629 }
630 }
631
632 HInstruction* receiver = invoke_instruction->InputAt(0);
633 HInstruction* cursor = invoke_instruction->GetPrevious();
634 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
635
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000636 if (!TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ false)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000637 return false;
638 }
639
640 // We successfully inlined, now add a guard.
641 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
642 class_linker, receiver, invoke_instruction->GetDexPc());
643
644 size_t method_offset = invoke_instruction->IsInvokeVirtual()
645 ? actual_method->GetVtableIndex()
646 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
647
648 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
649 ? Primitive::kPrimLong
650 : Primitive::kPrimInt;
651 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
652 receiver_class,
653 type,
654 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::kVTable : HClassTableGet::kIMTable,
655 method_offset,
656 invoke_instruction->GetDexPc());
657
658 HConstant* constant;
659 if (type == Primitive::kPrimLong) {
660 constant = graph_->GetLongConstant(
661 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
662 } else {
663 constant = graph_->GetIntConstant(
664 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
665 }
666
667 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
668 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
669 compare, invoke_instruction->GetDexPc());
670 // TODO: Extend reference type propagation to understand the guard.
671 if (cursor != nullptr) {
672 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
673 } else {
674 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
675 }
676 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
677 bb_cursor->InsertInstructionAfter(compare, class_table_get);
678 bb_cursor->InsertInstructionAfter(deoptimize, compare);
679 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
680
681 // Run type propagation to get the guard typed.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000682 ReferenceTypePropagation rtp_fixup(graph_, handles_, /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000683 rtp_fixup.Run();
684
685 MaybeRecordStat(kInlinedPolymorphicCall);
686
687 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100688}
689
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000690bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
691 HInstruction* return_replacement = nullptr;
692 if (!TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
693 return false;
694 }
695 if (return_replacement != nullptr) {
696 invoke_instruction->ReplaceWith(return_replacement);
697 }
698 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
699 FixUpReturnReferenceType(invoke_instruction, method, return_replacement, do_rtp);
700 return true;
701}
702
703bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
704 ArtMethod* method,
705 HInstruction** return_replacement) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100706 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Jeff Haodcdc85b2015-12-04 14:06:18 -0800707
708 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
709 // dex file here (though the transitivity of an inline chain would allow checking the calller).
710 if (!compiler_driver_->MayInline(method->GetDexFile(),
711 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000712 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000713 VLOG(compiler) << "Successfully replaced pattern of invoke " << PrettyMethod(method);
714 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
715 return true;
716 }
Jeff Haodcdc85b2015-12-04 14:06:18 -0800717 VLOG(compiler) << "Won't inline " << PrettyMethod(method) << " in "
718 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
719 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
720 << method->GetDexFile()->GetLocation();
721 return false;
722 }
723
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100724 uint32_t method_index = FindMethodIndexIn(
725 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
726 if (method_index == DexFile::kDexNoIndex) {
727 VLOG(compiler) << "Call to "
728 << PrettyMethod(method)
729 << " cannot be inlined because unaccessible to caller";
730 return false;
731 }
732
733 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
734
735 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000736
737 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100738 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000739 << " is not inlined because it is native";
740 return false;
741 }
742
Calin Juravleec748352015-07-29 13:52:12 +0100743 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
744 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100745 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000746 << " is too big to inline: "
747 << code_item->insns_size_in_code_units_
748 << " > "
749 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000750 return false;
751 }
752
753 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100754 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000755 << " is not inlined because of try block";
756 return false;
757 }
758
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100759 if (!method->GetDeclaringClass()->IsVerified()) {
760 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000761 if (Runtime::Current()->UseJit() ||
762 !compiler_driver_->IsMethodVerifiedWithoutFailures(
763 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100764 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
765 << " couldn't be verified, so it cannot be inlined";
766 return false;
767 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000768 }
769
Roland Levillain4c0eb422015-04-24 16:43:49 +0100770 if (invoke_instruction->IsInvokeStaticOrDirect() &&
771 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
772 // Case of a static method that cannot be inlined because it implicitly
773 // requires an initialization check of its declaring class.
774 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
775 << " is not inlined because it is static and requires a clinit"
776 << " check that cannot be emitted due to Dex cache limitations";
777 return false;
778 }
779
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000780 if (!TryBuildAndInlineHelper(invoke_instruction, method, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000781 return false;
782 }
783
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000784 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000785 MaybeRecordStat(kInlinedInvoke);
786 return true;
787}
788
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000789static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
790 size_t arg_vreg_index)
791 SHARED_REQUIRES(Locks::mutator_lock_) {
792 size_t input_index = 0;
793 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
794 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
795 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
796 ++i;
797 DCHECK_NE(i, arg_vreg_index);
798 }
799 }
800 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
801 return invoke_instruction->InputAt(input_index);
802}
803
804// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
805bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
806 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000807 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000808 InlineMethod inline_method;
809 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
810 return false;
811 }
812
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000813 switch (inline_method.opcode) {
814 case kInlineOpNop:
815 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000816 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000817 break;
818 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000819 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
820 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000821 break;
822 case kInlineOpNonWideConst:
823 if (resolved_method->GetShorty()[0] == 'L') {
824 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000825 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000826 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000827 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000828 }
829 break;
830 case kInlineOpIGet: {
831 const InlineIGetIPutData& data = inline_method.d.ifield_data;
832 if (data.method_is_static || data.object_arg != 0u) {
833 // TODO: Needs null check.
834 return false;
835 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000836 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000837 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000838 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000839 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
840 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
841 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000842 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000843 break;
844 }
845 case kInlineOpIPut: {
846 const InlineIGetIPutData& data = inline_method.d.ifield_data;
847 if (data.method_is_static || data.object_arg != 0u) {
848 // TODO: Needs null check.
849 return false;
850 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000851 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000852 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
853 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000854 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000855 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
856 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
857 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
858 if (data.return_arg_plus1 != 0u) {
859 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000860 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000861 }
862 break;
863 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000864 case kInlineOpConstructor: {
865 const InlineConstructorData& data = inline_method.d.constructor_data;
866 // Get the indexes to arrays for easier processing.
867 uint16_t iput_field_indexes[] = {
868 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
869 };
870 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
871 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
872 // Count valid field indexes.
873 size_t number_of_iputs = 0u;
874 while (number_of_iputs != arraysize(iput_field_indexes) &&
875 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
876 // Check that there are no duplicate valid field indexes.
877 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
878 iput_field_indexes + arraysize(iput_field_indexes),
879 iput_field_indexes[number_of_iputs]));
880 ++number_of_iputs;
881 }
882 // Check that there are no valid field indexes in the rest of the array.
883 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
884 iput_field_indexes + arraysize(iput_field_indexes),
885 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
886
887 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
888 Handle<mirror::DexCache> dex_cache;
889 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
890 bool needs_constructor_barrier = false;
891 for (size_t i = 0; i != number_of_iputs; ++i) {
892 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
893 if (!value->IsConstant() ||
894 (!value->AsConstant()->IsZero() && !value->IsNullConstant())) {
895 if (dex_cache.GetReference() == nullptr) {
896 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
897 }
898 uint16_t field_index = iput_field_indexes[i];
899 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
900 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
901
902 // Check whether the field is final. If it is, we need to add a barrier.
903 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
904 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
905 DCHECK(resolved_field != nullptr);
906 if (resolved_field->IsFinal()) {
907 needs_constructor_barrier = true;
908 }
909 }
910 }
911 if (needs_constructor_barrier) {
912 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
913 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
914 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000915 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +0000916 break;
917 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000918 default:
919 LOG(FATAL) << "UNREACHABLE";
920 UNREACHABLE();
921 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000922 return true;
923}
924
Vladimir Marko354efa62016-02-04 19:46:56 +0000925HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000926 uint32_t field_index,
927 HInstruction* obj)
928 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000929 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
930 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
931 DCHECK(resolved_field != nullptr);
932 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
933 obj,
934 resolved_field->GetTypeAsPrimitiveType(),
935 resolved_field->GetOffset(),
936 resolved_field->IsVolatile(),
937 field_index,
938 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +0000939 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000940 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +0000941 // Read barrier generates a runtime call in slow path and we need a valid
942 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
943 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000944 if (iget->GetType() == Primitive::kPrimNot) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000945 ReferenceTypePropagation rtp(graph_, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000946 rtp.Visit(iget);
947 }
948 return iget;
949}
950
Vladimir Marko354efa62016-02-04 19:46:56 +0000951HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000952 uint32_t field_index,
953 HInstruction* obj,
954 HInstruction* value)
955 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000956 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
957 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
958 DCHECK(resolved_field != nullptr);
959 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
960 obj,
961 value,
962 resolved_field->GetTypeAsPrimitiveType(),
963 resolved_field->GetOffset(),
964 resolved_field->IsVolatile(),
965 field_index,
966 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +0000967 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000968 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +0000969 // Read barrier generates a runtime call in slow path and we need a valid
970 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
971 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000972 return iput;
973}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000974
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000975bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
976 ArtMethod* resolved_method,
977 bool same_dex_file,
978 HInstruction** return_replacement) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000979 ScopedObjectAccess soa(Thread::Current());
980 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100981 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
982 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +0000983 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700984 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000985 DexCompilationUnit dex_compilation_unit(
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000986 nullptr,
987 caller_compilation_unit_.GetClassLoader(),
988 class_linker,
989 callee_dex_file,
990 code_item,
991 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
992 method_index,
993 resolved_method->GetAccessFlags(),
994 /* verified_method */ nullptr,
995 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000996
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100997 bool requires_ctor_barrier = false;
998
999 if (dex_compilation_unit.IsConstructor()) {
1000 // If it's a super invocation and we already generate a barrier there's no need
1001 // to generate another one.
1002 // We identify super calls by looking at the "this" pointer. If its value is the
1003 // same as the local "this" pointer then we must have a super invocation.
1004 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1005 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1006 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1007 requires_ctor_barrier = false;
1008 } else {
1009 Thread* self = Thread::Current();
1010 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1011 dex_compilation_unit.GetDexFile(),
1012 dex_compilation_unit.GetClassDefIndex());
1013 }
1014 }
1015
Nicolas Geoffray35071052015-06-09 15:43:38 +01001016 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
1017 if (invoke_type == kInterface) {
1018 // We have statically resolved the dispatch. To please the class linker
1019 // at runtime, we change this call as if it was a virtual call.
1020 invoke_type = kVirtual;
1021 }
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001022 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001023 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001024 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001025 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001026 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001027 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001028 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001029 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001030 /* osr */ false,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001031 graph_->GetCurrentInstructionId());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001032 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001033
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001034 OptimizingCompilerStats inline_stats;
David Brazdil5e8b1372015-01-23 14:39:08 +00001035 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001036 &dex_compilation_unit,
1037 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001038 resolved_method->GetDexFile(),
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001039 compiler_driver_,
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001040 &inline_stats,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001041 resolved_method->GetQuickenedInfo(),
1042 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001043
David Brazdilbadd8262016-02-02 16:28:56 +00001044 if (builder.BuildGraph(*code_item, handles_) != kAnalysisSuccess) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001045 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001046 << " could not be built, so cannot be inlined";
1047 return false;
1048 }
1049
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001050 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1051 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001052 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001053 << " cannot be inlined because of the register allocator";
1054 return false;
1055 }
1056
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001057 size_t parameter_index = 0;
1058 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1059 !instructions.Done();
1060 instructions.Advance()) {
1061 HInstruction* current = instructions.Current();
1062 if (current->IsParameterValue()) {
1063 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
1064 if (argument->IsNullConstant()) {
1065 current->ReplaceWith(callee_graph->GetNullConstant());
1066 } else if (argument->IsIntConstant()) {
1067 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1068 } else if (argument->IsLongConstant()) {
1069 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1070 } else if (argument->IsFloatConstant()) {
1071 current->ReplaceWith(
1072 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1073 } else if (argument->IsDoubleConstant()) {
1074 current->ReplaceWith(
1075 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1076 } else if (argument->GetType() == Primitive::kPrimNot) {
1077 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1078 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1079 }
1080 }
1081 }
1082
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001083 // Run simple optimizations on the graph.
Calin Juravle7a9c8852015-04-21 14:07:50 +01001084 HDeadCodeElimination dce(callee_graph, stats_);
Nicolas Geoffraye34648d2015-11-23 08:59:07 +00001085 HConstantFolding fold(callee_graph);
Vladimir Markodc151b22015-10-15 18:02:30 +01001086 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
Calin Juravleacf735c2015-02-12 15:25:22 +00001087 InstructionSimplifier simplify(callee_graph, stats_);
Jean-Philippe Halimi38e9e802016-02-18 16:42:03 +01001088 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_, stats_);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001089
1090 HOptimization* optimizations[] = {
Scott Wakelingd60a1af2015-07-22 14:32:44 +01001091 &intrinsics,
Vladimir Markodc151b22015-10-15 18:02:30 +01001092 &sharpening,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001093 &simplify,
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001094 &fold,
Vladimir Marko9e23df52015-11-10 17:14:35 +00001095 &dce,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001096 };
1097
1098 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1099 HOptimization* optimization = optimizations[i];
1100 optimization->Run();
1101 }
1102
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001103 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Calin Juravleec748352015-07-29 13:52:12 +01001104 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001105 HInliner inliner(callee_graph,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001106 outermost_graph_,
Vladimir Markodc151b22015-10-15 18:02:30 +01001107 codegen_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001108 outer_compilation_unit_,
1109 dex_compilation_unit,
1110 compiler_driver_,
Nicolas Geoffray454a4812015-06-09 10:37:32 +01001111 handles_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001112 stats_,
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001113 total_number_of_dex_registers_ + code_item->registers_size_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001114 depth_ + 1);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001115 inliner.Run();
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001116 number_of_instructions_budget += inliner.number_of_inlined_instructions_;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001117 }
1118
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001119 // TODO: We should abort only if all predecessors throw. However,
1120 // HGraph::InlineInto currently does not handle an exit block with
1121 // a throw predecessor.
1122 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1123 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001124 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001125 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001126 return false;
1127 }
1128
1129 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001130 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1131 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001132 has_throw_predecessor = true;
1133 break;
1134 }
1135 }
1136 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001137 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001138 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001139 return false;
1140 }
1141
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001142 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001143 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001144 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001145
1146 bool can_inline_environment =
1147 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1148
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001149 for (; !it.Done(); it.Advance()) {
1150 HBasicBlock* block = it.Current();
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001151
1152 if (block->IsLoopHeader() && block->GetLoopInformation()->IsIrreducible()) {
1153 // Don't inline methods with irreducible loops, they could prevent some
1154 // optimizations to run.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001155 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001156 << " could not be inlined because it contains an irreducible loop";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001157 return false;
1158 }
1159
1160 for (HInstructionIterator instr_it(block->GetInstructions());
1161 !instr_it.Done();
1162 instr_it.Advance()) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001163 if (number_of_instructions++ == number_of_instructions_budget) {
1164 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001165 << " is not inlined because its caller has reached"
1166 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001167 return false;
1168 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001169 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001170 if (!can_inline_environment && current->NeedsEnvironment()) {
1171 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1172 << " is not inlined because its caller has reached"
1173 << " its environment budget limit.";
1174 return false;
1175 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001176
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001177 if (current->IsInvokeInterface()) {
1178 // Disable inlining of interface calls. The cost in case of entering the
1179 // resolution conflict is currently too high.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001180 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001181 << " could not be inlined because it has an interface call.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001182 return false;
1183 }
1184
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001185 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001186 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001187 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001188 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001189 return false;
1190 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001191
Vladimir Markodc151b22015-10-15 18:02:30 +01001192 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001193 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001194 << " could not be inlined because " << current->DebugName()
1195 << " it is in a different dex file and requires access to the dex cache";
1196 return false;
1197 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001198
1199 if (current->IsNewInstance() &&
1200 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001201 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1202 << " could not be inlined because it is using an entrypoint"
1203 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001204 // Allocation entrypoint does not handle inlined frames.
1205 return false;
1206 }
1207
1208 if (current->IsNewArray() &&
1209 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001210 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1211 << " could not be inlined because it is using an entrypoint"
1212 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001213 // Allocation entrypoint does not handle inlined frames.
1214 return false;
1215 }
1216
1217 if (current->IsUnresolvedStaticFieldGet() ||
1218 current->IsUnresolvedInstanceFieldGet() ||
1219 current->IsUnresolvedStaticFieldSet() ||
1220 current->IsUnresolvedInstanceFieldSet()) {
1221 // Entrypoint for unresolved fields does not handle inlined frames.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001222 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1223 << " could not be inlined because it is using an unresolved"
1224 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001225 return false;
1226 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001227 }
1228 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001229 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001230
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001231 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001232 return true;
1233}
Calin Juravle2e768302015-07-28 14:41:11 +00001234
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001235void HInliner::FixUpReturnReferenceType(HInvoke* invoke_instruction,
1236 ArtMethod* resolved_method,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001237 HInstruction* return_replacement,
1238 bool do_rtp) {
Alex Light68289a52015-12-15 17:30:30 -08001239 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001240 if (return_replacement != nullptr) {
1241 if (return_replacement->GetType() == Primitive::kPrimNot) {
1242 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1243 // Make sure that we have a valid type for the return. We may get an invalid one when
1244 // we inline invokes with multiple branches and create a Phi for the result.
1245 // TODO: we could be more precise by merging the phi inputs but that requires
1246 // some functionality from the reference type propagation.
1247 DCHECK(return_replacement->IsPhi());
1248 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
1249 ReferenceTypeInfo::TypeHandle return_handle =
1250 handles_->NewHandle(resolved_method->GetReturnType(true /* resolve */, pointer_size));
1251 return_replacement->SetReferenceTypeInfo(ReferenceTypeInfo::Create(
1252 return_handle, return_handle->CannotBeAssignedFromOtherTypes() /* is_exact */));
1253 }
Alex Light68289a52015-12-15 17:30:30 -08001254
David Brazdil4833f5a2015-12-16 10:37:39 +00001255 if (do_rtp) {
1256 // If the return type is a refinement of the declared type run the type propagation again.
1257 ReferenceTypeInfo return_rti = return_replacement->GetReferenceTypeInfo();
1258 ReferenceTypeInfo invoke_rti = invoke_instruction->GetReferenceTypeInfo();
1259 if (invoke_rti.IsStrictSupertypeOf(return_rti)
1260 || (return_rti.IsExact() && !invoke_rti.IsExact())
1261 || !return_replacement->CanBeNull()) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001262 ReferenceTypePropagation(graph_, handles_, /* is_first_run */ false).Run();
David Brazdil4833f5a2015-12-16 10:37:39 +00001263 }
1264 }
1265 } else if (return_replacement->IsInstanceOf()) {
1266 if (do_rtp) {
1267 // Inlining InstanceOf into an If may put a tighter bound on reference types.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001268 ReferenceTypePropagation(graph_, handles_, /* is_first_run */ false).Run();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001269 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001270 }
Calin Juravle2e768302015-07-28 14:41:11 +00001271 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001272}
1273
1274} // namespace art