blob: 333126b9b3924f24dd4ca2eff703e1ee3dfd7aec [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "compiler_internals.h"
18#include "local_value_numbering.h"
Ian Rogers8d3a1172013-06-04 01:13:28 -070019#include "dataflow_iterator-inl.h"
buzbee311ca162013-02-28 15:56:43 -080020
21namespace art {
22
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070023static unsigned int Predecessors(BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -070024 return bb->predecessors->Size();
buzbee311ca162013-02-28 15:56:43 -080025}
26
27/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070028void MIRGraph::SetConstant(int32_t ssa_reg, int value) {
buzbee862a7602013-04-05 10:58:54 -070029 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080030 constant_values_[ssa_reg] = value;
31}
32
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070033void MIRGraph::SetConstantWide(int ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070034 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080035 constant_values_[ssa_reg] = Low32Bits(value);
36 constant_values_[ssa_reg + 1] = High32Bits(value);
37}
38
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080039void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080040 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080041
42 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
buzbee1da1e2f2013-11-15 13:37:01 -080043 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -080044
45 DecodedInstruction *d_insn = &mir->dalvikInsn;
46
47 if (!(df_attributes & DF_HAS_DEFS)) continue;
48
49 /* Handle instructions that set up constants directly */
50 if (df_attributes & DF_SETS_CONST) {
51 if (df_attributes & DF_DA) {
52 int32_t vB = static_cast<int32_t>(d_insn->vB);
53 switch (d_insn->opcode) {
54 case Instruction::CONST_4:
55 case Instruction::CONST_16:
56 case Instruction::CONST:
57 SetConstant(mir->ssa_rep->defs[0], vB);
58 break;
59 case Instruction::CONST_HIGH16:
60 SetConstant(mir->ssa_rep->defs[0], vB << 16);
61 break;
62 case Instruction::CONST_WIDE_16:
63 case Instruction::CONST_WIDE_32:
64 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
65 break;
66 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070067 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080068 break;
69 case Instruction::CONST_WIDE_HIGH16:
70 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
71 break;
72 default:
73 break;
74 }
75 }
76 /* Handle instructions that set up constants directly */
77 } else if (df_attributes & DF_IS_MOVE) {
78 int i;
79
80 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070081 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080082 }
83 /* Move a register holding a constant to another register */
84 if (i == mir->ssa_rep->num_uses) {
85 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
86 if (df_attributes & DF_A_WIDE) {
87 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
88 }
89 }
90 }
91 }
92 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -080093}
94
buzbee311ca162013-02-28 15:56:43 -080095/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -070096MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -080097 BasicBlock* bb = *p_bb;
98 if (mir != NULL) {
99 mir = mir->next;
100 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700101 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800102 if ((bb == NULL) || Predecessors(bb) != 1) {
103 mir = NULL;
104 } else {
105 *p_bb = bb;
106 mir = bb->first_mir_insn;
107 }
108 }
109 }
110 return mir;
111}
112
113/*
114 * To be used at an invoke mir. If the logically next mir node represents
115 * a move-result, return it. Else, return NULL. If a move-result exists,
116 * it is required to immediately follow the invoke with no intervening
117 * opcodes or incoming arcs. However, if the result of the invoke is not
118 * used, a move-result may not be present.
119 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700120MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800121 BasicBlock* tbb = bb;
122 mir = AdvanceMIR(&tbb, mir);
123 while (mir != NULL) {
124 int opcode = mir->dalvikInsn.opcode;
125 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
126 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
127 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
128 break;
129 }
130 // Keep going if pseudo op, otherwise terminate
131 if (opcode < kNumPackedOpcodes) {
132 mir = NULL;
133 } else {
134 mir = AdvanceMIR(&tbb, mir);
135 }
136 }
137 return mir;
138}
139
buzbee0d829482013-10-11 15:24:55 -0700140BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800141 if (bb->block_type == kDead) {
142 return NULL;
143 }
144 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
145 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700146 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
147 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800148 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700149 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700150 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700151 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700152 } else {
153 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700154 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700155 }
buzbee311ca162013-02-28 15:56:43 -0800156 if (bb == NULL || (Predecessors(bb) != 1)) {
157 return NULL;
158 }
159 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
160 return bb;
161}
162
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700163static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800164 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
165 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
166 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
167 if (mir->ssa_rep->uses[i] == ssa_name) {
168 return mir;
169 }
170 }
171 }
172 }
173 return NULL;
174}
175
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700176static SelectInstructionKind SelectKind(MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800177 switch (mir->dalvikInsn.opcode) {
178 case Instruction::MOVE:
179 case Instruction::MOVE_OBJECT:
180 case Instruction::MOVE_16:
181 case Instruction::MOVE_OBJECT_16:
182 case Instruction::MOVE_FROM16:
183 case Instruction::MOVE_OBJECT_FROM16:
184 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700185 case Instruction::CONST:
186 case Instruction::CONST_4:
187 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800188 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700189 case Instruction::GOTO:
190 case Instruction::GOTO_16:
191 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800192 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700193 default:
194 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800195 }
buzbee311ca162013-02-28 15:56:43 -0800196}
197
Vladimir Markoa1a70742014-03-03 10:28:05 +0000198static constexpr ConditionCode kIfCcZConditionCodes[] = {
199 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
200};
201
202COMPILE_ASSERT(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
203 if_ccz_ccodes_size1);
204
205static constexpr bool IsInstructionIfCcZ(Instruction::Code opcode) {
206 return Instruction::IF_EQZ <= opcode && opcode <= Instruction::IF_LEZ;
207}
208
209static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
210 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
211}
212
213COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, check_if_eqz_ccode);
214COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, check_if_nez_ccode);
215COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, check_if_ltz_ccode);
216COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, check_if_gez_ccode);
217COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, check_if_gtz_ccode);
218COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, check_if_lez_ccode);
219
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700220int MIRGraph::GetSSAUseCount(int s_reg) {
buzbee862a7602013-04-05 10:58:54 -0700221 return raw_use_counts_.Get(s_reg);
buzbee311ca162013-02-28 15:56:43 -0800222}
223
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800224size_t MIRGraph::GetNumAvailableNonSpecialCompilerTemps() {
225 if (num_non_special_compiler_temps_ >= max_available_non_special_compiler_temps_) {
226 return 0;
227 } else {
228 return max_available_non_special_compiler_temps_ - num_non_special_compiler_temps_;
229 }
230}
231
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000232
233// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800234static const RegLocation temp_loc = {kLocCompilerTemp,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000235 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/, kVectorNotUsed,
236 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800237
238CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
239 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
240 if (ct_type == kCompilerTempVR) {
241 size_t available_temps = GetNumAvailableNonSpecialCompilerTemps();
242 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
243 return 0;
244 }
245 }
246
247 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000248 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800249
250 // Create the type of temp requested. Special temps need special handling because
251 // they have a specific virtual register assignment.
252 if (ct_type == kCompilerTempSpecialMethodPtr) {
253 DCHECK_EQ(wide, false);
254 compiler_temp->v_reg = static_cast<int>(kVRegMethodPtrBaseReg);
255 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
256
257 // The MIR graph keeps track of the sreg for method pointer specially, so record that now.
258 method_sreg_ = compiler_temp->s_reg_low;
259 } else {
260 DCHECK_EQ(ct_type, kCompilerTempVR);
261
262 // The new non-special compiler temp must receive a unique v_reg with a negative value.
263 compiler_temp->v_reg = static_cast<int>(kVRegNonSpecialTempBaseReg) - num_non_special_compiler_temps_;
264 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
265 num_non_special_compiler_temps_++;
266
267 if (wide) {
268 // Ensure that the two registers are consecutive. Since the virtual registers used for temps grow in a
269 // negative fashion, we need the smaller to refer to the low part. Thus, we redefine the v_reg and s_reg_low.
270 compiler_temp->v_reg--;
271 int ssa_reg_high = compiler_temp->s_reg_low;
272 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
273 int ssa_reg_low = compiler_temp->s_reg_low;
274
275 // If needed initialize the register location for the high part.
276 // The low part is handled later in this method on a common path.
277 if (reg_location_ != nullptr) {
278 reg_location_[ssa_reg_high] = temp_loc;
279 reg_location_[ssa_reg_high].high_word = 1;
280 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
281 reg_location_[ssa_reg_high].wide = true;
282
283 // A new SSA needs new use counts.
284 use_counts_.Insert(0);
285 raw_use_counts_.Insert(0);
286 }
287
288 num_non_special_compiler_temps_++;
289 }
290 }
291
292 // Have we already allocated the register locations?
293 if (reg_location_ != nullptr) {
294 int ssa_reg_low = compiler_temp->s_reg_low;
295 reg_location_[ssa_reg_low] = temp_loc;
296 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
297 reg_location_[ssa_reg_low].wide = wide;
298
299 // A new SSA needs new use counts.
300 use_counts_.Insert(0);
301 raw_use_counts_.Insert(0);
302 }
303
304 compiler_temps_.Insert(compiler_temp);
305 return compiler_temp;
306}
buzbee311ca162013-02-28 15:56:43 -0800307
308/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700309bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800310 if (bb->block_type == kDead) {
311 return true;
312 }
buzbee1da1e2f2013-11-15 13:37:01 -0800313 bool use_lvn = bb->use_lvn;
314 UniquePtr<LocalValueNumbering> local_valnum;
315 if (use_lvn) {
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000316 local_valnum.reset(LocalValueNumbering::Create(cu_));
buzbee1da1e2f2013-11-15 13:37:01 -0800317 }
buzbee311ca162013-02-28 15:56:43 -0800318 while (bb != NULL) {
319 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
320 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800321 if (use_lvn) {
322 local_valnum->GetValueNumber(mir);
323 }
buzbee311ca162013-02-28 15:56:43 -0800324 // Look for interesting opcodes, skip otherwise
325 Instruction::Code opcode = mir->dalvikInsn.opcode;
326 switch (opcode) {
327 case Instruction::CMPL_FLOAT:
328 case Instruction::CMPL_DOUBLE:
329 case Instruction::CMPG_FLOAT:
330 case Instruction::CMPG_DOUBLE:
331 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700332 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800333 // Bitcode doesn't allow this optimization.
334 break;
335 }
336 if (mir->next != NULL) {
337 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800338 // Make sure result of cmp is used by next insn and nowhere else
Vladimir Markoa1a70742014-03-03 10:28:05 +0000339 if (IsInstructionIfCcZ(mir->next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800340 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
341 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000342 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700343 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800344 case Instruction::CMPL_FLOAT:
345 mir_next->dalvikInsn.opcode =
346 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
347 break;
348 case Instruction::CMPL_DOUBLE:
349 mir_next->dalvikInsn.opcode =
350 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
351 break;
352 case Instruction::CMPG_FLOAT:
353 mir_next->dalvikInsn.opcode =
354 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
355 break;
356 case Instruction::CMPG_DOUBLE:
357 mir_next->dalvikInsn.opcode =
358 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
359 break;
360 case Instruction::CMP_LONG:
361 mir_next->dalvikInsn.opcode =
362 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
363 break;
364 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
365 }
366 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
367 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
368 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
369 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
370 mir_next->ssa_rep->num_defs = 0;
371 mir->ssa_rep->num_uses = 0;
372 mir->ssa_rep->num_defs = 0;
373 }
374 }
375 break;
376 case Instruction::GOTO:
377 case Instruction::GOTO_16:
378 case Instruction::GOTO_32:
379 case Instruction::IF_EQ:
380 case Instruction::IF_NE:
381 case Instruction::IF_LT:
382 case Instruction::IF_GE:
383 case Instruction::IF_GT:
384 case Instruction::IF_LE:
385 case Instruction::IF_EQZ:
386 case Instruction::IF_NEZ:
387 case Instruction::IF_LTZ:
388 case Instruction::IF_GEZ:
389 case Instruction::IF_GTZ:
390 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700391 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700392 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
393 (IsBackedge(bb, bb->fall_through) &&
394 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800395 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
396 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700397 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
398 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800399 }
400 }
401 break;
402 default:
403 break;
404 }
405 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800406 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800407 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000408 if (!cu_->compiler->IsPortable() &&
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800409 (cu_->instruction_set == kThumb2 || cu_->instruction_set == kX86) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000410 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700411 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800412 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700413 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
414 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800415
buzbee0d829482013-10-11 15:24:55 -0700416 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800417 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700418 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
419 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800420
421 /*
422 * In the select pattern, the taken edge goes to a block that unconditionally
423 * transfers to the rejoin block and the fall_though edge goes to a block that
424 * unconditionally falls through to the rejoin block.
425 */
426 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
427 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
428 /*
429 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
430 * suspend check on the taken-taken branch back to the join point.
431 */
432 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
433 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
434 }
435 // Are the block bodies something we can handle?
436 if ((ft->first_mir_insn == ft->last_mir_insn) &&
437 (tk->first_mir_insn != tk->last_mir_insn) &&
438 (tk->first_mir_insn->next == tk->last_mir_insn) &&
439 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
440 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
441 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
442 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
443 // Almost there. Are the instructions targeting the same vreg?
444 MIR* if_true = tk->first_mir_insn;
445 MIR* if_false = ft->first_mir_insn;
446 // It's possible that the target of the select isn't used - skip those (rare) cases.
447 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
448 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
449 /*
450 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
451 * Phi node in the merge block and delete it (while using the SSA name
452 * of the merge as the target of the SELECT. Delete both taken and
453 * fallthrough blocks, and set fallthrough to merge block.
454 * NOTE: not updating other dataflow info (no longer used at this point).
455 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
456 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000457 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800458 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
459 bool const_form = (SelectKind(if_true) == kSelectConst);
460 if ((SelectKind(if_true) == kSelectMove)) {
461 if (IsConst(if_true->ssa_rep->uses[0]) &&
462 IsConst(if_false->ssa_rep->uses[0])) {
463 const_form = true;
464 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
465 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
466 }
467 }
468 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800469 /*
470 * TODO: If both constants are the same value, then instead of generating
471 * a select, we should simply generate a const bytecode. This should be
472 * considered after inlining which can lead to CFG of this form.
473 */
buzbee311ca162013-02-28 15:56:43 -0800474 // "true" set val in vB
475 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
476 // "false" set val in vC
477 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
478 } else {
479 DCHECK_EQ(SelectKind(if_true), kSelectMove);
480 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700481 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000482 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800483 src_ssa[0] = mir->ssa_rep->uses[0];
484 src_ssa[1] = if_true->ssa_rep->uses[0];
485 src_ssa[2] = if_false->ssa_rep->uses[0];
486 mir->ssa_rep->uses = src_ssa;
487 mir->ssa_rep->num_uses = 3;
488 }
489 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700490 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000491 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700492 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000493 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800494 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700495 // Match type of uses to def.
496 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700497 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000498 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700499 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
500 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
501 }
buzbee311ca162013-02-28 15:56:43 -0800502 /*
503 * There is usually a Phi node in the join block for our two cases. If the
504 * Phi node only contains our two cases as input, we will use the result
505 * SSA name of the Phi node as our select result and delete the Phi. If
506 * the Phi node has more than two operands, we will arbitrarily use the SSA
507 * name of the "true" path, delete the SSA name of the "false" path from the
508 * Phi node (and fix up the incoming arc list).
509 */
510 if (phi->ssa_rep->num_uses == 2) {
511 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
512 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
513 } else {
514 int dead_def = if_false->ssa_rep->defs[0];
515 int live_def = if_true->ssa_rep->defs[0];
516 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700517 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800518 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
519 if (phi->ssa_rep->uses[i] == live_def) {
520 incoming[i] = bb->id;
521 }
522 }
523 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
524 if (phi->ssa_rep->uses[i] == dead_def) {
525 int last_slot = phi->ssa_rep->num_uses - 1;
526 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
527 incoming[i] = incoming[last_slot];
528 }
529 }
530 }
531 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700532 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800533 tk->block_type = kDead;
534 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
535 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
536 }
537 }
538 }
539 }
540 }
541 }
buzbee1da1e2f2013-11-15 13:37:01 -0800542 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800543 }
544
buzbee311ca162013-02-28 15:56:43 -0800545 return true;
546}
547
buzbee311ca162013-02-28 15:56:43 -0800548/* Collect stats on number of checks removed */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700549void MIRGraph::CountChecks(struct BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700550 if (bb->data_flow_info != NULL) {
551 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
552 if (mir->ssa_rep == NULL) {
553 continue;
buzbee311ca162013-02-28 15:56:43 -0800554 }
buzbee1da1e2f2013-11-15 13:37:01 -0800555 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee862a7602013-04-05 10:58:54 -0700556 if (df_attributes & DF_HAS_NULL_CHKS) {
557 checkstats_->null_checks++;
558 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
559 checkstats_->null_checks_eliminated++;
560 }
561 }
562 if (df_attributes & DF_HAS_RANGE_CHKS) {
563 checkstats_->range_checks++;
564 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
565 checkstats_->range_checks_eliminated++;
566 }
buzbee311ca162013-02-28 15:56:43 -0800567 }
568 }
569 }
buzbee311ca162013-02-28 15:56:43 -0800570}
571
572/* Try to make common case the fallthrough path */
buzbee0d829482013-10-11 15:24:55 -0700573bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800574 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback
575 if (!bb->explicit_throw) {
576 return false;
577 }
578 BasicBlock* walker = bb;
579 while (true) {
580 // Check termination conditions
581 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
582 break;
583 }
buzbee0d829482013-10-11 15:24:55 -0700584 BasicBlock* prev = GetBasicBlock(walker->predecessors->Get(0));
buzbee311ca162013-02-28 15:56:43 -0800585 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700586 if (GetBasicBlock(prev->fall_through) == walker) {
buzbee311ca162013-02-28 15:56:43 -0800587 // Already done - return
588 break;
589 }
buzbee0d829482013-10-11 15:24:55 -0700590 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
buzbee311ca162013-02-28 15:56:43 -0800591 // Got one. Flip it and exit
592 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
593 switch (opcode) {
594 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
595 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
596 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
597 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
598 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
599 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
600 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
601 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
602 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
603 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
604 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
605 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
606 default: LOG(FATAL) << "Unexpected opcode " << opcode;
607 }
608 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700609 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800610 prev->taken = prev->fall_through;
611 prev->fall_through = t_bb;
612 break;
613 }
614 walker = prev;
615 }
616 return false;
617}
618
619/* Combine any basic blocks terminated by instructions that we now know can't throw */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800620void MIRGraph::CombineBlocks(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800621 // Loop here to allow combining a sequence of blocks
622 while (true) {
623 // Check termination conditions
624 if ((bb->first_mir_insn == NULL)
625 || (bb->data_flow_info == NULL)
626 || (bb->block_type == kExceptionHandling)
627 || (bb->block_type == kExitBlock)
628 || (bb->block_type == kDead)
buzbee0d829482013-10-11 15:24:55 -0700629 || (bb->taken == NullBasicBlockId)
630 || (GetBasicBlock(bb->taken)->block_type != kExceptionHandling)
631 || (bb->successor_block_list_type != kNotUsed)
buzbee311ca162013-02-28 15:56:43 -0800632 || (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) != kMirOpCheck)) {
633 break;
634 }
635
636 // Test the kMirOpCheck instruction
637 MIR* mir = bb->last_mir_insn;
638 // Grab the attributes from the paired opcode
639 MIR* throw_insn = mir->meta.throw_insn;
buzbee1da1e2f2013-11-15 13:37:01 -0800640 uint64_t df_attributes = oat_data_flow_attributes_[throw_insn->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -0800641 bool can_combine = true;
642 if (df_attributes & DF_HAS_NULL_CHKS) {
643 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) != 0);
644 }
645 if (df_attributes & DF_HAS_RANGE_CHKS) {
646 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
647 }
648 if (!can_combine) {
649 break;
650 }
651 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700652 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800653 DCHECK(!bb_next->catch_entry);
654 DCHECK_EQ(Predecessors(bb_next), 1U);
buzbee311ca162013-02-28 15:56:43 -0800655 // Overwrite the kOpCheck insn with the paired opcode
656 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
657 *bb->last_mir_insn = *throw_insn;
buzbee311ca162013-02-28 15:56:43 -0800658 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700659 bb->successor_block_list_type = bb_next->successor_block_list_type;
660 bb->successor_blocks = bb_next->successor_blocks;
buzbee311ca162013-02-28 15:56:43 -0800661 // Use the ending block linkage from the next block
662 bb->fall_through = bb_next->fall_through;
buzbee0d829482013-10-11 15:24:55 -0700663 GetBasicBlock(bb->taken)->block_type = kDead; // Kill the unused exception block
buzbee311ca162013-02-28 15:56:43 -0800664 bb->taken = bb_next->taken;
665 // Include the rest of the instructions
666 bb->last_mir_insn = bb_next->last_mir_insn;
667 /*
668 * If lower-half of pair of blocks to combine contained a return, move the flag
669 * to the newly combined block.
670 */
671 bb->terminated_by_return = bb_next->terminated_by_return;
672
673 /*
674 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
675 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
676 */
677
678 // Kill bb_next and remap now-dead id to parent
679 bb_next->block_type = kDead;
buzbee1fd33462013-03-25 13:40:45 -0700680 block_id_map_.Overwrite(bb_next->id, bb->id);
buzbee311ca162013-02-28 15:56:43 -0800681
682 // Now, loop back and see if we can keep going
683 }
buzbee311ca162013-02-28 15:56:43 -0800684}
685
Vladimir Markobfea9c22014-01-17 17:49:33 +0000686void MIRGraph::EliminateNullChecksAndInferTypesStart() {
687 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
688 if (kIsDebugBuild) {
689 AllNodesIterator iter(this);
690 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
691 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
692 }
693 }
694
695 DCHECK(temp_scoped_alloc_.get() == nullptr);
696 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
697 temp_bit_vector_size_ = GetNumSSARegs();
698 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
699 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapTempSSARegisterV);
700 }
701}
702
buzbee1da1e2f2013-11-15 13:37:01 -0800703/*
704 * Eliminate unnecessary null checks for a basic block. Also, while we're doing
705 * an iterative walk go ahead and perform type and size inference.
706 */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800707bool MIRGraph::EliminateNullChecksAndInferTypes(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800708 if (bb->data_flow_info == NULL) return false;
buzbee1da1e2f2013-11-15 13:37:01 -0800709 bool infer_changed = false;
710 bool do_nce = ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0);
buzbee311ca162013-02-28 15:56:43 -0800711
Vladimir Markobfea9c22014-01-17 17:49:33 +0000712 ArenaBitVector* ssa_regs_to_check = temp_bit_vector_;
buzbee1da1e2f2013-11-15 13:37:01 -0800713 if (do_nce) {
714 /*
715 * Set initial state. Be conservative with catch
716 * blocks and start with no assumptions about null check
717 * status (except for "this").
718 */
719 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000720 ssa_regs_to_check->ClearAllBits();
buzbee1da1e2f2013-11-15 13:37:01 -0800721 // Assume all ins are objects.
722 for (uint16_t in_reg = cu_->num_dalvik_registers - cu_->num_ins;
723 in_reg < cu_->num_dalvik_registers; in_reg++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000724 ssa_regs_to_check->SetBit(in_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800725 }
726 if ((cu_->access_flags & kAccStatic) == 0) {
727 // If non-static method, mark "this" as non-null
728 int this_reg = cu_->num_dalvik_registers - cu_->num_ins;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000729 ssa_regs_to_check->ClearBit(this_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800730 }
731 } else if (bb->predecessors->Size() == 1) {
732 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
Vladimir Markobfea9c22014-01-17 17:49:33 +0000733 // pred_bb must have already been processed at least once.
734 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
735 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800736 if (pred_bb->block_type == kDalvikByteCode) {
737 // Check to see if predecessor had an explicit null-check.
738 MIR* last_insn = pred_bb->last_mir_insn;
739 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
740 if (last_opcode == Instruction::IF_EQZ) {
741 if (pred_bb->fall_through == bb->id) {
742 // The fall-through of a block following a IF_EQZ, set the vA of the IF_EQZ to show that
743 // it can't be null.
Vladimir Markobfea9c22014-01-17 17:49:33 +0000744 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
buzbee1da1e2f2013-11-15 13:37:01 -0800745 }
746 } else if (last_opcode == Instruction::IF_NEZ) {
747 if (pred_bb->taken == bb->id) {
748 // The taken block following a IF_NEZ, set the vA of the IF_NEZ to show that it can't be
749 // null.
Vladimir Markobfea9c22014-01-17 17:49:33 +0000750 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
buzbee1da1e2f2013-11-15 13:37:01 -0800751 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700752 }
753 }
buzbee1da1e2f2013-11-15 13:37:01 -0800754 } else {
755 // Starting state is union of all incoming arcs
756 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
757 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
Vladimir Markobfea9c22014-01-17 17:49:33 +0000758 CHECK(pred_bb != NULL);
759 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
760 pred_bb = GetBasicBlock(iter.Next());
761 // At least one predecessor must have been processed before this bb.
762 DCHECK(pred_bb != nullptr);
763 DCHECK(pred_bb->data_flow_info != nullptr);
764 }
765 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800766 while (true) {
767 pred_bb = GetBasicBlock(iter.Next());
768 if (!pred_bb) break;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000769 DCHECK(pred_bb->data_flow_info != nullptr);
770 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
buzbee1da1e2f2013-11-15 13:37:01 -0800771 continue;
772 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000773 ssa_regs_to_check->Union(pred_bb->data_flow_info->ending_check_v);
buzbee311ca162013-02-28 15:56:43 -0800774 }
buzbee311ca162013-02-28 15:56:43 -0800775 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000776 // At this point, ssa_regs_to_check shows which sregs have an object definition with
buzbee1da1e2f2013-11-15 13:37:01 -0800777 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800778 }
779
780 // Walk through the instruction in the block, updating as necessary
781 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
782 if (mir->ssa_rep == NULL) {
783 continue;
784 }
buzbee1da1e2f2013-11-15 13:37:01 -0800785
786 // Propagate type info.
787 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
788 if (!do_nce) {
789 continue;
790 }
791
792 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -0800793
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000794 // Might need a null check?
795 if (df_attributes & DF_HAS_NULL_CHKS) {
796 int src_idx;
797 if (df_attributes & DF_NULL_CHK_1) {
798 src_idx = 1;
799 } else if (df_attributes & DF_NULL_CHK_2) {
800 src_idx = 2;
801 } else {
802 src_idx = 0;
803 }
804 int src_sreg = mir->ssa_rep->uses[src_idx];
Vladimir Markobfea9c22014-01-17 17:49:33 +0000805 if (!ssa_regs_to_check->IsBitSet(src_sreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000806 // Eliminate the null check.
807 mir->optimization_flags |= MIR_IGNORE_NULL_CHECK;
808 } else {
809 // Do the null check.
810 mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK;
811 // Mark s_reg as null-checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000812 ssa_regs_to_check->ClearBit(src_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000813 }
814 }
815
816 if ((df_attributes & DF_A_WIDE) ||
817 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
818 continue;
819 }
820
821 /*
822 * First, mark all object definitions as requiring null check.
823 * Note: we can't tell if a CONST definition might be used as an object, so treat
824 * them all as object definitions.
825 */
826 if (((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A)) ||
827 (df_attributes & DF_SETS_CONST)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000828 ssa_regs_to_check->SetBit(mir->ssa_rep->defs[0]);
buzbee4db179d2013-10-23 12:16:39 -0700829 }
830
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000831 // Now, remove mark from all object definitions we know are non-null.
832 if (df_attributes & DF_NON_NULL_DST) {
833 // Mark target of NEW* as non-null
Vladimir Markobfea9c22014-01-17 17:49:33 +0000834 ssa_regs_to_check->ClearBit(mir->ssa_rep->defs[0]);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000835 }
836
buzbee311ca162013-02-28 15:56:43 -0800837 // Mark non-null returns from invoke-style NEW*
838 if (df_attributes & DF_NON_NULL_RET) {
839 MIR* next_mir = mir->next;
840 // Next should be an MOVE_RESULT_OBJECT
841 if (next_mir &&
842 next_mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
843 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000844 ssa_regs_to_check->ClearBit(next_mir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800845 } else {
846 if (next_mir) {
847 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee0d829482013-10-11 15:24:55 -0700848 } else if (bb->fall_through != NullBasicBlockId) {
buzbee311ca162013-02-28 15:56:43 -0800849 // Look in next basic block
buzbee0d829482013-10-11 15:24:55 -0700850 struct BasicBlock* next_bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800851 for (MIR* tmir = next_bb->first_mir_insn; tmir != NULL;
852 tmir =tmir->next) {
853 if (static_cast<int>(tmir->dalvikInsn.opcode) >= static_cast<int>(kMirOpFirst)) {
854 continue;
855 }
856 // First non-pseudo should be MOVE_RESULT_OBJECT
857 if (tmir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
858 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000859 ssa_regs_to_check->ClearBit(tmir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800860 } else {
861 LOG(WARNING) << "Unexpected op after new: " << tmir->dalvikInsn.opcode;
862 }
863 break;
864 }
865 }
866 }
867 }
868
869 /*
870 * Propagate nullcheck state on register copies (including
871 * Phi pseudo copies. For the latter, nullcheck state is
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000872 * the "or" of all the Phi's operands.
buzbee311ca162013-02-28 15:56:43 -0800873 */
874 if (df_attributes & (DF_NULL_TRANSFER_0 | DF_NULL_TRANSFER_N)) {
875 int tgt_sreg = mir->ssa_rep->defs[0];
876 int operands = (df_attributes & DF_NULL_TRANSFER_0) ? 1 :
877 mir->ssa_rep->num_uses;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000878 bool needs_null_check = false;
buzbee311ca162013-02-28 15:56:43 -0800879 for (int i = 0; i < operands; i++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000880 needs_null_check |= ssa_regs_to_check->IsBitSet(mir->ssa_rep->uses[i]);
buzbee311ca162013-02-28 15:56:43 -0800881 }
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000882 if (needs_null_check) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000883 ssa_regs_to_check->SetBit(tgt_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000884 } else {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000885 ssa_regs_to_check->ClearBit(tgt_sreg);
buzbee311ca162013-02-28 15:56:43 -0800886 }
887 }
buzbee311ca162013-02-28 15:56:43 -0800888 }
889
890 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +0000891 bool nce_changed = false;
892 if (do_nce) {
893 if (bb->data_flow_info->ending_check_v == nullptr) {
894 DCHECK(temp_scoped_alloc_.get() != nullptr);
895 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
896 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapNullCheck);
897 nce_changed = ssa_regs_to_check->GetHighestBitSet() != -1;
898 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
899 } else if (!ssa_regs_to_check->Equal(bb->data_flow_info->ending_check_v)) {
900 nce_changed = true;
901 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
902 }
buzbee311ca162013-02-28 15:56:43 -0800903 }
buzbee1da1e2f2013-11-15 13:37:01 -0800904 return infer_changed | nce_changed;
buzbee311ca162013-02-28 15:56:43 -0800905}
906
Vladimir Markobfea9c22014-01-17 17:49:33 +0000907void MIRGraph::EliminateNullChecksAndInferTypesEnd() {
908 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
909 // Clean up temporaries.
910 temp_bit_vector_size_ = 0u;
911 temp_bit_vector_ = nullptr;
912 AllNodesIterator iter(this);
913 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
914 if (bb->data_flow_info != nullptr) {
915 bb->data_flow_info->ending_check_v = nullptr;
916 }
917 }
918 DCHECK(temp_scoped_alloc_.get() != nullptr);
919 temp_scoped_alloc_.reset();
920 }
921}
922
923bool MIRGraph::EliminateClassInitChecksGate() {
924 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
925 !cu_->mir_graph->HasStaticFieldAccess()) {
926 return false;
927 }
928
929 if (kIsDebugBuild) {
930 AllNodesIterator iter(this);
931 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
932 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
933 }
934 }
935
936 DCHECK(temp_scoped_alloc_.get() == nullptr);
937 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
938
939 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
940 const size_t end = (cu_->code_item->insns_size_in_code_units_ + 1u) / 2u;
941 temp_insn_data_ = static_cast<uint16_t*>(
942 temp_scoped_alloc_->Alloc(end * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
943
944 uint32_t unique_class_count = 0u;
945 {
946 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
947 // ScopedArenaAllocator.
948
949 // Embed the map value in the entry to save space.
950 struct MapEntry {
951 // Map key: the class identified by the declaring dex file and type index.
952 const DexFile* declaring_dex_file;
953 uint16_t declaring_class_idx;
954 // Map value: index into bit vectors of classes requiring initialization checks.
955 uint16_t index;
956 };
957 struct MapEntryComparator {
958 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
959 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
960 return lhs.declaring_class_idx < rhs.declaring_class_idx;
961 }
962 return lhs.declaring_dex_file < rhs.declaring_dex_file;
963 }
964 };
965
966 typedef std::set<MapEntry, MapEntryComparator, ScopedArenaAllocatorAdapter<MapEntry> >
967 ClassToIndexMap;
968
969 ScopedArenaAllocator allocator(&cu_->arena_stack);
970 ClassToIndexMap class_to_index_map(MapEntryComparator(), allocator.Adapter());
971
972 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
973 AllNodesIterator iter(this);
974 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
975 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
976 DCHECK(bb->data_flow_info != nullptr);
977 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
978 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
979 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
980 uint16_t index = 0xffffu;
981 if (field_info.IsResolved() && !field_info.IsInitialized()) {
982 DCHECK_LT(class_to_index_map.size(), 0xffffu);
983 MapEntry entry = {
984 field_info.DeclaringDexFile(),
985 field_info.DeclaringClassIndex(),
986 static_cast<uint16_t>(class_to_index_map.size())
987 };
988 index = class_to_index_map.insert(entry).first->index;
989 }
990 // Using offset/2 for index into temp_insn_data_.
991 temp_insn_data_[mir->offset / 2u] = index;
992 }
993 }
994 }
995 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
996 }
997
998 if (unique_class_count == 0u) {
999 // All SGET/SPUTs refer to initialized classes. Nothing to do.
1000 temp_insn_data_ = nullptr;
1001 temp_scoped_alloc_.reset();
1002 return false;
1003 }
1004
1005 temp_bit_vector_size_ = unique_class_count;
1006 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1007 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1008 DCHECK_GT(temp_bit_vector_size_, 0u);
1009 return true;
1010}
1011
1012/*
1013 * Eliminate unnecessary class initialization checks for a basic block.
1014 */
1015bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1016 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
1017 if (bb->data_flow_info == NULL) {
1018 return false;
1019 }
1020
1021 /*
1022 * Set initial state. Be conservative with catch
1023 * blocks and start with no assumptions about class init check status.
1024 */
1025 ArenaBitVector* classes_to_check = temp_bit_vector_;
1026 DCHECK(classes_to_check != nullptr);
1027 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
1028 classes_to_check->SetInitialBits(temp_bit_vector_size_);
1029 } else if (bb->predecessors->Size() == 1) {
1030 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
1031 // pred_bb must have already been processed at least once.
1032 DCHECK(pred_bb != nullptr);
1033 DCHECK(pred_bb->data_flow_info != nullptr);
1034 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
1035 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1036 } else {
1037 // Starting state is union of all incoming arcs
1038 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
1039 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
1040 DCHECK(pred_bb != NULL);
1041 DCHECK(pred_bb->data_flow_info != NULL);
1042 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
1043 pred_bb = GetBasicBlock(iter.Next());
1044 // At least one predecessor must have been processed before this bb.
1045 DCHECK(pred_bb != nullptr);
1046 DCHECK(pred_bb->data_flow_info != nullptr);
1047 }
1048 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1049 while (true) {
1050 pred_bb = GetBasicBlock(iter.Next());
1051 if (!pred_bb) break;
1052 DCHECK(pred_bb->data_flow_info != nullptr);
1053 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
1054 continue;
1055 }
1056 classes_to_check->Union(pred_bb->data_flow_info->ending_check_v);
1057 }
1058 }
1059 // At this point, classes_to_check shows which classes need clinit checks.
1060
1061 // Walk through the instruction in the block, updating as necessary
1062 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1063 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1064 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1065 uint16_t index = temp_insn_data_[mir->offset / 2u];
1066 if (index != 0xffffu) {
1067 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1068 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1069 if (!classes_to_check->IsBitSet(index)) {
1070 // Eliminate the class init check.
1071 mir->optimization_flags |= MIR_IGNORE_CLINIT_CHECK;
1072 } else {
1073 // Do the class init check.
1074 mir->optimization_flags &= ~MIR_IGNORE_CLINIT_CHECK;
1075 }
1076 }
1077 // Mark the class as initialized.
1078 classes_to_check->ClearBit(index);
1079 }
1080 }
1081 }
1082
1083 // Did anything change?
1084 bool changed = false;
1085 if (bb->data_flow_info->ending_check_v == nullptr) {
1086 DCHECK(temp_scoped_alloc_.get() != nullptr);
1087 DCHECK(bb->data_flow_info != nullptr);
1088 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1089 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1090 changed = classes_to_check->GetHighestBitSet() != -1;
1091 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1092 } else if (!classes_to_check->Equal(bb->data_flow_info->ending_check_v)) {
1093 changed = true;
1094 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1095 }
1096 return changed;
1097}
1098
1099void MIRGraph::EliminateClassInitChecksEnd() {
1100 // Clean up temporaries.
1101 temp_bit_vector_size_ = 0u;
1102 temp_bit_vector_ = nullptr;
1103 AllNodesIterator iter(this);
1104 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1105 if (bb->data_flow_info != nullptr) {
1106 bb->data_flow_info->ending_check_v = nullptr;
1107 }
1108 }
1109
1110 DCHECK(temp_insn_data_ != nullptr);
1111 temp_insn_data_ = nullptr;
1112 DCHECK(temp_scoped_alloc_.get() != nullptr);
1113 temp_scoped_alloc_.reset();
1114}
1115
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001116void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001117 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001118 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001119 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001120 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001121 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1122 CountChecks(bb);
1123 }
1124 if (stats->null_checks > 0) {
1125 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1126 float checks = static_cast<float>(stats->null_checks);
1127 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1128 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1129 << (eliminated/checks) * 100.0 << "%";
1130 }
1131 if (stats->range_checks > 0) {
1132 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1133 float checks = static_cast<float>(stats->range_checks);
1134 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1135 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1136 << (eliminated/checks) * 100.0 << "%";
1137 }
1138}
1139
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001140bool MIRGraph::BuildExtendedBBList(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001141 if (bb->visited) return false;
1142 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1143 || (bb->block_type == kExitBlock))) {
1144 // Ignore special blocks
1145 bb->visited = true;
1146 return false;
1147 }
1148 // Must be head of extended basic block.
1149 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001150 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001151 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001152 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001153 // Visit blocks strictly dominated by this head.
1154 while (bb != NULL) {
1155 bb->visited = true;
1156 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001157 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001158 bb = NextDominatedBlock(bb);
1159 }
buzbee1da1e2f2013-11-15 13:37:01 -08001160 if (terminated_by_return || do_local_value_numbering) {
1161 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001162 bb = start_bb;
1163 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001164 bb->use_lvn = do_local_value_numbering;
1165 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001166 bb = NextDominatedBlock(bb);
1167 }
1168 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001169 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001170}
1171
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001172void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001173 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1174 ClearAllVisitedFlags();
1175 PreOrderDfsIterator iter2(this);
1176 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1177 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001178 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001179 // Perform extended basic block optimizations.
1180 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1181 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1182 }
1183 } else {
1184 PreOrderDfsIterator iter(this);
1185 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1186 BasicBlockOpt(bb);
1187 }
buzbee311ca162013-02-28 15:56:43 -08001188 }
1189}
1190
1191} // namespace art