blob: 8100a29f32f25f9ee2c39885a2bb4f15fca54832 [file] [log] [blame]
David Brazdil46e2a392015-03-16 17:31:52 +00001/*
2 * Copyright (C) 2015 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "boolean_simplifier.h"
18
19namespace art {
20
David Brazdil769c9e52015-04-27 13:54:09 +010021void HBooleanSimplifier::TryRemovingNegatedCondition(HBasicBlock* block) {
22 DCHECK(block->EndsWithIf());
23
24 // Check if the condition is a Boolean negation.
25 HIf* if_instruction = block->GetLastInstruction()->AsIf();
26 HInstruction* boolean_not = if_instruction->InputAt(0);
27 if (!boolean_not->IsBooleanNot()) {
28 return;
29 }
30
31 // Make BooleanNot's input the condition of the If and swap branches.
32 if_instruction->ReplaceInput(boolean_not->InputAt(0), 0);
33 block->SwapSuccessors();
34
35 // Remove the BooleanNot if it is now unused.
36 if (!boolean_not->HasUses()) {
37 boolean_not->GetBlock()->RemoveInstruction(boolean_not);
38 }
39}
40
David Brazdil46e2a392015-03-16 17:31:52 +000041// Returns true if 'block1' and 'block2' are empty, merge into the same single
42// successor and the successor can only be reached from them.
43static bool BlocksDoMergeTogether(HBasicBlock* block1, HBasicBlock* block2) {
44 if (!block1->IsSingleGoto() || !block2->IsSingleGoto()) return false;
45 HBasicBlock* succ1 = block1->GetSuccessors().Get(0);
46 HBasicBlock* succ2 = block2->GetSuccessors().Get(0);
47 return succ1 == succ2 && succ1->GetPredecessors().Size() == 2u;
48}
49
50// Returns true if the outcome of the branching matches the boolean value of
51// the branching condition.
52static bool PreservesCondition(HInstruction* input_true, HInstruction* input_false) {
David Brazdilb2bd1c52015-03-25 11:17:37 +000053 return input_true->IsIntConstant() && input_true->AsIntConstant()->IsOne()
54 && input_false->IsIntConstant() && input_false->AsIntConstant()->IsZero();
David Brazdil46e2a392015-03-16 17:31:52 +000055}
56
57// Returns true if the outcome of the branching is exactly opposite of the
58// boolean value of the branching condition.
59static bool NegatesCondition(HInstruction* input_true, HInstruction* input_false) {
David Brazdilb2bd1c52015-03-25 11:17:37 +000060 return input_true->IsIntConstant() && input_true->AsIntConstant()->IsZero()
61 && input_false->IsIntConstant() && input_false->AsIntConstant()->IsOne();
David Brazdil46e2a392015-03-16 17:31:52 +000062}
63
64// Returns an instruction with the opposite boolean value from 'cond'.
65static HInstruction* GetOppositeCondition(HInstruction* cond) {
66 HGraph* graph = cond->GetBlock()->GetGraph();
67 ArenaAllocator* allocator = graph->GetArena();
68
69 if (cond->IsCondition()) {
70 HInstruction* lhs = cond->InputAt(0);
71 HInstruction* rhs = cond->InputAt(1);
72 if (cond->IsEqual()) {
73 return new (allocator) HNotEqual(lhs, rhs);
74 } else if (cond->IsNotEqual()) {
75 return new (allocator) HEqual(lhs, rhs);
76 } else if (cond->IsLessThan()) {
77 return new (allocator) HGreaterThanOrEqual(lhs, rhs);
78 } else if (cond->IsLessThanOrEqual()) {
79 return new (allocator) HGreaterThan(lhs, rhs);
80 } else if (cond->IsGreaterThan()) {
81 return new (allocator) HLessThanOrEqual(lhs, rhs);
David Brazdil2846b682015-03-31 09:59:27 +010082 } else {
83 DCHECK(cond->IsGreaterThanOrEqual());
David Brazdil46e2a392015-03-16 17:31:52 +000084 return new (allocator) HLessThan(lhs, rhs);
85 }
86 } else if (cond->IsIntConstant()) {
David Brazdilb2bd1c52015-03-25 11:17:37 +000087 HIntConstant* int_const = cond->AsIntConstant();
88 if (int_const->IsZero()) {
David Brazdil8d5b8b22015-03-24 10:51:52 +000089 return graph->GetIntConstant(1);
David Brazdil46e2a392015-03-16 17:31:52 +000090 } else {
David Brazdilb2bd1c52015-03-25 11:17:37 +000091 DCHECK(int_const->IsOne());
David Brazdil8d5b8b22015-03-24 10:51:52 +000092 return graph->GetIntConstant(0);
David Brazdil46e2a392015-03-16 17:31:52 +000093 }
David Brazdil2846b682015-03-31 09:59:27 +010094 } else {
David Brazdil917f9ab2015-04-21 15:13:31 +010095 // General case when 'cond' is another instruction of type boolean,
96 // as verified by SSAChecker.
David Brazdil66d126e2015-04-03 16:02:44 +010097 return new (allocator) HBooleanNot(cond);
David Brazdil46e2a392015-03-16 17:31:52 +000098 }
David Brazdil46e2a392015-03-16 17:31:52 +000099}
100
David Brazdil769c9e52015-04-27 13:54:09 +0100101void HBooleanSimplifier::TryRemovingBooleanSelection(HBasicBlock* block) {
102 DCHECK(block->EndsWithIf());
103
104 // Find elements of the pattern.
105 HIf* if_instruction = block->GetLastInstruction()->AsIf();
106 HBasicBlock* true_block = if_instruction->IfTrueSuccessor();
107 HBasicBlock* false_block = if_instruction->IfFalseSuccessor();
108 if (!BlocksDoMergeTogether(true_block, false_block)) {
109 return;
110 }
111 HBasicBlock* merge_block = true_block->GetSuccessors().Get(0);
112 if (!merge_block->HasSinglePhi()) {
113 return;
114 }
115 HPhi* phi = merge_block->GetFirstPhi()->AsPhi();
116 HInstruction* true_value = phi->InputAt(merge_block->GetPredecessorIndexOf(true_block));
117 HInstruction* false_value = phi->InputAt(merge_block->GetPredecessorIndexOf(false_block));
118
119 // Check if the selection negates/preserves the value of the condition and
120 // if so, generate a suitable replacement instruction.
121 HInstruction* if_condition = if_instruction->InputAt(0);
122 HInstruction* replacement;
123 if (NegatesCondition(true_value, false_value)) {
124 replacement = GetOppositeCondition(if_condition);
125 if (replacement->GetBlock() == nullptr) {
126 block->InsertInstructionBefore(replacement, if_instruction);
127 }
128 } else if (PreservesCondition(true_value, false_value)) {
129 replacement = if_condition;
130 } else {
131 return;
132 }
133
134 // Replace the selection outcome with the new instruction.
135 phi->ReplaceWith(replacement);
136 merge_block->RemovePhi(phi);
137
138 // Delete the true branch and merge the resulting chain of blocks
139 // 'block->false_block->merge_block' into one.
140 true_block->DisconnectAndDelete();
141 block->MergeWith(false_block);
142 block->MergeWith(merge_block);
143
144 // Remove the original condition if it is now unused.
145 if (!if_condition->HasUses()) {
146 if_condition->GetBlock()->RemoveInstructionOrPhi(if_condition);
147 }
148}
149
David Brazdil46e2a392015-03-16 17:31:52 +0000150void HBooleanSimplifier::Run() {
151 // Iterate in post order in the unlikely case that removing one occurrence of
David Brazdil769c9e52015-04-27 13:54:09 +0100152 // the selection pattern empties a branch block of another occurrence.
153 // Otherwise the order does not matter.
David Brazdil46e2a392015-03-16 17:31:52 +0000154 for (HPostOrderIterator it(*graph_); !it.Done(); it.Advance()) {
155 HBasicBlock* block = it.Current();
David Brazdilb2bd1c52015-03-25 11:17:37 +0000156 if (!block->EndsWithIf()) continue;
David Brazdil46e2a392015-03-16 17:31:52 +0000157
David Brazdil769c9e52015-04-27 13:54:09 +0100158 // If condition is negated, remove the negation and swap the branches.
159 TryRemovingNegatedCondition(block);
David Brazdil46e2a392015-03-16 17:31:52 +0000160
David Brazdil769c9e52015-04-27 13:54:09 +0100161 // If this is a boolean-selection diamond pattern, replace its result with
162 // the condition value (or its negation) and simplify the graph.
163 TryRemovingBooleanSelection(block);
David Brazdil46e2a392015-03-16 17:31:52 +0000164 }
165}
166
167} // namespace art