blob: 71d91ae38f685d738e749a32a3776e75d936c426 [file] [log] [blame]
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Andreas Gampe53c913b2014-08-12 23:19:23 -070017#include "optimizing_compiler.h"
18
Nicolas Geoffrayf635e632014-05-14 09:43:38 +010019#include <fstream>
David Srbecky5cc349f2015-12-18 15:04:48 +000020#include <memory>
Andreas Gampea0d81af2016-10-27 12:04:57 -070021#include <sstream>
22
Nicolas Geoffray787c3072014-03-17 10:20:19 +000023#include <stdint.h>
24
Vladimir Markob4536b72015-11-24 13:45:23 +000025#ifdef ART_ENABLE_CODEGEN_arm64
Alexandre Rames44b9cf92015-08-19 15:39:06 +010026#include "instruction_simplifier_arm64.h"
27#endif
28
Alexey Frunzee3fb2452016-05-10 16:08:05 -070029#ifdef ART_ENABLE_CODEGEN_mips
Alexey Frunzee3fb2452016-05-10 16:08:05 -070030#include "pc_relative_fixups_mips.h"
31#endif
32
Mark Mendell0616ae02015-04-17 12:49:27 -040033#ifdef ART_ENABLE_CODEGEN_x86
Vladimir Marko0f7dca42015-11-02 14:36:43 +000034#include "pc_relative_fixups_x86.h"
Mark Mendell0616ae02015-04-17 12:49:27 -040035#endif
36
Mark Mendellee8d9712016-07-12 11:13:15 -040037#if defined(ART_ENABLE_CODEGEN_x86) || defined(ART_ENABLE_CODEGEN_x86_64)
38#include "x86_memory_gen.h"
39#endif
40
Mathieu Chartiere401d142015-04-22 13:56:20 -070041#include "art_method-inl.h"
Mathieu Chartierb666f482015-02-18 14:33:14 -080042#include "base/arena_allocator.h"
Vladimir Markof9f64412015-09-02 14:05:49 +010043#include "base/arena_containers.h"
David Brazdil5e8b1372015-01-23 14:39:08 +000044#include "base/dumpable.h"
Vladimir Markoc90d7c72015-10-06 17:30:45 +000045#include "base/macros.h"
Andreas Gampea0d81af2016-10-27 12:04:57 -070046#include "base/mutex.h"
David Brazdil5e8b1372015-01-23 14:39:08 +000047#include "base/timing_logger.h"
Mingyao Yangf384f882014-10-22 16:08:18 -070048#include "bounds_check_elimination.h"
Nicolas Geoffray787c3072014-03-17 10:20:19 +000049#include "builder.h"
Mingyao Yangb0b051a2016-11-17 09:04:53 -080050#include "cha_guard_optimization.h"
Nicolas Geoffray787c3072014-03-17 10:20:19 +000051#include "code_generator.h"
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +000052#include "code_sinking.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000053#include "compiled_method.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070054#include "compiler.h"
Roland Levillain75be2832014-10-17 17:02:00 +010055#include "constant_folding.h"
56#include "dead_code_elimination.h"
David Srbeckyc5bfa972016-02-05 15:49:10 +000057#include "debug/elf_debug_writer.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000058#include "debug/method_debug_info.h"
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010059#include "dex/verification_results.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000060#include "dex/verified_method.h"
Andreas Gampea5b09a62016-11-17 15:21:22 -080061#include "dex_file_types.h"
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +000062#include "driver/compiler_driver-inl.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000063#include "driver/compiler_options.h"
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +000064#include "driver/dex_compilation_unit.h"
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +000065#include "elf_writer_quick.h"
David Brazdil69ba7b72015-06-23 18:27:30 +010066#include "graph_checker.h"
Nicolas Geoffrayf635e632014-05-14 09:43:38 +010067#include "graph_visualizer.h"
Nicolas Geoffrayd31cf3d2014-09-08 17:30:24 +010068#include "gvn.h"
Aart Bik22af3be2015-09-10 12:50:58 -070069#include "induction_var_analysis.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000070#include "inliner.h"
Nicolas Geoffray3c049742014-09-24 18:10:46 +010071#include "instruction_simplifier.h"
Artem Udovichenko4a0dad62016-01-26 12:28:31 +030072#include "instruction_simplifier_arm.h"
Andreas Gampe71fb52f2014-12-29 17:43:08 -080073#include "intrinsics.h"
David Srbecky5cc349f2015-12-18 15:04:48 +000074#include "jit/debugger_interface.h"
Nicolas Geoffraya4f81542016-03-08 16:57:48 +000075#include "jit/jit.h"
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +000076#include "jit/jit_code_cache.h"
Nicolas Geoffray01db5f72017-07-19 15:05:49 +010077#include "jit/jit_logger.h"
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +000078#include "jni/quick/jni_compiler.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000079#include "licm.h"
xueliang.zhongc239a2b2017-04-27 15:31:37 +010080#include "load_store_analysis.h"
Mingyao Yang8df69d42015-10-22 15:40:58 -070081#include "load_store_elimination.h"
Aart Bik281c6812016-08-26 11:31:48 -070082#include "loop_optimization.h"
Nicolas Geoffray787c3072014-03-17 10:20:19 +000083#include "nodes.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000084#include "oat_quick_method_header.h"
Nicolas Geoffray26a25ef2014-09-30 13:54:09 +010085#include "prepare_for_register_allocation.h"
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010086#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070087#include "register_allocator_linear_scan.h"
Alexandre Rames22aa54b2016-10-18 09:32:29 +010088#include "scheduler.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070089#include "select_generator.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010090#include "sharpening.h"
Nicolas Geoffray827eedb2015-01-26 15:18:36 +000091#include "side_effects_analysis.h"
Nicolas Geoffray31596742014-11-24 15:28:45 +000092#include "ssa_builder.h"
Nicolas Geoffray804d0932014-05-02 08:46:00 +010093#include "ssa_liveness_analysis.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000094#include "ssa_phi_elimination.h"
David Srbeckyc6b4dd82015-04-07 20:32:43 +010095#include "utils/assembler.h"
Andreas Gampe6d7abbd2017-04-24 13:19:09 -070096#include "verifier/verifier_compiler_binding.h"
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +000097
98namespace art {
99
Vladimir Marko3a40bf22016-03-22 16:26:33 +0000100static constexpr size_t kArenaAllocatorMemoryReportThreshold = 8 * MB;
101
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700102static constexpr const char* kPassNameSeparator = "$";
103
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000104/**
105 * Used by the code generator, to allocate the code in a vector.
106 */
107class CodeVectorAllocator FINAL : public CodeAllocator {
108 public:
Vladimir Markof9f64412015-09-02 14:05:49 +0100109 explicit CodeVectorAllocator(ArenaAllocator* arena)
110 : memory_(arena->Adapter(kArenaAllocCodeBuffer)),
111 size_(0) {}
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000112
113 virtual uint8_t* Allocate(size_t size) {
114 size_ = size;
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +0000115 memory_.resize(size);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000116 return &memory_[0];
117 }
118
119 size_t GetSize() const { return size_; }
Vladimir Markof9f64412015-09-02 14:05:49 +0100120 const ArenaVector<uint8_t>& GetMemory() const { return memory_; }
Nicolas Geoffray132d8362016-11-16 09:19:42 +0000121 uint8_t* GetData() { return memory_.data(); }
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000122
123 private:
Vladimir Markof9f64412015-09-02 14:05:49 +0100124 ArenaVector<uint8_t> memory_;
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000125 size_t size_;
126
127 DISALLOW_COPY_AND_ASSIGN(CodeVectorAllocator);
128};
129
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100130/**
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100131 * Filter to apply to the visualizer. Methods whose name contain that filter will
David Brazdilee690a32014-12-01 17:04:16 +0000132 * be dumped.
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100133 */
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700134static constexpr const char kStringFilter[] = "";
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100135
David Brazdil69ba7b72015-06-23 18:27:30 +0100136class PassScope;
David Brazdil809658e2015-02-05 11:34:02 +0000137
David Brazdil69ba7b72015-06-23 18:27:30 +0100138class PassObserver : public ValueObject {
David Brazdil5e8b1372015-01-23 14:39:08 +0000139 public:
David Brazdil69ba7b72015-06-23 18:27:30 +0100140 PassObserver(HGraph* graph,
David Brazdil69ba7b72015-06-23 18:27:30 +0100141 CodeGenerator* codegen,
142 std::ostream* visualizer_output,
Andreas Gampea0d81af2016-10-27 12:04:57 -0700143 CompilerDriver* compiler_driver,
144 Mutex& dump_mutex)
David Brazdil69ba7b72015-06-23 18:27:30 +0100145 : graph_(graph),
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000146 cached_method_name_(),
David Brazdil809658e2015-02-05 11:34:02 +0000147 timing_logger_enabled_(compiler_driver->GetDumpPasses()),
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000148 timing_logger_(timing_logger_enabled_ ? GetMethodName() : "", true, true),
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100149 disasm_info_(graph->GetArena()),
Andreas Gampea0d81af2016-10-27 12:04:57 -0700150 visualizer_oss_(),
151 visualizer_output_(visualizer_output),
Nicolas Geoffrayc903b6a2016-01-18 12:56:06 +0000152 visualizer_enabled_(!compiler_driver->GetCompilerOptions().GetDumpCfgFileName().empty()),
Andreas Gampea0d81af2016-10-27 12:04:57 -0700153 visualizer_(&visualizer_oss_, graph, *codegen),
154 visualizer_dump_mutex_(dump_mutex),
David Brazdil69ba7b72015-06-23 18:27:30 +0100155 graph_in_bad_state_(false) {
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700156 if (timing_logger_enabled_ || visualizer_enabled_) {
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000157 if (!IsVerboseMethod(compiler_driver, GetMethodName())) {
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700158 timing_logger_enabled_ = visualizer_enabled_ = false;
159 }
160 if (visualizer_enabled_) {
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000161 visualizer_.PrintHeader(GetMethodName());
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700162 codegen->SetDisassemblyInformation(&disasm_info_);
163 }
David Brazdil62e074f2015-04-07 18:09:37 +0100164 }
David Brazdil5e8b1372015-01-23 14:39:08 +0000165 }
166
David Brazdil69ba7b72015-06-23 18:27:30 +0100167 ~PassObserver() {
David Brazdil5e8b1372015-01-23 14:39:08 +0000168 if (timing_logger_enabled_) {
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000169 LOG(INFO) << "TIMINGS " << GetMethodName();
David Brazdil5e8b1372015-01-23 14:39:08 +0000170 LOG(INFO) << Dumpable<TimingLogger>(timing_logger_);
171 }
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000172 DCHECK(visualizer_oss_.str().empty());
David Brazdil5e8b1372015-01-23 14:39:08 +0000173 }
174
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000175 void DumpDisassembly() REQUIRES(!visualizer_dump_mutex_) {
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100176 if (visualizer_enabled_) {
177 visualizer_.DumpGraphWithDisassembly();
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000178 FlushVisualizer();
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100179 }
180 }
181
David Brazdil69ba7b72015-06-23 18:27:30 +0100182 void SetGraphInBadState() { graph_in_bad_state_ = true; }
183
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000184 const char* GetMethodName() {
185 // PrettyMethod() is expensive, so we delay calling it until we actually have to.
186 if (cached_method_name_.empty()) {
David Sehr709b0702016-10-13 09:12:37 -0700187 cached_method_name_ = graph_->GetDexFile().PrettyMethod(graph_->GetMethodIdx());
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000188 }
189 return cached_method_name_.c_str();
190 }
191
David Brazdil5e8b1372015-01-23 14:39:08 +0000192 private:
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000193 void StartPass(const char* pass_name) REQUIRES(!visualizer_dump_mutex_) {
Wojciech Staszkiewicze7060702016-08-16 17:31:19 -0700194 VLOG(compiler) << "Starting pass: " << pass_name;
David Brazdil809658e2015-02-05 11:34:02 +0000195 // Dump graph first, then start timer.
196 if (visualizer_enabled_) {
David Brazdilffee3d32015-07-06 11:48:53 +0100197 visualizer_.DumpGraph(pass_name, /* is_after_pass */ false, graph_in_bad_state_);
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000198 FlushVisualizer();
David Brazdil809658e2015-02-05 11:34:02 +0000199 }
200 if (timing_logger_enabled_) {
201 timing_logger_.StartTiming(pass_name);
202 }
203 }
204
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000205 void FlushVisualizer() REQUIRES(!visualizer_dump_mutex_) {
206 MutexLock mu(Thread::Current(), visualizer_dump_mutex_);
207 *visualizer_output_ << visualizer_oss_.str();
208 visualizer_output_->flush();
209 visualizer_oss_.str("");
210 visualizer_oss_.clear();
211 }
212
213 void EndPass(const char* pass_name) REQUIRES(!visualizer_dump_mutex_) {
David Brazdil809658e2015-02-05 11:34:02 +0000214 // Pause timer first, then dump graph.
215 if (timing_logger_enabled_) {
216 timing_logger_.EndTiming();
217 }
218 if (visualizer_enabled_) {
David Brazdilffee3d32015-07-06 11:48:53 +0100219 visualizer_.DumpGraph(pass_name, /* is_after_pass */ true, graph_in_bad_state_);
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000220 FlushVisualizer();
David Brazdil809658e2015-02-05 11:34:02 +0000221 }
David Brazdil69ba7b72015-06-23 18:27:30 +0100222
223 // Validate the HGraph if running in debug mode.
224 if (kIsDebugBuild) {
225 if (!graph_in_bad_state_) {
David Brazdilbadd8262016-02-02 16:28:56 +0000226 GraphChecker checker(graph_);
227 checker.Run();
228 if (!checker.IsValid()) {
229 LOG(FATAL) << "Error after " << pass_name << ": " << Dumpable<GraphChecker>(checker);
David Brazdil69ba7b72015-06-23 18:27:30 +0100230 }
231 }
232 }
David Brazdil809658e2015-02-05 11:34:02 +0000233 }
234
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700235 static bool IsVerboseMethod(CompilerDriver* compiler_driver, const char* method_name) {
236 // Test an exact match to --verbose-methods. If verbose-methods is set, this overrides an
237 // empty kStringFilter matching all methods.
238 if (compiler_driver->GetCompilerOptions().HasVerboseMethods()) {
239 return compiler_driver->GetCompilerOptions().IsVerboseMethod(method_name);
240 }
241
242 // Test the kStringFilter sub-string. constexpr helper variable to silence unreachable-code
243 // warning when the string is empty.
244 constexpr bool kStringFilterEmpty = arraysize(kStringFilter) <= 1;
245 if (kStringFilterEmpty || strstr(method_name, kStringFilter) != nullptr) {
246 return true;
247 }
248
249 return false;
250 }
251
David Brazdil69ba7b72015-06-23 18:27:30 +0100252 HGraph* const graph_;
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000253
254 std::string cached_method_name_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000255
256 bool timing_logger_enabled_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000257 TimingLogger timing_logger_;
258
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100259 DisassemblyInformation disasm_info_;
260
Andreas Gampea0d81af2016-10-27 12:04:57 -0700261 std::ostringstream visualizer_oss_;
262 std::ostream* visualizer_output_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000263 bool visualizer_enabled_;
264 HGraphVisualizer visualizer_;
Andreas Gampea0d81af2016-10-27 12:04:57 -0700265 Mutex& visualizer_dump_mutex_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000266
David Brazdil69ba7b72015-06-23 18:27:30 +0100267 // Flag to be set by the compiler if the pass failed and the graph is not
268 // expected to validate.
269 bool graph_in_bad_state_;
David Brazdil809658e2015-02-05 11:34:02 +0000270
David Brazdil69ba7b72015-06-23 18:27:30 +0100271 friend PassScope;
272
273 DISALLOW_COPY_AND_ASSIGN(PassObserver);
David Brazdil5e8b1372015-01-23 14:39:08 +0000274};
275
David Brazdil69ba7b72015-06-23 18:27:30 +0100276class PassScope : public ValueObject {
David Brazdil809658e2015-02-05 11:34:02 +0000277 public:
David Brazdil69ba7b72015-06-23 18:27:30 +0100278 PassScope(const char *pass_name, PassObserver* pass_observer)
David Brazdil809658e2015-02-05 11:34:02 +0000279 : pass_name_(pass_name),
David Brazdil69ba7b72015-06-23 18:27:30 +0100280 pass_observer_(pass_observer) {
281 pass_observer_->StartPass(pass_name_);
David Brazdil809658e2015-02-05 11:34:02 +0000282 }
283
David Brazdil69ba7b72015-06-23 18:27:30 +0100284 ~PassScope() {
285 pass_observer_->EndPass(pass_name_);
David Brazdil809658e2015-02-05 11:34:02 +0000286 }
287
288 private:
289 const char* const pass_name_;
David Brazdil69ba7b72015-06-23 18:27:30 +0100290 PassObserver* const pass_observer_;
David Brazdil809658e2015-02-05 11:34:02 +0000291};
292
Andreas Gampe53c913b2014-08-12 23:19:23 -0700293class OptimizingCompiler FINAL : public Compiler {
294 public:
295 explicit OptimizingCompiler(CompilerDriver* driver);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700296 ~OptimizingCompiler() OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700297
Vladimir Markodf739842016-03-23 16:59:07 +0000298 bool CanCompileMethod(uint32_t method_idx, const DexFile& dex_file) const OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700299
300 CompiledMethod* Compile(const DexFile::CodeItem* code_item,
301 uint32_t access_flags,
302 InvokeType invoke_type,
303 uint16_t class_def_idx,
304 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000305 Handle<mirror::ClassLoader> class_loader,
Mathieu Chartier736b5602015-09-02 14:54:11 -0700306 const DexFile& dex_file,
307 Handle<mirror::DexCache> dex_cache) const OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700308
Andreas Gampe53c913b2014-08-12 23:19:23 -0700309 CompiledMethod* JniCompile(uint32_t access_flags,
310 uint32_t method_idx,
Igor Murashkin9d4b6da2016-07-29 09:51:58 -0700311 const DexFile& dex_file,
312 JniOptimizationFlags optimization_flags) const OVERRIDE {
313 return ArtQuickJniCompileMethod(GetCompilerDriver(),
314 access_flags,
315 method_idx,
316 dex_file,
317 optimization_flags);
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000318 }
Andreas Gampe53c913b2014-08-12 23:19:23 -0700319
Mathieu Chartiere401d142015-04-22 13:56:20 -0700320 uintptr_t GetEntryPointOf(ArtMethod* method) const OVERRIDE
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700321 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000322 return reinterpret_cast<uintptr_t>(method->GetEntryPointFromQuickCompiledCodePtrSize(
323 InstructionSetPointerSize(GetCompilerDriver()->GetInstructionSet())));
324 }
Andreas Gampe53c913b2014-08-12 23:19:23 -0700325
David Brazdilee690a32014-12-01 17:04:16 +0000326 void Init() OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700327
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000328 void UnInit() const OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700329
Nicolas Geoffray01db5f72017-07-19 15:05:49 +0100330 bool JitCompile(Thread* self,
331 jit::JitCodeCache* code_cache,
332 ArtMethod* method,
333 bool osr,
334 jit::JitLogger* jit_logger)
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000335 OVERRIDE
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700336 REQUIRES_SHARED(Locks::mutator_lock_);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000337
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700338 private:
339 void RunOptimizations(HGraph* graph,
340 CodeGenerator* codegen,
341 CompilerDriver* driver,
342 const DexCompilationUnit& dex_compilation_unit,
343 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700344 VariableSizedHandleScope* handles) const;
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700345
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700346 void RunOptimizations(HOptimization* optimizations[],
347 size_t length,
348 PassObserver* pass_observer) const;
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700349
Andreas Gampe53c913b2014-08-12 23:19:23 -0700350 private:
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000351 // Create a 'CompiledMethod' for an optimized graph.
David Brazdil58282f42016-01-14 12:45:10 +0000352 CompiledMethod* Emit(ArenaAllocator* arena,
353 CodeVectorAllocator* code_allocator,
354 CodeGenerator* codegen,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000355 CompilerDriver* driver,
356 const DexFile::CodeItem* item) const;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000357
358 // Try compiling a method and return the code generator used for
359 // compiling it.
360 // This method:
361 // 1) Builds the graph. Returns null if it failed to build it.
David Brazdil58282f42016-01-14 12:45:10 +0000362 // 2) Transforms the graph to SSA. Returns null if it failed.
363 // 3) Runs optimizations on the graph, including register allocator.
364 // 4) Generates code with the `code_allocator` provided.
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000365 CodeGenerator* TryCompile(ArenaAllocator* arena,
366 CodeVectorAllocator* code_allocator,
367 const DexFile::CodeItem* code_item,
368 uint32_t access_flags,
369 InvokeType invoke_type,
370 uint16_t class_def_idx,
371 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000372 Handle<mirror::ClassLoader> class_loader,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000373 const DexFile& dex_file,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000374 Handle<mirror::DexCache> dex_cache,
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000375 ArtMethod* method,
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000376 bool osr,
377 VariableSizedHandleScope* handles) const;
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000378
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700379 void MaybeRunInliner(HGraph* graph,
380 CodeGenerator* codegen,
381 CompilerDriver* driver,
382 const DexCompilationUnit& dex_compilation_unit,
383 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700384 VariableSizedHandleScope* handles) const;
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700385
386 void RunArchOptimizations(InstructionSet instruction_set,
387 HGraph* graph,
388 CodeGenerator* codegen,
389 PassObserver* pass_observer) const;
390
Calin Juravle2be39e02015-04-21 13:56:34 +0100391 std::unique_ptr<OptimizingCompilerStats> compilation_stats_;
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100392
Andreas Gampe53c913b2014-08-12 23:19:23 -0700393 std::unique_ptr<std::ostream> visualizer_output_;
394
Andreas Gampea0d81af2016-10-27 12:04:57 -0700395 mutable Mutex dump_mutex_; // To synchronize visualizer writing.
396
Andreas Gampe53c913b2014-08-12 23:19:23 -0700397 DISALLOW_COPY_AND_ASSIGN(OptimizingCompiler);
398};
399
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100400static const int kMaximumCompilationTimeBeforeWarning = 100; /* ms */
401
402OptimizingCompiler::OptimizingCompiler(CompilerDriver* driver)
Andreas Gampea0d81af2016-10-27 12:04:57 -0700403 : Compiler(driver, kMaximumCompilationTimeBeforeWarning),
404 dump_mutex_("Visualizer dump lock") {}
David Brazdilee690a32014-12-01 17:04:16 +0000405
406void OptimizingCompiler::Init() {
407 // Enable C1visualizer output. Must be done in Init() because the compiler
408 // driver is not fully initialized when passed to the compiler's constructor.
409 CompilerDriver* driver = GetCompilerDriver();
Nicolas Geoffrayc903b6a2016-01-18 12:56:06 +0000410 const std::string cfg_file_name = driver->GetCompilerOptions().GetDumpCfgFileName();
David Brazdil866c0312015-01-13 21:21:31 +0000411 if (!cfg_file_name.empty()) {
Calin Juravle87000a92015-08-24 15:34:44 +0100412 std::ios_base::openmode cfg_file_mode =
Nicolas Geoffrayc903b6a2016-01-18 12:56:06 +0000413 driver->GetCompilerOptions().GetDumpCfgAppend() ? std::ofstream::app : std::ofstream::out;
Calin Juravle87000a92015-08-24 15:34:44 +0100414 visualizer_output_.reset(new std::ofstream(cfg_file_name, cfg_file_mode));
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100415 }
Calin Juravle2be39e02015-04-21 13:56:34 +0100416 if (driver->GetDumpStats()) {
417 compilation_stats_.reset(new OptimizingCompilerStats());
418 }
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100419}
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000420
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000421void OptimizingCompiler::UnInit() const {
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000422}
423
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100424OptimizingCompiler::~OptimizingCompiler() {
Calin Juravle2be39e02015-04-21 13:56:34 +0100425 if (compilation_stats_.get() != nullptr) {
426 compilation_stats_->Log();
427 }
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100428}
429
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +0000430bool OptimizingCompiler::CanCompileMethod(uint32_t method_idx ATTRIBUTE_UNUSED,
Vladimir Markodf739842016-03-23 16:59:07 +0000431 const DexFile& dex_file ATTRIBUTE_UNUSED) const {
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +0000432 return true;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700433}
434
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000435static bool IsInstructionSetSupported(InstructionSet instruction_set) {
Calin Juravlecff8cc72015-10-09 12:03:24 +0100436 return (instruction_set == kArm && !kArm32QuickCodeUseSoftFloat)
437 || instruction_set == kArm64
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000438 || (instruction_set == kThumb2 && !kArm32QuickCodeUseSoftFloat)
Goran Jakovljevicf652cec2015-08-25 16:11:42 +0200439 || instruction_set == kMips
Alexey Frunze4dda3372015-06-01 18:31:49 -0700440 || instruction_set == kMips64
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000441 || instruction_set == kX86
442 || instruction_set == kX86_64;
443}
444
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700445// Strip pass name suffix to get optimization name.
446static std::string ConvertPassNameToOptimizationName(const std::string& pass_name) {
447 size_t pos = pass_name.find(kPassNameSeparator);
448 return pos == std::string::npos ? pass_name : pass_name.substr(0, pos);
449}
450
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700451static HOptimization* BuildOptimization(
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700452 const std::string& pass_name,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700453 ArenaAllocator* arena,
454 HGraph* graph,
455 OptimizingCompilerStats* stats,
456 CodeGenerator* codegen,
457 CompilerDriver* driver,
458 const DexCompilationUnit& dex_compilation_unit,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700459 VariableSizedHandleScope* handles,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700460 SideEffectsAnalysis* most_recent_side_effects,
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100461 HInductionVarAnalysis* most_recent_induction,
462 LoadStoreAnalysis* most_recent_lsa) {
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700463 std::string opt_name = ConvertPassNameToOptimizationName(pass_name);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700464 if (opt_name == BoundsCheckElimination::kBoundsCheckEliminationPassName) {
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700465 CHECK(most_recent_side_effects != nullptr && most_recent_induction != nullptr);
466 return new (arena) BoundsCheckElimination(graph,
467 *most_recent_side_effects,
468 most_recent_induction);
469 } else if (opt_name == GVNOptimization::kGlobalValueNumberingPassName) {
470 CHECK(most_recent_side_effects != nullptr);
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700471 return new (arena) GVNOptimization(graph, *most_recent_side_effects, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700472 } else if (opt_name == HConstantFolding::kConstantFoldingPassName) {
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700473 return new (arena) HConstantFolding(graph, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700474 } else if (opt_name == HDeadCodeElimination::kDeadCodeEliminationPassName) {
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700475 return new (arena) HDeadCodeElimination(graph, stats, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700476 } else if (opt_name == HInliner::kInlinerPassName) {
477 size_t number_of_dex_registers = dex_compilation_unit.GetCodeItem()->registers_size_;
478 return new (arena) HInliner(graph, // outer_graph
479 graph, // outermost_graph
480 codegen,
481 dex_compilation_unit, // outer_compilation_unit
482 dex_compilation_unit, // outermost_compilation_unit
483 driver,
484 handles,
485 stats,
486 number_of_dex_registers,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000487 /* total_number_of_instructions */ 0,
488 /* parent */ nullptr);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700489 } else if (opt_name == HSharpening::kSharpeningPassName) {
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000490 return new (arena) HSharpening(graph, codegen, dex_compilation_unit, driver, handles);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700491 } else if (opt_name == HSelectGenerator::kSelectGeneratorPassName) {
Mads Ager16e52892017-07-14 13:11:37 +0200492 return new (arena) HSelectGenerator(graph, handles, stats);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700493 } else if (opt_name == HInductionVarAnalysis::kInductionPassName) {
494 return new (arena) HInductionVarAnalysis(graph);
495 } else if (opt_name == InstructionSimplifier::kInstructionSimplifierPassName) {
Vladimir Marko65979462017-05-19 17:25:12 +0100496 return new (arena) InstructionSimplifier(graph, codegen, driver, stats, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700497 } else if (opt_name == IntrinsicsRecognizer::kIntrinsicsRecognizerPassName) {
Nicolas Geoffray762869d2016-07-15 15:28:35 +0100498 return new (arena) IntrinsicsRecognizer(graph, stats);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700499 } else if (opt_name == LICM::kLoopInvariantCodeMotionPassName) {
500 CHECK(most_recent_side_effects != nullptr);
501 return new (arena) LICM(graph, *most_recent_side_effects, stats);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100502 } else if (opt_name == LoadStoreAnalysis::kLoadStoreAnalysisPassName) {
503 return new (arena) LoadStoreAnalysis(graph);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700504 } else if (opt_name == LoadStoreElimination::kLoadStoreEliminationPassName) {
505 CHECK(most_recent_side_effects != nullptr);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100506 CHECK(most_recent_lsa != nullptr);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700507 return
508 new (arena) LoadStoreElimination(graph, *most_recent_side_effects, *most_recent_lsa, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700509 } else if (opt_name == SideEffectsAnalysis::kSideEffectsAnalysisPassName) {
510 return new (arena) SideEffectsAnalysis(graph);
Nicolas Geoffrayebe16742016-10-05 09:55:42 +0100511 } else if (opt_name == HLoopOptimization::kLoopOptimizationPassName) {
Aart Bikb92cc332017-09-06 15:53:17 -0700512 return new (arena) HLoopOptimization(graph, driver, most_recent_induction, stats);
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800513 } else if (opt_name == CHAGuardOptimization::kCHAGuardOptimizationPassName) {
514 return new (arena) CHAGuardOptimization(graph);
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +0000515 } else if (opt_name == CodeSinking::kCodeSinkingPassName) {
516 return new (arena) CodeSinking(graph, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700517#ifdef ART_ENABLE_CODEGEN_arm
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700518 } else if (opt_name == arm::InstructionSimplifierArm::kInstructionSimplifierArmPassName) {
519 return new (arena) arm::InstructionSimplifierArm(graph, stats);
520#endif
521#ifdef ART_ENABLE_CODEGEN_arm64
522 } else if (opt_name == arm64::InstructionSimplifierArm64::kInstructionSimplifierArm64PassName) {
523 return new (arena) arm64::InstructionSimplifierArm64(graph, stats);
524#endif
525#ifdef ART_ENABLE_CODEGEN_mips
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700526 } else if (opt_name == mips::PcRelativeFixups::kPcRelativeFixupsMipsPassName) {
527 return new (arena) mips::PcRelativeFixups(graph, codegen, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700528#endif
529#ifdef ART_ENABLE_CODEGEN_x86
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700530 } else if (opt_name == x86::PcRelativeFixups::kPcRelativeFixupsX86PassName) {
531 return new (arena) x86::PcRelativeFixups(graph, codegen, stats);
532 } else if (opt_name == x86::X86MemoryOperandGeneration::kX86MemoryOperandGenerationPassName) {
533 return new (arena) x86::X86MemoryOperandGeneration(graph, codegen, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700534#endif
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700535 }
536 return nullptr;
537}
538
539static ArenaVector<HOptimization*> BuildOptimizations(
540 const std::vector<std::string>& pass_names,
541 ArenaAllocator* arena,
542 HGraph* graph,
543 OptimizingCompilerStats* stats,
544 CodeGenerator* codegen,
545 CompilerDriver* driver,
546 const DexCompilationUnit& dex_compilation_unit,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700547 VariableSizedHandleScope* handles) {
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700548 // Few HOptimizations constructors require SideEffectsAnalysis or HInductionVarAnalysis
549 // instances. This method assumes that each of them expects the nearest instance preceeding it
550 // in the pass name list.
551 SideEffectsAnalysis* most_recent_side_effects = nullptr;
552 HInductionVarAnalysis* most_recent_induction = nullptr;
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100553 LoadStoreAnalysis* most_recent_lsa = nullptr;
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700554 ArenaVector<HOptimization*> ret(arena->Adapter());
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700555 for (const std::string& pass_name : pass_names) {
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700556 HOptimization* opt = BuildOptimization(
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700557 pass_name,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700558 arena,
559 graph,
560 stats,
561 codegen,
562 driver,
563 dex_compilation_unit,
564 handles,
565 most_recent_side_effects,
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100566 most_recent_induction,
567 most_recent_lsa);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700568 CHECK(opt != nullptr) << "Couldn't build optimization: \"" << pass_name << "\"";
569 ret.push_back(opt);
570
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700571 std::string opt_name = ConvertPassNameToOptimizationName(pass_name);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700572 if (opt_name == SideEffectsAnalysis::kSideEffectsAnalysisPassName) {
573 most_recent_side_effects = down_cast<SideEffectsAnalysis*>(opt);
574 } else if (opt_name == HInductionVarAnalysis::kInductionPassName) {
575 most_recent_induction = down_cast<HInductionVarAnalysis*>(opt);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100576 } else if (opt_name == LoadStoreAnalysis::kLoadStoreAnalysisPassName) {
577 most_recent_lsa = down_cast<LoadStoreAnalysis*>(opt);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700578 }
579 }
580 return ret;
581}
582
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700583void OptimizingCompiler::RunOptimizations(HOptimization* optimizations[],
584 size_t length,
585 PassObserver* pass_observer) const {
Calin Juravle10e244f2015-01-26 18:54:32 +0000586 for (size_t i = 0; i < length; ++i) {
David Brazdil69ba7b72015-06-23 18:27:30 +0100587 PassScope scope(optimizations[i]->GetPassName(), pass_observer);
588 optimizations[i]->Run();
Calin Juravle10e244f2015-01-26 18:54:32 +0000589 }
590}
591
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700592void OptimizingCompiler::MaybeRunInliner(HGraph* graph,
593 CodeGenerator* codegen,
594 CompilerDriver* driver,
595 const DexCompilationUnit& dex_compilation_unit,
596 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700597 VariableSizedHandleScope* handles) const {
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700598 OptimizingCompilerStats* stats = compilation_stats_.get();
Calin Juravleec748352015-07-29 13:52:12 +0100599 const CompilerOptions& compiler_options = driver->GetCompilerOptions();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000600 bool should_inline = (compiler_options.GetInlineMaxCodeUnits() > 0);
Calin Juravleec748352015-07-29 13:52:12 +0100601 if (!should_inline) {
602 return;
603 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000604 size_t number_of_dex_registers = dex_compilation_unit.GetCodeItem()->registers_size_;
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000605 HInliner* inliner = new (graph->GetArena()) HInliner(
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700606 graph, // outer_graph
607 graph, // outermost_graph
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000608 codegen,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700609 dex_compilation_unit, // outer_compilation_unit
610 dex_compilation_unit, // outermost_compilation_unit
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000611 driver,
612 handles,
613 stats,
614 number_of_dex_registers,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000615 /* total_number_of_instructions */ 0,
616 /* parent */ nullptr);
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000617 HOptimization* optimizations[] = { inliner };
Calin Juravleec748352015-07-29 13:52:12 +0100618
619 RunOptimizations(optimizations, arraysize(optimizations), pass_observer);
620}
621
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700622void OptimizingCompiler::RunArchOptimizations(InstructionSet instruction_set,
623 HGraph* graph,
624 CodeGenerator* codegen,
625 PassObserver* pass_observer) const {
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700626 UNUSED(codegen); // To avoid compilation error when compiling for svelte
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700627 OptimizingCompilerStats* stats = compilation_stats_.get();
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100628 ArenaAllocator* arena = graph->GetArena();
629 switch (instruction_set) {
Artem Serov2bbc9532016-10-21 11:51:50 +0100630#if defined(ART_ENABLE_CODEGEN_arm)
Vladimir Markob4536b72015-11-24 13:45:23 +0000631 case kThumb2:
632 case kArm: {
Artem Udovichenko4a0dad62016-01-26 12:28:31 +0300633 arm::InstructionSimplifierArm* simplifier =
634 new (arena) arm::InstructionSimplifierArm(graph, stats);
Artem Serov328429f2016-07-06 16:23:04 +0100635 SideEffectsAnalysis* side_effects = new (arena) SideEffectsAnalysis(graph);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700636 GVNOptimization* gvn = new (arena) GVNOptimization(graph, *side_effects, "GVN$after_arch");
xueliang.zhongf7caf682017-03-01 16:07:02 +0000637 HInstructionScheduling* scheduling =
638 new (arena) HInstructionScheduling(graph, instruction_set, codegen);
Vladimir Markob4536b72015-11-24 13:45:23 +0000639 HOptimization* arm_optimizations[] = {
Artem Udovichenko4a0dad62016-01-26 12:28:31 +0300640 simplifier,
Artem Serov328429f2016-07-06 16:23:04 +0100641 side_effects,
642 gvn,
xueliang.zhongf7caf682017-03-01 16:07:02 +0000643 scheduling,
Vladimir Markob4536b72015-11-24 13:45:23 +0000644 };
645 RunOptimizations(arm_optimizations, arraysize(arm_optimizations), pass_observer);
646 break;
647 }
648#endif
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100649#ifdef ART_ENABLE_CODEGEN_arm64
650 case kArm64: {
651 arm64::InstructionSimplifierArm64* simplifier =
652 new (arena) arm64::InstructionSimplifierArm64(graph, stats);
653 SideEffectsAnalysis* side_effects = new (arena) SideEffectsAnalysis(graph);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700654 GVNOptimization* gvn = new (arena) GVNOptimization(graph, *side_effects, "GVN$after_arch");
Alexandre Rames22aa54b2016-10-18 09:32:29 +0100655 HInstructionScheduling* scheduling =
656 new (arena) HInstructionScheduling(graph, instruction_set);
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100657 HOptimization* arm64_optimizations[] = {
658 simplifier,
659 side_effects,
Alexandre Rames22aa54b2016-10-18 09:32:29 +0100660 gvn,
661 scheduling,
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100662 };
663 RunOptimizations(arm64_optimizations, arraysize(arm64_optimizations), pass_observer);
664 break;
665 }
666#endif
Alexey Frunzee3fb2452016-05-10 16:08:05 -0700667#ifdef ART_ENABLE_CODEGEN_mips
668 case kMips: {
669 mips::PcRelativeFixups* pc_relative_fixups =
670 new (arena) mips::PcRelativeFixups(graph, codegen, stats);
Alexey Frunzee3fb2452016-05-10 16:08:05 -0700671 HOptimization* mips_optimizations[] = {
672 pc_relative_fixups,
Alexey Frunzee3fb2452016-05-10 16:08:05 -0700673 };
674 RunOptimizations(mips_optimizations, arraysize(mips_optimizations), pass_observer);
675 break;
676 }
677#endif
Mark Mendell0616ae02015-04-17 12:49:27 -0400678#ifdef ART_ENABLE_CODEGEN_x86
679 case kX86: {
Aart Bikd1c40452016-03-02 16:06:13 -0800680 x86::PcRelativeFixups* pc_relative_fixups =
681 new (arena) x86::PcRelativeFixups(graph, codegen, stats);
Mark Mendellee8d9712016-07-12 11:13:15 -0400682 x86::X86MemoryOperandGeneration* memory_gen =
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700683 new (arena) x86::X86MemoryOperandGeneration(graph, codegen, stats);
Mark Mendell0616ae02015-04-17 12:49:27 -0400684 HOptimization* x86_optimizations[] = {
Mark Mendellee8d9712016-07-12 11:13:15 -0400685 pc_relative_fixups,
686 memory_gen
Mark Mendell0616ae02015-04-17 12:49:27 -0400687 };
688 RunOptimizations(x86_optimizations, arraysize(x86_optimizations), pass_observer);
689 break;
690 }
691#endif
Mark Mendellee8d9712016-07-12 11:13:15 -0400692#ifdef ART_ENABLE_CODEGEN_x86_64
693 case kX86_64: {
694 x86::X86MemoryOperandGeneration* memory_gen =
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700695 new (arena) x86::X86MemoryOperandGeneration(graph, codegen, stats);
Mark Mendellee8d9712016-07-12 11:13:15 -0400696 HOptimization* x86_64_optimizations[] = {
697 memory_gen
698 };
699 RunOptimizations(x86_64_optimizations, arraysize(x86_64_optimizations), pass_observer);
700 break;
701 }
702#endif
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100703 default:
704 break;
705 }
706}
707
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000708NO_INLINE // Avoid increasing caller's frame size by large stack-allocated objects.
709static void AllocateRegisters(HGraph* graph,
710 CodeGenerator* codegen,
Matthew Gharrity2cd05b72016-08-03 16:57:37 -0700711 PassObserver* pass_observer,
Igor Murashkin6ef45672017-08-08 13:59:55 -0700712 RegisterAllocator::Strategy strategy,
713 OptimizingCompilerStats* stats) {
Mingyao Yang700347e2016-03-02 14:59:32 -0800714 {
715 PassScope scope(PrepareForRegisterAllocation::kPrepareForRegisterAllocationPassName,
716 pass_observer);
Igor Murashkin6ef45672017-08-08 13:59:55 -0700717 PrepareForRegisterAllocation(graph, stats).Run();
Mingyao Yang700347e2016-03-02 14:59:32 -0800718 }
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000719 SsaLivenessAnalysis liveness(graph, codegen);
720 {
721 PassScope scope(SsaLivenessAnalysis::kLivenessPassName, pass_observer);
722 liveness.Analyze();
723 }
724 {
725 PassScope scope(RegisterAllocator::kRegisterAllocatorPassName, pass_observer);
Matthew Gharrity2cd05b72016-08-03 16:57:37 -0700726 RegisterAllocator::Create(graph->GetArena(), codegen, liveness, strategy)->AllocateRegisters();
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000727 }
728}
729
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700730void OptimizingCompiler::RunOptimizations(HGraph* graph,
731 CodeGenerator* codegen,
732 CompilerDriver* driver,
733 const DexCompilationUnit& dex_compilation_unit,
734 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700735 VariableSizedHandleScope* handles) const {
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700736 OptimizingCompilerStats* stats = compilation_stats_.get();
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100737 ArenaAllocator* arena = graph->GetArena();
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700738 if (driver->GetCompilerOptions().GetPassesToRun() != nullptr) {
739 ArenaVector<HOptimization*> optimizations = BuildOptimizations(
740 *driver->GetCompilerOptions().GetPassesToRun(),
741 arena,
742 graph,
743 stats,
744 codegen,
745 driver,
746 dex_compilation_unit,
747 handles);
748 RunOptimizations(&optimizations[0], optimizations.size(), pass_observer);
749 return;
750 }
751
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100752 HDeadCodeElimination* dce1 = new (arena) HDeadCodeElimination(
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700753 graph, stats, "dead_code_elimination$initial");
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100754 HDeadCodeElimination* dce2 = new (arena) HDeadCodeElimination(
Aart Bik2767f4b2016-10-28 15:03:53 -0700755 graph, stats, "dead_code_elimination$after_inlining");
756 HDeadCodeElimination* dce3 = new (arena) HDeadCodeElimination(
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700757 graph, stats, "dead_code_elimination$final");
Andreas Gampeca620d72016-11-08 08:09:33 -0800758 HConstantFolding* fold1 = new (arena) HConstantFolding(graph, "constant_folding");
Vladimir Marko65979462017-05-19 17:25:12 +0100759 InstructionSimplifier* simplify1 = new (arena) InstructionSimplifier(
760 graph, codegen, driver, stats);
Mads Ager16e52892017-07-14 13:11:37 +0200761 HSelectGenerator* select_generator = new (arena) HSelectGenerator(graph, handles, stats);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700762 HConstantFolding* fold2 = new (arena) HConstantFolding(
763 graph, "constant_folding$after_inlining");
764 HConstantFolding* fold3 = new (arena) HConstantFolding(graph, "constant_folding$after_bce");
Aart Bik92685a82017-03-06 11:13:43 -0800765 SideEffectsAnalysis* side_effects1 = new (arena) SideEffectsAnalysis(
766 graph, "side_effects$before_gvn");
767 SideEffectsAnalysis* side_effects2 = new (arena) SideEffectsAnalysis(
768 graph, "side_effects$before_lse");
769 GVNOptimization* gvn = new (arena) GVNOptimization(graph, *side_effects1);
770 LICM* licm = new (arena) LICM(graph, *side_effects1, stats);
Aart Bik22af3be2015-09-10 12:50:58 -0700771 HInductionVarAnalysis* induction = new (arena) HInductionVarAnalysis(graph);
Aart Bik92685a82017-03-06 11:13:43 -0800772 BoundsCheckElimination* bce = new (arena) BoundsCheckElimination(graph, *side_effects1, induction);
Aart Bikb92cc332017-09-06 15:53:17 -0700773 HLoopOptimization* loop = new (arena) HLoopOptimization(graph, driver, induction, stats);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100774 LoadStoreAnalysis* lsa = new (arena) LoadStoreAnalysis(graph);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700775 LoadStoreElimination* lse = new (arena) LoadStoreElimination(graph, *side_effects2, *lsa, stats);
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000776 HSharpening* sharpening = new (arena) HSharpening(
777 graph, codegen, dex_compilation_unit, driver, handles);
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100778 InstructionSimplifier* simplify2 = new (arena) InstructionSimplifier(
Vladimir Marko65979462017-05-19 17:25:12 +0100779 graph, codegen, driver, stats, "instruction_simplifier$after_inlining");
David Brazdil4833f5a2015-12-16 10:37:39 +0000780 InstructionSimplifier* simplify3 = new (arena) InstructionSimplifier(
Vladimir Marko65979462017-05-19 17:25:12 +0100781 graph, codegen, driver, stats, "instruction_simplifier$after_bce");
Aart Bik639cc8c2016-10-18 13:03:31 -0700782 InstructionSimplifier* simplify4 = new (arena) InstructionSimplifier(
Vladimir Marko65979462017-05-19 17:25:12 +0100783 graph, codegen, driver, stats, "instruction_simplifier$before_codegen");
Nicolas Geoffray762869d2016-07-15 15:28:35 +0100784 IntrinsicsRecognizer* intrinsics = new (arena) IntrinsicsRecognizer(graph, stats);
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800785 CHAGuardOptimization* cha_guard = new (arena) CHAGuardOptimization(graph);
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +0000786 CodeSinking* code_sinking = new (arena) CodeSinking(graph, stats);
Andreas Gampe71fb52f2014-12-29 17:43:08 -0800787
Calin Juravleec748352015-07-29 13:52:12 +0100788 HOptimization* optimizations1[] = {
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100789 intrinsics,
David Brazdil4833f5a2015-12-16 10:37:39 +0000790 sharpening,
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100791 fold1,
792 simplify1,
Nicolas Geoffray18e68732015-06-17 23:09:05 +0100793 dce1,
Calin Juravleec748352015-07-29 13:52:12 +0100794 };
Calin Juravleec748352015-07-29 13:52:12 +0100795 RunOptimizations(optimizations1, arraysize(optimizations1), pass_observer);
796
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700797 MaybeRunInliner(graph, codegen, driver, dex_compilation_unit, pass_observer, handles);
David Brazdil95177982015-10-30 12:56:58 -0500798
David Brazdil8993caf2015-12-07 10:04:40 +0000799 HOptimization* optimizations2[] = {
David Brazdil74eb1b22015-12-14 11:44:01 +0000800 // SelectGenerator depends on the InstructionSimplifier removing
David Brazdil8993caf2015-12-07 10:04:40 +0000801 // redundant suspend checks to recognize empty blocks.
David Brazdil74eb1b22015-12-14 11:44:01 +0000802 select_generator,
David Brazdil8993caf2015-12-07 10:04:40 +0000803 fold2, // TODO: if we don't inline we can also skip fold2.
Aart Bik639cc8c2016-10-18 13:03:31 -0700804 simplify2,
Aart Bik2767f4b2016-10-28 15:03:53 -0700805 dce2,
Aart Bik92685a82017-03-06 11:13:43 -0800806 side_effects1,
David Brazdil8993caf2015-12-07 10:04:40 +0000807 gvn,
808 licm,
809 induction,
810 bce,
Aart Bik281c6812016-08-26 11:31:48 -0700811 loop,
David Brazdil8993caf2015-12-07 10:04:40 +0000812 fold3, // evaluates code generated by dynamic bce
Aart Bik639cc8c2016-10-18 13:03:31 -0700813 simplify3,
Aart Bik92685a82017-03-06 11:13:43 -0800814 side_effects2,
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100815 lsa,
David Brazdil8993caf2015-12-07 10:04:40 +0000816 lse,
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800817 cha_guard,
Aart Bik2767f4b2016-10-28 15:03:53 -0700818 dce3,
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +0000819 code_sinking,
David Brazdil8993caf2015-12-07 10:04:40 +0000820 // The codegen has a few assumptions that only the instruction simplifier
821 // can satisfy. For example, the code generator does not expect to see a
822 // HTypeConversion from a type to the same type.
Aart Bik639cc8c2016-10-18 13:03:31 -0700823 simplify4,
David Brazdil8993caf2015-12-07 10:04:40 +0000824 };
825 RunOptimizations(optimizations2, arraysize(optimizations2), pass_observer);
David Brazdilbbd733e2015-08-18 17:48:17 +0100826
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700827 RunArchOptimizations(driver->GetInstructionSet(), graph, codegen, pass_observer);
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000828}
829
Vladimir Marko58155012015-08-19 12:49:41 +0000830static ArenaVector<LinkerPatch> EmitAndSortLinkerPatches(CodeGenerator* codegen) {
831 ArenaVector<LinkerPatch> linker_patches(codegen->GetGraph()->GetArena()->Adapter());
832 codegen->EmitLinkerPatches(&linker_patches);
833
834 // Sort patches by literal offset. Required for .oat_patches encoding.
835 std::sort(linker_patches.begin(), linker_patches.end(),
836 [](const LinkerPatch& lhs, const LinkerPatch& rhs) {
837 return lhs.LiteralOffset() < rhs.LiteralOffset();
838 });
839
840 return linker_patches;
841}
842
David Brazdil58282f42016-01-14 12:45:10 +0000843CompiledMethod* OptimizingCompiler::Emit(ArenaAllocator* arena,
844 CodeVectorAllocator* code_allocator,
845 CodeGenerator* codegen,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000846 CompilerDriver* compiler_driver,
847 const DexFile::CodeItem* code_item) const {
Vladimir Marko58155012015-08-19 12:49:41 +0000848 ArenaVector<LinkerPatch> linker_patches = EmitAndSortLinkerPatches(codegen);
Vladimir Markof9f64412015-09-02 14:05:49 +0100849 ArenaVector<uint8_t> stack_map(arena->Adapter(kArenaAllocStackMaps));
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -0700850 ArenaVector<uint8_t> method_info(arena->Adapter(kArenaAllocStackMaps));
851 size_t stack_map_size = 0;
852 size_t method_info_size = 0;
853 codegen->ComputeStackMapAndMethodInfoSize(&stack_map_size, &method_info_size);
854 stack_map.resize(stack_map_size);
855 method_info.resize(method_info_size);
856 codegen->BuildStackMaps(MemoryRegion(stack_map.data(), stack_map.size()),
857 MemoryRegion(method_info.data(), method_info.size()),
858 *code_item);
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000859
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100860 CompiledMethod* compiled_method = CompiledMethod::SwapAllocCompiledMethod(
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000861 compiler_driver,
862 codegen->GetInstructionSet(),
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000863 ArrayRef<const uint8_t>(code_allocator->GetMemory()),
Roland Levillainaa9b7c42015-02-17 15:40:09 +0000864 // Follow Quick's behavior and set the frame size to zero if it is
865 // considered "empty" (see the definition of
866 // art::CodeGenerator::HasEmptyFrame).
867 codegen->HasEmptyFrame() ? 0 : codegen->GetFrameSize(),
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000868 codegen->GetCoreSpillMask(),
Nicolas Geoffrayd97dc402015-01-22 13:50:01 +0000869 codegen->GetFpuSpillMask(),
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -0700870 ArrayRef<const uint8_t>(method_info),
David Srbeckyc6b4dd82015-04-07 20:32:43 +0100871 ArrayRef<const uint8_t>(stack_map),
David Srbeckyc6b4dd82015-04-07 20:32:43 +0100872 ArrayRef<const uint8_t>(*codegen->GetAssembler()->cfi().data()),
Vladimir Marko58155012015-08-19 12:49:41 +0000873 ArrayRef<const LinkerPatch>(linker_patches));
Mathieu Chartiered150002015-08-28 11:16:54 -0700874
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100875 return compiled_method;
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000876}
877
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000878CodeGenerator* OptimizingCompiler::TryCompile(ArenaAllocator* arena,
879 CodeVectorAllocator* code_allocator,
880 const DexFile::CodeItem* code_item,
881 uint32_t access_flags,
882 InvokeType invoke_type,
883 uint16_t class_def_idx,
884 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000885 Handle<mirror::ClassLoader> class_loader,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000886 const DexFile& dex_file,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000887 Handle<mirror::DexCache> dex_cache,
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000888 ArtMethod* method,
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000889 bool osr,
890 VariableSizedHandleScope* handles) const {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700891 MaybeRecordStat(compilation_stats_.get(),
892 MethodCompilationStat::kAttemptCompilation);
Calin Juravlecd6dffe2015-01-08 17:35:35 +0000893 CompilerDriver* compiler_driver = GetCompilerDriver();
894 InstructionSet instruction_set = compiler_driver->GetInstructionSet();
Calin Juravlecff8cc72015-10-09 12:03:24 +0100895
Roland Levillain3b359c72015-11-17 19:35:12 +0000896 // Always use the Thumb-2 assembler: some runtime functionality
897 // (like implicit stack overflow checks) assume Thumb-2.
Artem Serovba6b6792016-08-15 14:22:07 +0100898 DCHECK_NE(instruction_set, kArm);
Nicolas Geoffray8fb5ce32014-07-04 09:43:26 +0100899
900 // Do not attempt to compile on architectures we do not support.
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000901 if (!IsInstructionSetSupported(instruction_set)) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700902 MaybeRecordStat(compilation_stats_.get(),
903 MethodCompilationStat::kNotCompiledUnsupportedIsa);
Nicolas Geoffray8fb5ce32014-07-04 09:43:26 +0100904 return nullptr;
905 }
906
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +0000907 if (Compiler::IsPathologicalCase(*code_item, method_idx, dex_file)) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700908 MaybeRecordStat(compilation_stats_.get(),
909 MethodCompilationStat::kNotCompiledPathological);
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +0000910 return nullptr;
911 }
912
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000913 // Implementation of the space filter: do not compile a code item whose size in
Nicolas Geoffray432bf3d2015-07-17 11:11:09 +0100914 // code units is bigger than 128.
915 static constexpr size_t kSpaceFilterOptimizingThreshold = 128;
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000916 const CompilerOptions& compiler_options = compiler_driver->GetCompilerOptions();
Andreas Gampe29d38e72016-03-23 15:31:51 +0000917 if ((compiler_options.GetCompilerFilter() == CompilerFilter::kSpace)
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000918 && (code_item->insns_size_in_code_units_ > kSpaceFilterOptimizingThreshold)) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700919 MaybeRecordStat(compilation_stats_.get(),
920 MethodCompilationStat::kNotCompiledSpaceFilter);
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000921 return nullptr;
922 }
923
Vladimir Marko97d7e1c2016-10-04 14:44:28 +0100924 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +0000925 DexCompilationUnit dex_compilation_unit(
Vladimir Markodf739842016-03-23 16:59:07 +0000926 class_loader,
Vladimir Marko97d7e1c2016-10-04 14:44:28 +0100927 class_linker,
Vladimir Markodf739842016-03-23 16:59:07 +0000928 dex_file,
929 code_item,
930 class_def_idx,
931 method_idx,
932 access_flags,
933 /* verified_method */ nullptr,
934 dex_cache);
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +0000935
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000936 HGraph* graph = new (arena) HGraph(
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000937 arena,
938 dex_file,
939 method_idx,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000940 compiler_driver->GetInstructionSet(),
941 kInvalidInvokeType,
942 compiler_driver->GetCompilerOptions().GetDebuggable(),
943 osr);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000944
David Brazdilbadd8262016-02-02 16:28:56 +0000945 const uint8_t* interpreter_metadata = nullptr;
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000946 if (method == nullptr) {
David Brazdilbadd8262016-02-02 16:28:56 +0000947 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000948 method = compiler_driver->ResolveMethod(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000949 soa, dex_cache, class_loader, &dex_compilation_unit, method_idx, invoke_type);
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000950 }
951 // For AOT compilation, we may not get a method, for example if its class is erroneous.
952 // JIT should always have a method.
953 DCHECK(Runtime::Current()->IsAotCompiler() || method != nullptr);
954 if (method != nullptr) {
955 graph->SetArtMethod(method);
956 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko97d7e1c2016-10-04 14:44:28 +0100957 interpreter_metadata = method->GetQuickenedInfo(class_linker->GetImagePointerSize());
David Brazdilbadd8262016-02-02 16:28:56 +0000958 }
959
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000960 std::unique_ptr<CodeGenerator> codegen(
Calin Juravlecd6dffe2015-01-08 17:35:35 +0000961 CodeGenerator::Create(graph,
962 instruction_set,
963 *compiler_driver->GetInstructionSetFeatures(),
Calin Juravle2ae48182016-03-16 14:05:09 +0000964 compiler_driver->GetCompilerOptions(),
965 compilation_stats_.get()));
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000966 if (codegen.get() == nullptr) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700967 MaybeRecordStat(compilation_stats_.get(),
968 MethodCompilationStat::kNotCompiledNoCodegen);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000969 return nullptr;
970 }
David Srbeckyc6b4dd82015-04-07 20:32:43 +0100971 codegen->GetAssembler()->cfi().SetEnabled(
David Srbecky5b1c2ca2016-01-25 17:32:41 +0000972 compiler_driver->GetCompilerOptions().GenerateAnyDebugInfo());
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000973
David Brazdil69ba7b72015-06-23 18:27:30 +0100974 PassObserver pass_observer(graph,
David Brazdil69ba7b72015-06-23 18:27:30 +0100975 codegen.get(),
976 visualizer_output_.get(),
Andreas Gampea0d81af2016-10-27 12:04:57 -0700977 compiler_driver,
978 dump_mutex_);
David Brazdil5e8b1372015-01-23 14:39:08 +0000979
David Brazdil809658e2015-02-05 11:34:02 +0000980 {
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000981 VLOG(compiler) << "Building " << pass_observer.GetMethodName();
982 PassScope scope(HGraphBuilder::kBuilderPassName, &pass_observer);
983 HGraphBuilder builder(graph,
984 &dex_compilation_unit,
985 &dex_compilation_unit,
986 &dex_file,
987 *code_item,
988 compiler_driver,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000989 codegen.get(),
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000990 compilation_stats_.get(),
991 interpreter_metadata,
992 dex_cache,
993 handles);
994 GraphAnalysisResult result = builder.BuildGraph();
995 if (result != kAnalysisSuccess) {
996 switch (result) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700997 case kAnalysisSkipped: {
998 MaybeRecordStat(compilation_stats_.get(),
999 MethodCompilationStat::kNotCompiledSkipped);
1000 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001001 break;
Igor Murashkin1e065a52017-08-09 13:20:34 -07001002 case kAnalysisInvalidBytecode: {
1003 MaybeRecordStat(compilation_stats_.get(),
1004 MethodCompilationStat::kNotCompiledInvalidBytecode);
1005 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001006 break;
Igor Murashkin1e065a52017-08-09 13:20:34 -07001007 case kAnalysisFailThrowCatchLoop: {
1008 MaybeRecordStat(compilation_stats_.get(),
1009 MethodCompilationStat::kNotCompiledThrowCatchLoop);
1010 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001011 break;
Igor Murashkin1e065a52017-08-09 13:20:34 -07001012 case kAnalysisFailAmbiguousArrayOp: {
1013 MaybeRecordStat(compilation_stats_.get(),
1014 MethodCompilationStat::kNotCompiledAmbiguousArrayOp);
1015 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001016 break;
1017 case kAnalysisSuccess:
1018 UNREACHABLE();
David Brazdil809658e2015-02-05 11:34:02 +00001019 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001020 pass_observer.SetGraphInBadState();
1021 return nullptr;
Nicolas Geoffrayf5370122014-12-02 11:51:19 +00001022 }
David Brazdilbadd8262016-02-02 16:28:56 +00001023 }
Vladimir Markof9f64412015-09-02 14:05:49 +01001024
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001025 RunOptimizations(graph,
1026 codegen.get(),
1027 compiler_driver,
1028 dex_compilation_unit,
1029 &pass_observer,
1030 handles);
1031
1032 RegisterAllocator::Strategy regalloc_strategy =
1033 compiler_options.GetRegisterAllocationStrategy();
Igor Murashkin1e065a52017-08-09 13:20:34 -07001034 AllocateRegisters(graph,
1035 codegen.get(),
1036 &pass_observer,
Igor Murashkin6ef45672017-08-08 13:59:55 -07001037 regalloc_strategy,
1038 compilation_stats_.get());
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001039
1040 codegen->Compile(code_allocator);
1041 pass_observer.DumpDisassembly();
1042
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001043 return codegen.release();
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001044}
1045
Nicolas Geoffray216eaa22015-03-17 17:09:30 +00001046CompiledMethod* OptimizingCompiler::Compile(const DexFile::CodeItem* code_item,
1047 uint32_t access_flags,
1048 InvokeType invoke_type,
1049 uint16_t class_def_idx,
1050 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001051 Handle<mirror::ClassLoader> jclass_loader,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001052 const DexFile& dex_file,
1053 Handle<mirror::DexCache> dex_cache) const {
Calin Juravlef1c6d9e2015-04-13 18:42:21 +01001054 CompilerDriver* compiler_driver = GetCompilerDriver();
1055 CompiledMethod* method = nullptr;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001056 DCHECK(Runtime::Current()->IsAotCompiler());
1057 const VerifiedMethod* verified_method = compiler_driver->GetVerifiedMethod(&dex_file, method_idx);
1058 DCHECK(!verified_method->HasRuntimeThrow());
1059 if (compiler_driver->IsMethodVerifiedWithoutFailures(method_idx, class_def_idx, dex_file)
Andreas Gampe6d7abbd2017-04-24 13:19:09 -07001060 || verifier::CanCompilerHandleVerificationFailure(
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001061 verified_method->GetEncounteredVerificationFailures())) {
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001062 ArenaAllocator arena(Runtime::Current()->GetArenaPool());
1063 CodeVectorAllocator code_allocator(&arena);
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001064 std::unique_ptr<CodeGenerator> codegen;
1065 {
1066 ScopedObjectAccess soa(Thread::Current());
1067 VariableSizedHandleScope handles(soa.Self());
1068 // Go to native so that we don't block GC during compilation.
1069 ScopedThreadSuspension sts(soa.Self(), kNative);
1070 codegen.reset(
1071 TryCompile(&arena,
1072 &code_allocator,
1073 code_item,
1074 access_flags,
1075 invoke_type,
1076 class_def_idx,
1077 method_idx,
1078 jclass_loader,
1079 dex_file,
1080 dex_cache,
1081 nullptr,
1082 /* osr */ false,
1083 &handles));
1084 }
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001085 if (codegen.get() != nullptr) {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001086 MaybeRecordStat(compilation_stats_.get(),
1087 MethodCompilationStat::kCompiled);
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001088 method = Emit(&arena, &code_allocator, codegen.get(), compiler_driver, code_item);
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001089
1090 if (kArenaAllocatorCountAllocations) {
1091 if (arena.BytesAllocated() > kArenaAllocatorMemoryReportThreshold) {
1092 MemStats mem_stats(arena.GetMemStats());
David Sehr709b0702016-10-13 09:12:37 -07001093 LOG(INFO) << dex_file.PrettyMethod(method_idx) << " " << Dumpable<MemStats>(mem_stats);
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001094 }
1095 }
Calin Juravlef1c6d9e2015-04-13 18:42:21 +01001096 }
Nicolas Geoffray0c3c2662015-10-15 13:53:04 +01001097 } else {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001098 MethodCompilationStat method_stat;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001099 if (compiler_driver->GetCompilerOptions().VerifyAtRuntime()) {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001100 method_stat = MethodCompilationStat::kNotCompiledVerifyAtRuntime;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001101 } else {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001102 method_stat = MethodCompilationStat::kNotCompiledVerificationError;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001103 }
Igor Murashkin1e065a52017-08-09 13:20:34 -07001104 MaybeRecordStat(compilation_stats_.get(), method_stat);
Calin Juravlef1c6d9e2015-04-13 18:42:21 +01001105 }
1106
Calin Juravlecff8cc72015-10-09 12:03:24 +01001107 if (kIsDebugBuild &&
1108 IsCompilingWithCoreImage() &&
Goran Jakovljevic9c4f0d8f2017-04-05 16:27:25 +02001109 IsInstructionSetSupported(compiler_driver->GetInstructionSet())) {
Roland Levillain0d5a2812015-11-13 10:07:31 +00001110 // For testing purposes, we put a special marker on method names
Goran Jakovljevic9c4f0d8f2017-04-05 16:27:25 +02001111 // that should be compiled with this compiler (when the
1112 // instruction set is supported). This makes sure we're not
Roland Levillain0d5a2812015-11-13 10:07:31 +00001113 // regressing.
David Sehr709b0702016-10-13 09:12:37 -07001114 std::string method_name = dex_file.PrettyMethod(method_idx);
Calin Juravle09b1d6f2015-10-07 12:08:54 +01001115 bool shouldCompile = method_name.find("$opt$") != std::string::npos;
1116 DCHECK((method != nullptr) || !shouldCompile) << "Didn't compile " << method_name;
1117 }
1118
Nicolas Geoffray12be74e2015-03-30 13:29:08 +01001119 return method;
Nicolas Geoffray216eaa22015-03-17 17:09:30 +00001120}
1121
Andreas Gampe53c913b2014-08-12 23:19:23 -07001122Compiler* CreateOptimizingCompiler(CompilerDriver* driver) {
1123 return new OptimizingCompiler(driver);
1124}
1125
Nicolas Geoffray335005e2015-06-25 10:01:47 +01001126bool IsCompilingWithCoreImage() {
1127 const std::string& image = Runtime::Current()->GetImageLocation();
Roland Levillain2b03a1f2017-06-06 16:09:59 +01001128 return CompilerDriver::IsCoreImageFilename(image);
Nicolas Geoffray335005e2015-06-25 10:01:47 +01001129}
1130
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001131bool EncodeArtMethodInInlineInfo(ArtMethod* method ATTRIBUTE_UNUSED) {
1132 // Note: the runtime is null only for unit testing.
1133 return Runtime::Current() == nullptr || !Runtime::Current()->IsAotCompiler();
1134}
1135
1136bool CanEncodeInlinedMethodInStackMap(const DexFile& caller_dex_file, ArtMethod* callee) {
1137 if (!Runtime::Current()->IsAotCompiler()) {
1138 // JIT can always encode methods in stack maps.
1139 return true;
1140 }
1141 if (IsSameDexFile(caller_dex_file, *callee->GetDexFile())) {
1142 return true;
1143 }
1144 // TODO(ngeoffray): Support more AOT cases for inlining:
1145 // - methods in multidex
1146 // - methods in boot image for on-device non-PIC compilation.
1147 return false;
1148}
1149
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001150bool OptimizingCompiler::JitCompile(Thread* self,
1151 jit::JitCodeCache* code_cache,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001152 ArtMethod* method,
Nicolas Geoffray01db5f72017-07-19 15:05:49 +01001153 bool osr,
1154 jit::JitLogger* jit_logger) {
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001155 StackHandleScope<3> hs(self);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001156 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1157 method->GetDeclaringClass()->GetClassLoader()));
1158 Handle<mirror::DexCache> dex_cache(hs.NewHandle(method->GetDexCache()));
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001159 DCHECK(method->IsCompilable());
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001160
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001161 const DexFile* dex_file = method->GetDexFile();
1162 const uint16_t class_def_idx = method->GetClassDefIndex();
1163 const DexFile::CodeItem* code_item = dex_file->GetCodeItem(method->GetCodeItemOffset());
1164 const uint32_t method_idx = method->GetDexMethodIndex();
1165 const uint32_t access_flags = method->GetAccessFlags();
1166 const InvokeType invoke_type = method->GetInvokeType();
1167
Nicolas Geoffray25e04562016-03-01 13:17:58 +00001168 ArenaAllocator arena(Runtime::Current()->GetJitArenaPool());
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001169 CodeVectorAllocator code_allocator(&arena);
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001170 VariableSizedHandleScope handles(self);
1171
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001172 std::unique_ptr<CodeGenerator> codegen;
1173 {
1174 // Go to native so that we don't block GC during compilation.
1175 ScopedThreadSuspension sts(self, kNative);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001176 codegen.reset(
1177 TryCompile(&arena,
1178 &code_allocator,
1179 code_item,
1180 access_flags,
1181 invoke_type,
1182 class_def_idx,
1183 method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001184 class_loader,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001185 *dex_file,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001186 dex_cache,
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +00001187 method,
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001188 osr,
1189 &handles));
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001190 if (codegen.get() == nullptr) {
1191 return false;
1192 }
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001193
1194 if (kArenaAllocatorCountAllocations) {
1195 if (arena.BytesAllocated() > kArenaAllocatorMemoryReportThreshold) {
1196 MemStats mem_stats(arena.GetMemStats());
David Sehr709b0702016-10-13 09:12:37 -07001197 LOG(INFO) << dex_file->PrettyMethod(method_idx) << " " << Dumpable<MemStats>(mem_stats);
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001198 }
1199 }
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001200 }
1201
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001202 size_t stack_map_size = 0;
1203 size_t method_info_size = 0;
1204 codegen->ComputeStackMapAndMethodInfoSize(&stack_map_size, &method_info_size);
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001205 size_t number_of_roots = codegen->GetNumberOfJitRoots();
1206 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1207 // We allocate an object array to ensure the JIT roots that we will collect in EmitJitRoots
1208 // will be visible by the GC between EmitLiterals and CommitCode. Once CommitCode is
1209 // executed, this array is not needed.
1210 Handle<mirror::ObjectArray<mirror::Object>> roots(
1211 hs.NewHandle(mirror::ObjectArray<mirror::Object>::Alloc(
1212 self, class_linker->GetClassRoot(ClassLinker::kObjectArrayClass), number_of_roots)));
Andreas Gampefa4333d2017-02-14 11:10:34 -08001213 if (roots == nullptr) {
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001214 // Out of memory, just clear the exception to avoid any Java exception uncaught problems.
1215 DCHECK(self->IsExceptionPending());
1216 self->ClearException();
1217 return false;
1218 }
1219 uint8_t* stack_map_data = nullptr;
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001220 uint8_t* method_info_data = nullptr;
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001221 uint8_t* roots_data = nullptr;
Orion Hodsondbd05fe2017-08-10 11:41:35 +01001222 uint32_t data_size = code_cache->ReserveData(self,
1223 stack_map_size,
1224 method_info_size,
1225 number_of_roots,
1226 method,
1227 &stack_map_data,
1228 &method_info_data,
1229 &roots_data);
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001230 if (stack_map_data == nullptr || roots_data == nullptr) {
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001231 return false;
1232 }
Igor Murashkin1e065a52017-08-09 13:20:34 -07001233 MaybeRecordStat(compilation_stats_.get(), MethodCompilationStat::kCompiled);
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001234 codegen->BuildStackMaps(MemoryRegion(stack_map_data, stack_map_size),
1235 MemoryRegion(method_info_data, method_info_size),
1236 *code_item);
Nicolas Geoffrayf0acfe72017-01-09 20:54:52 +00001237 codegen->EmitJitRoots(code_allocator.GetData(), roots, roots_data);
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001238
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001239 const void* code = code_cache->CommitCode(
1240 self,
1241 method,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001242 stack_map_data,
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001243 method_info_data,
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001244 roots_data,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001245 codegen->HasEmptyFrame() ? 0 : codegen->GetFrameSize(),
1246 codegen->GetCoreSpillMask(),
1247 codegen->GetFpuSpillMask(),
1248 code_allocator.GetMemory().data(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001249 code_allocator.GetSize(),
Orion Hodsondbd05fe2017-08-10 11:41:35 +01001250 data_size,
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001251 osr,
Mingyao Yang063fc772016-08-02 11:02:54 -07001252 roots,
1253 codegen->GetGraph()->HasShouldDeoptimizeFlag(),
1254 codegen->GetGraph()->GetCHASingleImplementationList());
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001255
1256 if (code == nullptr) {
Nicolas Geoffrayf46501c2016-11-22 13:45:36 +00001257 code_cache->ClearData(self, stack_map_data, roots_data);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001258 return false;
1259 }
1260
David Srbecky91cc06c2016-03-07 16:13:58 +00001261 const CompilerOptions& compiler_options = GetCompilerDriver()->GetCompilerOptions();
1262 if (compiler_options.GetGenerateDebugInfo()) {
David Srbecky5cc349f2015-12-18 15:04:48 +00001263 const auto* method_header = reinterpret_cast<const OatQuickMethodHeader*>(code);
1264 const uintptr_t code_address = reinterpret_cast<uintptr_t>(method_header->GetCode());
David Srbecky09c2a6b2016-03-11 17:11:44 +00001265 debug::MethodDebugInfo info = debug::MethodDebugInfo();
1266 info.trampoline_name = nullptr;
David Srbecky197160d2016-03-07 17:33:57 +00001267 info.dex_file = dex_file;
1268 info.class_def_index = class_def_idx;
1269 info.dex_method_index = method_idx;
1270 info.access_flags = access_flags;
1271 info.code_item = code_item;
1272 info.isa = codegen->GetInstructionSet();
1273 info.deduped = false;
1274 info.is_native_debuggable = compiler_options.GetNativeDebuggable();
1275 info.is_optimized = true;
1276 info.is_code_address_text_relative = false;
1277 info.code_address = code_address;
1278 info.code_size = code_allocator.GetSize();
1279 info.frame_size_in_bytes = method_header->GetFrameSizeInBytes();
1280 info.code_info = stack_map_size == 0 ? nullptr : stack_map_data;
1281 info.cfi = ArrayRef<const uint8_t>(*codegen->GetAssembler()->cfi().data());
Vladimir Marko93205e32016-04-13 11:59:46 +01001282 std::vector<uint8_t> elf_file = debug::WriteDebugElfFileForMethods(
David Srbecky5d811202016-03-08 13:21:22 +00001283 GetCompilerDriver()->GetInstructionSet(),
1284 GetCompilerDriver()->GetInstructionSetFeatures(),
David Srbeckyfe736b72016-03-09 11:44:44 +00001285 ArrayRef<const debug::MethodDebugInfo>(&info, 1));
Vladimir Marko93205e32016-04-13 11:59:46 +01001286 CreateJITCodeEntryForAddress(code_address, std::move(elf_file));
David Srbecky5cc349f2015-12-18 15:04:48 +00001287 }
1288
Nicolas Geoffraya4f81542016-03-08 16:57:48 +00001289 Runtime::Current()->GetJit()->AddMemoryUsage(method, arena.BytesUsed());
Nicolas Geoffray01db5f72017-07-19 15:05:49 +01001290 if (jit_logger != nullptr) {
1291 jit_logger->WriteLog(code, code_allocator.GetSize(), method);
1292 }
Nicolas Geoffraya4f81542016-03-08 16:57:48 +00001293
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001294 return true;
1295}
1296
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001297} // namespace art