blob: a7a1c0f2c476da56f592fcc13138067c43728b04 [file] [log] [blame]
Mingyao Yangf384f882014-10-22 16:08:18 -07001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "bounds_check_elimination.h"
Aart Bikaab5b752015-09-23 11:18:57 -070018
19#include <limits>
20
21#include "base/arena_containers.h"
Aart Bik22af3be2015-09-10 12:50:58 -070022#include "induction_var_range.h"
Aart Bik4a342772015-11-30 10:17:46 -080023#include "side_effects_analysis.h"
Mingyao Yangf384f882014-10-22 16:08:18 -070024#include "nodes.h"
Mingyao Yangf384f882014-10-22 16:08:18 -070025
26namespace art {
27
28class MonotonicValueRange;
29
30/**
31 * A value bound is represented as a pair of value and constant,
32 * e.g. array.length - 1.
33 */
34class ValueBound : public ValueObject {
35 public:
Mingyao Yang0304e182015-01-30 16:41:29 -080036 ValueBound(HInstruction* instruction, int32_t constant) {
Mingyao Yang64197522014-12-05 15:56:23 -080037 if (instruction != nullptr && instruction->IsIntConstant()) {
Mingyao Yang0304e182015-01-30 16:41:29 -080038 // Normalize ValueBound with constant instruction.
39 int32_t instr_const = instruction->AsIntConstant()->GetValue();
Mingyao Yang8c8bad82015-02-09 18:13:26 -080040 if (!WouldAddOverflowOrUnderflow(instr_const, constant)) {
Mingyao Yang64197522014-12-05 15:56:23 -080041 instruction_ = nullptr;
42 constant_ = instr_const + constant;
43 return;
44 }
Mingyao Yangf384f882014-10-22 16:08:18 -070045 }
Mingyao Yang64197522014-12-05 15:56:23 -080046 instruction_ = instruction;
47 constant_ = constant;
48 }
49
Mingyao Yang8c8bad82015-02-09 18:13:26 -080050 // Return whether (left + right) overflows or underflows.
51 static bool WouldAddOverflowOrUnderflow(int32_t left, int32_t right) {
52 if (right == 0) {
53 return false;
54 }
Aart Bikaab5b752015-09-23 11:18:57 -070055 if ((right > 0) && (left <= (std::numeric_limits<int32_t>::max() - right))) {
Mingyao Yang8c8bad82015-02-09 18:13:26 -080056 // No overflow.
57 return false;
58 }
Aart Bikaab5b752015-09-23 11:18:57 -070059 if ((right < 0) && (left >= (std::numeric_limits<int32_t>::min() - right))) {
Mingyao Yang8c8bad82015-02-09 18:13:26 -080060 // No underflow.
61 return false;
62 }
63 return true;
64 }
65
Aart Bik1d239822016-02-09 14:26:34 -080066 // Return true if instruction can be expressed as "left_instruction + right_constant".
Mingyao Yang0304e182015-01-30 16:41:29 -080067 static bool IsAddOrSubAConstant(HInstruction* instruction,
Aart Bik1d239822016-02-09 14:26:34 -080068 /* out */ HInstruction** left_instruction,
69 /* out */ int32_t* right_constant) {
Aart Bikbf3f1cf2016-02-22 16:22:33 -080070 HInstruction* left_so_far = nullptr;
71 int32_t right_so_far = 0;
72 while (instruction->IsAdd() || instruction->IsSub()) {
Mingyao Yang0304e182015-01-30 16:41:29 -080073 HBinaryOperation* bin_op = instruction->AsBinaryOperation();
74 HInstruction* left = bin_op->GetLeft();
75 HInstruction* right = bin_op->GetRight();
76 if (right->IsIntConstant()) {
Aart Bikbf3f1cf2016-02-22 16:22:33 -080077 int32_t v = right->AsIntConstant()->GetValue();
78 int32_t c = instruction->IsAdd() ? v : -v;
79 if (!WouldAddOverflowOrUnderflow(right_so_far, c)) {
80 instruction = left;
81 left_so_far = left;
82 right_so_far += c;
83 continue;
84 }
Mingyao Yang0304e182015-01-30 16:41:29 -080085 }
Aart Bikbf3f1cf2016-02-22 16:22:33 -080086 break;
Mingyao Yang0304e182015-01-30 16:41:29 -080087 }
Aart Bikbf3f1cf2016-02-22 16:22:33 -080088 // Return result: either false and "null+0" or true and "instr+constant".
89 *left_instruction = left_so_far;
90 *right_constant = right_so_far;
91 return left_so_far != nullptr;
Mingyao Yang0304e182015-01-30 16:41:29 -080092 }
93
Aart Bik1d239822016-02-09 14:26:34 -080094 // Expresses any instruction as a value bound.
95 static ValueBound AsValueBound(HInstruction* instruction) {
96 if (instruction->IsIntConstant()) {
97 return ValueBound(nullptr, instruction->AsIntConstant()->GetValue());
98 }
99 HInstruction *left;
100 int32_t right;
101 if (IsAddOrSubAConstant(instruction, &left, &right)) {
102 return ValueBound(left, right);
103 }
104 return ValueBound(instruction, 0);
105 }
106
Mingyao Yang64197522014-12-05 15:56:23 -0800107 // Try to detect useful value bound format from an instruction, e.g.
108 // a constant or array length related value.
Aart Bik1d239822016-02-09 14:26:34 -0800109 static ValueBound DetectValueBoundFromValue(HInstruction* instruction, /* out */ bool* found) {
Mingyao Yang64197522014-12-05 15:56:23 -0800110 DCHECK(instruction != nullptr);
Mingyao Yangf384f882014-10-22 16:08:18 -0700111 if (instruction->IsIntConstant()) {
Mingyao Yang64197522014-12-05 15:56:23 -0800112 *found = true;
113 return ValueBound(nullptr, instruction->AsIntConstant()->GetValue());
Mingyao Yangf384f882014-10-22 16:08:18 -0700114 }
Mingyao Yang64197522014-12-05 15:56:23 -0800115
116 if (instruction->IsArrayLength()) {
117 *found = true;
118 return ValueBound(instruction, 0);
119 }
120 // Try to detect (array.length + c) format.
Mingyao Yang0304e182015-01-30 16:41:29 -0800121 HInstruction *left;
122 int32_t right;
123 if (IsAddOrSubAConstant(instruction, &left, &right)) {
124 if (left->IsArrayLength()) {
Mingyao Yang64197522014-12-05 15:56:23 -0800125 *found = true;
Mingyao Yang0304e182015-01-30 16:41:29 -0800126 return ValueBound(left, right);
Mingyao Yang64197522014-12-05 15:56:23 -0800127 }
128 }
129
130 // No useful bound detected.
131 *found = false;
132 return ValueBound::Max();
Mingyao Yangf384f882014-10-22 16:08:18 -0700133 }
134
135 HInstruction* GetInstruction() const { return instruction_; }
Mingyao Yang0304e182015-01-30 16:41:29 -0800136 int32_t GetConstant() const { return constant_; }
Mingyao Yangf384f882014-10-22 16:08:18 -0700137
Mingyao Yang0304e182015-01-30 16:41:29 -0800138 bool IsRelatedToArrayLength() const {
139 // Some bounds are created with HNewArray* as the instruction instead
140 // of HArrayLength*. They are treated the same.
141 return (instruction_ != nullptr) &&
142 (instruction_->IsArrayLength() || instruction_->IsNewArray());
Mingyao Yangf384f882014-10-22 16:08:18 -0700143 }
144
145 bool IsConstant() const {
146 return instruction_ == nullptr;
147 }
148
Aart Bikaab5b752015-09-23 11:18:57 -0700149 static ValueBound Min() { return ValueBound(nullptr, std::numeric_limits<int32_t>::min()); }
150 static ValueBound Max() { return ValueBound(nullptr, std::numeric_limits<int32_t>::max()); }
Mingyao Yangf384f882014-10-22 16:08:18 -0700151
152 bool Equals(ValueBound bound) const {
153 return instruction_ == bound.instruction_ && constant_ == bound.constant_;
154 }
155
Aart Bik22af3be2015-09-10 12:50:58 -0700156 /*
157 * Hunt "under the hood" of array lengths (leading to array references),
158 * null checks (also leading to array references), and new arrays
159 * (leading to the actual length). This makes it more likely related
160 * instructions become actually comparable.
161 */
162 static HInstruction* HuntForDeclaration(HInstruction* instruction) {
163 while (instruction->IsArrayLength() ||
164 instruction->IsNullCheck() ||
165 instruction->IsNewArray()) {
166 instruction = instruction->InputAt(0);
Mingyao Yang0304e182015-01-30 16:41:29 -0800167 }
168 return instruction;
169 }
170
171 static bool Equal(HInstruction* instruction1, HInstruction* instruction2) {
172 if (instruction1 == instruction2) {
173 return true;
174 }
Mingyao Yang0304e182015-01-30 16:41:29 -0800175 if (instruction1 == nullptr || instruction2 == nullptr) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700176 return false;
177 }
Aart Bik22af3be2015-09-10 12:50:58 -0700178 instruction1 = HuntForDeclaration(instruction1);
179 instruction2 = HuntForDeclaration(instruction2);
Mingyao Yang0304e182015-01-30 16:41:29 -0800180 return instruction1 == instruction2;
181 }
182
183 // Returns if it's certain this->bound >= `bound`.
184 bool GreaterThanOrEqualTo(ValueBound bound) const {
185 if (Equal(instruction_, bound.instruction_)) {
186 return constant_ >= bound.constant_;
187 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700188 // Not comparable. Just return false.
189 return false;
190 }
191
Mingyao Yang0304e182015-01-30 16:41:29 -0800192 // Returns if it's certain this->bound <= `bound`.
193 bool LessThanOrEqualTo(ValueBound bound) const {
194 if (Equal(instruction_, bound.instruction_)) {
195 return constant_ <= bound.constant_;
Mingyao Yangf384f882014-10-22 16:08:18 -0700196 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700197 // Not comparable. Just return false.
198 return false;
199 }
200
Aart Bik4a342772015-11-30 10:17:46 -0800201 // Returns if it's certain this->bound > `bound`.
202 bool GreaterThan(ValueBound bound) const {
203 if (Equal(instruction_, bound.instruction_)) {
204 return constant_ > bound.constant_;
205 }
206 // Not comparable. Just return false.
207 return false;
208 }
209
210 // Returns if it's certain this->bound < `bound`.
211 bool LessThan(ValueBound bound) const {
212 if (Equal(instruction_, bound.instruction_)) {
213 return constant_ < bound.constant_;
214 }
215 // Not comparable. Just return false.
216 return false;
217 }
218
Mingyao Yangf384f882014-10-22 16:08:18 -0700219 // Try to narrow lower bound. Returns the greatest of the two if possible.
220 // Pick one if they are not comparable.
221 static ValueBound NarrowLowerBound(ValueBound bound1, ValueBound bound2) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800222 if (bound1.GreaterThanOrEqualTo(bound2)) {
223 return bound1;
224 }
225 if (bound2.GreaterThanOrEqualTo(bound1)) {
226 return bound2;
Mingyao Yangf384f882014-10-22 16:08:18 -0700227 }
228
229 // Not comparable. Just pick one. We may lose some info, but that's ok.
230 // Favor constant as lower bound.
231 return bound1.IsConstant() ? bound1 : bound2;
232 }
233
234 // Try to narrow upper bound. Returns the lowest of the two if possible.
235 // Pick one if they are not comparable.
236 static ValueBound NarrowUpperBound(ValueBound bound1, ValueBound bound2) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800237 if (bound1.LessThanOrEqualTo(bound2)) {
238 return bound1;
239 }
240 if (bound2.LessThanOrEqualTo(bound1)) {
241 return bound2;
Mingyao Yangf384f882014-10-22 16:08:18 -0700242 }
243
244 // Not comparable. Just pick one. We may lose some info, but that's ok.
245 // Favor array length as upper bound.
Mingyao Yang0304e182015-01-30 16:41:29 -0800246 return bound1.IsRelatedToArrayLength() ? bound1 : bound2;
Mingyao Yangf384f882014-10-22 16:08:18 -0700247 }
248
Mingyao Yang0304e182015-01-30 16:41:29 -0800249 // Add a constant to a ValueBound.
250 // `overflow` or `underflow` will return whether the resulting bound may
251 // overflow or underflow an int.
Aart Bik1d239822016-02-09 14:26:34 -0800252 ValueBound Add(int32_t c, /* out */ bool* overflow, /* out */ bool* underflow) const {
Mingyao Yang0304e182015-01-30 16:41:29 -0800253 *overflow = *underflow = false;
Mingyao Yangf384f882014-10-22 16:08:18 -0700254 if (c == 0) {
255 return *this;
256 }
257
Mingyao Yang0304e182015-01-30 16:41:29 -0800258 int32_t new_constant;
Mingyao Yangf384f882014-10-22 16:08:18 -0700259 if (c > 0) {
Aart Bikaab5b752015-09-23 11:18:57 -0700260 if (constant_ > (std::numeric_limits<int32_t>::max() - c)) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800261 *overflow = true;
Mingyao Yang64197522014-12-05 15:56:23 -0800262 return Max();
Mingyao Yangf384f882014-10-22 16:08:18 -0700263 }
Mingyao Yang0304e182015-01-30 16:41:29 -0800264
265 new_constant = constant_ + c;
266 // (array.length + non-positive-constant) won't overflow an int.
267 if (IsConstant() || (IsRelatedToArrayLength() && new_constant <= 0)) {
268 return ValueBound(instruction_, new_constant);
269 }
270 // Be conservative.
271 *overflow = true;
272 return Max();
Mingyao Yangf384f882014-10-22 16:08:18 -0700273 } else {
Aart Bikaab5b752015-09-23 11:18:57 -0700274 if (constant_ < (std::numeric_limits<int32_t>::min() - c)) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800275 *underflow = true;
276 return Min();
Mingyao Yangf384f882014-10-22 16:08:18 -0700277 }
Mingyao Yang0304e182015-01-30 16:41:29 -0800278
279 new_constant = constant_ + c;
280 // Regardless of the value new_constant, (array.length+new_constant) will
281 // never underflow since array.length is no less than 0.
282 if (IsConstant() || IsRelatedToArrayLength()) {
283 return ValueBound(instruction_, new_constant);
284 }
285 // Be conservative.
286 *underflow = true;
287 return Min();
Mingyao Yangf384f882014-10-22 16:08:18 -0700288 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700289 }
290
291 private:
Mingyao Yangf384f882014-10-22 16:08:18 -0700292 HInstruction* instruction_;
Mingyao Yang0304e182015-01-30 16:41:29 -0800293 int32_t constant_;
Mingyao Yangf384f882014-10-22 16:08:18 -0700294};
295
296/**
297 * Represent a range of lower bound and upper bound, both being inclusive.
298 * Currently a ValueRange may be generated as a result of the following:
299 * comparisons related to array bounds, array bounds check, add/sub on top
Mingyao Yang0304e182015-01-30 16:41:29 -0800300 * of an existing value range, NewArray or a loop phi corresponding to an
Mingyao Yangf384f882014-10-22 16:08:18 -0700301 * incrementing/decrementing array index (MonotonicValueRange).
302 */
Vladimir Marko5233f932015-09-29 19:01:15 +0100303class ValueRange : public ArenaObject<kArenaAllocBoundsCheckElimination> {
Mingyao Yangf384f882014-10-22 16:08:18 -0700304 public:
305 ValueRange(ArenaAllocator* allocator, ValueBound lower, ValueBound upper)
306 : allocator_(allocator), lower_(lower), upper_(upper) {}
307
308 virtual ~ValueRange() {}
309
Mingyao Yang57e04752015-02-09 18:13:26 -0800310 virtual MonotonicValueRange* AsMonotonicValueRange() { return nullptr; }
311 bool IsMonotonicValueRange() {
Mingyao Yangf384f882014-10-22 16:08:18 -0700312 return AsMonotonicValueRange() != nullptr;
313 }
314
315 ArenaAllocator* GetAllocator() const { return allocator_; }
316 ValueBound GetLower() const { return lower_; }
317 ValueBound GetUpper() const { return upper_; }
318
Mingyao Yang3584bce2015-05-19 16:01:59 -0700319 bool IsConstantValueRange() { return lower_.IsConstant() && upper_.IsConstant(); }
320
Mingyao Yangf384f882014-10-22 16:08:18 -0700321 // If it's certain that this value range fits in other_range.
322 virtual bool FitsIn(ValueRange* other_range) const {
323 if (other_range == nullptr) {
324 return true;
325 }
326 DCHECK(!other_range->IsMonotonicValueRange());
Mingyao Yang0304e182015-01-30 16:41:29 -0800327 return lower_.GreaterThanOrEqualTo(other_range->lower_) &&
328 upper_.LessThanOrEqualTo(other_range->upper_);
Mingyao Yangf384f882014-10-22 16:08:18 -0700329 }
330
331 // Returns the intersection of this and range.
332 // If it's not possible to do intersection because some
333 // bounds are not comparable, it's ok to pick either bound.
334 virtual ValueRange* Narrow(ValueRange* range) {
335 if (range == nullptr) {
336 return this;
337 }
338
339 if (range->IsMonotonicValueRange()) {
340 return this;
341 }
342
343 return new (allocator_) ValueRange(
344 allocator_,
345 ValueBound::NarrowLowerBound(lower_, range->lower_),
346 ValueBound::NarrowUpperBound(upper_, range->upper_));
347 }
348
Mingyao Yang0304e182015-01-30 16:41:29 -0800349 // Shift a range by a constant.
350 ValueRange* Add(int32_t constant) const {
351 bool overflow, underflow;
352 ValueBound lower = lower_.Add(constant, &overflow, &underflow);
353 if (underflow) {
354 // Lower bound underflow will wrap around to positive values
355 // and invalidate the upper bound.
356 return nullptr;
Mingyao Yangf384f882014-10-22 16:08:18 -0700357 }
Mingyao Yang0304e182015-01-30 16:41:29 -0800358 ValueBound upper = upper_.Add(constant, &overflow, &underflow);
359 if (overflow) {
360 // Upper bound overflow will wrap around to negative values
361 // and invalidate the lower bound.
362 return nullptr;
Mingyao Yangf384f882014-10-22 16:08:18 -0700363 }
364 return new (allocator_) ValueRange(allocator_, lower, upper);
365 }
366
Mingyao Yangf384f882014-10-22 16:08:18 -0700367 private:
368 ArenaAllocator* const allocator_;
369 const ValueBound lower_; // inclusive
370 const ValueBound upper_; // inclusive
371
372 DISALLOW_COPY_AND_ASSIGN(ValueRange);
373};
374
375/**
376 * A monotonically incrementing/decrementing value range, e.g.
377 * the variable i in "for (int i=0; i<array.length; i++)".
378 * Special care needs to be taken to account for overflow/underflow
379 * of such value ranges.
380 */
381class MonotonicValueRange : public ValueRange {
382 public:
Mingyao Yang64197522014-12-05 15:56:23 -0800383 MonotonicValueRange(ArenaAllocator* allocator,
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700384 HPhi* induction_variable,
Mingyao Yang64197522014-12-05 15:56:23 -0800385 HInstruction* initial,
Mingyao Yang0304e182015-01-30 16:41:29 -0800386 int32_t increment,
Mingyao Yang64197522014-12-05 15:56:23 -0800387 ValueBound bound)
Aart Bikaab5b752015-09-23 11:18:57 -0700388 // To be conservative, give it full range [Min(), Max()] in case it's
Mingyao Yang64197522014-12-05 15:56:23 -0800389 // used as a regular value range, due to possible overflow/underflow.
390 : ValueRange(allocator, ValueBound::Min(), ValueBound::Max()),
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700391 induction_variable_(induction_variable),
Mingyao Yang64197522014-12-05 15:56:23 -0800392 initial_(initial),
393 increment_(increment),
394 bound_(bound) {}
Mingyao Yangf384f882014-10-22 16:08:18 -0700395
396 virtual ~MonotonicValueRange() {}
397
Mingyao Yang57e04752015-02-09 18:13:26 -0800398 int32_t GetIncrement() const { return increment_; }
Mingyao Yang57e04752015-02-09 18:13:26 -0800399 ValueBound GetBound() const { return bound_; }
Mingyao Yang3584bce2015-05-19 16:01:59 -0700400 HBasicBlock* GetLoopHeader() const {
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700401 DCHECK(induction_variable_->GetBlock()->IsLoopHeader());
402 return induction_variable_->GetBlock();
403 }
Mingyao Yang57e04752015-02-09 18:13:26 -0800404
405 MonotonicValueRange* AsMonotonicValueRange() OVERRIDE { return this; }
Mingyao Yangf384f882014-10-22 16:08:18 -0700406
407 // If it's certain that this value range fits in other_range.
408 bool FitsIn(ValueRange* other_range) const OVERRIDE {
409 if (other_range == nullptr) {
410 return true;
411 }
412 DCHECK(!other_range->IsMonotonicValueRange());
413 return false;
414 }
415
416 // Try to narrow this MonotonicValueRange given another range.
417 // Ideally it will return a normal ValueRange. But due to
418 // possible overflow/underflow, that may not be possible.
419 ValueRange* Narrow(ValueRange* range) OVERRIDE {
420 if (range == nullptr) {
421 return this;
422 }
423 DCHECK(!range->IsMonotonicValueRange());
424
425 if (increment_ > 0) {
426 // Monotonically increasing.
Mingyao Yang64197522014-12-05 15:56:23 -0800427 ValueBound lower = ValueBound::NarrowLowerBound(bound_, range->GetLower());
Aart Bikaab5b752015-09-23 11:18:57 -0700428 if (!lower.IsConstant() || lower.GetConstant() == std::numeric_limits<int32_t>::min()) {
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700429 // Lower bound isn't useful. Leave it to deoptimization.
430 return this;
431 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700432
Aart Bikaab5b752015-09-23 11:18:57 -0700433 // We currently conservatively assume max array length is Max().
434 // If we can make assumptions about the max array length, e.g. due to the max heap size,
Mingyao Yangf384f882014-10-22 16:08:18 -0700435 // divided by the element size (such as 4 bytes for each integer array), we can
436 // lower this number and rule out some possible overflows.
Aart Bikaab5b752015-09-23 11:18:57 -0700437 int32_t max_array_len = std::numeric_limits<int32_t>::max();
Mingyao Yangf384f882014-10-22 16:08:18 -0700438
Mingyao Yang0304e182015-01-30 16:41:29 -0800439 // max possible integer value of range's upper value.
Aart Bikaab5b752015-09-23 11:18:57 -0700440 int32_t upper = std::numeric_limits<int32_t>::max();
Mingyao Yang0304e182015-01-30 16:41:29 -0800441 // Try to lower upper.
442 ValueBound upper_bound = range->GetUpper();
443 if (upper_bound.IsConstant()) {
444 upper = upper_bound.GetConstant();
445 } else if (upper_bound.IsRelatedToArrayLength() && upper_bound.GetConstant() <= 0) {
446 // Normal case. e.g. <= array.length - 1.
447 upper = max_array_len + upper_bound.GetConstant();
Mingyao Yangf384f882014-10-22 16:08:18 -0700448 }
449
450 // If we can prove for the last number in sequence of initial_,
451 // initial_ + increment_, initial_ + 2 x increment_, ...
452 // that's <= upper, (last_num_in_sequence + increment_) doesn't trigger overflow,
453 // then this MonoticValueRange is narrowed to a normal value range.
454
455 // Be conservative first, assume last number in the sequence hits upper.
Mingyao Yang0304e182015-01-30 16:41:29 -0800456 int32_t last_num_in_sequence = upper;
Mingyao Yangf384f882014-10-22 16:08:18 -0700457 if (initial_->IsIntConstant()) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800458 int32_t initial_constant = initial_->AsIntConstant()->GetValue();
Mingyao Yangf384f882014-10-22 16:08:18 -0700459 if (upper <= initial_constant) {
460 last_num_in_sequence = upper;
461 } else {
Mingyao Yang0304e182015-01-30 16:41:29 -0800462 // Cast to int64_t for the substraction part to avoid int32_t overflow.
Mingyao Yangf384f882014-10-22 16:08:18 -0700463 last_num_in_sequence = initial_constant +
464 ((int64_t)upper - (int64_t)initial_constant) / increment_ * increment_;
465 }
466 }
Aart Bikaab5b752015-09-23 11:18:57 -0700467 if (last_num_in_sequence <= (std::numeric_limits<int32_t>::max() - increment_)) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700468 // No overflow. The sequence will be stopped by the upper bound test as expected.
469 return new (GetAllocator()) ValueRange(GetAllocator(), lower, range->GetUpper());
470 }
471
472 // There might be overflow. Give up narrowing.
473 return this;
474 } else {
475 DCHECK_NE(increment_, 0);
476 // Monotonically decreasing.
Mingyao Yang64197522014-12-05 15:56:23 -0800477 ValueBound upper = ValueBound::NarrowUpperBound(bound_, range->GetUpper());
Aart Bikaab5b752015-09-23 11:18:57 -0700478 if ((!upper.IsConstant() || upper.GetConstant() == std::numeric_limits<int32_t>::max()) &&
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700479 !upper.IsRelatedToArrayLength()) {
480 // Upper bound isn't useful. Leave it to deoptimization.
481 return this;
482 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700483
484 // Need to take care of underflow. Try to prove underflow won't happen
Mingyao Yang0304e182015-01-30 16:41:29 -0800485 // for common cases.
Mingyao Yangf384f882014-10-22 16:08:18 -0700486 if (range->GetLower().IsConstant()) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800487 int32_t constant = range->GetLower().GetConstant();
Aart Bikaab5b752015-09-23 11:18:57 -0700488 if (constant >= (std::numeric_limits<int32_t>::min() - increment_)) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700489 return new (GetAllocator()) ValueRange(GetAllocator(), range->GetLower(), upper);
490 }
491 }
492
Mingyao Yang0304e182015-01-30 16:41:29 -0800493 // For non-constant lower bound, just assume might be underflow. Give up narrowing.
Mingyao Yangf384f882014-10-22 16:08:18 -0700494 return this;
495 }
496 }
497
498 private:
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700499 HPhi* const induction_variable_; // Induction variable for this monotonic value range.
500 HInstruction* const initial_; // Initial value.
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700501 const int32_t increment_; // Increment for each loop iteration.
502 const ValueBound bound_; // Additional value bound info for initial_.
Mingyao Yangf384f882014-10-22 16:08:18 -0700503
504 DISALLOW_COPY_AND_ASSIGN(MonotonicValueRange);
505};
506
507class BCEVisitor : public HGraphVisitor {
508 public:
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700509 // The least number of bounds checks that should be eliminated by triggering
510 // the deoptimization technique.
511 static constexpr size_t kThresholdForAddingDeoptimize = 2;
512
Aart Bik1d239822016-02-09 14:26:34 -0800513 // Very large lengths are considered an anomaly. This is a threshold beyond which we don't
514 // bother to apply the deoptimization technique since it's likely, or sometimes certain,
515 // an AIOOBE will be thrown.
516 static constexpr uint32_t kMaxLengthForAddingDeoptimize =
Aart Bikaab5b752015-09-23 11:18:57 -0700517 std::numeric_limits<int32_t>::max() - 1024 * 1024;
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700518
Mingyao Yang3584bce2015-05-19 16:01:59 -0700519 // Added blocks for loop body entry test.
520 bool IsAddedBlock(HBasicBlock* block) const {
521 return block->GetBlockId() >= initial_block_size_;
522 }
523
Aart Bik4a342772015-11-30 10:17:46 -0800524 BCEVisitor(HGraph* graph,
525 const SideEffectsAnalysis& side_effects,
526 HInductionVarAnalysis* induction_analysis)
Aart Bik22af3be2015-09-10 12:50:58 -0700527 : HGraphVisitor(graph),
Vladimir Marko5233f932015-09-29 19:01:15 +0100528 maps_(graph->GetBlocks().size(),
529 ArenaSafeMap<int, ValueRange*>(
530 std::less<int>(),
531 graph->GetArena()->Adapter(kArenaAllocBoundsCheckElimination)),
532 graph->GetArena()->Adapter(kArenaAllocBoundsCheckElimination)),
Aart Bik1d239822016-02-09 14:26:34 -0800533 first_index_bounds_check_map_(
Vladimir Marko5233f932015-09-29 19:01:15 +0100534 std::less<int>(),
535 graph->GetArena()->Adapter(kArenaAllocBoundsCheckElimination)),
Aart Bik4a342772015-11-30 10:17:46 -0800536 early_exit_loop_(
537 std::less<uint32_t>(),
538 graph->GetArena()->Adapter(kArenaAllocBoundsCheckElimination)),
539 taken_test_loop_(
540 std::less<uint32_t>(),
541 graph->GetArena()->Adapter(kArenaAllocBoundsCheckElimination)),
542 finite_loop_(graph->GetArena()->Adapter(kArenaAllocBoundsCheckElimination)),
Aart Bik1d239822016-02-09 14:26:34 -0800543 has_dom_based_dynamic_bce_(false),
Vladimir Markofa6b93c2015-09-15 10:15:55 +0100544 initial_block_size_(graph->GetBlocks().size()),
Aart Bik4a342772015-11-30 10:17:46 -0800545 side_effects_(side_effects),
Aart Bik22af3be2015-09-10 12:50:58 -0700546 induction_range_(induction_analysis) {}
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700547
548 void VisitBasicBlock(HBasicBlock* block) OVERRIDE {
Mingyao Yang3584bce2015-05-19 16:01:59 -0700549 DCHECK(!IsAddedBlock(block));
Aart Bik1d239822016-02-09 14:26:34 -0800550 first_index_bounds_check_map_.clear();
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700551 HGraphVisitor::VisitBasicBlock(block);
Aart Bik1d239822016-02-09 14:26:34 -0800552 AddComparesWithDeoptimization(block);
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700553 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700554
Aart Bik4a342772015-11-30 10:17:46 -0800555 void Finish() {
556 // Preserve SSA structure which may have been broken by adding one or more
557 // new taken-test structures (see TransformLoopForDeoptimizationIfNeeded()).
558 InsertPhiNodes();
559
560 // Clear the loop data structures.
561 early_exit_loop_.clear();
562 taken_test_loop_.clear();
563 finite_loop_.clear();
564 }
565
Mingyao Yangf384f882014-10-22 16:08:18 -0700566 private:
567 // Return the map of proven value ranges at the beginning of a basic block.
568 ArenaSafeMap<int, ValueRange*>* GetValueRangeMap(HBasicBlock* basic_block) {
Mingyao Yang3584bce2015-05-19 16:01:59 -0700569 if (IsAddedBlock(basic_block)) {
570 // Added blocks don't keep value ranges.
571 return nullptr;
572 }
Aart Bik1d239822016-02-09 14:26:34 -0800573 return &maps_[basic_block->GetBlockId()];
Mingyao Yangf384f882014-10-22 16:08:18 -0700574 }
575
576 // Traverse up the dominator tree to look for value range info.
577 ValueRange* LookupValueRange(HInstruction* instruction, HBasicBlock* basic_block) {
578 while (basic_block != nullptr) {
579 ArenaSafeMap<int, ValueRange*>* map = GetValueRangeMap(basic_block);
Mingyao Yang3584bce2015-05-19 16:01:59 -0700580 if (map != nullptr) {
581 if (map->find(instruction->GetId()) != map->end()) {
582 return map->Get(instruction->GetId());
583 }
584 } else {
585 DCHECK(IsAddedBlock(basic_block));
Mingyao Yangf384f882014-10-22 16:08:18 -0700586 }
587 basic_block = basic_block->GetDominator();
588 }
589 // Didn't find any.
590 return nullptr;
591 }
592
Aart Bik1d239822016-02-09 14:26:34 -0800593 // Helper method to assign a new range to an instruction in given basic block.
594 void AssignRange(HBasicBlock* basic_block, HInstruction* instruction, ValueRange* range) {
595 GetValueRangeMap(basic_block)->Overwrite(instruction->GetId(), range);
596 }
597
Mingyao Yang0304e182015-01-30 16:41:29 -0800598 // Narrow the value range of `instruction` at the end of `basic_block` with `range`,
599 // and push the narrowed value range to `successor`.
Mingyao Yangf384f882014-10-22 16:08:18 -0700600 void ApplyRangeFromComparison(HInstruction* instruction, HBasicBlock* basic_block,
Mingyao Yang8c8bad82015-02-09 18:13:26 -0800601 HBasicBlock* successor, ValueRange* range) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700602 ValueRange* existing_range = LookupValueRange(instruction, basic_block);
Mingyao Yang8c8bad82015-02-09 18:13:26 -0800603 if (existing_range == nullptr) {
604 if (range != nullptr) {
Aart Bik1d239822016-02-09 14:26:34 -0800605 AssignRange(successor, instruction, range);
Mingyao Yang8c8bad82015-02-09 18:13:26 -0800606 }
607 return;
608 }
609 if (existing_range->IsMonotonicValueRange()) {
610 DCHECK(instruction->IsLoopHeaderPhi());
611 // Make sure the comparison is in the loop header so each increment is
612 // checked with a comparison.
613 if (instruction->GetBlock() != basic_block) {
614 return;
615 }
616 }
Aart Bik1d239822016-02-09 14:26:34 -0800617 AssignRange(successor, instruction, existing_range->Narrow(range));
Mingyao Yangf384f882014-10-22 16:08:18 -0700618 }
619
Mingyao Yang57e04752015-02-09 18:13:26 -0800620 // Special case that we may simultaneously narrow two MonotonicValueRange's to
621 // regular value ranges.
622 void HandleIfBetweenTwoMonotonicValueRanges(HIf* instruction,
623 HInstruction* left,
624 HInstruction* right,
625 IfCondition cond,
626 MonotonicValueRange* left_range,
627 MonotonicValueRange* right_range) {
628 DCHECK(left->IsLoopHeaderPhi());
629 DCHECK(right->IsLoopHeaderPhi());
630 if (instruction->GetBlock() != left->GetBlock()) {
631 // Comparison needs to be in loop header to make sure it's done after each
632 // increment/decrement.
633 return;
634 }
635
636 // Handle common cases which also don't have overflow/underflow concerns.
637 if (left_range->GetIncrement() == 1 &&
638 left_range->GetBound().IsConstant() &&
639 right_range->GetIncrement() == -1 &&
640 right_range->GetBound().IsRelatedToArrayLength() &&
641 right_range->GetBound().GetConstant() < 0) {
Mingyao Yang57e04752015-02-09 18:13:26 -0800642 HBasicBlock* successor = nullptr;
643 int32_t left_compensation = 0;
644 int32_t right_compensation = 0;
645 if (cond == kCondLT) {
646 left_compensation = -1;
647 right_compensation = 1;
648 successor = instruction->IfTrueSuccessor();
649 } else if (cond == kCondLE) {
650 successor = instruction->IfTrueSuccessor();
651 } else if (cond == kCondGT) {
652 successor = instruction->IfFalseSuccessor();
653 } else if (cond == kCondGE) {
654 left_compensation = -1;
655 right_compensation = 1;
656 successor = instruction->IfFalseSuccessor();
657 } else {
658 // We don't handle '=='/'!=' test in case left and right can cross and
659 // miss each other.
660 return;
661 }
662
663 if (successor != nullptr) {
664 bool overflow;
665 bool underflow;
666 ValueRange* new_left_range = new (GetGraph()->GetArena()) ValueRange(
667 GetGraph()->GetArena(),
668 left_range->GetBound(),
669 right_range->GetBound().Add(left_compensation, &overflow, &underflow));
670 if (!overflow && !underflow) {
671 ApplyRangeFromComparison(left, instruction->GetBlock(), successor,
672 new_left_range);
673 }
674
675 ValueRange* new_right_range = new (GetGraph()->GetArena()) ValueRange(
676 GetGraph()->GetArena(),
677 left_range->GetBound().Add(right_compensation, &overflow, &underflow),
678 right_range->GetBound());
679 if (!overflow && !underflow) {
680 ApplyRangeFromComparison(right, instruction->GetBlock(), successor,
681 new_right_range);
682 }
683 }
684 }
685 }
686
Mingyao Yangf384f882014-10-22 16:08:18 -0700687 // Handle "if (left cmp_cond right)".
688 void HandleIf(HIf* instruction, HInstruction* left, HInstruction* right, IfCondition cond) {
689 HBasicBlock* block = instruction->GetBlock();
690
691 HBasicBlock* true_successor = instruction->IfTrueSuccessor();
692 // There should be no critical edge at this point.
Vladimir Marko60584552015-09-03 13:35:12 +0000693 DCHECK_EQ(true_successor->GetPredecessors().size(), 1u);
Mingyao Yangf384f882014-10-22 16:08:18 -0700694
695 HBasicBlock* false_successor = instruction->IfFalseSuccessor();
696 // There should be no critical edge at this point.
Vladimir Marko60584552015-09-03 13:35:12 +0000697 DCHECK_EQ(false_successor->GetPredecessors().size(), 1u);
Mingyao Yangf384f882014-10-22 16:08:18 -0700698
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700699 ValueRange* left_range = LookupValueRange(left, block);
700 MonotonicValueRange* left_monotonic_range = nullptr;
701 if (left_range != nullptr) {
702 left_monotonic_range = left_range->AsMonotonicValueRange();
703 if (left_monotonic_range != nullptr) {
Mingyao Yang3584bce2015-05-19 16:01:59 -0700704 HBasicBlock* loop_head = left_monotonic_range->GetLoopHeader();
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700705 if (instruction->GetBlock() != loop_head) {
706 // For monotonic value range, don't handle `instruction`
707 // if it's not defined in the loop header.
708 return;
709 }
710 }
711 }
712
Mingyao Yang64197522014-12-05 15:56:23 -0800713 bool found;
714 ValueBound bound = ValueBound::DetectValueBoundFromValue(right, &found);
Mingyao Yang0304e182015-01-30 16:41:29 -0800715 // Each comparison can establish a lower bound and an upper bound
716 // for the left hand side.
Mingyao Yangf384f882014-10-22 16:08:18 -0700717 ValueBound lower = bound;
718 ValueBound upper = bound;
719 if (!found) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800720 // No constant or array.length+c format bound found.
Mingyao Yangf384f882014-10-22 16:08:18 -0700721 // For i<j, we can still use j's upper bound as i's upper bound. Same for lower.
Mingyao Yang57e04752015-02-09 18:13:26 -0800722 ValueRange* right_range = LookupValueRange(right, block);
723 if (right_range != nullptr) {
724 if (right_range->IsMonotonicValueRange()) {
Mingyao Yang57e04752015-02-09 18:13:26 -0800725 if (left_range != nullptr && left_range->IsMonotonicValueRange()) {
726 HandleIfBetweenTwoMonotonicValueRanges(instruction, left, right, cond,
727 left_range->AsMonotonicValueRange(),
728 right_range->AsMonotonicValueRange());
729 return;
730 }
731 }
732 lower = right_range->GetLower();
733 upper = right_range->GetUpper();
Mingyao Yangf384f882014-10-22 16:08:18 -0700734 } else {
735 lower = ValueBound::Min();
736 upper = ValueBound::Max();
737 }
738 }
739
Mingyao Yang0304e182015-01-30 16:41:29 -0800740 bool overflow, underflow;
Mingyao Yangf384f882014-10-22 16:08:18 -0700741 if (cond == kCondLT || cond == kCondLE) {
742 if (!upper.Equals(ValueBound::Max())) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800743 int32_t compensation = (cond == kCondLT) ? -1 : 0; // upper bound is inclusive
744 ValueBound new_upper = upper.Add(compensation, &overflow, &underflow);
745 if (overflow || underflow) {
746 return;
Mingyao Yang64197522014-12-05 15:56:23 -0800747 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700748 ValueRange* new_range = new (GetGraph()->GetArena())
749 ValueRange(GetGraph()->GetArena(), ValueBound::Min(), new_upper);
750 ApplyRangeFromComparison(left, block, true_successor, new_range);
751 }
752
753 // array.length as a lower bound isn't considered useful.
Mingyao Yang0304e182015-01-30 16:41:29 -0800754 if (!lower.Equals(ValueBound::Min()) && !lower.IsRelatedToArrayLength()) {
755 int32_t compensation = (cond == kCondLE) ? 1 : 0; // lower bound is inclusive
756 ValueBound new_lower = lower.Add(compensation, &overflow, &underflow);
757 if (overflow || underflow) {
758 return;
Mingyao Yang64197522014-12-05 15:56:23 -0800759 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700760 ValueRange* new_range = new (GetGraph()->GetArena())
761 ValueRange(GetGraph()->GetArena(), new_lower, ValueBound::Max());
762 ApplyRangeFromComparison(left, block, false_successor, new_range);
763 }
764 } else if (cond == kCondGT || cond == kCondGE) {
765 // array.length as a lower bound isn't considered useful.
Mingyao Yang0304e182015-01-30 16:41:29 -0800766 if (!lower.Equals(ValueBound::Min()) && !lower.IsRelatedToArrayLength()) {
767 int32_t compensation = (cond == kCondGT) ? 1 : 0; // lower bound is inclusive
768 ValueBound new_lower = lower.Add(compensation, &overflow, &underflow);
769 if (overflow || underflow) {
770 return;
Mingyao Yang64197522014-12-05 15:56:23 -0800771 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700772 ValueRange* new_range = new (GetGraph()->GetArena())
773 ValueRange(GetGraph()->GetArena(), new_lower, ValueBound::Max());
774 ApplyRangeFromComparison(left, block, true_successor, new_range);
775 }
776
777 if (!upper.Equals(ValueBound::Max())) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800778 int32_t compensation = (cond == kCondGE) ? -1 : 0; // upper bound is inclusive
779 ValueBound new_upper = upper.Add(compensation, &overflow, &underflow);
780 if (overflow || underflow) {
781 return;
Mingyao Yang64197522014-12-05 15:56:23 -0800782 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700783 ValueRange* new_range = new (GetGraph()->GetArena())
784 ValueRange(GetGraph()->GetArena(), ValueBound::Min(), new_upper);
785 ApplyRangeFromComparison(left, block, false_successor, new_range);
786 }
787 }
788 }
789
Aart Bik4a342772015-11-30 10:17:46 -0800790 void VisitBoundsCheck(HBoundsCheck* bounds_check) OVERRIDE {
Mingyao Yangf384f882014-10-22 16:08:18 -0700791 HBasicBlock* block = bounds_check->GetBlock();
792 HInstruction* index = bounds_check->InputAt(0);
793 HInstruction* array_length = bounds_check->InputAt(1);
Mingyao Yang3584bce2015-05-19 16:01:59 -0700794 DCHECK(array_length->IsIntConstant() ||
795 array_length->IsArrayLength() ||
796 array_length->IsPhi());
Aart Bik4a342772015-11-30 10:17:46 -0800797 bool try_dynamic_bce = true;
Mingyao Yangf384f882014-10-22 16:08:18 -0700798
Aart Bik1d239822016-02-09 14:26:34 -0800799 // Analyze index range.
Mingyao Yang0304e182015-01-30 16:41:29 -0800800 if (!index->IsIntConstant()) {
Aart Bik1d239822016-02-09 14:26:34 -0800801 // Non-constant index.
Aart Bik22af3be2015-09-10 12:50:58 -0700802 ValueBound lower = ValueBound(nullptr, 0); // constant 0
803 ValueBound upper = ValueBound(array_length, -1); // array_length - 1
804 ValueRange array_range(GetGraph()->GetArena(), lower, upper);
Aart Bik1d239822016-02-09 14:26:34 -0800805 // Try index range obtained by dominator-based analysis.
Mingyao Yang0304e182015-01-30 16:41:29 -0800806 ValueRange* index_range = LookupValueRange(index, block);
Aart Bik22af3be2015-09-10 12:50:58 -0700807 if (index_range != nullptr && index_range->FitsIn(&array_range)) {
Aart Bik4a342772015-11-30 10:17:46 -0800808 ReplaceInstruction(bounds_check, index);
Aart Bik22af3be2015-09-10 12:50:58 -0700809 return;
810 }
Aart Bik1d239822016-02-09 14:26:34 -0800811 // Try index range obtained by induction variable analysis.
Aart Bik4a342772015-11-30 10:17:46 -0800812 // Disables dynamic bce if OOB is certain.
813 if (InductionRangeFitsIn(&array_range, bounds_check, index, &try_dynamic_bce)) {
814 ReplaceInstruction(bounds_check, index);
Aart Bik22af3be2015-09-10 12:50:58 -0700815 return;
Mingyao Yangf384f882014-10-22 16:08:18 -0700816 }
Mingyao Yang0304e182015-01-30 16:41:29 -0800817 } else {
Aart Bik1d239822016-02-09 14:26:34 -0800818 // Constant index.
Mingyao Yang0304e182015-01-30 16:41:29 -0800819 int32_t constant = index->AsIntConstant()->GetValue();
820 if (constant < 0) {
821 // Will always throw exception.
822 return;
Aart Bik1d239822016-02-09 14:26:34 -0800823 } else if (array_length->IsIntConstant()) {
Mingyao Yang0304e182015-01-30 16:41:29 -0800824 if (constant < array_length->AsIntConstant()->GetValue()) {
Aart Bik4a342772015-11-30 10:17:46 -0800825 ReplaceInstruction(bounds_check, index);
Mingyao Yang0304e182015-01-30 16:41:29 -0800826 }
827 return;
828 }
Aart Bik1d239822016-02-09 14:26:34 -0800829 // Analyze array length range.
Mingyao Yang0304e182015-01-30 16:41:29 -0800830 DCHECK(array_length->IsArrayLength());
831 ValueRange* existing_range = LookupValueRange(array_length, block);
832 if (existing_range != nullptr) {
833 ValueBound lower = existing_range->GetLower();
834 DCHECK(lower.IsConstant());
835 if (constant < lower.GetConstant()) {
Aart Bik4a342772015-11-30 10:17:46 -0800836 ReplaceInstruction(bounds_check, index);
Mingyao Yang0304e182015-01-30 16:41:29 -0800837 return;
838 } else {
839 // Existing range isn't strong enough to eliminate the bounds check.
840 // Fall through to update the array_length range with info from this
841 // bounds check.
842 }
843 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700844 // Once we have an array access like 'array[5] = 1', we record array.length >= 6.
Mingyao Yang0304e182015-01-30 16:41:29 -0800845 // We currently don't do it for non-constant index since a valid array[i] can't prove
846 // a valid array[i-1] yet due to the lower bound side.
Aart Bikaab5b752015-09-23 11:18:57 -0700847 if (constant == std::numeric_limits<int32_t>::max()) {
848 // Max() as an index will definitely throw AIOOBE.
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700849 return;
Aart Bik1d239822016-02-09 14:26:34 -0800850 } else {
851 ValueBound lower = ValueBound(nullptr, constant + 1);
852 ValueBound upper = ValueBound::Max();
853 ValueRange* range = new (GetGraph()->GetArena())
854 ValueRange(GetGraph()->GetArena(), lower, upper);
855 AssignRange(block, array_length, range);
Mingyao Yangd43b3ac2015-04-01 14:03:04 -0700856 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700857 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700858
Aart Bik4a342772015-11-30 10:17:46 -0800859 // If static analysis fails, and OOB is not certain, try dynamic elimination.
860 if (try_dynamic_bce) {
Aart Bik1d239822016-02-09 14:26:34 -0800861 // Try loop-based dynamic elimination.
862 if (TryDynamicBCE(bounds_check)) {
863 return;
864 }
865 // Prepare dominator-based dynamic elimination.
866 if (first_index_bounds_check_map_.find(array_length->GetId()) ==
867 first_index_bounds_check_map_.end()) {
868 // Remember the first bounds check against each array_length. That bounds check
869 // instruction has an associated HEnvironment where we may add an HDeoptimize
870 // to eliminate subsequent bounds checks against the same array_length.
871 first_index_bounds_check_map_.Put(array_length->GetId(), bounds_check);
872 }
Aart Bik4a342772015-11-30 10:17:46 -0800873 }
Mingyao Yangf384f882014-10-22 16:08:18 -0700874 }
875
Nicolas Geoffraydb216f42015-05-05 17:02:20 +0100876 static bool HasSameInputAtBackEdges(HPhi* phi) {
877 DCHECK(phi->IsLoopHeaderPhi());
878 // Start with input 1. Input 0 is from the incoming block.
879 HInstruction* input1 = phi->InputAt(1);
880 DCHECK(phi->GetBlock()->GetLoopInformation()->IsBackEdge(
Vladimir Markoec7802a2015-10-01 20:57:57 +0100881 *phi->GetBlock()->GetPredecessors()[1]));
Nicolas Geoffraydb216f42015-05-05 17:02:20 +0100882 for (size_t i = 2, e = phi->InputCount(); i < e; ++i) {
883 DCHECK(phi->GetBlock()->GetLoopInformation()->IsBackEdge(
Vladimir Markoec7802a2015-10-01 20:57:57 +0100884 *phi->GetBlock()->GetPredecessors()[i]));
Nicolas Geoffraydb216f42015-05-05 17:02:20 +0100885 if (input1 != phi->InputAt(i)) {
886 return false;
887 }
888 }
889 return true;
890 }
891
Aart Bik4a342772015-11-30 10:17:46 -0800892 void VisitPhi(HPhi* phi) OVERRIDE {
Nicolas Geoffraydb216f42015-05-05 17:02:20 +0100893 if (phi->IsLoopHeaderPhi()
894 && (phi->GetType() == Primitive::kPrimInt)
895 && HasSameInputAtBackEdges(phi)) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700896 HInstruction* instruction = phi->InputAt(1);
Mingyao Yang0304e182015-01-30 16:41:29 -0800897 HInstruction *left;
898 int32_t increment;
899 if (ValueBound::IsAddOrSubAConstant(instruction, &left, &increment)) {
900 if (left == phi) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700901 HInstruction* initial_value = phi->InputAt(0);
902 ValueRange* range = nullptr;
Mingyao Yang64197522014-12-05 15:56:23 -0800903 if (increment == 0) {
Mingyao Yangf384f882014-10-22 16:08:18 -0700904 // Add constant 0. It's really a fixed value.
905 range = new (GetGraph()->GetArena()) ValueRange(
906 GetGraph()->GetArena(),
Mingyao Yang64197522014-12-05 15:56:23 -0800907 ValueBound(initial_value, 0),
908 ValueBound(initial_value, 0));
Mingyao Yangf384f882014-10-22 16:08:18 -0700909 } else {
910 // Monotonically increasing/decreasing.
Mingyao Yang64197522014-12-05 15:56:23 -0800911 bool found;
912 ValueBound bound = ValueBound::DetectValueBoundFromValue(
913 initial_value, &found);
914 if (!found) {
915 // No constant or array.length+c bound found.
916 // For i=j, we can still use j's upper bound as i's upper bound.
917 // Same for lower.
918 ValueRange* initial_range = LookupValueRange(initial_value, phi->GetBlock());
919 if (initial_range != nullptr) {
920 bound = increment > 0 ? initial_range->GetLower() :
921 initial_range->GetUpper();
922 } else {
923 bound = increment > 0 ? ValueBound::Min() : ValueBound::Max();
924 }
925 }
926 range = new (GetGraph()->GetArena()) MonotonicValueRange(
Mingyao Yangf384f882014-10-22 16:08:18 -0700927 GetGraph()->GetArena(),
Mingyao Yang206d6fd2015-04-13 16:46:28 -0700928 phi,
Mingyao Yangf384f882014-10-22 16:08:18 -0700929 initial_value,
Mingyao Yang64197522014-12-05 15:56:23 -0800930 increment,
931 bound);
Mingyao Yangf384f882014-10-22 16:08:18 -0700932 }
Aart Bik1d239822016-02-09 14:26:34 -0800933 AssignRange(phi->GetBlock(), phi, range);
Mingyao Yangf384f882014-10-22 16:08:18 -0700934 }
935 }
936 }
937 }
938
Aart Bik4a342772015-11-30 10:17:46 -0800939 void VisitIf(HIf* instruction) OVERRIDE {
Mingyao Yangf384f882014-10-22 16:08:18 -0700940 if (instruction->InputAt(0)->IsCondition()) {
941 HCondition* cond = instruction->InputAt(0)->AsCondition();
942 IfCondition cmp = cond->GetCondition();
943 if (cmp == kCondGT || cmp == kCondGE ||
944 cmp == kCondLT || cmp == kCondLE) {
945 HInstruction* left = cond->GetLeft();
946 HInstruction* right = cond->GetRight();
947 HandleIf(instruction, left, right, cmp);
948 }
949 }
950 }
951
Aart Bik4a342772015-11-30 10:17:46 -0800952 void VisitAdd(HAdd* add) OVERRIDE {
Mingyao Yangf384f882014-10-22 16:08:18 -0700953 HInstruction* right = add->GetRight();
954 if (right->IsIntConstant()) {
955 ValueRange* left_range = LookupValueRange(add->GetLeft(), add->GetBlock());
956 if (left_range == nullptr) {
957 return;
958 }
959 ValueRange* range = left_range->Add(right->AsIntConstant()->GetValue());
960 if (range != nullptr) {
Aart Bik1d239822016-02-09 14:26:34 -0800961 AssignRange(add->GetBlock(), add, range);
Mingyao Yangf384f882014-10-22 16:08:18 -0700962 }
963 }
964 }
965
Aart Bik4a342772015-11-30 10:17:46 -0800966 void VisitSub(HSub* sub) OVERRIDE {
Mingyao Yangf384f882014-10-22 16:08:18 -0700967 HInstruction* left = sub->GetLeft();
968 HInstruction* right = sub->GetRight();
969 if (right->IsIntConstant()) {
970 ValueRange* left_range = LookupValueRange(left, sub->GetBlock());
971 if (left_range == nullptr) {
972 return;
973 }
974 ValueRange* range = left_range->Add(-right->AsIntConstant()->GetValue());
975 if (range != nullptr) {
Aart Bik1d239822016-02-09 14:26:34 -0800976 AssignRange(sub->GetBlock(), sub, range);
Mingyao Yangf384f882014-10-22 16:08:18 -0700977 return;
978 }
979 }
980
981 // Here we are interested in the typical triangular case of nested loops,
982 // such as the inner loop 'for (int j=0; j<array.length-i; j++)' where i
983 // is the index for outer loop. In this case, we know j is bounded by array.length-1.
Mingyao Yang8c8bad82015-02-09 18:13:26 -0800984
985 // Try to handle (array.length - i) or (array.length + c - i) format.
986 HInstruction* left_of_left; // left input of left.
987 int32_t right_const = 0;
988 if (ValueBound::IsAddOrSubAConstant(left, &left_of_left, &right_const)) {
989 left = left_of_left;
990 }
991 // The value of left input of the sub equals (left + right_const).
992
Mingyao Yangf384f882014-10-22 16:08:18 -0700993 if (left->IsArrayLength()) {
994 HInstruction* array_length = left->AsArrayLength();
995 ValueRange* right_range = LookupValueRange(right, sub->GetBlock());
996 if (right_range != nullptr) {
997 ValueBound lower = right_range->GetLower();
998 ValueBound upper = right_range->GetUpper();
Mingyao Yang0304e182015-01-30 16:41:29 -0800999 if (lower.IsConstant() && upper.IsRelatedToArrayLength()) {
Mingyao Yangf384f882014-10-22 16:08:18 -07001000 HInstruction* upper_inst = upper.GetInstruction();
Mingyao Yang0304e182015-01-30 16:41:29 -08001001 // Make sure it's the same array.
1002 if (ValueBound::Equal(array_length, upper_inst)) {
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001003 int32_t c0 = right_const;
1004 int32_t c1 = lower.GetConstant();
1005 int32_t c2 = upper.GetConstant();
1006 // (array.length + c0 - v) where v is in [c1, array.length + c2]
1007 // gets [c0 - c2, array.length + c0 - c1] as its value range.
1008 if (!ValueBound::WouldAddOverflowOrUnderflow(c0, -c2) &&
1009 !ValueBound::WouldAddOverflowOrUnderflow(c0, -c1)) {
1010 if ((c0 - c1) <= 0) {
1011 // array.length + (c0 - c1) won't overflow/underflow.
1012 ValueRange* range = new (GetGraph()->GetArena()) ValueRange(
1013 GetGraph()->GetArena(),
1014 ValueBound(nullptr, right_const - upper.GetConstant()),
1015 ValueBound(array_length, right_const - lower.GetConstant()));
Aart Bik1d239822016-02-09 14:26:34 -08001016 AssignRange(sub->GetBlock(), sub, range);
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001017 }
1018 }
Mingyao Yangf384f882014-10-22 16:08:18 -07001019 }
1020 }
1021 }
1022 }
1023 }
1024
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001025 void FindAndHandlePartialArrayLength(HBinaryOperation* instruction) {
1026 DCHECK(instruction->IsDiv() || instruction->IsShr() || instruction->IsUShr());
1027 HInstruction* right = instruction->GetRight();
1028 int32_t right_const;
1029 if (right->IsIntConstant()) {
1030 right_const = right->AsIntConstant()->GetValue();
1031 // Detect division by two or more.
1032 if ((instruction->IsDiv() && right_const <= 1) ||
1033 (instruction->IsShr() && right_const < 1) ||
1034 (instruction->IsUShr() && right_const < 1)) {
1035 return;
1036 }
1037 } else {
1038 return;
1039 }
1040
1041 // Try to handle array.length/2 or (array.length-1)/2 format.
1042 HInstruction* left = instruction->GetLeft();
1043 HInstruction* left_of_left; // left input of left.
1044 int32_t c = 0;
1045 if (ValueBound::IsAddOrSubAConstant(left, &left_of_left, &c)) {
1046 left = left_of_left;
1047 }
1048 // The value of left input of instruction equals (left + c).
1049
1050 // (array_length + 1) or smaller divided by two or more
Aart Bikaab5b752015-09-23 11:18:57 -07001051 // always generate a value in [Min(), array_length].
1052 // This is true even if array_length is Max().
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001053 if (left->IsArrayLength() && c <= 1) {
1054 if (instruction->IsUShr() && c < 0) {
1055 // Make sure for unsigned shift, left side is not negative.
1056 // e.g. if array_length is 2, ((array_length - 3) >>> 2) is way bigger
1057 // than array_length.
1058 return;
1059 }
1060 ValueRange* range = new (GetGraph()->GetArena()) ValueRange(
1061 GetGraph()->GetArena(),
Aart Bikaab5b752015-09-23 11:18:57 -07001062 ValueBound(nullptr, std::numeric_limits<int32_t>::min()),
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001063 ValueBound(left, 0));
Aart Bik1d239822016-02-09 14:26:34 -08001064 AssignRange(instruction->GetBlock(), instruction, range);
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001065 }
1066 }
1067
Aart Bik4a342772015-11-30 10:17:46 -08001068 void VisitDiv(HDiv* div) OVERRIDE {
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001069 FindAndHandlePartialArrayLength(div);
1070 }
1071
Aart Bik4a342772015-11-30 10:17:46 -08001072 void VisitShr(HShr* shr) OVERRIDE {
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001073 FindAndHandlePartialArrayLength(shr);
1074 }
1075
Aart Bik4a342772015-11-30 10:17:46 -08001076 void VisitUShr(HUShr* ushr) OVERRIDE {
Mingyao Yang8c8bad82015-02-09 18:13:26 -08001077 FindAndHandlePartialArrayLength(ushr);
1078 }
1079
Aart Bik4a342772015-11-30 10:17:46 -08001080 void VisitAnd(HAnd* instruction) OVERRIDE {
Mingyao Yang4559f002015-02-27 14:43:53 -08001081 if (instruction->GetRight()->IsIntConstant()) {
1082 int32_t constant = instruction->GetRight()->AsIntConstant()->GetValue();
1083 if (constant > 0) {
1084 // constant serves as a mask so any number masked with it
1085 // gets a [0, constant] value range.
1086 ValueRange* range = new (GetGraph()->GetArena()) ValueRange(
1087 GetGraph()->GetArena(),
1088 ValueBound(nullptr, 0),
1089 ValueBound(nullptr, constant));
Aart Bik1d239822016-02-09 14:26:34 -08001090 AssignRange(instruction->GetBlock(), instruction, range);
Mingyao Yang4559f002015-02-27 14:43:53 -08001091 }
1092 }
1093 }
1094
Aart Bik4a342772015-11-30 10:17:46 -08001095 void VisitNewArray(HNewArray* new_array) OVERRIDE {
Mingyao Yang0304e182015-01-30 16:41:29 -08001096 HInstruction* len = new_array->InputAt(0);
1097 if (!len->IsIntConstant()) {
1098 HInstruction *left;
1099 int32_t right_const;
1100 if (ValueBound::IsAddOrSubAConstant(len, &left, &right_const)) {
1101 // (left + right_const) is used as size to new the array.
1102 // We record "-right_const <= left <= new_array - right_const";
1103 ValueBound lower = ValueBound(nullptr, -right_const);
1104 // We use new_array for the bound instead of new_array.length,
1105 // which isn't available as an instruction yet. new_array will
1106 // be treated the same as new_array.length when it's used in a ValueBound.
1107 ValueBound upper = ValueBound(new_array, -right_const);
1108 ValueRange* range = new (GetGraph()->GetArena())
1109 ValueRange(GetGraph()->GetArena(), lower, upper);
Nicolas Geoffraya09ff9c2015-06-24 10:38:27 +01001110 ValueRange* existing_range = LookupValueRange(left, new_array->GetBlock());
1111 if (existing_range != nullptr) {
1112 range = existing_range->Narrow(range);
1113 }
Aart Bik1d239822016-02-09 14:26:34 -08001114 AssignRange(new_array->GetBlock(), left, range);
Mingyao Yang0304e182015-01-30 16:41:29 -08001115 }
1116 }
1117 }
1118
Aart Bik4a342772015-11-30 10:17:46 -08001119 /**
1120 * After null/bounds checks are eliminated, some invariant array references
1121 * may be exposed underneath which can be hoisted out of the loop to the
1122 * preheader or, in combination with dynamic bce, the deoptimization block.
1123 *
1124 * for (int i = 0; i < n; i++) {
1125 * <-------+
1126 * for (int j = 0; j < n; j++) |
1127 * a[i][j] = 0; --a[i]--+
1128 * }
1129 *
Aart Bik1d239822016-02-09 14:26:34 -08001130 * Note: this optimization is no longer applied after dominator-based dynamic deoptimization
1131 * has occurred (see AddCompareWithDeoptimization()), since in those cases it would be
1132 * unsafe to hoist array references across their deoptimization instruction inside a loop.
Aart Bik4a342772015-11-30 10:17:46 -08001133 */
1134 void VisitArrayGet(HArrayGet* array_get) OVERRIDE {
Aart Bik1d239822016-02-09 14:26:34 -08001135 if (!has_dom_based_dynamic_bce_ && array_get->IsInLoop()) {
Aart Bik4a342772015-11-30 10:17:46 -08001136 HLoopInformation* loop = array_get->GetBlock()->GetLoopInformation();
Mingyao Yang4b467ed2015-11-19 17:04:22 -08001137 if (loop->IsDefinedOutOfTheLoop(array_get->InputAt(0)) &&
1138 loop->IsDefinedOutOfTheLoop(array_get->InputAt(1))) {
Aart Bik4a342772015-11-30 10:17:46 -08001139 SideEffects loop_effects = side_effects_.GetLoopEffects(loop->GetHeader());
1140 if (!array_get->GetSideEffects().MayDependOn(loop_effects)) {
Aart Bik55b14df2016-01-12 14:12:47 -08001141 HoistToPreHeaderOrDeoptBlock(loop, array_get);
Aart Bik4a342772015-11-30 10:17:46 -08001142 }
1143 }
1144 }
1145 }
1146
Aart Bik1d239822016-02-09 14:26:34 -08001147 // Perform dominator-based dynamic elimination on suitable set of bounds checks.
1148 void AddCompareWithDeoptimization(HBasicBlock* block,
1149 HInstruction* array_length,
1150 HInstruction* base,
1151 int32_t min_c, int32_t max_c) {
1152 HBoundsCheck* bounds_check =
1153 first_index_bounds_check_map_.Get(array_length->GetId())->AsBoundsCheck();
1154 // Construct deoptimization on single or double bounds on range [base-min_c,base+max_c],
1155 // for example either for a[0]..a[3] just 3 or for a[base-1]..a[base+3] both base-1
1156 // and base+3, since we made the assumption any in between value may occur too.
1157 static_assert(kMaxLengthForAddingDeoptimize < std::numeric_limits<int32_t>::max(),
1158 "Incorrect max length may be subject to arithmetic wrap-around");
1159 HInstruction* upper = GetGraph()->GetIntConstant(max_c);
1160 if (base == nullptr) {
1161 DCHECK_GE(min_c, 0);
1162 } else {
1163 HInstruction* lower = new (GetGraph()->GetArena())
1164 HAdd(Primitive::kPrimInt, base, GetGraph()->GetIntConstant(min_c));
1165 upper = new (GetGraph()->GetArena()) HAdd(Primitive::kPrimInt, base, upper);
1166 block->InsertInstructionBefore(lower, bounds_check);
1167 block->InsertInstructionBefore(upper, bounds_check);
1168 InsertDeoptInBlock(bounds_check, new (GetGraph()->GetArena()) HAbove(lower, upper));
1169 }
1170 InsertDeoptInBlock(bounds_check, new (GetGraph()->GetArena()) HAboveOrEqual(upper, array_length));
1171 // Flag that this kind of deoptimization has occurred.
1172 has_dom_based_dynamic_bce_ = true;
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001173 }
1174
Aart Bik1d239822016-02-09 14:26:34 -08001175 // Attempt dominator-based dynamic elimination on remaining candidates.
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001176 void AddComparesWithDeoptimization(HBasicBlock* block) {
Vladimir Markoda571cb2016-02-15 17:54:56 +00001177 for (const auto& entry : first_index_bounds_check_map_) {
1178 HBoundsCheck* bounds_check = entry.second;
Aart Bik1d239822016-02-09 14:26:34 -08001179 HInstruction* index = bounds_check->InputAt(0);
Nicolas Geoffray8df886b2015-06-24 14:57:44 +01001180 HInstruction* array_length = bounds_check->InputAt(1);
1181 if (!array_length->IsArrayLength()) {
Aart Bik1d239822016-02-09 14:26:34 -08001182 continue; // disregard phis and constants
Nicolas Geoffray8df886b2015-06-24 14:57:44 +01001183 }
Aart Bik1d239822016-02-09 14:26:34 -08001184 // Collect all bounds checks are still there and that are related as "a[base + constant]"
1185 // for a base instruction (possibly absent) and various constants. Note that no attempt
1186 // is made to partition the set into matching subsets (viz. a[0], a[1] and a[base+1] and
1187 // a[base+2] are considered as one set).
1188 // TODO: would such a partitioning be worthwhile?
1189 ValueBound value = ValueBound::AsValueBound(index);
1190 HInstruction* base = value.GetInstruction();
1191 int32_t min_c = base == nullptr ? 0 : value.GetConstant();
1192 int32_t max_c = value.GetConstant();
1193 ArenaVector<HBoundsCheck*> candidates(
1194 GetGraph()->GetArena()->Adapter(kArenaAllocBoundsCheckElimination));
1195 ArenaVector<HBoundsCheck*> standby(
1196 GetGraph()->GetArena()->Adapter(kArenaAllocBoundsCheckElimination));
1197 for (HUseIterator<HInstruction*> it2(array_length->GetUses()); !it2.Done(); it2.Advance()) {
1198 // Another bounds check in same or dominated block?
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001199 HInstruction* user = it2.Current()->GetUser();
Aart Bik1d239822016-02-09 14:26:34 -08001200 HBasicBlock* other_block = user->GetBlock();
1201 if (user->IsBoundsCheck() && block->Dominates(other_block)) {
1202 HBoundsCheck* other_bounds_check = user->AsBoundsCheck();
1203 HInstruction* other_index = other_bounds_check->InputAt(0);
1204 HInstruction* other_array_length = other_bounds_check->InputAt(1);
1205 ValueBound other_value = ValueBound::AsValueBound(other_index);
1206 if (array_length == other_array_length && base == other_value.GetInstruction()) {
1207 int32_t other_c = other_value.GetConstant();
1208 // Since a subsequent dominated block could be under a conditional, only accept
1209 // the other bounds check if it is in same block or both blocks dominate the exit.
1210 // TODO: we could improve this by testing proper post-dominance, or even if this
1211 // constant is seen along *all* conditional paths that follow.
1212 HBasicBlock* exit = GetGraph()->GetExitBlock();
1213 if (block == user->GetBlock() ||
1214 (block->Dominates(exit) && other_block->Dominates(exit))) {
1215 min_c = std::min(min_c, other_c);
1216 max_c = std::max(max_c, other_c);
1217 candidates.push_back(other_bounds_check);
1218 } else {
1219 // Add this candidate later only if it falls into the range.
1220 standby.push_back(other_bounds_check);
1221 }
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001222 }
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001223 }
1224 }
Aart Bik1d239822016-02-09 14:26:34 -08001225 // Add standby candidates that fall in selected range.
Vladimir Markoda571cb2016-02-15 17:54:56 +00001226 for (HBoundsCheck* other_bounds_check : standby) {
Aart Bik1d239822016-02-09 14:26:34 -08001227 HInstruction* other_index = other_bounds_check->InputAt(0);
1228 int32_t other_c = ValueBound::AsValueBound(other_index).GetConstant();
1229 if (min_c <= other_c && other_c <= max_c) {
1230 candidates.push_back(other_bounds_check);
1231 }
1232 }
1233 // Perform dominator-based deoptimization if it seems profitable. Note that we reject cases
1234 // where the distance min_c:max_c range gets close to the maximum possible array length,
1235 // since those cases are likely to always deopt (such situations do not necessarily go
1236 // OOB, though, since the programmer could rely on wrap-around from max to min).
1237 size_t threshold = kThresholdForAddingDeoptimize + (base == nullptr ? 0 : 1); // extra test?
1238 uint32_t distance = static_cast<uint32_t>(max_c) - static_cast<uint32_t>(min_c);
1239 if (candidates.size() >= threshold &&
1240 (base != nullptr || min_c >= 0) && // reject certain OOB
1241 distance <= kMaxLengthForAddingDeoptimize) { // reject likely/certain deopt
1242 AddCompareWithDeoptimization(block, array_length, base, min_c, max_c);
Vladimir Markoda571cb2016-02-15 17:54:56 +00001243 for (HInstruction* other_bounds_check : candidates) {
Aart Bik1d239822016-02-09 14:26:34 -08001244 ReplaceInstruction(other_bounds_check, other_bounds_check->InputAt(0));
1245 }
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001246 }
1247 }
1248 }
1249
Aart Bik4a342772015-11-30 10:17:46 -08001250 /**
1251 * Returns true if static range analysis based on induction variables can determine the bounds
1252 * check on the given array range is always satisfied with the computed index range. The output
1253 * parameter try_dynamic_bce is set to false if OOB is certain.
1254 */
1255 bool InductionRangeFitsIn(ValueRange* array_range,
1256 HInstruction* context,
1257 HInstruction* index,
1258 bool* try_dynamic_bce) {
1259 InductionVarRange::Value v1;
1260 InductionVarRange::Value v2;
1261 bool needs_finite_test = false;
Aart Bik1fc3afb2016-02-02 13:26:16 -08001262 if (induction_range_.GetInductionRange(context, index, &v1, &v2, &needs_finite_test)) {
1263 do {
1264 if (v1.is_known && (v1.a_constant == 0 || v1.a_constant == 1) &&
1265 v2.is_known && (v2.a_constant == 0 || v2.a_constant == 1)) {
1266 DCHECK(v1.a_constant == 1 || v1.instruction == nullptr);
1267 DCHECK(v2.a_constant == 1 || v2.instruction == nullptr);
1268 ValueRange index_range(GetGraph()->GetArena(),
1269 ValueBound(v1.instruction, v1.b_constant),
1270 ValueBound(v2.instruction, v2.b_constant));
1271 // If analysis reveals a certain OOB, disable dynamic BCE.
1272 if (index_range.GetLower().LessThan(array_range->GetLower()) ||
1273 index_range.GetUpper().GreaterThan(array_range->GetUpper())) {
1274 *try_dynamic_bce = false;
1275 return false;
1276 }
1277 // Use analysis for static bce only if loop is finite.
1278 if (!needs_finite_test && index_range.FitsIn(array_range)) {
1279 return true;
1280 }
Aart Bikb738d4f2015-12-03 11:23:35 -08001281 }
Aart Bik1fc3afb2016-02-02 13:26:16 -08001282 } while (induction_range_.RefineOuter(&v1, &v2));
1283 }
Aart Bik4a342772015-11-30 10:17:46 -08001284 return false;
1285 }
1286
1287 /**
1288 * When the compiler fails to remove a bounds check statically, we try to remove the bounds
1289 * check dynamically by adding runtime tests that trigger a deoptimization in case bounds
1290 * will go out of range (we want to be rather certain of that given the slowdown of
1291 * deoptimization). If no deoptimization occurs, the loop is executed with all corresponding
1292 * bounds checks and related null checks removed.
1293 */
Aart Bik1d239822016-02-09 14:26:34 -08001294 bool TryDynamicBCE(HBoundsCheck* instruction) {
Aart Bik4a342772015-11-30 10:17:46 -08001295 HLoopInformation* loop = instruction->GetBlock()->GetLoopInformation();
1296 HInstruction* index = instruction->InputAt(0);
1297 HInstruction* length = instruction->InputAt(1);
1298 // If dynamic bounds check elimination seems profitable and is possible, then proceed.
1299 bool needs_finite_test = false;
1300 bool needs_taken_test = false;
1301 if (DynamicBCESeemsProfitable(loop, instruction->GetBlock()) &&
1302 induction_range_.CanGenerateCode(
1303 instruction, index, &needs_finite_test, &needs_taken_test) &&
1304 CanHandleInfiniteLoop(loop, index, needs_finite_test) &&
1305 CanHandleLength(loop, length, needs_taken_test)) { // do this test last (may code gen)
1306 HInstruction* lower = nullptr;
1307 HInstruction* upper = nullptr;
1308 // Generate the following unsigned comparisons
1309 // if (lower > upper) deoptimize;
1310 // if (upper >= length) deoptimize;
1311 // or, for a non-induction index, just the unsigned comparison on its 'upper' value
1312 // if (upper >= length) deoptimize;
1313 // as runtime test. By restricting dynamic bce to unit strides (with a maximum of 32-bit
1314 // iterations) and by not combining access (e.g. a[i], a[i-3], a[i+5] etc.), these tests
1315 // correctly guard against any possible OOB (including arithmetic wrap-around cases).
Aart Bik55b14df2016-01-12 14:12:47 -08001316 TransformLoopForDeoptimizationIfNeeded(loop, needs_taken_test);
1317 HBasicBlock* block = GetPreHeader(loop, instruction);
Aart Bik4a342772015-11-30 10:17:46 -08001318 induction_range_.GenerateRangeCode(instruction, index, GetGraph(), block, &lower, &upper);
1319 if (lower != nullptr) {
Aart Bik1d239822016-02-09 14:26:34 -08001320 InsertDeoptInLoop(loop, block, new (GetGraph()->GetArena()) HAbove(lower, upper));
Aart Bik4a342772015-11-30 10:17:46 -08001321 }
Aart Bik1d239822016-02-09 14:26:34 -08001322 InsertDeoptInLoop(loop, block, new (GetGraph()->GetArena()) HAboveOrEqual(upper, length));
Aart Bik4a342772015-11-30 10:17:46 -08001323 ReplaceInstruction(instruction, index);
Aart Bik1d239822016-02-09 14:26:34 -08001324 return true;
Aart Bik4a342772015-11-30 10:17:46 -08001325 }
Aart Bik1d239822016-02-09 14:26:34 -08001326 return false;
Aart Bik4a342772015-11-30 10:17:46 -08001327 }
1328
1329 /**
1330 * Returns true if heuristics indicate that dynamic bce may be profitable.
1331 */
1332 bool DynamicBCESeemsProfitable(HLoopInformation* loop, HBasicBlock* block) {
1333 if (loop != nullptr) {
Nicolas Geoffray15bd2282016-01-05 15:55:41 +00001334 // The loop preheader of an irreducible loop does not dominate all the blocks in
1335 // the loop. We would need to find the common dominator of all blocks in the loop.
1336 if (loop->IsIrreducible()) {
1337 return false;
1338 }
Aart Bik4a342772015-11-30 10:17:46 -08001339 // A try boundary preheader is hard to handle.
Nicolas Geoffray15bd2282016-01-05 15:55:41 +00001340 // TODO: remove this restriction.
Aart Bik4a342772015-11-30 10:17:46 -08001341 if (loop->GetPreHeader()->GetLastInstruction()->IsTryBoundary()) {
1342 return false;
1343 }
1344 // Does loop have early-exits? If so, the full range may not be covered by the loop
1345 // at runtime and testing the range may apply deoptimization unnecessarily.
1346 if (IsEarlyExitLoop(loop)) {
1347 return false;
1348 }
1349 // Does the current basic block dominate all back edges? If not,
1350 // don't apply dynamic bce to something that may not be executed.
1351 for (HBasicBlock* back_edge : loop->GetBackEdges()) {
1352 if (!block->Dominates(back_edge)) {
1353 return false;
1354 }
1355 }
1356 // Success!
1357 return true;
1358 }
1359 return false;
1360 }
1361
1362 /**
1363 * Returns true if the loop has early exits, which implies it may not cover
1364 * the full range computed by range analysis based on induction variables.
1365 */
1366 bool IsEarlyExitLoop(HLoopInformation* loop) {
1367 const uint32_t loop_id = loop->GetHeader()->GetBlockId();
1368 // If loop has been analyzed earlier for early-exit, don't repeat the analysis.
1369 auto it = early_exit_loop_.find(loop_id);
1370 if (it != early_exit_loop_.end()) {
1371 return it->second;
1372 }
1373 // First time early-exit analysis for this loop. Since analysis requires scanning
1374 // the full loop-body, results of the analysis is stored for subsequent queries.
1375 HBlocksInLoopReversePostOrderIterator it_loop(*loop);
1376 for (it_loop.Advance(); !it_loop.Done(); it_loop.Advance()) {
1377 for (HBasicBlock* successor : it_loop.Current()->GetSuccessors()) {
1378 if (!loop->Contains(*successor)) {
1379 early_exit_loop_.Put(loop_id, true);
1380 return true;
1381 }
1382 }
1383 }
1384 early_exit_loop_.Put(loop_id, false);
1385 return false;
1386 }
1387
1388 /**
1389 * Returns true if the array length is already loop invariant, or can be made so
1390 * by handling the null check under the hood of the array length operation.
1391 */
1392 bool CanHandleLength(HLoopInformation* loop, HInstruction* length, bool needs_taken_test) {
Mingyao Yang4b467ed2015-11-19 17:04:22 -08001393 if (loop->IsDefinedOutOfTheLoop(length)) {
Aart Bik4a342772015-11-30 10:17:46 -08001394 return true;
1395 } else if (length->IsArrayLength() && length->GetBlock()->GetLoopInformation() == loop) {
1396 if (CanHandleNullCheck(loop, length->InputAt(0), needs_taken_test)) {
Aart Bik55b14df2016-01-12 14:12:47 -08001397 HoistToPreHeaderOrDeoptBlock(loop, length);
Aart Bik4a342772015-11-30 10:17:46 -08001398 return true;
1399 }
1400 }
1401 return false;
1402 }
1403
1404 /**
1405 * Returns true if the null check is already loop invariant, or can be made so
1406 * by generating a deoptimization test.
1407 */
1408 bool CanHandleNullCheck(HLoopInformation* loop, HInstruction* check, bool needs_taken_test) {
Mingyao Yang4b467ed2015-11-19 17:04:22 -08001409 if (loop->IsDefinedOutOfTheLoop(check)) {
Aart Bik4a342772015-11-30 10:17:46 -08001410 return true;
1411 } else if (check->IsNullCheck() && check->GetBlock()->GetLoopInformation() == loop) {
1412 HInstruction* array = check->InputAt(0);
Mingyao Yang4b467ed2015-11-19 17:04:22 -08001413 if (loop->IsDefinedOutOfTheLoop(array)) {
Aart Bik4a342772015-11-30 10:17:46 -08001414 // Generate: if (array == null) deoptimize;
Aart Bik55b14df2016-01-12 14:12:47 -08001415 TransformLoopForDeoptimizationIfNeeded(loop, needs_taken_test);
1416 HBasicBlock* block = GetPreHeader(loop, check);
Aart Bik4a342772015-11-30 10:17:46 -08001417 HInstruction* cond =
1418 new (GetGraph()->GetArena()) HEqual(array, GetGraph()->GetNullConstant());
Aart Bik1d239822016-02-09 14:26:34 -08001419 InsertDeoptInLoop(loop, block, cond);
Aart Bik4a342772015-11-30 10:17:46 -08001420 ReplaceInstruction(check, array);
1421 return true;
1422 }
1423 }
1424 return false;
1425 }
1426
1427 /**
1428 * Returns true if compiler can apply dynamic bce to loops that may be infinite
1429 * (e.g. for (int i = 0; i <= U; i++) with U = MAX_INT), which would invalidate
1430 * the range analysis evaluation code by "overshooting" the computed range.
1431 * Since deoptimization would be a bad choice, and there is no other version
1432 * of the loop to use, dynamic bce in such cases is only allowed if other tests
1433 * ensure the loop is finite.
1434 */
1435 bool CanHandleInfiniteLoop(
1436 HLoopInformation* loop, HInstruction* index, bool needs_infinite_test) {
1437 if (needs_infinite_test) {
1438 // If we already forced the loop to be finite, allow directly.
1439 const uint32_t loop_id = loop->GetHeader()->GetBlockId();
1440 if (finite_loop_.find(loop_id) != finite_loop_.end()) {
1441 return true;
1442 }
1443 // Otherwise, allow dynamic bce if the index (which is necessarily an induction at
1444 // this point) is the direct loop index (viz. a[i]), since then the runtime tests
1445 // ensure upper bound cannot cause an infinite loop.
1446 HInstruction* control = loop->GetHeader()->GetLastInstruction();
1447 if (control->IsIf()) {
1448 HInstruction* if_expr = control->AsIf()->InputAt(0);
1449 if (if_expr->IsCondition()) {
1450 HCondition* condition = if_expr->AsCondition();
1451 if (index == condition->InputAt(0) ||
1452 index == condition->InputAt(1)) {
1453 finite_loop_.insert(loop_id);
1454 return true;
1455 }
1456 }
1457 }
1458 return false;
1459 }
1460 return true;
1461 }
1462
Aart Bik55b14df2016-01-12 14:12:47 -08001463 /**
1464 * Returns appropriate preheader for the loop, depending on whether the
1465 * instruction appears in the loop header or proper loop-body.
1466 */
1467 HBasicBlock* GetPreHeader(HLoopInformation* loop, HInstruction* instruction) {
1468 // Use preheader unless there is an earlier generated deoptimization block since
1469 // hoisted expressions may depend on and/or used by the deoptimization tests.
1470 HBasicBlock* header = loop->GetHeader();
1471 const uint32_t loop_id = header->GetBlockId();
1472 auto it = taken_test_loop_.find(loop_id);
1473 if (it != taken_test_loop_.end()) {
1474 HBasicBlock* block = it->second;
1475 // If always taken, keep it that way by returning the original preheader,
1476 // which can be found by following the predecessor of the true-block twice.
1477 if (instruction->GetBlock() == header) {
1478 return block->GetSinglePredecessor()->GetSinglePredecessor();
1479 }
1480 return block;
1481 }
1482 return loop->GetPreHeader();
1483 }
1484
Aart Bik1d239822016-02-09 14:26:34 -08001485 /** Inserts a deoptimization test in a loop preheader. */
1486 void InsertDeoptInLoop(HLoopInformation* loop, HBasicBlock* block, HInstruction* condition) {
Aart Bik4a342772015-11-30 10:17:46 -08001487 HInstruction* suspend = loop->GetSuspendCheck();
1488 block->InsertInstructionBefore(condition, block->GetLastInstruction());
1489 HDeoptimize* deoptimize =
1490 new (GetGraph()->GetArena()) HDeoptimize(condition, suspend->GetDexPc());
1491 block->InsertInstructionBefore(deoptimize, block->GetLastInstruction());
1492 if (suspend->HasEnvironment()) {
1493 deoptimize->CopyEnvironmentFromWithLoopPhiAdjustment(
1494 suspend->GetEnvironment(), loop->GetHeader());
1495 }
1496 }
1497
Aart Bik1d239822016-02-09 14:26:34 -08001498 /** Inserts a deoptimization test right before a bounds check. */
1499 void InsertDeoptInBlock(HBoundsCheck* bounds_check, HInstruction* condition) {
1500 HBasicBlock* block = bounds_check->GetBlock();
1501 block->InsertInstructionBefore(condition, bounds_check);
1502 HDeoptimize* deoptimize =
1503 new (GetGraph()->GetArena()) HDeoptimize(condition, bounds_check->GetDexPc());
1504 block->InsertInstructionBefore(deoptimize, bounds_check);
1505 deoptimize->CopyEnvironmentFrom(bounds_check->GetEnvironment());
1506 }
1507
Aart Bik4a342772015-11-30 10:17:46 -08001508 /** Hoists instruction out of the loop to preheader or deoptimization block. */
Aart Bik55b14df2016-01-12 14:12:47 -08001509 void HoistToPreHeaderOrDeoptBlock(HLoopInformation* loop, HInstruction* instruction) {
1510 HBasicBlock* block = GetPreHeader(loop, instruction);
Aart Bik4a342772015-11-30 10:17:46 -08001511 DCHECK(!instruction->HasEnvironment());
1512 instruction->MoveBefore(block->GetLastInstruction());
1513 }
1514
1515 /**
Aart Bik55b14df2016-01-12 14:12:47 -08001516 * Adds a new taken-test structure to a loop if needed and not already done.
Aart Bik4a342772015-11-30 10:17:46 -08001517 * The taken-test protects range analysis evaluation code to avoid any
1518 * deoptimization caused by incorrect trip-count evaluation in non-taken loops.
1519 *
Aart Bik4a342772015-11-30 10:17:46 -08001520 * old_preheader
1521 * |
1522 * if_block <- taken-test protects deoptimization block
1523 * / \
1524 * true_block false_block <- deoptimizations/invariants are placed in true_block
1525 * \ /
1526 * new_preheader <- may require phi nodes to preserve SSA structure
1527 * |
1528 * header
1529 *
1530 * For example, this loop:
1531 *
1532 * for (int i = lower; i < upper; i++) {
1533 * array[i] = 0;
1534 * }
1535 *
1536 * will be transformed to:
1537 *
1538 * if (lower < upper) {
1539 * if (array == null) deoptimize;
1540 * array_length = array.length;
1541 * if (lower > upper) deoptimize; // unsigned
1542 * if (upper >= array_length) deoptimize; // unsigned
1543 * } else {
1544 * array_length = 0;
1545 * }
1546 * for (int i = lower; i < upper; i++) {
1547 * // Loop without null check and bounds check, and any array.length replaced with array_length.
1548 * array[i] = 0;
1549 * }
1550 */
Aart Bik55b14df2016-01-12 14:12:47 -08001551 void TransformLoopForDeoptimizationIfNeeded(HLoopInformation* loop, bool needs_taken_test) {
1552 // Not needed (can use preheader) or already done (can reuse)?
Aart Bik4a342772015-11-30 10:17:46 -08001553 const uint32_t loop_id = loop->GetHeader()->GetBlockId();
Aart Bik55b14df2016-01-12 14:12:47 -08001554 if (!needs_taken_test || taken_test_loop_.find(loop_id) != taken_test_loop_.end()) {
1555 return;
Aart Bik4a342772015-11-30 10:17:46 -08001556 }
1557
1558 // Generate top test structure.
1559 HBasicBlock* header = loop->GetHeader();
1560 GetGraph()->TransformLoopHeaderForBCE(header);
1561 HBasicBlock* new_preheader = loop->GetPreHeader();
1562 HBasicBlock* if_block = new_preheader->GetDominator();
1563 HBasicBlock* true_block = if_block->GetSuccessors()[0]; // True successor.
1564 HBasicBlock* false_block = if_block->GetSuccessors()[1]; // False successor.
1565
1566 // Goto instructions.
1567 true_block->AddInstruction(new (GetGraph()->GetArena()) HGoto());
1568 false_block->AddInstruction(new (GetGraph()->GetArena()) HGoto());
1569 new_preheader->AddInstruction(new (GetGraph()->GetArena()) HGoto());
1570
1571 // Insert the taken-test to see if the loop body is entered. If the
1572 // loop isn't entered at all, it jumps around the deoptimization block.
1573 if_block->AddInstruction(new (GetGraph()->GetArena()) HGoto()); // placeholder
1574 HInstruction* condition = nullptr;
1575 induction_range_.GenerateTakenTest(header->GetLastInstruction(),
1576 GetGraph(),
1577 if_block,
1578 &condition);
1579 DCHECK(condition != nullptr);
1580 if_block->RemoveInstruction(if_block->GetLastInstruction());
1581 if_block->AddInstruction(new (GetGraph()->GetArena()) HIf(condition));
1582
1583 taken_test_loop_.Put(loop_id, true_block);
Aart Bik4a342772015-11-30 10:17:46 -08001584 }
1585
1586 /**
1587 * Inserts phi nodes that preserve SSA structure in generated top test structures.
1588 * All uses of instructions in the deoptimization block that reach the loop need
1589 * a phi node in the new loop preheader to fix the dominance relation.
1590 *
1591 * Example:
1592 * if_block
1593 * / \
1594 * x_0 = .. false_block
1595 * \ /
1596 * x_1 = phi(x_0, null) <- synthetic phi
1597 * |
Aart Bik55b14df2016-01-12 14:12:47 -08001598 * new_preheader
Aart Bik4a342772015-11-30 10:17:46 -08001599 */
1600 void InsertPhiNodes() {
1601 // Scan all new deoptimization blocks.
1602 for (auto it1 = taken_test_loop_.begin(); it1 != taken_test_loop_.end(); ++it1) {
1603 HBasicBlock* true_block = it1->second;
1604 HBasicBlock* new_preheader = true_block->GetSingleSuccessor();
1605 // Scan all instructions in a new deoptimization block.
1606 for (HInstructionIterator it(true_block->GetInstructions()); !it.Done(); it.Advance()) {
1607 HInstruction* instruction = it.Current();
1608 Primitive::Type type = instruction->GetType();
1609 HPhi* phi = nullptr;
1610 // Scan all uses of an instruction and replace each later use with a phi node.
1611 for (HUseIterator<HInstruction*> it2(instruction->GetUses());
1612 !it2.Done();
1613 it2.Advance()) {
1614 HInstruction* user = it2.Current()->GetUser();
1615 if (user->GetBlock() != true_block) {
1616 if (phi == nullptr) {
1617 phi = NewPhi(new_preheader, instruction, type);
1618 }
1619 user->ReplaceInput(phi, it2.Current()->GetIndex());
1620 }
1621 }
1622 // Scan all environment uses of an instruction and replace each later use with a phi node.
1623 for (HUseIterator<HEnvironment*> it2(instruction->GetEnvUses());
1624 !it2.Done();
1625 it2.Advance()) {
1626 HEnvironment* user = it2.Current()->GetUser();
1627 if (user->GetHolder()->GetBlock() != true_block) {
1628 if (phi == nullptr) {
1629 phi = NewPhi(new_preheader, instruction, type);
1630 }
1631 user->RemoveAsUserOfInput(it2.Current()->GetIndex());
1632 user->SetRawEnvAt(it2.Current()->GetIndex(), phi);
1633 phi->AddEnvUseAt(user, it2.Current()->GetIndex());
1634 }
1635 }
1636 }
1637 }
1638 }
1639
1640 /**
1641 * Construct a phi(instruction, 0) in the new preheader to fix the dominance relation.
1642 * These are synthetic phi nodes without a virtual register.
1643 */
1644 HPhi* NewPhi(HBasicBlock* new_preheader,
1645 HInstruction* instruction,
1646 Primitive::Type type) {
1647 HGraph* graph = GetGraph();
1648 HInstruction* zero;
1649 switch (type) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001650 case Primitive::kPrimNot: zero = graph->GetNullConstant(); break;
1651 case Primitive::kPrimFloat: zero = graph->GetFloatConstant(0); break;
1652 case Primitive::kPrimDouble: zero = graph->GetDoubleConstant(0); break;
Aart Bik4a342772015-11-30 10:17:46 -08001653 default: zero = graph->GetConstant(type, 0); break;
1654 }
1655 HPhi* phi = new (graph->GetArena())
1656 HPhi(graph->GetArena(), kNoRegNumber, /*number_of_inputs*/ 2, HPhi::ToPhiType(type));
1657 phi->SetRawInputAt(0, instruction);
1658 phi->SetRawInputAt(1, zero);
David Brazdil4833f5a2015-12-16 10:37:39 +00001659 if (type == Primitive::kPrimNot) {
1660 phi->SetReferenceTypeInfo(instruction->GetReferenceTypeInfo());
1661 }
Aart Bik4a342772015-11-30 10:17:46 -08001662 new_preheader->AddPhi(phi);
1663 return phi;
1664 }
1665
1666 /** Helper method to replace an instruction with another instruction. */
1667 static void ReplaceInstruction(HInstruction* instruction, HInstruction* replacement) {
1668 instruction->ReplaceWith(replacement);
1669 instruction->GetBlock()->RemoveInstruction(instruction);
1670 }
1671
1672 // A set of maps, one per basic block, from instruction to range.
Vladimir Marko5233f932015-09-29 19:01:15 +01001673 ArenaVector<ArenaSafeMap<int, ValueRange*>> maps_;
Mingyao Yangf384f882014-10-22 16:08:18 -07001674
Aart Bik1d239822016-02-09 14:26:34 -08001675 // Map an HArrayLength instruction's id to the first HBoundsCheck instruction
1676 // in a block that checks an index against that HArrayLength.
1677 ArenaSafeMap<int, HBoundsCheck*> first_index_bounds_check_map_;
Mingyao Yangd43b3ac2015-04-01 14:03:04 -07001678
Aart Bik4a342772015-11-30 10:17:46 -08001679 // Early-exit loop bookkeeping.
1680 ArenaSafeMap<uint32_t, bool> early_exit_loop_;
1681
1682 // Taken-test loop bookkeeping.
1683 ArenaSafeMap<uint32_t, HBasicBlock*> taken_test_loop_;
1684
1685 // Finite loop bookkeeping.
1686 ArenaSet<uint32_t> finite_loop_;
1687
Aart Bik1d239822016-02-09 14:26:34 -08001688 // Flag that denotes whether dominator-based dynamic elimination has occurred.
1689 bool has_dom_based_dynamic_bce_;
Aart Bik4a342772015-11-30 10:17:46 -08001690
Mingyao Yang3584bce2015-05-19 16:01:59 -07001691 // Initial number of blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +01001692 uint32_t initial_block_size_;
Mingyao Yang3584bce2015-05-19 16:01:59 -07001693
Aart Bik4a342772015-11-30 10:17:46 -08001694 // Side effects.
1695 const SideEffectsAnalysis& side_effects_;
1696
Aart Bik22af3be2015-09-10 12:50:58 -07001697 // Range analysis based on induction variables.
1698 InductionVarRange induction_range_;
1699
Mingyao Yangf384f882014-10-22 16:08:18 -07001700 DISALLOW_COPY_AND_ASSIGN(BCEVisitor);
1701};
1702
1703void BoundsCheckElimination::Run() {
Mark Mendell1152c922015-04-24 17:06:35 -04001704 if (!graph_->HasBoundsChecks()) {
Mingyao Yange4335eb2015-03-02 15:14:13 -08001705 return;
1706 }
1707
Mingyao Yangf384f882014-10-22 16:08:18 -07001708 // Reverse post order guarantees a node's dominators are visited first.
1709 // We want to visit in the dominator-based order since if a value is known to
1710 // be bounded by a range at one instruction, it must be true that all uses of
1711 // that value dominated by that instruction fits in that range. Range of that
1712 // value can be narrowed further down in the dominator tree.
Aart Bik4a342772015-11-30 10:17:46 -08001713 BCEVisitor visitor(graph_, side_effects_, induction_analysis_);
Mingyao Yang3584bce2015-05-19 16:01:59 -07001714 HBasicBlock* last_visited_block = nullptr;
1715 for (HReversePostOrderIterator it(*graph_); !it.Done(); it.Advance()) {
1716 HBasicBlock* current = it.Current();
1717 if (current == last_visited_block) {
1718 // We may insert blocks into the reverse post order list when processing
1719 // a loop header. Don't process it again.
1720 DCHECK(current->IsLoopHeader());
1721 continue;
1722 }
1723 if (visitor.IsAddedBlock(current)) {
1724 // Skip added blocks. Their effects are already taken care of.
1725 continue;
1726 }
1727 visitor.VisitBasicBlock(current);
1728 last_visited_block = current;
1729 }
Aart Bik4a342772015-11-30 10:17:46 -08001730
1731 // Perform cleanup.
1732 visitor.Finish();
Mingyao Yangf384f882014-10-22 16:08:18 -07001733}
1734
1735} // namespace art