blob: a5cbb5f10d4c6008387653b393aae9b856873095 [file] [log] [blame]
Vladimir Markof59f18b2014-02-17 15:53:57 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Vladimir Markoaf6925b2014-10-31 16:37:32 +000017#include "dex/mir_field_info.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010018#include "global_value_numbering.h"
19#include "local_value_numbering.h"
Vladimir Markof59f18b2014-02-17 15:53:57 +000020#include "gtest/gtest.h"
21
22namespace art {
23
24class LocalValueNumberingTest : public testing::Test {
25 protected:
26 struct IFieldDef {
27 uint16_t field_idx;
28 uintptr_t declaring_dex_file;
29 uint16_t declaring_field_idx;
30 bool is_volatile;
Vladimir Markoaf6925b2014-10-31 16:37:32 +000031 DexMemAccessType type;
Vladimir Markof59f18b2014-02-17 15:53:57 +000032 };
33
34 struct SFieldDef {
35 uint16_t field_idx;
36 uintptr_t declaring_dex_file;
37 uint16_t declaring_field_idx;
38 bool is_volatile;
Vladimir Markoaf6925b2014-10-31 16:37:32 +000039 DexMemAccessType type;
Vladimir Markof59f18b2014-02-17 15:53:57 +000040 };
41
42 struct MIRDef {
43 static constexpr size_t kMaxSsaDefs = 2;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +010044 static constexpr size_t kMaxSsaUses = 4;
Vladimir Markof59f18b2014-02-17 15:53:57 +000045
46 Instruction::Code opcode;
47 int64_t value;
Vladimir Markobe0e5462014-02-26 11:24:15 +000048 uint32_t field_info;
Vladimir Markof59f18b2014-02-17 15:53:57 +000049 size_t num_uses;
50 int32_t uses[kMaxSsaUses];
51 size_t num_defs;
52 int32_t defs[kMaxSsaDefs];
53 };
54
55#define DEF_CONST(opcode, reg, value) \
56 { opcode, value, 0u, 0, { }, 1, { reg } }
57#define DEF_CONST_WIDE(opcode, reg, value) \
58 { opcode, value, 0u, 0, { }, 2, { reg, reg + 1 } }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +010059#define DEF_CONST_STRING(opcode, reg, index) \
60 { opcode, index, 0u, 0, { }, 1, { reg } }
Vladimir Markobe0e5462014-02-26 11:24:15 +000061#define DEF_IGET(opcode, reg, obj, field_info) \
62 { opcode, 0u, field_info, 1, { obj }, 1, { reg } }
63#define DEF_IGET_WIDE(opcode, reg, obj, field_info) \
64 { opcode, 0u, field_info, 1, { obj }, 2, { reg, reg + 1 } }
65#define DEF_IPUT(opcode, reg, obj, field_info) \
66 { opcode, 0u, field_info, 2, { reg, obj }, 0, { } }
67#define DEF_IPUT_WIDE(opcode, reg, obj, field_info) \
68 { opcode, 0u, field_info, 3, { reg, reg + 1, obj }, 0, { } }
69#define DEF_SGET(opcode, reg, field_info) \
70 { opcode, 0u, field_info, 0, { }, 1, { reg } }
71#define DEF_SGET_WIDE(opcode, reg, field_info) \
72 { opcode, 0u, field_info, 0, { }, 2, { reg, reg + 1 } }
73#define DEF_SPUT(opcode, reg, field_info) \
74 { opcode, 0u, field_info, 1, { reg }, 0, { } }
75#define DEF_SPUT_WIDE(opcode, reg, field_info) \
76 { opcode, 0u, field_info, 2, { reg, reg + 1 }, 0, { } }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +010077#define DEF_AGET(opcode, reg, obj, idx) \
78 { opcode, 0u, 0u, 2, { obj, idx }, 1, { reg } }
79#define DEF_AGET_WIDE(opcode, reg, obj, idx) \
80 { opcode, 0u, 0u, 2, { obj, idx }, 2, { reg, reg + 1 } }
81#define DEF_APUT(opcode, reg, obj, idx) \
82 { opcode, 0u, 0u, 3, { reg, obj, idx }, 0, { } }
83#define DEF_APUT_WIDE(opcode, reg, obj, idx) \
84 { opcode, 0u, 0u, 4, { reg, reg + 1, obj, idx }, 0, { } }
Vladimir Markof59f18b2014-02-17 15:53:57 +000085#define DEF_INVOKE1(opcode, reg) \
86 { opcode, 0u, 0u, 1, { reg }, 0, { } }
87#define DEF_UNIQUE_REF(opcode, reg) \
88 { opcode, 0u, 0u, 0, { }, 1, { reg } } // CONST_CLASS, CONST_STRING, NEW_ARRAY, ...
Razvan A Lupusorue0951142014-11-14 14:36:55 -080089#define DEF_DIV_REM(opcode, result, dividend, divisor) \
90 { opcode, 0u, 0u, 2, { dividend, divisor }, 1, { result } }
91#define DEF_DIV_REM_WIDE(opcode, result, dividend, divisor) \
92 { opcode, 0u, 0u, 4, { dividend, dividend + 1, divisor, divisor + 1 }, 2, { result, result + 1 } }
Vladimir Markof59f18b2014-02-17 15:53:57 +000093
94 void DoPrepareIFields(const IFieldDef* defs, size_t count) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010095 cu_.mir_graph->ifield_lowering_infos_.clear();
96 cu_.mir_graph->ifield_lowering_infos_.reserve(count);
Vladimir Markobe0e5462014-02-26 11:24:15 +000097 for (size_t i = 0u; i != count; ++i) {
98 const IFieldDef* def = &defs[i];
Vladimir Markoaf6925b2014-10-31 16:37:32 +000099 MirIFieldLoweringInfo field_info(def->field_idx, def->type);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000100 if (def->declaring_dex_file != 0u) {
101 field_info.declaring_dex_file_ = reinterpret_cast<const DexFile*>(def->declaring_dex_file);
102 field_info.declaring_field_idx_ = def->declaring_field_idx;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000103 field_info.flags_ &= ~(def->is_volatile ? 0u : MirSFieldLoweringInfo::kFlagIsVolatile);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000104 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100105 cu_.mir_graph->ifield_lowering_infos_.push_back(field_info);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000106 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000107 }
108
109 template <size_t count>
110 void PrepareIFields(const IFieldDef (&defs)[count]) {
111 DoPrepareIFields(defs, count);
112 }
113
114 void DoPrepareSFields(const SFieldDef* defs, size_t count) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100115 cu_.mir_graph->sfield_lowering_infos_.clear();
116 cu_.mir_graph->sfield_lowering_infos_.reserve(count);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000117 for (size_t i = 0u; i != count; ++i) {
118 const SFieldDef* def = &defs[i];
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000119 MirSFieldLoweringInfo field_info(def->field_idx, def->type);
Vladimir Markof418f322014-07-09 14:45:36 +0100120 // Mark even unresolved fields as initialized.
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000121 field_info.flags_ |= MirSFieldLoweringInfo::kFlagClassIsInitialized;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100122 // NOTE: MirSFieldLoweringInfo::kFlagClassIsInDexCache isn't used by LVN.
Vladimir Markobe0e5462014-02-26 11:24:15 +0000123 if (def->declaring_dex_file != 0u) {
124 field_info.declaring_dex_file_ = reinterpret_cast<const DexFile*>(def->declaring_dex_file);
125 field_info.declaring_field_idx_ = def->declaring_field_idx;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000126 field_info.flags_ &= ~(def->is_volatile ? 0u : MirSFieldLoweringInfo::kFlagIsVolatile);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000127 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100128 cu_.mir_graph->sfield_lowering_infos_.push_back(field_info);
Vladimir Markobe0e5462014-02-26 11:24:15 +0000129 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000130 }
131
132 template <size_t count>
133 void PrepareSFields(const SFieldDef (&defs)[count]) {
134 DoPrepareSFields(defs, count);
135 }
136
137 void DoPrepareMIRs(const MIRDef* defs, size_t count) {
138 mir_count_ = count;
Vladimir Markoe4fcc5b2015-02-13 10:28:29 +0000139 mirs_ = cu_.arena.AllocArray<MIR>(count, kArenaAllocMIR);
Vladimir Markof59f18b2014-02-17 15:53:57 +0000140 ssa_reps_.resize(count);
141 for (size_t i = 0u; i != count; ++i) {
142 const MIRDef* def = &defs[i];
143 MIR* mir = &mirs_[i];
144 mir->dalvikInsn.opcode = def->opcode;
145 mir->dalvikInsn.vB = static_cast<int32_t>(def->value);
146 mir->dalvikInsn.vB_wide = def->value;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000147 if (IsInstructionIGetOrIPut(def->opcode)) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100148 ASSERT_LT(def->field_info, cu_.mir_graph->ifield_lowering_infos_.size());
Vladimir Markobe0e5462014-02-26 11:24:15 +0000149 mir->meta.ifield_lowering_info = def->field_info;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000150 ASSERT_EQ(cu_.mir_graph->ifield_lowering_infos_[def->field_info].MemAccessType(),
151 IGetOrIPutMemAccessType(def->opcode));
152 } else if (IsInstructionSGetOrSPut(def->opcode)) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100153 ASSERT_LT(def->field_info, cu_.mir_graph->sfield_lowering_infos_.size());
Vladimir Markobe0e5462014-02-26 11:24:15 +0000154 mir->meta.sfield_lowering_info = def->field_info;
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000155 ASSERT_EQ(cu_.mir_graph->sfield_lowering_infos_[def->field_info].MemAccessType(),
156 SGetOrSPutMemAccessType(def->opcode));
Vladimir Markobe0e5462014-02-26 11:24:15 +0000157 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000158 mir->ssa_rep = &ssa_reps_[i];
159 mir->ssa_rep->num_uses = def->num_uses;
160 mir->ssa_rep->uses = const_cast<int32_t*>(def->uses); // Not modified by LVN.
161 mir->ssa_rep->fp_use = nullptr; // Not used by LVN.
162 mir->ssa_rep->num_defs = def->num_defs;
163 mir->ssa_rep->defs = const_cast<int32_t*>(def->defs); // Not modified by LVN.
164 mir->ssa_rep->fp_def = nullptr; // Not used by LVN.
165 mir->dalvikInsn.opcode = def->opcode;
166 mir->offset = i; // LVN uses offset only for debug output
Vladimir Markof59f18b2014-02-17 15:53:57 +0000167 mir->optimization_flags = 0u;
168
169 if (i != 0u) {
170 mirs_[i - 1u].next = mir;
171 }
172 }
173 mirs_[count - 1u].next = nullptr;
174 }
175
176 template <size_t count>
177 void PrepareMIRs(const MIRDef (&defs)[count]) {
178 DoPrepareMIRs(defs, count);
179 }
180
Vladimir Markof418f322014-07-09 14:45:36 +0100181 void MakeSFieldUninitialized(uint32_t sfield_index) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100182 CHECK_LT(sfield_index, cu_.mir_graph->sfield_lowering_infos_.size());
183 cu_.mir_graph->sfield_lowering_infos_[sfield_index].flags_ &=
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100184 ~MirSFieldLoweringInfo::kFlagClassIsInitialized;
Vladimir Markof418f322014-07-09 14:45:36 +0100185 }
186
Vladimir Markof59f18b2014-02-17 15:53:57 +0000187 void PerformLVN() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000188 cu_.mir_graph->temp_.gvn.ifield_ids_ = GlobalValueNumbering::PrepareGvnFieldIds(
189 allocator_.get(), cu_.mir_graph->ifield_lowering_infos_);
190 cu_.mir_graph->temp_.gvn.sfield_ids_ = GlobalValueNumbering::PrepareGvnFieldIds(
191 allocator_.get(), cu_.mir_graph->sfield_lowering_infos_);
192 gvn_.reset(new (allocator_.get()) GlobalValueNumbering(&cu_, allocator_.get(),
193 GlobalValueNumbering::kModeLvn));
194 lvn_.reset(new (allocator_.get()) LocalValueNumbering(gvn_.get(), 0u, allocator_.get()));
Vladimir Markof59f18b2014-02-17 15:53:57 +0000195 value_names_.resize(mir_count_);
196 for (size_t i = 0; i != mir_count_; ++i) {
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000197 value_names_[i] = lvn_->GetValueNumber(&mirs_[i]);
Vladimir Markof59f18b2014-02-17 15:53:57 +0000198 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100199 EXPECT_TRUE(gvn_->Good());
Vladimir Markof59f18b2014-02-17 15:53:57 +0000200 }
201
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000202 LocalValueNumberingTest()
203 : pool_(),
Andreas Gampe0b9203e2015-01-22 20:39:27 -0800204 cu_(&pool_, kRuntimeISA, nullptr, nullptr),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000205 mir_count_(0u),
206 mirs_(nullptr),
Vladimir Marko95a05972014-05-30 10:01:32 +0100207 ssa_reps_(),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100208 allocator_(),
Vladimir Marko95a05972014-05-30 10:01:32 +0100209 gvn_(),
210 lvn_(),
211 value_names_() {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000212 cu_.mir_graph.reset(new MIRGraph(&cu_, &cu_.arena));
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100213 allocator_.reset(ScopedArenaAllocator::Create(&cu_.arena_stack));
Vladimir Markof59f18b2014-02-17 15:53:57 +0000214 }
215
216 ArenaPool pool_;
217 CompilationUnit cu_;
218 size_t mir_count_;
219 MIR* mirs_;
220 std::vector<SSARepresentation> ssa_reps_;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100221 std::unique_ptr<ScopedArenaAllocator> allocator_;
Vladimir Marko95a05972014-05-30 10:01:32 +0100222 std::unique_ptr<GlobalValueNumbering> gvn_;
Ian Rogers700a4022014-05-19 16:49:03 -0700223 std::unique_ptr<LocalValueNumbering> lvn_;
Vladimir Marko95a05972014-05-30 10:01:32 +0100224 std::vector<uint16_t> value_names_;
Vladimir Markof59f18b2014-02-17 15:53:57 +0000225};
226
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100227TEST_F(LocalValueNumberingTest, IGetIGetInvokeIGet) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000228 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000229 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000230 };
231 static const MIRDef mirs[] = {
232 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
233 DEF_IGET(Instruction::IGET, 1u, 10u, 0u),
234 DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 11u),
235 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
236 };
237
238 PrepareIFields(ifields);
239 PrepareMIRs(mirs);
240 PerformLVN();
241 ASSERT_EQ(value_names_.size(), 4u);
242 EXPECT_EQ(value_names_[0], value_names_[1]);
243 EXPECT_NE(value_names_[0], value_names_[3]);
244 EXPECT_EQ(mirs_[0].optimization_flags, 0u);
245 EXPECT_EQ(mirs_[1].optimization_flags, MIR_IGNORE_NULL_CHECK);
246 EXPECT_EQ(mirs_[2].optimization_flags, 0u);
247 EXPECT_EQ(mirs_[3].optimization_flags, MIR_IGNORE_NULL_CHECK);
248}
249
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100250TEST_F(LocalValueNumberingTest, IGetIPutIGetIGetIGet) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000251 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000252 { 1u, 1u, 1u, false, kDexMemAccessObject },
253 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000254 };
255 static const MIRDef mirs[] = {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100256 DEF_IGET(Instruction::IGET_OBJECT, 0u, 10u, 0u),
257 DEF_IPUT(Instruction::IPUT_OBJECT, 1u, 11u, 0u), // May alias.
258 DEF_IGET(Instruction::IGET_OBJECT, 2u, 10u, 0u),
Vladimir Markof59f18b2014-02-17 15:53:57 +0000259 DEF_IGET(Instruction::IGET, 3u, 0u, 1u),
260 DEF_IGET(Instruction::IGET, 4u, 2u, 1u),
261 };
262
263 PrepareIFields(ifields);
264 PrepareMIRs(mirs);
265 PerformLVN();
266 ASSERT_EQ(value_names_.size(), 5u);
267 EXPECT_NE(value_names_[0], value_names_[2]);
268 EXPECT_NE(value_names_[3], value_names_[4]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100269 for (size_t i = 0; i != arraysize(mirs); ++i) {
270 EXPECT_EQ((i == 2u) ? MIR_IGNORE_NULL_CHECK : 0,
271 mirs_[i].optimization_flags) << i;
272 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000273}
274
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100275TEST_F(LocalValueNumberingTest, UniquePreserve1) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000276 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000277 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000278 };
279 static const MIRDef mirs[] = {
280 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 10u),
281 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
282 DEF_IPUT(Instruction::IPUT, 1u, 11u, 0u), // No aliasing since 10u is unique.
283 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
284 };
285
286 PrepareIFields(ifields);
287 PrepareMIRs(mirs);
288 PerformLVN();
289 ASSERT_EQ(value_names_.size(), 4u);
290 EXPECT_EQ(value_names_[1], value_names_[3]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100291 for (size_t i = 0; i != arraysize(mirs); ++i) {
292 EXPECT_EQ((i == 1u || i == 3u) ? MIR_IGNORE_NULL_CHECK : 0,
293 mirs_[i].optimization_flags) << i;
294 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000295}
296
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100297TEST_F(LocalValueNumberingTest, UniquePreserve2) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000298 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000299 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000300 };
301 static const MIRDef mirs[] = {
302 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 11u),
303 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
304 DEF_IPUT(Instruction::IPUT, 1u, 11u, 0u), // No aliasing since 11u is unique.
305 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
306 };
307
308 PrepareIFields(ifields);
309 PrepareMIRs(mirs);
310 PerformLVN();
311 ASSERT_EQ(value_names_.size(), 4u);
312 EXPECT_EQ(value_names_[1], value_names_[3]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100313 for (size_t i = 0; i != arraysize(mirs); ++i) {
314 EXPECT_EQ((i == 2u || i == 3u) ? MIR_IGNORE_NULL_CHECK : 0,
315 mirs_[i].optimization_flags) << i;
316 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000317}
318
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100319TEST_F(LocalValueNumberingTest, UniquePreserveAndEscape) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000320 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000321 { 1u, 1u, 1u, false, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000322 };
323 static const MIRDef mirs[] = {
324 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 10u),
325 DEF_IGET(Instruction::IGET, 0u, 10u, 0u),
326 DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 11u), // 10u still unique.
327 DEF_IGET(Instruction::IGET, 2u, 10u, 0u),
328 DEF_INVOKE1(Instruction::INVOKE_VIRTUAL, 10u), // 10u not unique anymore.
329 DEF_IGET(Instruction::IGET, 3u, 10u, 0u),
330 };
331
332 PrepareIFields(ifields);
333 PrepareMIRs(mirs);
334 PerformLVN();
335 ASSERT_EQ(value_names_.size(), 6u);
336 EXPECT_EQ(value_names_[1], value_names_[3]);
337 EXPECT_NE(value_names_[1], value_names_[5]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100338 for (size_t i = 0; i != arraysize(mirs); ++i) {
339 EXPECT_EQ((i == 1u || i == 3u || i == 4u || i == 5u) ? MIR_IGNORE_NULL_CHECK : 0,
340 mirs_[i].optimization_flags) << i;
341 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000342}
Vladimir Markof59f18b2014-02-17 15:53:57 +0000343
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100344TEST_F(LocalValueNumberingTest, Volatile) {
Vladimir Markof59f18b2014-02-17 15:53:57 +0000345 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000346 { 1u, 1u, 1u, false, kDexMemAccessWord },
347 { 2u, 1u, 2u, true, kDexMemAccessWord },
Vladimir Markof59f18b2014-02-17 15:53:57 +0000348 };
349 static const MIRDef mirs[] = {
350 DEF_IGET(Instruction::IGET, 0u, 10u, 1u), // Volatile.
351 DEF_IGET(Instruction::IGET, 1u, 0u, 0u), // Non-volatile.
352 DEF_IGET(Instruction::IGET, 2u, 10u, 1u), // Volatile.
353 DEF_IGET(Instruction::IGET, 3u, 2u, 1u), // Non-volatile.
Vladimir Markofa236452014-09-29 17:58:10 +0100354 DEF_IGET(Instruction::IGET, 4u, 0u, 0u), // Non-volatile.
Vladimir Markof59f18b2014-02-17 15:53:57 +0000355 };
356
357 PrepareIFields(ifields);
358 PrepareMIRs(mirs);
359 PerformLVN();
Vladimir Markofa236452014-09-29 17:58:10 +0100360 ASSERT_EQ(value_names_.size(), 5u);
Vladimir Markof59f18b2014-02-17 15:53:57 +0000361 EXPECT_NE(value_names_[0], value_names_[2]); // Volatile has always different value name.
362 EXPECT_NE(value_names_[1], value_names_[3]); // Used different base because of volatile.
Vladimir Markofa236452014-09-29 17:58:10 +0100363 EXPECT_NE(value_names_[1], value_names_[4]); // Not guaranteed to be the same after "acquire".
364
Vladimir Marko95a05972014-05-30 10:01:32 +0100365 for (size_t i = 0; i != arraysize(mirs); ++i) {
Vladimir Markofa236452014-09-29 17:58:10 +0100366 EXPECT_EQ((i == 2u || i == 4u) ? MIR_IGNORE_NULL_CHECK : 0,
Vladimir Marko95a05972014-05-30 10:01:32 +0100367 mirs_[i].optimization_flags) << i;
368 }
Vladimir Markof59f18b2014-02-17 15:53:57 +0000369}
370
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100371TEST_F(LocalValueNumberingTest, UnresolvedIField) {
372 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000373 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
374 { 2u, 1u, 2u, false, kDexMemAccessWide }, // Resolved field #2.
375 { 3u, 0u, 0u, false, kDexMemAccessWord }, // Unresolved field.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100376 };
377 static const MIRDef mirs[] = {
378 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 20u),
379 DEF_IGET(Instruction::IGET, 1u, 20u, 0u), // Resolved field #1, unique object.
380 DEF_IGET(Instruction::IGET, 2u, 21u, 0u), // Resolved field #1.
381 DEF_IGET_WIDE(Instruction::IGET_WIDE, 3u, 21u, 1u), // Resolved field #2.
Vladimir Markofa236452014-09-29 17:58:10 +0100382 DEF_IGET(Instruction::IGET, 4u, 22u, 2u), // Unresolved IGET can be "acquire".
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100383 DEF_IGET(Instruction::IGET, 5u, 20u, 0u), // Resolved field #1, unique object.
384 DEF_IGET(Instruction::IGET, 6u, 21u, 0u), // Resolved field #1.
385 DEF_IGET_WIDE(Instruction::IGET_WIDE, 7u, 21u, 1u), // Resolved field #2.
Vladimir Marko95a05972014-05-30 10:01:32 +0100386 DEF_IPUT(Instruction::IPUT, 8u, 22u, 2u), // IPUT clobbers field #1 (#2 is wide).
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100387 DEF_IGET(Instruction::IGET, 9u, 20u, 0u), // Resolved field #1, unique object.
388 DEF_IGET(Instruction::IGET, 10u, 21u, 0u), // Resolved field #1, new value name.
389 DEF_IGET_WIDE(Instruction::IGET_WIDE, 11u, 21u, 1u), // Resolved field #2.
Vladimir Marko95a05972014-05-30 10:01:32 +0100390 DEF_IGET_WIDE(Instruction::IGET_WIDE, 12u, 20u, 1u), // Resolved field #2, unique object.
391 DEF_IPUT(Instruction::IPUT, 13u, 20u, 2u), // IPUT clobbers field #1 (#2 is wide).
392 DEF_IGET(Instruction::IGET, 14u, 20u, 0u), // Resolved field #1, unique object.
393 DEF_IGET_WIDE(Instruction::IGET_WIDE, 15u, 20u, 1u), // Resolved field #2, unique object.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100394 };
395
396 PrepareIFields(ifields);
397 PrepareMIRs(mirs);
398 PerformLVN();
Vladimir Marko95a05972014-05-30 10:01:32 +0100399 ASSERT_EQ(value_names_.size(), 16u);
Vladimir Markofa236452014-09-29 17:58:10 +0100400 // Unresolved field is potentially volatile, so we need to adhere to the volatile semantics.
401 EXPECT_EQ(value_names_[1], value_names_[5]); // Unique object.
402 EXPECT_NE(value_names_[2], value_names_[6]); // Not guaranteed to be the same after "acquire".
403 EXPECT_NE(value_names_[3], value_names_[7]); // Not guaranteed to be the same after "acquire".
404 EXPECT_EQ(value_names_[1], value_names_[9]); // Unique object.
405 EXPECT_NE(value_names_[6], value_names_[10]); // This aliased with unresolved IPUT.
406 EXPECT_EQ(value_names_[7], value_names_[11]); // Still the same after "release".
407 EXPECT_EQ(value_names_[12], value_names_[15]); // Still the same after "release".
408 EXPECT_NE(value_names_[1], value_names_[14]); // This aliased with unresolved IPUT.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100409 EXPECT_EQ(mirs_[0].optimization_flags, 0u);
410 EXPECT_EQ(mirs_[1].optimization_flags, MIR_IGNORE_NULL_CHECK);
411 EXPECT_EQ(mirs_[2].optimization_flags, 0u);
412 EXPECT_EQ(mirs_[3].optimization_flags, MIR_IGNORE_NULL_CHECK);
413 EXPECT_EQ(mirs_[4].optimization_flags, 0u);
414 for (size_t i = 5u; i != mir_count_; ++i) {
Vladimir Marko95a05972014-05-30 10:01:32 +0100415 EXPECT_EQ((i == 1u || i == 3u || i >=5u) ? MIR_IGNORE_NULL_CHECK : 0,
416 mirs_[i].optimization_flags) << i;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100417 }
418}
419
420TEST_F(LocalValueNumberingTest, UnresolvedSField) {
421 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000422 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
423 { 2u, 1u, 2u, false, kDexMemAccessWide }, // Resolved field #2.
424 { 3u, 0u, 0u, false, kDexMemAccessWord }, // Unresolved field.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100425 };
426 static const MIRDef mirs[] = {
427 DEF_SGET(Instruction::SGET, 0u, 0u), // Resolved field #1.
428 DEF_SGET_WIDE(Instruction::SGET_WIDE, 1u, 1u), // Resolved field #2.
Vladimir Markofa236452014-09-29 17:58:10 +0100429 DEF_SGET(Instruction::SGET, 2u, 2u), // Unresolved SGET can be "acquire".
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100430 DEF_SGET(Instruction::SGET, 3u, 0u), // Resolved field #1.
431 DEF_SGET_WIDE(Instruction::SGET_WIDE, 4u, 1u), // Resolved field #2.
432 DEF_SPUT(Instruction::SPUT, 5u, 2u), // SPUT clobbers field #1 (#2 is wide).
433 DEF_SGET(Instruction::SGET, 6u, 0u), // Resolved field #1.
434 DEF_SGET_WIDE(Instruction::SGET_WIDE, 7u, 1u), // Resolved field #2.
435 };
436
437 PrepareSFields(sfields);
438 PrepareMIRs(mirs);
439 PerformLVN();
440 ASSERT_EQ(value_names_.size(), 8u);
Vladimir Markofa236452014-09-29 17:58:10 +0100441 // Unresolved field is potentially volatile, so we need to adhere to the volatile semantics.
442 EXPECT_NE(value_names_[0], value_names_[3]); // Not guaranteed to be the same after "acquire".
443 EXPECT_NE(value_names_[1], value_names_[4]); // Not guaranteed to be the same after "acquire".
444 EXPECT_NE(value_names_[3], value_names_[6]); // This aliased with unresolved IPUT.
445 EXPECT_EQ(value_names_[4], value_names_[7]); // Still the same after "release".
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100446 for (size_t i = 0u; i != mir_count_; ++i) {
Vladimir Marko95a05972014-05-30 10:01:32 +0100447 EXPECT_EQ(0, mirs_[i].optimization_flags) << i;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100448 }
449}
450
Vladimir Marko95a05972014-05-30 10:01:32 +0100451TEST_F(LocalValueNumberingTest, UninitializedSField) {
452 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000453 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
Vladimir Marko95a05972014-05-30 10:01:32 +0100454 };
455 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000456 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Resolved field #1.
457 { 2u, 1u, 2u, false, kDexMemAccessWord }, // Resolved field #2; uninitialized.
Vladimir Marko95a05972014-05-30 10:01:32 +0100458 };
459 static const MIRDef mirs[] = {
460 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 200u),
461 DEF_IGET(Instruction::IGET, 1u, 100u, 0u),
462 DEF_IGET(Instruction::IGET, 2u, 200u, 0u),
463 DEF_SGET(Instruction::SGET, 3u, 0u),
464 DEF_SGET(Instruction::SGET, 4u, 1u), // Can call <clinit>().
465 DEF_IGET(Instruction::IGET, 5u, 100u, 0u), // Differs from 1u.
466 DEF_IGET(Instruction::IGET, 6u, 200u, 0u), // Same as 2u.
467 DEF_SGET(Instruction::SGET, 7u, 0u), // Differs from 3u.
468 };
469
470 PrepareIFields(ifields);
471 PrepareSFields(sfields);
472 MakeSFieldUninitialized(1u);
473 PrepareMIRs(mirs);
474 PerformLVN();
475 ASSERT_EQ(value_names_.size(), 8u);
476 EXPECT_NE(value_names_[1], value_names_[5]);
477 EXPECT_EQ(value_names_[2], value_names_[6]);
478 EXPECT_NE(value_names_[3], value_names_[7]);
479}
480
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100481TEST_F(LocalValueNumberingTest, ConstString) {
482 static const MIRDef mirs[] = {
483 DEF_CONST_STRING(Instruction::CONST_STRING, 0u, 0u),
484 DEF_CONST_STRING(Instruction::CONST_STRING, 1u, 0u),
485 DEF_CONST_STRING(Instruction::CONST_STRING, 2u, 2u),
486 DEF_CONST_STRING(Instruction::CONST_STRING, 3u, 0u),
487 DEF_INVOKE1(Instruction::INVOKE_DIRECT, 2u),
488 DEF_CONST_STRING(Instruction::CONST_STRING, 4u, 2u),
489 };
490
491 PrepareMIRs(mirs);
492 PerformLVN();
493 ASSERT_EQ(value_names_.size(), 6u);
494 EXPECT_EQ(value_names_[1], value_names_[0]);
495 EXPECT_NE(value_names_[2], value_names_[0]);
496 EXPECT_EQ(value_names_[3], value_names_[0]);
497 EXPECT_EQ(value_names_[5], value_names_[2]);
498}
499
500TEST_F(LocalValueNumberingTest, SameValueInDifferentMemoryLocations) {
501 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000502 { 1u, 1u, 1u, false, kDexMemAccessWord },
503 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100504 };
505 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000506 { 3u, 1u, 3u, false, kDexMemAccessWord },
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100507 };
508 static const MIRDef mirs[] = {
Vladimir Marko95a05972014-05-30 10:01:32 +0100509 DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 201u),
510 DEF_IGET(Instruction::IGET, 0u, 100u, 0u),
511 DEF_IPUT(Instruction::IPUT, 0u, 100u, 1u),
512 DEF_IPUT(Instruction::IPUT, 0u, 101u, 1u),
513 DEF_APUT(Instruction::APUT, 0u, 200u, 300u),
514 DEF_APUT(Instruction::APUT, 0u, 200u, 301u),
515 DEF_APUT(Instruction::APUT, 0u, 201u, 300u),
516 DEF_APUT(Instruction::APUT, 0u, 201u, 301u),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100517 DEF_SPUT(Instruction::SPUT, 0u, 0u),
Vladimir Marko95a05972014-05-30 10:01:32 +0100518 DEF_IGET(Instruction::IGET, 9u, 100u, 0u),
519 DEF_IGET(Instruction::IGET, 10u, 100u, 1u),
520 DEF_IGET(Instruction::IGET, 11u, 101u, 1u),
521 DEF_AGET(Instruction::AGET, 12u, 200u, 300u),
522 DEF_AGET(Instruction::AGET, 13u, 200u, 301u),
523 DEF_AGET(Instruction::AGET, 14u, 201u, 300u),
524 DEF_AGET(Instruction::AGET, 15u, 201u, 301u),
525 DEF_SGET(Instruction::SGET, 16u, 0u),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100526 };
527
528 PrepareIFields(ifields);
529 PrepareSFields(sfields);
530 PrepareMIRs(mirs);
531 PerformLVN();
Vladimir Marko95a05972014-05-30 10:01:32 +0100532 ASSERT_EQ(value_names_.size(), 17u);
533 for (size_t i = 9; i != arraysize(mirs); ++i) {
534 EXPECT_EQ(value_names_[1], value_names_[i]) << i;
535 }
536 for (size_t i = 0; i != arraysize(mirs); ++i) {
537 int expected_flags =
538 ((i == 2u || (i >= 5u && i <= 7u) || (i >= 9u && i <= 15u)) ? MIR_IGNORE_NULL_CHECK : 0) |
539 ((i >= 12u && i <= 15u) ? MIR_IGNORE_RANGE_CHECK : 0);
540 EXPECT_EQ(expected_flags, mirs_[i].optimization_flags) << i;
541 }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100542}
543
544TEST_F(LocalValueNumberingTest, UniqueArrayAliasing) {
545 static const MIRDef mirs[] = {
546 DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 20u),
547 DEF_AGET(Instruction::AGET, 1u, 20u, 40u),
548 DEF_APUT(Instruction::APUT, 2u, 20u, 41u), // May alias with index for sreg 40u.
549 DEF_AGET(Instruction::AGET, 3u, 20u, 40u),
550 };
551
552 PrepareMIRs(mirs);
553 PerformLVN();
554 ASSERT_EQ(value_names_.size(), 4u);
555 EXPECT_NE(value_names_[1], value_names_[3]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100556 for (size_t i = 0; i != arraysize(mirs); ++i) {
557 int expected_flags =
558 ((i >= 1u) ? MIR_IGNORE_NULL_CHECK : 0) |
559 ((i == 3u) ? MIR_IGNORE_RANGE_CHECK : 0);
560 EXPECT_EQ(expected_flags, mirs_[i].optimization_flags) << i;
561 }
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100562}
563
564TEST_F(LocalValueNumberingTest, EscapingRefs) {
565 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000566 { 1u, 1u, 1u, false, kDexMemAccessWord }, // Field #1.
567 { 2u, 1u, 2u, false, kDexMemAccessWord }, // Field #2.
568 { 3u, 1u, 3u, false, kDexMemAccessObject }, // For storing escaping refs.
569 { 4u, 1u, 4u, false, kDexMemAccessWide }, // Wide.
570 { 5u, 0u, 0u, false, kDexMemAccessWord }, // Unresolved field, int.
571 { 6u, 0u, 0u, false, kDexMemAccessWide }, // Unresolved field, wide.
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100572 };
573 static const MIRDef mirs[] = {
574 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 20u),
575 DEF_IGET(Instruction::IGET, 1u, 20u, 0u),
576 DEF_IGET(Instruction::IGET, 2u, 20u, 1u),
577 DEF_IPUT(Instruction::IPUT_OBJECT, 20u, 30u, 2u), // Ref escapes.
578 DEF_IGET(Instruction::IGET, 4u, 20u, 0u),
579 DEF_IGET(Instruction::IGET, 5u, 20u, 1u),
580 DEF_IPUT(Instruction::IPUT, 6u, 31u, 0u), // May alias with field #1.
581 DEF_IGET(Instruction::IGET, 7u, 20u, 0u), // New value.
582 DEF_IGET(Instruction::IGET, 8u, 20u, 1u), // Still the same.
583 DEF_IPUT_WIDE(Instruction::IPUT_WIDE, 9u, 31u, 3u), // No aliasing, different type.
584 DEF_IGET(Instruction::IGET, 10u, 20u, 0u),
585 DEF_IGET(Instruction::IGET, 11u, 20u, 1u),
586 DEF_IPUT_WIDE(Instruction::IPUT_WIDE, 12u, 31u, 5u), // No aliasing, different type.
587 DEF_IGET(Instruction::IGET, 13u, 20u, 0u),
588 DEF_IGET(Instruction::IGET, 14u, 20u, 1u),
589 DEF_IPUT(Instruction::IPUT, 15u, 31u, 4u), // Aliasing, same type.
590 DEF_IGET(Instruction::IGET, 16u, 20u, 0u),
591 DEF_IGET(Instruction::IGET, 17u, 20u, 1u),
592 };
593
594 PrepareIFields(ifields);
595 PrepareMIRs(mirs);
596 PerformLVN();
597 ASSERT_EQ(value_names_.size(), 18u);
598 EXPECT_EQ(value_names_[1], value_names_[4]);
599 EXPECT_EQ(value_names_[2], value_names_[5]);
600 EXPECT_NE(value_names_[4], value_names_[7]); // New value.
601 EXPECT_EQ(value_names_[5], value_names_[8]);
602 EXPECT_EQ(value_names_[7], value_names_[10]);
603 EXPECT_EQ(value_names_[8], value_names_[11]);
604 EXPECT_EQ(value_names_[10], value_names_[13]);
605 EXPECT_EQ(value_names_[11], value_names_[14]);
606 EXPECT_NE(value_names_[13], value_names_[16]); // New value.
607 EXPECT_NE(value_names_[14], value_names_[17]); // New value.
608 for (size_t i = 0u; i != mir_count_; ++i) {
Vladimir Marko743b98c2014-11-24 19:45:41 +0000609 int expected =
610 ((i != 0u && i != 3u && i != 6u) ? MIR_IGNORE_NULL_CHECK : 0) |
611 ((i == 3u) ? MIR_STORE_NON_NULL_VALUE: 0);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100612 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
613 }
614}
615
616TEST_F(LocalValueNumberingTest, EscapingArrayRefs) {
617 static const MIRDef mirs[] = {
618 DEF_UNIQUE_REF(Instruction::NEW_ARRAY, 20u),
619 DEF_AGET(Instruction::AGET, 1u, 20u, 40u),
620 DEF_AGET(Instruction::AGET, 2u, 20u, 41u),
621 DEF_APUT(Instruction::APUT_OBJECT, 20u, 30u, 42u), // Array ref escapes.
622 DEF_AGET(Instruction::AGET, 4u, 20u, 40u),
623 DEF_AGET(Instruction::AGET, 5u, 20u, 41u),
624 DEF_APUT_WIDE(Instruction::APUT_WIDE, 6u, 31u, 43u), // No aliasing, different type.
625 DEF_AGET(Instruction::AGET, 7u, 20u, 40u),
626 DEF_AGET(Instruction::AGET, 8u, 20u, 41u),
627 DEF_APUT(Instruction::APUT, 9u, 32u, 40u), // May alias with all elements.
628 DEF_AGET(Instruction::AGET, 10u, 20u, 40u), // New value (same index name).
629 DEF_AGET(Instruction::AGET, 11u, 20u, 41u), // New value (different index name).
630 };
631
632 PrepareMIRs(mirs);
633 PerformLVN();
634 ASSERT_EQ(value_names_.size(), 12u);
635 EXPECT_EQ(value_names_[1], value_names_[4]);
636 EXPECT_EQ(value_names_[2], value_names_[5]);
637 EXPECT_EQ(value_names_[4], value_names_[7]);
638 EXPECT_EQ(value_names_[5], value_names_[8]);
639 EXPECT_NE(value_names_[7], value_names_[10]); // New value.
640 EXPECT_NE(value_names_[8], value_names_[11]); // New value.
641 for (size_t i = 0u; i != mir_count_; ++i) {
642 int expected =
643 ((i != 0u && i != 3u && i != 6u && i != 9u) ? MIR_IGNORE_NULL_CHECK : 0u) |
Vladimir Marko743b98c2014-11-24 19:45:41 +0000644 ((i >= 4 && i != 6u && i != 9u) ? MIR_IGNORE_RANGE_CHECK : 0u) |
645 ((i == 3u) ? MIR_STORE_NON_NULL_VALUE: 0);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100646 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
647 }
648}
649
650TEST_F(LocalValueNumberingTest, StoringSameValueKeepsMemoryVersion) {
651 static const IFieldDef ifields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000652 { 1u, 1u, 1u, false, kDexMemAccessWord },
653 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Marko95a05972014-05-30 10:01:32 +0100654 };
655 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000656 { 2u, 1u, 2u, false, kDexMemAccessWord },
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100657 };
658 static const MIRDef mirs[] = {
Vladimir Marko95a05972014-05-30 10:01:32 +0100659 DEF_IGET(Instruction::IGET, 0u, 30u, 0u),
660 DEF_IGET(Instruction::IGET, 1u, 31u, 0u),
661 DEF_IPUT(Instruction::IPUT, 1u, 31u, 0u), // Store the same value.
662 DEF_IGET(Instruction::IGET, 3u, 30u, 0u),
663 DEF_AGET(Instruction::AGET, 4u, 32u, 40u),
664 DEF_AGET(Instruction::AGET, 5u, 33u, 40u),
665 DEF_APUT(Instruction::APUT, 5u, 33u, 40u), // Store the same value.
666 DEF_AGET(Instruction::AGET, 7u, 32u, 40u),
667 DEF_SGET(Instruction::SGET, 8u, 0u),
668 DEF_SPUT(Instruction::SPUT, 8u, 0u), // Store the same value.
669 DEF_SGET(Instruction::SGET, 10u, 0u),
670 DEF_UNIQUE_REF(Instruction::NEW_INSTANCE, 50u), // Test with unique references.
671 { Instruction::FILLED_NEW_ARRAY, 0, 0u, 2, { 12u, 13u }, 0, { } },
672 DEF_UNIQUE_REF(Instruction::MOVE_RESULT_OBJECT, 51u),
673 DEF_IGET(Instruction::IGET, 14u, 50u, 0u),
674 DEF_IGET(Instruction::IGET, 15u, 50u, 1u),
675 DEF_IPUT(Instruction::IPUT, 15u, 50u, 1u), // Store the same value.
676 DEF_IGET(Instruction::IGET, 17u, 50u, 0u),
677 DEF_AGET(Instruction::AGET, 18u, 51u, 40u),
678 DEF_AGET(Instruction::AGET, 19u, 51u, 41u),
679 DEF_APUT(Instruction::APUT, 19u, 51u, 41u), // Store the same value.
680 DEF_AGET(Instruction::AGET, 21u, 51u, 40u),
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100681 };
682
683 PrepareIFields(ifields);
Vladimir Marko95a05972014-05-30 10:01:32 +0100684 PrepareSFields(sfields);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100685 PrepareMIRs(mirs);
686 PerformLVN();
Vladimir Marko95a05972014-05-30 10:01:32 +0100687 ASSERT_EQ(value_names_.size(), 22u);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100688 EXPECT_NE(value_names_[0], value_names_[1]);
689 EXPECT_EQ(value_names_[0], value_names_[3]);
690 EXPECT_NE(value_names_[4], value_names_[5]);
691 EXPECT_EQ(value_names_[4], value_names_[7]);
Vladimir Marko95a05972014-05-30 10:01:32 +0100692 EXPECT_EQ(value_names_[8], value_names_[10]);
693 EXPECT_NE(value_names_[14], value_names_[15]);
694 EXPECT_EQ(value_names_[14], value_names_[17]);
695 EXPECT_NE(value_names_[18], value_names_[19]);
696 EXPECT_EQ(value_names_[18], value_names_[21]);
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100697 for (size_t i = 0u; i != mir_count_; ++i) {
698 int expected =
Vladimir Marko95a05972014-05-30 10:01:32 +0100699 ((i == 2u || i == 3u || i == 6u || i == 7u || (i >= 14u)) ? MIR_IGNORE_NULL_CHECK : 0u) |
700 ((i == 6u || i == 7u || i >= 20u) ? MIR_IGNORE_RANGE_CHECK : 0u);
701 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
702 }
703}
704
705TEST_F(LocalValueNumberingTest, FilledNewArrayTracking) {
706 if (!kLocalValueNumberingEnableFilledNewArrayTracking) {
707 // Feature disabled.
708 return;
709 }
710 static const MIRDef mirs[] = {
711 DEF_CONST(Instruction::CONST, 0u, 100),
712 DEF_CONST(Instruction::CONST, 1u, 200),
713 { Instruction::FILLED_NEW_ARRAY, 0, 0u, 2, { 0u, 1u }, 0, { } },
714 DEF_UNIQUE_REF(Instruction::MOVE_RESULT_OBJECT, 10u),
715 DEF_CONST(Instruction::CONST, 20u, 0),
716 DEF_CONST(Instruction::CONST, 21u, 1),
717 DEF_AGET(Instruction::AGET, 6u, 10u, 20u),
718 DEF_AGET(Instruction::AGET, 7u, 10u, 21u),
719 };
720
721 PrepareMIRs(mirs);
722 PerformLVN();
723 ASSERT_EQ(value_names_.size(), 8u);
724 EXPECT_EQ(value_names_[0], value_names_[6]);
725 EXPECT_EQ(value_names_[1], value_names_[7]);
726 for (size_t i = 0u; i != mir_count_; ++i) {
727 int expected = (i == 6u || i == 7u) ? (MIR_IGNORE_NULL_CHECK | MIR_IGNORE_RANGE_CHECK) : 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100728 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
729 }
730}
731
Vladimir Markof418f322014-07-09 14:45:36 +0100732TEST_F(LocalValueNumberingTest, ClInitOnSget) {
733 static const SFieldDef sfields[] = {
Vladimir Markoaf6925b2014-10-31 16:37:32 +0000734 { 0u, 1u, 0u, false, kDexMemAccessObject },
735 { 1u, 2u, 1u, false, kDexMemAccessObject },
Vladimir Markof418f322014-07-09 14:45:36 +0100736 };
737 static const MIRDef mirs[] = {
738 DEF_SGET(Instruction::SGET_OBJECT, 0u, 0u),
739 DEF_AGET(Instruction::AGET, 1u, 0u, 100u),
740 DEF_SGET(Instruction::SGET_OBJECT, 2u, 1u),
741 DEF_SGET(Instruction::SGET_OBJECT, 3u, 0u),
742 DEF_AGET(Instruction::AGET, 4u, 3u, 100u),
743 };
744
745 PrepareSFields(sfields);
746 MakeSFieldUninitialized(1u);
747 PrepareMIRs(mirs);
748 PerformLVN();
749 ASSERT_EQ(value_names_.size(), 5u);
750 EXPECT_NE(value_names_[0], value_names_[3]);
751}
752
Razvan A Lupusorue0951142014-11-14 14:36:55 -0800753TEST_F(LocalValueNumberingTest, DivZeroCheck) {
754 static const MIRDef mirs[] = {
755 DEF_DIV_REM(Instruction::DIV_INT, 1u, 10u, 20u),
756 DEF_DIV_REM(Instruction::DIV_INT, 2u, 20u, 20u),
757 DEF_DIV_REM(Instruction::DIV_INT_2ADDR, 3u, 10u, 1u),
758 DEF_DIV_REM(Instruction::REM_INT, 4u, 30u, 20u),
759 DEF_DIV_REM_WIDE(Instruction::REM_LONG, 5u, 12u, 14u),
760 DEF_DIV_REM_WIDE(Instruction::DIV_LONG_2ADDR, 7u, 16u, 14u),
761 };
762
763 static const bool expected_ignore_div_zero_check[] = {
764 false, true, false, true, false, true,
765 };
766
767 PrepareMIRs(mirs);
768 PerformLVN();
769 for (size_t i = 0u; i != mir_count_; ++i) {
770 int expected = expected_ignore_div_zero_check[i] ? MIR_IGNORE_DIV_ZERO_CHECK : 0u;
771 EXPECT_EQ(expected, mirs_[i].optimization_flags) << i;
772 }
773}
774
Vladimir Markod532f002015-02-13 19:47:13 +0000775TEST_F(LocalValueNumberingTest, ConstWide) {
776 static const MIRDef mirs[] = {
777 DEF_CONST(Instruction::CONST_WIDE_16, 0u, 0),
778 DEF_CONST(Instruction::CONST_WIDE_16, 1u, 1),
779 DEF_CONST(Instruction::CONST_WIDE_16, 2u, -1),
780 DEF_CONST(Instruction::CONST_WIDE_32, 3u, 1 << 16),
781 DEF_CONST(Instruction::CONST_WIDE_32, 4u, -1 << 16),
782 DEF_CONST(Instruction::CONST_WIDE_32, 5u, (1 << 16) + 1),
783 DEF_CONST(Instruction::CONST_WIDE_32, 6u, (1 << 16) - 1),
784 DEF_CONST(Instruction::CONST_WIDE_32, 7u, -(1 << 16) + 1),
785 DEF_CONST(Instruction::CONST_WIDE_32, 8u, -(1 << 16) - 1),
786 DEF_CONST(Instruction::CONST_WIDE, 9u, INT64_C(1) << 32),
787 DEF_CONST(Instruction::CONST_WIDE, 10u, INT64_C(-1) << 32),
788 DEF_CONST(Instruction::CONST_WIDE, 11u, (INT64_C(1) << 32) + 1),
789 DEF_CONST(Instruction::CONST_WIDE, 12u, (INT64_C(1) << 32) - 1),
790 DEF_CONST(Instruction::CONST_WIDE, 13u, (INT64_C(-1) << 32) + 1),
791 DEF_CONST(Instruction::CONST_WIDE, 14u, (INT64_C(-1) << 32) - 1),
792 DEF_CONST(Instruction::CONST_WIDE_HIGH16, 15u, 1), // Effectively 1 << 48.
793 DEF_CONST(Instruction::CONST_WIDE_HIGH16, 16u, 0xffff), // Effectively -1 << 48.
794 DEF_CONST(Instruction::CONST_WIDE, 17u, (INT64_C(1) << 48) + 1),
795 DEF_CONST(Instruction::CONST_WIDE, 18u, (INT64_C(1) << 48) - 1),
796 DEF_CONST(Instruction::CONST_WIDE, 19u, (INT64_C(-1) << 48) + 1),
797 DEF_CONST(Instruction::CONST_WIDE, 20u, (INT64_C(-1) << 48) - 1),
798 };
799
800 PrepareMIRs(mirs);
801 PerformLVN();
802 for (size_t i = 0u; i != mir_count_; ++i) {
803 for (size_t j = i + 1u; j != mir_count_; ++j) {
804 EXPECT_NE(value_names_[i], value_names_[j]) << i << " " << j;
805 }
806 }
807}
808
Vladimir Markof59f18b2014-02-17 15:53:57 +0000809} // namespace art