blob: 77b7a228dcf04115e51d540047053a5a75732cc1 [file] [log] [blame]
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +01001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "ssa_builder.h"
Nicolas Geoffray184d6402014-06-09 14:06:02 +010018
David Brazdil86ea7ee2016-02-16 09:26:07 +000019#include "bytecode_utils.h"
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010020#include "data_type-inl.h"
Andreas Gampe90b936d2017-01-31 08:58:55 -080021#include "mirror/class-inl.h"
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +010022#include "nodes.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000023#include "reference_type_propagation.h"
Andreas Gampe90b936d2017-01-31 08:58:55 -080024#include "scoped_thread_state_change-inl.h"
Nicolas Geoffray31596742014-11-24 15:28:45 +000025#include "ssa_phi_elimination.h"
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +010026
27namespace art {
28
Calin Juravlea4f88312015-04-16 12:57:19 +010029void SsaBuilder::FixNullConstantType() {
30 // The order doesn't matter here.
Vladimir Marko2c45bc92016-10-25 16:54:12 +010031 for (HBasicBlock* block : graph_->GetReversePostOrder()) {
32 for (HInstructionIterator it(block->GetInstructions()); !it.Done(); it.Advance()) {
Calin Juravlea4f88312015-04-16 12:57:19 +010033 HInstruction* equality_instr = it.Current();
34 if (!equality_instr->IsEqual() && !equality_instr->IsNotEqual()) {
35 continue;
36 }
37 HInstruction* left = equality_instr->InputAt(0);
38 HInstruction* right = equality_instr->InputAt(1);
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010039 HInstruction* int_operand = nullptr;
Calin Juravlea4f88312015-04-16 12:57:19 +010040
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010041 if ((left->GetType() == DataType::Type::kReference) &&
42 (right->GetType() == DataType::Type::kInt32)) {
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010043 int_operand = right;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +010044 } else if ((right->GetType() == DataType::Type::kReference) &&
45 (left->GetType() == DataType::Type::kInt32)) {
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010046 int_operand = left;
Calin Juravlea4f88312015-04-16 12:57:19 +010047 } else {
48 continue;
49 }
50
51 // If we got here, we are comparing against a reference and the int constant
52 // should be replaced with a null constant.
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010053 // Both type propagation and redundant phi elimination ensure `int_operand`
54 // can only be the 0 constant.
Nicolas Geoffray15bd2282016-01-05 15:55:41 +000055 DCHECK(int_operand->IsIntConstant()) << int_operand->DebugName();
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010056 DCHECK_EQ(0, int_operand->AsIntConstant()->GetValue());
David Brazdildee58d62016-04-07 09:54:26 +000057 equality_instr->ReplaceInput(graph_->GetNullConstant(), int_operand == right ? 1 : 0);
Calin Juravlea4f88312015-04-16 12:57:19 +010058 }
59 }
60}
61
62void SsaBuilder::EquivalentPhisCleanup() {
63 // The order doesn't matter here.
Vladimir Marko2c45bc92016-10-25 16:54:12 +010064 for (HBasicBlock* block : graph_->GetReversePostOrder()) {
65 for (HInstructionIterator it(block->GetPhis()); !it.Done(); it.Advance()) {
Calin Juravlea4f88312015-04-16 12:57:19 +010066 HPhi* phi = it.Current()->AsPhi();
67 HPhi* next = phi->GetNextEquivalentPhiWithSameType();
68 if (next != nullptr) {
David Brazdil4833f5a2015-12-16 10:37:39 +000069 // Make sure we do not replace a live phi with a dead phi. A live phi
70 // has been handled by the type propagation phase, unlike a dead phi.
Nicolas Geoffray4230e182015-06-29 14:34:46 +010071 if (next->IsLive()) {
72 phi->ReplaceWith(next);
David Brazdil4833f5a2015-12-16 10:37:39 +000073 phi->SetDead();
Nicolas Geoffray4230e182015-06-29 14:34:46 +010074 } else {
75 next->ReplaceWith(phi);
76 }
Calin Juravlea4f88312015-04-16 12:57:19 +010077 DCHECK(next->GetNextEquivalentPhiWithSameType() == nullptr)
78 << "More then one phi equivalent with type " << phi->GetType()
79 << " found for phi" << phi->GetId();
80 }
81 }
82 }
83}
84
David Brazdil4833f5a2015-12-16 10:37:39 +000085void SsaBuilder::FixEnvironmentPhis() {
Vladimir Marko2c45bc92016-10-25 16:54:12 +010086 for (HBasicBlock* block : graph_->GetReversePostOrder()) {
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +000087 for (HInstructionIterator it_phis(block->GetPhis()); !it_phis.Done(); it_phis.Advance()) {
88 HPhi* phi = it_phis.Current()->AsPhi();
89 // If the phi is not dead, or has no environment uses, there is nothing to do.
90 if (!phi->IsDead() || !phi->HasEnvironmentUses()) continue;
91 HInstruction* next = phi->GetNext();
David Brazdild0180f92015-09-22 14:39:58 +010092 if (!phi->IsVRegEquivalentOf(next)) continue;
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +000093 if (next->AsPhi()->IsDead()) {
94 // If the phi equivalent is dead, check if there is another one.
95 next = next->GetNext();
David Brazdild0180f92015-09-22 14:39:58 +010096 if (!phi->IsVRegEquivalentOf(next)) continue;
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +000097 // There can be at most two phi equivalents.
David Brazdild0180f92015-09-22 14:39:58 +010098 DCHECK(!phi->IsVRegEquivalentOf(next->GetNext()));
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +000099 if (next->AsPhi()->IsDead()) continue;
100 }
101 // We found a live phi equivalent. Update the environment uses of `phi` with it.
102 phi->ReplaceWith(next);
103 }
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000104 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000105}
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000106
David Brazdil4833f5a2015-12-16 10:37:39 +0000107static void AddDependentInstructionsToWorklist(HInstruction* instruction,
108 ArenaVector<HPhi*>* worklist) {
109 // If `instruction` is a dead phi, type conflict was just identified. All its
110 // live phi users, and transitively users of those users, therefore need to be
111 // marked dead/conflicting too, so we add them to the worklist. Otherwise we
112 // add users whose type does not match and needs to be updated.
113 bool add_all_live_phis = instruction->IsPhi() && instruction->AsPhi()->IsDead();
Vladimir Marko46817b82016-03-29 12:21:58 +0100114 for (const HUseListNode<HInstruction*>& use : instruction->GetUses()) {
115 HInstruction* user = use.GetUser();
David Brazdil4833f5a2015-12-16 10:37:39 +0000116 if (user->IsPhi() && user->AsPhi()->IsLive()) {
117 if (add_all_live_phis || user->GetType() != instruction->GetType()) {
118 worklist->push_back(user->AsPhi());
119 }
120 }
121 }
122}
123
124// Find a candidate primitive type for `phi` by merging the type of its inputs.
125// Return false if conflict is identified.
126static bool TypePhiFromInputs(HPhi* phi) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100127 DataType::Type common_type = phi->GetType();
David Brazdil4833f5a2015-12-16 10:37:39 +0000128
Vladimir Marko372f10e2016-05-17 16:30:10 +0100129 for (HInstruction* input : phi->GetInputs()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000130 if (input->IsPhi() && input->AsPhi()->IsDead()) {
131 // Phis are constructed live so if an input is a dead phi, it must have
132 // been made dead due to type conflict. Mark this phi conflicting too.
133 return false;
134 }
135
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100136 DataType::Type input_type = HPhi::ToPhiType(input->GetType());
David Brazdil4833f5a2015-12-16 10:37:39 +0000137 if (common_type == input_type) {
138 // No change in type.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100139 } else if (DataType::Is64BitType(common_type) != DataType::Is64BitType(input_type)) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000140 // Types are of different sizes, e.g. int vs. long. Must be a conflict.
141 return false;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100142 } else if (DataType::IsIntegralType(common_type)) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000143 // Previous inputs were integral, this one is not but is of the same size.
144 // This does not imply conflict since some bytecode instruction types are
145 // ambiguous. TypeInputsOfPhi will either type them or detect a conflict.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100146 DCHECK(DataType::IsFloatingPointType(input_type) ||
147 input_type == DataType::Type::kReference);
David Brazdil4833f5a2015-12-16 10:37:39 +0000148 common_type = input_type;
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100149 } else if (DataType::IsIntegralType(input_type)) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000150 // Input is integral, common type is not. Same as in the previous case, if
151 // there is a conflict, it will be detected during TypeInputsOfPhi.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100152 DCHECK(DataType::IsFloatingPointType(common_type) ||
153 common_type == DataType::Type::kReference);
David Brazdil4833f5a2015-12-16 10:37:39 +0000154 } else {
155 // Combining float and reference types. Clearly a conflict.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100156 DCHECK(
157 (common_type == DataType::Type::kFloat32 && input_type == DataType::Type::kReference) ||
158 (common_type == DataType::Type::kReference && input_type == DataType::Type::kFloat32));
David Brazdil4833f5a2015-12-16 10:37:39 +0000159 return false;
160 }
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000161 }
162
David Brazdil4833f5a2015-12-16 10:37:39 +0000163 // We have found a candidate type for the phi. Set it and return true. We may
164 // still discover conflict whilst typing the individual inputs in TypeInputsOfPhi.
165 phi->SetType(common_type);
166 return true;
167}
David Brazdild9510df2015-11-04 23:30:22 +0000168
David Brazdil4833f5a2015-12-16 10:37:39 +0000169// Replace inputs of `phi` to match its type. Return false if conflict is identified.
170bool SsaBuilder::TypeInputsOfPhi(HPhi* phi, ArenaVector<HPhi*>* worklist) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100171 DataType::Type common_type = phi->GetType();
172 if (DataType::IsIntegralType(common_type)) {
Nicolas Geoffray50a9ed02016-09-23 15:40:41 +0100173 // We do not need to retype ambiguous inputs because they are always constructed
174 // with the integral type candidate.
David Brazdil4833f5a2015-12-16 10:37:39 +0000175 if (kIsDebugBuild) {
Vladimir Marko372f10e2016-05-17 16:30:10 +0100176 for (HInstruction* input : phi->GetInputs()) {
Nicolas Geoffray50a9ed02016-09-23 15:40:41 +0100177 DCHECK(HPhi::ToPhiType(input->GetType()) == common_type);
David Brazdil4833f5a2015-12-16 10:37:39 +0000178 }
179 }
180 // Inputs did not need to be replaced, hence no conflict. Report success.
181 return true;
182 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100183 DCHECK(common_type == DataType::Type::kReference ||
184 DataType::IsFloatingPointType(common_type));
Vladimir Markoe9004912016-06-16 16:50:52 +0100185 HInputsRef inputs = phi->GetInputs();
Vladimir Marko372f10e2016-05-17 16:30:10 +0100186 for (size_t i = 0; i < inputs.size(); ++i) {
187 HInstruction* input = inputs[i];
David Brazdil4833f5a2015-12-16 10:37:39 +0000188 if (input->GetType() != common_type) {
189 // Input type does not match phi's type. Try to retype the input or
190 // generate a suitably typed equivalent.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100191 HInstruction* equivalent = (common_type == DataType::Type::kReference)
David Brazdil4833f5a2015-12-16 10:37:39 +0000192 ? GetReferenceTypeEquivalent(input)
193 : GetFloatOrDoubleEquivalent(input, common_type);
194 if (equivalent == nullptr) {
195 // Input could not be typed. Report conflict.
196 return false;
197 }
198 // Make sure the input did not change its type and we do not need to
199 // update its users.
200 DCHECK_NE(input, equivalent);
201
202 phi->ReplaceInput(equivalent, i);
203 if (equivalent->IsPhi()) {
204 worklist->push_back(equivalent->AsPhi());
205 }
206 }
207 }
208 // All inputs either matched the type of the phi or we successfully replaced
209 // them with a suitable equivalent. Report success.
210 return true;
211 }
212}
213
214// Attempt to set the primitive type of `phi` to match its inputs. Return whether
215// it was changed by the algorithm or not.
216bool SsaBuilder::UpdatePrimitiveType(HPhi* phi, ArenaVector<HPhi*>* worklist) {
217 DCHECK(phi->IsLive());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100218 DataType::Type original_type = phi->GetType();
David Brazdil4833f5a2015-12-16 10:37:39 +0000219
220 // Try to type the phi in two stages:
221 // (1) find a candidate type for the phi by merging types of all its inputs,
222 // (2) try to type the phi's inputs to that candidate type.
223 // Either of these stages may detect a type conflict and fail, in which case
224 // we immediately abort.
225 if (!TypePhiFromInputs(phi) || !TypeInputsOfPhi(phi, worklist)) {
226 // Conflict detected. Mark the phi dead and return true because it changed.
227 phi->SetDead();
228 return true;
229 }
230
231 // Return true if the type of the phi has changed.
232 return phi->GetType() != original_type;
233}
234
235void SsaBuilder::RunPrimitiveTypePropagation() {
Vladimir Marko3ea5a972016-05-09 20:23:34 +0100236 ArenaVector<HPhi*> worklist(graph_->GetArena()->Adapter(kArenaAllocGraphBuilder));
David Brazdil4833f5a2015-12-16 10:37:39 +0000237
Vladimir Marko2c45bc92016-10-25 16:54:12 +0100238 for (HBasicBlock* block : graph_->GetReversePostOrder()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000239 if (block->IsLoopHeader()) {
240 for (HInstructionIterator phi_it(block->GetPhis()); !phi_it.Done(); phi_it.Advance()) {
241 HPhi* phi = phi_it.Current()->AsPhi();
242 if (phi->IsLive()) {
243 worklist.push_back(phi);
244 }
245 }
246 } else {
247 for (HInstructionIterator phi_it(block->GetPhis()); !phi_it.Done(); phi_it.Advance()) {
248 // Eagerly compute the type of the phi, for quicker convergence. Note
249 // that we don't need to add users to the worklist because we are
250 // doing a reverse post-order visit, therefore either the phi users are
251 // non-loop phi and will be visited later in the visit, or are loop-phis,
252 // and they are already in the work list.
253 HPhi* phi = phi_it.Current()->AsPhi();
254 if (phi->IsLive()) {
255 UpdatePrimitiveType(phi, &worklist);
256 }
257 }
258 }
259 }
260
261 ProcessPrimitiveTypePropagationWorklist(&worklist);
262 EquivalentPhisCleanup();
263}
264
265void SsaBuilder::ProcessPrimitiveTypePropagationWorklist(ArenaVector<HPhi*>* worklist) {
266 // Process worklist
267 while (!worklist->empty()) {
268 HPhi* phi = worklist->back();
269 worklist->pop_back();
270 // The phi could have been made dead as a result of conflicts while in the
271 // worklist. If it is now dead, there is no point in updating its type.
272 if (phi->IsLive() && UpdatePrimitiveType(phi, worklist)) {
273 AddDependentInstructionsToWorklist(phi, worklist);
274 }
275 }
276}
277
278static HArrayGet* FindFloatOrDoubleEquivalentOfArrayGet(HArrayGet* aget) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100279 DataType::Type type = aget->GetType();
280 DCHECK(DataType::IsIntOrLongType(type));
David Brazdildee58d62016-04-07 09:54:26 +0000281 HInstruction* next = aget->GetNext();
282 if (next != nullptr && next->IsArrayGet()) {
283 HArrayGet* next_aget = next->AsArrayGet();
284 if (next_aget->IsEquivalentOf(aget)) {
285 return next_aget;
286 }
287 }
288 return nullptr;
David Brazdil4833f5a2015-12-16 10:37:39 +0000289}
290
291static HArrayGet* CreateFloatOrDoubleEquivalentOfArrayGet(HArrayGet* aget) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100292 DataType::Type type = aget->GetType();
293 DCHECK(DataType::IsIntOrLongType(type));
David Brazdil4833f5a2015-12-16 10:37:39 +0000294 DCHECK(FindFloatOrDoubleEquivalentOfArrayGet(aget) == nullptr);
295
296 HArrayGet* equivalent = new (aget->GetBlock()->GetGraph()->GetArena()) HArrayGet(
297 aget->GetArray(),
298 aget->GetIndex(),
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100299 type == DataType::Type::kInt32 ? DataType::Type::kFloat32 : DataType::Type::kFloat64,
David Brazdil4833f5a2015-12-16 10:37:39 +0000300 aget->GetDexPc());
301 aget->GetBlock()->InsertInstructionAfter(equivalent, aget);
302 return equivalent;
303}
304
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100305static DataType::Type GetPrimitiveArrayComponentType(HInstruction* array)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700306 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil15693bf2015-12-16 10:30:45 +0000307 ReferenceTypeInfo array_type = array->GetReferenceTypeInfo();
David Brazdil4833f5a2015-12-16 10:37:39 +0000308 DCHECK(array_type.IsPrimitiveArrayClass());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100309 return DataTypeFromPrimitive(
310 array_type.GetTypeHandle()->GetComponentType()->GetPrimitiveType());
David Brazdil4833f5a2015-12-16 10:37:39 +0000311}
312
David Brazdil15693bf2015-12-16 10:30:45 +0000313bool SsaBuilder::FixAmbiguousArrayOps() {
314 if (ambiguous_agets_.empty() && ambiguous_asets_.empty()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000315 return true;
316 }
317
318 // The wrong ArrayGet equivalent may still have Phi uses coming from ArraySet
319 // uses (because they are untyped) and environment uses (if --debuggable).
320 // After resolving all ambiguous ArrayGets, we will re-run primitive type
321 // propagation on the Phis which need to be updated.
Vladimir Marko3ea5a972016-05-09 20:23:34 +0100322 ArenaVector<HPhi*> worklist(graph_->GetArena()->Adapter(kArenaAllocGraphBuilder));
David Brazdil4833f5a2015-12-16 10:37:39 +0000323
324 {
325 ScopedObjectAccess soa(Thread::Current());
326
327 for (HArrayGet* aget_int : ambiguous_agets_) {
David Brazdil15693bf2015-12-16 10:30:45 +0000328 HInstruction* array = aget_int->GetArray();
329 if (!array->GetReferenceTypeInfo().IsPrimitiveArrayClass()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000330 // RTP did not type the input array. Bail.
331 return false;
332 }
333
334 HArrayGet* aget_float = FindFloatOrDoubleEquivalentOfArrayGet(aget_int);
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100335 DataType::Type array_type = GetPrimitiveArrayComponentType(array);
336 DCHECK_EQ(DataType::Is64BitType(aget_int->GetType()), DataType::Is64BitType(array_type));
David Brazdil15693bf2015-12-16 10:30:45 +0000337
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100338 if (DataType::IsIntOrLongType(array_type)) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000339 if (aget_float != nullptr) {
340 // There is a float/double equivalent. We must replace it and re-run
341 // primitive type propagation on all dependent instructions.
342 aget_float->ReplaceWith(aget_int);
343 aget_float->GetBlock()->RemoveInstruction(aget_float);
344 AddDependentInstructionsToWorklist(aget_int, &worklist);
345 }
346 } else {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100347 DCHECK(DataType::IsFloatingPointType(array_type));
David Brazdil4833f5a2015-12-16 10:37:39 +0000348 if (aget_float == nullptr) {
349 // This is a float/double ArrayGet but there were no typed uses which
350 // would create the typed equivalent. Create it now.
351 aget_float = CreateFloatOrDoubleEquivalentOfArrayGet(aget_int);
352 }
353 // Replace the original int/long instruction. Note that it may have phi
354 // uses, environment uses, as well as real uses (from untyped ArraySets).
355 // We need to re-run primitive type propagation on its dependent instructions.
356 aget_int->ReplaceWith(aget_float);
357 aget_int->GetBlock()->RemoveInstruction(aget_int);
358 AddDependentInstructionsToWorklist(aget_float, &worklist);
359 }
360 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000361
David Brazdil15693bf2015-12-16 10:30:45 +0000362 // Set a flag stating that types of ArrayGets have been resolved. Requesting
363 // equivalent of the wrong type with GetFloatOrDoubleEquivalentOfArrayGet
364 // will fail from now on.
365 agets_fixed_ = true;
366
367 for (HArraySet* aset : ambiguous_asets_) {
368 HInstruction* array = aset->GetArray();
369 if (!array->GetReferenceTypeInfo().IsPrimitiveArrayClass()) {
370 // RTP did not type the input array. Bail.
371 return false;
372 }
373
374 HInstruction* value = aset->GetValue();
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100375 DataType::Type value_type = value->GetType();
376 DataType::Type array_type = GetPrimitiveArrayComponentType(array);
377 DCHECK_EQ(DataType::Is64BitType(value_type), DataType::Is64BitType(array_type));
David Brazdil15693bf2015-12-16 10:30:45 +0000378
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100379 if (DataType::IsFloatingPointType(array_type)) {
380 if (!DataType::IsFloatingPointType(value_type)) {
381 DCHECK(DataType::IsIntegralType(value_type));
David Brazdil15693bf2015-12-16 10:30:45 +0000382 // Array elements are floating-point but the value has not been replaced
383 // with its floating-point equivalent. The replacement must always
384 // succeed in code validated by the verifier.
385 HInstruction* equivalent = GetFloatOrDoubleEquivalent(value, array_type);
386 DCHECK(equivalent != nullptr);
387 aset->ReplaceInput(equivalent, /* input_index */ 2);
388 if (equivalent->IsPhi()) {
389 // Returned equivalent is a phi which may not have had its inputs
390 // replaced yet. We need to run primitive type propagation on it.
391 worklist.push_back(equivalent->AsPhi());
392 }
393 }
Aart Bik18b36ab2016-04-13 16:41:35 -0700394 // Refine the side effects of this floating point aset. Note that we do this even if
395 // no replacement occurs, since the right-hand-side may have been corrected already.
396 aset->ComputeSideEffects();
David Brazdil15693bf2015-12-16 10:30:45 +0000397 } else {
398 // Array elements are integral and the value assigned to it initially
399 // was integral too. Nothing to do.
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100400 DCHECK(DataType::IsIntegralType(array_type));
401 DCHECK(DataType::IsIntegralType(value_type));
David Brazdil15693bf2015-12-16 10:30:45 +0000402 }
403 }
404 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000405
406 if (!worklist.empty()) {
407 ProcessPrimitiveTypePropagationWorklist(&worklist);
408 EquivalentPhisCleanup();
409 }
410
411 return true;
412}
413
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000414static bool HasAliasInEnvironments(HInstruction* instruction) {
Vladimir Marko46817b82016-03-29 12:21:58 +0100415 HEnvironment* last_user = nullptr;
416 for (const HUseListNode<HEnvironment*>& use : instruction->GetEnvUses()) {
417 DCHECK(use.GetUser() != nullptr);
418 // Note: The first comparison (== null) always fails.
419 if (use.GetUser() == last_user) {
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000420 return true;
421 }
Vladimir Marko46817b82016-03-29 12:21:58 +0100422 last_user = use.GetUser();
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000423 }
424
425 if (kIsDebugBuild) {
426 // Do a quadratic search to ensure same environment uses are next
427 // to each other.
Vladimir Marko46817b82016-03-29 12:21:58 +0100428 const HUseList<HEnvironment*>& env_uses = instruction->GetEnvUses();
429 for (auto current = env_uses.begin(), end = env_uses.end(); current != end; ++current) {
430 auto next = current;
431 for (++next; next != end; ++next) {
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000432 DCHECK(next->GetUser() != current->GetUser());
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000433 }
434 }
435 }
436 return false;
437}
438
David Brazdil65902e82016-01-15 09:35:13 +0000439void SsaBuilder::RemoveRedundantUninitializedStrings() {
David Brazdildee58d62016-04-07 09:54:26 +0000440 if (graph_->IsDebuggable()) {
David Brazdil65902e82016-01-15 09:35:13 +0000441 // Do not perform the optimization for consistency with the interpreter
442 // which always allocates an object for new-instance of String.
443 return;
444 }
445
446 for (HNewInstance* new_instance : uninitialized_strings_) {
Aart Bikeda31402016-03-24 15:38:56 -0700447 DCHECK(new_instance->IsInBlock());
David Brazdildee58d62016-04-07 09:54:26 +0000448 DCHECK(new_instance->IsStringAlloc());
449
David Brazdil65902e82016-01-15 09:35:13 +0000450 // Replace NewInstance of String with NullConstant if not used prior to
451 // calling StringFactory. In case of deoptimization, the interpreter is
452 // expected to skip null check on the `this` argument of the StringFactory call.
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000453 if (!new_instance->HasNonEnvironmentUses() && !HasAliasInEnvironments(new_instance)) {
David Brazdildee58d62016-04-07 09:54:26 +0000454 new_instance->ReplaceWith(graph_->GetNullConstant());
David Brazdil65902e82016-01-15 09:35:13 +0000455 new_instance->GetBlock()->RemoveInstruction(new_instance);
456
457 // Remove LoadClass if not needed any more.
Nicolas Geoffray5e08e362016-02-15 15:56:11 +0000458 HInstruction* input = new_instance->InputAt(0);
459 HLoadClass* load_class = nullptr;
460
461 // If the class was not present in the dex cache at the point of building
462 // the graph, the builder inserted a HClinitCheck in between. Since the String
463 // class is always initialized at the point of running Java code, we can remove
464 // that check.
465 if (input->IsClinitCheck()) {
466 load_class = input->InputAt(0)->AsLoadClass();
467 input->ReplaceWith(load_class);
468 input->GetBlock()->RemoveInstruction(input);
469 } else {
470 load_class = input->AsLoadClass();
471 DCHECK(new_instance->IsStringAlloc());
472 DCHECK(!load_class->NeedsAccessCheck()) << "String class is always accessible";
473 }
David Brazdil65902e82016-01-15 09:35:13 +0000474 DCHECK(load_class != nullptr);
David Brazdil65902e82016-01-15 09:35:13 +0000475 if (!load_class->HasUses()) {
Nicolas Geoffray5e08e362016-02-15 15:56:11 +0000476 // Even if the HLoadClass needs access check, we can remove it, as we know the
477 // String class does not need it.
David Brazdil65902e82016-01-15 09:35:13 +0000478 load_class->GetBlock()->RemoveInstruction(load_class);
479 }
480 }
481 }
482}
483
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000484GraphAnalysisResult SsaBuilder::BuildSsa() {
David Brazdildee58d62016-04-07 09:54:26 +0000485 DCHECK(!graph_->IsInSsaForm());
David Brazdilbadd8262016-02-02 16:28:56 +0000486
David Brazdildee58d62016-04-07 09:54:26 +0000487 // 1) Propagate types of phis. At this point, phis are typed void in the general
David Brazdil4833f5a2015-12-16 10:37:39 +0000488 // case, or float/double/reference if we created an equivalent phi. So we need
489 // to propagate the types across phis to give them a correct type. If a type
490 // conflict is detected in this stage, the phi is marked dead.
491 RunPrimitiveTypePropagation();
492
David Brazdildee58d62016-04-07 09:54:26 +0000493 // 2) Now that the correct primitive types have been assigned, we can get rid
David Brazdil4833f5a2015-12-16 10:37:39 +0000494 // of redundant phis. Note that we cannot do this phase before type propagation,
495 // otherwise we could get rid of phi equivalents, whose presence is a requirement
496 // for the type propagation phase. Note that this is to satisfy statement (a)
497 // of the SsaBuilder (see ssa_builder.h).
David Brazdildee58d62016-04-07 09:54:26 +0000498 SsaRedundantPhiElimination(graph_).Run();
David Brazdil4833f5a2015-12-16 10:37:39 +0000499
David Brazdildee58d62016-04-07 09:54:26 +0000500 // 3) Fix the type for null constants which are part of an equality comparison.
David Brazdil4833f5a2015-12-16 10:37:39 +0000501 // We need to do this after redundant phi elimination, to ensure the only cases
502 // that we can see are reference comparison against 0. The redundant phi
503 // elimination ensures we do not see a phi taking two 0 constants in a HEqual
504 // or HNotEqual.
505 FixNullConstantType();
506
David Brazdildee58d62016-04-07 09:54:26 +0000507 // 4) Compute type of reference type instructions. The pass assumes that
David Brazdil4833f5a2015-12-16 10:37:39 +0000508 // NullConstant has been fixed up.
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000509 ReferenceTypePropagation(graph_,
510 class_loader_,
511 dex_cache_,
512 handles_,
513 /* is_first_run */ true).Run();
David Brazdil4833f5a2015-12-16 10:37:39 +0000514
David Brazdildee58d62016-04-07 09:54:26 +0000515 // 5) HInstructionBuilder duplicated ArrayGet instructions with ambiguous type
516 // (int/float or long/double) and marked ArraySets with ambiguous input type.
517 // Now that RTP computed the type of the array input, the ambiguity can be
518 // resolved and the correct equivalents kept.
David Brazdil15693bf2015-12-16 10:30:45 +0000519 if (!FixAmbiguousArrayOps()) {
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000520 return kAnalysisFailAmbiguousArrayOp;
David Brazdil4833f5a2015-12-16 10:37:39 +0000521 }
522
David Brazdildee58d62016-04-07 09:54:26 +0000523 // 6) Mark dead phis. This will mark phis which are not used by instructions
David Brazdil4833f5a2015-12-16 10:37:39 +0000524 // or other live phis. If compiling as debuggable code, phis will also be kept
525 // live if they have an environment use.
David Brazdildee58d62016-04-07 09:54:26 +0000526 SsaDeadPhiElimination dead_phi_elimimation(graph_);
David Brazdil4833f5a2015-12-16 10:37:39 +0000527 dead_phi_elimimation.MarkDeadPhis();
528
David Brazdildee58d62016-04-07 09:54:26 +0000529 // 7) Make sure environments use the right phi equivalent: a phi marked dead
David Brazdil4833f5a2015-12-16 10:37:39 +0000530 // can have a phi equivalent that is not dead. In that case we have to replace
531 // it with the live equivalent because deoptimization and try/catch rely on
532 // environments containing values of all live vregs at that point. Note that
533 // there can be multiple phis for the same Dex register that are live
534 // (for example when merging constants), in which case it is okay for the
535 // environments to just reference one.
536 FixEnvironmentPhis();
537
David Brazdildee58d62016-04-07 09:54:26 +0000538 // 8) Now that the right phis are used for the environments, we can eliminate
David Brazdil4833f5a2015-12-16 10:37:39 +0000539 // phis we do not need. Regardless of the debuggable status, this phase is
540 /// necessary for statement (b) of the SsaBuilder (see ssa_builder.h), as well
541 // as for the code generation, which does not deal with phis of conflicting
542 // input types.
543 dead_phi_elimimation.EliminateDeadPhis();
544
David Brazdildee58d62016-04-07 09:54:26 +0000545 // 9) HInstructionBuidler replaced uses of NewInstances of String with the
546 // results of their corresponding StringFactory calls. Unless the String
547 // objects are used before they are initialized, they can be replaced with
548 // NullConstant. Note that this optimization is valid only if unsimplified
549 // code does not use the uninitialized value because we assume execution can
550 // be deoptimized at any safepoint. We must therefore perform it before any
551 // other optimizations.
David Brazdil65902e82016-01-15 09:35:13 +0000552 RemoveRedundantUninitializedStrings();
553
David Brazdildee58d62016-04-07 09:54:26 +0000554 graph_->SetInSsaForm();
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000555 return kAnalysisSuccess;
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100556}
557
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100558/**
559 * Constants in the Dex format are not typed. So the builder types them as
560 * integers, but when doing the SSA form, we might realize the constant
561 * is used for floating point operations. We create a floating-point equivalent
562 * constant to make the operations correctly typed.
563 */
David Brazdil8d5b8b22015-03-24 10:51:52 +0000564HFloatConstant* SsaBuilder::GetFloatEquivalent(HIntConstant* constant) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100565 // We place the floating point constant next to this constant.
566 HFloatConstant* result = constant->GetNext()->AsFloatConstant();
567 if (result == nullptr) {
David Brazdildee58d62016-04-07 09:54:26 +0000568 float value = bit_cast<float, int32_t>(constant->GetValue());
569 result = new (graph_->GetArena()) HFloatConstant(value);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100570 constant->GetBlock()->InsertInstructionBefore(result, constant->GetNext());
David Brazdildee58d62016-04-07 09:54:26 +0000571 graph_->CacheFloatConstant(result);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100572 } else {
573 // If there is already a constant with the expected type, we know it is
574 // the floating point equivalent of this constant.
Roland Levillainda4d79b2015-03-24 14:36:11 +0000575 DCHECK_EQ((bit_cast<int32_t, float>(result->GetValue())), constant->GetValue());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100576 }
577 return result;
578}
579
580/**
581 * Wide constants in the Dex format are not typed. So the builder types them as
582 * longs, but when doing the SSA form, we might realize the constant
583 * is used for floating point operations. We create a floating-point equivalent
584 * constant to make the operations correctly typed.
585 */
David Brazdil8d5b8b22015-03-24 10:51:52 +0000586HDoubleConstant* SsaBuilder::GetDoubleEquivalent(HLongConstant* constant) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100587 // We place the floating point constant next to this constant.
588 HDoubleConstant* result = constant->GetNext()->AsDoubleConstant();
589 if (result == nullptr) {
David Brazdildee58d62016-04-07 09:54:26 +0000590 double value = bit_cast<double, int64_t>(constant->GetValue());
591 result = new (graph_->GetArena()) HDoubleConstant(value);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100592 constant->GetBlock()->InsertInstructionBefore(result, constant->GetNext());
David Brazdildee58d62016-04-07 09:54:26 +0000593 graph_->CacheDoubleConstant(result);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100594 } else {
595 // If there is already a constant with the expected type, we know it is
596 // the floating point equivalent of this constant.
Roland Levillainda4d79b2015-03-24 14:36:11 +0000597 DCHECK_EQ((bit_cast<int64_t, double>(result->GetValue())), constant->GetValue());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100598 }
599 return result;
600}
601
602/**
603 * Because of Dex format, we might end up having the same phi being
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000604 * used for non floating point operations and floating point / reference operations.
605 * Because we want the graph to be correctly typed (and thereafter avoid moves between
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100606 * floating point registers and core registers), we need to create a copy of the
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000607 * phi with a floating point / reference type.
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100608 */
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100609HPhi* SsaBuilder::GetFloatDoubleOrReferenceEquivalentOfPhi(HPhi* phi, DataType::Type type) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000610 DCHECK(phi->IsLive()) << "Cannot get equivalent of a dead phi since it would create a live one.";
611
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000612 // We place the floating point /reference phi next to this phi.
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100613 HInstruction* next = phi->GetNext();
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000614 if (next != nullptr
615 && next->AsPhi()->GetRegNumber() == phi->GetRegNumber()
616 && next->GetType() != type) {
617 // Move to the next phi to see if it is the one we are looking for.
618 next = next->GetNext();
619 }
620
621 if (next == nullptr
622 || (next->AsPhi()->GetRegNumber() != phi->GetRegNumber())
623 || (next->GetType() != type)) {
David Brazdildee58d62016-04-07 09:54:26 +0000624 ArenaAllocator* allocator = graph_->GetArena();
Vladimir Markoe9004912016-06-16 16:50:52 +0100625 HInputsRef inputs = phi->GetInputs();
Vladimir Marko372f10e2016-05-17 16:30:10 +0100626 HPhi* new_phi =
627 new (allocator) HPhi(allocator, phi->GetRegNumber(), inputs.size(), type);
628 // Copy the inputs. Note that the graph may not be correctly typed
629 // by doing this copy, but the type propagation phase will fix it.
630 ArrayRef<HUserRecord<HInstruction*>> new_input_records = new_phi->GetInputRecords();
631 for (size_t i = 0; i < inputs.size(); ++i) {
632 new_input_records[i] = HUserRecord<HInstruction*>(inputs[i]);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100633 }
634 phi->GetBlock()->InsertPhiAfter(new_phi, phi);
David Brazdil4833f5a2015-12-16 10:37:39 +0000635 DCHECK(new_phi->IsLive());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100636 return new_phi;
637 } else {
David Brazdil4833f5a2015-12-16 10:37:39 +0000638 // An existing equivalent was found. If it is dead, conflict was previously
639 // identified and we return nullptr instead.
David Brazdil809d70f2015-11-19 10:29:39 +0000640 HPhi* next_phi = next->AsPhi();
641 DCHECK_EQ(next_phi->GetType(), type);
David Brazdil4833f5a2015-12-16 10:37:39 +0000642 return next_phi->IsLive() ? next_phi : nullptr;
David Brazdild9510df2015-11-04 23:30:22 +0000643 }
644}
645
David Brazdil4833f5a2015-12-16 10:37:39 +0000646HArrayGet* SsaBuilder::GetFloatOrDoubleEquivalentOfArrayGet(HArrayGet* aget) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100647 DCHECK(DataType::IsIntegralType(aget->GetType()));
David Brazdil4833f5a2015-12-16 10:37:39 +0000648
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100649 if (!DataType::IsIntOrLongType(aget->GetType())) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000650 // Cannot type boolean, char, byte, short to float/double.
651 return nullptr;
652 }
653
654 DCHECK(ContainsElement(ambiguous_agets_, aget));
655 if (agets_fixed_) {
656 // This used to be an ambiguous ArrayGet but its type has been resolved to
657 // int/long. Requesting a float/double equivalent should lead to a conflict.
658 if (kIsDebugBuild) {
659 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100660 DCHECK(DataType::IsIntOrLongType(GetPrimitiveArrayComponentType(aget->GetArray())));
David Brazdil4833f5a2015-12-16 10:37:39 +0000661 }
662 return nullptr;
663 } else {
664 // This is an ambiguous ArrayGet which has not been resolved yet. Return an
665 // equivalent float/double instruction to use until it is resolved.
666 HArrayGet* equivalent = FindFloatOrDoubleEquivalentOfArrayGet(aget);
667 return (equivalent == nullptr) ? CreateFloatOrDoubleEquivalentOfArrayGet(aget) : equivalent;
668 }
669}
670
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100671HInstruction* SsaBuilder::GetFloatOrDoubleEquivalent(HInstruction* value, DataType::Type type) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100672 if (value->IsArrayGet()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000673 return GetFloatOrDoubleEquivalentOfArrayGet(value->AsArrayGet());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100674 } else if (value->IsLongConstant()) {
675 return GetDoubleEquivalent(value->AsLongConstant());
676 } else if (value->IsIntConstant()) {
677 return GetFloatEquivalent(value->AsIntConstant());
678 } else if (value->IsPhi()) {
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000679 return GetFloatDoubleOrReferenceEquivalentOfPhi(value->AsPhi(), type);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100680 } else {
David Brazdil4833f5a2015-12-16 10:37:39 +0000681 return nullptr;
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100682 }
683}
684
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000685HInstruction* SsaBuilder::GetReferenceTypeEquivalent(HInstruction* value) {
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000686 if (value->IsIntConstant() && value->AsIntConstant()->GetValue() == 0) {
David Brazdildee58d62016-04-07 09:54:26 +0000687 return graph_->GetNullConstant();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000688 } else if (value->IsPhi()) {
Vladimir Marko0ebe0d82017-09-21 22:50:39 +0100689 return GetFloatDoubleOrReferenceEquivalentOfPhi(value->AsPhi(), DataType::Type::kReference);
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000690 } else {
691 return nullptr;
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000692 }
693}
694
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100695} // namespace art