blob: 294d00f8e2e9bd8873788e116fd61663934bf645 [file] [log] [blame]
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +01001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "ssa_builder.h"
Nicolas Geoffray184d6402014-06-09 14:06:02 +010018
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +010019#include "nodes.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000020#include "reference_type_propagation.h"
Nicolas Geoffray31596742014-11-24 15:28:45 +000021#include "ssa_phi_elimination.h"
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +010022
23namespace art {
24
David Brazdil809d70f2015-11-19 10:29:39 +000025void SsaBuilder::SetLoopHeaderPhiInputs() {
26 for (size_t i = loop_headers_.size(); i > 0; --i) {
27 HBasicBlock* block = loop_headers_[i - 1];
28 for (HInstructionIterator it(block->GetPhis()); !it.Done(); it.Advance()) {
29 HPhi* phi = it.Current()->AsPhi();
30 size_t vreg = phi->GetRegNumber();
31 for (HBasicBlock* predecessor : block->GetPredecessors()) {
32 HInstruction* value = ValueOfLocal(predecessor, vreg);
33 if (value == nullptr) {
34 // Vreg is undefined at this predecessor. Mark it dead and leave with
35 // fewer inputs than predecessors. SsaChecker will fail if not removed.
36 phi->SetDead();
37 break;
38 } else {
39 phi->AddInput(value);
40 }
41 }
42 }
43 }
44}
45
Calin Juravlea4f88312015-04-16 12:57:19 +010046void SsaBuilder::FixNullConstantType() {
47 // The order doesn't matter here.
48 for (HReversePostOrderIterator itb(*GetGraph()); !itb.Done(); itb.Advance()) {
49 for (HInstructionIterator it(itb.Current()->GetInstructions()); !it.Done(); it.Advance()) {
50 HInstruction* equality_instr = it.Current();
51 if (!equality_instr->IsEqual() && !equality_instr->IsNotEqual()) {
52 continue;
53 }
54 HInstruction* left = equality_instr->InputAt(0);
55 HInstruction* right = equality_instr->InputAt(1);
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010056 HInstruction* int_operand = nullptr;
Calin Juravlea4f88312015-04-16 12:57:19 +010057
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010058 if ((left->GetType() == Primitive::kPrimNot) && (right->GetType() == Primitive::kPrimInt)) {
59 int_operand = right;
60 } else if ((right->GetType() == Primitive::kPrimNot)
61 && (left->GetType() == Primitive::kPrimInt)) {
62 int_operand = left;
Calin Juravlea4f88312015-04-16 12:57:19 +010063 } else {
64 continue;
65 }
66
67 // If we got here, we are comparing against a reference and the int constant
68 // should be replaced with a null constant.
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010069 // Both type propagation and redundant phi elimination ensure `int_operand`
70 // can only be the 0 constant.
Nicolas Geoffray15bd2282016-01-05 15:55:41 +000071 DCHECK(int_operand->IsIntConstant()) << int_operand->DebugName();
Nicolas Geoffray51d400d2015-06-15 09:01:08 +010072 DCHECK_EQ(0, int_operand->AsIntConstant()->GetValue());
73 equality_instr->ReplaceInput(GetGraph()->GetNullConstant(), int_operand == right ? 1 : 0);
Calin Juravlea4f88312015-04-16 12:57:19 +010074 }
75 }
76}
77
78void SsaBuilder::EquivalentPhisCleanup() {
79 // The order doesn't matter here.
80 for (HReversePostOrderIterator itb(*GetGraph()); !itb.Done(); itb.Advance()) {
81 for (HInstructionIterator it(itb.Current()->GetPhis()); !it.Done(); it.Advance()) {
82 HPhi* phi = it.Current()->AsPhi();
83 HPhi* next = phi->GetNextEquivalentPhiWithSameType();
84 if (next != nullptr) {
David Brazdil4833f5a2015-12-16 10:37:39 +000085 // Make sure we do not replace a live phi with a dead phi. A live phi
86 // has been handled by the type propagation phase, unlike a dead phi.
Nicolas Geoffray4230e182015-06-29 14:34:46 +010087 if (next->IsLive()) {
88 phi->ReplaceWith(next);
David Brazdil4833f5a2015-12-16 10:37:39 +000089 phi->SetDead();
Nicolas Geoffray4230e182015-06-29 14:34:46 +010090 } else {
91 next->ReplaceWith(phi);
92 }
Calin Juravlea4f88312015-04-16 12:57:19 +010093 DCHECK(next->GetNextEquivalentPhiWithSameType() == nullptr)
94 << "More then one phi equivalent with type " << phi->GetType()
95 << " found for phi" << phi->GetId();
96 }
97 }
98 }
99}
100
David Brazdil4833f5a2015-12-16 10:37:39 +0000101void SsaBuilder::FixEnvironmentPhis() {
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000102 for (HReversePostOrderIterator it(*GetGraph()); !it.Done(); it.Advance()) {
103 HBasicBlock* block = it.Current();
104 for (HInstructionIterator it_phis(block->GetPhis()); !it_phis.Done(); it_phis.Advance()) {
105 HPhi* phi = it_phis.Current()->AsPhi();
106 // If the phi is not dead, or has no environment uses, there is nothing to do.
107 if (!phi->IsDead() || !phi->HasEnvironmentUses()) continue;
108 HInstruction* next = phi->GetNext();
David Brazdild0180f92015-09-22 14:39:58 +0100109 if (!phi->IsVRegEquivalentOf(next)) continue;
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000110 if (next->AsPhi()->IsDead()) {
111 // If the phi equivalent is dead, check if there is another one.
112 next = next->GetNext();
David Brazdild0180f92015-09-22 14:39:58 +0100113 if (!phi->IsVRegEquivalentOf(next)) continue;
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000114 // There can be at most two phi equivalents.
David Brazdild0180f92015-09-22 14:39:58 +0100115 DCHECK(!phi->IsVRegEquivalentOf(next->GetNext()));
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000116 if (next->AsPhi()->IsDead()) continue;
117 }
118 // We found a live phi equivalent. Update the environment uses of `phi` with it.
119 phi->ReplaceWith(next);
120 }
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000121 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000122}
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000123
David Brazdil4833f5a2015-12-16 10:37:39 +0000124static void AddDependentInstructionsToWorklist(HInstruction* instruction,
125 ArenaVector<HPhi*>* worklist) {
126 // If `instruction` is a dead phi, type conflict was just identified. All its
127 // live phi users, and transitively users of those users, therefore need to be
128 // marked dead/conflicting too, so we add them to the worklist. Otherwise we
129 // add users whose type does not match and needs to be updated.
130 bool add_all_live_phis = instruction->IsPhi() && instruction->AsPhi()->IsDead();
131 for (HUseIterator<HInstruction*> it(instruction->GetUses()); !it.Done(); it.Advance()) {
132 HInstruction* user = it.Current()->GetUser();
133 if (user->IsPhi() && user->AsPhi()->IsLive()) {
134 if (add_all_live_phis || user->GetType() != instruction->GetType()) {
135 worklist->push_back(user->AsPhi());
136 }
137 }
138 }
139}
140
141// Find a candidate primitive type for `phi` by merging the type of its inputs.
142// Return false if conflict is identified.
143static bool TypePhiFromInputs(HPhi* phi) {
144 Primitive::Type common_type = phi->GetType();
145
146 for (HInputIterator it(phi); !it.Done(); it.Advance()) {
147 HInstruction* input = it.Current();
148 if (input->IsPhi() && input->AsPhi()->IsDead()) {
149 // Phis are constructed live so if an input is a dead phi, it must have
150 // been made dead due to type conflict. Mark this phi conflicting too.
151 return false;
152 }
153
154 Primitive::Type input_type = HPhi::ToPhiType(input->GetType());
155 if (common_type == input_type) {
156 // No change in type.
David Brazdild87f3ea2016-01-04 15:55:10 +0000157 } else if (Primitive::Is64BitType(common_type) != Primitive::Is64BitType(input_type)) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000158 // Types are of different sizes, e.g. int vs. long. Must be a conflict.
159 return false;
160 } else if (Primitive::IsIntegralType(common_type)) {
161 // Previous inputs were integral, this one is not but is of the same size.
162 // This does not imply conflict since some bytecode instruction types are
163 // ambiguous. TypeInputsOfPhi will either type them or detect a conflict.
164 DCHECK(Primitive::IsFloatingPointType(input_type) || input_type == Primitive::kPrimNot);
165 common_type = input_type;
166 } else if (Primitive::IsIntegralType(input_type)) {
167 // Input is integral, common type is not. Same as in the previous case, if
168 // there is a conflict, it will be detected during TypeInputsOfPhi.
169 DCHECK(Primitive::IsFloatingPointType(common_type) || common_type == Primitive::kPrimNot);
170 } else {
171 // Combining float and reference types. Clearly a conflict.
172 DCHECK((common_type == Primitive::kPrimFloat && input_type == Primitive::kPrimNot) ||
173 (common_type == Primitive::kPrimNot && input_type == Primitive::kPrimFloat));
174 return false;
175 }
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000176 }
177
David Brazdil4833f5a2015-12-16 10:37:39 +0000178 // We have found a candidate type for the phi. Set it and return true. We may
179 // still discover conflict whilst typing the individual inputs in TypeInputsOfPhi.
180 phi->SetType(common_type);
181 return true;
182}
David Brazdild9510df2015-11-04 23:30:22 +0000183
David Brazdil4833f5a2015-12-16 10:37:39 +0000184// Replace inputs of `phi` to match its type. Return false if conflict is identified.
185bool SsaBuilder::TypeInputsOfPhi(HPhi* phi, ArenaVector<HPhi*>* worklist) {
186 Primitive::Type common_type = phi->GetType();
187 if (common_type == Primitive::kPrimVoid || Primitive::IsIntegralType(common_type)) {
188 // Phi either contains only other untyped phis (common_type == kPrimVoid),
189 // or `common_type` is integral and we do not need to retype ambiguous inputs
190 // because they are always constructed with the integral type candidate.
191 if (kIsDebugBuild) {
192 for (size_t i = 0, e = phi->InputCount(); i < e; ++i) {
193 HInstruction* input = phi->InputAt(i);
194 if (common_type == Primitive::kPrimVoid) {
195 DCHECK(input->IsPhi() && input->GetType() == Primitive::kPrimVoid);
196 } else {
197 DCHECK((input->IsPhi() && input->GetType() == Primitive::kPrimVoid) ||
198 HPhi::ToPhiType(input->GetType()) == common_type);
199 }
200 }
201 }
202 // Inputs did not need to be replaced, hence no conflict. Report success.
203 return true;
204 } else {
205 DCHECK(common_type == Primitive::kPrimNot || Primitive::IsFloatingPointType(common_type));
206 for (size_t i = 0, e = phi->InputCount(); i < e; ++i) {
207 HInstruction* input = phi->InputAt(i);
208 if (input->GetType() != common_type) {
209 // Input type does not match phi's type. Try to retype the input or
210 // generate a suitably typed equivalent.
211 HInstruction* equivalent = (common_type == Primitive::kPrimNot)
212 ? GetReferenceTypeEquivalent(input)
213 : GetFloatOrDoubleEquivalent(input, common_type);
214 if (equivalent == nullptr) {
215 // Input could not be typed. Report conflict.
216 return false;
217 }
218 // Make sure the input did not change its type and we do not need to
219 // update its users.
220 DCHECK_NE(input, equivalent);
221
222 phi->ReplaceInput(equivalent, i);
223 if (equivalent->IsPhi()) {
224 worklist->push_back(equivalent->AsPhi());
225 }
226 }
227 }
228 // All inputs either matched the type of the phi or we successfully replaced
229 // them with a suitable equivalent. Report success.
230 return true;
231 }
232}
233
234// Attempt to set the primitive type of `phi` to match its inputs. Return whether
235// it was changed by the algorithm or not.
236bool SsaBuilder::UpdatePrimitiveType(HPhi* phi, ArenaVector<HPhi*>* worklist) {
237 DCHECK(phi->IsLive());
238 Primitive::Type original_type = phi->GetType();
239
240 // Try to type the phi in two stages:
241 // (1) find a candidate type for the phi by merging types of all its inputs,
242 // (2) try to type the phi's inputs to that candidate type.
243 // Either of these stages may detect a type conflict and fail, in which case
244 // we immediately abort.
245 if (!TypePhiFromInputs(phi) || !TypeInputsOfPhi(phi, worklist)) {
246 // Conflict detected. Mark the phi dead and return true because it changed.
247 phi->SetDead();
248 return true;
249 }
250
251 // Return true if the type of the phi has changed.
252 return phi->GetType() != original_type;
253}
254
255void SsaBuilder::RunPrimitiveTypePropagation() {
256 ArenaVector<HPhi*> worklist(GetGraph()->GetArena()->Adapter());
257
258 for (HReversePostOrderIterator it(*GetGraph()); !it.Done(); it.Advance()) {
259 HBasicBlock* block = it.Current();
260 if (block->IsLoopHeader()) {
261 for (HInstructionIterator phi_it(block->GetPhis()); !phi_it.Done(); phi_it.Advance()) {
262 HPhi* phi = phi_it.Current()->AsPhi();
263 if (phi->IsLive()) {
264 worklist.push_back(phi);
265 }
266 }
267 } else {
268 for (HInstructionIterator phi_it(block->GetPhis()); !phi_it.Done(); phi_it.Advance()) {
269 // Eagerly compute the type of the phi, for quicker convergence. Note
270 // that we don't need to add users to the worklist because we are
271 // doing a reverse post-order visit, therefore either the phi users are
272 // non-loop phi and will be visited later in the visit, or are loop-phis,
273 // and they are already in the work list.
274 HPhi* phi = phi_it.Current()->AsPhi();
275 if (phi->IsLive()) {
276 UpdatePrimitiveType(phi, &worklist);
277 }
278 }
279 }
280 }
281
282 ProcessPrimitiveTypePropagationWorklist(&worklist);
283 EquivalentPhisCleanup();
284}
285
286void SsaBuilder::ProcessPrimitiveTypePropagationWorklist(ArenaVector<HPhi*>* worklist) {
287 // Process worklist
288 while (!worklist->empty()) {
289 HPhi* phi = worklist->back();
290 worklist->pop_back();
291 // The phi could have been made dead as a result of conflicts while in the
292 // worklist. If it is now dead, there is no point in updating its type.
293 if (phi->IsLive() && UpdatePrimitiveType(phi, worklist)) {
294 AddDependentInstructionsToWorklist(phi, worklist);
295 }
296 }
297}
298
299static HArrayGet* FindFloatOrDoubleEquivalentOfArrayGet(HArrayGet* aget) {
300 Primitive::Type type = aget->GetType();
301 DCHECK(Primitive::IsIntOrLongType(type));
302 HArrayGet* next = aget->GetNext()->AsArrayGet();
303 return (next != nullptr && next->IsEquivalentOf(aget)) ? next : nullptr;
304}
305
306static HArrayGet* CreateFloatOrDoubleEquivalentOfArrayGet(HArrayGet* aget) {
307 Primitive::Type type = aget->GetType();
308 DCHECK(Primitive::IsIntOrLongType(type));
309 DCHECK(FindFloatOrDoubleEquivalentOfArrayGet(aget) == nullptr);
310
311 HArrayGet* equivalent = new (aget->GetBlock()->GetGraph()->GetArena()) HArrayGet(
312 aget->GetArray(),
313 aget->GetIndex(),
314 type == Primitive::kPrimInt ? Primitive::kPrimFloat : Primitive::kPrimDouble,
315 aget->GetDexPc());
316 aget->GetBlock()->InsertInstructionAfter(equivalent, aget);
317 return equivalent;
318}
319
David Brazdil15693bf2015-12-16 10:30:45 +0000320static Primitive::Type GetPrimitiveArrayComponentType(HInstruction* array)
321 SHARED_REQUIRES(Locks::mutator_lock_) {
322 ReferenceTypeInfo array_type = array->GetReferenceTypeInfo();
David Brazdil4833f5a2015-12-16 10:37:39 +0000323 DCHECK(array_type.IsPrimitiveArrayClass());
David Brazdil15693bf2015-12-16 10:30:45 +0000324 return array_type.GetTypeHandle()->GetComponentType()->GetPrimitiveType();
David Brazdil4833f5a2015-12-16 10:37:39 +0000325}
326
David Brazdil15693bf2015-12-16 10:30:45 +0000327bool SsaBuilder::FixAmbiguousArrayOps() {
328 if (ambiguous_agets_.empty() && ambiguous_asets_.empty()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000329 return true;
330 }
331
332 // The wrong ArrayGet equivalent may still have Phi uses coming from ArraySet
333 // uses (because they are untyped) and environment uses (if --debuggable).
334 // After resolving all ambiguous ArrayGets, we will re-run primitive type
335 // propagation on the Phis which need to be updated.
336 ArenaVector<HPhi*> worklist(GetGraph()->GetArena()->Adapter());
337
338 {
339 ScopedObjectAccess soa(Thread::Current());
340
341 for (HArrayGet* aget_int : ambiguous_agets_) {
David Brazdil15693bf2015-12-16 10:30:45 +0000342 HInstruction* array = aget_int->GetArray();
343 if (!array->GetReferenceTypeInfo().IsPrimitiveArrayClass()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000344 // RTP did not type the input array. Bail.
345 return false;
346 }
347
348 HArrayGet* aget_float = FindFloatOrDoubleEquivalentOfArrayGet(aget_int);
David Brazdil15693bf2015-12-16 10:30:45 +0000349 Primitive::Type array_type = GetPrimitiveArrayComponentType(array);
350 DCHECK_EQ(Primitive::Is64BitType(aget_int->GetType()), Primitive::Is64BitType(array_type));
351
352 if (Primitive::IsIntOrLongType(array_type)) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000353 if (aget_float != nullptr) {
354 // There is a float/double equivalent. We must replace it and re-run
355 // primitive type propagation on all dependent instructions.
356 aget_float->ReplaceWith(aget_int);
357 aget_float->GetBlock()->RemoveInstruction(aget_float);
358 AddDependentInstructionsToWorklist(aget_int, &worklist);
359 }
360 } else {
David Brazdil15693bf2015-12-16 10:30:45 +0000361 DCHECK(Primitive::IsFloatingPointType(array_type));
David Brazdil4833f5a2015-12-16 10:37:39 +0000362 if (aget_float == nullptr) {
363 // This is a float/double ArrayGet but there were no typed uses which
364 // would create the typed equivalent. Create it now.
365 aget_float = CreateFloatOrDoubleEquivalentOfArrayGet(aget_int);
366 }
367 // Replace the original int/long instruction. Note that it may have phi
368 // uses, environment uses, as well as real uses (from untyped ArraySets).
369 // We need to re-run primitive type propagation on its dependent instructions.
370 aget_int->ReplaceWith(aget_float);
371 aget_int->GetBlock()->RemoveInstruction(aget_int);
372 AddDependentInstructionsToWorklist(aget_float, &worklist);
373 }
374 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000375
David Brazdil15693bf2015-12-16 10:30:45 +0000376 // Set a flag stating that types of ArrayGets have been resolved. Requesting
377 // equivalent of the wrong type with GetFloatOrDoubleEquivalentOfArrayGet
378 // will fail from now on.
379 agets_fixed_ = true;
380
381 for (HArraySet* aset : ambiguous_asets_) {
382 HInstruction* array = aset->GetArray();
383 if (!array->GetReferenceTypeInfo().IsPrimitiveArrayClass()) {
384 // RTP did not type the input array. Bail.
385 return false;
386 }
387
388 HInstruction* value = aset->GetValue();
389 Primitive::Type value_type = value->GetType();
390 Primitive::Type array_type = GetPrimitiveArrayComponentType(array);
391 DCHECK_EQ(Primitive::Is64BitType(value_type), Primitive::Is64BitType(array_type));
392
393 if (Primitive::IsFloatingPointType(array_type)) {
394 if (!Primitive::IsFloatingPointType(value_type)) {
395 DCHECK(Primitive::IsIntegralType(value_type));
396 // Array elements are floating-point but the value has not been replaced
397 // with its floating-point equivalent. The replacement must always
398 // succeed in code validated by the verifier.
399 HInstruction* equivalent = GetFloatOrDoubleEquivalent(value, array_type);
400 DCHECK(equivalent != nullptr);
401 aset->ReplaceInput(equivalent, /* input_index */ 2);
402 if (equivalent->IsPhi()) {
403 // Returned equivalent is a phi which may not have had its inputs
404 // replaced yet. We need to run primitive type propagation on it.
405 worklist.push_back(equivalent->AsPhi());
406 }
407 }
408 } else {
409 // Array elements are integral and the value assigned to it initially
410 // was integral too. Nothing to do.
411 DCHECK(Primitive::IsIntegralType(array_type));
412 DCHECK(Primitive::IsIntegralType(value_type));
413 }
414 }
415 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000416
417 if (!worklist.empty()) {
418 ProcessPrimitiveTypePropagationWorklist(&worklist);
419 EquivalentPhisCleanup();
420 }
421
422 return true;
423}
424
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000425static bool HasAliasInEnvironments(HInstruction* instruction) {
426 for (HUseIterator<HEnvironment*> use_it(instruction->GetEnvUses());
427 !use_it.Done();
428 use_it.Advance()) {
429 HEnvironment* use = use_it.Current()->GetUser();
430 HUseListNode<HEnvironment*>* next = use_it.Current()->GetNext();
431 if (next != nullptr && next->GetUser() == use) {
432 return true;
433 }
434 }
435
436 if (kIsDebugBuild) {
437 // Do a quadratic search to ensure same environment uses are next
438 // to each other.
439 for (HUseIterator<HEnvironment*> use_it(instruction->GetEnvUses());
440 !use_it.Done();
441 use_it.Advance()) {
442 HUseListNode<HEnvironment*>* current = use_it.Current();
443 HUseListNode<HEnvironment*>* next = current->GetNext();
444 while (next != nullptr) {
445 DCHECK(next->GetUser() != current->GetUser());
446 next = next->GetNext();
447 }
448 }
449 }
450 return false;
451}
452
David Brazdil65902e82016-01-15 09:35:13 +0000453void SsaBuilder::RemoveRedundantUninitializedStrings() {
454 if (GetGraph()->IsDebuggable()) {
455 // Do not perform the optimization for consistency with the interpreter
456 // which always allocates an object for new-instance of String.
457 return;
458 }
459
460 for (HNewInstance* new_instance : uninitialized_strings_) {
Aart Bikeda31402016-03-24 15:38:56 -0700461 DCHECK(new_instance->IsInBlock());
David Brazdil65902e82016-01-15 09:35:13 +0000462 // Replace NewInstance of String with NullConstant if not used prior to
463 // calling StringFactory. In case of deoptimization, the interpreter is
464 // expected to skip null check on the `this` argument of the StringFactory call.
Nicolas Geoffray98e6ce42016-02-16 18:42:15 +0000465 if (!new_instance->HasNonEnvironmentUses() && !HasAliasInEnvironments(new_instance)) {
David Brazdil65902e82016-01-15 09:35:13 +0000466 new_instance->ReplaceWith(GetGraph()->GetNullConstant());
467 new_instance->GetBlock()->RemoveInstruction(new_instance);
468
469 // Remove LoadClass if not needed any more.
Nicolas Geoffray5e08e362016-02-15 15:56:11 +0000470 HInstruction* input = new_instance->InputAt(0);
471 HLoadClass* load_class = nullptr;
472
473 // If the class was not present in the dex cache at the point of building
474 // the graph, the builder inserted a HClinitCheck in between. Since the String
475 // class is always initialized at the point of running Java code, we can remove
476 // that check.
477 if (input->IsClinitCheck()) {
478 load_class = input->InputAt(0)->AsLoadClass();
479 input->ReplaceWith(load_class);
480 input->GetBlock()->RemoveInstruction(input);
481 } else {
482 load_class = input->AsLoadClass();
483 DCHECK(new_instance->IsStringAlloc());
484 DCHECK(!load_class->NeedsAccessCheck()) << "String class is always accessible";
485 }
David Brazdil65902e82016-01-15 09:35:13 +0000486 DCHECK(load_class != nullptr);
David Brazdil65902e82016-01-15 09:35:13 +0000487 if (!load_class->HasUses()) {
Nicolas Geoffray5e08e362016-02-15 15:56:11 +0000488 // Even if the HLoadClass needs access check, we can remove it, as we know the
489 // String class does not need it.
David Brazdil65902e82016-01-15 09:35:13 +0000490 load_class->GetBlock()->RemoveInstruction(load_class);
491 }
492 }
493 }
494}
495
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000496GraphAnalysisResult SsaBuilder::BuildSsa() {
David Brazdilbadd8262016-02-02 16:28:56 +0000497 DCHECK(!GetGraph()->IsInSsaForm());
498
David Brazdil4833f5a2015-12-16 10:37:39 +0000499 // 1) Visit in reverse post order. We need to have all predecessors of a block
500 // visited (with the exception of loops) in order to create the right environment
501 // for that block. For loops, we create phis whose inputs will be set in 2).
502 for (HReversePostOrderIterator it(*GetGraph()); !it.Done(); it.Advance()) {
503 VisitBasicBlock(it.Current());
504 }
505
506 // 2) Set inputs of loop header phis.
507 SetLoopHeaderPhiInputs();
508
509 // 3) Propagate types of phis. At this point, phis are typed void in the general
510 // case, or float/double/reference if we created an equivalent phi. So we need
511 // to propagate the types across phis to give them a correct type. If a type
512 // conflict is detected in this stage, the phi is marked dead.
513 RunPrimitiveTypePropagation();
514
515 // 4) Now that the correct primitive types have been assigned, we can get rid
516 // of redundant phis. Note that we cannot do this phase before type propagation,
517 // otherwise we could get rid of phi equivalents, whose presence is a requirement
518 // for the type propagation phase. Note that this is to satisfy statement (a)
519 // of the SsaBuilder (see ssa_builder.h).
520 SsaRedundantPhiElimination(GetGraph()).Run();
521
522 // 5) Fix the type for null constants which are part of an equality comparison.
523 // We need to do this after redundant phi elimination, to ensure the only cases
524 // that we can see are reference comparison against 0. The redundant phi
525 // elimination ensures we do not see a phi taking two 0 constants in a HEqual
526 // or HNotEqual.
527 FixNullConstantType();
528
529 // 6) Compute type of reference type instructions. The pass assumes that
530 // NullConstant has been fixed up.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000531 ReferenceTypePropagation(GetGraph(), handles_, /* is_first_run */ true).Run();
David Brazdil4833f5a2015-12-16 10:37:39 +0000532
533 // 7) Step 1) duplicated ArrayGet instructions with ambiguous type (int/float
David Brazdil15693bf2015-12-16 10:30:45 +0000534 // or long/double) and marked ArraySets with ambiguous input type. Now that RTP
535 // computed the type of the array input, the ambiguity can be resolved and the
536 // correct equivalents kept.
537 if (!FixAmbiguousArrayOps()) {
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000538 return kAnalysisFailAmbiguousArrayOp;
David Brazdil4833f5a2015-12-16 10:37:39 +0000539 }
540
541 // 8) Mark dead phis. This will mark phis which are not used by instructions
542 // or other live phis. If compiling as debuggable code, phis will also be kept
543 // live if they have an environment use.
544 SsaDeadPhiElimination dead_phi_elimimation(GetGraph());
545 dead_phi_elimimation.MarkDeadPhis();
546
547 // 9) Make sure environments use the right phi equivalent: a phi marked dead
548 // can have a phi equivalent that is not dead. In that case we have to replace
549 // it with the live equivalent because deoptimization and try/catch rely on
550 // environments containing values of all live vregs at that point. Note that
551 // there can be multiple phis for the same Dex register that are live
552 // (for example when merging constants), in which case it is okay for the
553 // environments to just reference one.
554 FixEnvironmentPhis();
555
556 // 10) Now that the right phis are used for the environments, we can eliminate
557 // phis we do not need. Regardless of the debuggable status, this phase is
558 /// necessary for statement (b) of the SsaBuilder (see ssa_builder.h), as well
559 // as for the code generation, which does not deal with phis of conflicting
560 // input types.
561 dead_phi_elimimation.EliminateDeadPhis();
562
David Brazdil65902e82016-01-15 09:35:13 +0000563 // 11) Step 1) replaced uses of NewInstances of String with the results of
564 // their corresponding StringFactory calls. Unless the String objects are used
565 // before they are initialized, they can be replaced with NullConstant.
566 // Note that this optimization is valid only if unsimplified code does not use
567 // the uninitialized value because we assume execution can be deoptimized at
568 // any safepoint. We must therefore perform it before any other optimizations.
569 RemoveRedundantUninitializedStrings();
570
571 // 12) Clear locals.
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100572 for (HInstructionIterator it(GetGraph()->GetEntryBlock()->GetInstructions());
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100573 !it.Done();
574 it.Advance()) {
575 HInstruction* current = it.Current();
Roland Levillain476df552014-10-09 17:51:36 +0100576 if (current->IsLocal()) {
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100577 current->GetBlock()->RemoveInstruction(current);
578 }
579 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000580
David Brazdilbadd8262016-02-02 16:28:56 +0000581 GetGraph()->SetInSsaForm();
Nicolas Geoffray15bd2282016-01-05 15:55:41 +0000582 return kAnalysisSuccess;
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100583}
584
David Brazdileead0712015-09-18 14:58:57 +0100585ArenaVector<HInstruction*>* SsaBuilder::GetLocalsFor(HBasicBlock* block) {
David Brazdileead0712015-09-18 14:58:57 +0100586 ArenaVector<HInstruction*>* locals = &locals_for_[block->GetBlockId()];
587 const size_t vregs = GetGraph()->GetNumberOfVRegs();
588 if (locals->empty() && vregs != 0u) {
589 locals->resize(vregs, nullptr);
590
591 if (block->IsCatchBlock()) {
592 ArenaAllocator* arena = GetGraph()->GetArena();
593 // We record incoming inputs of catch phis at throwing instructions and
594 // must therefore eagerly create the phis. Phis for undefined vregs will
595 // be deleted when the first throwing instruction with the vreg undefined
596 // is encountered. Unused phis will be removed by dead phi analysis.
597 for (size_t i = 0; i < vregs; ++i) {
598 // No point in creating the catch phi if it is already undefined at
599 // the first throwing instruction.
David Brazdil809d70f2015-11-19 10:29:39 +0000600 HInstruction* current_local_value = (*current_locals_)[i];
601 if (current_local_value != nullptr) {
602 HPhi* phi = new (arena) HPhi(
603 arena,
604 i,
605 0,
606 current_local_value->GetType());
David Brazdileead0712015-09-18 14:58:57 +0100607 block->AddPhi(phi);
608 (*locals)[i] = phi;
609 }
610 }
611 }
612 }
613 return locals;
614}
615
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100616HInstruction* SsaBuilder::ValueOfLocal(HBasicBlock* block, size_t local) {
Vladimir Marko71bf8092015-09-15 15:33:14 +0100617 ArenaVector<HInstruction*>* locals = GetLocalsFor(block);
Vladimir Marko71bf8092015-09-15 15:33:14 +0100618 return (*locals)[local];
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100619}
620
621void SsaBuilder::VisitBasicBlock(HBasicBlock* block) {
622 current_locals_ = GetLocalsFor(block);
623
David Brazdilffee3d32015-07-06 11:48:53 +0100624 if (block->IsCatchBlock()) {
625 // Catch phis were already created and inputs collected from throwing sites.
David Brazdild0180f92015-09-22 14:39:58 +0100626 if (kIsDebugBuild) {
627 // Make sure there was at least one throwing instruction which initialized
628 // locals (guaranteed by HGraphBuilder) and that all try blocks have been
629 // visited already (from HTryBoundary scoping and reverse post order).
630 bool throwing_instruction_found = false;
631 bool catch_block_visited = false;
632 for (HReversePostOrderIterator it(*GetGraph()); !it.Done(); it.Advance()) {
633 HBasicBlock* current = it.Current();
634 if (current == block) {
635 catch_block_visited = true;
636 } else if (current->IsTryBlock() &&
637 current->GetTryCatchInformation()->GetTryEntry().HasExceptionHandler(*block)) {
638 DCHECK(!catch_block_visited) << "Catch block visited before its try block.";
639 throwing_instruction_found |= current->HasThrowingInstructions();
640 }
641 }
642 DCHECK(throwing_instruction_found) << "No instructions throwing into a live catch block.";
643 }
David Brazdilffee3d32015-07-06 11:48:53 +0100644 } else if (block->IsLoopHeader()) {
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100645 // If the block is a loop header, we know we only have visited the pre header
Nicolas Geoffray804d0932014-05-02 08:46:00 +0100646 // because we are visiting in reverse post order. We create phis for all initialized
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100647 // locals from the pre header. Their inputs will be populated at the end of
648 // the analysis.
Vladimir Marko71bf8092015-09-15 15:33:14 +0100649 for (size_t local = 0; local < current_locals_->size(); ++local) {
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100650 HInstruction* incoming = ValueOfLocal(block->GetLoopInformation()->GetPreHeader(), local);
651 if (incoming != nullptr) {
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100652 HPhi* phi = new (GetGraph()->GetArena()) HPhi(
David Brazdil809d70f2015-11-19 10:29:39 +0000653 GetGraph()->GetArena(),
654 local,
655 0,
656 incoming->GetType());
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100657 block->AddPhi(phi);
Vladimir Marko71bf8092015-09-15 15:33:14 +0100658 (*current_locals_)[local] = phi;
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100659 }
660 }
661 // Save the loop header so that the last phase of the analysis knows which
662 // blocks need to be updated.
Vladimir Marko71bf8092015-09-15 15:33:14 +0100663 loop_headers_.push_back(block);
Vladimir Marko60584552015-09-03 13:35:12 +0000664 } else if (block->GetPredecessors().size() > 0) {
Nicolas Geoffray804d0932014-05-02 08:46:00 +0100665 // All predecessors have already been visited because we are visiting in reverse post order.
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100666 // We merge the values of all locals, creating phis if those values differ.
Vladimir Marko71bf8092015-09-15 15:33:14 +0100667 for (size_t local = 0; local < current_locals_->size(); ++local) {
Nicolas Geoffray7c3560f2014-06-04 12:12:08 +0100668 bool one_predecessor_has_no_value = false;
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100669 bool is_different = false;
Vladimir Markoec7802a2015-10-01 20:57:57 +0100670 HInstruction* value = ValueOfLocal(block->GetPredecessors()[0], local);
Nicolas Geoffray7c3560f2014-06-04 12:12:08 +0100671
Vladimir Marko60584552015-09-03 13:35:12 +0000672 for (HBasicBlock* predecessor : block->GetPredecessors()) {
673 HInstruction* current = ValueOfLocal(predecessor, local);
Nicolas Geoffray7c3560f2014-06-04 12:12:08 +0100674 if (current == nullptr) {
Nicolas Geoffrayec7e4722014-06-06 11:24:33 +0100675 one_predecessor_has_no_value = true;
676 break;
Nicolas Geoffray7c3560f2014-06-04 12:12:08 +0100677 } else if (current != value) {
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100678 is_different = true;
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100679 }
680 }
Nicolas Geoffray7c3560f2014-06-04 12:12:08 +0100681
682 if (one_predecessor_has_no_value) {
683 // If one predecessor has no value for this local, we trust the verifier has
684 // successfully checked that there is a store dominating any read after this block.
685 continue;
686 }
687
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100688 if (is_different) {
David Brazdil809d70f2015-11-19 10:29:39 +0000689 HInstruction* first_input = ValueOfLocal(block->GetPredecessors()[0], local);
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100690 HPhi* phi = new (GetGraph()->GetArena()) HPhi(
David Brazdil809d70f2015-11-19 10:29:39 +0000691 GetGraph()->GetArena(),
692 local,
693 block->GetPredecessors().size(),
694 first_input->GetType());
Vladimir Marko60584552015-09-03 13:35:12 +0000695 for (size_t i = 0; i < block->GetPredecessors().size(); i++) {
Vladimir Markoec7802a2015-10-01 20:57:57 +0100696 HInstruction* pred_value = ValueOfLocal(block->GetPredecessors()[i], local);
Andreas Gampe277ccbd2014-11-03 21:36:10 -0800697 phi->SetRawInputAt(i, pred_value);
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100698 }
699 block->AddPhi(phi);
700 value = phi;
701 }
Vladimir Marko71bf8092015-09-15 15:33:14 +0100702 (*current_locals_)[local] = value;
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100703 }
704 }
705
706 // Visit all instructions. The instructions of interest are:
707 // - HLoadLocal: replace them with the current value of the local.
708 // - HStoreLocal: update current value of the local and remove the instruction.
709 // - Instructions that require an environment: populate their environment
710 // with the current values of the locals.
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100711 for (HInstructionIterator it(block->GetInstructions()); !it.Done(); it.Advance()) {
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100712 it.Current()->Accept(this);
713 }
714}
715
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100716/**
717 * Constants in the Dex format are not typed. So the builder types them as
718 * integers, but when doing the SSA form, we might realize the constant
719 * is used for floating point operations. We create a floating-point equivalent
720 * constant to make the operations correctly typed.
721 */
David Brazdil8d5b8b22015-03-24 10:51:52 +0000722HFloatConstant* SsaBuilder::GetFloatEquivalent(HIntConstant* constant) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100723 // We place the floating point constant next to this constant.
724 HFloatConstant* result = constant->GetNext()->AsFloatConstant();
725 if (result == nullptr) {
726 HGraph* graph = constant->GetBlock()->GetGraph();
727 ArenaAllocator* allocator = graph->GetArena();
Roland Levillainda4d79b2015-03-24 14:36:11 +0000728 result = new (allocator) HFloatConstant(bit_cast<float, int32_t>(constant->GetValue()));
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100729 constant->GetBlock()->InsertInstructionBefore(result, constant->GetNext());
Nicolas Geoffrayf213e052015-04-27 08:53:46 +0000730 graph->CacheFloatConstant(result);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100731 } else {
732 // If there is already a constant with the expected type, we know it is
733 // the floating point equivalent of this constant.
Roland Levillainda4d79b2015-03-24 14:36:11 +0000734 DCHECK_EQ((bit_cast<int32_t, float>(result->GetValue())), constant->GetValue());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100735 }
736 return result;
737}
738
739/**
740 * Wide constants in the Dex format are not typed. So the builder types them as
741 * longs, but when doing the SSA form, we might realize the constant
742 * is used for floating point operations. We create a floating-point equivalent
743 * constant to make the operations correctly typed.
744 */
David Brazdil8d5b8b22015-03-24 10:51:52 +0000745HDoubleConstant* SsaBuilder::GetDoubleEquivalent(HLongConstant* constant) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100746 // We place the floating point constant next to this constant.
747 HDoubleConstant* result = constant->GetNext()->AsDoubleConstant();
748 if (result == nullptr) {
749 HGraph* graph = constant->GetBlock()->GetGraph();
750 ArenaAllocator* allocator = graph->GetArena();
Roland Levillainda4d79b2015-03-24 14:36:11 +0000751 result = new (allocator) HDoubleConstant(bit_cast<double, int64_t>(constant->GetValue()));
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100752 constant->GetBlock()->InsertInstructionBefore(result, constant->GetNext());
Nicolas Geoffrayf213e052015-04-27 08:53:46 +0000753 graph->CacheDoubleConstant(result);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100754 } else {
755 // If there is already a constant with the expected type, we know it is
756 // the floating point equivalent of this constant.
Roland Levillainda4d79b2015-03-24 14:36:11 +0000757 DCHECK_EQ((bit_cast<int64_t, double>(result->GetValue())), constant->GetValue());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100758 }
759 return result;
760}
761
762/**
763 * Because of Dex format, we might end up having the same phi being
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000764 * used for non floating point operations and floating point / reference operations.
765 * Because we want the graph to be correctly typed (and thereafter avoid moves between
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100766 * floating point registers and core registers), we need to create a copy of the
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000767 * phi with a floating point / reference type.
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100768 */
David Brazdil8d5b8b22015-03-24 10:51:52 +0000769HPhi* SsaBuilder::GetFloatDoubleOrReferenceEquivalentOfPhi(HPhi* phi, Primitive::Type type) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000770 DCHECK(phi->IsLive()) << "Cannot get equivalent of a dead phi since it would create a live one.";
771
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000772 // We place the floating point /reference phi next to this phi.
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100773 HInstruction* next = phi->GetNext();
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000774 if (next != nullptr
775 && next->AsPhi()->GetRegNumber() == phi->GetRegNumber()
776 && next->GetType() != type) {
777 // Move to the next phi to see if it is the one we are looking for.
778 next = next->GetNext();
779 }
780
781 if (next == nullptr
782 || (next->AsPhi()->GetRegNumber() != phi->GetRegNumber())
783 || (next->GetType() != type)) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100784 ArenaAllocator* allocator = phi->GetBlock()->GetGraph()->GetArena();
785 HPhi* new_phi = new (allocator) HPhi(allocator, phi->GetRegNumber(), phi->InputCount(), type);
786 for (size_t i = 0, e = phi->InputCount(); i < e; ++i) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000787 // Copy the inputs. Note that the graph may not be correctly typed
788 // by doing this copy, but the type propagation phase will fix it.
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100789 new_phi->SetRawInputAt(i, phi->InputAt(i));
790 }
791 phi->GetBlock()->InsertPhiAfter(new_phi, phi);
David Brazdil4833f5a2015-12-16 10:37:39 +0000792 DCHECK(new_phi->IsLive());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100793 return new_phi;
794 } else {
David Brazdil4833f5a2015-12-16 10:37:39 +0000795 // An existing equivalent was found. If it is dead, conflict was previously
796 // identified and we return nullptr instead.
David Brazdil809d70f2015-11-19 10:29:39 +0000797 HPhi* next_phi = next->AsPhi();
798 DCHECK_EQ(next_phi->GetType(), type);
David Brazdil4833f5a2015-12-16 10:37:39 +0000799 return next_phi->IsLive() ? next_phi : nullptr;
David Brazdild9510df2015-11-04 23:30:22 +0000800 }
801}
802
David Brazdil4833f5a2015-12-16 10:37:39 +0000803HArrayGet* SsaBuilder::GetFloatOrDoubleEquivalentOfArrayGet(HArrayGet* aget) {
804 DCHECK(Primitive::IsIntegralType(aget->GetType()));
805
806 if (!Primitive::IsIntOrLongType(aget->GetType())) {
807 // Cannot type boolean, char, byte, short to float/double.
808 return nullptr;
809 }
810
811 DCHECK(ContainsElement(ambiguous_agets_, aget));
812 if (agets_fixed_) {
813 // This used to be an ambiguous ArrayGet but its type has been resolved to
814 // int/long. Requesting a float/double equivalent should lead to a conflict.
815 if (kIsDebugBuild) {
816 ScopedObjectAccess soa(Thread::Current());
David Brazdil15693bf2015-12-16 10:30:45 +0000817 DCHECK(Primitive::IsIntOrLongType(GetPrimitiveArrayComponentType(aget->GetArray())));
David Brazdil4833f5a2015-12-16 10:37:39 +0000818 }
819 return nullptr;
820 } else {
821 // This is an ambiguous ArrayGet which has not been resolved yet. Return an
822 // equivalent float/double instruction to use until it is resolved.
823 HArrayGet* equivalent = FindFloatOrDoubleEquivalentOfArrayGet(aget);
824 return (equivalent == nullptr) ? CreateFloatOrDoubleEquivalentOfArrayGet(aget) : equivalent;
825 }
826}
827
828HInstruction* SsaBuilder::GetFloatOrDoubleEquivalent(HInstruction* value, Primitive::Type type) {
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100829 if (value->IsArrayGet()) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000830 return GetFloatOrDoubleEquivalentOfArrayGet(value->AsArrayGet());
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100831 } else if (value->IsLongConstant()) {
832 return GetDoubleEquivalent(value->AsLongConstant());
833 } else if (value->IsIntConstant()) {
834 return GetFloatEquivalent(value->AsIntConstant());
835 } else if (value->IsPhi()) {
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000836 return GetFloatDoubleOrReferenceEquivalentOfPhi(value->AsPhi(), type);
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100837 } else {
David Brazdil4833f5a2015-12-16 10:37:39 +0000838 return nullptr;
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100839 }
840}
841
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000842HInstruction* SsaBuilder::GetReferenceTypeEquivalent(HInstruction* value) {
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000843 if (value->IsIntConstant() && value->AsIntConstant()->GetValue() == 0) {
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000844 return value->GetBlock()->GetGraph()->GetNullConstant();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000845 } else if (value->IsPhi()) {
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000846 return GetFloatDoubleOrReferenceEquivalentOfPhi(value->AsPhi(), Primitive::kPrimNot);
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000847 } else {
848 return nullptr;
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000849 }
850}
851
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100852void SsaBuilder::VisitLoadLocal(HLoadLocal* load) {
David Brazdil4833f5a2015-12-16 10:37:39 +0000853 Primitive::Type load_type = load->GetType();
Vladimir Marko71bf8092015-09-15 15:33:14 +0100854 HInstruction* value = (*current_locals_)[load->GetLocal()->GetRegNumber()];
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000855 // If the operation requests a specific type, we make sure its input is of that type.
David Brazdil4833f5a2015-12-16 10:37:39 +0000856 if (load_type != value->GetType()) {
857 if (load_type == Primitive::kPrimFloat || load_type == Primitive::kPrimDouble) {
858 value = GetFloatOrDoubleEquivalent(value, load_type);
859 } else if (load_type == Primitive::kPrimNot) {
Nicolas Geoffrayd6138ef2015-02-18 14:48:53 +0000860 value = GetReferenceTypeEquivalent(value);
861 }
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100862 }
David Brazdil4833f5a2015-12-16 10:37:39 +0000863
Nicolas Geoffray102cbed2014-10-15 18:31:05 +0100864 load->ReplaceWith(value);
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100865 load->GetBlock()->RemoveInstruction(load);
866}
867
868void SsaBuilder::VisitStoreLocal(HStoreLocal* store) {
David Brazdil809d70f2015-11-19 10:29:39 +0000869 uint32_t reg_number = store->GetLocal()->GetRegNumber();
870 HInstruction* stored_value = store->InputAt(1);
871 Primitive::Type stored_type = stored_value->GetType();
872 DCHECK_NE(stored_type, Primitive::kPrimVoid);
873
874 // Storing into vreg `reg_number` may implicitly invalidate the surrounding
875 // registers. Consider the following cases:
876 // (1) Storing a wide value must overwrite previous values in both `reg_number`
877 // and `reg_number+1`. We store `nullptr` in `reg_number+1`.
878 // (2) If vreg `reg_number-1` holds a wide value, writing into `reg_number`
879 // must invalidate it. We store `nullptr` in `reg_number-1`.
880 // Consequently, storing a wide value into the high vreg of another wide value
881 // will invalidate both `reg_number-1` and `reg_number+1`.
882
883 if (reg_number != 0) {
884 HInstruction* local_low = (*current_locals_)[reg_number - 1];
885 if (local_low != nullptr && Primitive::Is64BitType(local_low->GetType())) {
886 // The vreg we are storing into was previously the high vreg of a pair.
887 // We need to invalidate its low vreg.
888 DCHECK((*current_locals_)[reg_number] == nullptr);
889 (*current_locals_)[reg_number - 1] = nullptr;
890 }
891 }
892
893 (*current_locals_)[reg_number] = stored_value;
894 if (Primitive::Is64BitType(stored_type)) {
895 // We are storing a pair. Invalidate the instruction in the high vreg.
896 (*current_locals_)[reg_number + 1] = nullptr;
897 }
898
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100899 store->GetBlock()->RemoveInstruction(store);
900}
901
902void SsaBuilder::VisitInstruction(HInstruction* instruction) {
David Brazdilffee3d32015-07-06 11:48:53 +0100903 if (instruction->NeedsEnvironment()) {
904 HEnvironment* environment = new (GetGraph()->GetArena()) HEnvironment(
905 GetGraph()->GetArena(),
Vladimir Marko71bf8092015-09-15 15:33:14 +0100906 current_locals_->size(),
David Brazdilffee3d32015-07-06 11:48:53 +0100907 GetGraph()->GetDexFile(),
908 GetGraph()->GetMethodIdx(),
909 instruction->GetDexPc(),
910 GetGraph()->GetInvokeType(),
911 instruction);
912 environment->CopyFrom(*current_locals_);
913 instruction->SetRawEnvironment(environment);
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100914 }
David Brazdilffee3d32015-07-06 11:48:53 +0100915
916 // If in a try block, propagate values of locals into catch blocks.
David Brazdilec16f792015-08-19 15:04:01 +0100917 if (instruction->CanThrowIntoCatchBlock()) {
918 const HTryBoundary& try_entry =
919 instruction->GetBlock()->GetTryCatchInformation()->GetTryEntry();
David Brazdild26a4112015-11-10 11:07:31 +0000920 for (HBasicBlock* catch_block : try_entry.GetExceptionHandlers()) {
David Brazdil3eaa32f2015-09-18 10:58:32 +0100921 ArenaVector<HInstruction*>* handler_locals = GetLocalsFor(catch_block);
Vladimir Marko71bf8092015-09-15 15:33:14 +0100922 DCHECK_EQ(handler_locals->size(), current_locals_->size());
David Brazdil3eaa32f2015-09-18 10:58:32 +0100923 for (size_t vreg = 0, e = current_locals_->size(); vreg < e; ++vreg) {
924 HInstruction* handler_value = (*handler_locals)[vreg];
925 if (handler_value == nullptr) {
926 // Vreg was undefined at a previously encountered throwing instruction
927 // and the catch phi was deleted. Do not record the local value.
928 continue;
929 }
930 DCHECK(handler_value->IsPhi());
931
932 HInstruction* local_value = (*current_locals_)[vreg];
933 if (local_value == nullptr) {
934 // This is the first instruction throwing into `catch_block` where
935 // `vreg` is undefined. Delete the catch phi.
936 catch_block->RemovePhi(handler_value->AsPhi());
937 (*handler_locals)[vreg] = nullptr;
938 } else {
939 // Vreg has been defined at all instructions throwing into `catch_block`
940 // encountered so far. Record the local value in the catch phi.
941 handler_value->AsPhi()->AddInput(local_value);
David Brazdilffee3d32015-07-06 11:48:53 +0100942 }
943 }
944 }
945 }
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100946}
947
David Brazdil4833f5a2015-12-16 10:37:39 +0000948void SsaBuilder::VisitArrayGet(HArrayGet* aget) {
949 Primitive::Type type = aget->GetType();
950 DCHECK(!Primitive::IsFloatingPointType(type));
951 if (Primitive::IsIntOrLongType(type)) {
952 ambiguous_agets_.push_back(aget);
953 }
954 VisitInstruction(aget);
955}
956
David Brazdil15693bf2015-12-16 10:30:45 +0000957void SsaBuilder::VisitArraySet(HArraySet* aset) {
958 Primitive::Type type = aset->GetValue()->GetType();
959 if (Primitive::IsIntOrLongType(type)) {
960 ambiguous_asets_.push_back(aset);
961 }
962 VisitInstruction(aset);
963}
964
David Brazdil6de19382016-01-08 17:37:10 +0000965void SsaBuilder::VisitInvokeStaticOrDirect(HInvokeStaticOrDirect* invoke) {
966 VisitInstruction(invoke);
967
968 if (invoke->IsStringInit()) {
969 // This is a StringFactory call which acts as a String constructor. Its
970 // result replaces the empty String pre-allocated by NewInstance.
David Brazdilbc9ab162016-01-20 14:50:19 +0000971 HInstruction* arg_this = invoke->GetAndRemoveThisArgumentOfStringInit();
David Brazdil6de19382016-01-08 17:37:10 +0000972
David Brazdil65902e82016-01-15 09:35:13 +0000973 // Replacing the NewInstance might render it redundant. Keep a list of these
974 // to be visited once it is clear whether it is has remaining uses.
David Brazdilbc9ab162016-01-20 14:50:19 +0000975 if (arg_this->IsNewInstance()) {
Aart Bikeda31402016-03-24 15:38:56 -0700976 HNewInstance* new_instance = arg_this->AsNewInstance();
977 // Note that in some rare cases (b/27847265), the same NewInstance may be seen
978 // multiple times. We should only consider it once for removal, so we
979 // ensure it is not added more than once.
980 if (!ContainsElement(uninitialized_strings_, new_instance)) {
981 uninitialized_strings_.push_back(new_instance);
982 }
David Brazdilbc9ab162016-01-20 14:50:19 +0000983 } else {
David Brazdilc047d942016-01-20 17:00:19 +0000984 DCHECK(arg_this->IsPhi());
David Brazdilbc9ab162016-01-20 14:50:19 +0000985 // NewInstance is not the direct input of the StringFactory call. It might
986 // be redundant but optimizing this case is not worth the effort.
987 }
David Brazdil65902e82016-01-15 09:35:13 +0000988
David Brazdilbc9ab162016-01-20 14:50:19 +0000989 // Walk over all vregs and replace any occurrence of `arg_this` with `invoke`.
David Brazdil6de19382016-01-08 17:37:10 +0000990 for (size_t vreg = 0, e = current_locals_->size(); vreg < e; ++vreg) {
David Brazdilbc9ab162016-01-20 14:50:19 +0000991 if ((*current_locals_)[vreg] == arg_this) {
David Brazdil6de19382016-01-08 17:37:10 +0000992 (*current_locals_)[vreg] = invoke;
993 }
994 }
995 }
996}
997
Nicolas Geoffrayc32e7702014-04-24 12:43:16 +0100998} // namespace art