blob: 5a6a212cc9842265eb1eff3e4cd12e2bf1794974 [file] [log] [blame]
David Brazdildee58d62016-04-07 09:54:26 +00001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "instruction_builder.h"
18
Matthew Gharrity465ecc82016-07-19 21:32:52 +000019#include "art_method-inl.h"
David Brazdildee58d62016-04-07 09:54:26 +000020#include "bytecode_utils.h"
21#include "class_linker.h"
Andreas Gampe26de38b2016-07-27 17:53:11 -070022#include "dex_instruction-inl.h"
David Brazdildee58d62016-04-07 09:54:26 +000023#include "driver/compiler_options.h"
24#include "scoped_thread_state_change.h"
25
26namespace art {
27
28void HInstructionBuilder::MaybeRecordStat(MethodCompilationStat compilation_stat) {
29 if (compilation_stats_ != nullptr) {
30 compilation_stats_->RecordStat(compilation_stat);
31 }
32}
33
34HBasicBlock* HInstructionBuilder::FindBlockStartingAt(uint32_t dex_pc) const {
35 return block_builder_->GetBlockAt(dex_pc);
36}
37
38ArenaVector<HInstruction*>* HInstructionBuilder::GetLocalsFor(HBasicBlock* block) {
39 ArenaVector<HInstruction*>* locals = &locals_for_[block->GetBlockId()];
40 const size_t vregs = graph_->GetNumberOfVRegs();
41 if (locals->size() != vregs) {
42 locals->resize(vregs, nullptr);
43
44 if (block->IsCatchBlock()) {
45 // We record incoming inputs of catch phis at throwing instructions and
46 // must therefore eagerly create the phis. Phis for undefined vregs will
47 // be deleted when the first throwing instruction with the vreg undefined
48 // is encountered. Unused phis will be removed by dead phi analysis.
49 for (size_t i = 0; i < vregs; ++i) {
50 // No point in creating the catch phi if it is already undefined at
51 // the first throwing instruction.
52 HInstruction* current_local_value = (*current_locals_)[i];
53 if (current_local_value != nullptr) {
54 HPhi* phi = new (arena_) HPhi(
55 arena_,
56 i,
57 0,
58 current_local_value->GetType());
59 block->AddPhi(phi);
60 (*locals)[i] = phi;
61 }
62 }
63 }
64 }
65 return locals;
66}
67
68HInstruction* HInstructionBuilder::ValueOfLocalAt(HBasicBlock* block, size_t local) {
69 ArenaVector<HInstruction*>* locals = GetLocalsFor(block);
70 return (*locals)[local];
71}
72
73void HInstructionBuilder::InitializeBlockLocals() {
74 current_locals_ = GetLocalsFor(current_block_);
75
76 if (current_block_->IsCatchBlock()) {
77 // Catch phis were already created and inputs collected from throwing sites.
78 if (kIsDebugBuild) {
79 // Make sure there was at least one throwing instruction which initialized
80 // locals (guaranteed by HGraphBuilder) and that all try blocks have been
81 // visited already (from HTryBoundary scoping and reverse post order).
82 bool catch_block_visited = false;
83 for (HReversePostOrderIterator it(*graph_); !it.Done(); it.Advance()) {
84 HBasicBlock* current = it.Current();
85 if (current == current_block_) {
86 catch_block_visited = true;
87 } else if (current->IsTryBlock()) {
88 const HTryBoundary& try_entry = current->GetTryCatchInformation()->GetTryEntry();
89 if (try_entry.HasExceptionHandler(*current_block_)) {
90 DCHECK(!catch_block_visited) << "Catch block visited before its try block.";
91 }
92 }
93 }
94 DCHECK_EQ(current_locals_->size(), graph_->GetNumberOfVRegs())
95 << "No instructions throwing into a live catch block.";
96 }
97 } else if (current_block_->IsLoopHeader()) {
98 // If the block is a loop header, we know we only have visited the pre header
99 // because we are visiting in reverse post order. We create phis for all initialized
100 // locals from the pre header. Their inputs will be populated at the end of
101 // the analysis.
102 for (size_t local = 0; local < current_locals_->size(); ++local) {
103 HInstruction* incoming =
104 ValueOfLocalAt(current_block_->GetLoopInformation()->GetPreHeader(), local);
105 if (incoming != nullptr) {
106 HPhi* phi = new (arena_) HPhi(
107 arena_,
108 local,
109 0,
110 incoming->GetType());
111 current_block_->AddPhi(phi);
112 (*current_locals_)[local] = phi;
113 }
114 }
115
116 // Save the loop header so that the last phase of the analysis knows which
117 // blocks need to be updated.
118 loop_headers_.push_back(current_block_);
119 } else if (current_block_->GetPredecessors().size() > 0) {
120 // All predecessors have already been visited because we are visiting in reverse post order.
121 // We merge the values of all locals, creating phis if those values differ.
122 for (size_t local = 0; local < current_locals_->size(); ++local) {
123 bool one_predecessor_has_no_value = false;
124 bool is_different = false;
125 HInstruction* value = ValueOfLocalAt(current_block_->GetPredecessors()[0], local);
126
127 for (HBasicBlock* predecessor : current_block_->GetPredecessors()) {
128 HInstruction* current = ValueOfLocalAt(predecessor, local);
129 if (current == nullptr) {
130 one_predecessor_has_no_value = true;
131 break;
132 } else if (current != value) {
133 is_different = true;
134 }
135 }
136
137 if (one_predecessor_has_no_value) {
138 // If one predecessor has no value for this local, we trust the verifier has
139 // successfully checked that there is a store dominating any read after this block.
140 continue;
141 }
142
143 if (is_different) {
144 HInstruction* first_input = ValueOfLocalAt(current_block_->GetPredecessors()[0], local);
145 HPhi* phi = new (arena_) HPhi(
146 arena_,
147 local,
148 current_block_->GetPredecessors().size(),
149 first_input->GetType());
150 for (size_t i = 0; i < current_block_->GetPredecessors().size(); i++) {
151 HInstruction* pred_value = ValueOfLocalAt(current_block_->GetPredecessors()[i], local);
152 phi->SetRawInputAt(i, pred_value);
153 }
154 current_block_->AddPhi(phi);
155 value = phi;
156 }
157 (*current_locals_)[local] = value;
158 }
159 }
160}
161
162void HInstructionBuilder::PropagateLocalsToCatchBlocks() {
163 const HTryBoundary& try_entry = current_block_->GetTryCatchInformation()->GetTryEntry();
164 for (HBasicBlock* catch_block : try_entry.GetExceptionHandlers()) {
165 ArenaVector<HInstruction*>* handler_locals = GetLocalsFor(catch_block);
166 DCHECK_EQ(handler_locals->size(), current_locals_->size());
167 for (size_t vreg = 0, e = current_locals_->size(); vreg < e; ++vreg) {
168 HInstruction* handler_value = (*handler_locals)[vreg];
169 if (handler_value == nullptr) {
170 // Vreg was undefined at a previously encountered throwing instruction
171 // and the catch phi was deleted. Do not record the local value.
172 continue;
173 }
174 DCHECK(handler_value->IsPhi());
175
176 HInstruction* local_value = (*current_locals_)[vreg];
177 if (local_value == nullptr) {
178 // This is the first instruction throwing into `catch_block` where
179 // `vreg` is undefined. Delete the catch phi.
180 catch_block->RemovePhi(handler_value->AsPhi());
181 (*handler_locals)[vreg] = nullptr;
182 } else {
183 // Vreg has been defined at all instructions throwing into `catch_block`
184 // encountered so far. Record the local value in the catch phi.
185 handler_value->AsPhi()->AddInput(local_value);
186 }
187 }
188 }
189}
190
191void HInstructionBuilder::AppendInstruction(HInstruction* instruction) {
192 current_block_->AddInstruction(instruction);
193 InitializeInstruction(instruction);
194}
195
196void HInstructionBuilder::InsertInstructionAtTop(HInstruction* instruction) {
197 if (current_block_->GetInstructions().IsEmpty()) {
198 current_block_->AddInstruction(instruction);
199 } else {
200 current_block_->InsertInstructionBefore(instruction, current_block_->GetFirstInstruction());
201 }
202 InitializeInstruction(instruction);
203}
204
205void HInstructionBuilder::InitializeInstruction(HInstruction* instruction) {
206 if (instruction->NeedsEnvironment()) {
207 HEnvironment* environment = new (arena_) HEnvironment(
208 arena_,
209 current_locals_->size(),
210 graph_->GetDexFile(),
211 graph_->GetMethodIdx(),
212 instruction->GetDexPc(),
213 graph_->GetInvokeType(),
214 instruction);
215 environment->CopyFrom(*current_locals_);
216 instruction->SetRawEnvironment(environment);
217 }
218}
219
David Brazdilc120bbe2016-04-22 16:57:00 +0100220HInstruction* HInstructionBuilder::LoadNullCheckedLocal(uint32_t register_index, uint32_t dex_pc) {
221 HInstruction* ref = LoadLocal(register_index, Primitive::kPrimNot);
222 if (!ref->CanBeNull()) {
223 return ref;
224 }
225
226 HNullCheck* null_check = new (arena_) HNullCheck(ref, dex_pc);
227 AppendInstruction(null_check);
228 return null_check;
229}
230
David Brazdildee58d62016-04-07 09:54:26 +0000231void HInstructionBuilder::SetLoopHeaderPhiInputs() {
232 for (size_t i = loop_headers_.size(); i > 0; --i) {
233 HBasicBlock* block = loop_headers_[i - 1];
234 for (HInstructionIterator it(block->GetPhis()); !it.Done(); it.Advance()) {
235 HPhi* phi = it.Current()->AsPhi();
236 size_t vreg = phi->GetRegNumber();
237 for (HBasicBlock* predecessor : block->GetPredecessors()) {
238 HInstruction* value = ValueOfLocalAt(predecessor, vreg);
239 if (value == nullptr) {
240 // Vreg is undefined at this predecessor. Mark it dead and leave with
241 // fewer inputs than predecessors. SsaChecker will fail if not removed.
242 phi->SetDead();
243 break;
244 } else {
245 phi->AddInput(value);
246 }
247 }
248 }
249 }
250}
251
252static bool IsBlockPopulated(HBasicBlock* block) {
253 if (block->IsLoopHeader()) {
254 // Suspend checks were inserted into loop headers during building of dominator tree.
255 DCHECK(block->GetFirstInstruction()->IsSuspendCheck());
256 return block->GetFirstInstruction() != block->GetLastInstruction();
257 } else {
258 return !block->GetInstructions().IsEmpty();
259 }
260}
261
262bool HInstructionBuilder::Build() {
263 locals_for_.resize(graph_->GetBlocks().size(),
264 ArenaVector<HInstruction*>(arena_->Adapter(kArenaAllocGraphBuilder)));
265
266 // Find locations where we want to generate extra stackmaps for native debugging.
267 // This allows us to generate the info only at interesting points (for example,
268 // at start of java statement) rather than before every dex instruction.
269 const bool native_debuggable = compiler_driver_ != nullptr &&
270 compiler_driver_->GetCompilerOptions().GetNativeDebuggable();
271 ArenaBitVector* native_debug_info_locations = nullptr;
272 if (native_debuggable) {
273 const uint32_t num_instructions = code_item_.insns_size_in_code_units_;
274 native_debug_info_locations = new (arena_) ArenaBitVector (arena_, num_instructions, false);
275 FindNativeDebugInfoLocations(native_debug_info_locations);
276 }
277
278 for (HReversePostOrderIterator block_it(*graph_); !block_it.Done(); block_it.Advance()) {
279 current_block_ = block_it.Current();
280 uint32_t block_dex_pc = current_block_->GetDexPc();
281
282 InitializeBlockLocals();
283
284 if (current_block_->IsEntryBlock()) {
285 InitializeParameters();
286 AppendInstruction(new (arena_) HSuspendCheck(0u));
287 AppendInstruction(new (arena_) HGoto(0u));
288 continue;
289 } else if (current_block_->IsExitBlock()) {
290 AppendInstruction(new (arena_) HExit());
291 continue;
292 } else if (current_block_->IsLoopHeader()) {
293 HSuspendCheck* suspend_check = new (arena_) HSuspendCheck(current_block_->GetDexPc());
294 current_block_->GetLoopInformation()->SetSuspendCheck(suspend_check);
295 // This is slightly odd because the loop header might not be empty (TryBoundary).
296 // But we're still creating the environment with locals from the top of the block.
297 InsertInstructionAtTop(suspend_check);
298 }
299
300 if (block_dex_pc == kNoDexPc || current_block_ != block_builder_->GetBlockAt(block_dex_pc)) {
301 // Synthetic block that does not need to be populated.
302 DCHECK(IsBlockPopulated(current_block_));
303 continue;
304 }
305
306 DCHECK(!IsBlockPopulated(current_block_));
307
308 for (CodeItemIterator it(code_item_, block_dex_pc); !it.Done(); it.Advance()) {
309 if (current_block_ == nullptr) {
310 // The previous instruction ended this block.
311 break;
312 }
313
314 uint32_t dex_pc = it.CurrentDexPc();
315 if (dex_pc != block_dex_pc && FindBlockStartingAt(dex_pc) != nullptr) {
316 // This dex_pc starts a new basic block.
317 break;
318 }
319
320 if (current_block_->IsTryBlock() && IsThrowingDexInstruction(it.CurrentInstruction())) {
321 PropagateLocalsToCatchBlocks();
322 }
323
324 if (native_debuggable && native_debug_info_locations->IsBitSet(dex_pc)) {
325 AppendInstruction(new (arena_) HNativeDebugInfo(dex_pc));
326 }
327
328 if (!ProcessDexInstruction(it.CurrentInstruction(), dex_pc)) {
329 return false;
330 }
331 }
332
333 if (current_block_ != nullptr) {
334 // Branching instructions clear current_block, so we know the last
335 // instruction of the current block is not a branching instruction.
336 // We add an unconditional Goto to the next block.
337 DCHECK_EQ(current_block_->GetSuccessors().size(), 1u);
338 AppendInstruction(new (arena_) HGoto());
339 }
340 }
341
342 SetLoopHeaderPhiInputs();
343
344 return true;
345}
346
347void HInstructionBuilder::FindNativeDebugInfoLocations(ArenaBitVector* locations) {
348 // The callback gets called when the line number changes.
349 // In other words, it marks the start of new java statement.
350 struct Callback {
351 static bool Position(void* ctx, const DexFile::PositionInfo& entry) {
352 static_cast<ArenaBitVector*>(ctx)->SetBit(entry.address_);
353 return false;
354 }
355 };
356 dex_file_->DecodeDebugPositionInfo(&code_item_, Callback::Position, locations);
357 // Instruction-specific tweaks.
358 const Instruction* const begin = Instruction::At(code_item_.insns_);
359 const Instruction* const end = begin->RelativeAt(code_item_.insns_size_in_code_units_);
360 for (const Instruction* inst = begin; inst < end; inst = inst->Next()) {
361 switch (inst->Opcode()) {
362 case Instruction::MOVE_EXCEPTION: {
363 // Stop in native debugger after the exception has been moved.
364 // The compiler also expects the move at the start of basic block so
365 // we do not want to interfere by inserting native-debug-info before it.
366 locations->ClearBit(inst->GetDexPc(code_item_.insns_));
367 const Instruction* next = inst->Next();
368 if (next < end) {
369 locations->SetBit(next->GetDexPc(code_item_.insns_));
370 }
371 break;
372 }
373 default:
374 break;
375 }
376 }
377}
378
379HInstruction* HInstructionBuilder::LoadLocal(uint32_t reg_number, Primitive::Type type) const {
380 HInstruction* value = (*current_locals_)[reg_number];
381 DCHECK(value != nullptr);
382
383 // If the operation requests a specific type, we make sure its input is of that type.
384 if (type != value->GetType()) {
385 if (Primitive::IsFloatingPointType(type)) {
Aart Bik31883642016-06-06 15:02:44 -0700386 value = ssa_builder_->GetFloatOrDoubleEquivalent(value, type);
David Brazdildee58d62016-04-07 09:54:26 +0000387 } else if (type == Primitive::kPrimNot) {
Aart Bik31883642016-06-06 15:02:44 -0700388 value = ssa_builder_->GetReferenceTypeEquivalent(value);
David Brazdildee58d62016-04-07 09:54:26 +0000389 }
Aart Bik31883642016-06-06 15:02:44 -0700390 DCHECK(value != nullptr);
David Brazdildee58d62016-04-07 09:54:26 +0000391 }
392
393 return value;
394}
395
396void HInstructionBuilder::UpdateLocal(uint32_t reg_number, HInstruction* stored_value) {
397 Primitive::Type stored_type = stored_value->GetType();
398 DCHECK_NE(stored_type, Primitive::kPrimVoid);
399
400 // Storing into vreg `reg_number` may implicitly invalidate the surrounding
401 // registers. Consider the following cases:
402 // (1) Storing a wide value must overwrite previous values in both `reg_number`
403 // and `reg_number+1`. We store `nullptr` in `reg_number+1`.
404 // (2) If vreg `reg_number-1` holds a wide value, writing into `reg_number`
405 // must invalidate it. We store `nullptr` in `reg_number-1`.
406 // Consequently, storing a wide value into the high vreg of another wide value
407 // will invalidate both `reg_number-1` and `reg_number+1`.
408
409 if (reg_number != 0) {
410 HInstruction* local_low = (*current_locals_)[reg_number - 1];
411 if (local_low != nullptr && Primitive::Is64BitType(local_low->GetType())) {
412 // The vreg we are storing into was previously the high vreg of a pair.
413 // We need to invalidate its low vreg.
414 DCHECK((*current_locals_)[reg_number] == nullptr);
415 (*current_locals_)[reg_number - 1] = nullptr;
416 }
417 }
418
419 (*current_locals_)[reg_number] = stored_value;
420 if (Primitive::Is64BitType(stored_type)) {
421 // We are storing a pair. Invalidate the instruction in the high vreg.
422 (*current_locals_)[reg_number + 1] = nullptr;
423 }
424}
425
426void HInstructionBuilder::InitializeParameters() {
427 DCHECK(current_block_->IsEntryBlock());
428
429 // dex_compilation_unit_ is null only when unit testing.
430 if (dex_compilation_unit_ == nullptr) {
431 return;
432 }
433
434 const char* shorty = dex_compilation_unit_->GetShorty();
435 uint16_t number_of_parameters = graph_->GetNumberOfInVRegs();
436 uint16_t locals_index = graph_->GetNumberOfLocalVRegs();
437 uint16_t parameter_index = 0;
438
439 const DexFile::MethodId& referrer_method_id =
440 dex_file_->GetMethodId(dex_compilation_unit_->GetDexMethodIndex());
441 if (!dex_compilation_unit_->IsStatic()) {
442 // Add the implicit 'this' argument, not expressed in the signature.
443 HParameterValue* parameter = new (arena_) HParameterValue(*dex_file_,
444 referrer_method_id.class_idx_,
445 parameter_index++,
446 Primitive::kPrimNot,
447 true);
448 AppendInstruction(parameter);
449 UpdateLocal(locals_index++, parameter);
450 number_of_parameters--;
451 }
452
453 const DexFile::ProtoId& proto = dex_file_->GetMethodPrototype(referrer_method_id);
454 const DexFile::TypeList* arg_types = dex_file_->GetProtoParameters(proto);
455 for (int i = 0, shorty_pos = 1; i < number_of_parameters; i++) {
456 HParameterValue* parameter = new (arena_) HParameterValue(
457 *dex_file_,
458 arg_types->GetTypeItem(shorty_pos - 1).type_idx_,
459 parameter_index++,
460 Primitive::GetType(shorty[shorty_pos]),
461 false);
462 ++shorty_pos;
463 AppendInstruction(parameter);
464 // Store the parameter value in the local that the dex code will use
465 // to reference that parameter.
466 UpdateLocal(locals_index++, parameter);
467 if (Primitive::Is64BitType(parameter->GetType())) {
468 i++;
469 locals_index++;
470 parameter_index++;
471 }
472 }
473}
474
475template<typename T>
476void HInstructionBuilder::If_22t(const Instruction& instruction, uint32_t dex_pc) {
477 HInstruction* first = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
478 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
479 T* comparison = new (arena_) T(first, second, dex_pc);
480 AppendInstruction(comparison);
481 AppendInstruction(new (arena_) HIf(comparison, dex_pc));
482 current_block_ = nullptr;
483}
484
485template<typename T>
486void HInstructionBuilder::If_21t(const Instruction& instruction, uint32_t dex_pc) {
487 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
488 T* comparison = new (arena_) T(value, graph_->GetIntConstant(0, dex_pc), dex_pc);
489 AppendInstruction(comparison);
490 AppendInstruction(new (arena_) HIf(comparison, dex_pc));
491 current_block_ = nullptr;
492}
493
494template<typename T>
495void HInstructionBuilder::Unop_12x(const Instruction& instruction,
496 Primitive::Type type,
497 uint32_t dex_pc) {
498 HInstruction* first = LoadLocal(instruction.VRegB(), type);
499 AppendInstruction(new (arena_) T(type, first, dex_pc));
500 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
501}
502
503void HInstructionBuilder::Conversion_12x(const Instruction& instruction,
504 Primitive::Type input_type,
505 Primitive::Type result_type,
506 uint32_t dex_pc) {
507 HInstruction* first = LoadLocal(instruction.VRegB(), input_type);
508 AppendInstruction(new (arena_) HTypeConversion(result_type, first, dex_pc));
509 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
510}
511
512template<typename T>
513void HInstructionBuilder::Binop_23x(const Instruction& instruction,
514 Primitive::Type type,
515 uint32_t dex_pc) {
516 HInstruction* first = LoadLocal(instruction.VRegB(), type);
517 HInstruction* second = LoadLocal(instruction.VRegC(), type);
518 AppendInstruction(new (arena_) T(type, first, second, dex_pc));
519 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
520}
521
522template<typename T>
523void HInstructionBuilder::Binop_23x_shift(const Instruction& instruction,
524 Primitive::Type type,
525 uint32_t dex_pc) {
526 HInstruction* first = LoadLocal(instruction.VRegB(), type);
527 HInstruction* second = LoadLocal(instruction.VRegC(), Primitive::kPrimInt);
528 AppendInstruction(new (arena_) T(type, first, second, dex_pc));
529 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
530}
531
532void HInstructionBuilder::Binop_23x_cmp(const Instruction& instruction,
533 Primitive::Type type,
534 ComparisonBias bias,
535 uint32_t dex_pc) {
536 HInstruction* first = LoadLocal(instruction.VRegB(), type);
537 HInstruction* second = LoadLocal(instruction.VRegC(), type);
538 AppendInstruction(new (arena_) HCompare(type, first, second, bias, dex_pc));
539 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
540}
541
542template<typename T>
543void HInstructionBuilder::Binop_12x_shift(const Instruction& instruction,
544 Primitive::Type type,
545 uint32_t dex_pc) {
546 HInstruction* first = LoadLocal(instruction.VRegA(), type);
547 HInstruction* second = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
548 AppendInstruction(new (arena_) T(type, first, second, dex_pc));
549 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
550}
551
552template<typename T>
553void HInstructionBuilder::Binop_12x(const Instruction& instruction,
554 Primitive::Type type,
555 uint32_t dex_pc) {
556 HInstruction* first = LoadLocal(instruction.VRegA(), type);
557 HInstruction* second = LoadLocal(instruction.VRegB(), type);
558 AppendInstruction(new (arena_) T(type, first, second, dex_pc));
559 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
560}
561
562template<typename T>
563void HInstructionBuilder::Binop_22s(const Instruction& instruction, bool reverse, uint32_t dex_pc) {
564 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
565 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22s(), dex_pc);
566 if (reverse) {
567 std::swap(first, second);
568 }
569 AppendInstruction(new (arena_) T(Primitive::kPrimInt, first, second, dex_pc));
570 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
571}
572
573template<typename T>
574void HInstructionBuilder::Binop_22b(const Instruction& instruction, bool reverse, uint32_t dex_pc) {
575 HInstruction* first = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
576 HInstruction* second = graph_->GetIntConstant(instruction.VRegC_22b(), dex_pc);
577 if (reverse) {
578 std::swap(first, second);
579 }
580 AppendInstruction(new (arena_) T(Primitive::kPrimInt, first, second, dex_pc));
581 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
582}
583
Mathieu Chartierc4ae9162016-04-07 13:19:19 -0700584static bool RequiresConstructorBarrier(const DexCompilationUnit* cu, CompilerDriver* driver) {
David Brazdildee58d62016-04-07 09:54:26 +0000585 Thread* self = Thread::Current();
586 return cu->IsConstructor()
Mathieu Chartierc4ae9162016-04-07 13:19:19 -0700587 && driver->RequiresConstructorBarrier(self, cu->GetDexFile(), cu->GetClassDefIndex());
David Brazdildee58d62016-04-07 09:54:26 +0000588}
589
590// Returns true if `block` has only one successor which starts at the next
591// dex_pc after `instruction` at `dex_pc`.
592static bool IsFallthroughInstruction(const Instruction& instruction,
593 uint32_t dex_pc,
594 HBasicBlock* block) {
595 uint32_t next_dex_pc = dex_pc + instruction.SizeInCodeUnits();
596 return block->GetSingleSuccessor()->GetDexPc() == next_dex_pc;
597}
598
599void HInstructionBuilder::BuildSwitch(const Instruction& instruction, uint32_t dex_pc) {
600 HInstruction* value = LoadLocal(instruction.VRegA(), Primitive::kPrimInt);
601 DexSwitchTable table(instruction, dex_pc);
602
603 if (table.GetNumEntries() == 0) {
604 // Empty Switch. Code falls through to the next block.
605 DCHECK(IsFallthroughInstruction(instruction, dex_pc, current_block_));
606 AppendInstruction(new (arena_) HGoto(dex_pc));
607 } else if (table.ShouldBuildDecisionTree()) {
608 for (DexSwitchTableIterator it(table); !it.Done(); it.Advance()) {
609 HInstruction* case_value = graph_->GetIntConstant(it.CurrentKey(), dex_pc);
610 HEqual* comparison = new (arena_) HEqual(value, case_value, dex_pc);
611 AppendInstruction(comparison);
612 AppendInstruction(new (arena_) HIf(comparison, dex_pc));
613
614 if (!it.IsLast()) {
615 current_block_ = FindBlockStartingAt(it.GetDexPcForCurrentIndex());
616 }
617 }
618 } else {
619 AppendInstruction(
620 new (arena_) HPackedSwitch(table.GetEntryAt(0), table.GetNumEntries(), value, dex_pc));
621 }
622
623 current_block_ = nullptr;
624}
625
626void HInstructionBuilder::BuildReturn(const Instruction& instruction,
627 Primitive::Type type,
628 uint32_t dex_pc) {
629 if (type == Primitive::kPrimVoid) {
630 if (graph_->ShouldGenerateConstructorBarrier()) {
631 // The compilation unit is null during testing.
632 if (dex_compilation_unit_ != nullptr) {
Mathieu Chartierc4ae9162016-04-07 13:19:19 -0700633 DCHECK(RequiresConstructorBarrier(dex_compilation_unit_, compiler_driver_))
David Brazdildee58d62016-04-07 09:54:26 +0000634 << "Inconsistent use of ShouldGenerateConstructorBarrier. Should not generate a barrier.";
635 }
636 AppendInstruction(new (arena_) HMemoryBarrier(kStoreStore, dex_pc));
637 }
638 AppendInstruction(new (arena_) HReturnVoid(dex_pc));
639 } else {
640 HInstruction* value = LoadLocal(instruction.VRegA(), type);
641 AppendInstruction(new (arena_) HReturn(value, dex_pc));
642 }
643 current_block_ = nullptr;
644}
645
646static InvokeType GetInvokeTypeFromOpCode(Instruction::Code opcode) {
647 switch (opcode) {
648 case Instruction::INVOKE_STATIC:
649 case Instruction::INVOKE_STATIC_RANGE:
650 return kStatic;
651 case Instruction::INVOKE_DIRECT:
652 case Instruction::INVOKE_DIRECT_RANGE:
653 return kDirect;
654 case Instruction::INVOKE_VIRTUAL:
655 case Instruction::INVOKE_VIRTUAL_QUICK:
656 case Instruction::INVOKE_VIRTUAL_RANGE:
657 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK:
658 return kVirtual;
659 case Instruction::INVOKE_INTERFACE:
660 case Instruction::INVOKE_INTERFACE_RANGE:
661 return kInterface;
662 case Instruction::INVOKE_SUPER_RANGE:
663 case Instruction::INVOKE_SUPER:
664 return kSuper;
665 default:
666 LOG(FATAL) << "Unexpected invoke opcode: " << opcode;
667 UNREACHABLE();
668 }
669}
670
671ArtMethod* HInstructionBuilder::ResolveMethod(uint16_t method_idx, InvokeType invoke_type) {
672 ScopedObjectAccess soa(Thread::Current());
673 StackHandleScope<3> hs(soa.Self());
674
675 ClassLinker* class_linker = dex_compilation_unit_->GetClassLinker();
676 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
677 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
678 Handle<mirror::Class> compiling_class(hs.NewHandle(GetCompilingClass()));
Nicolas Geoffray393fdb82016-04-25 14:58:06 +0100679 // We fetch the referenced class eagerly (that is, the class pointed by in the MethodId
680 // at method_idx), as `CanAccessResolvedMethod` expects it be be in the dex cache.
681 Handle<mirror::Class> methods_class(hs.NewHandle(class_linker->ResolveReferencedClassOfMethod(
682 method_idx, dex_compilation_unit_->GetDexCache(), class_loader)));
683
684 if (UNLIKELY(methods_class.Get() == nullptr)) {
685 // Clean up any exception left by type resolution.
686 soa.Self()->ClearException();
687 return nullptr;
688 }
David Brazdildee58d62016-04-07 09:54:26 +0000689
690 ArtMethod* resolved_method = class_linker->ResolveMethod<ClassLinker::kForceICCECheck>(
691 *dex_compilation_unit_->GetDexFile(),
692 method_idx,
693 dex_compilation_unit_->GetDexCache(),
694 class_loader,
695 /* referrer */ nullptr,
696 invoke_type);
697
698 if (UNLIKELY(resolved_method == nullptr)) {
699 // Clean up any exception left by type resolution.
700 soa.Self()->ClearException();
701 return nullptr;
702 }
703
704 // Check access. The class linker has a fast path for looking into the dex cache
705 // and does not check the access if it hits it.
706 if (compiling_class.Get() == nullptr) {
707 if (!resolved_method->IsPublic()) {
708 return nullptr;
709 }
710 } else if (!compiling_class->CanAccessResolvedMethod(resolved_method->GetDeclaringClass(),
711 resolved_method,
712 dex_compilation_unit_->GetDexCache().Get(),
713 method_idx)) {
714 return nullptr;
715 }
716
717 // We have to special case the invoke-super case, as ClassLinker::ResolveMethod does not.
718 // We need to look at the referrer's super class vtable. We need to do this to know if we need to
719 // make this an invoke-unresolved to handle cross-dex invokes or abstract super methods, both of
720 // which require runtime handling.
721 if (invoke_type == kSuper) {
722 if (compiling_class.Get() == nullptr) {
723 // We could not determine the method's class we need to wait until runtime.
724 DCHECK(Runtime::Current()->IsAotCompiler());
725 return nullptr;
726 }
Aart Bikf663e342016-04-04 17:28:59 -0700727 if (!methods_class->IsAssignableFrom(compiling_class.Get())) {
728 // We cannot statically determine the target method. The runtime will throw a
729 // NoSuchMethodError on this one.
730 return nullptr;
731 }
Nicolas Geoffray393fdb82016-04-25 14:58:06 +0100732 ArtMethod* actual_method;
733 if (methods_class->IsInterface()) {
734 actual_method = methods_class->FindVirtualMethodForInterfaceSuper(
735 resolved_method, class_linker->GetImagePointerSize());
David Brazdildee58d62016-04-07 09:54:26 +0000736 } else {
Nicolas Geoffray393fdb82016-04-25 14:58:06 +0100737 uint16_t vtable_index = resolved_method->GetMethodIndex();
738 actual_method = compiling_class->GetSuperClass()->GetVTableEntry(
739 vtable_index, class_linker->GetImagePointerSize());
David Brazdildee58d62016-04-07 09:54:26 +0000740 }
Nicolas Geoffray393fdb82016-04-25 14:58:06 +0100741 if (actual_method != resolved_method &&
742 !IsSameDexFile(*actual_method->GetDexFile(), *dex_compilation_unit_->GetDexFile())) {
743 // The back-end code generator relies on this check in order to ensure that it will not
744 // attempt to read the dex_cache with a dex_method_index that is not from the correct
745 // dex_file. If we didn't do this check then the dex_method_index will not be updated in the
746 // builder, which means that the code-generator (and compiler driver during sharpening and
747 // inliner, maybe) might invoke an incorrect method.
748 // TODO: The actual method could still be referenced in the current dex file, so we
749 // could try locating it.
750 // TODO: Remove the dex_file restriction.
751 return nullptr;
752 }
753 if (!actual_method->IsInvokable()) {
754 // Fail if the actual method cannot be invoked. Otherwise, the runtime resolution stub
755 // could resolve the callee to the wrong method.
756 return nullptr;
757 }
758 resolved_method = actual_method;
David Brazdildee58d62016-04-07 09:54:26 +0000759 }
760
761 // Check for incompatible class changes. The class linker has a fast path for
762 // looking into the dex cache and does not check incompatible class changes if it hits it.
763 if (resolved_method->CheckIncompatibleClassChange(invoke_type)) {
764 return nullptr;
765 }
766
767 return resolved_method;
768}
769
770bool HInstructionBuilder::BuildInvoke(const Instruction& instruction,
771 uint32_t dex_pc,
772 uint32_t method_idx,
773 uint32_t number_of_vreg_arguments,
774 bool is_range,
775 uint32_t* args,
776 uint32_t register_index) {
777 InvokeType invoke_type = GetInvokeTypeFromOpCode(instruction.Opcode());
778 const char* descriptor = dex_file_->GetMethodShorty(method_idx);
779 Primitive::Type return_type = Primitive::GetType(descriptor[0]);
780
781 // Remove the return type from the 'proto'.
782 size_t number_of_arguments = strlen(descriptor) - 1;
783 if (invoke_type != kStatic) { // instance call
784 // One extra argument for 'this'.
785 number_of_arguments++;
786 }
787
David Brazdildee58d62016-04-07 09:54:26 +0000788 // Special handling for string init.
789 int32_t string_init_offset = 0;
790 bool is_string_init = compiler_driver_->IsStringInit(method_idx,
791 dex_file_,
792 &string_init_offset);
793 // Replace calls to String.<init> with StringFactory.
794 if (is_string_init) {
795 HInvokeStaticOrDirect::DispatchInfo dispatch_info = {
796 HInvokeStaticOrDirect::MethodLoadKind::kStringInit,
797 HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod,
798 dchecked_integral_cast<uint64_t>(string_init_offset),
799 0U
800 };
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100801 MethodReference target_method(dex_file_, method_idx);
David Brazdildee58d62016-04-07 09:54:26 +0000802 HInvoke* invoke = new (arena_) HInvokeStaticOrDirect(
803 arena_,
804 number_of_arguments - 1,
805 Primitive::kPrimNot /*return_type */,
806 dex_pc,
807 method_idx,
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100808 nullptr,
David Brazdildee58d62016-04-07 09:54:26 +0000809 dispatch_info,
810 invoke_type,
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100811 target_method,
David Brazdildee58d62016-04-07 09:54:26 +0000812 HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit);
813 return HandleStringInit(invoke,
814 number_of_vreg_arguments,
815 args,
816 register_index,
817 is_range,
818 descriptor);
819 }
820
821 ArtMethod* resolved_method = ResolveMethod(method_idx, invoke_type);
822
823 if (UNLIKELY(resolved_method == nullptr)) {
824 MaybeRecordStat(MethodCompilationStat::kUnresolvedMethod);
825 HInvoke* invoke = new (arena_) HInvokeUnresolved(arena_,
826 number_of_arguments,
827 return_type,
828 dex_pc,
829 method_idx,
830 invoke_type);
831 return HandleInvoke(invoke,
832 number_of_vreg_arguments,
833 args,
834 register_index,
835 is_range,
836 descriptor,
Aart Bik296fbb42016-06-07 13:49:12 -0700837 nullptr, /* clinit_check */
838 true /* is_unresolved */);
David Brazdildee58d62016-04-07 09:54:26 +0000839 }
840
841 // Potential class initialization check, in the case of a static method call.
842 HClinitCheck* clinit_check = nullptr;
843 HInvoke* invoke = nullptr;
844 if (invoke_type == kDirect || invoke_type == kStatic || invoke_type == kSuper) {
845 // By default, consider that the called method implicitly requires
846 // an initialization check of its declaring method.
847 HInvokeStaticOrDirect::ClinitCheckRequirement clinit_check_requirement
848 = HInvokeStaticOrDirect::ClinitCheckRequirement::kImplicit;
849 ScopedObjectAccess soa(Thread::Current());
850 if (invoke_type == kStatic) {
851 clinit_check = ProcessClinitCheckForInvoke(
852 dex_pc, resolved_method, method_idx, &clinit_check_requirement);
853 } else if (invoke_type == kSuper) {
854 if (IsSameDexFile(*resolved_method->GetDexFile(), *dex_compilation_unit_->GetDexFile())) {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100855 // Update the method index to the one resolved. Note that this may be a no-op if
David Brazdildee58d62016-04-07 09:54:26 +0000856 // we resolved to the method referenced by the instruction.
857 method_idx = resolved_method->GetDexMethodIndex();
David Brazdildee58d62016-04-07 09:54:26 +0000858 }
859 }
860
861 HInvokeStaticOrDirect::DispatchInfo dispatch_info = {
862 HInvokeStaticOrDirect::MethodLoadKind::kDexCacheViaMethod,
863 HInvokeStaticOrDirect::CodePtrLocation::kCallArtMethod,
864 0u,
865 0U
866 };
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100867 MethodReference target_method(resolved_method->GetDexFile(),
868 resolved_method->GetDexMethodIndex());
David Brazdildee58d62016-04-07 09:54:26 +0000869 invoke = new (arena_) HInvokeStaticOrDirect(arena_,
870 number_of_arguments,
871 return_type,
872 dex_pc,
873 method_idx,
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100874 resolved_method,
David Brazdildee58d62016-04-07 09:54:26 +0000875 dispatch_info,
876 invoke_type,
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100877 target_method,
David Brazdildee58d62016-04-07 09:54:26 +0000878 clinit_check_requirement);
879 } else if (invoke_type == kVirtual) {
880 ScopedObjectAccess soa(Thread::Current()); // Needed for the method index
881 invoke = new (arena_) HInvokeVirtual(arena_,
882 number_of_arguments,
883 return_type,
884 dex_pc,
885 method_idx,
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100886 resolved_method,
David Brazdildee58d62016-04-07 09:54:26 +0000887 resolved_method->GetMethodIndex());
888 } else {
889 DCHECK_EQ(invoke_type, kInterface);
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100890 ScopedObjectAccess soa(Thread::Current()); // Needed for the IMT index.
David Brazdildee58d62016-04-07 09:54:26 +0000891 invoke = new (arena_) HInvokeInterface(arena_,
892 number_of_arguments,
893 return_type,
894 dex_pc,
895 method_idx,
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100896 resolved_method,
Matthew Gharrity465ecc82016-07-19 21:32:52 +0000897 resolved_method->GetImtIndex());
David Brazdildee58d62016-04-07 09:54:26 +0000898 }
899
900 return HandleInvoke(invoke,
901 number_of_vreg_arguments,
902 args,
903 register_index,
904 is_range,
905 descriptor,
Aart Bik296fbb42016-06-07 13:49:12 -0700906 clinit_check,
907 false /* is_unresolved */);
David Brazdildee58d62016-04-07 09:54:26 +0000908}
909
910bool HInstructionBuilder::BuildNewInstance(uint16_t type_index, uint32_t dex_pc) {
Vladimir Marko3cd50df2016-04-13 19:29:26 +0100911 ScopedObjectAccess soa(Thread::Current());
912 StackHandleScope<1> hs(soa.Self());
913 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
914 Handle<mirror::Class> resolved_class(hs.NewHandle(dex_cache->GetResolvedType(type_index)));
915 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
916 Handle<mirror::DexCache> outer_dex_cache = outer_compilation_unit_->GetDexCache();
917
David Brazdildee58d62016-04-07 09:54:26 +0000918 bool finalizable;
Mingyao Yang062157f2016-03-02 10:15:36 -0800919 bool needs_access_check = NeedsAccessCheck(type_index, dex_cache, &finalizable);
David Brazdildee58d62016-04-07 09:54:26 +0000920
921 // Only the non-resolved entrypoint handles the finalizable class case. If we
922 // need access checks, then we haven't resolved the method and the class may
923 // again be finalizable.
Mingyao Yang062157f2016-03-02 10:15:36 -0800924 QuickEntrypointEnum entrypoint = (finalizable || needs_access_check)
David Brazdildee58d62016-04-07 09:54:26 +0000925 ? kQuickAllocObject
926 : kQuickAllocObjectInitialized;
927
David Brazdildee58d62016-04-07 09:54:26 +0000928 if (outer_dex_cache.Get() != dex_cache.Get()) {
929 // We currently do not support inlining allocations across dex files.
930 return false;
931 }
932
933 HLoadClass* load_class = new (arena_) HLoadClass(
934 graph_->GetCurrentMethod(),
935 type_index,
936 outer_dex_file,
937 IsOutermostCompilingClass(type_index),
938 dex_pc,
Mingyao Yang062157f2016-03-02 10:15:36 -0800939 needs_access_check,
Mathieu Chartier31b12e32016-09-02 17:11:57 -0700940 /* is_in_dex_cache */ false,
941 /* is_in_boot_image */ false);
David Brazdildee58d62016-04-07 09:54:26 +0000942
943 AppendInstruction(load_class);
944 HInstruction* cls = load_class;
945 if (!IsInitialized(resolved_class)) {
946 cls = new (arena_) HClinitCheck(load_class, dex_pc);
947 AppendInstruction(cls);
948 }
949
950 AppendInstruction(new (arena_) HNewInstance(
951 cls,
952 graph_->GetCurrentMethod(),
953 dex_pc,
954 type_index,
955 *dex_compilation_unit_->GetDexFile(),
Mingyao Yang062157f2016-03-02 10:15:36 -0800956 needs_access_check,
David Brazdildee58d62016-04-07 09:54:26 +0000957 finalizable,
958 entrypoint));
959 return true;
960}
961
962static bool IsSubClass(mirror::Class* to_test, mirror::Class* super_class)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700963 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdildee58d62016-04-07 09:54:26 +0000964 return to_test != nullptr && !to_test->IsInterface() && to_test->IsSubClass(super_class);
965}
966
967bool HInstructionBuilder::IsInitialized(Handle<mirror::Class> cls) const {
968 if (cls.Get() == nullptr) {
969 return false;
970 }
971
972 // `CanAssumeClassIsLoaded` will return true if we're JITting, or will
973 // check whether the class is in an image for the AOT compilation.
974 if (cls->IsInitialized() &&
975 compiler_driver_->CanAssumeClassIsLoaded(cls.Get())) {
976 return true;
977 }
978
979 if (IsSubClass(GetOutermostCompilingClass(), cls.Get())) {
980 return true;
981 }
982
983 // TODO: We should walk over the inlined methods, but we don't pass
984 // that information to the builder.
985 if (IsSubClass(GetCompilingClass(), cls.Get())) {
986 return true;
987 }
988
989 return false;
990}
991
992HClinitCheck* HInstructionBuilder::ProcessClinitCheckForInvoke(
993 uint32_t dex_pc,
994 ArtMethod* resolved_method,
995 uint32_t method_idx,
996 HInvokeStaticOrDirect::ClinitCheckRequirement* clinit_check_requirement) {
997 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
998 Thread* self = Thread::Current();
Vladimir Marko3cd50df2016-04-13 19:29:26 +0100999 StackHandleScope<2> hs(self);
1000 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
1001 Handle<mirror::DexCache> outer_dex_cache = outer_compilation_unit_->GetDexCache();
David Brazdildee58d62016-04-07 09:54:26 +00001002 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
1003 Handle<mirror::Class> resolved_method_class(hs.NewHandle(resolved_method->GetDeclaringClass()));
1004
1005 // The index at which the method's class is stored in the DexCache's type array.
1006 uint32_t storage_index = DexFile::kDexNoIndex;
1007 bool is_outer_class = (resolved_method->GetDeclaringClass() == outer_class.Get());
1008 if (is_outer_class) {
1009 storage_index = outer_class->GetDexTypeIndex();
1010 } else if (outer_dex_cache.Get() == dex_cache.Get()) {
1011 // Get `storage_index` from IsClassOfStaticMethodAvailableToReferrer.
1012 compiler_driver_->IsClassOfStaticMethodAvailableToReferrer(outer_dex_cache.Get(),
1013 GetCompilingClass(),
1014 resolved_method,
1015 method_idx,
1016 &storage_index);
1017 }
1018
1019 HClinitCheck* clinit_check = nullptr;
1020
1021 if (IsInitialized(resolved_method_class)) {
1022 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kNone;
1023 } else if (storage_index != DexFile::kDexNoIndex) {
1024 *clinit_check_requirement = HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit;
1025 HLoadClass* load_class = new (arena_) HLoadClass(
1026 graph_->GetCurrentMethod(),
1027 storage_index,
1028 outer_dex_file,
1029 is_outer_class,
1030 dex_pc,
1031 /*needs_access_check*/ false,
Mathieu Chartier31b12e32016-09-02 17:11:57 -07001032 /* is_in_dex_cache */ false,
1033 /* is_in_boot_image */ false);
David Brazdildee58d62016-04-07 09:54:26 +00001034 AppendInstruction(load_class);
1035 clinit_check = new (arena_) HClinitCheck(load_class, dex_pc);
1036 AppendInstruction(clinit_check);
1037 }
1038 return clinit_check;
1039}
1040
1041bool HInstructionBuilder::SetupInvokeArguments(HInvoke* invoke,
1042 uint32_t number_of_vreg_arguments,
1043 uint32_t* args,
1044 uint32_t register_index,
1045 bool is_range,
1046 const char* descriptor,
1047 size_t start_index,
1048 size_t* argument_index) {
1049 uint32_t descriptor_index = 1; // Skip the return type.
1050
1051 for (size_t i = start_index;
1052 // Make sure we don't go over the expected arguments or over the number of
1053 // dex registers given. If the instruction was seen as dead by the verifier,
1054 // it hasn't been properly checked.
1055 (i < number_of_vreg_arguments) && (*argument_index < invoke->GetNumberOfArguments());
1056 i++, (*argument_index)++) {
1057 Primitive::Type type = Primitive::GetType(descriptor[descriptor_index++]);
1058 bool is_wide = (type == Primitive::kPrimLong) || (type == Primitive::kPrimDouble);
1059 if (!is_range
1060 && is_wide
1061 && ((i + 1 == number_of_vreg_arguments) || (args[i] + 1 != args[i + 1]))) {
1062 // Longs and doubles should be in pairs, that is, sequential registers. The verifier should
1063 // reject any class where this is violated. However, the verifier only does these checks
1064 // on non trivially dead instructions, so we just bailout the compilation.
1065 VLOG(compiler) << "Did not compile "
1066 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
1067 << " because of non-sequential dex register pair in wide argument";
1068 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
1069 return false;
1070 }
1071 HInstruction* arg = LoadLocal(is_range ? register_index + i : args[i], type);
1072 invoke->SetArgumentAt(*argument_index, arg);
1073 if (is_wide) {
1074 i++;
1075 }
1076 }
1077
1078 if (*argument_index != invoke->GetNumberOfArguments()) {
1079 VLOG(compiler) << "Did not compile "
1080 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
1081 << " because of wrong number of arguments in invoke instruction";
1082 MaybeRecordStat(MethodCompilationStat::kNotCompiledMalformedOpcode);
1083 return false;
1084 }
1085
1086 if (invoke->IsInvokeStaticOrDirect() &&
1087 HInvokeStaticOrDirect::NeedsCurrentMethodInput(
1088 invoke->AsInvokeStaticOrDirect()->GetMethodLoadKind())) {
1089 invoke->SetArgumentAt(*argument_index, graph_->GetCurrentMethod());
1090 (*argument_index)++;
1091 }
1092
1093 return true;
1094}
1095
1096bool HInstructionBuilder::HandleInvoke(HInvoke* invoke,
1097 uint32_t number_of_vreg_arguments,
1098 uint32_t* args,
1099 uint32_t register_index,
1100 bool is_range,
1101 const char* descriptor,
Aart Bik296fbb42016-06-07 13:49:12 -07001102 HClinitCheck* clinit_check,
1103 bool is_unresolved) {
David Brazdildee58d62016-04-07 09:54:26 +00001104 DCHECK(!invoke->IsInvokeStaticOrDirect() || !invoke->AsInvokeStaticOrDirect()->IsStringInit());
1105
1106 size_t start_index = 0;
1107 size_t argument_index = 0;
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001108 if (invoke->GetInvokeType() != InvokeType::kStatic) { // Instance call.
Aart Bik296fbb42016-06-07 13:49:12 -07001109 uint32_t obj_reg = is_range ? register_index : args[0];
1110 HInstruction* arg = is_unresolved
1111 ? LoadLocal(obj_reg, Primitive::kPrimNot)
1112 : LoadNullCheckedLocal(obj_reg, invoke->GetDexPc());
David Brazdilc120bbe2016-04-22 16:57:00 +01001113 invoke->SetArgumentAt(0, arg);
David Brazdildee58d62016-04-07 09:54:26 +00001114 start_index = 1;
1115 argument_index = 1;
1116 }
1117
1118 if (!SetupInvokeArguments(invoke,
1119 number_of_vreg_arguments,
1120 args,
1121 register_index,
1122 is_range,
1123 descriptor,
1124 start_index,
1125 &argument_index)) {
1126 return false;
1127 }
1128
1129 if (clinit_check != nullptr) {
1130 // Add the class initialization check as last input of `invoke`.
1131 DCHECK(invoke->IsInvokeStaticOrDirect());
1132 DCHECK(invoke->AsInvokeStaticOrDirect()->GetClinitCheckRequirement()
1133 == HInvokeStaticOrDirect::ClinitCheckRequirement::kExplicit);
1134 invoke->SetArgumentAt(argument_index, clinit_check);
1135 argument_index++;
1136 }
1137
1138 AppendInstruction(invoke);
1139 latest_result_ = invoke;
1140
1141 return true;
1142}
1143
1144bool HInstructionBuilder::HandleStringInit(HInvoke* invoke,
1145 uint32_t number_of_vreg_arguments,
1146 uint32_t* args,
1147 uint32_t register_index,
1148 bool is_range,
1149 const char* descriptor) {
1150 DCHECK(invoke->IsInvokeStaticOrDirect());
1151 DCHECK(invoke->AsInvokeStaticOrDirect()->IsStringInit());
1152
1153 size_t start_index = 1;
1154 size_t argument_index = 0;
1155 if (!SetupInvokeArguments(invoke,
1156 number_of_vreg_arguments,
1157 args,
1158 register_index,
1159 is_range,
1160 descriptor,
1161 start_index,
1162 &argument_index)) {
1163 return false;
1164 }
1165
1166 AppendInstruction(invoke);
1167
1168 // This is a StringFactory call, not an actual String constructor. Its result
1169 // replaces the empty String pre-allocated by NewInstance.
1170 uint32_t orig_this_reg = is_range ? register_index : args[0];
1171 HInstruction* arg_this = LoadLocal(orig_this_reg, Primitive::kPrimNot);
1172
1173 // Replacing the NewInstance might render it redundant. Keep a list of these
1174 // to be visited once it is clear whether it is has remaining uses.
1175 if (arg_this->IsNewInstance()) {
1176 ssa_builder_->AddUninitializedString(arg_this->AsNewInstance());
1177 } else {
1178 DCHECK(arg_this->IsPhi());
1179 // NewInstance is not the direct input of the StringFactory call. It might
1180 // be redundant but optimizing this case is not worth the effort.
1181 }
1182
1183 // Walk over all vregs and replace any occurrence of `arg_this` with `invoke`.
1184 for (size_t vreg = 0, e = current_locals_->size(); vreg < e; ++vreg) {
1185 if ((*current_locals_)[vreg] == arg_this) {
1186 (*current_locals_)[vreg] = invoke;
1187 }
1188 }
1189
1190 return true;
1191}
1192
1193static Primitive::Type GetFieldAccessType(const DexFile& dex_file, uint16_t field_index) {
1194 const DexFile::FieldId& field_id = dex_file.GetFieldId(field_index);
1195 const char* type = dex_file.GetFieldTypeDescriptor(field_id);
1196 return Primitive::GetType(type[0]);
1197}
1198
1199bool HInstructionBuilder::BuildInstanceFieldAccess(const Instruction& instruction,
1200 uint32_t dex_pc,
1201 bool is_put) {
1202 uint32_t source_or_dest_reg = instruction.VRegA_22c();
1203 uint32_t obj_reg = instruction.VRegB_22c();
1204 uint16_t field_index;
1205 if (instruction.IsQuickened()) {
1206 if (!CanDecodeQuickenedInfo()) {
1207 return false;
1208 }
1209 field_index = LookupQuickenedInfo(dex_pc);
1210 } else {
1211 field_index = instruction.VRegC_22c();
1212 }
1213
1214 ScopedObjectAccess soa(Thread::Current());
1215 ArtField* resolved_field =
1216 compiler_driver_->ComputeInstanceFieldInfo(field_index, dex_compilation_unit_, is_put, soa);
1217
1218
Aart Bik14154132016-06-02 17:53:58 -07001219 // Generate an explicit null check on the reference, unless the field access
1220 // is unresolved. In that case, we rely on the runtime to perform various
1221 // checks first, followed by a null check.
1222 HInstruction* object = (resolved_field == nullptr)
1223 ? LoadLocal(obj_reg, Primitive::kPrimNot)
1224 : LoadNullCheckedLocal(obj_reg, dex_pc);
David Brazdildee58d62016-04-07 09:54:26 +00001225
1226 Primitive::Type field_type = (resolved_field == nullptr)
1227 ? GetFieldAccessType(*dex_file_, field_index)
1228 : resolved_field->GetTypeAsPrimitiveType();
1229 if (is_put) {
1230 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
1231 HInstruction* field_set = nullptr;
1232 if (resolved_field == nullptr) {
1233 MaybeRecordStat(MethodCompilationStat::kUnresolvedField);
David Brazdilc120bbe2016-04-22 16:57:00 +01001234 field_set = new (arena_) HUnresolvedInstanceFieldSet(object,
David Brazdildee58d62016-04-07 09:54:26 +00001235 value,
1236 field_type,
1237 field_index,
1238 dex_pc);
1239 } else {
1240 uint16_t class_def_index = resolved_field->GetDeclaringClass()->GetDexClassDefIndex();
David Brazdilc120bbe2016-04-22 16:57:00 +01001241 field_set = new (arena_) HInstanceFieldSet(object,
David Brazdildee58d62016-04-07 09:54:26 +00001242 value,
1243 field_type,
1244 resolved_field->GetOffset(),
1245 resolved_field->IsVolatile(),
1246 field_index,
1247 class_def_index,
1248 *dex_file_,
1249 dex_compilation_unit_->GetDexCache(),
1250 dex_pc);
1251 }
1252 AppendInstruction(field_set);
1253 } else {
1254 HInstruction* field_get = nullptr;
1255 if (resolved_field == nullptr) {
1256 MaybeRecordStat(MethodCompilationStat::kUnresolvedField);
David Brazdilc120bbe2016-04-22 16:57:00 +01001257 field_get = new (arena_) HUnresolvedInstanceFieldGet(object,
David Brazdildee58d62016-04-07 09:54:26 +00001258 field_type,
1259 field_index,
1260 dex_pc);
1261 } else {
1262 uint16_t class_def_index = resolved_field->GetDeclaringClass()->GetDexClassDefIndex();
David Brazdilc120bbe2016-04-22 16:57:00 +01001263 field_get = new (arena_) HInstanceFieldGet(object,
David Brazdildee58d62016-04-07 09:54:26 +00001264 field_type,
1265 resolved_field->GetOffset(),
1266 resolved_field->IsVolatile(),
1267 field_index,
1268 class_def_index,
1269 *dex_file_,
1270 dex_compilation_unit_->GetDexCache(),
1271 dex_pc);
1272 }
1273 AppendInstruction(field_get);
1274 UpdateLocal(source_or_dest_reg, field_get);
1275 }
1276
1277 return true;
1278}
1279
1280static mirror::Class* GetClassFrom(CompilerDriver* driver,
1281 const DexCompilationUnit& compilation_unit) {
1282 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001283 StackHandleScope<1> hs(soa.Self());
David Brazdildee58d62016-04-07 09:54:26 +00001284 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1285 soa.Decode<mirror::ClassLoader*>(compilation_unit.GetClassLoader())));
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001286 Handle<mirror::DexCache> dex_cache = compilation_unit.GetDexCache();
David Brazdildee58d62016-04-07 09:54:26 +00001287
1288 return driver->ResolveCompilingMethodsClass(soa, dex_cache, class_loader, &compilation_unit);
1289}
1290
1291mirror::Class* HInstructionBuilder::GetOutermostCompilingClass() const {
1292 return GetClassFrom(compiler_driver_, *outer_compilation_unit_);
1293}
1294
1295mirror::Class* HInstructionBuilder::GetCompilingClass() const {
1296 return GetClassFrom(compiler_driver_, *dex_compilation_unit_);
1297}
1298
1299bool HInstructionBuilder::IsOutermostCompilingClass(uint16_t type_index) const {
1300 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001301 StackHandleScope<3> hs(soa.Self());
1302 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
David Brazdildee58d62016-04-07 09:54:26 +00001303 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1304 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
1305 Handle<mirror::Class> cls(hs.NewHandle(compiler_driver_->ResolveClass(
1306 soa, dex_cache, class_loader, type_index, dex_compilation_unit_)));
1307 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
1308
1309 // GetOutermostCompilingClass returns null when the class is unresolved
1310 // (e.g. if it derives from an unresolved class). This is bogus knowing that
1311 // we are compiling it.
1312 // When this happens we cannot establish a direct relation between the current
1313 // class and the outer class, so we return false.
1314 // (Note that this is only used for optimizing invokes and field accesses)
1315 return (cls.Get() != nullptr) && (outer_class.Get() == cls.Get());
1316}
1317
1318void HInstructionBuilder::BuildUnresolvedStaticFieldAccess(const Instruction& instruction,
1319 uint32_t dex_pc,
1320 bool is_put,
1321 Primitive::Type field_type) {
1322 uint32_t source_or_dest_reg = instruction.VRegA_21c();
1323 uint16_t field_index = instruction.VRegB_21c();
1324
1325 if (is_put) {
1326 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
1327 AppendInstruction(
1328 new (arena_) HUnresolvedStaticFieldSet(value, field_type, field_index, dex_pc));
1329 } else {
1330 AppendInstruction(new (arena_) HUnresolvedStaticFieldGet(field_type, field_index, dex_pc));
1331 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1332 }
1333}
1334
1335bool HInstructionBuilder::BuildStaticFieldAccess(const Instruction& instruction,
1336 uint32_t dex_pc,
1337 bool is_put) {
1338 uint32_t source_or_dest_reg = instruction.VRegA_21c();
1339 uint16_t field_index = instruction.VRegB_21c();
1340
1341 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001342 StackHandleScope<3> hs(soa.Self());
1343 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
David Brazdildee58d62016-04-07 09:54:26 +00001344 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1345 soa.Decode<mirror::ClassLoader*>(dex_compilation_unit_->GetClassLoader())));
1346 ArtField* resolved_field = compiler_driver_->ResolveField(
1347 soa, dex_cache, class_loader, dex_compilation_unit_, field_index, true);
1348
1349 if (resolved_field == nullptr) {
1350 MaybeRecordStat(MethodCompilationStat::kUnresolvedField);
1351 Primitive::Type field_type = GetFieldAccessType(*dex_file_, field_index);
1352 BuildUnresolvedStaticFieldAccess(instruction, dex_pc, is_put, field_type);
1353 return true;
1354 }
1355
1356 Primitive::Type field_type = resolved_field->GetTypeAsPrimitiveType();
1357 const DexFile& outer_dex_file = *outer_compilation_unit_->GetDexFile();
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001358 Handle<mirror::DexCache> outer_dex_cache = outer_compilation_unit_->GetDexCache();
David Brazdildee58d62016-04-07 09:54:26 +00001359 Handle<mirror::Class> outer_class(hs.NewHandle(GetOutermostCompilingClass()));
1360
1361 // The index at which the field's class is stored in the DexCache's type array.
1362 uint32_t storage_index;
1363 bool is_outer_class = (outer_class.Get() == resolved_field->GetDeclaringClass());
1364 if (is_outer_class) {
1365 storage_index = outer_class->GetDexTypeIndex();
1366 } else if (outer_dex_cache.Get() != dex_cache.Get()) {
1367 // The compiler driver cannot currently understand multiple dex caches involved. Just bailout.
1368 return false;
1369 } else {
1370 // TODO: This is rather expensive. Perf it and cache the results if needed.
1371 std::pair<bool, bool> pair = compiler_driver_->IsFastStaticField(
1372 outer_dex_cache.Get(),
1373 GetCompilingClass(),
1374 resolved_field,
1375 field_index,
1376 &storage_index);
1377 bool can_easily_access = is_put ? pair.second : pair.first;
1378 if (!can_easily_access) {
1379 MaybeRecordStat(MethodCompilationStat::kUnresolvedFieldNotAFastAccess);
1380 BuildUnresolvedStaticFieldAccess(instruction, dex_pc, is_put, field_type);
1381 return true;
1382 }
1383 }
1384
David Brazdildee58d62016-04-07 09:54:26 +00001385 HLoadClass* constant = new (arena_) HLoadClass(graph_->GetCurrentMethod(),
1386 storage_index,
1387 outer_dex_file,
1388 is_outer_class,
1389 dex_pc,
1390 /*needs_access_check*/ false,
Mathieu Chartier31b12e32016-09-02 17:11:57 -07001391 /* is_in_dex_cache */ false,
1392 /* is_in_boot_image */ false);
David Brazdildee58d62016-04-07 09:54:26 +00001393 AppendInstruction(constant);
1394
1395 HInstruction* cls = constant;
1396
1397 Handle<mirror::Class> klass(hs.NewHandle(resolved_field->GetDeclaringClass()));
1398 if (!IsInitialized(klass)) {
1399 cls = new (arena_) HClinitCheck(constant, dex_pc);
1400 AppendInstruction(cls);
1401 }
1402
1403 uint16_t class_def_index = klass->GetDexClassDefIndex();
1404 if (is_put) {
1405 // We need to keep the class alive before loading the value.
1406 HInstruction* value = LoadLocal(source_or_dest_reg, field_type);
1407 DCHECK_EQ(HPhi::ToPhiType(value->GetType()), HPhi::ToPhiType(field_type));
1408 AppendInstruction(new (arena_) HStaticFieldSet(cls,
1409 value,
1410 field_type,
1411 resolved_field->GetOffset(),
1412 resolved_field->IsVolatile(),
1413 field_index,
1414 class_def_index,
1415 *dex_file_,
1416 dex_cache_,
1417 dex_pc));
1418 } else {
1419 AppendInstruction(new (arena_) HStaticFieldGet(cls,
1420 field_type,
1421 resolved_field->GetOffset(),
1422 resolved_field->IsVolatile(),
1423 field_index,
1424 class_def_index,
1425 *dex_file_,
1426 dex_cache_,
1427 dex_pc));
1428 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1429 }
1430 return true;
1431}
1432
1433void HInstructionBuilder::BuildCheckedDivRem(uint16_t out_vreg,
1434 uint16_t first_vreg,
1435 int64_t second_vreg_or_constant,
1436 uint32_t dex_pc,
1437 Primitive::Type type,
1438 bool second_is_constant,
1439 bool isDiv) {
1440 DCHECK(type == Primitive::kPrimInt || type == Primitive::kPrimLong);
1441
1442 HInstruction* first = LoadLocal(first_vreg, type);
1443 HInstruction* second = nullptr;
1444 if (second_is_constant) {
1445 if (type == Primitive::kPrimInt) {
1446 second = graph_->GetIntConstant(second_vreg_or_constant, dex_pc);
1447 } else {
1448 second = graph_->GetLongConstant(second_vreg_or_constant, dex_pc);
1449 }
1450 } else {
1451 second = LoadLocal(second_vreg_or_constant, type);
1452 }
1453
1454 if (!second_is_constant
1455 || (type == Primitive::kPrimInt && second->AsIntConstant()->GetValue() == 0)
1456 || (type == Primitive::kPrimLong && second->AsLongConstant()->GetValue() == 0)) {
1457 second = new (arena_) HDivZeroCheck(second, dex_pc);
1458 AppendInstruction(second);
1459 }
1460
1461 if (isDiv) {
1462 AppendInstruction(new (arena_) HDiv(type, first, second, dex_pc));
1463 } else {
1464 AppendInstruction(new (arena_) HRem(type, first, second, dex_pc));
1465 }
1466 UpdateLocal(out_vreg, current_block_->GetLastInstruction());
1467}
1468
1469void HInstructionBuilder::BuildArrayAccess(const Instruction& instruction,
1470 uint32_t dex_pc,
1471 bool is_put,
1472 Primitive::Type anticipated_type) {
1473 uint8_t source_or_dest_reg = instruction.VRegA_23x();
1474 uint8_t array_reg = instruction.VRegB_23x();
1475 uint8_t index_reg = instruction.VRegC_23x();
1476
David Brazdilc120bbe2016-04-22 16:57:00 +01001477 HInstruction* object = LoadNullCheckedLocal(array_reg, dex_pc);
David Brazdildee58d62016-04-07 09:54:26 +00001478 HInstruction* length = new (arena_) HArrayLength(object, dex_pc);
1479 AppendInstruction(length);
1480 HInstruction* index = LoadLocal(index_reg, Primitive::kPrimInt);
1481 index = new (arena_) HBoundsCheck(index, length, dex_pc);
1482 AppendInstruction(index);
1483 if (is_put) {
1484 HInstruction* value = LoadLocal(source_or_dest_reg, anticipated_type);
1485 // TODO: Insert a type check node if the type is Object.
1486 HArraySet* aset = new (arena_) HArraySet(object, index, value, anticipated_type, dex_pc);
1487 ssa_builder_->MaybeAddAmbiguousArraySet(aset);
1488 AppendInstruction(aset);
1489 } else {
1490 HArrayGet* aget = new (arena_) HArrayGet(object, index, anticipated_type, dex_pc);
1491 ssa_builder_->MaybeAddAmbiguousArrayGet(aget);
1492 AppendInstruction(aget);
1493 UpdateLocal(source_or_dest_reg, current_block_->GetLastInstruction());
1494 }
1495 graph_->SetHasBoundsChecks(true);
1496}
1497
1498void HInstructionBuilder::BuildFilledNewArray(uint32_t dex_pc,
1499 uint32_t type_index,
1500 uint32_t number_of_vreg_arguments,
1501 bool is_range,
1502 uint32_t* args,
1503 uint32_t register_index) {
1504 HInstruction* length = graph_->GetIntConstant(number_of_vreg_arguments, dex_pc);
1505 bool finalizable;
1506 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index, &finalizable)
1507 ? kQuickAllocArrayWithAccessCheck
1508 : kQuickAllocArray;
1509 HInstruction* object = new (arena_) HNewArray(length,
1510 graph_->GetCurrentMethod(),
1511 dex_pc,
1512 type_index,
1513 *dex_compilation_unit_->GetDexFile(),
1514 entrypoint);
1515 AppendInstruction(object);
1516
1517 const char* descriptor = dex_file_->StringByTypeIdx(type_index);
1518 DCHECK_EQ(descriptor[0], '[') << descriptor;
1519 char primitive = descriptor[1];
1520 DCHECK(primitive == 'I'
1521 || primitive == 'L'
1522 || primitive == '[') << descriptor;
1523 bool is_reference_array = (primitive == 'L') || (primitive == '[');
1524 Primitive::Type type = is_reference_array ? Primitive::kPrimNot : Primitive::kPrimInt;
1525
1526 for (size_t i = 0; i < number_of_vreg_arguments; ++i) {
1527 HInstruction* value = LoadLocal(is_range ? register_index + i : args[i], type);
1528 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1529 HArraySet* aset = new (arena_) HArraySet(object, index, value, type, dex_pc);
1530 ssa_builder_->MaybeAddAmbiguousArraySet(aset);
1531 AppendInstruction(aset);
1532 }
1533 latest_result_ = object;
1534}
1535
1536template <typename T>
1537void HInstructionBuilder::BuildFillArrayData(HInstruction* object,
1538 const T* data,
1539 uint32_t element_count,
1540 Primitive::Type anticipated_type,
1541 uint32_t dex_pc) {
1542 for (uint32_t i = 0; i < element_count; ++i) {
1543 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1544 HInstruction* value = graph_->GetIntConstant(data[i], dex_pc);
1545 HArraySet* aset = new (arena_) HArraySet(object, index, value, anticipated_type, dex_pc);
1546 ssa_builder_->MaybeAddAmbiguousArraySet(aset);
1547 AppendInstruction(aset);
1548 }
1549}
1550
1551void HInstructionBuilder::BuildFillArrayData(const Instruction& instruction, uint32_t dex_pc) {
David Brazdilc120bbe2016-04-22 16:57:00 +01001552 HInstruction* array = LoadNullCheckedLocal(instruction.VRegA_31t(), dex_pc);
David Brazdildee58d62016-04-07 09:54:26 +00001553
1554 int32_t payload_offset = instruction.VRegB_31t() + dex_pc;
1555 const Instruction::ArrayDataPayload* payload =
1556 reinterpret_cast<const Instruction::ArrayDataPayload*>(code_item_.insns_ + payload_offset);
1557 const uint8_t* data = payload->data;
1558 uint32_t element_count = payload->element_count;
1559
Vladimir Markoc69fba22016-09-06 16:49:15 +01001560 if (element_count == 0u) {
1561 // For empty payload we emit only the null check above.
1562 return;
1563 }
1564
1565 HInstruction* length = new (arena_) HArrayLength(array, dex_pc);
1566 AppendInstruction(length);
1567
David Brazdildee58d62016-04-07 09:54:26 +00001568 // Implementation of this DEX instruction seems to be that the bounds check is
1569 // done before doing any stores.
1570 HInstruction* last_index = graph_->GetIntConstant(payload->element_count - 1, dex_pc);
1571 AppendInstruction(new (arena_) HBoundsCheck(last_index, length, dex_pc));
1572
1573 switch (payload->element_width) {
1574 case 1:
David Brazdilc120bbe2016-04-22 16:57:00 +01001575 BuildFillArrayData(array,
David Brazdildee58d62016-04-07 09:54:26 +00001576 reinterpret_cast<const int8_t*>(data),
1577 element_count,
1578 Primitive::kPrimByte,
1579 dex_pc);
1580 break;
1581 case 2:
David Brazdilc120bbe2016-04-22 16:57:00 +01001582 BuildFillArrayData(array,
David Brazdildee58d62016-04-07 09:54:26 +00001583 reinterpret_cast<const int16_t*>(data),
1584 element_count,
1585 Primitive::kPrimShort,
1586 dex_pc);
1587 break;
1588 case 4:
David Brazdilc120bbe2016-04-22 16:57:00 +01001589 BuildFillArrayData(array,
David Brazdildee58d62016-04-07 09:54:26 +00001590 reinterpret_cast<const int32_t*>(data),
1591 element_count,
1592 Primitive::kPrimInt,
1593 dex_pc);
1594 break;
1595 case 8:
David Brazdilc120bbe2016-04-22 16:57:00 +01001596 BuildFillWideArrayData(array,
David Brazdildee58d62016-04-07 09:54:26 +00001597 reinterpret_cast<const int64_t*>(data),
1598 element_count,
1599 dex_pc);
1600 break;
1601 default:
1602 LOG(FATAL) << "Unknown element width for " << payload->element_width;
1603 }
1604 graph_->SetHasBoundsChecks(true);
1605}
1606
1607void HInstructionBuilder::BuildFillWideArrayData(HInstruction* object,
1608 const int64_t* data,
1609 uint32_t element_count,
1610 uint32_t dex_pc) {
1611 for (uint32_t i = 0; i < element_count; ++i) {
1612 HInstruction* index = graph_->GetIntConstant(i, dex_pc);
1613 HInstruction* value = graph_->GetLongConstant(data[i], dex_pc);
1614 HArraySet* aset = new (arena_) HArraySet(object, index, value, Primitive::kPrimLong, dex_pc);
1615 ssa_builder_->MaybeAddAmbiguousArraySet(aset);
1616 AppendInstruction(aset);
1617 }
1618}
1619
1620static TypeCheckKind ComputeTypeCheckKind(Handle<mirror::Class> cls)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001621 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdildee58d62016-04-07 09:54:26 +00001622 if (cls.Get() == nullptr) {
1623 return TypeCheckKind::kUnresolvedCheck;
1624 } else if (cls->IsInterface()) {
1625 return TypeCheckKind::kInterfaceCheck;
1626 } else if (cls->IsArrayClass()) {
1627 if (cls->GetComponentType()->IsObjectClass()) {
1628 return TypeCheckKind::kArrayObjectCheck;
1629 } else if (cls->CannotBeAssignedFromOtherTypes()) {
1630 return TypeCheckKind::kExactCheck;
1631 } else {
1632 return TypeCheckKind::kArrayCheck;
1633 }
1634 } else if (cls->IsFinal()) {
1635 return TypeCheckKind::kExactCheck;
1636 } else if (cls->IsAbstract()) {
1637 return TypeCheckKind::kAbstractClassCheck;
1638 } else {
1639 return TypeCheckKind::kClassHierarchyCheck;
1640 }
1641}
1642
1643void HInstructionBuilder::BuildTypeCheck(const Instruction& instruction,
1644 uint8_t destination,
1645 uint8_t reference,
1646 uint16_t type_index,
1647 uint32_t dex_pc) {
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001648 ScopedObjectAccess soa(Thread::Current());
1649 StackHandleScope<1> hs(soa.Self());
1650 const DexFile& dex_file = *dex_compilation_unit_->GetDexFile();
1651 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
1652 Handle<mirror::Class> resolved_class(hs.NewHandle(dex_cache->GetResolvedType(type_index)));
1653
David Brazdildee58d62016-04-07 09:54:26 +00001654 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
1655 dex_compilation_unit_->GetDexMethodIndex(),
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001656 dex_cache,
1657 type_index);
David Brazdildee58d62016-04-07 09:54:26 +00001658
1659 HInstruction* object = LoadLocal(reference, Primitive::kPrimNot);
1660 HLoadClass* cls = new (arena_) HLoadClass(
1661 graph_->GetCurrentMethod(),
1662 type_index,
1663 dex_file,
1664 IsOutermostCompilingClass(type_index),
1665 dex_pc,
1666 !can_access,
Mathieu Chartier31b12e32016-09-02 17:11:57 -07001667 /* is_in_dex_cache */ false,
1668 /* is_in_boot_image */ false);
David Brazdildee58d62016-04-07 09:54:26 +00001669 AppendInstruction(cls);
1670
1671 TypeCheckKind check_kind = ComputeTypeCheckKind(resolved_class);
1672 if (instruction.Opcode() == Instruction::INSTANCE_OF) {
1673 AppendInstruction(new (arena_) HInstanceOf(object, cls, check_kind, dex_pc));
1674 UpdateLocal(destination, current_block_->GetLastInstruction());
1675 } else {
1676 DCHECK_EQ(instruction.Opcode(), Instruction::CHECK_CAST);
1677 // We emit a CheckCast followed by a BoundType. CheckCast is a statement
1678 // which may throw. If it succeeds BoundType sets the new type of `object`
1679 // for all subsequent uses.
1680 AppendInstruction(new (arena_) HCheckCast(object, cls, check_kind, dex_pc));
1681 AppendInstruction(new (arena_) HBoundType(object, dex_pc));
1682 UpdateLocal(reference, current_block_->GetLastInstruction());
1683 }
1684}
1685
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001686bool HInstructionBuilder::NeedsAccessCheck(uint32_t type_index,
1687 Handle<mirror::DexCache> dex_cache,
1688 bool* finalizable) const {
David Brazdildee58d62016-04-07 09:54:26 +00001689 return !compiler_driver_->CanAccessInstantiableTypeWithoutChecks(
Vladimir Marko3cd50df2016-04-13 19:29:26 +01001690 dex_compilation_unit_->GetDexMethodIndex(), dex_cache, type_index, finalizable);
1691}
1692
1693bool HInstructionBuilder::NeedsAccessCheck(uint32_t type_index, bool* finalizable) const {
1694 ScopedObjectAccess soa(Thread::Current());
1695 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
1696 return NeedsAccessCheck(type_index, dex_cache, finalizable);
David Brazdildee58d62016-04-07 09:54:26 +00001697}
1698
1699bool HInstructionBuilder::CanDecodeQuickenedInfo() const {
1700 return interpreter_metadata_ != nullptr;
1701}
1702
1703uint16_t HInstructionBuilder::LookupQuickenedInfo(uint32_t dex_pc) {
1704 DCHECK(interpreter_metadata_ != nullptr);
1705
1706 // First check if the info has already been decoded from `interpreter_metadata_`.
1707 auto it = skipped_interpreter_metadata_.find(dex_pc);
1708 if (it != skipped_interpreter_metadata_.end()) {
1709 // Remove the entry from the map and return the parsed info.
1710 uint16_t value_in_map = it->second;
1711 skipped_interpreter_metadata_.erase(it);
1712 return value_in_map;
1713 }
1714
1715 // Otherwise start parsing `interpreter_metadata_` until the slot for `dex_pc`
1716 // is found. Store skipped values in the `skipped_interpreter_metadata_` map.
1717 while (true) {
1718 uint32_t dex_pc_in_map = DecodeUnsignedLeb128(&interpreter_metadata_);
1719 uint16_t value_in_map = DecodeUnsignedLeb128(&interpreter_metadata_);
1720 DCHECK_LE(dex_pc_in_map, dex_pc);
1721
1722 if (dex_pc_in_map == dex_pc) {
1723 return value_in_map;
1724 } else {
1725 skipped_interpreter_metadata_.Put(dex_pc_in_map, value_in_map);
1726 }
1727 }
1728}
1729
1730bool HInstructionBuilder::ProcessDexInstruction(const Instruction& instruction, uint32_t dex_pc) {
1731 switch (instruction.Opcode()) {
1732 case Instruction::CONST_4: {
1733 int32_t register_index = instruction.VRegA();
1734 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_11n(), dex_pc);
1735 UpdateLocal(register_index, constant);
1736 break;
1737 }
1738
1739 case Instruction::CONST_16: {
1740 int32_t register_index = instruction.VRegA();
1741 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21s(), dex_pc);
1742 UpdateLocal(register_index, constant);
1743 break;
1744 }
1745
1746 case Instruction::CONST: {
1747 int32_t register_index = instruction.VRegA();
1748 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_31i(), dex_pc);
1749 UpdateLocal(register_index, constant);
1750 break;
1751 }
1752
1753 case Instruction::CONST_HIGH16: {
1754 int32_t register_index = instruction.VRegA();
1755 HIntConstant* constant = graph_->GetIntConstant(instruction.VRegB_21h() << 16, dex_pc);
1756 UpdateLocal(register_index, constant);
1757 break;
1758 }
1759
1760 case Instruction::CONST_WIDE_16: {
1761 int32_t register_index = instruction.VRegA();
1762 // Get 16 bits of constant value, sign extended to 64 bits.
1763 int64_t value = instruction.VRegB_21s();
1764 value <<= 48;
1765 value >>= 48;
1766 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1767 UpdateLocal(register_index, constant);
1768 break;
1769 }
1770
1771 case Instruction::CONST_WIDE_32: {
1772 int32_t register_index = instruction.VRegA();
1773 // Get 32 bits of constant value, sign extended to 64 bits.
1774 int64_t value = instruction.VRegB_31i();
1775 value <<= 32;
1776 value >>= 32;
1777 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1778 UpdateLocal(register_index, constant);
1779 break;
1780 }
1781
1782 case Instruction::CONST_WIDE: {
1783 int32_t register_index = instruction.VRegA();
1784 HLongConstant* constant = graph_->GetLongConstant(instruction.VRegB_51l(), dex_pc);
1785 UpdateLocal(register_index, constant);
1786 break;
1787 }
1788
1789 case Instruction::CONST_WIDE_HIGH16: {
1790 int32_t register_index = instruction.VRegA();
1791 int64_t value = static_cast<int64_t>(instruction.VRegB_21h()) << 48;
1792 HLongConstant* constant = graph_->GetLongConstant(value, dex_pc);
1793 UpdateLocal(register_index, constant);
1794 break;
1795 }
1796
1797 // Note that the SSA building will refine the types.
1798 case Instruction::MOVE:
1799 case Instruction::MOVE_FROM16:
1800 case Instruction::MOVE_16: {
1801 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimInt);
1802 UpdateLocal(instruction.VRegA(), value);
1803 break;
1804 }
1805
1806 // Note that the SSA building will refine the types.
1807 case Instruction::MOVE_WIDE:
1808 case Instruction::MOVE_WIDE_FROM16:
1809 case Instruction::MOVE_WIDE_16: {
1810 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimLong);
1811 UpdateLocal(instruction.VRegA(), value);
1812 break;
1813 }
1814
1815 case Instruction::MOVE_OBJECT:
1816 case Instruction::MOVE_OBJECT_16:
1817 case Instruction::MOVE_OBJECT_FROM16: {
1818 HInstruction* value = LoadLocal(instruction.VRegB(), Primitive::kPrimNot);
1819 UpdateLocal(instruction.VRegA(), value);
1820 break;
1821 }
1822
1823 case Instruction::RETURN_VOID_NO_BARRIER:
1824 case Instruction::RETURN_VOID: {
1825 BuildReturn(instruction, Primitive::kPrimVoid, dex_pc);
1826 break;
1827 }
1828
1829#define IF_XX(comparison, cond) \
1830 case Instruction::IF_##cond: If_22t<comparison>(instruction, dex_pc); break; \
1831 case Instruction::IF_##cond##Z: If_21t<comparison>(instruction, dex_pc); break
1832
1833 IF_XX(HEqual, EQ);
1834 IF_XX(HNotEqual, NE);
1835 IF_XX(HLessThan, LT);
1836 IF_XX(HLessThanOrEqual, LE);
1837 IF_XX(HGreaterThan, GT);
1838 IF_XX(HGreaterThanOrEqual, GE);
1839
1840 case Instruction::GOTO:
1841 case Instruction::GOTO_16:
1842 case Instruction::GOTO_32: {
1843 AppendInstruction(new (arena_) HGoto(dex_pc));
1844 current_block_ = nullptr;
1845 break;
1846 }
1847
1848 case Instruction::RETURN: {
1849 BuildReturn(instruction, return_type_, dex_pc);
1850 break;
1851 }
1852
1853 case Instruction::RETURN_OBJECT: {
1854 BuildReturn(instruction, return_type_, dex_pc);
1855 break;
1856 }
1857
1858 case Instruction::RETURN_WIDE: {
1859 BuildReturn(instruction, return_type_, dex_pc);
1860 break;
1861 }
1862
1863 case Instruction::INVOKE_DIRECT:
1864 case Instruction::INVOKE_INTERFACE:
1865 case Instruction::INVOKE_STATIC:
1866 case Instruction::INVOKE_SUPER:
1867 case Instruction::INVOKE_VIRTUAL:
1868 case Instruction::INVOKE_VIRTUAL_QUICK: {
1869 uint16_t method_idx;
1870 if (instruction.Opcode() == Instruction::INVOKE_VIRTUAL_QUICK) {
1871 if (!CanDecodeQuickenedInfo()) {
1872 return false;
1873 }
1874 method_idx = LookupQuickenedInfo(dex_pc);
1875 } else {
1876 method_idx = instruction.VRegB_35c();
1877 }
1878 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
1879 uint32_t args[5];
1880 instruction.GetVarArgs(args);
1881 if (!BuildInvoke(instruction, dex_pc, method_idx,
1882 number_of_vreg_arguments, false, args, -1)) {
1883 return false;
1884 }
1885 break;
1886 }
1887
1888 case Instruction::INVOKE_DIRECT_RANGE:
1889 case Instruction::INVOKE_INTERFACE_RANGE:
1890 case Instruction::INVOKE_STATIC_RANGE:
1891 case Instruction::INVOKE_SUPER_RANGE:
1892 case Instruction::INVOKE_VIRTUAL_RANGE:
1893 case Instruction::INVOKE_VIRTUAL_RANGE_QUICK: {
1894 uint16_t method_idx;
1895 if (instruction.Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK) {
1896 if (!CanDecodeQuickenedInfo()) {
1897 return false;
1898 }
1899 method_idx = LookupQuickenedInfo(dex_pc);
1900 } else {
1901 method_idx = instruction.VRegB_3rc();
1902 }
1903 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
1904 uint32_t register_index = instruction.VRegC();
1905 if (!BuildInvoke(instruction, dex_pc, method_idx,
1906 number_of_vreg_arguments, true, nullptr, register_index)) {
1907 return false;
1908 }
1909 break;
1910 }
1911
1912 case Instruction::NEG_INT: {
1913 Unop_12x<HNeg>(instruction, Primitive::kPrimInt, dex_pc);
1914 break;
1915 }
1916
1917 case Instruction::NEG_LONG: {
1918 Unop_12x<HNeg>(instruction, Primitive::kPrimLong, dex_pc);
1919 break;
1920 }
1921
1922 case Instruction::NEG_FLOAT: {
1923 Unop_12x<HNeg>(instruction, Primitive::kPrimFloat, dex_pc);
1924 break;
1925 }
1926
1927 case Instruction::NEG_DOUBLE: {
1928 Unop_12x<HNeg>(instruction, Primitive::kPrimDouble, dex_pc);
1929 break;
1930 }
1931
1932 case Instruction::NOT_INT: {
1933 Unop_12x<HNot>(instruction, Primitive::kPrimInt, dex_pc);
1934 break;
1935 }
1936
1937 case Instruction::NOT_LONG: {
1938 Unop_12x<HNot>(instruction, Primitive::kPrimLong, dex_pc);
1939 break;
1940 }
1941
1942 case Instruction::INT_TO_LONG: {
1943 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimLong, dex_pc);
1944 break;
1945 }
1946
1947 case Instruction::INT_TO_FLOAT: {
1948 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimFloat, dex_pc);
1949 break;
1950 }
1951
1952 case Instruction::INT_TO_DOUBLE: {
1953 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimDouble, dex_pc);
1954 break;
1955 }
1956
1957 case Instruction::LONG_TO_INT: {
1958 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimInt, dex_pc);
1959 break;
1960 }
1961
1962 case Instruction::LONG_TO_FLOAT: {
1963 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimFloat, dex_pc);
1964 break;
1965 }
1966
1967 case Instruction::LONG_TO_DOUBLE: {
1968 Conversion_12x(instruction, Primitive::kPrimLong, Primitive::kPrimDouble, dex_pc);
1969 break;
1970 }
1971
1972 case Instruction::FLOAT_TO_INT: {
1973 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimInt, dex_pc);
1974 break;
1975 }
1976
1977 case Instruction::FLOAT_TO_LONG: {
1978 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimLong, dex_pc);
1979 break;
1980 }
1981
1982 case Instruction::FLOAT_TO_DOUBLE: {
1983 Conversion_12x(instruction, Primitive::kPrimFloat, Primitive::kPrimDouble, dex_pc);
1984 break;
1985 }
1986
1987 case Instruction::DOUBLE_TO_INT: {
1988 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimInt, dex_pc);
1989 break;
1990 }
1991
1992 case Instruction::DOUBLE_TO_LONG: {
1993 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimLong, dex_pc);
1994 break;
1995 }
1996
1997 case Instruction::DOUBLE_TO_FLOAT: {
1998 Conversion_12x(instruction, Primitive::kPrimDouble, Primitive::kPrimFloat, dex_pc);
1999 break;
2000 }
2001
2002 case Instruction::INT_TO_BYTE: {
2003 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimByte, dex_pc);
2004 break;
2005 }
2006
2007 case Instruction::INT_TO_SHORT: {
2008 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimShort, dex_pc);
2009 break;
2010 }
2011
2012 case Instruction::INT_TO_CHAR: {
2013 Conversion_12x(instruction, Primitive::kPrimInt, Primitive::kPrimChar, dex_pc);
2014 break;
2015 }
2016
2017 case Instruction::ADD_INT: {
2018 Binop_23x<HAdd>(instruction, Primitive::kPrimInt, dex_pc);
2019 break;
2020 }
2021
2022 case Instruction::ADD_LONG: {
2023 Binop_23x<HAdd>(instruction, Primitive::kPrimLong, dex_pc);
2024 break;
2025 }
2026
2027 case Instruction::ADD_DOUBLE: {
2028 Binop_23x<HAdd>(instruction, Primitive::kPrimDouble, dex_pc);
2029 break;
2030 }
2031
2032 case Instruction::ADD_FLOAT: {
2033 Binop_23x<HAdd>(instruction, Primitive::kPrimFloat, dex_pc);
2034 break;
2035 }
2036
2037 case Instruction::SUB_INT: {
2038 Binop_23x<HSub>(instruction, Primitive::kPrimInt, dex_pc);
2039 break;
2040 }
2041
2042 case Instruction::SUB_LONG: {
2043 Binop_23x<HSub>(instruction, Primitive::kPrimLong, dex_pc);
2044 break;
2045 }
2046
2047 case Instruction::SUB_FLOAT: {
2048 Binop_23x<HSub>(instruction, Primitive::kPrimFloat, dex_pc);
2049 break;
2050 }
2051
2052 case Instruction::SUB_DOUBLE: {
2053 Binop_23x<HSub>(instruction, Primitive::kPrimDouble, dex_pc);
2054 break;
2055 }
2056
2057 case Instruction::ADD_INT_2ADDR: {
2058 Binop_12x<HAdd>(instruction, Primitive::kPrimInt, dex_pc);
2059 break;
2060 }
2061
2062 case Instruction::MUL_INT: {
2063 Binop_23x<HMul>(instruction, Primitive::kPrimInt, dex_pc);
2064 break;
2065 }
2066
2067 case Instruction::MUL_LONG: {
2068 Binop_23x<HMul>(instruction, Primitive::kPrimLong, dex_pc);
2069 break;
2070 }
2071
2072 case Instruction::MUL_FLOAT: {
2073 Binop_23x<HMul>(instruction, Primitive::kPrimFloat, dex_pc);
2074 break;
2075 }
2076
2077 case Instruction::MUL_DOUBLE: {
2078 Binop_23x<HMul>(instruction, Primitive::kPrimDouble, dex_pc);
2079 break;
2080 }
2081
2082 case Instruction::DIV_INT: {
2083 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2084 dex_pc, Primitive::kPrimInt, false, true);
2085 break;
2086 }
2087
2088 case Instruction::DIV_LONG: {
2089 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2090 dex_pc, Primitive::kPrimLong, false, true);
2091 break;
2092 }
2093
2094 case Instruction::DIV_FLOAT: {
2095 Binop_23x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
2096 break;
2097 }
2098
2099 case Instruction::DIV_DOUBLE: {
2100 Binop_23x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
2101 break;
2102 }
2103
2104 case Instruction::REM_INT: {
2105 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2106 dex_pc, Primitive::kPrimInt, false, false);
2107 break;
2108 }
2109
2110 case Instruction::REM_LONG: {
2111 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2112 dex_pc, Primitive::kPrimLong, false, false);
2113 break;
2114 }
2115
2116 case Instruction::REM_FLOAT: {
2117 Binop_23x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2118 break;
2119 }
2120
2121 case Instruction::REM_DOUBLE: {
2122 Binop_23x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2123 break;
2124 }
2125
2126 case Instruction::AND_INT: {
2127 Binop_23x<HAnd>(instruction, Primitive::kPrimInt, dex_pc);
2128 break;
2129 }
2130
2131 case Instruction::AND_LONG: {
2132 Binop_23x<HAnd>(instruction, Primitive::kPrimLong, dex_pc);
2133 break;
2134 }
2135
2136 case Instruction::SHL_INT: {
2137 Binop_23x_shift<HShl>(instruction, Primitive::kPrimInt, dex_pc);
2138 break;
2139 }
2140
2141 case Instruction::SHL_LONG: {
2142 Binop_23x_shift<HShl>(instruction, Primitive::kPrimLong, dex_pc);
2143 break;
2144 }
2145
2146 case Instruction::SHR_INT: {
2147 Binop_23x_shift<HShr>(instruction, Primitive::kPrimInt, dex_pc);
2148 break;
2149 }
2150
2151 case Instruction::SHR_LONG: {
2152 Binop_23x_shift<HShr>(instruction, Primitive::kPrimLong, dex_pc);
2153 break;
2154 }
2155
2156 case Instruction::USHR_INT: {
2157 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimInt, dex_pc);
2158 break;
2159 }
2160
2161 case Instruction::USHR_LONG: {
2162 Binop_23x_shift<HUShr>(instruction, Primitive::kPrimLong, dex_pc);
2163 break;
2164 }
2165
2166 case Instruction::OR_INT: {
2167 Binop_23x<HOr>(instruction, Primitive::kPrimInt, dex_pc);
2168 break;
2169 }
2170
2171 case Instruction::OR_LONG: {
2172 Binop_23x<HOr>(instruction, Primitive::kPrimLong, dex_pc);
2173 break;
2174 }
2175
2176 case Instruction::XOR_INT: {
2177 Binop_23x<HXor>(instruction, Primitive::kPrimInt, dex_pc);
2178 break;
2179 }
2180
2181 case Instruction::XOR_LONG: {
2182 Binop_23x<HXor>(instruction, Primitive::kPrimLong, dex_pc);
2183 break;
2184 }
2185
2186 case Instruction::ADD_LONG_2ADDR: {
2187 Binop_12x<HAdd>(instruction, Primitive::kPrimLong, dex_pc);
2188 break;
2189 }
2190
2191 case Instruction::ADD_DOUBLE_2ADDR: {
2192 Binop_12x<HAdd>(instruction, Primitive::kPrimDouble, dex_pc);
2193 break;
2194 }
2195
2196 case Instruction::ADD_FLOAT_2ADDR: {
2197 Binop_12x<HAdd>(instruction, Primitive::kPrimFloat, dex_pc);
2198 break;
2199 }
2200
2201 case Instruction::SUB_INT_2ADDR: {
2202 Binop_12x<HSub>(instruction, Primitive::kPrimInt, dex_pc);
2203 break;
2204 }
2205
2206 case Instruction::SUB_LONG_2ADDR: {
2207 Binop_12x<HSub>(instruction, Primitive::kPrimLong, dex_pc);
2208 break;
2209 }
2210
2211 case Instruction::SUB_FLOAT_2ADDR: {
2212 Binop_12x<HSub>(instruction, Primitive::kPrimFloat, dex_pc);
2213 break;
2214 }
2215
2216 case Instruction::SUB_DOUBLE_2ADDR: {
2217 Binop_12x<HSub>(instruction, Primitive::kPrimDouble, dex_pc);
2218 break;
2219 }
2220
2221 case Instruction::MUL_INT_2ADDR: {
2222 Binop_12x<HMul>(instruction, Primitive::kPrimInt, dex_pc);
2223 break;
2224 }
2225
2226 case Instruction::MUL_LONG_2ADDR: {
2227 Binop_12x<HMul>(instruction, Primitive::kPrimLong, dex_pc);
2228 break;
2229 }
2230
2231 case Instruction::MUL_FLOAT_2ADDR: {
2232 Binop_12x<HMul>(instruction, Primitive::kPrimFloat, dex_pc);
2233 break;
2234 }
2235
2236 case Instruction::MUL_DOUBLE_2ADDR: {
2237 Binop_12x<HMul>(instruction, Primitive::kPrimDouble, dex_pc);
2238 break;
2239 }
2240
2241 case Instruction::DIV_INT_2ADDR: {
2242 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2243 dex_pc, Primitive::kPrimInt, false, true);
2244 break;
2245 }
2246
2247 case Instruction::DIV_LONG_2ADDR: {
2248 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2249 dex_pc, Primitive::kPrimLong, false, true);
2250 break;
2251 }
2252
2253 case Instruction::REM_INT_2ADDR: {
2254 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2255 dex_pc, Primitive::kPrimInt, false, false);
2256 break;
2257 }
2258
2259 case Instruction::REM_LONG_2ADDR: {
2260 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegA(), instruction.VRegB(),
2261 dex_pc, Primitive::kPrimLong, false, false);
2262 break;
2263 }
2264
2265 case Instruction::REM_FLOAT_2ADDR: {
2266 Binop_12x<HRem>(instruction, Primitive::kPrimFloat, dex_pc);
2267 break;
2268 }
2269
2270 case Instruction::REM_DOUBLE_2ADDR: {
2271 Binop_12x<HRem>(instruction, Primitive::kPrimDouble, dex_pc);
2272 break;
2273 }
2274
2275 case Instruction::SHL_INT_2ADDR: {
2276 Binop_12x_shift<HShl>(instruction, Primitive::kPrimInt, dex_pc);
2277 break;
2278 }
2279
2280 case Instruction::SHL_LONG_2ADDR: {
2281 Binop_12x_shift<HShl>(instruction, Primitive::kPrimLong, dex_pc);
2282 break;
2283 }
2284
2285 case Instruction::SHR_INT_2ADDR: {
2286 Binop_12x_shift<HShr>(instruction, Primitive::kPrimInt, dex_pc);
2287 break;
2288 }
2289
2290 case Instruction::SHR_LONG_2ADDR: {
2291 Binop_12x_shift<HShr>(instruction, Primitive::kPrimLong, dex_pc);
2292 break;
2293 }
2294
2295 case Instruction::USHR_INT_2ADDR: {
2296 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimInt, dex_pc);
2297 break;
2298 }
2299
2300 case Instruction::USHR_LONG_2ADDR: {
2301 Binop_12x_shift<HUShr>(instruction, Primitive::kPrimLong, dex_pc);
2302 break;
2303 }
2304
2305 case Instruction::DIV_FLOAT_2ADDR: {
2306 Binop_12x<HDiv>(instruction, Primitive::kPrimFloat, dex_pc);
2307 break;
2308 }
2309
2310 case Instruction::DIV_DOUBLE_2ADDR: {
2311 Binop_12x<HDiv>(instruction, Primitive::kPrimDouble, dex_pc);
2312 break;
2313 }
2314
2315 case Instruction::AND_INT_2ADDR: {
2316 Binop_12x<HAnd>(instruction, Primitive::kPrimInt, dex_pc);
2317 break;
2318 }
2319
2320 case Instruction::AND_LONG_2ADDR: {
2321 Binop_12x<HAnd>(instruction, Primitive::kPrimLong, dex_pc);
2322 break;
2323 }
2324
2325 case Instruction::OR_INT_2ADDR: {
2326 Binop_12x<HOr>(instruction, Primitive::kPrimInt, dex_pc);
2327 break;
2328 }
2329
2330 case Instruction::OR_LONG_2ADDR: {
2331 Binop_12x<HOr>(instruction, Primitive::kPrimLong, dex_pc);
2332 break;
2333 }
2334
2335 case Instruction::XOR_INT_2ADDR: {
2336 Binop_12x<HXor>(instruction, Primitive::kPrimInt, dex_pc);
2337 break;
2338 }
2339
2340 case Instruction::XOR_LONG_2ADDR: {
2341 Binop_12x<HXor>(instruction, Primitive::kPrimLong, dex_pc);
2342 break;
2343 }
2344
2345 case Instruction::ADD_INT_LIT16: {
2346 Binop_22s<HAdd>(instruction, false, dex_pc);
2347 break;
2348 }
2349
2350 case Instruction::AND_INT_LIT16: {
2351 Binop_22s<HAnd>(instruction, false, dex_pc);
2352 break;
2353 }
2354
2355 case Instruction::OR_INT_LIT16: {
2356 Binop_22s<HOr>(instruction, false, dex_pc);
2357 break;
2358 }
2359
2360 case Instruction::XOR_INT_LIT16: {
2361 Binop_22s<HXor>(instruction, false, dex_pc);
2362 break;
2363 }
2364
2365 case Instruction::RSUB_INT: {
2366 Binop_22s<HSub>(instruction, true, dex_pc);
2367 break;
2368 }
2369
2370 case Instruction::MUL_INT_LIT16: {
2371 Binop_22s<HMul>(instruction, false, dex_pc);
2372 break;
2373 }
2374
2375 case Instruction::ADD_INT_LIT8: {
2376 Binop_22b<HAdd>(instruction, false, dex_pc);
2377 break;
2378 }
2379
2380 case Instruction::AND_INT_LIT8: {
2381 Binop_22b<HAnd>(instruction, false, dex_pc);
2382 break;
2383 }
2384
2385 case Instruction::OR_INT_LIT8: {
2386 Binop_22b<HOr>(instruction, false, dex_pc);
2387 break;
2388 }
2389
2390 case Instruction::XOR_INT_LIT8: {
2391 Binop_22b<HXor>(instruction, false, dex_pc);
2392 break;
2393 }
2394
2395 case Instruction::RSUB_INT_LIT8: {
2396 Binop_22b<HSub>(instruction, true, dex_pc);
2397 break;
2398 }
2399
2400 case Instruction::MUL_INT_LIT8: {
2401 Binop_22b<HMul>(instruction, false, dex_pc);
2402 break;
2403 }
2404
2405 case Instruction::DIV_INT_LIT16:
2406 case Instruction::DIV_INT_LIT8: {
2407 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2408 dex_pc, Primitive::kPrimInt, true, true);
2409 break;
2410 }
2411
2412 case Instruction::REM_INT_LIT16:
2413 case Instruction::REM_INT_LIT8: {
2414 BuildCheckedDivRem(instruction.VRegA(), instruction.VRegB(), instruction.VRegC(),
2415 dex_pc, Primitive::kPrimInt, true, false);
2416 break;
2417 }
2418
2419 case Instruction::SHL_INT_LIT8: {
2420 Binop_22b<HShl>(instruction, false, dex_pc);
2421 break;
2422 }
2423
2424 case Instruction::SHR_INT_LIT8: {
2425 Binop_22b<HShr>(instruction, false, dex_pc);
2426 break;
2427 }
2428
2429 case Instruction::USHR_INT_LIT8: {
2430 Binop_22b<HUShr>(instruction, false, dex_pc);
2431 break;
2432 }
2433
2434 case Instruction::NEW_INSTANCE: {
2435 if (!BuildNewInstance(instruction.VRegB_21c(), dex_pc)) {
2436 return false;
2437 }
2438 UpdateLocal(instruction.VRegA(), current_block_->GetLastInstruction());
2439 break;
2440 }
2441
2442 case Instruction::NEW_ARRAY: {
2443 uint16_t type_index = instruction.VRegC_22c();
2444 HInstruction* length = LoadLocal(instruction.VRegB_22c(), Primitive::kPrimInt);
2445 bool finalizable;
2446 QuickEntrypointEnum entrypoint = NeedsAccessCheck(type_index, &finalizable)
2447 ? kQuickAllocArrayWithAccessCheck
2448 : kQuickAllocArray;
2449 AppendInstruction(new (arena_) HNewArray(length,
2450 graph_->GetCurrentMethod(),
2451 dex_pc,
2452 type_index,
2453 *dex_compilation_unit_->GetDexFile(),
2454 entrypoint));
2455 UpdateLocal(instruction.VRegA_22c(), current_block_->GetLastInstruction());
2456 break;
2457 }
2458
2459 case Instruction::FILLED_NEW_ARRAY: {
2460 uint32_t number_of_vreg_arguments = instruction.VRegA_35c();
2461 uint32_t type_index = instruction.VRegB_35c();
2462 uint32_t args[5];
2463 instruction.GetVarArgs(args);
2464 BuildFilledNewArray(dex_pc, type_index, number_of_vreg_arguments, false, args, 0);
2465 break;
2466 }
2467
2468 case Instruction::FILLED_NEW_ARRAY_RANGE: {
2469 uint32_t number_of_vreg_arguments = instruction.VRegA_3rc();
2470 uint32_t type_index = instruction.VRegB_3rc();
2471 uint32_t register_index = instruction.VRegC_3rc();
2472 BuildFilledNewArray(
2473 dex_pc, type_index, number_of_vreg_arguments, true, nullptr, register_index);
2474 break;
2475 }
2476
2477 case Instruction::FILL_ARRAY_DATA: {
2478 BuildFillArrayData(instruction, dex_pc);
2479 break;
2480 }
2481
2482 case Instruction::MOVE_RESULT:
2483 case Instruction::MOVE_RESULT_WIDE:
2484 case Instruction::MOVE_RESULT_OBJECT: {
2485 DCHECK(latest_result_ != nullptr);
2486 UpdateLocal(instruction.VRegA(), latest_result_);
2487 latest_result_ = nullptr;
2488 break;
2489 }
2490
2491 case Instruction::CMP_LONG: {
2492 Binop_23x_cmp(instruction, Primitive::kPrimLong, ComparisonBias::kNoBias, dex_pc);
2493 break;
2494 }
2495
2496 case Instruction::CMPG_FLOAT: {
2497 Binop_23x_cmp(instruction, Primitive::kPrimFloat, ComparisonBias::kGtBias, dex_pc);
2498 break;
2499 }
2500
2501 case Instruction::CMPG_DOUBLE: {
2502 Binop_23x_cmp(instruction, Primitive::kPrimDouble, ComparisonBias::kGtBias, dex_pc);
2503 break;
2504 }
2505
2506 case Instruction::CMPL_FLOAT: {
2507 Binop_23x_cmp(instruction, Primitive::kPrimFloat, ComparisonBias::kLtBias, dex_pc);
2508 break;
2509 }
2510
2511 case Instruction::CMPL_DOUBLE: {
2512 Binop_23x_cmp(instruction, Primitive::kPrimDouble, ComparisonBias::kLtBias, dex_pc);
2513 break;
2514 }
2515
2516 case Instruction::NOP:
2517 break;
2518
2519 case Instruction::IGET:
2520 case Instruction::IGET_QUICK:
2521 case Instruction::IGET_WIDE:
2522 case Instruction::IGET_WIDE_QUICK:
2523 case Instruction::IGET_OBJECT:
2524 case Instruction::IGET_OBJECT_QUICK:
2525 case Instruction::IGET_BOOLEAN:
2526 case Instruction::IGET_BOOLEAN_QUICK:
2527 case Instruction::IGET_BYTE:
2528 case Instruction::IGET_BYTE_QUICK:
2529 case Instruction::IGET_CHAR:
2530 case Instruction::IGET_CHAR_QUICK:
2531 case Instruction::IGET_SHORT:
2532 case Instruction::IGET_SHORT_QUICK: {
2533 if (!BuildInstanceFieldAccess(instruction, dex_pc, false)) {
2534 return false;
2535 }
2536 break;
2537 }
2538
2539 case Instruction::IPUT:
2540 case Instruction::IPUT_QUICK:
2541 case Instruction::IPUT_WIDE:
2542 case Instruction::IPUT_WIDE_QUICK:
2543 case Instruction::IPUT_OBJECT:
2544 case Instruction::IPUT_OBJECT_QUICK:
2545 case Instruction::IPUT_BOOLEAN:
2546 case Instruction::IPUT_BOOLEAN_QUICK:
2547 case Instruction::IPUT_BYTE:
2548 case Instruction::IPUT_BYTE_QUICK:
2549 case Instruction::IPUT_CHAR:
2550 case Instruction::IPUT_CHAR_QUICK:
2551 case Instruction::IPUT_SHORT:
2552 case Instruction::IPUT_SHORT_QUICK: {
2553 if (!BuildInstanceFieldAccess(instruction, dex_pc, true)) {
2554 return false;
2555 }
2556 break;
2557 }
2558
2559 case Instruction::SGET:
2560 case Instruction::SGET_WIDE:
2561 case Instruction::SGET_OBJECT:
2562 case Instruction::SGET_BOOLEAN:
2563 case Instruction::SGET_BYTE:
2564 case Instruction::SGET_CHAR:
2565 case Instruction::SGET_SHORT: {
2566 if (!BuildStaticFieldAccess(instruction, dex_pc, false)) {
2567 return false;
2568 }
2569 break;
2570 }
2571
2572 case Instruction::SPUT:
2573 case Instruction::SPUT_WIDE:
2574 case Instruction::SPUT_OBJECT:
2575 case Instruction::SPUT_BOOLEAN:
2576 case Instruction::SPUT_BYTE:
2577 case Instruction::SPUT_CHAR:
2578 case Instruction::SPUT_SHORT: {
2579 if (!BuildStaticFieldAccess(instruction, dex_pc, true)) {
2580 return false;
2581 }
2582 break;
2583 }
2584
2585#define ARRAY_XX(kind, anticipated_type) \
2586 case Instruction::AGET##kind: { \
2587 BuildArrayAccess(instruction, dex_pc, false, anticipated_type); \
2588 break; \
2589 } \
2590 case Instruction::APUT##kind: { \
2591 BuildArrayAccess(instruction, dex_pc, true, anticipated_type); \
2592 break; \
2593 }
2594
2595 ARRAY_XX(, Primitive::kPrimInt);
2596 ARRAY_XX(_WIDE, Primitive::kPrimLong);
2597 ARRAY_XX(_OBJECT, Primitive::kPrimNot);
2598 ARRAY_XX(_BOOLEAN, Primitive::kPrimBoolean);
2599 ARRAY_XX(_BYTE, Primitive::kPrimByte);
2600 ARRAY_XX(_CHAR, Primitive::kPrimChar);
2601 ARRAY_XX(_SHORT, Primitive::kPrimShort);
2602
2603 case Instruction::ARRAY_LENGTH: {
David Brazdilc120bbe2016-04-22 16:57:00 +01002604 HInstruction* object = LoadNullCheckedLocal(instruction.VRegB_12x(), dex_pc);
David Brazdildee58d62016-04-07 09:54:26 +00002605 AppendInstruction(new (arena_) HArrayLength(object, dex_pc));
2606 UpdateLocal(instruction.VRegA_12x(), current_block_->GetLastInstruction());
2607 break;
2608 }
2609
2610 case Instruction::CONST_STRING: {
2611 uint32_t string_index = instruction.VRegB_21c();
2612 AppendInstruction(
2613 new (arena_) HLoadString(graph_->GetCurrentMethod(), string_index, *dex_file_, dex_pc));
2614 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction());
2615 break;
2616 }
2617
2618 case Instruction::CONST_STRING_JUMBO: {
2619 uint32_t string_index = instruction.VRegB_31c();
2620 AppendInstruction(
2621 new (arena_) HLoadString(graph_->GetCurrentMethod(), string_index, *dex_file_, dex_pc));
2622 UpdateLocal(instruction.VRegA_31c(), current_block_->GetLastInstruction());
2623 break;
2624 }
2625
2626 case Instruction::CONST_CLASS: {
2627 uint16_t type_index = instruction.VRegB_21c();
David Brazdildee58d62016-04-07 09:54:26 +00002628 // `CanAccessTypeWithoutChecks` will tell whether the method being
2629 // built is trying to access its own class, so that the generated
2630 // code can optimize for this case. However, the optimization does not
2631 // work for inlining, so we use `IsOutermostCompilingClass` instead.
Vladimir Marko3cd50df2016-04-13 19:29:26 +01002632 ScopedObjectAccess soa(Thread::Current());
2633 Handle<mirror::DexCache> dex_cache = dex_compilation_unit_->GetDexCache();
David Brazdildee58d62016-04-07 09:54:26 +00002634 bool can_access = compiler_driver_->CanAccessTypeWithoutChecks(
Vladimir Marko3cd50df2016-04-13 19:29:26 +01002635 dex_compilation_unit_->GetDexMethodIndex(), dex_cache, type_index);
David Brazdildee58d62016-04-07 09:54:26 +00002636 AppendInstruction(new (arena_) HLoadClass(
2637 graph_->GetCurrentMethod(),
2638 type_index,
2639 *dex_file_,
2640 IsOutermostCompilingClass(type_index),
2641 dex_pc,
2642 !can_access,
Mathieu Chartier31b12e32016-09-02 17:11:57 -07002643 /* is_in_dex_cache */ false,
2644 /* is_in_boot_image */ false));
David Brazdildee58d62016-04-07 09:54:26 +00002645 UpdateLocal(instruction.VRegA_21c(), current_block_->GetLastInstruction());
2646 break;
2647 }
2648
2649 case Instruction::MOVE_EXCEPTION: {
2650 AppendInstruction(new (arena_) HLoadException(dex_pc));
2651 UpdateLocal(instruction.VRegA_11x(), current_block_->GetLastInstruction());
2652 AppendInstruction(new (arena_) HClearException(dex_pc));
2653 break;
2654 }
2655
2656 case Instruction::THROW: {
2657 HInstruction* exception = LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot);
2658 AppendInstruction(new (arena_) HThrow(exception, dex_pc));
2659 // We finished building this block. Set the current block to null to avoid
2660 // adding dead instructions to it.
2661 current_block_ = nullptr;
2662 break;
2663 }
2664
2665 case Instruction::INSTANCE_OF: {
2666 uint8_t destination = instruction.VRegA_22c();
2667 uint8_t reference = instruction.VRegB_22c();
2668 uint16_t type_index = instruction.VRegC_22c();
2669 BuildTypeCheck(instruction, destination, reference, type_index, dex_pc);
2670 break;
2671 }
2672
2673 case Instruction::CHECK_CAST: {
2674 uint8_t reference = instruction.VRegA_21c();
2675 uint16_t type_index = instruction.VRegB_21c();
2676 BuildTypeCheck(instruction, -1, reference, type_index, dex_pc);
2677 break;
2678 }
2679
2680 case Instruction::MONITOR_ENTER: {
2681 AppendInstruction(new (arena_) HMonitorOperation(
2682 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot),
2683 HMonitorOperation::OperationKind::kEnter,
2684 dex_pc));
2685 break;
2686 }
2687
2688 case Instruction::MONITOR_EXIT: {
2689 AppendInstruction(new (arena_) HMonitorOperation(
2690 LoadLocal(instruction.VRegA_11x(), Primitive::kPrimNot),
2691 HMonitorOperation::OperationKind::kExit,
2692 dex_pc));
2693 break;
2694 }
2695
2696 case Instruction::SPARSE_SWITCH:
2697 case Instruction::PACKED_SWITCH: {
2698 BuildSwitch(instruction, dex_pc);
2699 break;
2700 }
2701
2702 default:
2703 VLOG(compiler) << "Did not compile "
2704 << PrettyMethod(dex_compilation_unit_->GetDexMethodIndex(), *dex_file_)
2705 << " because of unhandled instruction "
2706 << instruction.Name();
2707 MaybeRecordStat(MethodCompilationStat::kNotCompiledUnhandledInstruction);
2708 return false;
2709 }
2710 return true;
2711} // NOLINT(readability/fn_size)
2712
2713} // namespace art