Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "instruction_simplifier.h" |
| 18 | |
Nicolas Geoffray | a83a54d | 2015-10-02 17:30:26 +0100 | [diff] [blame] | 19 | #include "intrinsics.h" |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 20 | #include "mirror/class-inl.h" |
| 21 | #include "scoped_thread_state_change.h" |
| 22 | |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 23 | namespace art { |
| 24 | |
Nicolas Geoffray | a83a54d | 2015-10-02 17:30:26 +0100 | [diff] [blame] | 25 | class InstructionSimplifierVisitor : public HGraphDelegateVisitor { |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 26 | public: |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 27 | InstructionSimplifierVisitor(HGraph* graph, OptimizingCompilerStats* stats) |
Nicolas Geoffray | a83a54d | 2015-10-02 17:30:26 +0100 | [diff] [blame] | 28 | : HGraphDelegateVisitor(graph), |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 29 | stats_(stats) {} |
| 30 | |
| 31 | void Run(); |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 32 | |
| 33 | private: |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 34 | void RecordSimplification() { |
| 35 | simplification_occurred_ = true; |
| 36 | simplifications_at_current_position_++; |
| 37 | if (stats_) { |
| 38 | stats_->RecordStat(kInstructionSimplifications); |
| 39 | } |
| 40 | } |
| 41 | |
| 42 | bool TryMoveNegOnInputsAfterBinop(HBinaryOperation* binop); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 43 | void VisitShift(HBinaryOperation* shift); |
| 44 | |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 45 | void VisitSuspendCheck(HSuspendCheck* check) OVERRIDE; |
| 46 | void VisitEqual(HEqual* equal) OVERRIDE; |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 47 | void VisitNotEqual(HNotEqual* equal) OVERRIDE; |
| 48 | void VisitBooleanNot(HBooleanNot* bool_not) OVERRIDE; |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 49 | void VisitInstanceFieldSet(HInstanceFieldSet* equal) OVERRIDE; |
| 50 | void VisitStaticFieldSet(HStaticFieldSet* equal) OVERRIDE; |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 51 | void VisitArraySet(HArraySet* equal) OVERRIDE; |
Nicolas Geoffray | 01fcc9e | 2014-12-01 14:16:20 +0000 | [diff] [blame] | 52 | void VisitTypeConversion(HTypeConversion* instruction) OVERRIDE; |
Calin Juravle | 10e244f | 2015-01-26 18:54:32 +0000 | [diff] [blame] | 53 | void VisitNullCheck(HNullCheck* instruction) OVERRIDE; |
Mingyao Yang | 0304e18 | 2015-01-30 16:41:29 -0800 | [diff] [blame] | 54 | void VisitArrayLength(HArrayLength* instruction) OVERRIDE; |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 55 | void VisitCheckCast(HCheckCast* instruction) OVERRIDE; |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 56 | void VisitAdd(HAdd* instruction) OVERRIDE; |
| 57 | void VisitAnd(HAnd* instruction) OVERRIDE; |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 58 | void VisitCondition(HCondition* instruction) OVERRIDE; |
| 59 | void VisitGreaterThan(HGreaterThan* condition) OVERRIDE; |
| 60 | void VisitGreaterThanOrEqual(HGreaterThanOrEqual* condition) OVERRIDE; |
| 61 | void VisitLessThan(HLessThan* condition) OVERRIDE; |
| 62 | void VisitLessThanOrEqual(HLessThanOrEqual* condition) OVERRIDE; |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 63 | void VisitDiv(HDiv* instruction) OVERRIDE; |
| 64 | void VisitMul(HMul* instruction) OVERRIDE; |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 65 | void VisitNeg(HNeg* instruction) OVERRIDE; |
| 66 | void VisitNot(HNot* instruction) OVERRIDE; |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 67 | void VisitOr(HOr* instruction) OVERRIDE; |
| 68 | void VisitShl(HShl* instruction) OVERRIDE; |
| 69 | void VisitShr(HShr* instruction) OVERRIDE; |
| 70 | void VisitSub(HSub* instruction) OVERRIDE; |
| 71 | void VisitUShr(HUShr* instruction) OVERRIDE; |
| 72 | void VisitXor(HXor* instruction) OVERRIDE; |
Guillaume "Vermeille" Sanchez | af88835 | 2015-04-20 14:41:30 +0100 | [diff] [blame] | 73 | void VisitInstanceOf(HInstanceOf* instruction) OVERRIDE; |
Nicolas Geoffray | 2e7cd75 | 2015-07-10 11:38:52 +0100 | [diff] [blame] | 74 | void VisitFakeString(HFakeString* fake_string) OVERRIDE; |
Nicolas Geoffray | a83a54d | 2015-10-02 17:30:26 +0100 | [diff] [blame] | 75 | void VisitInvoke(HInvoke* invoke) OVERRIDE; |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 76 | |
| 77 | bool CanEnsureNotNullAt(HInstruction* instr, HInstruction* at) const; |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 78 | |
| 79 | OptimizingCompilerStats* stats_; |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 80 | bool simplification_occurred_ = false; |
| 81 | int simplifications_at_current_position_ = 0; |
| 82 | // We ensure we do not loop infinitely. The value is a finger in the air guess |
| 83 | // that should allow enough simplification. |
| 84 | static constexpr int kMaxSamePositionSimplifications = 10; |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 85 | }; |
| 86 | |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 87 | void InstructionSimplifier::Run() { |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 88 | InstructionSimplifierVisitor visitor(graph_, stats_); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 89 | visitor.Run(); |
| 90 | } |
| 91 | |
| 92 | void InstructionSimplifierVisitor::Run() { |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 93 | // Iterate in reverse post order to open up more simplifications to users |
| 94 | // of instructions that got simplified. |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 95 | for (HReversePostOrderIterator it(*GetGraph()); !it.Done();) { |
| 96 | // The simplification of an instruction to another instruction may yield |
| 97 | // possibilities for other simplifications. So although we perform a reverse |
| 98 | // post order visit, we sometimes need to revisit an instruction index. |
| 99 | simplification_occurred_ = false; |
| 100 | VisitBasicBlock(it.Current()); |
| 101 | if (simplification_occurred_ && |
| 102 | (simplifications_at_current_position_ < kMaxSamePositionSimplifications)) { |
| 103 | // New simplifications may be applicable to the instruction at the |
| 104 | // current index, so don't advance the iterator. |
| 105 | continue; |
| 106 | } |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 107 | simplifications_at_current_position_ = 0; |
| 108 | it.Advance(); |
| 109 | } |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 110 | } |
| 111 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 112 | namespace { |
| 113 | |
| 114 | bool AreAllBitsSet(HConstant* constant) { |
| 115 | return Int64FromConstant(constant) == -1; |
| 116 | } |
| 117 | |
| 118 | } // namespace |
| 119 | |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 120 | // Returns true if the code was simplified to use only one negation operation |
| 121 | // after the binary operation instead of one on each of the inputs. |
| 122 | bool InstructionSimplifierVisitor::TryMoveNegOnInputsAfterBinop(HBinaryOperation* binop) { |
| 123 | DCHECK(binop->IsAdd() || binop->IsSub()); |
| 124 | DCHECK(binop->GetLeft()->IsNeg() && binop->GetRight()->IsNeg()); |
| 125 | HNeg* left_neg = binop->GetLeft()->AsNeg(); |
| 126 | HNeg* right_neg = binop->GetRight()->AsNeg(); |
| 127 | if (!left_neg->HasOnlyOneNonEnvironmentUse() || |
| 128 | !right_neg->HasOnlyOneNonEnvironmentUse()) { |
| 129 | return false; |
| 130 | } |
| 131 | // Replace code looking like |
| 132 | // NEG tmp1, a |
| 133 | // NEG tmp2, b |
| 134 | // ADD dst, tmp1, tmp2 |
| 135 | // with |
| 136 | // ADD tmp, a, b |
| 137 | // NEG dst, tmp |
Serdjuk, Nikolay Y | aae9e66 | 2015-08-21 13:26:34 +0600 | [diff] [blame] | 138 | // Note that we cannot optimize `(-a) + (-b)` to `-(a + b)` for floating-point. |
| 139 | // When `a` is `-0.0` and `b` is `0.0`, the former expression yields `0.0`, |
| 140 | // while the later yields `-0.0`. |
| 141 | if (!Primitive::IsIntegralType(binop->GetType())) { |
| 142 | return false; |
| 143 | } |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 144 | binop->ReplaceInput(left_neg->GetInput(), 0); |
| 145 | binop->ReplaceInput(right_neg->GetInput(), 1); |
| 146 | left_neg->GetBlock()->RemoveInstruction(left_neg); |
| 147 | right_neg->GetBlock()->RemoveInstruction(right_neg); |
| 148 | HNeg* neg = new (GetGraph()->GetArena()) HNeg(binop->GetType(), binop); |
| 149 | binop->GetBlock()->InsertInstructionBefore(neg, binop->GetNext()); |
| 150 | binop->ReplaceWithExceptInReplacementAtIndex(neg, 0); |
| 151 | RecordSimplification(); |
| 152 | return true; |
| 153 | } |
| 154 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 155 | void InstructionSimplifierVisitor::VisitShift(HBinaryOperation* instruction) { |
| 156 | DCHECK(instruction->IsShl() || instruction->IsShr() || instruction->IsUShr()); |
| 157 | HConstant* input_cst = instruction->GetConstantRight(); |
| 158 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 159 | |
Mark Mendell | ba56d06 | 2015-05-05 21:34:03 -0400 | [diff] [blame] | 160 | if (input_cst != nullptr) { |
| 161 | if (input_cst->IsZero()) { |
| 162 | // Replace code looking like |
| 163 | // SHL dst, src, 0 |
| 164 | // with |
| 165 | // src |
| 166 | instruction->ReplaceWith(input_other); |
| 167 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 168 | } else if (instruction->IsShl() && input_cst->IsOne()) { |
| 169 | // Replace Shl looking like |
| 170 | // SHL dst, src, 1 |
| 171 | // with |
| 172 | // ADD dst, src, src |
| 173 | HAdd *add = new(GetGraph()->GetArena()) HAdd(instruction->GetType(), |
| 174 | input_other, |
| 175 | input_other); |
| 176 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, add); |
| 177 | RecordSimplification(); |
| 178 | } |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 179 | } |
| 180 | } |
| 181 | |
Calin Juravle | 10e244f | 2015-01-26 18:54:32 +0000 | [diff] [blame] | 182 | void InstructionSimplifierVisitor::VisitNullCheck(HNullCheck* null_check) { |
| 183 | HInstruction* obj = null_check->InputAt(0); |
| 184 | if (!obj->CanBeNull()) { |
| 185 | null_check->ReplaceWith(obj); |
| 186 | null_check->GetBlock()->RemoveInstruction(null_check); |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 187 | if (stats_ != nullptr) { |
| 188 | stats_->RecordStat(MethodCompilationStat::kRemovedNullCheck); |
| 189 | } |
| 190 | } |
| 191 | } |
| 192 | |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 193 | bool InstructionSimplifierVisitor::CanEnsureNotNullAt(HInstruction* input, HInstruction* at) const { |
| 194 | if (!input->CanBeNull()) { |
| 195 | return true; |
| 196 | } |
| 197 | |
Guillaume "Vermeille" Sanchez | 8909baf | 2015-04-23 21:35:11 +0100 | [diff] [blame] | 198 | for (HUseIterator<HInstruction*> it(input->GetUses()); !it.Done(); it.Advance()) { |
| 199 | HInstruction* use = it.Current()->GetUser(); |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 200 | if (use->IsNullCheck() && use->StrictlyDominates(at)) { |
Guillaume "Vermeille" Sanchez | 8909baf | 2015-04-23 21:35:11 +0100 | [diff] [blame] | 201 | return true; |
| 202 | } |
| 203 | } |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 204 | |
Guillaume "Vermeille" Sanchez | 8909baf | 2015-04-23 21:35:11 +0100 | [diff] [blame] | 205 | return false; |
| 206 | } |
| 207 | |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 208 | // Returns whether doing a type test between the class of `object` against `klass` has |
| 209 | // a statically known outcome. The result of the test is stored in `outcome`. |
| 210 | static bool TypeCheckHasKnownOutcome(HLoadClass* klass, HInstruction* object, bool* outcome) { |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 211 | DCHECK(!object->IsNullConstant()) << "Null constants should be special cased"; |
| 212 | ReferenceTypeInfo obj_rti = object->GetReferenceTypeInfo(); |
| 213 | ScopedObjectAccess soa(Thread::Current()); |
| 214 | if (!obj_rti.IsValid()) { |
| 215 | // We run the simplifier before the reference type propagation so type info might not be |
| 216 | // available. |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 217 | return false; |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 218 | } |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 219 | |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 220 | ReferenceTypeInfo class_rti = klass->GetLoadedClassRTI(); |
Calin Juravle | 98893e1 | 2015-10-02 21:05:03 +0100 | [diff] [blame] | 221 | if (!class_rti.IsValid()) { |
| 222 | // Happens when the loaded class is unresolved. |
| 223 | return false; |
| 224 | } |
| 225 | DCHECK(class_rti.IsExact()); |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 226 | if (class_rti.IsSupertypeOf(obj_rti)) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 227 | *outcome = true; |
| 228 | return true; |
| 229 | } else if (obj_rti.IsExact()) { |
| 230 | // The test failed at compile time so will also fail at runtime. |
| 231 | *outcome = false; |
| 232 | return true; |
Nicolas Geoffray | 7cb499b | 2015-06-17 11:35:11 +0100 | [diff] [blame] | 233 | } else if (!class_rti.IsInterface() |
| 234 | && !obj_rti.IsInterface() |
| 235 | && !obj_rti.IsSupertypeOf(class_rti)) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 236 | // Different type hierarchy. The test will fail. |
| 237 | *outcome = false; |
| 238 | return true; |
| 239 | } |
| 240 | return false; |
| 241 | } |
| 242 | |
| 243 | void InstructionSimplifierVisitor::VisitCheckCast(HCheckCast* check_cast) { |
| 244 | HInstruction* object = check_cast->InputAt(0); |
Calin Juravle | e53fb55 | 2015-10-07 17:51:52 +0100 | [diff] [blame^] | 245 | HLoadClass* load_class = check_cast->InputAt(1)->AsLoadClass(); |
| 246 | if (load_class->NeedsAccessCheck()) { |
| 247 | // If we need to perform an access check we cannot remove the instruction. |
| 248 | return; |
| 249 | } |
| 250 | |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 251 | if (CanEnsureNotNullAt(object, check_cast)) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 252 | check_cast->ClearMustDoNullCheck(); |
| 253 | } |
| 254 | |
| 255 | if (object->IsNullConstant()) { |
Calin Juravle | acf735c | 2015-02-12 15:25:22 +0000 | [diff] [blame] | 256 | check_cast->GetBlock()->RemoveInstruction(check_cast); |
| 257 | if (stats_ != nullptr) { |
| 258 | stats_->RecordStat(MethodCompilationStat::kRemovedCheckedCast); |
| 259 | } |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 260 | return; |
| 261 | } |
| 262 | |
| 263 | bool outcome; |
Nicolas Geoffray | efa8468 | 2015-08-12 18:28:14 -0700 | [diff] [blame] | 264 | if (TypeCheckHasKnownOutcome(load_class, object, &outcome)) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 265 | if (outcome) { |
| 266 | check_cast->GetBlock()->RemoveInstruction(check_cast); |
| 267 | if (stats_ != nullptr) { |
| 268 | stats_->RecordStat(MethodCompilationStat::kRemovedCheckedCast); |
| 269 | } |
Nicolas Geoffray | efa8468 | 2015-08-12 18:28:14 -0700 | [diff] [blame] | 270 | if (!load_class->HasUses()) { |
| 271 | // We cannot rely on DCE to remove the class because the `HLoadClass` thinks it can throw. |
| 272 | // However, here we know that it cannot because the checkcast was successfull, hence |
| 273 | // the class was already loaded. |
| 274 | load_class->GetBlock()->RemoveInstruction(load_class); |
| 275 | } |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 276 | } else { |
| 277 | // Don't do anything for exceptional cases for now. Ideally we should remove |
| 278 | // all instructions and blocks this instruction dominates. |
| 279 | } |
Calin Juravle | 10e244f | 2015-01-26 18:54:32 +0000 | [diff] [blame] | 280 | } |
| 281 | } |
| 282 | |
Guillaume "Vermeille" Sanchez | af88835 | 2015-04-20 14:41:30 +0100 | [diff] [blame] | 283 | void InstructionSimplifierVisitor::VisitInstanceOf(HInstanceOf* instruction) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 284 | HInstruction* object = instruction->InputAt(0); |
Calin Juravle | e53fb55 | 2015-10-07 17:51:52 +0100 | [diff] [blame^] | 285 | HLoadClass* load_class = instruction->InputAt(1)->AsLoadClass(); |
| 286 | if (load_class->NeedsAccessCheck()) { |
| 287 | // If we need to perform an access check we cannot remove the instruction. |
| 288 | return; |
| 289 | } |
| 290 | |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 291 | bool can_be_null = true; |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 292 | if (CanEnsureNotNullAt(object, instruction)) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 293 | can_be_null = false; |
Guillaume "Vermeille" Sanchez | af88835 | 2015-04-20 14:41:30 +0100 | [diff] [blame] | 294 | instruction->ClearMustDoNullCheck(); |
| 295 | } |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 296 | |
| 297 | HGraph* graph = GetGraph(); |
| 298 | if (object->IsNullConstant()) { |
| 299 | instruction->ReplaceWith(graph->GetIntConstant(0)); |
| 300 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 301 | RecordSimplification(); |
| 302 | return; |
| 303 | } |
| 304 | |
| 305 | bool outcome; |
Nicolas Geoffray | efa8468 | 2015-08-12 18:28:14 -0700 | [diff] [blame] | 306 | if (TypeCheckHasKnownOutcome(load_class, object, &outcome)) { |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 307 | if (outcome && can_be_null) { |
| 308 | // Type test will succeed, we just need a null test. |
| 309 | HNotEqual* test = new (graph->GetArena()) HNotEqual(graph->GetNullConstant(), object); |
| 310 | instruction->GetBlock()->InsertInstructionBefore(test, instruction); |
| 311 | instruction->ReplaceWith(test); |
| 312 | } else { |
| 313 | // We've statically determined the result of the instanceof. |
| 314 | instruction->ReplaceWith(graph->GetIntConstant(outcome)); |
| 315 | } |
| 316 | RecordSimplification(); |
| 317 | instruction->GetBlock()->RemoveInstruction(instruction); |
Nicolas Geoffray | efa8468 | 2015-08-12 18:28:14 -0700 | [diff] [blame] | 318 | if (outcome && !load_class->HasUses()) { |
| 319 | // We cannot rely on DCE to remove the class because the `HLoadClass` thinks it can throw. |
| 320 | // However, here we know that it cannot because the instanceof check was successfull, hence |
| 321 | // the class was already loaded. |
| 322 | load_class->GetBlock()->RemoveInstruction(load_class); |
| 323 | } |
Guillaume Sanchez | 222862c | 2015-06-09 18:33:02 +0100 | [diff] [blame] | 324 | } |
Guillaume "Vermeille" Sanchez | af88835 | 2015-04-20 14:41:30 +0100 | [diff] [blame] | 325 | } |
| 326 | |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 327 | void InstructionSimplifierVisitor::VisitInstanceFieldSet(HInstanceFieldSet* instruction) { |
| 328 | if ((instruction->GetValue()->GetType() == Primitive::kPrimNot) |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 329 | && CanEnsureNotNullAt(instruction->GetValue(), instruction)) { |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 330 | instruction->ClearValueCanBeNull(); |
| 331 | } |
| 332 | } |
| 333 | |
| 334 | void InstructionSimplifierVisitor::VisitStaticFieldSet(HStaticFieldSet* instruction) { |
| 335 | if ((instruction->GetValue()->GetType() == Primitive::kPrimNot) |
Nicolas Geoffray | 6e7455e | 2015-09-28 16:25:37 +0100 | [diff] [blame] | 336 | && CanEnsureNotNullAt(instruction->GetValue(), instruction)) { |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 337 | instruction->ClearValueCanBeNull(); |
| 338 | } |
| 339 | } |
| 340 | |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 341 | void InstructionSimplifierVisitor::VisitSuspendCheck(HSuspendCheck* check) { |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 342 | HBasicBlock* block = check->GetBlock(); |
| 343 | // Currently always keep the suspend check at entry. |
| 344 | if (block->IsEntryBlock()) return; |
| 345 | |
| 346 | // Currently always keep suspend checks at loop entry. |
| 347 | if (block->IsLoopHeader() && block->GetFirstInstruction() == check) { |
| 348 | DCHECK(block->GetLoopInformation()->GetSuspendCheck() == check); |
| 349 | return; |
| 350 | } |
| 351 | |
| 352 | // Remove the suspend check that was added at build time for the baseline |
| 353 | // compiler. |
| 354 | block->RemoveInstruction(check); |
| 355 | } |
| 356 | |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 357 | void InstructionSimplifierVisitor::VisitEqual(HEqual* equal) { |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 358 | HInstruction* input_const = equal->GetConstantRight(); |
| 359 | if (input_const != nullptr) { |
| 360 | HInstruction* input_value = equal->GetLeastConstantLeft(); |
| 361 | if (input_value->GetType() == Primitive::kPrimBoolean && input_const->IsIntConstant()) { |
| 362 | HBasicBlock* block = equal->GetBlock(); |
Nicolas Geoffray | 3c4ab80 | 2015-06-19 11:42:07 +0100 | [diff] [blame] | 363 | // We are comparing the boolean to a constant which is of type int and can |
| 364 | // be any constant. |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 365 | if (input_const->AsIntConstant()->IsOne()) { |
| 366 | // Replace (bool_value == true) with bool_value |
| 367 | equal->ReplaceWith(input_value); |
| 368 | block->RemoveInstruction(equal); |
| 369 | RecordSimplification(); |
Nicolas Geoffray | 3c4ab80 | 2015-06-19 11:42:07 +0100 | [diff] [blame] | 370 | } else if (input_const->AsIntConstant()->IsZero()) { |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 371 | // Replace (bool_value == false) with !bool_value |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 372 | block->ReplaceAndRemoveInstructionWith( |
| 373 | equal, new (block->GetGraph()->GetArena()) HBooleanNot(input_value)); |
| 374 | RecordSimplification(); |
David Brazdil | 1e9ec05 | 2015-06-22 10:26:45 +0100 | [diff] [blame] | 375 | } else { |
| 376 | // Replace (bool_value == integer_not_zero_nor_one_constant) with false |
| 377 | equal->ReplaceWith(GetGraph()->GetIntConstant(0)); |
| 378 | block->RemoveInstruction(equal); |
| 379 | RecordSimplification(); |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 380 | } |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 381 | } else { |
| 382 | VisitCondition(equal); |
Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 383 | } |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 384 | } else { |
| 385 | VisitCondition(equal); |
Nicolas Geoffray | 01ef345 | 2014-10-01 11:32:17 +0100 | [diff] [blame] | 386 | } |
| 387 | } |
| 388 | |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 389 | void InstructionSimplifierVisitor::VisitNotEqual(HNotEqual* not_equal) { |
| 390 | HInstruction* input_const = not_equal->GetConstantRight(); |
| 391 | if (input_const != nullptr) { |
| 392 | HInstruction* input_value = not_equal->GetLeastConstantLeft(); |
| 393 | if (input_value->GetType() == Primitive::kPrimBoolean && input_const->IsIntConstant()) { |
| 394 | HBasicBlock* block = not_equal->GetBlock(); |
Nicolas Geoffray | 3c4ab80 | 2015-06-19 11:42:07 +0100 | [diff] [blame] | 395 | // We are comparing the boolean to a constant which is of type int and can |
| 396 | // be any constant. |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 397 | if (input_const->AsIntConstant()->IsOne()) { |
| 398 | // Replace (bool_value != true) with !bool_value |
| 399 | block->ReplaceAndRemoveInstructionWith( |
| 400 | not_equal, new (block->GetGraph()->GetArena()) HBooleanNot(input_value)); |
| 401 | RecordSimplification(); |
Nicolas Geoffray | 3c4ab80 | 2015-06-19 11:42:07 +0100 | [diff] [blame] | 402 | } else if (input_const->AsIntConstant()->IsZero()) { |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 403 | // Replace (bool_value != false) with bool_value |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 404 | not_equal->ReplaceWith(input_value); |
| 405 | block->RemoveInstruction(not_equal); |
| 406 | RecordSimplification(); |
David Brazdil | 1e9ec05 | 2015-06-22 10:26:45 +0100 | [diff] [blame] | 407 | } else { |
| 408 | // Replace (bool_value != integer_not_zero_nor_one_constant) with true |
| 409 | not_equal->ReplaceWith(GetGraph()->GetIntConstant(1)); |
| 410 | block->RemoveInstruction(not_equal); |
| 411 | RecordSimplification(); |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 412 | } |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 413 | } else { |
| 414 | VisitCondition(not_equal); |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 415 | } |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 416 | } else { |
| 417 | VisitCondition(not_equal); |
David Brazdil | 0d13fee | 2015-04-17 14:52:19 +0100 | [diff] [blame] | 418 | } |
| 419 | } |
| 420 | |
| 421 | void InstructionSimplifierVisitor::VisitBooleanNot(HBooleanNot* bool_not) { |
| 422 | HInstruction* parent = bool_not->InputAt(0); |
| 423 | if (parent->IsBooleanNot()) { |
| 424 | HInstruction* value = parent->InputAt(0); |
| 425 | // Replace (!(!bool_value)) with bool_value |
| 426 | bool_not->ReplaceWith(value); |
| 427 | bool_not->GetBlock()->RemoveInstruction(bool_not); |
| 428 | // It is possible that `parent` is dead at this point but we leave |
| 429 | // its removal to DCE for simplicity. |
| 430 | RecordSimplification(); |
| 431 | } |
| 432 | } |
| 433 | |
Mingyao Yang | 0304e18 | 2015-01-30 16:41:29 -0800 | [diff] [blame] | 434 | void InstructionSimplifierVisitor::VisitArrayLength(HArrayLength* instruction) { |
| 435 | HInstruction* input = instruction->InputAt(0); |
| 436 | // If the array is a NewArray with constant size, replace the array length |
| 437 | // with the constant instruction. This helps the bounds check elimination phase. |
| 438 | if (input->IsNewArray()) { |
| 439 | input = input->InputAt(0); |
| 440 | if (input->IsIntConstant()) { |
| 441 | instruction->ReplaceWith(input); |
| 442 | } |
| 443 | } |
| 444 | } |
| 445 | |
Nicolas Geoffray | 5e6916c | 2014-11-18 16:53:35 +0000 | [diff] [blame] | 446 | void InstructionSimplifierVisitor::VisitArraySet(HArraySet* instruction) { |
Nicolas Geoffray | af07bc1 | 2014-11-12 18:08:09 +0000 | [diff] [blame] | 447 | HInstruction* value = instruction->GetValue(); |
| 448 | if (value->GetType() != Primitive::kPrimNot) return; |
| 449 | |
Nicolas Geoffray | e0395dd | 2015-09-25 11:04:45 +0100 | [diff] [blame] | 450 | if (CanEnsureNotNullAt(value, instruction)) { |
| 451 | instruction->ClearValueCanBeNull(); |
| 452 | } |
| 453 | |
Nicolas Geoffray | af07bc1 | 2014-11-12 18:08:09 +0000 | [diff] [blame] | 454 | if (value->IsArrayGet()) { |
| 455 | if (value->AsArrayGet()->GetArray() == instruction->GetArray()) { |
| 456 | // If the code is just swapping elements in the array, no need for a type check. |
| 457 | instruction->ClearNeedsTypeCheck(); |
Nicolas Geoffray | e0395dd | 2015-09-25 11:04:45 +0100 | [diff] [blame] | 458 | return; |
Nicolas Geoffray | af07bc1 | 2014-11-12 18:08:09 +0000 | [diff] [blame] | 459 | } |
| 460 | } |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 461 | |
Nicolas Geoffray | 9fdb31e | 2015-07-01 12:56:46 +0100 | [diff] [blame] | 462 | if (value->IsNullConstant()) { |
| 463 | instruction->ClearNeedsTypeCheck(); |
Nicolas Geoffray | e0395dd | 2015-09-25 11:04:45 +0100 | [diff] [blame] | 464 | return; |
Nicolas Geoffray | 9fdb31e | 2015-07-01 12:56:46 +0100 | [diff] [blame] | 465 | } |
| 466 | |
Nicolas Geoffray | e0395dd | 2015-09-25 11:04:45 +0100 | [diff] [blame] | 467 | ScopedObjectAccess soa(Thread::Current()); |
| 468 | ReferenceTypeInfo array_rti = instruction->GetArray()->GetReferenceTypeInfo(); |
| 469 | ReferenceTypeInfo value_rti = value->GetReferenceTypeInfo(); |
| 470 | if (!array_rti.IsValid()) { |
| 471 | return; |
| 472 | } |
| 473 | |
| 474 | if (value_rti.IsValid() && array_rti.CanArrayHold(value_rti)) { |
| 475 | instruction->ClearNeedsTypeCheck(); |
| 476 | return; |
| 477 | } |
| 478 | |
| 479 | if (array_rti.IsObjectArray()) { |
| 480 | if (array_rti.IsExact()) { |
| 481 | instruction->ClearNeedsTypeCheck(); |
| 482 | return; |
| 483 | } |
| 484 | instruction->SetStaticTypeOfArrayIsObjectArray(); |
Nicolas Geoffray | 07276db | 2015-05-18 14:22:09 +0100 | [diff] [blame] | 485 | } |
Nicolas Geoffray | af07bc1 | 2014-11-12 18:08:09 +0000 | [diff] [blame] | 486 | } |
| 487 | |
Nicolas Geoffray | 01fcc9e | 2014-12-01 14:16:20 +0000 | [diff] [blame] | 488 | void InstructionSimplifierVisitor::VisitTypeConversion(HTypeConversion* instruction) { |
| 489 | if (instruction->GetResultType() == instruction->GetInputType()) { |
| 490 | // Remove the instruction if it's converting to the same type. |
| 491 | instruction->ReplaceWith(instruction->GetInput()); |
| 492 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 493 | } |
| 494 | } |
| 495 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 496 | void InstructionSimplifierVisitor::VisitAdd(HAdd* instruction) { |
| 497 | HConstant* input_cst = instruction->GetConstantRight(); |
| 498 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 499 | if ((input_cst != nullptr) && input_cst->IsZero()) { |
| 500 | // Replace code looking like |
| 501 | // ADD dst, src, 0 |
| 502 | // with |
| 503 | // src |
Serguei Katkov | 115b53f | 2015-08-05 17:03:30 +0600 | [diff] [blame] | 504 | // Note that we cannot optimize `x + 0.0` to `x` for floating-point. When |
| 505 | // `x` is `-0.0`, the former expression yields `0.0`, while the later |
| 506 | // yields `-0.0`. |
| 507 | if (Primitive::IsIntegralType(instruction->GetType())) { |
| 508 | instruction->ReplaceWith(input_other); |
| 509 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 510 | return; |
| 511 | } |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 512 | } |
| 513 | |
| 514 | HInstruction* left = instruction->GetLeft(); |
| 515 | HInstruction* right = instruction->GetRight(); |
| 516 | bool left_is_neg = left->IsNeg(); |
| 517 | bool right_is_neg = right->IsNeg(); |
| 518 | |
| 519 | if (left_is_neg && right_is_neg) { |
| 520 | if (TryMoveNegOnInputsAfterBinop(instruction)) { |
| 521 | return; |
| 522 | } |
| 523 | } |
| 524 | |
| 525 | HNeg* neg = left_is_neg ? left->AsNeg() : right->AsNeg(); |
| 526 | if ((left_is_neg ^ right_is_neg) && neg->HasOnlyOneNonEnvironmentUse()) { |
| 527 | // Replace code looking like |
| 528 | // NEG tmp, b |
| 529 | // ADD dst, a, tmp |
| 530 | // with |
| 531 | // SUB dst, a, b |
| 532 | // We do not perform the optimization if the input negation has environment |
| 533 | // uses or multiple non-environment uses as it could lead to worse code. In |
| 534 | // particular, we do not want the live range of `b` to be extended if we are |
| 535 | // not sure the initial 'NEG' instruction can be removed. |
| 536 | HInstruction* other = left_is_neg ? right : left; |
| 537 | HSub* sub = new(GetGraph()->GetArena()) HSub(instruction->GetType(), other, neg->GetInput()); |
| 538 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, sub); |
| 539 | RecordSimplification(); |
| 540 | neg->GetBlock()->RemoveInstruction(neg); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 541 | } |
| 542 | } |
| 543 | |
| 544 | void InstructionSimplifierVisitor::VisitAnd(HAnd* instruction) { |
| 545 | HConstant* input_cst = instruction->GetConstantRight(); |
| 546 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 547 | |
Vladimir Marko | 452c1b6 | 2015-09-25 14:44:17 +0100 | [diff] [blame] | 548 | if (input_cst != nullptr) { |
| 549 | int64_t value = Int64FromConstant(input_cst); |
| 550 | if (value == -1) { |
| 551 | // Replace code looking like |
| 552 | // AND dst, src, 0xFFF...FF |
| 553 | // with |
| 554 | // src |
| 555 | instruction->ReplaceWith(input_other); |
| 556 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 557 | RecordSimplification(); |
| 558 | return; |
| 559 | } |
| 560 | // Eliminate And from UShr+And if the And-mask contains all the bits that |
| 561 | // can be non-zero after UShr. Transform Shr+And to UShr if the And-mask |
| 562 | // precisely clears the shifted-in sign bits. |
| 563 | if ((input_other->IsUShr() || input_other->IsShr()) && input_other->InputAt(1)->IsConstant()) { |
| 564 | size_t reg_bits = (instruction->GetResultType() == Primitive::kPrimLong) ? 64 : 32; |
| 565 | size_t shift = Int64FromConstant(input_other->InputAt(1)->AsConstant()) & (reg_bits - 1); |
| 566 | size_t num_tail_bits_set = CTZ(value + 1); |
| 567 | if ((num_tail_bits_set >= reg_bits - shift) && input_other->IsUShr()) { |
| 568 | // This AND clears only bits known to be clear, for example "(x >>> 24) & 0xff". |
| 569 | instruction->ReplaceWith(input_other); |
| 570 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 571 | RecordSimplification(); |
| 572 | return; |
| 573 | } else if ((num_tail_bits_set == reg_bits - shift) && IsPowerOfTwo(value + 1) && |
| 574 | input_other->HasOnlyOneNonEnvironmentUse()) { |
| 575 | DCHECK(input_other->IsShr()); // For UShr, we would have taken the branch above. |
| 576 | // Replace SHR+AND with USHR, for example "(x >> 24) & 0xff" -> "x >>> 24". |
| 577 | HUShr* ushr = new (GetGraph()->GetArena()) HUShr(instruction->GetType(), |
| 578 | input_other->InputAt(0), |
| 579 | input_other->InputAt(1), |
| 580 | input_other->GetDexPc()); |
| 581 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, ushr); |
| 582 | input_other->GetBlock()->RemoveInstruction(input_other); |
| 583 | RecordSimplification(); |
| 584 | return; |
| 585 | } |
| 586 | } |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 587 | } |
| 588 | |
| 589 | // We assume that GVN has run before, so we only perform a pointer comparison. |
| 590 | // If for some reason the values are equal but the pointers are different, we |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 591 | // are still correct and only miss an optimization opportunity. |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 592 | if (instruction->GetLeft() == instruction->GetRight()) { |
| 593 | // Replace code looking like |
| 594 | // AND dst, src, src |
| 595 | // with |
| 596 | // src |
| 597 | instruction->ReplaceWith(instruction->GetLeft()); |
| 598 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 599 | } |
| 600 | } |
| 601 | |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 602 | void InstructionSimplifierVisitor::VisitGreaterThan(HGreaterThan* condition) { |
| 603 | VisitCondition(condition); |
| 604 | } |
| 605 | |
| 606 | void InstructionSimplifierVisitor::VisitGreaterThanOrEqual(HGreaterThanOrEqual* condition) { |
| 607 | VisitCondition(condition); |
| 608 | } |
| 609 | |
| 610 | void InstructionSimplifierVisitor::VisitLessThan(HLessThan* condition) { |
| 611 | VisitCondition(condition); |
| 612 | } |
| 613 | |
| 614 | void InstructionSimplifierVisitor::VisitLessThanOrEqual(HLessThanOrEqual* condition) { |
| 615 | VisitCondition(condition); |
| 616 | } |
| 617 | |
| 618 | void InstructionSimplifierVisitor::VisitCondition(HCondition* condition) { |
| 619 | // Try to fold an HCompare into this HCondition. |
| 620 | |
Roland Levillain | 7f63c52 | 2015-07-13 15:54:55 +0000 | [diff] [blame] | 621 | // This simplification is currently supported on x86, x86_64, ARM and ARM64. |
| 622 | // TODO: Implement it for MIPS64. |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 623 | InstructionSet instruction_set = GetGraph()->GetInstructionSet(); |
Roland Levillain | 7f63c52 | 2015-07-13 15:54:55 +0000 | [diff] [blame] | 624 | if (instruction_set == kMips64) { |
Mark Mendell | c470193 | 2015-04-10 13:18:51 -0400 | [diff] [blame] | 625 | return; |
| 626 | } |
| 627 | |
| 628 | HInstruction* left = condition->GetLeft(); |
| 629 | HInstruction* right = condition->GetRight(); |
| 630 | // We can only replace an HCondition which compares a Compare to 0. |
| 631 | // Both 'dx' and 'jack' generate a compare to 0 when compiling a |
| 632 | // condition with a long, float or double comparison as input. |
| 633 | if (!left->IsCompare() || !right->IsConstant() || right->AsIntConstant()->GetValue() != 0) { |
| 634 | // Conversion is not possible. |
| 635 | return; |
| 636 | } |
| 637 | |
| 638 | // Is the Compare only used for this purpose? |
| 639 | if (!left->GetUses().HasOnlyOneUse()) { |
| 640 | // Someone else also wants the result of the compare. |
| 641 | return; |
| 642 | } |
| 643 | |
| 644 | if (!left->GetEnvUses().IsEmpty()) { |
| 645 | // There is a reference to the compare result in an environment. Do we really need it? |
| 646 | if (GetGraph()->IsDebuggable()) { |
| 647 | return; |
| 648 | } |
| 649 | |
| 650 | // We have to ensure that there are no deopt points in the sequence. |
| 651 | if (left->HasAnyEnvironmentUseBefore(condition)) { |
| 652 | return; |
| 653 | } |
| 654 | } |
| 655 | |
| 656 | // Clean up any environment uses from the HCompare, if any. |
| 657 | left->RemoveEnvironmentUsers(); |
| 658 | |
| 659 | // We have decided to fold the HCompare into the HCondition. Transfer the information. |
| 660 | condition->SetBias(left->AsCompare()->GetBias()); |
| 661 | |
| 662 | // Replace the operands of the HCondition. |
| 663 | condition->ReplaceInput(left->InputAt(0), 0); |
| 664 | condition->ReplaceInput(left->InputAt(1), 1); |
| 665 | |
| 666 | // Remove the HCompare. |
| 667 | left->GetBlock()->RemoveInstruction(left); |
| 668 | |
| 669 | RecordSimplification(); |
| 670 | } |
| 671 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 672 | void InstructionSimplifierVisitor::VisitDiv(HDiv* instruction) { |
| 673 | HConstant* input_cst = instruction->GetConstantRight(); |
| 674 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 675 | Primitive::Type type = instruction->GetType(); |
| 676 | |
| 677 | if ((input_cst != nullptr) && input_cst->IsOne()) { |
| 678 | // Replace code looking like |
| 679 | // DIV dst, src, 1 |
| 680 | // with |
| 681 | // src |
| 682 | instruction->ReplaceWith(input_other); |
| 683 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 684 | return; |
| 685 | } |
| 686 | |
Nicolas Geoffray | 0d22184 | 2015-04-27 08:53:46 +0000 | [diff] [blame] | 687 | if ((input_cst != nullptr) && input_cst->IsMinusOne()) { |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 688 | // Replace code looking like |
| 689 | // DIV dst, src, -1 |
| 690 | // with |
| 691 | // NEG dst, src |
| 692 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith( |
Nicolas Geoffray | 0d22184 | 2015-04-27 08:53:46 +0000 | [diff] [blame] | 693 | instruction, new (GetGraph()->GetArena()) HNeg(type, input_other)); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 694 | RecordSimplification(); |
Nicolas Geoffray | 0d22184 | 2015-04-27 08:53:46 +0000 | [diff] [blame] | 695 | return; |
| 696 | } |
| 697 | |
| 698 | if ((input_cst != nullptr) && Primitive::IsFloatingPointType(type)) { |
| 699 | // Try replacing code looking like |
| 700 | // DIV dst, src, constant |
| 701 | // with |
| 702 | // MUL dst, src, 1 / constant |
| 703 | HConstant* reciprocal = nullptr; |
| 704 | if (type == Primitive::Primitive::kPrimDouble) { |
| 705 | double value = input_cst->AsDoubleConstant()->GetValue(); |
| 706 | if (CanDivideByReciprocalMultiplyDouble(bit_cast<int64_t, double>(value))) { |
| 707 | reciprocal = GetGraph()->GetDoubleConstant(1.0 / value); |
| 708 | } |
| 709 | } else { |
| 710 | DCHECK_EQ(type, Primitive::kPrimFloat); |
| 711 | float value = input_cst->AsFloatConstant()->GetValue(); |
| 712 | if (CanDivideByReciprocalMultiplyFloat(bit_cast<int32_t, float>(value))) { |
| 713 | reciprocal = GetGraph()->GetFloatConstant(1.0f / value); |
| 714 | } |
| 715 | } |
| 716 | |
| 717 | if (reciprocal != nullptr) { |
| 718 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith( |
| 719 | instruction, new (GetGraph()->GetArena()) HMul(type, input_other, reciprocal)); |
| 720 | RecordSimplification(); |
| 721 | return; |
| 722 | } |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 723 | } |
| 724 | } |
| 725 | |
| 726 | void InstructionSimplifierVisitor::VisitMul(HMul* instruction) { |
| 727 | HConstant* input_cst = instruction->GetConstantRight(); |
| 728 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 729 | Primitive::Type type = instruction->GetType(); |
| 730 | HBasicBlock* block = instruction->GetBlock(); |
| 731 | ArenaAllocator* allocator = GetGraph()->GetArena(); |
| 732 | |
| 733 | if (input_cst == nullptr) { |
| 734 | return; |
| 735 | } |
| 736 | |
| 737 | if (input_cst->IsOne()) { |
| 738 | // Replace code looking like |
| 739 | // MUL dst, src, 1 |
| 740 | // with |
| 741 | // src |
| 742 | instruction->ReplaceWith(input_other); |
| 743 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 744 | return; |
| 745 | } |
| 746 | |
| 747 | if (input_cst->IsMinusOne() && |
| 748 | (Primitive::IsFloatingPointType(type) || Primitive::IsIntOrLongType(type))) { |
| 749 | // Replace code looking like |
| 750 | // MUL dst, src, -1 |
| 751 | // with |
| 752 | // NEG dst, src |
| 753 | HNeg* neg = new (allocator) HNeg(type, input_other); |
| 754 | block->ReplaceAndRemoveInstructionWith(instruction, neg); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 755 | RecordSimplification(); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 756 | return; |
| 757 | } |
| 758 | |
| 759 | if (Primitive::IsFloatingPointType(type) && |
| 760 | ((input_cst->IsFloatConstant() && input_cst->AsFloatConstant()->GetValue() == 2.0f) || |
| 761 | (input_cst->IsDoubleConstant() && input_cst->AsDoubleConstant()->GetValue() == 2.0))) { |
| 762 | // Replace code looking like |
| 763 | // FP_MUL dst, src, 2.0 |
| 764 | // with |
| 765 | // FP_ADD dst, src, src |
| 766 | // The 'int' and 'long' cases are handled below. |
| 767 | block->ReplaceAndRemoveInstructionWith(instruction, |
| 768 | new (allocator) HAdd(type, input_other, input_other)); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 769 | RecordSimplification(); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 770 | return; |
| 771 | } |
| 772 | |
| 773 | if (Primitive::IsIntOrLongType(type)) { |
| 774 | int64_t factor = Int64FromConstant(input_cst); |
Serguei Katkov | 5384919 | 2015-04-20 14:22:27 +0600 | [diff] [blame] | 775 | // Even though constant propagation also takes care of the zero case, other |
| 776 | // optimizations can lead to having a zero multiplication. |
| 777 | if (factor == 0) { |
| 778 | // Replace code looking like |
| 779 | // MUL dst, src, 0 |
| 780 | // with |
| 781 | // 0 |
| 782 | instruction->ReplaceWith(input_cst); |
| 783 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 784 | } else if (IsPowerOfTwo(factor)) { |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 785 | // Replace code looking like |
| 786 | // MUL dst, src, pow_of_2 |
| 787 | // with |
| 788 | // SHL dst, src, log2(pow_of_2) |
David Brazdil | 8d5b8b2 | 2015-03-24 10:51:52 +0000 | [diff] [blame] | 789 | HIntConstant* shift = GetGraph()->GetIntConstant(WhichPowerOf2(factor)); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 790 | HShl* shl = new(allocator) HShl(type, input_other, shift); |
| 791 | block->ReplaceAndRemoveInstructionWith(instruction, shl); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 792 | RecordSimplification(); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 793 | } |
| 794 | } |
| 795 | } |
| 796 | |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 797 | void InstructionSimplifierVisitor::VisitNeg(HNeg* instruction) { |
| 798 | HInstruction* input = instruction->GetInput(); |
| 799 | if (input->IsNeg()) { |
| 800 | // Replace code looking like |
| 801 | // NEG tmp, src |
| 802 | // NEG dst, tmp |
| 803 | // with |
| 804 | // src |
| 805 | HNeg* previous_neg = input->AsNeg(); |
| 806 | instruction->ReplaceWith(previous_neg->GetInput()); |
| 807 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 808 | // We perform the optimization even if the input negation has environment |
| 809 | // uses since it allows removing the current instruction. But we only delete |
| 810 | // the input negation only if it is does not have any uses left. |
| 811 | if (!previous_neg->HasUses()) { |
| 812 | previous_neg->GetBlock()->RemoveInstruction(previous_neg); |
| 813 | } |
| 814 | RecordSimplification(); |
| 815 | return; |
| 816 | } |
| 817 | |
Serguei Katkov | 339dfc2 | 2015-04-20 12:29:32 +0600 | [diff] [blame] | 818 | if (input->IsSub() && input->HasOnlyOneNonEnvironmentUse() && |
| 819 | !Primitive::IsFloatingPointType(input->GetType())) { |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 820 | // Replace code looking like |
| 821 | // SUB tmp, a, b |
| 822 | // NEG dst, tmp |
| 823 | // with |
| 824 | // SUB dst, b, a |
| 825 | // We do not perform the optimization if the input subtraction has |
| 826 | // environment uses or multiple non-environment uses as it could lead to |
| 827 | // worse code. In particular, we do not want the live ranges of `a` and `b` |
| 828 | // to be extended if we are not sure the initial 'SUB' instruction can be |
| 829 | // removed. |
Serguei Katkov | 339dfc2 | 2015-04-20 12:29:32 +0600 | [diff] [blame] | 830 | // We do not perform optimization for fp because we could lose the sign of zero. |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 831 | HSub* sub = input->AsSub(); |
| 832 | HSub* new_sub = |
| 833 | new (GetGraph()->GetArena()) HSub(instruction->GetType(), sub->GetRight(), sub->GetLeft()); |
| 834 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, new_sub); |
| 835 | if (!sub->HasUses()) { |
| 836 | sub->GetBlock()->RemoveInstruction(sub); |
| 837 | } |
| 838 | RecordSimplification(); |
| 839 | } |
| 840 | } |
| 841 | |
| 842 | void InstructionSimplifierVisitor::VisitNot(HNot* instruction) { |
| 843 | HInstruction* input = instruction->GetInput(); |
| 844 | if (input->IsNot()) { |
| 845 | // Replace code looking like |
| 846 | // NOT tmp, src |
| 847 | // NOT dst, tmp |
| 848 | // with |
| 849 | // src |
| 850 | // We perform the optimization even if the input negation has environment |
| 851 | // uses since it allows removing the current instruction. But we only delete |
| 852 | // the input negation only if it is does not have any uses left. |
| 853 | HNot* previous_not = input->AsNot(); |
| 854 | instruction->ReplaceWith(previous_not->GetInput()); |
| 855 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 856 | if (!previous_not->HasUses()) { |
| 857 | previous_not->GetBlock()->RemoveInstruction(previous_not); |
| 858 | } |
| 859 | RecordSimplification(); |
| 860 | } |
| 861 | } |
| 862 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 863 | void InstructionSimplifierVisitor::VisitOr(HOr* instruction) { |
| 864 | HConstant* input_cst = instruction->GetConstantRight(); |
| 865 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 866 | |
| 867 | if ((input_cst != nullptr) && input_cst->IsZero()) { |
| 868 | // Replace code looking like |
| 869 | // OR dst, src, 0 |
| 870 | // with |
| 871 | // src |
| 872 | instruction->ReplaceWith(input_other); |
| 873 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 874 | return; |
| 875 | } |
| 876 | |
| 877 | // We assume that GVN has run before, so we only perform a pointer comparison. |
| 878 | // If for some reason the values are equal but the pointers are different, we |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 879 | // are still correct and only miss an optimization opportunity. |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 880 | if (instruction->GetLeft() == instruction->GetRight()) { |
| 881 | // Replace code looking like |
| 882 | // OR dst, src, src |
| 883 | // with |
| 884 | // src |
| 885 | instruction->ReplaceWith(instruction->GetLeft()); |
| 886 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 887 | } |
| 888 | } |
| 889 | |
| 890 | void InstructionSimplifierVisitor::VisitShl(HShl* instruction) { |
| 891 | VisitShift(instruction); |
| 892 | } |
| 893 | |
| 894 | void InstructionSimplifierVisitor::VisitShr(HShr* instruction) { |
| 895 | VisitShift(instruction); |
| 896 | } |
| 897 | |
| 898 | void InstructionSimplifierVisitor::VisitSub(HSub* instruction) { |
| 899 | HConstant* input_cst = instruction->GetConstantRight(); |
| 900 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 901 | |
Serguei Katkov | 115b53f | 2015-08-05 17:03:30 +0600 | [diff] [blame] | 902 | Primitive::Type type = instruction->GetType(); |
| 903 | if (Primitive::IsFloatingPointType(type)) { |
| 904 | return; |
| 905 | } |
| 906 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 907 | if ((input_cst != nullptr) && input_cst->IsZero()) { |
| 908 | // Replace code looking like |
| 909 | // SUB dst, src, 0 |
| 910 | // with |
| 911 | // src |
Serguei Katkov | 115b53f | 2015-08-05 17:03:30 +0600 | [diff] [blame] | 912 | // Note that we cannot optimize `x - 0.0` to `x` for floating-point. When |
| 913 | // `x` is `-0.0`, the former expression yields `0.0`, while the later |
| 914 | // yields `-0.0`. |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 915 | instruction->ReplaceWith(input_other); |
| 916 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 917 | return; |
| 918 | } |
| 919 | |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 920 | HBasicBlock* block = instruction->GetBlock(); |
| 921 | ArenaAllocator* allocator = GetGraph()->GetArena(); |
| 922 | |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 923 | HInstruction* left = instruction->GetLeft(); |
| 924 | HInstruction* right = instruction->GetRight(); |
| 925 | if (left->IsConstant()) { |
| 926 | if (Int64FromConstant(left->AsConstant()) == 0) { |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 927 | // Replace code looking like |
| 928 | // SUB dst, 0, src |
| 929 | // with |
| 930 | // NEG dst, src |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 931 | // Note that we cannot optimize `0.0 - x` to `-x` for floating-point. When |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 932 | // `x` is `0.0`, the former expression yields `0.0`, while the later |
| 933 | // yields `-0.0`. |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 934 | HNeg* neg = new (allocator) HNeg(type, right); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 935 | block->ReplaceAndRemoveInstructionWith(instruction, neg); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 936 | RecordSimplification(); |
| 937 | return; |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 938 | } |
| 939 | } |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 940 | |
| 941 | if (left->IsNeg() && right->IsNeg()) { |
| 942 | if (TryMoveNegOnInputsAfterBinop(instruction)) { |
| 943 | return; |
| 944 | } |
| 945 | } |
| 946 | |
| 947 | if (right->IsNeg() && right->HasOnlyOneNonEnvironmentUse()) { |
| 948 | // Replace code looking like |
| 949 | // NEG tmp, b |
| 950 | // SUB dst, a, tmp |
| 951 | // with |
| 952 | // ADD dst, a, b |
| 953 | HAdd* add = new(GetGraph()->GetArena()) HAdd(type, left, right->AsNeg()->GetInput()); |
| 954 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, add); |
| 955 | RecordSimplification(); |
| 956 | right->GetBlock()->RemoveInstruction(right); |
| 957 | return; |
| 958 | } |
| 959 | |
| 960 | if (left->IsNeg() && left->HasOnlyOneNonEnvironmentUse()) { |
| 961 | // Replace code looking like |
| 962 | // NEG tmp, a |
| 963 | // SUB dst, tmp, b |
| 964 | // with |
| 965 | // ADD tmp, a, b |
| 966 | // NEG dst, tmp |
| 967 | // The second version is not intrinsically better, but enables more |
| 968 | // transformations. |
| 969 | HAdd* add = new(GetGraph()->GetArena()) HAdd(type, left->AsNeg()->GetInput(), right); |
| 970 | instruction->GetBlock()->InsertInstructionBefore(add, instruction); |
| 971 | HNeg* neg = new (GetGraph()->GetArena()) HNeg(instruction->GetType(), add); |
| 972 | instruction->GetBlock()->InsertInstructionBefore(neg, instruction); |
| 973 | instruction->ReplaceWith(neg); |
| 974 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 975 | RecordSimplification(); |
| 976 | left->GetBlock()->RemoveInstruction(left); |
| 977 | } |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 978 | } |
| 979 | |
| 980 | void InstructionSimplifierVisitor::VisitUShr(HUShr* instruction) { |
| 981 | VisitShift(instruction); |
| 982 | } |
| 983 | |
| 984 | void InstructionSimplifierVisitor::VisitXor(HXor* instruction) { |
| 985 | HConstant* input_cst = instruction->GetConstantRight(); |
| 986 | HInstruction* input_other = instruction->GetLeastConstantLeft(); |
| 987 | |
| 988 | if ((input_cst != nullptr) && input_cst->IsZero()) { |
| 989 | // Replace code looking like |
| 990 | // XOR dst, src, 0 |
| 991 | // with |
| 992 | // src |
| 993 | instruction->ReplaceWith(input_other); |
| 994 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 995 | return; |
| 996 | } |
| 997 | |
| 998 | if ((input_cst != nullptr) && AreAllBitsSet(input_cst)) { |
| 999 | // Replace code looking like |
| 1000 | // XOR dst, src, 0xFFF...FF |
| 1001 | // with |
| 1002 | // NOT dst, src |
| 1003 | HNot* bitwise_not = new (GetGraph()->GetArena()) HNot(instruction->GetType(), input_other); |
| 1004 | instruction->GetBlock()->ReplaceAndRemoveInstructionWith(instruction, bitwise_not); |
Alexandre Rames | 188d431 | 2015-04-09 18:30:21 +0100 | [diff] [blame] | 1005 | RecordSimplification(); |
Alexandre Rames | b2fd7bc | 2015-03-11 16:48:16 +0000 | [diff] [blame] | 1006 | return; |
| 1007 | } |
| 1008 | } |
| 1009 | |
Nicolas Geoffray | 2e7cd75 | 2015-07-10 11:38:52 +0100 | [diff] [blame] | 1010 | void InstructionSimplifierVisitor::VisitFakeString(HFakeString* instruction) { |
| 1011 | HInstruction* actual_string = nullptr; |
| 1012 | |
| 1013 | // Find the string we need to replace this instruction with. The actual string is |
| 1014 | // the return value of a StringFactory call. |
| 1015 | for (HUseIterator<HInstruction*> it(instruction->GetUses()); !it.Done(); it.Advance()) { |
| 1016 | HInstruction* use = it.Current()->GetUser(); |
| 1017 | if (use->IsInvokeStaticOrDirect() |
| 1018 | && use->AsInvokeStaticOrDirect()->IsStringFactoryFor(instruction)) { |
| 1019 | use->AsInvokeStaticOrDirect()->RemoveFakeStringArgumentAsLastInput(); |
| 1020 | actual_string = use; |
| 1021 | break; |
| 1022 | } |
| 1023 | } |
| 1024 | |
| 1025 | // Check that there is no other instruction that thinks it is the factory for that string. |
| 1026 | if (kIsDebugBuild) { |
| 1027 | CHECK(actual_string != nullptr); |
| 1028 | for (HUseIterator<HInstruction*> it(instruction->GetUses()); !it.Done(); it.Advance()) { |
| 1029 | HInstruction* use = it.Current()->GetUser(); |
| 1030 | if (use->IsInvokeStaticOrDirect()) { |
| 1031 | CHECK(!use->AsInvokeStaticOrDirect()->IsStringFactoryFor(instruction)); |
| 1032 | } |
| 1033 | } |
| 1034 | } |
| 1035 | |
| 1036 | // We need to remove any environment uses of the fake string that are not dominated by |
| 1037 | // `actual_string` to null. |
| 1038 | for (HUseIterator<HEnvironment*> it(instruction->GetEnvUses()); !it.Done(); it.Advance()) { |
| 1039 | HEnvironment* environment = it.Current()->GetUser(); |
| 1040 | if (!actual_string->StrictlyDominates(environment->GetHolder())) { |
| 1041 | environment->RemoveAsUserOfInput(it.Current()->GetIndex()); |
| 1042 | environment->SetRawEnvAt(it.Current()->GetIndex(), nullptr); |
| 1043 | } |
| 1044 | } |
| 1045 | |
| 1046 | // Only uses dominated by `actual_string` must remain. We can safely replace and remove |
| 1047 | // `instruction`. |
| 1048 | instruction->ReplaceWith(actual_string); |
| 1049 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 1050 | } |
| 1051 | |
Nicolas Geoffray | a83a54d | 2015-10-02 17:30:26 +0100 | [diff] [blame] | 1052 | void InstructionSimplifierVisitor::VisitInvoke(HInvoke* instruction) { |
| 1053 | if (instruction->GetIntrinsic() == Intrinsics::kStringEquals) { |
| 1054 | HInstruction* argument = instruction->InputAt(1); |
| 1055 | HInstruction* receiver = instruction->InputAt(0); |
| 1056 | if (receiver == argument) { |
| 1057 | // Because String.equals is an instance call, the receiver is |
| 1058 | // a null check if we don't know it's null. The argument however, will |
| 1059 | // be the actual object. So we cannot end up in a situation where both |
| 1060 | // are equal but could be null. |
| 1061 | DCHECK(CanEnsureNotNullAt(argument, instruction)); |
| 1062 | instruction->ReplaceWith(GetGraph()->GetIntConstant(1)); |
| 1063 | instruction->GetBlock()->RemoveInstruction(instruction); |
| 1064 | } else { |
| 1065 | StringEqualsOptimizations optimizations(instruction); |
| 1066 | if (CanEnsureNotNullAt(argument, instruction)) { |
| 1067 | optimizations.SetArgumentNotNull(); |
| 1068 | } |
| 1069 | ScopedObjectAccess soa(Thread::Current()); |
| 1070 | if (argument->GetReferenceTypeInfo().IsStringClass()) { |
| 1071 | optimizations.SetArgumentIsString(); |
| 1072 | } |
| 1073 | } |
| 1074 | } |
| 1075 | } |
| 1076 | |
Nicolas Geoffray | 3c04974 | 2014-09-24 18:10:46 +0100 | [diff] [blame] | 1077 | } // namespace art |