blob: 8a009cb3e54266e06e63cc622999f3a06d004ed7 [file] [log] [blame]
Vladimir Markoc7f83202014-01-24 17:55:18 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "verified_method.h"
18
19#include <algorithm>
Ian Rogers700a4022014-05-19 16:49:03 -070020#include <memory>
Vladimir Markoc7f83202014-01-24 17:55:18 +000021#include <vector>
22
Mathieu Chartiere401d142015-04-22 13:56:20 -070023#include "art_method-inl.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000024#include "base/logging.h"
25#include "base/stl_util.h"
26#include "dex_file.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000027#include "dex_instruction-inl.h"
Mathieu Chartiere5f13e52015-02-24 09:37:21 -080028#include "dex_instruction_utils.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000029#include "mirror/class-inl.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000030#include "mirror/dex_cache-inl.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000031#include "mirror/object-inl.h"
Andreas Gampe0b9203e2015-01-22 20:39:27 -080032#include "utils.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000033#include "verifier/dex_gc_map.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000034#include "verifier/method_verifier-inl.h"
Ian Rogers7b078e82014-09-10 14:44:24 -070035#include "verifier/reg_type-inl.h"
Vladimir Markoc7f83202014-01-24 17:55:18 +000036#include "verifier/register_line-inl.h"
37
38namespace art {
39
40const VerifiedMethod* VerifiedMethod::Create(verifier::MethodVerifier* method_verifier,
41 bool compile) {
Ian Rogers700a4022014-05-19 16:49:03 -070042 std::unique_ptr<VerifiedMethod> verified_method(new VerifiedMethod);
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010043 verified_method->has_verification_failures_ = method_verifier->HasFailures();
Vladimir Markoc7f83202014-01-24 17:55:18 +000044 if (compile) {
45 /* Generate a register map. */
46 if (!verified_method->GenerateGcMap(method_verifier)) {
Vladimir Markoc7f83202014-01-24 17:55:18 +000047 return nullptr; // Not a real failure, but a failure to encode.
48 }
49 if (kIsDebugBuild) {
50 VerifyGcMap(method_verifier, verified_method->dex_gc_map_);
51 }
52
53 // TODO: move this out when DEX-to-DEX supports devirtualization.
54 if (method_verifier->HasVirtualOrInterfaceInvokes()) {
55 verified_method->GenerateDevirtMap(method_verifier);
56 }
Mathieu Chartiere5f13e52015-02-24 09:37:21 -080057
58 // Only need dequicken info for JIT so far.
Mathieu Chartier091d2382015-03-06 10:59:06 -080059 if (Runtime::Current()->UseJit() && !verified_method->GenerateDequickenMap(method_verifier)) {
60 return nullptr;
Mathieu Chartiere5f13e52015-02-24 09:37:21 -080061 }
Vladimir Markoc7f83202014-01-24 17:55:18 +000062 }
63
64 if (method_verifier->HasCheckCasts()) {
65 verified_method->GenerateSafeCastSet(method_verifier);
66 }
Jeff Hao848f70a2014-01-15 13:49:50 -080067
68 verified_method->SetStringInitPcRegMap(method_verifier->GetStringInitPcRegMap());
69
Vladimir Markoc7f83202014-01-24 17:55:18 +000070 return verified_method.release();
71}
72
73const MethodReference* VerifiedMethod::GetDevirtTarget(uint32_t dex_pc) const {
74 auto it = devirt_map_.find(dex_pc);
75 return (it != devirt_map_.end()) ? &it->second : nullptr;
76}
77
Mathieu Chartiere5f13e52015-02-24 09:37:21 -080078const DexFileReference* VerifiedMethod::GetDequickenIndex(uint32_t dex_pc) const {
79 DCHECK(Runtime::Current()->UseJit());
80 auto it = dequicken_map_.find(dex_pc);
81 return (it != dequicken_map_.end()) ? &it->second : nullptr;
82}
83
Vladimir Markoc7f83202014-01-24 17:55:18 +000084bool VerifiedMethod::IsSafeCast(uint32_t pc) const {
85 return std::binary_search(safe_cast_set_.begin(), safe_cast_set_.end(), pc);
86}
87
88bool VerifiedMethod::GenerateGcMap(verifier::MethodVerifier* method_verifier) {
89 DCHECK(dex_gc_map_.empty());
90 size_t num_entries, ref_bitmap_bits, pc_bits;
91 ComputeGcMapSizes(method_verifier, &num_entries, &ref_bitmap_bits, &pc_bits);
Mathieu Chartierf8da1962015-06-19 13:55:27 -070092 const size_t ref_bitmap_bytes = RoundUp(ref_bitmap_bits, kBitsPerByte) / kBitsPerByte;
93 static constexpr size_t kFormatBits = 3;
94 // We have 16 - kFormatBits available for the ref_bitmap_bytes.
95 if ((ref_bitmap_bytes >> (16u - kFormatBits)) != 0) {
Andreas Gampe6c170c92014-12-17 14:35:46 -080096 LOG(WARNING) << "Cannot encode GC map for method with " << ref_bitmap_bits << " registers: "
97 << PrettyMethod(method_verifier->GetMethodReference().dex_method_index,
98 *method_verifier->GetMethodReference().dex_file);
Vladimir Markoc7f83202014-01-24 17:55:18 +000099 return false;
100 }
Vladimir Markoc7f83202014-01-24 17:55:18 +0000101 // There are 2 bytes to encode the number of entries.
Igor Murashkinc449e8b2015-06-10 15:56:42 -0700102 if (num_entries > std::numeric_limits<uint16_t>::max()) {
Andreas Gampe6c170c92014-12-17 14:35:46 -0800103 LOG(WARNING) << "Cannot encode GC map for method with " << num_entries << " entries: "
104 << PrettyMethod(method_verifier->GetMethodReference().dex_method_index,
105 *method_verifier->GetMethodReference().dex_file);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000106 return false;
107 }
108 size_t pc_bytes;
109 verifier::RegisterMapFormat format;
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800110 if (pc_bits <= kBitsPerByte) {
Vladimir Markoc7f83202014-01-24 17:55:18 +0000111 format = verifier::kRegMapFormatCompact8;
112 pc_bytes = 1;
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800113 } else if (pc_bits <= kBitsPerByte * 2) {
Vladimir Markoc7f83202014-01-24 17:55:18 +0000114 format = verifier::kRegMapFormatCompact16;
115 pc_bytes = 2;
116 } else {
Andreas Gampe6c170c92014-12-17 14:35:46 -0800117 LOG(WARNING) << "Cannot encode GC map for method with "
118 << (1 << pc_bits) << " instructions (number is rounded up to nearest power of 2): "
119 << PrettyMethod(method_verifier->GetMethodReference().dex_method_index,
120 *method_verifier->GetMethodReference().dex_file);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000121 return false;
122 }
123 size_t table_size = ((pc_bytes + ref_bitmap_bytes) * num_entries) + 4;
124 dex_gc_map_.reserve(table_size);
125 // Write table header.
Mathieu Chartierf8da1962015-06-19 13:55:27 -0700126 dex_gc_map_.push_back(format | ((ref_bitmap_bytes & ~0xFF) >> (kBitsPerByte - kFormatBits)));
Vladimir Markoc7f83202014-01-24 17:55:18 +0000127 dex_gc_map_.push_back(ref_bitmap_bytes & 0xFF);
128 dex_gc_map_.push_back(num_entries & 0xFF);
129 dex_gc_map_.push_back((num_entries >> 8) & 0xFF);
130 // Write table data.
131 const DexFile::CodeItem* code_item = method_verifier->CodeItem();
132 for (size_t i = 0; i < code_item->insns_size_in_code_units_; i++) {
133 if (method_verifier->GetInstructionFlags(i).IsCompileTimeInfoPoint()) {
134 dex_gc_map_.push_back(i & 0xFF);
135 if (pc_bytes == 2) {
136 dex_gc_map_.push_back((i >> 8) & 0xFF);
137 }
138 verifier::RegisterLine* line = method_verifier->GetRegLine(i);
Ian Rogers7b078e82014-09-10 14:44:24 -0700139 line->WriteReferenceBitMap(method_verifier, &dex_gc_map_, ref_bitmap_bytes);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000140 }
141 }
142 DCHECK_EQ(dex_gc_map_.size(), table_size);
143 return true;
144}
145
146void VerifiedMethod::VerifyGcMap(verifier::MethodVerifier* method_verifier,
147 const std::vector<uint8_t>& data) {
148 // Check that for every GC point there is a map entry, there aren't entries for non-GC points,
149 // that the table data is well formed and all references are marked (or not) in the bitmap.
150 verifier::DexPcToReferenceMap map(&data[0]);
Mathieu Chartierf8da1962015-06-19 13:55:27 -0700151 CHECK_EQ(data.size(), map.RawSize()) << map.NumEntries() << " " << map.RegWidth();
Vladimir Markoc7f83202014-01-24 17:55:18 +0000152 size_t map_index = 0;
153 const DexFile::CodeItem* code_item = method_verifier->CodeItem();
154 for (size_t i = 0; i < code_item->insns_size_in_code_units_; i++) {
155 const uint8_t* reg_bitmap = map.FindBitMap(i, false);
156 if (method_verifier->GetInstructionFlags(i).IsCompileTimeInfoPoint()) {
157 DCHECK_LT(map_index, map.NumEntries());
158 DCHECK_EQ(map.GetDexPc(map_index), i);
159 DCHECK_EQ(map.GetBitMap(map_index), reg_bitmap);
160 map_index++;
161 verifier::RegisterLine* line = method_verifier->GetRegLine(i);
162 for (size_t j = 0; j < code_item->registers_size_; j++) {
Ian Rogers7b078e82014-09-10 14:44:24 -0700163 if (line->GetRegisterType(method_verifier, j).IsNonZeroReferenceTypes()) {
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800164 DCHECK_LT(j / kBitsPerByte, map.RegWidth());
165 DCHECK_EQ((reg_bitmap[j / kBitsPerByte] >> (j % kBitsPerByte)) & 1, 1);
166 } else if ((j / kBitsPerByte) < map.RegWidth()) {
167 DCHECK_EQ((reg_bitmap[j / kBitsPerByte] >> (j % kBitsPerByte)) & 1, 0);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000168 } else {
169 // If a register doesn't contain a reference then the bitmap may be shorter than the line.
170 }
171 }
172 } else {
Mathieu Chartier2cebb242015-04-21 16:50:40 -0700173 DCHECK(i >= 65536 || reg_bitmap == nullptr);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000174 }
175 }
176}
177
178void VerifiedMethod::ComputeGcMapSizes(verifier::MethodVerifier* method_verifier,
179 size_t* gc_points, size_t* ref_bitmap_bits,
180 size_t* log2_max_gc_pc) {
181 size_t local_gc_points = 0;
182 size_t max_insn = 0;
183 size_t max_ref_reg = -1;
184 const DexFile::CodeItem* code_item = method_verifier->CodeItem();
185 for (size_t i = 0; i < code_item->insns_size_in_code_units_; i++) {
186 if (method_verifier->GetInstructionFlags(i).IsCompileTimeInfoPoint()) {
187 local_gc_points++;
188 max_insn = i;
189 verifier::RegisterLine* line = method_verifier->GetRegLine(i);
Ian Rogers7b078e82014-09-10 14:44:24 -0700190 max_ref_reg = line->GetMaxNonZeroReferenceReg(method_verifier, max_ref_reg);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000191 }
192 }
193 *gc_points = local_gc_points;
194 *ref_bitmap_bits = max_ref_reg + 1; // If max register is 0 we need 1 bit to encode (ie +1).
195 size_t i = 0;
196 while ((1U << i) <= max_insn) {
197 i++;
198 }
199 *log2_max_gc_pc = i;
200}
201
Mathieu Chartier091d2382015-03-06 10:59:06 -0800202bool VerifiedMethod::GenerateDequickenMap(verifier::MethodVerifier* method_verifier) {
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800203 if (method_verifier->HasFailures()) {
Mathieu Chartier091d2382015-03-06 10:59:06 -0800204 return false;
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800205 }
206 const DexFile::CodeItem* code_item = method_verifier->CodeItem();
207 const uint16_t* insns = code_item->insns_;
208 const Instruction* inst = Instruction::At(insns);
209 const Instruction* end = Instruction::At(insns + code_item->insns_size_in_code_units_);
210 for (; inst < end; inst = inst->Next()) {
211 const bool is_virtual_quick = inst->Opcode() == Instruction::INVOKE_VIRTUAL_QUICK;
212 const bool is_range_quick = inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE_QUICK;
213 if (is_virtual_quick || is_range_quick) {
214 uint32_t dex_pc = inst->GetDexPc(insns);
215 verifier::RegisterLine* line = method_verifier->GetRegLine(dex_pc);
Mathieu Chartiere401d142015-04-22 13:56:20 -0700216 ArtMethod* method =
Mathieu Chartier091d2382015-03-06 10:59:06 -0800217 method_verifier->GetQuickInvokedMethod(inst, line, is_range_quick, true);
218 if (method == nullptr) {
219 // It can be null if the line wasn't verified since it was unreachable.
220 return false;
221 }
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800222 // The verifier must know what the type of the object was or else we would have gotten a
223 // failure. Put the dex method index in the dequicken map since we need this to get number of
224 // arguments in the compiler.
Mathieu Chartiere5f13e52015-02-24 09:37:21 -0800225 dequicken_map_.Put(dex_pc, DexFileReference(method->GetDexFile(),
226 method->GetDexMethodIndex()));
227 } else if (IsInstructionIGetQuickOrIPutQuick(inst->Opcode())) {
228 uint32_t dex_pc = inst->GetDexPc(insns);
229 verifier::RegisterLine* line = method_verifier->GetRegLine(dex_pc);
Mathieu Chartierc7853442015-03-27 14:35:38 -0700230 ArtField* field = method_verifier->GetQuickFieldAccess(inst, line);
Mathieu Chartier091d2382015-03-06 10:59:06 -0800231 if (field == nullptr) {
232 // It can be null if the line wasn't verified since it was unreachable.
233 return false;
234 }
Mathieu Chartiere5f13e52015-02-24 09:37:21 -0800235 // The verifier must know what the type of the field was or else we would have gotten a
236 // failure. Put the dex field index in the dequicken map since we need this for lowering
237 // in the compiler.
238 // TODO: Putting a field index in a method reference is gross.
239 dequicken_map_.Put(dex_pc, DexFileReference(field->GetDexFile(), field->GetDexFieldIndex()));
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800240 }
241 }
Mathieu Chartier091d2382015-03-06 10:59:06 -0800242 return true;
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800243}
244
Vladimir Markoc7f83202014-01-24 17:55:18 +0000245void VerifiedMethod::GenerateDevirtMap(verifier::MethodVerifier* method_verifier) {
246 // It is risky to rely on reg_types for sharpening in cases of soft
247 // verification, we might end up sharpening to a wrong implementation. Just abort.
248 if (method_verifier->HasFailures()) {
249 return;
250 }
251
252 const DexFile::CodeItem* code_item = method_verifier->CodeItem();
253 const uint16_t* insns = code_item->insns_;
254 const Instruction* inst = Instruction::At(insns);
255 const Instruction* end = Instruction::At(insns + code_item->insns_size_in_code_units_);
256
257 for (; inst < end; inst = inst->Next()) {
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800258 const bool is_virtual = inst->Opcode() == Instruction::INVOKE_VIRTUAL ||
259 inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE;
260 const bool is_interface = inst->Opcode() == Instruction::INVOKE_INTERFACE ||
261 inst->Opcode() == Instruction::INVOKE_INTERFACE_RANGE;
Vladimir Markoc7f83202014-01-24 17:55:18 +0000262
263 if (!is_interface && !is_virtual) {
264 continue;
265 }
266 // Get reg type for register holding the reference to the object that will be dispatched upon.
267 uint32_t dex_pc = inst->GetDexPc(insns);
268 verifier::RegisterLine* line = method_verifier->GetRegLine(dex_pc);
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800269 const bool is_range = inst->Opcode() == Instruction::INVOKE_VIRTUAL_RANGE ||
270 inst->Opcode() == Instruction::INVOKE_INTERFACE_RANGE;
Ian Rogersd8f69b02014-09-10 21:43:52 +0000271 const verifier::RegType&
Ian Rogers7b078e82014-09-10 14:44:24 -0700272 reg_type(line->GetRegisterType(method_verifier,
273 is_range ? inst->VRegC_3rc() : inst->VRegC_35c()));
Vladimir Markoc7f83202014-01-24 17:55:18 +0000274
275 if (!reg_type.HasClass()) {
276 // We will compute devirtualization information only when we know the Class of the reg type.
277 continue;
278 }
279 mirror::Class* reg_class = reg_type.GetClass();
280 if (reg_class->IsInterface()) {
281 // We can't devirtualize when the known type of the register is an interface.
282 continue;
283 }
284 if (reg_class->IsAbstract() && !reg_class->IsArrayClass()) {
285 // We can't devirtualize abstract classes except on arrays of abstract classes.
286 continue;
287 }
Mathieu Chartiere401d142015-04-22 13:56:20 -0700288 auto* cl = Runtime::Current()->GetClassLinker();
289 size_t pointer_size = cl->GetImagePointerSize();
290 ArtMethod* abstract_method = method_verifier->GetDexCache()->GetResolvedMethod(
291 is_range ? inst->VRegB_3rc() : inst->VRegB_35c(), pointer_size);
Mathieu Chartier2cebb242015-04-21 16:50:40 -0700292 if (abstract_method == nullptr) {
Vladimir Markoc7f83202014-01-24 17:55:18 +0000293 // If the method is not found in the cache this means that it was never found
294 // by ResolveMethodAndCheckAccess() called when verifying invoke_*.
295 continue;
296 }
297 // Find the concrete method.
Mathieu Chartiere401d142015-04-22 13:56:20 -0700298 ArtMethod* concrete_method = nullptr;
Vladimir Markoc7f83202014-01-24 17:55:18 +0000299 if (is_interface) {
Mathieu Chartiere401d142015-04-22 13:56:20 -0700300 concrete_method = reg_type.GetClass()->FindVirtualMethodForInterface(
301 abstract_method, pointer_size);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000302 }
303 if (is_virtual) {
Mathieu Chartiere401d142015-04-22 13:56:20 -0700304 concrete_method = reg_type.GetClass()->FindVirtualMethodForVirtual(
305 abstract_method, pointer_size);
Vladimir Markoc7f83202014-01-24 17:55:18 +0000306 }
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800307 if (concrete_method == nullptr || concrete_method->IsAbstract()) {
Vladimir Markoc7f83202014-01-24 17:55:18 +0000308 // In cases where concrete_method is not found, or is abstract, continue to the next invoke.
309 continue;
310 }
311 if (reg_type.IsPreciseReference() || concrete_method->IsFinal() ||
312 concrete_method->GetDeclaringClass()->IsFinal()) {
313 // If we knew exactly the class being dispatched upon, or if the target method cannot be
314 // overridden record the target to be used in the compiler driver.
Mathieu Chartier36b58f52014-12-10 12:06:45 -0800315 devirt_map_.Put(dex_pc, concrete_method->ToMethodReference());
Vladimir Markoc7f83202014-01-24 17:55:18 +0000316 }
317 }
318}
319
320void VerifiedMethod::GenerateSafeCastSet(verifier::MethodVerifier* method_verifier) {
321 /*
322 * Walks over the method code and adds any cast instructions in which
323 * the type cast is implicit to a set, which is used in the code generation
324 * to elide these casts.
325 */
326 if (method_verifier->HasFailures()) {
327 return;
328 }
329 const DexFile::CodeItem* code_item = method_verifier->CodeItem();
330 const Instruction* inst = Instruction::At(code_item->insns_);
331 const Instruction* end = Instruction::At(code_item->insns_ +
332 code_item->insns_size_in_code_units_);
333
334 for (; inst < end; inst = inst->Next()) {
335 Instruction::Code code = inst->Opcode();
336 if ((code == Instruction::CHECK_CAST) || (code == Instruction::APUT_OBJECT)) {
337 uint32_t dex_pc = inst->GetDexPc(code_item->insns_);
Stephen Kyle40d35182014-10-03 13:47:56 +0100338 if (!method_verifier->GetInstructionFlags(dex_pc).IsVisited()) {
339 // Do not attempt to quicken this instruction, it's unreachable anyway.
340 continue;
341 }
Vladimir Markoc7f83202014-01-24 17:55:18 +0000342 const verifier::RegisterLine* line = method_verifier->GetRegLine(dex_pc);
343 bool is_safe_cast = false;
344 if (code == Instruction::CHECK_CAST) {
Ian Rogers7b078e82014-09-10 14:44:24 -0700345 const verifier::RegType& reg_type(line->GetRegisterType(method_verifier,
346 inst->VRegA_21c()));
Ian Rogersd8f69b02014-09-10 21:43:52 +0000347 const verifier::RegType& cast_type =
Vladimir Markoc7f83202014-01-24 17:55:18 +0000348 method_verifier->ResolveCheckedClass(inst->VRegB_21c());
349 is_safe_cast = cast_type.IsStrictlyAssignableFrom(reg_type);
350 } else {
Ian Rogers7b078e82014-09-10 14:44:24 -0700351 const verifier::RegType& array_type(line->GetRegisterType(method_verifier,
352 inst->VRegB_23x()));
Vladimir Markoc7f83202014-01-24 17:55:18 +0000353 // We only know its safe to assign to an array if the array type is precise. For example,
354 // an Object[] can have any type of object stored in it, but it may also be assigned a
355 // String[] in which case the stores need to be of Strings.
356 if (array_type.IsPreciseReference()) {
Ian Rogers7b078e82014-09-10 14:44:24 -0700357 const verifier::RegType& value_type(line->GetRegisterType(method_verifier,
358 inst->VRegA_23x()));
Ian Rogersd8f69b02014-09-10 21:43:52 +0000359 const verifier::RegType& component_type = method_verifier->GetRegTypeCache()
Vladimir Markoc7f83202014-01-24 17:55:18 +0000360 ->GetComponentType(array_type, method_verifier->GetClassLoader());
361 is_safe_cast = component_type.IsStrictlyAssignableFrom(value_type);
362 }
363 }
364 if (is_safe_cast) {
365 // Verify ordering for push_back() to the sorted vector.
366 DCHECK(safe_cast_set_.empty() || safe_cast_set_.back() < dex_pc);
367 safe_cast_set_.push_back(dex_pc);
368 }
369 }
370 }
371}
372
373} // namespace art